Re: Value doco page written

2011-03-30 Thread Pierre-Arnaud Marcelot
Hi Emmanuel, Doco looks fine to me. I think the naming of two methods could be improved for readability and coherence with standard Java and our own coding standards: - boolean isHR(); --- boolean isHumanReadable(); - boolean instanceOf( AttributeType attributeType ); --- boolean isInstanceOf(

Re: Some few classes that are probably stored at the right place...

2011-03-30 Thread Pierre-Arnaud Marcelot
Hi Emmanuel, +1 SearchScope could be in 'org.apache.directory.shared.ldap.model.message'. LdapURL could in 'org.apache.directory.shared.ldap.model.url'. Shouldn't we also rename 'LdapURL' as 'LdapUrl' to match other class names (like Dn, Rdn, Oid, etc.)? Regards, Pierre-Arnaud On 30 mars

Re: Pb with mvn eclipse:eclipse and -Dintegration

2011-03-30 Thread Pierre-Arnaud Marcelot
Did anyone had the chance to test that and confirm site generation is ok? Thanks, Pierre-Arnaud On 18 mars 2011, at 15:53, Pierre-Arnaud Marcelot wrote: Funny thing... I removed the 'integration' profile and regenerated the site again (with 'shared-integ' projet added back as a module)

Re: Some few classes that are probably stored at the right place...

2011-03-30 Thread Emmanuel Lecharny
On 3/30/11 11:20 AM, Pierre-Arnaud Marcelot wrote: Hi Emmanuel, +1 SearchScope could be in 'org.apache.directory.shared.ldap.model.message'. LdapURL could in 'org.apache.directory.shared.ldap.model.url'. Shouldn't we also rename 'LdapURL' as 'LdapUrl' to match other class names (like Dn,

Re: Some few classes that are probably stored at the right place...

2011-03-30 Thread Alex Karasulu
On Wed, Mar 30, 2011 at 12:20 PM, Pierre-Arnaud Marcelot p...@marcelot.netwrote: Hi Emmanuel, +1 SearchScope could be in 'org.apache.directory.shared.ldap.model.message'. LdapURL could in 'org.apache.directory.shared.ldap.model.url'. Shouldn't we also rename 'LdapURL' as 'LdapUrl' to

Re: Filter parsing and values

2011-03-30 Thread Alex Karasulu
On Wed, Mar 30, 2011 at 1:35 AM, Emmanuel Lecharny elecha...@gmail.comwrote: Hi guys, I'm facing an interesting issue. When we parse a filter, we build a Value which is a BinaryValue, even if the attribute is H/R. The problem is that we have to provide a getString() method which translates

Re: Some few classes that are probably stored at the right place...

2011-03-30 Thread Pierre-Arnaud Marcelot
Hi Alex, On 30 mars 2011, at 14:24, Alex Karasulu wrote: On Wed, Mar 30, 2011 at 12:20 PM, Pierre-Arnaud Marcelot p...@marcelot.net wrote: Hi Emmanuel, +1 SearchScope could be in 'org.apache.directory.shared.ldap.model.message'. LdapURL could in

Re: Filter parsing and values

2011-03-30 Thread Emmanuel Lécharny
On 3/30/11 3:01 PM, Alex Karasulu wrote: On Wed, Mar 30, 2011 at 1:35 AM, Emmanuel Lecharnyelecha...@gmail.comwrote: Hi guys, I'm facing an interesting issue. When we parse a filter, we build a Value which is a BinaryValue, even if the attribute is H/R. The problem is that we have to provide

Renaming EntryAttribute to Attribute ?

2011-03-30 Thread Emmanuel Lecharny
Hi guys, when I initially started to write the EntryAttribute class, I picked this name to avoid a confusion with the JNDI Attribute class. bck 2 years ago, it was important, because we had a hell lot of JNDI code all over the shared and server code. Mixing both name would have been a

Re: Renaming EntryAttribute to Attribute ?

2011-03-30 Thread Kiran Ayyagari
On Wed, Mar 30, 2011 at 7:51 PM, Emmanuel Lecharny elecha...@gmail.com wrote: Hi guys, when I initially started to write the EntryAttribute class, I picked this name to avoid a confusion with the JNDI Attribute class. bck 2 years ago, it was important, because we had a hell lot of JNDI code

Re: Renaming EntryAttribute to Attribute ?

2011-03-30 Thread Emmanuel Lecharny
On 3/30/11 4:35 PM, Kiran Ayyagari wrote: On Wed, Mar 30, 2011 at 7:51 PM, Emmanuel Lecharnyelecha...@gmail.com wrote: Hi guys, when I initially started to write the EntryAttribute class, I picked this name to avoid a confusion with the JNDI Attribute class. bck 2 years ago, it was important,

Re: Renaming EntryAttribute to Attribute ?

2011-03-30 Thread Alex Karasulu
On Wed, Mar 30, 2011 at 5:21 PM, Emmanuel Lecharny elecha...@gmail.comwrote: Now that we have been able to get rid of most of the JNDI calls, it might be a good idea to move the name to use Attribute. wdyt ? +1

Re: Renaming EntryAttribute to Attribute ?

2011-03-30 Thread Alex Karasulu
On Wed, Mar 30, 2011 at 5:26 PM, Pierre-Arnaud Marcelot p...@marcelot.netwrote: Hi Emmanuel, Makes totally sense to me. It seems more obvious than EntryAttribute. Alternative thought: we could also go with LdapEntry which is pretty explicit and commonly used in language. Best, Alex

Re: Some few classes that are probably stored at the right place...

2011-03-30 Thread Alex Karasulu
On Wed, Mar 30, 2011 at 4:50 PM, Pierre-Arnaud Marcelot p...@marcelot.netwrote: Hi Alex, On 30 mars 2011, at 14:24, Alex Karasulu wrote: On Wed, Mar 30, 2011 at 12:20 PM, Pierre-Arnaud Marcelot p...@marcelot.netwrote: Hi Emmanuel, +1 SearchScope could be in

Re: Can't seem to find shared 1.0.0-M2 release

2011-03-30 Thread Stefan Seelmann
Hi Alex, they are there, the artifacts just have other names now, e.g. http://repo2.maven.org/maven2/org/apache/directory/shared/shared-ldap-model/ Kind Regards Stefan On Wed, Mar 30, 2011 at 10:02 PM, Alex Karasulu akaras...@apache.org wrote: Hi guys, I cannot seem to find the M2 jars on the