[VOTE] Release of LDAP API 1.0.0-M25

2014-11-06 Thread Emmanuel Lécharny
Hi, This is a vote for the 25th milestone of the 1.0.0 LDAP API/Shared, 1.0.0-M25. It's a bug fix release. It contains a few bug fixes, and some new features and a better Ldap Connection Pool : Bugs * DIRAPI-137 https://issues.apache.org/jira/browse/DIRAPI-137 Add Control support for RFC

[Fortress] Code smell...

2014-11-06 Thread Emmanuel Lécharny
Hi Shawn, there is one method in CommandLineInterpreter, printPermission, which contains a line of code that I found fishy : LOG.info(type +KEY + ++ctr + [ + key + ]); Note the ++ctr here. That means if we remove the LOG, the ctr counter will not be incremented. Do you

[jira] [Commented] (FC-42) Avoid pulling a new connection from the LDAP connection pool

2014-11-06 Thread Emmanuel Lecharny (JIRA)
[ https://issues.apache.org/jira/browse/FC-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14200639#comment-14200639 ] Emmanuel Lecharny commented on FC-42: - The connection is not anymore validated nor

[Fortress] About xxxP and xxxDAO classes

2014-11-06 Thread Emmanuel Lécharny
Hi, we discussed in FC-42 the opportunity of using a shared ldapConnection accross many operations. Now that the pool does not validate or re-bind teh connection when we are done with it, the need to share the connection is less critical. Although I wonder if it's still a good idea to have two

[jira] [Commented] (DIRAPI-206) BindRequest logs exception on valid call to setter

2014-11-06 Thread Peter Becker (JIRA)
[ https://issues.apache.org/jira/browse/DIRAPI-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14200968#comment-14200968 ] Peter Becker commented on DIRAPI-206: - The solution still breaks the rule of using

Re: [Fortress] Code smell...

2014-11-06 Thread Shawn McKinney
That method logs the contents of a permission (within a collection) so disabling the info logger renders all output invisible which makes the counter useless anyway. I am fine with moving it outside of the log statement though. On 11/06/2014 10:37 AM, Emmanuel Lécharny wrote: Hi Shawn,

Re: [VOTE] Release of LDAP API 1.0.0-M25

2014-11-06 Thread Lucas Theisen
I did a pull around 10 pm GMT, and was unable to build successfully. Actually, the shared project did build, but the apacheds did not so I was unable to run the integration test. I think the dependency versions are out of sync. I will try again tomorrow. Lucas On Nov 6, 2014 11:16 AM, Emmanuel

[jira] [Commented] (DIRAPI-206) BindRequest logs exception on valid call to setter

2014-11-06 Thread Peter Becker (JIRA)
[ https://issues.apache.org/jira/browse/DIRAPI-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201210#comment-14201210 ] Peter Becker commented on DIRAPI-206: - I'm not a big fan of Microsoft technologies,

Re: [VOTE] Release of LDAP API 1.0.0-M25

2014-11-06 Thread Kiran Ayyagari
you need to manually update the API version in apacheds to build the trunk apacheds with M25 On Fri, Nov 7, 2014 at 7:26 AM, Lucas Theisen lucasthei...@pastdev.com wrote: I did a pull around 10 pm GMT, and was unable to build successfully. Actually, the shared project did build, but the

[jira] [Commented] (DIRAPI-206) BindRequest logs exception on valid call to setter

2014-11-06 Thread Emmanuel Lecharny (JIRA)
[ https://issues.apache.org/jira/browse/DIRAPI-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201273#comment-14201273 ] Emmanuel Lecharny commented on DIRAPI-206: -- The mistake we have made was to keep

[jira] [Commented] (DIRAPI-206) BindRequest logs exception on valid call to setter

2014-11-06 Thread Kiran Ayyagari (JIRA)
[ https://issues.apache.org/jira/browse/DIRAPI-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201269#comment-14201269 ] Kiran Ayyagari commented on DIRAPI-206: --- No, it wasn't snarky (IMHO email/text is

Cancel: [VOTE] Release of LDAP API 1.0.0-M25

2014-11-06 Thread Emmanuel Lécharny
Hi, I therefore cancel the vote for API 1.0.0-M25, there is a bug in the way we deal with the sort control. Lucas finding is correct, it breaks server-integ. The reason is that the sort control grammar is incorrect : one transition (from orderingRule to reverseOrder ) is made mandatory, when teh

[jira] [Commented] (DIRAPI-206) BindRequest logs exception on valid call to setter

2014-11-06 Thread Peter Becker (JIRA)
[ https://issues.apache.org/jira/browse/DIRAPI-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201573#comment-14201573 ] Peter Becker commented on DIRAPI-206: - Emmanuel: that seems sensible assuming the