[jira] [Commented] (DIRKRB-113) Add tests for Kerberos message codecs

[ https://issues.apache.org/jira/browse/DIRKRB-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276622#comment-14276622 ] Kiran Ayyagari commented on DIRKRB-113: --- I see that all these tests were written bas

[jira] [Commented] (DIRKRB-114) Add tests for AS-REQ message codec

[ https://issues.apache.org/jira/browse/DIRKRB-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276615#comment-14276615 ] Kiran Ayyagari commented on DIRKRB-114: --- I am curious on why a binary file is used t

RE: Could you please review patches in Directory Kerberos?

Thanks Lin. Could anyone help with the review? I would but am only able to do it quite some time late. Thanks. Regards, Kai From: Chen, Lin1 [mailto:lin1.c...@intel.com] Sent: Wednesday, January 14, 2015 2:54 PM To: dev@directory.apache.org Subject: Could you please review patches in Directory

Could you please review patches in Directory Kerberos?

Hi all, I attached some patches to DIRKRB-114 , DIRKRB-115, DIRKRB-116 and DIRKRB-117. The co

[jira] [Commented] (DIRKRB-137) Adding maven rat plugin

[ https://issues.apache.org/jira/browse/DIRKRB-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276560#comment-14276560 ] Kai Zheng commented on DIRKRB-137: -- Hi Emmanuel, I understand we should add the rat che

[jira] [Updated] (DIRKRB-117) Add tests for TGS-REP message codec

[ https://issues.apache.org/jira/browse/DIRKRB-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lin Chen updated DIRKRB-117: Attachment: tgsrep.token > Add tests for TGS-REP message codec > --- > >

[jira] [Updated] (DIRKRB-117) Add tests for TGS-REP message codec

[ https://issues.apache.org/jira/browse/DIRKRB-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lin Chen updated DIRKRB-117: Attachment: DIRKRB-117_v1.patch > Add tests for TGS-REP message codec > ---

[jira] [Updated] (DIRKRB-116) Add tests for TGS-REQ message codec

[ https://issues.apache.org/jira/browse/DIRKRB-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lin Chen updated DIRKRB-116: Attachment: tgsreq.token > Add tests for TGS-REQ message codec > --- > >

[jira] [Updated] (DIRKRB-116) Add tests for TGS-REQ message codec

[ https://issues.apache.org/jira/browse/DIRKRB-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lin Chen updated DIRKRB-116: Attachment: DIRKRB-116_v1.patch > Add tests for TGS-REQ message codec > ---

[jira] [Updated] (DIRKRB-115) Add tests for AS-REP message codec

[ https://issues.apache.org/jira/browse/DIRKRB-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lin Chen updated DIRKRB-115: Attachment: asrep.token > Add tests for AS-REP message codec > -- > >

[jira] [Updated] (DIRKRB-114) Add tests for AS-REQ message codec

[ https://issues.apache.org/jira/browse/DIRKRB-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lin Chen updated DIRKRB-114: Attachment: asreq.token > Add tests for AS-REQ message codec > -- > >

[jira] [Updated] (DIRKRB-115) Add tests for AS-REP message codec

[ https://issues.apache.org/jira/browse/DIRKRB-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lin Chen updated DIRKRB-115: Attachment: DIRKRB-115_v1.patch > Add tests for AS-REP message codec > -- >

[jira] [Updated] (DIRKRB-114) Add tests for AS-REQ message codec

[ https://issues.apache.org/jira/browse/DIRKRB-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lin Chen updated DIRKRB-114: Attachment: DIRKRB-114_v1.patch > Add tests for AS-REQ message codec > -- >

RE: [Kerberos] re-organizing the module structure

Appreciate if we could accelerate on this. It makes a lot sense to make the project comfortable for all of us. Thanks! Regards, Kai From: Kiran Ayyagari [mailto:kayyag...@apache.org] Sent: Wednesday, January 14, 2015 9:18 AM To: Apache Directory Developers List Subject: Re: [Kerberos] re-organiz

RE: [Kerberos] Code style

I appreciate the thoughts. Many new projects use standard Java code style, requiring the only setting of spaces for tab. Converting isn’t easy (as for now we have so many tasks to handle with), and we also might wish to avoid mess in the new project. Regards, Kai From: Lucas Theisen [mailto:lu

Re: [Kerberos] re-organizing the module structure

On Wed, Jan 14, 2015 at 9:05 AM, Zheng, Kai wrote: > Hi Kiran, > > > > Thanks for taking care of this! > > > > Looks like we could re-organize the project much better if we get the > naming issue resolved first. For example, if Kerby is used, maybe > ‘kerby-asn1’ would be a choice, which allows

RE: [Kerberos] re-organizing the module structure

Hi Kiran, Thanks for taking care of this! Looks like we could re-organize the project much better if we get the naming issue resolved first. For example, if Kerby is used, maybe ‘kerby-asn1’ would be a choice, which allows it to be used in other contexts/projects without worrying about polluti

[Kerberos] re-organizing the module structure

I suggest we reorganize the modules under directory-kerberos. All the modules under 'contrib' are essential components hence must be moved to the project root directory. Add a new folder 'mech' or 'mechanisms' and move various auth mechanisms like 'pkix', 'token' etc there. Move 'haox-kdc/kdc-se

[jira] [Assigned] (DIRSTUDIO-1004) Add the missing configuration elements

[ https://issues.apache.org/jira/browse/DIRSTUDIO-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emmanuel Lecharny reassigned DIRSTUDIO-1004: Assignee: Emmanuel Lecharny > Add the missing configuration elements >

[jira] [Commented] (DIR-311) Improvement to How to Contribute page

[ https://issues.apache.org/jira/browse/DIR-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275169#comment-14275169 ] Pierre Smits commented on DIR-311: -- This issue can be closed, as it has been implemented. >

Re: [Kerberos] Code style

I will admit, I still have trouble using the ApacheDS code style. I prefer standard java code style. That said, consistency across a project is pretty important. Especially for new contributors. Plus, java autoformatters are pretty good. I use eclipse to do so on all my personal projects and h

[jira] [Commented] (DIRKRB-137) Adding maven rat plugin

[ https://issues.apache.org/jira/browse/DIRKRB-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275018#comment-14275018 ] Emmanuel Lecharny commented on DIRKRB-137: -- No. You must set up rat configuration

Re: [kerby/haox] Dependencies updates needed

On Tue, Jan 13, 2015 at 5:17 PM, Emmanuel Lécharny wrote: > Le 13/01/15 09:30, Kiran Ayyagari a écrit : > > On Tue, Jan 13, 2015 at 4:01 PM, Zheng, Kai wrote: > > > I don't like 4 spaces for XML files, it's quickly too wide, I use 2 > >> spaces. > >> Agree, let's follow this. > >> > Re

[jira] [Commented] (DIRKRB-137) Adding maven rat plugin

[ https://issues.apache.org/jira/browse/DIRKRB-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274955#comment-14274955 ] Lin Chen commented on DIRKRB-137: - Thanks Emmanuel's instruction. The v2 patch attached.

Re: [kerby/haox] Dependencies updates needed

Le 13/01/15 09:30, Kiran Ayyagari a écrit : > On Tue, Jan 13, 2015 at 4:01 PM, Zheng, Kai wrote: > I don't like 4 spaces for XML files, it's quickly too wide, I use 2 >> spaces. >> Agree, let's follow this. >> Regarding teh Java code, I suggest we keep what you have (likely Java >> code

[jira] [Updated] (DIRKRB-137) Adding maven rat plugin

[ https://issues.apache.org/jira/browse/DIRKRB-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lin Chen updated DIRKRB-137: Attachment: DIRKRB-137_v2.patch > Adding maven rat plugin > --- > > Key:

[jira] [Commented] (DIRKRB-137) Adding maven rat plugin

[ https://issues.apache.org/jira/browse/DIRKRB-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274913#comment-14274913 ] Emmanuel Lecharny commented on DIRKRB-137: -- using {{**/c.txt}} should do the tric

[Kerberos] Code style

Hi guys ! as everybody knows, we have accepted the code Kerberos donation recently. This code base uses a different code format than the one we are using (they are using a Java standard code format). As much as I like our code format, as this is a separate code base, I wonder if it makes sense to

Re: [kerby/haox] Dependencies updates needed

On Tue, Jan 13, 2015 at 4:01 PM, Zheng, Kai wrote: > >> I don't like 4 spaces for XML files, it's quickly too wide, I use 2 > spaces. > Agree, let's follow this. > > >> Regarding teh Java code, I suggest we keep what you have (likely Java > code convention), we can vote later on keep it or moving

RE: [kerby/haox] Dependencies updates needed

>> I don't like 4 spaces for XML files, it's quickly too wide, I use 2 spaces. Agree, let's follow this. >> Regarding teh Java code, I suggest we keep what you have (likely Java code >> convention), we can vote later on keep it or moving globally to another >> convention. I do like the current o