[jira] [Resolved] (DIRAPI-333) Switch to Junit 5

2019-05-05 Thread Emmanuel Lecharny (JIRA)
[ https://issues.apache.org/jira/browse/DIRAPI-333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emmanuel Lecharny resolved DIRAPI-333. -- Resolution: Fixed Done with commit e8a4e86 > Switch to Junit 5 > - > >

Re: JUNIT 5 migration

2019-05-05 Thread Emmanuel Lécharny
On 05/05/2019 12:30, Stefan Seelmann wrote: On 5/5/19 9:50 AM, Emmanuel Lécharny wrote: I'm almost done with LDAP API junit 5 migration, with only one burden : the multithreaded Rule that has to be ported. Junit 5 does not support @Rule, there is a new mechanism called extensions [1]. I still ha

Re: JUNIT 5 migration

2019-05-05 Thread Stefan Seelmann
On 5/5/19 9:50 AM, Emmanuel Lécharny wrote: > I'm almost done with LDAP API junit 5 migration, with only one burden : > the multithreaded Rule that has to be ported. Junit 5 does not support > @Rule, there is a new mechanism called extensions [1]. I still have to > study it. The other used rule is

[GitHub] [directory-ldap-api] seelmann commented on issue #11: Introduced maven wrapper and simple travisci build script

2019-05-05 Thread GitBox
seelmann commented on issue #11: Introduced maven wrapper and simple travisci build script URL: https://github.com/apache/directory-ldap-api/pull/11#issuecomment-489412739 Nice to introduce the possibility to run a Travis CI build. I just wonder if we should introduce the maven wrapper.

[GitHub] [directory-ldap-api] seelmann commented on issue #10: DIRAPI-341 respecting strict/relaxed settings from SchemaLoader

2019-05-05 Thread GitBox
seelmann commented on issue #10: DIRAPI-341 respecting strict/relaxed settings from SchemaLoader URL: https://github.com/apache/directory-ldap-api/pull/10#issuecomment-489412029 LGTM. I additionally run the integration tests https://github.com/apache/directory-server/tree/master/ldap-clien

JUNIT 5 migration

2019-05-05 Thread Emmanuel Lécharny
Hi, I'm almost done with LDAP API junit 5 migration, with only one burden : the multithreaded Rule that has to be ported. Junit 5 does not support @Rule, there is a new mechanism called extensions [1]. I still have to study it. The other used rule is the one using temporary folder creation.