[ https://issues.apache.org/jira/browse/DIRSERVER-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17583941#comment-17583941 ]
Emmanuel Lécharny edited comment on DIRSERVER-1589 at 9/3/22 8:01 AM: ---------------------------------------------------------------------- It's now 26 instances: {code} <fixed> ./bulkloader/src/main/java/org/apache/directory/mavibot/btree/FastLdifReader.java: ne.printStackTrace(); ./bulkloader/src/main/java/org/apache/directory/mavibot/btree/MavibotPartitionBuilder.java: e.printStackTrace(); ./bulkloader/src/main/java/org/apache/directory/mavibot/btree/MavibotPartitionBuilder.java: e.printStackTrace(); ./bulkloader/src/main/java/org/apache/directory/mavibot/btree/MavibotPartitionBuilder.java: e.printStackTrace(); ./bulkloader/src/main/java/org/apache/directory/mavibot/btree/MavibotPartitionBuilder.java: e.printStackTrace(); ./bulkloader/src/main/java/org/apache/directory/mavibot/btree/MavibotPartitionBuilder.java: e.printStackTrace(); ./bulkloader/src/main/java/org/apache/directory/mavibot/btree/MavibotPartitionBuilder.java: e.printStackTrace(); ./bulkloader/src/main/java/org/apache/directory/mavibot/btree/MavibotPartitionBuilder.java: e.printStackTrace(); ./bulkloader/src/main/java/org/apache/directory/mavibot/btree/MavibotPartitionBuilder.java: e.printStackTrace(); ./bulkloader/src/main/java/org/apache/directory/mavibot/btree/MavibotPartitionBuilder.java: e.printStackTrace(); ./syncrepl/src/main/java/org/apache/directory/server/syncrepl/EntryInjector.java: e.printStackTrace(); ./syncrepl/src/main/java/org/apache/directory/server/syncrepl/EntryInjector.java: e.printStackTrace(); ./syncrepl/src/main/java/org/apache/directory/server/syncrepl/EntryInjector.java: e.printStackTrace(); ./syncrepl/src/main/java/org/apache/directory/server/syncrepl/EntryInjector.java: e.printStackTrace(); ./syncrepl/src/main/java/org/apache/directory/server/syncrepl/EntryInjector.java: e.printStackTrace(); ./syncrepl/src/main/java/org/apache/directory/server/syncrepl/SyncreplRunnerUI.java: e.printStackTrace(); ./syncrepl/src/main/java/org/apache/directory/server/syncrepl/SyncreplRunnerUI.java: e.printStackTrace(); ./protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/protocol/DhcpProtocolHandler.java: cause.printStackTrace( System.out ); ./kerberos-codec/src/main/java/org/apache/directory/server/kerberos/shared/crypto/encryption/ArcFourHmacMd5Encryption.java: nsae.printStackTrace(); ./kerberos-codec/src/main/java/org/apache/directory/server/kerberos/shared/crypto/encryption/DesStringToKey.java: nsae.printStackTrace(); ./kerberos-codec/src/main/java/org/apache/directory/server/kerberos/shared/crypto/checksum/HmacMd5Checksum.java: nsae.printStackTrace(); ./benchmarks/src/main/java/org/apache/directory/server/benchmarks/BogusBenchmark.java: e.printStackTrace(); ./server-annotations/src/main/java/org/apache/directory/server/factory/ServerAnnotationProcessor.java: e.printStackTrace(); ./core-avl/src/main/java/org/apache/directory/server/core/avltree/AvlTreeMarshaller.java: e.printStackTrace(); <fixed> ./core-avl/src/main/java/org/apache/directory/server/core/avltree/ArrayMarshaller.java: e.printStackTrace(); ./service/src/main/java/org/apache/directory/server/ApacheDsService.java: e.printStackTrace(); {code} was (Author: elecharny): It's now 26 instances: {code} ./bulkloader/src/main/java/org/apache/directory/mavibot/btree/FastLdifReader.java: ne.printStackTrace(); ./bulkloader/src/main/java/org/apache/directory/mavibot/btree/MavibotPartitionBuilder.java: e.printStackTrace(); ./bulkloader/src/main/java/org/apache/directory/mavibot/btree/MavibotPartitionBuilder.java: e.printStackTrace(); ./bulkloader/src/main/java/org/apache/directory/mavibot/btree/MavibotPartitionBuilder.java: e.printStackTrace(); ./bulkloader/src/main/java/org/apache/directory/mavibot/btree/MavibotPartitionBuilder.java: e.printStackTrace(); ./bulkloader/src/main/java/org/apache/directory/mavibot/btree/MavibotPartitionBuilder.java: e.printStackTrace(); ./bulkloader/src/main/java/org/apache/directory/mavibot/btree/MavibotPartitionBuilder.java: e.printStackTrace(); ./bulkloader/src/main/java/org/apache/directory/mavibot/btree/MavibotPartitionBuilder.java: e.printStackTrace(); ./bulkloader/src/main/java/org/apache/directory/mavibot/btree/MavibotPartitionBuilder.java: e.printStackTrace(); ./bulkloader/src/main/java/org/apache/directory/mavibot/btree/MavibotPartitionBuilder.java: e.printStackTrace(); ./syncrepl/src/main/java/org/apache/directory/server/syncrepl/EntryInjector.java: e.printStackTrace(); ./syncrepl/src/main/java/org/apache/directory/server/syncrepl/EntryInjector.java: e.printStackTrace(); ./syncrepl/src/main/java/org/apache/directory/server/syncrepl/EntryInjector.java: e.printStackTrace(); ./syncrepl/src/main/java/org/apache/directory/server/syncrepl/EntryInjector.java: e.printStackTrace(); ./syncrepl/src/main/java/org/apache/directory/server/syncrepl/EntryInjector.java: e.printStackTrace(); ./syncrepl/src/main/java/org/apache/directory/server/syncrepl/SyncreplRunnerUI.java: e.printStackTrace(); ./syncrepl/src/main/java/org/apache/directory/server/syncrepl/SyncreplRunnerUI.java: e.printStackTrace(); ./protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/protocol/DhcpProtocolHandler.java: cause.printStackTrace( System.out ); ./kerberos-codec/src/main/java/org/apache/directory/server/kerberos/shared/crypto/encryption/ArcFourHmacMd5Encryption.java: nsae.printStackTrace(); ./kerberos-codec/src/main/java/org/apache/directory/server/kerberos/shared/crypto/encryption/DesStringToKey.java: nsae.printStackTrace(); ./kerberos-codec/src/main/java/org/apache/directory/server/kerberos/shared/crypto/checksum/HmacMd5Checksum.java: nsae.printStackTrace(); ./benchmarks/src/main/java/org/apache/directory/server/benchmarks/BogusBenchmark.java: e.printStackTrace(); ./server-annotations/src/main/java/org/apache/directory/server/factory/ServerAnnotationProcessor.java: e.printStackTrace(); ./core-avl/src/main/java/org/apache/directory/server/core/avltree/AvlTreeMarshaller.java: e.printStackTrace(); ./core-avl/src/main/java/org/apache/directory/server/core/avltree/ArrayMarshaller.java: e.printStackTrace(); ./service/src/main/java/org/apache/directory/server/ApacheDsService.java: e.printStackTrace(); {code} > Replace the printStacktrace calls by some decent loging > ------------------------------------------------------- > > Key: DIRSERVER-1589 > URL: https://issues.apache.org/jira/browse/DIRSERVER-1589 > Project: Directory ApacheDS > Issue Type: Task > Components: code quality > Affects Versions: 1.5.7 > Reporter: Emmanuel Lécharny > Priority: Major > Fix For: 2.0.0-RC2 > > > We have many printStackTrace calls in the code, some in the tests, some in > the code. We have to review all those printStackTraces and replace them with > some logging, or even remove them (some were adding in order to help > debugging) -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org