Re: [PR] Move attribute and etag logic into Repository [directory-scimple]

2023-11-15 Thread via GitHub
bdemers commented on PR #411: URL: https://github.com/apache/directory-scimple/pull/411#issuecomment-1812909404 > However, can we get some better comments/documentation about what, specifically, about the incoming PUT or PATCH requests determines whether the `update()` or `patch()` flows a

Re: [PR] Move attribute and etag logic into Repository [directory-scimple]

2023-11-15 Thread via GitHub
bdemers commented on code in PR #411: URL: https://github.com/apache/directory-scimple/pull/411#discussion_r1394463027 ## scim-server/src/main/java/org/apache/directory/scim/server/rest/BaseResourceTypeResourceImpl.java: ## @@ -382,35 +358,51 @@ private ScimException notFoundExc

[jira] [Resolved] (DIRAPI-396) Additional loading of a schema not complete

2023-11-15 Thread Jira
[ https://issues.apache.org/jira/browse/DIRAPI-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emmanuel Lécharny resolved DIRAPI-396. -- Resolution: Not A Problem It just needed some more explaination > Additional loading o

Re: [PR] Move attribute and etag logic into Repository [directory-scimple]

2023-11-15 Thread via GitHub
joshuapsteele commented on code in PR #411: URL: https://github.com/apache/directory-scimple/pull/411#discussion_r1394096752 ## scim-server/src/main/java/org/apache/directory/scim/server/rest/BaseResourceTypeResourceImpl.java: ## @@ -382,35 +358,51 @@ private ScimException notFo

Re: [PR] Move attribute and etag logic into Repository [directory-scimple]

2023-11-15 Thread via GitHub
joshuapsteele commented on code in PR #411: URL: https://github.com/apache/directory-scimple/pull/411#discussion_r1394093329 ## scim-core/src/main/java/org/apache/directory/scim/core/repository/Repository.java: ## @@ -60,14 +63,31 @@ public interface Repository { /** * Al

[jira] [Commented] (DIRAPI-396) Additional loading of a schema not complete

2023-11-15 Thread Thomas Gaebler (Jira)
[ https://issues.apache.org/jira/browse/DIRAPI-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786254#comment-17786254 ] Thomas Gaebler commented on DIRAPI-396: --- It works. Many thanks for the quick reply.