Code is never executed

2010-06-04 Thread Felix Knecht
This will always match for the else clause - we now the attributeType is null (line 1469). Probably dead code? http://people.apache.org/~felixk/shared-docs/xref/org/apache/directory/shared/ldap/entry/DefaultEntryAttribute.html#1475

Re: Code is never executed

2010-06-04 Thread Emmanuel Lecharny
On 6/4/10 4:14 PM, Felix Knecht wrote: This will always match for the else clause - we now the attributeType is null (line 1469). Probably dead code? http://people.apache.org/~felixk/shared-docs/xref/org/apache/directory/shared/ldap/entry/DefaultEntryAttribute.html#1475 Dohhh ! Good catch

Re: Code is never executed

2010-06-04 Thread Felix Knecht
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/04/10 16:32, Emmanuel Lecharny wrote: On 6/4/10 4:14 PM, Felix Knecht wrote: This will always match for the else clause - we now the attributeType is null (line 1469). Probably dead code?

Re: Code is never executed

2010-06-04 Thread Emmanuel Lecharny
On 6/4/10 4:40 PM, Felix Knecht wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/04/10 16:32, Emmanuel Lecharny wrote: On 6/4/10 4:14 PM, Felix Knecht wrote: This will always match for the else clause - we now the attributeType is null (line 1469). Probably dead code?

Re: Code is never executed

2010-06-04 Thread Felix Knecht
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I *do* look at the reports, but not as frenquently as you do. Probably because I consider that we have many other serious issues to fix in the server, and I wrongly assume that they are more important than the one you are pointing out. I didn't

Re: Code is never executed

2010-06-04 Thread Emmanuel Lecharny
On 6/4/10 5:09 PM, Felix Knecht wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I *do* look at the reports, but not as frenquently as you do. Probably because I consider that we have many other serious issues to fix in the server, and I wrongly assume that they are more important