RE: [kerby] ASN1 Quick review

2015-12-24 Thread Zheng, Kai
-Original Message- From: Emmanuel Lécharny [mailto:elecha...@gmail.com] Sent: Thursday, December 24, 2015 1:29 AM To: Apache Directory Developers List <dev@directory.apache.org> Subject: Re: [kerby] ASN1 Quick review Some more questions, now that I have drawn the full Asn1 hierarchy

RE: [kerby] ASN1 Quick review

2015-12-24 Thread Zheng, Kai
-Original Message- From: Emmanuel Lécharny [mailto:elecha...@gmail.com] Sent: Thursday, December 24, 2015 5:03 PM To: ke...@directory.apache.org Subject: Re: [kerby] ASN1 Quick review Le 24/12/15 01:56, Zheng, Kai a écrit : > Nice picture!! My comments are embedded marked as [

Re: [kerby] ASN1 Quick review

2015-12-23 Thread Emmanuel Lécharny
Some more questions, now that I have drawn the full Asn1 hierarchy (http://pasteboard.co/fGVRQFm.png) - can't we merge the Asn1Encodable and AbstractAsn1Type classes ? - same question for the Asn1Cnstructed and Asn1Collection classes - I'm not sure the Asn1Dumpable interface makes a lot of sense.

RE: [kerby] ASN1 Quick review

2015-12-23 Thread Zheng, Kai
Nice picture!! My comments are embedded marked as [Kai]. -Original Message- From: Emmanuel Lécharny [mailto:elecha...@gmail.com] Sent: Thursday, December 24, 2015 1:29 AM To: Apache Directory Developers List <dev@directory.apache.org> Subject: Re: [kerby] ASN1 Quick review Som

RE: [kerby] ASN1 Quick review

2015-12-23 Thread Yan, Yan A
, December 24, 2015 8:31 AM To: Apache Directory Developers List <dev@directory.apache.org>; ke...@directory.apache.org Subject: RE: [kerby] ASN1 Quick review Thanks Emmanuel for the review and great comments! The questions are hard but fortunately I'm still kept in the loop so my pleasure to a

RE: [kerby] ASN1 Quick review

2015-12-23 Thread Zheng, Kai
Thanks Emmanuel for the review and great comments! The questions are hard but fortunately I'm still kept in the loop so my pleasure to address them. My comments are embedded and marked by [Kai]. -Original Message- From: Emmanuel Lécharny [mailto:elecha...@gmail.com] Sent: Wednesday,

RE: [kerby] ASN1 Quick review

2015-12-23 Thread Zheng, Kai
Resend after formatted. Thanks Emmanuel for the review and great comments! The questions are hard but fortunately I'm still kept in the loop so my pleasure to address them. My comments are embedded and marked by [Kai]. -Original Message- From: Emmanuel Lécharny

RE: [kerby] ASN1 Quick review

2015-12-23 Thread Zheng, Kai
...@directory.apache.org; Apache Directory Developers List <dev@directory.apache.org> Subject: RE: [kerby] ASN1 Quick review Thanks for Emmanuel and Kai's discussion. I'm wondering if any contributor would help with such. I'd like to help with the issues, and by the way be familiar with the core part codes.