Usage of static variables in BaseInterceptor

2015-08-13 Thread Stefan Seelmann
Hi dev, while doing some checkstyle cleanup in ApacheDS I found some strange usage of static varables, e.g. in BaseInterceptor, there are lot of definitions like protected static AttributeType OBJECT_CLASS_AT; However those variables are not initialized in a static block, but in the BaseInte

Re: Usage of static variables in BaseInterceptor

2015-08-13 Thread Emmanuel Lécharny
Le 13/08/15 20:40, Stefan Seelmann a écrit : > Hi dev, > > while doing some checkstyle cleanup in ApacheDS I found some strange > usage of static varables, e.g. in BaseInterceptor, there are lot of > definitions like > > protected static AttributeType OBJECT_CLASS_AT; > > However those variable

Re: Usage of static variables in BaseInterceptor

2015-08-15 Thread Stefan Seelmann
On 08/13/2015 11:53 PM, Emmanuel Lécharny wrote: > So, here is what I think : we should have a diect access to those AT > through the SchemaManager without having to do a lookup in the > registries. Some ways to do it is to have a static class that is > initialized after the SM, and which provides

Re: Usage of static variables in BaseInterceptor

2015-08-15 Thread Emmanuel Lecharny
I totally agreewith your last paragraph. Actually, we designed the schema years ago with OSGI in mind, but we weren't ready. It's probably time to take this road now that the api is OSGI complient... Le samedi 15 août 2015, Stefan Seelmann a écrit : > On 08/13/2015 11:53 PM, Emmanuel Lécharny wr