Re: [kerby] ASN1 Quick review

Some more questions, now that I have drawn the full Asn1 hierarchy (http://pasteboard.co/fGVRQFm.png) - can't we merge the Asn1Encodable and AbstractAsn1Type classes ? - same question for the Asn1Cnstructed and Asn1Collection classes - I'm not sure the Asn1Dumpable interface makes a lot of sense.

RE: [kerby] ASN1 Quick review

Nice picture!! My comments are embedded marked as [Kai]. -Original Message- From: Emmanuel Lécharny [mailto:elecha...@gmail.com] Sent: Thursday, December 24, 2015 1:29 AM To: Apache Directory Developers List Subject: Re: [kerby] ASN1 Quick review Some more

RE: [kerby] ASN1 Quick review

Thanks for Emmanuel and Kai's discussion. I'm wondering if any contributor would help with such. I'd like to help with the issues, and by the way be familiar with the core part codes. Best regards, Yan -Original Message- From: Zheng, Kai [mailto:kai.zh...@intel.com] Sent: Thursday,

[jira] [Created] (DIRKRB-511) Load the resource name and contents at the same time

YanYan created DIRKRB-511: - Summary: Load the resource name and contents at the same time Key: DIRKRB-511 URL: https://issues.apache.org/jira/browse/DIRKRB-511 Project: Directory Kerberos Issue

RE: [kerby] ASN1 Quick review

Thanks Emmanuel for the review and great comments! The questions are hard but fortunately I'm still kept in the loop so my pleasure to address them. My comments are embedded and marked by [Kai]. -Original Message- From: Emmanuel Lécharny [mailto:elecha...@gmail.com] Sent: Wednesday,

RE: [kerby] ASN1 Quick review

Resend after formatted. Thanks Emmanuel for the review and great comments! The questions are hard but fortunately I'm still kept in the loop so my pleasure to address them. My comments are embedded and marked by [Kai]. -Original Message- From: Emmanuel Lécharny

[jira] [Updated] (DIRKRB-511) Load configuration content when adding the resource

[ https://issues.apache.org/jira/browse/DIRKRB-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kai Zheng updated DIRKRB-511: - Summary: Load configuration content when adding the resource (was: Load the resource name and contents

[jira] [Commented] (DIRKRB-511) Load configuration content when adding the resource

[ https://issues.apache.org/jira/browse/DIRKRB-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070710#comment-15070710 ] Kai Zheng commented on DIRKRB-511: -- With this change there would be no good place to call the following.

RE: [kerby] ASN1 Quick review

Thanks Yan for the hard taking! Note it means you would need to manually modify 200+ classes one by one since we'll need a friendly enum name. Regards, Kai -Original Message- From: Yan, Yan A [mailto:yan.a@intel.com] Sent: Thursday, December 24, 2015 9:13 AM To:

[jira] [Updated] (DIRKRB-511) Load the resource name and contents at the same time

[ https://issues.apache.org/jira/browse/DIRKRB-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YanYan updated DIRKRB-511: -- Attachment: DIRKRB-511-v1.patch Load resource name and contents in one step. Main changes are as follow: In

[jira] [Commented] (DIRKRB-511) Load configuration content when adding the resource

[ https://issues.apache.org/jira/browse/DIRKRB-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070699#comment-15070699 ] Kai Zheng commented on DIRKRB-511: -- Thanks [~Alice Yan] for this! This would make the {{Conf}} look much

[kerby] ASN1 Quick review

Hi band, I'm having a quick look at the kerby-asn1 code, as I wanted to paly around the idea of porting the LDAP codec to use this piece of nice code. AFAIU, when you want to declare an object that can be encoded or decoded, you have to extend the correct Asn1Object child. Looking at the Ticket