Re: Distributed Log as Kafka's backend

2016-08-26 Thread Sijie Guo
+ Leigh Khurrum, Thanks for your hard working on this. The approach in general looks good to me. However, I am kind of agreeing with what Leigh commented at pull request. Ideally we want to make DL more focus on single streams itself, such as durability, consistency and performance. As different

[GitHub] incubator-distributedlog issue #16: (WIP) Kafka publisher uses distributed l...

2016-08-26 Thread leighst
Github user leighst commented on the issue: https://github.com/apache/incubator-distributedlog/pull/16 my feeling is that this is supposed to be a simple tutorial and it should live in the tutorials section. there is a question of layering here. dl should be concerned with ser

[GitHub] incubator-distributedlog pull request #15: DL-37: add an offset sequencer fo...

2016-08-26 Thread leighst
Github user leighst commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/15#discussion_r76434565 --- Diff: distributedlog-core/src/main/java/com/twitter/distributedlog/util/OffsetSequencer.java --- @@ -0,0 +1,51 @@ +/** + * Lice

[GitHub] incubator-distributedlog pull request #15: DL-37: add an offset sequencer fo...

2016-08-26 Thread leighst
Github user leighst commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/15#discussion_r76433771 --- Diff: distributedlog-service/src/main/java/com/twitter/distributedlog/service/stream/StreamImpl.java --- @@ -239,6 +231,12 @@ private D

[GitHub] incubator-distributedlog issue #14: DL-36: travis ci build failed with assem...

2016-08-26 Thread leighst
Github user leighst commented on the issue: https://github.com/apache/incubator-distributedlog/pull/14 LGTM, i assume all of the packages build and run fine with example scripts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] incubator-distributedlog issue #13: DL-3: Move distributedlog website to apa...

2016-08-26 Thread leighst
Github user leighst commented on the issue: https://github.com/apache/incubator-distributedlog/pull/13 On second thought criss crossing from one site to another like this is awkward. Why cant we just use sphinx? Its also a lot of irritating web code to have to mainta

[GitHub] incubator-distributedlog issue #13: DL-3: Move distributedlog website to apa...

2016-08-26 Thread leighst
Github user leighst commented on the issue: https://github.com/apache/incubator-distributedlog/pull/13 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

Jenkins build is still unstable: distributedlog-nightly-build #37

2016-08-26 Thread Apache Jenkins Server
See