[GitHub] incubator-distributedlog issue #123: DL-193: Bumped up the Guava version

2017-03-08 Thread arvindkandhare
Github user arvindkandhare commented on the issue: https://github.com/apache/incubator-distributedlog/pull/123 While the compile passes, the tests actually try to create a server process. This tries to start bookkeeper server, which has dependencies on Guava again. This means that

[GitHub] incubator-distributedlog issue #123: DL-193: Bumped up the Guava version

2017-03-08 Thread arvindkandhare
Github user arvindkandhare commented on the issue: https://github.com/apache/incubator-distributedlog/pull/123 Looking in to this. mvn compile passed for me locally. Maybe I should try running mvn clean install? Giving it a shot. --- If your project is set up for it, you can reply

[GitHub] incubator-distributedlog pull request #123: DL-193: Bumped up the Guava vers...

2017-03-07 Thread arvindkandhare
GitHub user arvindkandhare opened a pull request: https://github.com/apache/incubator-distributedlog/pull/123 DL-193: Bumped up the Guava version Moving the Guava version from 16.0 to 20.0. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-distributedlog pull request #21: DL-45: DL should allow ByteBuffer...

2016-11-20 Thread arvindkandhare
Github user arvindkandhare commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/21#discussion_r88817799 --- Diff: distributedlog-core/src/main/java/com/twitter/distributedlog/EnvelopedEntry.java --- @@ -254,21 +253,22 @@ private void

[GitHub] incubator-distributedlog issue #21: DL-45: DL should allow ByteBuffer based ...

2016-11-01 Thread arvindkandhare
Github user arvindkandhare commented on the issue: https://github.com/apache/incubator-distributedlog/pull/21 @sijie The BK changes are final and ready to be checked in once you are satisfied with them. This particular pull request still needs a couple of changes. --- If your

[GitHub] incubator-distributedlog pull request #21: DL-45: DL should allow ByteBuffer...

2016-10-31 Thread arvindkandhare
Github user arvindkandhare commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/21#discussion_r85870071 --- Diff: distributedlog-core/src/main/java/com/twitter/distributedlog/BKLogSegmentWriter.java --- @@ -17,27 +17,18

[GitHub] incubator-distributedlog issue #3: DL-25: Documentation for vagrant and dock...

2016-07-27 Thread arvindkandhare
Github user arvindkandhare commented on the issue: https://github.com/apache/incubator-distributedlog/pull/3 Done. Somehow not able to assign the issue to myself. Everything else is taken care of :) --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-distributedlog pull request #3: Documentation for vagrant deployme...

2016-07-27 Thread arvindkandhare
GitHub user arvindkandhare opened a pull request: https://github.com/apache/incubator-distributedlog/pull/3 Documentation for vagrant deployment You can merge this pull request into a Git repository by running: $ git pull https://github.com/arvindkandhare/incubator