[GitHub] incubator-distributedlog pull request #77: DL-122: Use assertions from Junit...

GitHub user brennonyork opened a pull request: https://github.com/apache/incubator-distributedlog/pull/77 DL-122: Use assertions from Junit rather than assert() for tests * changed all instances of `assert()` to junit versions in `src/test` Here is the script I used to find

[GitHub] incubator-distributedlog issue #75: DL-123: Every tests should have timeout

Github user brennonyork commented on the issue: https://github.com/apache/incubator-distributedlog/pull/75 Totally valid question. I went through and Google'd for a bit and found a few links. In short the best we can do that is _currently_ supported by JUnit is to create a class

[GitHub] incubator-distributedlog pull request #75: DL-123: Every tests should have t...

GitHub user brennonyork opened a pull request: https://github.com/apache/incubator-distributedlog/pull/75 DL-123: Every tests should have timeout * used a simple bash script to find any tests without a timeout Here is the below bash executed from the root directory. This

[GitHub] incubator-distributedlog pull request #74: DL-136: Avoid empty catch blocks

GitHub user brennonyork opened a pull request: https://github.com/apache/incubator-distributedlog/pull/74 DL-136: Avoid empty catch blocks * resolves the 9 empty catch blocks in `src/main` * leaves 49 errors within `src/test` unchanged * if we want to resolve those as well