[GitHub] incubator-distributedlog issue #27: DL-23: update libthrift version in distr...

2017-04-18 Thread khurrumnasimm
Github user khurrumnasimm commented on the issue: https://github.com/apache/incubator-distributedlog/pull/27 @jiazhai mind closing this PR, if it is not active? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-distributedlog pull request #16: (WIP) Kafka publisher uses distri...

2017-04-18 Thread khurrumnasimm
Github user khurrumnasimm closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-distributedlog issue #16: (WIP) Kafka publisher uses distributed l...

2017-04-18 Thread khurrumnasimm
Github user khurrumnasimm commented on the issue: https://github.com/apache/incubator-distributedlog/pull/16 @sijie currently I don't have enough time to work on this. closing this pull and will send out another one if I am done with that work. --- If your project is set up f

[GitHub] incubator-distributedlog pull request #106: DL-179: Support ZStandard Compre...

2017-01-06 Thread khurrumnasimm
GitHub user khurrumnasimm opened a pull request: https://github.com/apache/incubator-distributedlog/pull/106 DL-179: Support ZStandard Compression This PR is to add [Zstd](https://github.com/facebook/zstd) compression support. You can merge this pull request into a Git repository

[GitHub] incubator-distributedlog pull request #41: DL-4: Repackage the source under ...

2016-12-30 Thread khurrumnasimm
Github user khurrumnasimm closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/41 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-distributedlog issue #41: DL-4: Repackage the source under apache ...

2016-12-30 Thread khurrumnasimm
Github user khurrumnasimm commented on the issue: https://github.com/apache/incubator-distributedlog/pull/41 @leighst @sijie I will close this pull request, as I sent a separate pull request #95 for the script. --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-distributedlog pull request #95: DL-4: Add repackaging script

2016-12-30 Thread khurrumnasimm
GitHub user khurrumnasimm opened a pull request: https://github.com/apache/incubator-distributedlog/pull/95 DL-4: Add repackaging script this pull request only contains the script to repackage files. run it at the root directory of the project - **./scripts/dev/repackage.sh

[GitHub] incubator-distributedlog issue #41: DL-4: Repackage the source under apache ...

2016-12-30 Thread khurrumnasimm
Github user khurrumnasimm commented on the issue: https://github.com/apache/incubator-distributedlog/pull/41 @sijie I added a script "scripts/dev/repackage.sh". it is included in this pull request. I think the easiest way to coordinate with this pull request - when

[GitHub] incubator-distributedlog issue #41: DL-4: Repackage the source under apache ...

2016-11-12 Thread khurrumnasimm
Github user khurrumnasimm commented on the issue: https://github.com/apache/incubator-distributedlog/pull/41 ping again @leighst @sijie --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-distributedlog pull request #42: Fix deadlock on BKSyncLogReaderDL...

2016-11-12 Thread khurrumnasimm
Github user khurrumnasimm commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/42#discussion_r87690568 --- Diff: distributedlog-core/src/main/java/com/twitter/distributedlog/BKSyncLogReaderDLSN.java --- @@ -116,7 +110,7 @@ public void

[GitHub] incubator-distributedlog issue #15: DL-37: add an offset sequencer for gener...

2016-11-12 Thread khurrumnasimm
Github user khurrumnasimm commented on the issue: https://github.com/apache/incubator-distributedlog/pull/15 @sijie @leighst thank you so much for your comments. I agreed with you after trying a while, it turns out is a bit hard to get an offset generator correctly on write proxy. I

[GitHub] incubator-distributedlog pull request #15: DL-37: add an offset sequencer fo...

2016-11-12 Thread khurrumnasimm
Github user khurrumnasimm closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-distributedlog pull request #42: Fix deadlock on BKSyncLogReaderDL...

2016-11-02 Thread khurrumnasimm
Github user khurrumnasimm commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/42#discussion_r86109926 --- Diff: distributedlog-core/src/main/java/com/twitter/distributedlog/BKSyncLogReaderDLSN.java --- @@ -116,7 +110,7 @@ public void

[GitHub] incubator-distributedlog pull request #42: Fix deadlock on BKSyncLogReaderDL...

2016-10-21 Thread khurrumnasimm
GitHub user khurrumnasimm opened a pull request: https://github.com/apache/incubator-distributedlog/pull/42 Fix deadlock on BKSyncLogReaderDLSN Change the lastSeenDLSN to volatile to remove the synchronization block to avoid deadlock with sharedLock You can merge this pull request

[GitHub] incubator-distributedlog pull request #41: DL-4: Repackage the source under ...

2016-10-21 Thread khurrumnasimm
GitHub user khurrumnasimm opened a pull request: https://github.com/apache/incubator-distributedlog/pull/41 DL-4: Repackage the source under apache namespace Repackage the source code from 'com.twitter.distributedlog' to 'org.apache.distributedlog'.

[GitHub] incubator-distributedlog pull request #40: DL-56: Fix broken links in quicks...

2016-10-21 Thread khurrumnasimm
GitHub user khurrumnasimm opened a pull request: https://github.com/apache/incubator-distributedlog/pull/40 DL-56: Fix broken links in quickstart page You can merge this pull request into a Git repository by running: $ git pull https://github.com/khurrumnasimm/incubator

[GitHub] incubator-distributedlog pull request #39: DL-60: Add user mail list to the ...

2016-10-21 Thread khurrumnasimm
GitHub user khurrumnasimm opened a pull request: https://github.com/apache/incubator-distributedlog/pull/39 DL-60: Add user mail list to the community page You can merge this pull request into a Git repository by running: $ git pull https://github.com/khurrumnasimm/incubator

[GitHub] incubator-distributedlog issue #36: add global cluster deploy instructions

2016-10-21 Thread khurrumnasimm
Github user khurrumnasimm commented on the issue: https://github.com/apache/incubator-distributedlog/pull/36 +1 for the Ansible playbook. when do you guys think it can be available? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-distributedlog pull request #38: DL-59: Check findbugs warning bef...

2016-10-21 Thread khurrumnasimm
GitHub user khurrumnasimm opened a pull request: https://github.com/apache/incubator-distributedlog/pull/38 DL-59: Check findbugs warning before packaging check findbugs errors before running package You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-distributedlog pull request #16: (WIP) Kafka publisher uses distri...

2016-08-25 Thread khurrumnasimm
GitHub user khurrumnasimm opened a pull request: https://github.com/apache/incubator-distributedlog/pull/16 (WIP) Kafka publisher uses distributed log streams as partitions - moved the distributedlog-kafka module out of tutorials module, so people can use it directly - rewrote

[GitHub] incubator-distributedlog pull request #15: DL-37: add an offset sequencer fo...

2016-08-25 Thread khurrumnasimm
GitHub user khurrumnasimm opened a pull request: https://github.com/apache/incubator-distributedlog/pull/15 DL-37: add an offset sequencer for generating transaction id add an offset sequencer for generating transaction id. You can merge this pull request into a Git repository by