[GitHub] incubator-distributedlog issue #1: Update travis' configuration file.

2016-07-25 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/1 The change looks good to me. But I will first port the bookkeeper merge-pr script to distributedlog. Then merge the pr can automatically close the corresponding ticket. --- If your

[GitHub] incubator-distributedlog issue #1: Update travis' configuration file.

2016-07-25 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/1 I created a jira https://issues.apache.org/jira/browse/DL-16 to port the merge script. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-distributedlog issue #1: Update travis' configuration file.

2016-07-25 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/1 Also I am thinking of cloning the process of BookKeeper about pull-requests and merge scripts. https://cwiki.apache.org/confluence/display/BOOKKEEPER/Contributing+to

[GitHub] incubator-distributedlog issue #3: Documentation for vagrant deployment

2016-07-27 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/3 This looks good to me! +1 But can you create a jira under https://issues.apache.org/jira/browse/DL and changed the pull request title to be "DL-XXX: ...". S

[GitHub] incubator-distributedlog issue #5: DL-21: Fix DL flaky test cases

2016-07-27 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/5 The change looks good to me. +1. (regarding the ci check failure, created https://issues.apache.org/jira/browse/DL-22 for tracking the flaky test) --- If your project is set

[GitHub] incubator-distributedlog issue #2: DL-4: Add NOTICE file.

2016-07-27 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/2 The notice file looks good to me. +1. @fpj did you see any problem here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-distributedlog issue #3: DL-25: Documentation for vagrant and dock...

2016-07-27 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/3 @arvindkandhare I just added you to contributor list and assigned that ticket to you. so we are good now. we are working on porting the merge-pr.py script from bookkeeper

[GitHub] incubator-distributedlog issue #6: DL-16: Add script to merge GitHub PR.

2016-07-28 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/6 LGTM +1. Let's merge this pull request using it :D Also, I created a wiki page for 'committer workflow' - do you mind filling up the information on how to use

[GitHub] incubator-distributedlog issue #2: DL-4: Add NOTICE file.

2016-07-31 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/2 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-distributedlog pull request #7: DL-16: Fix the merge script

2016-07-31 Thread sijie
GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/7 DL-16: Fix the merge script - Fix the commit message to include 'Close #%s' message, so the pull request will be closed automatically when the change is merged. - Fi

[GitHub] incubator-distributedlog issue #1: DL-14: Update travis' configuration file.

2016-07-31 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/1 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-distributedlog issue #6: DL-16: Add script to merge GitHub PR.

2016-07-31 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/6 @franckcuny I merged this pull request. but because the commit message doesn't contain 'close #6' message. so asfgit doesn't close this pull request. Can you manu

[GitHub] incubator-distributedlog issue #8: DL-16: Use correct git remote repository

2016-08-09 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/8 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-distributedlog pull request #9: DL-31: Provide flag to disable zk ...

2016-08-11 Thread sijie
GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/9 DL-31: Provide flag to disable zk based distributed lock DL doesn't enforce any leader election. However it still provides a zookeeper ephemeral znode based lock for leader ele

[GitHub] incubator-distributedlog issue #10: DL-1: Clean up the distributedlog pom fi...

2016-08-16 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/10 LGTM +1 thanks @jiazhai (btw, I like the way how you organized the module description) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-distributedlog issue #3: DL-25: Documentation for vagrant and dock...

2016-08-16 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/3 @franckcuny can you review this also? I'd like to have a second eye on documentation. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] incubator-distributedlog issue #11: Handle correctly merge commits.

2016-08-17 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/11 @franckcuny you are faster than me. I was planning to send a change out :D --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-distributedlog issue #12: DL-32: Update findbugs version to 3.0.3

2016-08-21 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/12 @franckcuny I think you might need to run `mvn clean install -DskipTests` first and then run `mvn findbugs:findbugs`. `Findbugs` runs when the code is compiled. --- If your project

[GitHub] incubator-distributedlog issue #12: DL-32: Update findbugs version to 3.0.3

2016-08-21 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/12 Also, I think we also need to make code changes to address findbugs errors if there are any. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-distributedlog issue #11: Handle correctly merge commits.

2016-08-22 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/11 The change looks good to me. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-distributedlog pull request #13: DL-3: Move distributedlog website...

2016-08-23 Thread sijie
GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/13 DL-3: Move distributedlog website to apache (part 1) Setup an initial distributedlog website using jekyll & bootstrap. Live demo: https://sijie.github.io/incub

[GitHub] incubator-distributedlog issue #17: DL-24: broken quickstart tutorial

2016-08-25 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/17 LGTM +1. thanks @crazysoftwarecoder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-distributedlog issue #20: Mark some dl tests as flaky

2016-09-01 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/20 Nice attempt, @jiazhai . In general, looks good to me. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-distributedlog issue #19: DL-32: Fix Findbug warnings

2016-09-01 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/19 looks good to me. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-distributedlog issue #18: DL-39: Use a distributedlog uri to confi...

2016-09-01 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/18 this sounds reasonable to me. it actually simplifies things. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-distributedlog issue #26: Disable travis ci on linux

2016-09-13 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/26 LGTM. however I'd like to hold off to see #25 can help improve the ci. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-distributedlog issue #25: Add infinite retry policy to zookeeper c...

2016-09-13 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/25 LGTM +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-distributedlog issue #25: Add infinite retry policy to zookeeper c...

2016-09-13 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/25 the title is actually not correct. it has be to in the format of "DL-XXX: ...". Can you create a DL ticket and update the title? --- If your project is set up for it, you

[GitHub] incubator-distributedlog pull request #29: Fix the build scripts

2016-09-13 Thread sijie
GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/29 Fix the build scripts - the baseurl is the relative path - url is the protocol + domain name You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-distributedlog pull request #30: Add instructions for building web...

2016-09-13 Thread sijie
GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/30 Add instructions for building website and documentation You can merge this pull request into a Git repository by running: $ git pull https://github.com/sijie/incubator

[GitHub] incubator-distributedlog issue #35: [blog] A technical review of kafka and d...

2016-10-13 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/35 @leighst FYI. I merged this pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-distributedlog pull request #30: Add instructions for building web...

2016-10-13 Thread sijie
Github user sijie commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/30#discussion_r83162115 --- Diff: docs/README.md --- @@ -0,0 +1,85 @@ +This README gives an overview of how to build and contribute to the documentation of

[GitHub] incubator-distributedlog issue #32: DL-52: update README.md to reflect curre...

2016-10-13 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/32 @leighst can you ship this? I'd like to push the new README file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] incubator-distributedlog issue #36: add global cluster deploy instructions

2016-10-13 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/36 +1 for the idea. @franckcuny I don't have an experience with ansible. so I will just defer this to you :D --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-distributedlog issue #32: DL-52: update README.md to reflect curre...

2016-10-19 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/32 @leighst @franckcuny @mgodave can any of you take a look at this? I'd like to get the README updated and then I will sync the twitter github repo with this one. --- If your pr

[GitHub] incubator-distributedlog issue #40: DL-56: Fix broken links in quickstart pa...

2016-10-22 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/40 LGTM. Thank you for fixing the broken links. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-distributedlog issue #39: DL-60: Add user mail list to the communi...

2016-11-01 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/39 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-distributedlog issue #27: DL-23: update libthrift version in distr...

2016-11-01 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/27 @jiazhai it would good that you can send out the second part of this change. I took a look at this change initially. the layout seems to be fine. I would like to see how will you

[GitHub] incubator-distributedlog issue #28: Fix the typo in merge script on formatti...

2016-11-01 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/28 ping @franckcuny --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-distributedlog issue #21: DL-45: DL should allow ByteBuffer based ...

2016-11-01 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/21 @arvindkandhare is the [twitter/bookkeeper#4](https://github.com/twitter/bookkeeper/pull/4) change finalized? --- If your project is set up for it, you can reply to this email and

incubator-distributedlog git commit: DL-60: Add user mail list to the community page

2016-11-01 Thread sijie
Repository: incubator-distributedlog Updated Branches: refs/heads/master c2546a9c1 -> f88c1e6e4 DL-60: Add user mail list to the community page Author: Khurrum Nasim Reviewers: Sijie Guo Closes #39 from khurrumnasimm/kn/add_user_list Project: http://git-wip-us.apache.org/repos/

incubator-distributedlog git commit: DL-59: Check findbugs warning before packaging

2016-11-01 Thread sijie
Repository: incubator-distributedlog Updated Branches: refs/heads/master f88c1e6e4 -> 298abf86b DL-59: Check findbugs warning before packaging check findbugs errors before running package Author: Khurrum Nasim Reviewers: Sijie Guo Closes #38 from khurrumnasimm/kn/DL-59 Project: h

[GitHub] incubator-distributedlog issue #41: DL-4: Repackage the source under apache ...

2016-11-08 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/41 @khurrumnasimm thank you so much for your effort. This is not a trivial change. I think most of changes are just renaming files and package names. so +1 from me. but I&#

[GitHub] incubator-distributedlog issue #37: Introduce namespace resolver for validat...

2016-11-08 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/37 @jderrickk I think the change is making the namespace management become much complicated. I had a brief discussion with @leighst offline about the naming management in DL. I

[GitHub] incubator-distributedlog issue #27: DL-23: update libthrift version in distr...

2016-11-08 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/27 @leighst can you also take a look at this? I think it might be a good direction to go down to have a write-protocol specific client or service. so it is easy to extend in

[GitHub] incubator-distributedlog issue #15: DL-37: add an offset sequencer for gener...

2016-11-08 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/15 I am not sure if we should support this. I had the same feeling with @leighst - I don't think we can find a reliable to use transaction id for offset. I am actually thi

incubator-distributedlog git commit: Fix the typo in merge script on formatting modified title

2016-11-08 Thread sijie
Repository: incubator-distributedlog Updated Branches: refs/heads/master 298abf86b -> f3f0d55ac Fix the typo in merge script on formatting modified title /cc franckcuny Author: Sijie Guo Reviewers: Franck Cuny Closes #28 from sijie/sijie/fix_typo_in_merge_script Project: http://git-

incubator-distributedlog git commit: Fix the build scripts

2016-11-08 Thread sijie
Repository: incubator-distributedlog Updated Branches: refs/heads/master f3f0d55ac -> 3fadd14aa Fix the build scripts - the baseurl is the relative path - url is the protocol + domain name Author: Sijie Guo Reviewers: Franck Cuny Closes #29 from sijie/sijie/fix_website_build_scri

incubator-distributedlog git commit: Enable coverall report

2016-11-08 Thread sijie
Repository: incubator-distributedlog Updated Branches: refs/heads/master 3fadd14aa -> 878ae87be Enable coverall report Author: Sijie Guo Author: Sijie Guo Reviewers: Leigh Stewart Closes #33 from sijie/sijie/fix_coverall_plugin Project: http://git-wip-us.apache.org/repos/asf/incuba

[GitHub] incubator-distributedlog issue #12: DL-32: Update findbugs version to 3.0.3

2016-11-08 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/12 @franckcuny I think findbugs was added in #19 . mind closing this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-distributedlog issue #44: Add documentation for distributedlog-ben...

2016-11-15 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/44 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-distributedlog pull request #42: Fix deadlock on BKSyncLogReaderDL...

2016-11-15 Thread sijie
Github user sijie commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/42#discussion_r87980394 --- Diff: distributedlog-core/src/main/java/com/twitter/distributedlog/BKSyncLogReaderDLSN.java --- @@ -116,7 +110,7 @@ public void

[GitHub] incubator-distributedlog issue #41: DL-4: Repackage the source under apache ...

2016-11-15 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/41 @khurrumnasimm sorry for being late. the change LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-distributedlog pull request #37: Introduce namespace resolver for ...

2016-11-15 Thread sijie
Github user sijie commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/37#discussion_r87980980 --- Diff: distributedlog-core/src/main/java/com/twitter/distributedlog/metadata/BKDLConfig.java --- @@ -19,9 +19,11 @@ import

[GitHub] incubator-distributedlog pull request #37: Introduce namespace resolver for ...

2016-11-15 Thread sijie
Github user sijie commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/37#discussion_r87980954 --- Diff: distributedlog-core/src/main/java/com/twitter/distributedlog/metadata/BKDLConfig.java --- @@ -19,9 +19,11 @@ import

[GitHub] incubator-distributedlog pull request #37: Introduce namespace resolver for ...

2016-11-15 Thread sijie
Github user sijie commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/37#discussion_r87980883 --- Diff: distributedlog-core/src/main/java/com/twitter/distributedlog/BKDistributedLogNamespace.java --- @@ -470,6 +478,23 @@ private

[GitHub] incubator-distributedlog issue #21: DL-45: DL should allow ByteBuffer based ...

2016-11-15 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/21 @arvindkandhare @jiazhai I will merge the bk change and produce a new version this week. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-distributedlog issue #16: (WIP) Kafka publisher uses distributed l...

2016-11-15 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/16 @khurrumnasimm Any updates about this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

incubator-distributedlog git commit: Fix deadlock on BKSyncLogReaderDLSN

2016-11-29 Thread sijie
458 Diff: http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/diff/ebaf1458 Branch: refs/heads/master Commit: ebaf145807813c2731f3afbcd30fb526a1d677da Parents: 50f6bd4 Author: Khurrum Nasim Authored: Tue Nov 29 11:50:17 2016 -0800 Committer: Sijie Guo Committed: Tue Nov 29 11:50:17 2

[GitHub] incubator-distributedlog issue #45: Build cobertura report only on master fo...

2016-11-29 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/45 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-distributedlog issue #46: Update a couple of scripts

2016-11-29 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/46 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-distributedlog issue #47: The CONFIG.ini file has no purpose outsi...

2016-12-01 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/47 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-distributedlog issue #48: DL-80 : synchronized getLogRecordSetWrit...

2016-12-02 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/48 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

incubator-distributedlog git commit: DL-80: synchronized getLogRecordSetWriter()

2016-12-02 Thread sijie
Repository: incubator-distributedlog Updated Branches: refs/heads/master e611ef9e8 -> 2a677d15a DL-80: synchronized getLogRecordSetWriter() see jira's comments Author: xieliang Reviewers: Sijie Guo Closes #48 from xieliang/DL-80 Project: http://git-wip-us.apache.org/repos/asf/i

[GitHub] incubator-distributedlog issue #41: DL-4: Repackage the source under apache ...

2016-12-02 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/41 @leighst @khurrumnasimm I would like to put this as last change to merge for the first apache release. since we might have quite a few changes to merge based on current package name

incubator-distributedlog git commit: Update a couple of scripts

2016-12-02 Thread sijie
Repository: incubator-distributedlog Updated Branches: refs/heads/master 2a677d15a -> a546e6207 Update a couple of scripts Mostly style. Author: Franck Cuny Author: Leigh Stewart Author: Khurrum Nasim Reviewers: Sijie Guo Closes #46 from franckcuny/fcuny/update-scripts and squashes

incubator-distributedlog git commit: The CONFIG.ini file has no purpose outside of Twitter

2016-12-02 Thread sijie
Repository: incubator-distributedlog Updated Branches: refs/heads/master a546e6207 -> e4dce21cb The CONFIG.ini file has no purpose outside of Twitter Author: Franck Cuny Reviewers: Sijie Guo Closes #47 from franckcuny/fcuny/cleanup Project: http://git-wip-us.apache.org/repos/

[GitHub] incubator-distributedlog issue #22: DL-49: Support building project with sca...

2016-12-02 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/22 merged latest master and wait for travis ci build to complete --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

incubator-distributedlog git commit: DL-49: Support building project with scala 2.10 and 2.11

2016-12-02 Thread sijie
Repository: incubator-distributedlog Updated Branches: refs/heads/master e4dce21cb -> f03249dfb DL-49: Support building project with scala 2.10 and 2.11 Author: Sijie Guo Author: Sijie Guo Reviewers: Franck Cuny Closes #22 from sijie/sijie/support_scala_2.10_and_2.11 Project: h

[GitHub] incubator-distributedlog pull request #49: Blacklist branches on travis

2016-12-02 Thread sijie
GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/49 Blacklist branches on travis You can merge this pull request into a Git repository by running: $ git pull https://github.com/sijie/incubator-distributedlog sijie

[GitHub] incubator-distributedlog issue #50: DL-79 : DL eclipse formatter file

2016-12-07 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/50 LGTM thanks @xieliang --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-distributedlog issue #49: Blacklist branches on travis

2016-12-09 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/49 @franckcuny yup. the change is to verify the pull request pass the tests. I think we need a coverall token to report coverall reports. I am thinking of moving the coverall report to

[GitHub] incubator-distributedlog pull request #51: (WIP) DL-81: Build the distribute...

2016-12-10 Thread sijie
GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/51 (WIP) DL-81: Build the distributedlog release procedure Borrow from http://beam.incubator.apache.org/contribute/release-guide/ You can merge this pull request into a Git repository

[GitHub] incubator-distributedlog issue #51: (WIP) DL-81: Build the distributedlog re...

2016-12-10 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/51 We will use this guide for the first release. Will make modifications when go through it and will not merge until the first release is made. /cc @franckcuny @leighst @mgodave

[GitHub] incubator-distributedlog issue #37: Introduce namespace resolver for validat...

2016-12-10 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/37 @jderrickk are you still willing to contribute this? I am thinking it might be just easier to accept zookeeper-like path as the stream name. we don't need to intr

incubator-distributedlog git commit: DL-79: DL eclipse formatter file

2016-12-10 Thread sijie
Repository: incubator-distributedlog Updated Branches: refs/heads/master f03249dfb -> 9ca84c9f6 DL-79: DL eclipse formatter file Author: xieliang Reviewers: Sijie Guo Closes #50 from xieliang/DL-79 Project: http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/repo Com

incubator-distributedlog git commit: Blacklist branches on travis

2016-12-10 Thread sijie
Repository: incubator-distributedlog Updated Branches: refs/heads/master 9ca84c9f6 -> 8e619cd73 Blacklist branches on travis Author: Sijie Guo Reviewers: Franck Cuny Closes #49 from sijie/sijie/fix_travis_build Project: http://git-wip-us.apache.org/repos/asf/incubator-distributed

[GitHub] incubator-distributedlog pull request #52: DL-126: Fix the url of distribute...

2016-12-10 Thread sijie
GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/52 DL-126: Fix the url of distributedlog blog post fix the url for the blog post and but still keep the wrong url and make it redirect to the right url. You can merge this pull request

[GitHub] incubator-distributedlog pull request #53: DL-127: Fix coverall report

2016-12-10 Thread sijie
GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/53 DL-127: Fix coverall report You can merge this pull request into a Git repository by running: $ git pull https://github.com/sijie/incubator-distributedlog sijie

[GitHub] incubator-distributedlog pull request #51: (WIP) DL-81: Build the distribute...

2016-12-12 Thread sijie
Github user sijie commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/51#discussion_r92024690 --- Diff: website/community/release_guide.md --- @@ -0,0 +1,507 @@ +--- +layout: default +title: "DistributedLog Release

[GitHub] incubator-distributedlog pull request #54: DL-129: Enable checkstyle plugin ...

2016-12-12 Thread sijie
Github user sijie commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/54#discussion_r92026632 --- Diff: distributedlog-build-tools/src/main/resources/distributedlog/checkstyle.xml --- @@ -0,0 +1,443 @@ + + +http

[GitHub] incubator-distributedlog pull request #54: DL-129: Enable checkstyle plugin ...

2016-12-12 Thread sijie
Github user sijie commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/54#discussion_r92026310 --- Diff: distributedlog-build-tools/src/main/resources/distributedlog/checkstyle.xml --- @@ -0,0 +1,443 @@ + + +http

[GitHub] incubator-distributedlog pull request #54: DL-129: Enable checkstyle plugin ...

2016-12-12 Thread sijie
Github user sijie commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/54#discussion_r92026383 --- Diff: distributedlog-build-tools/src/main/resources/distributedlog/checkstyle.xml --- @@ -0,0 +1,443 @@ + + +http

[GitHub] incubator-distributedlog pull request #54: DL-129: Enable checkstyle plugin ...

2016-12-12 Thread sijie
Github user sijie commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/54#discussion_r92025930 --- Diff: distributedlog-build-tools/src/main/resources/distributedlog/checkstyle.xml --- @@ -0,0 +1,443 @@ + + +http

[GitHub] incubator-distributedlog pull request #54: DL-129: Enable checkstyle plugin ...

2016-12-12 Thread sijie
Github user sijie commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/54#discussion_r92025594 --- Diff: distributedlog-build-tools/pom.xml --- @@ -0,0 +1,30 @@ + --- End diff -- I like the idea to organize the

[GitHub] incubator-distributedlog issue #53: DL-127: Fix coverall report

2016-12-12 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/53 @franckcuny @leighst can any of you review this one? the coverall plugin was added in a wrong section which cause the coverall report can't be generated correctly. I'd lik

incubator-distributedlog git commit: DL-127: Fix coverall report

2016-12-12 Thread sijie
Repository: incubator-distributedlog Updated Branches: refs/heads/master 8e619cd73 -> 3fceccc6c DL-127: Fix coverall report Author: Sijie Guo Reviewers: Franck Cuny Closes #53 from sijie/sijie/remove_reporting Project: http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/r

[GitHub] incubator-distributedlog pull request #56: Add distributedlog user mail list...

2016-12-12 Thread sijie
GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/56 Add distributedlog user mail list to pom file You can merge this pull request into a Git repository by running: $ git pull https://github.com/sijie/incubator-distributedlog

[GitHub] incubator-distributedlog pull request #56: DL-134: Add distributedlog user m...

2016-12-12 Thread sijie
Github user sijie commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/56#discussion_r92087267 --- Diff: pom.xml --- @@ -52,6 +52,13 @@ + DistributedLog User + user-subscr

[GitHub] incubator-distributedlog pull request #57: DL-85: Publish both per-stream st...

2016-12-12 Thread sijie
GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/57 DL-85: Publish both per-stream stats and aggregation stats merge twittter's changes from Jordan Bull. You can merge this pull request into a Git repository by running:

[GitHub] incubator-distributedlog pull request #58: DL-86: Improve handling of lock c...

2016-12-12 Thread sijie
GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/58 DL-86: Improve handling of lock conflicts in zk session lock merge twitter's change from Sijie Guo. You can merge this pull request into a Git repository by running: $ git

[GitHub] incubator-distributedlog pull request #59: DL-87: Introduce periodic keepali...

2016-12-12 Thread sijie
GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/59 DL-87: Introduce periodic keepalive control record in writer merge twitter's change from Leigh Stewart You can merge this pull request into a Git repository by running:

[GitHub] incubator-distributedlog pull request #60: DL-88: remove watches when unregi...

2016-12-12 Thread sijie
GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/60 DL-88: remove watches when unregister children watches merge twitter's change from Sijie Guo You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-distributedlog pull request #61: DL-89: add flag to enable thrift ...

2016-12-12 Thread sijie
GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/61 DL-89: add flag to enable thrift mux on DL monitor service merge twitter's change from David Rusek. You can merge this pull request into a Git repository by running: $ git

[GitHub] incubator-distributedlog pull request #62: DL-90: Don't use stack and codec ...

2016-12-12 Thread sijie
GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/62 DL-90: Don't use stack and codec together for configuring thriftmux merge Twitter's change on thriftmux You can merge this pull request into a Git repository by running:

[GitHub] incubator-distributedlog pull request #63: DL-91: Be able to close writer wi...

2016-12-12 Thread sijie
GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/63 DL-91: Be able to close writer within a timeout duration merge twitter's change on closing writer. You can merge this pull request into a Git repository by running: $ git

[GitHub] incubator-distributedlog pull request #63: DL-91: Be able to close writer wi...

2016-12-12 Thread sijie
Github user sijie closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/63 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-distributedlog pull request #64: DL-91: Be able to close writer wi...

2016-12-12 Thread sijie
GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/64 DL-91: Be able to close writer within a timeout duration merge twitter's change on closing writer. You can merge this pull request into a Git repository by running: $ git

[GitHub] incubator-distributedlog pull request #65: DL-92: Simplify the state transit...

2016-12-12 Thread sijie
GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/65 DL-92: Simplify the state transition on stream merge twitter's change on simplifying the stream state transition You can merge this pull request into a Git repository by ru

[GitHub] incubator-distributedlog pull request #66: DL-93: LogSegmentMetadataStore sh...

2016-12-12 Thread sijie
GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/66 DL-93: LogSegmentMetadataStore should only notify when the list of log segments is updated merge twitter's change on log segment metadata store. You can merge this pull request

  1   2   3   4   5   6   7   8   9   10   >