Github user xiliuant commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/89
@sijie @leighst I have rebased the pull request to latest master. please
review it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user xiliuant opened a pull request:
https://github.com/apache/incubator-distributedlog/pull/89
DL-132: Enable check style for distributedlog service module.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xiliuant
GitHub user xiliuant opened a pull request:
https://github.com/apache/incubator-distributedlog/pull/87
DL-131: Enable checkstyle for distributedlog-client module
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xiliuant/incubator
Github user xiliuant commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/54
@sijie I addressed most of your comments. please let me know if you have
any other comments.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user xiliuant commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/54#discussion_r93190694
--- Diff:
distributedlog-build-tools/src/main/resources/distributedlog/checkstyle.xml ---
@@ -0,0 +1,443 @@
+
+
+http
Github user xiliuant commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/54#discussion_r93190638
--- Diff: distributedlog-build-tools/pom.xml ---
@@ -0,0 +1,30 @@
+
--- End diff --
I moved the eclipse setting to the
Github user xiliuant commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/70
the change looks good to me +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user xiliuant opened a pull request:
https://github.com/apache/incubator-distributedlog/pull/54
Enable checkstyle plugin for distributedlog-protocol module
- add build-tools module for check style configurations
- fix style problems in distributedlog-protocol
