Re: [PROPOSAL] Add static check to our codebase

bution. > > > -- 原始邮件 -- > 发件人: "Jiajie Zhong" 发送时间: 2020年4月25日(星期六) 晚上11:34 > 收件人: "dev" > 主题: Re: [PROPOSAL] Add static check to our codebase > > > > Thanks, Got it > > Best Wish > — Jiajie

re?? [PROPOSAL] Add static check to our codebase

Code style is always a problem that needs to be solved,  looking forward to your contribution. --  -- ??: "Jiajie Zhong"

Re: [PROPOSAL] Add static check to our codebase

Thanks, Got it Best Wish — Jiajie

?????? [PROPOSAL] Add static check to our codebase

For code style, you can follow this thread https://lists.apache.org/thread.html/r348ce4f6e11924defc11668b8799cd26a893f290890652888b4d33dc%40%3Cdev.dolphinscheduler.apache.org%3E We planned to use Ali style , but didn't find a proper checkstyle file. --  -

Re: [PROPOSAL] Add static check to our codebase

Oh I found out that, But why https://github.com/apache/incubator-dolphinscheduler/pull/2363 still have so many code style change? Did sonar check code style too? Or maybe we still WIP about code style cover in the project? Best W

??????[PROPOSAL] Add static check to our codebase

We use sonar for static check. You can see more at:  https://sonarcloud.io/dashboard?id=apache-dolphinscheduler --  -- ??: "Jiajie Zhong"https://github.com/apache/incubator-dolphinscheduler/pull/2363#discussion_r415080037

[PROPOSAL] Add static check to our codebase

Hi folks In https://github.com/apache/incubator-dolphinscheduler/pull/2363#discussion_r415080037 I find out our codebase do not have static check. I’m here to proposal we add some static check for codebase, I