[dpdk-dev] [PATCH 0/2]

2014-05-15 Thread Thomas Monjalon
Hi Vadim, Your new patchset trial is better but not correct: - all is in the title. - the title must be short and begin with "timer:" as it's done for previous timer patches - you must describe the bug you are fixing I think you'll understand the problem by looking at the archives: http://dpdk.o

[dpdk-dev] [PATCH 2/2] rte_timer bug fix: when a perdiodic timer's callback manipulates another timer, updated flag prevents reloading the periodic timer. Fix: move updated flag to rte_timer structure

2014-05-15 Thread Vadim Suraev
Signed-off-by: Vadim Suraev --- lib/librte_timer/rte_timer.c | 17 - lib/librte_timer/rte_timer.h |7 ++- 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c index f98e904..0cc5fa9 100755 --- a/lib

[dpdk-dev] [PATCH 1/2] rte_timer bug fix: pending timers count is not decremented when going running. Fix: decrement pending when going running, increment if reloaded, do nothing if not reloaded Signe

2014-05-15 Thread Vadim Suraev
Signed-off-by: Vadim Suraev --- lib/librte_timer/rte_timer.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c index a3d5cca..f98e904 100755 --- a/lib/librte_timer/rte_timer.c +++ b/lib/librte_timer/rte_timer.c @

[dpdk-dev] [PATCH 0/2]

2014-05-15 Thread Vadim Suraev
rte_timer: 2 bug fixes Vadim Suraev (2): rte_timer bug fix: pending timers count is not decremented when going running. Fix: decrement pending when going running, increment if reloaded, do nothing if not reloaded Signed-off-by: Vadim Suraev rte_timer bug fix: when a perdiodic

[dpdk-dev] Regarding Mellanox CX3 NIC

2014-05-15 Thread Prashant Upadhyaya
Hi, I have a usecase coming up where I have to use DPDK with the Mellanox CX3 NIC. I see on dpdk.org that there is a PMD available for that http://dpdk.org/about#6WIND Kindly let me know if the above PMD is open source or has to be purchased. Regards -Prashant

[dpdk-dev] compilation error with 1.6.0r2

2014-05-15 Thread Prashant Upadhyaya
[resending on the list] Hi, I recently picked the 1.6.0r2 from dpdk.org and tried to compile it the usual way and ran into the following compilation error. I am aware I can sidestep these by getting the compiler to treat them as warnings, but these did not use to come with 1.6.0r1 so wanted t

[dpdk-dev] [PATCH 6/6] vmxnet3: replace Intel driver

2014-05-15 Thread Thomas Monjalon
Hi Stephen, 2014-05-14 11:55, Stephen Hemminger: > Replace the Intel VMXNET3 driver with the one developed by Brocade. > The Intel code was a missing features, and had style and other issues. > > Major changes: > - supports multi-segment > - supports vlan offload > - per queue s

[dpdk-dev] [PATCH v3] app/testpmd: list forwarding engines

2014-05-15 Thread Thomas Monjalon
Having a function to list forwarding engines helps to show them in cli help and in parameters usage witout duplicating code. Signed-off-by: Thomas Monjalon --- app/test-pmd/cmdline.c| 52 +++ app/test-pmd/config.c | 19 + app/te

[dpdk-dev] [PATCH v2 6/6] mk: add "make examples" target in root makefile

2014-05-15 Thread Olivier MATZ
Hi Thomas, Thank you for your comments. On 05/14/2014 04:04 PM, Thomas Monjalon wrote: >> +# Build directory is given with O= >> +ifndef O >> +O = $(RTE_SDK)/examples >> +endif >> + >> +# Target for which examples should be built. >> +ifndef T >> +T = * >> +endif > > Using "?=" should be cleaner

[dpdk-dev] [PATCH RFC 11/11] ixgbe/mbuf: add TSO support

2014-05-15 Thread Olivier MATZ
Hi Konstantin, On 05/15/2014 05:09 PM, Ananyev, Konstantin wrote: > By design PMD not supposed to touch (or even look) into actual packet's data. I agree on the principle, we should avoid that as much as possible. > That is one of the reason why we put l2/l3/l4_len fields into the mbuf itself. >

[dpdk-dev] System hangs when using dpdk in a guest machine

2014-05-15 Thread Nikos Anastopoulos
Hi, I am experiencing an irrecoverable system hang when trying to run the 'helloworld' dpdk example from within a CentOS 6.5 guest (4 VCPUS, 7GB RAM), running on VirtualBox (Windows host). Specifically, I have successfully built dpdk-1.6.0r2 for the "x86_64-ivshmem-linuxapp-gcc" target. I perform

[dpdk-dev] [PATCH RFC 11/11] ixgbe/mbuf: add TSO support

2014-05-15 Thread Ananyev, Konstantin
Hi Oliver, With the current DPDK implementation the upper code would still be different for TCP checksum (without segmentation) and TCP segmentation: different flags in mbuf, with TSO you need to setup l4_len and mss fields inside mbuf, with just checksum - you don't. Plus, as I said, it is a bi

[dpdk-dev] [PATCH RFC 11/11] ixgbe/mbuf: add TSO support

2014-05-15 Thread Ananyev, Konstantin
Hi Oliver, By design PMD not supposed to touch (or even look) into actual packet's data. That is one of the reason why we put l2/l3/l4_len fields into the mbuf itself. Also it seems a bit strange to calculate one pseudo-header checksum in the upper layer and then Recalculate it again inside testp

[dpdk-dev] [PATCH RFC 05/11] mbuf: merge physaddr and buf_len in a bitfield

2014-05-15 Thread Olivier MATZ
Hi Konstantin, On 05/14/2014 04:07 PM, Ananyev, Konstantin wrote: > Apart from performance impact, one more concern: > As I know, theoretical limit for PA on Intel is 52 bits. > I understand that these days no-one using more than 48 bits and it probably > would stay like that for next few years.

[dpdk-dev] [PATCH v2] app/testpmd: list forwarding modes

2014-05-15 Thread Thomas Monjalon
Having a function to list forwarding modes helps to show them in cli help and in parameters usage witout duplicating code. Signed-off-by: Thomas Monjalon --- app/test-pmd/cmdline.c| 55 --- app/test-pmd/config.c | 19 app/test-

[dpdk-dev] [PATCH 5/6] ether: allow setting mac address

2014-05-15 Thread Ivan Boule
Hi Stephen, By default, changing the [current] default MAC address of a device is not equivalent to adding a MAC address to it ! At least, the minimum to do should consist in: 1. checking that the PMD exports both mac_addr_remove() and mac_addr_add() functions, returning a NON_SUPPORTED error c

[dpdk-dev] [PATCH 2/6] Subjet: ethdev: add common code to atomicly access link

2014-05-15 Thread Ivan Boule
Hi Stephen, The new function rte_eth_dev_set_link() below is declared as void. Thus, the comments about its return value are wrong, and should be removed, unless they still refer to a desired behaviour, in which case it is the function itself that should be reworked to invoke rte_atomic64_cmpset a

[dpdk-dev] [PATCH RFC 01/11] igb/ixgbe: fix IP checksum calculation

2014-05-15 Thread Ananyev, Konstantin
-Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz Sent: Friday, May 09, 2014 3:50 PM To: dev at dpdk.org Subject: [dpdk-dev] [PATCH RFC 01/11] igb/ixgbe: fix IP checksum calculation According to Intel? 82599 10 GbE Controller Datasheet (Table 7-38), bot

[dpdk-dev] [PATCH 3/3] Upgrade share codes:change Copyright date of e1000_osdep.c and e1000_osdep.h files

2014-05-15 Thread Jijiang Liu
Signed-off-by: Jijiang Liu --- lib/librte_pmd_e1000/e1000/e1000_osdep.c |2 +- lib/librte_pmd_e1000/e1000/e1000_osdep.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_pmd_e1000/e1000/e1000_osdep.c b/lib/librte_pmd_e1000/e1000/e1000_osdep.c index 7a569b2

[dpdk-dev] [PATCH 2/3] Upgrade share codes:fix an issue of hash calculation of flow director introduced by upgrading NIC share codes

2014-05-15 Thread Jijiang Liu
Signed-off-by: Jijiang Liu --- lib/librte_pmd_ixgbe/ixgbe_fdir.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/librte_pmd_ixgbe/ixgbe_fdir.c b/lib/librte_pmd_ixgbe/ixgbe_fdir.c index 0d91ff9..54ebf73 100644 --- a/lib/librte_pmd_ixgbe/ixgbe_fdir.c +++ b/lib/lib

[dpdk-dev] [PATCH 1/3] Upgrade share codes:upgrade NIC shared code in ixgbe & e1000 directories

2014-05-15 Thread Jijiang Liu
Signed-off-by: Jijiang Liu --- lib/librte_eal/common/include/rte_pci_dev_ids.h |8 - lib/librte_pmd_e1000/e1000/README |2 +- lib/librte_pmd_e1000/e1000/e1000_80003es2lan.c | 44 +- lib/librte_pmd_e1000/e1000/e1000_80003es2lan.h |2 +- lib/librte_pmd_e1000/e1000/e10

[dpdk-dev] [PATCH 0/3] *** Upgrade NIC share codes ***

2014-05-15 Thread Jijiang Liu
This patchset upgrades NIC share code in ixgbe & e1000 directories and fixs an issue of hash calculation of flow director introduced by upgrading this. Short summary: * Upgrading NIC share code in ixgbe & e1000 directories * Changing README in ixgbe & e1000 directories * Changing ixgbe_osdep.h fi