When setting up an app to run using the uio driver, errors caused by
VFIO failures should not abruptly cause the app to fail.
Example: on a board with 8 ports bound to igb_uio module, and no VFIO
configuration, a testpmd run currently fails with:
EAL: cannot open VFIO container!
EAL: :04:
The below patch is the quickest fix I found to make my applications work again,
but I'm not sure it's the best solution. Can anyone else offer other
suggestions to improve this?
> -Original Message-
> From: Richardson, Bruce
> Sent: Monday, June 16, 2014 3:29 PM
> To: dev at dpdk.org
> C
Hi all,
Now that vfio support has merged into the dpdk.org mainline, I'm seeing a
number of issues with running applications, and I'm hoping someone can explain
the observed behaviour.
I have a number of NIC ports which were working correctly yesterday and are
bound correctly to the igb_uio dr
2014-06-16 13:47, Neil Horman:
> But lets not just quietly start abandoning stuff because its inconvienient.
Fully agree. The minimum is to have "TODO" comments.
And please, don't consider existing API as a reference.
We must build a convenient and robust API, and probably break
the existing one i
2014-06-16 15:31, Jingjing Wu:
> A generic filter mechanism for handling special packet is required.
> It will allow filters to be set in HW when available so that specific
> packet may be filtered by NICs to specific descriptor queues for
> processing. Currently only Flow Director for Intel's 10Gb
> Anatoly Burakov (13):
> ip_frag: Moving fragmentation/reassembly headers into a separate
> library
> Refactored IPv4 fragmentation into a proper library
> Fixing issues reported by checkpatch
> ip_frag: new internal common header
> ip_frag: removed unneeded check and macro
> ip_fr
> -Original Message-
> From: Neil Horman [mailto:nhorman at tuxdriver.com]
> Sent: Monday, June 16, 2014 10:48 AM
> To: Richardson, Bruce
> Cc: Doherty, Declan; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 2/5] Link Bonding PMD Library
> (librte_eal/librte_ether link bonding support
Hi David,
> This patchset introduces 3 new ethdev operations: flow control parameters
> retrieval and mtu get/set operations.
> Changes since v1:
> - compute min rx buffer size at ethdev level (to simplify pmd mtu checks)
> - introduce enable_scatter rx mode so that we can advise pmd to configure
> -Original Message-
<...snip...>
> > this doesn't seem like an idea solution either. I'm not 100% clear why
> > rte_eal_pci_probe is currently called by the application code and not
> > initiated
> > from within rte_eal_dev_init, if this was the case we would be able to
> > figure
>
add commands in testpmd for NIC filters:
add_ethertype_filter
remove_ethertype_filter
get_ethertype_filter
add_2tuple_filter
remove_2tuple_filter
get_2tuple_filter
add_5tuple_filter
remove_5tuple_filter
get_5tuple_filter
add_syn_filter
remove_syn_filter
get_syn_filter
add_flex_filter
remove_flex_fi
This patch adds following ixgbe NIC filters implement:
syn filter, ethertype filter, 5tuple filter for intel NIC 82599
Signed-off-by: jingjing.wu
---
lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 440
lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 34 +++
2 files changed,
This patch adds following igb NIC filters implement:
syn filter, ethertype filter, 2tuple filter, flex filter for intel NIC 82580
and i350
syn filter, ethertype filter, 5tuple filter for intel NIC 82576
Signed-off-by: jingjing.wu
---
lib/librte_pmd_e1000/e1000_ethdev.h | 53 +++
lib/librte
This patch adds APIs for NIC filters list below:
ethertype filter, syn filter, 2tuple filter, flex filter, 5tuple filter
Signed-off-by: jingjing.wu
---
lib/librte_ether/rte_ethdev.c | 275 +++
lib/librte_ether/rte_ethdev.h | 428 ++
--- the v4 patchset changes:
--- change the type of rx_queue to uint16_t
--- change the parameter of rte_eth_dev_add_syn_filter API
--- the v3 patchset changes:
--- comments alignment
--- the v2 patchset changes:
--- add NIC filter support for 82576
--- rework for the whitespace and tab warning i
2014-06-16 09:28, Burakov, Anatoly:
> 2014-06-16 11:08, Thomas Monjalon:
> > The signed-off-by line disappeared from v6 patches.
> > I assume to be
> > Signed-off-by: Anatoly Burakov
> > Please confirm.
>
> Yes, sorry about that, was having a rather long day :-(
> Both VFIO and tailq patc
Tested-by: Waterman Cao
This patch includes 4 files, and has been tested by Intel.
Please see test environment information as the following:
Fedora 20 x86_64, Linux Kernel 3.11.10-301, GCC 4.8.2 Intel Xeon CPU E5-2680
v2 @ 2.80GHz
NIC: Intel Niantic 82599, Intel i350, Intel 82580 and Intel 8257
Hi Bruce,
>> > However, even with that, I would suggest that any limit should be possible
>> > to
>> override. It's entirely possible that someone max actually want to reserve
>> the
>> full number of VFs, either because they don't want to use the NIC on the
>> host at
>> all, or because they
On Mon, Jun 16, 2014 at 04:17:03PM +, Richardson, Bruce wrote:
>
>
> > -Original Message-
> <...snip...>
> > > this doesn't seem like an idea solution either. I'm not 100% clear why
> > > rte_eal_pci_probe is currently called by the application code and not
> > > initiated
> > > fr
Signed-off-by: Declan Doherty
---
doc/doxy-api-index.md |1 +
doc/doxy-api.conf |1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/doc/doxy-api-index.md b/doc/doxy-api-index.md
index 83303a1..8338a9b 100644
--- a/doc/doxy-api-index.md
+++ b/doc/doxy-api-index.md
@@
- Includes the ability to create new bonded devices.
- Add /remove bonding slave devices.
- Interogate bonded device stats/configuration
- Change bonding modes and select balance transmit polices
Signed-off-by: Declan Doherty
---
app/test-pmd/cmdline.c| 571 +
Including:
- code to generate packet bursts for testing rx and tx
functionality of bonded device
- virtual/stubbed out ethdev for use as slave ethdev in testing
Signed-off-by: Declan Doherty
---
app/test/Makefile |4 +-
app/test/commands.c |7 +
app/tes
Updating functionality in EAL to support adding link bonding
devices via ?vdev option. Link bonding devices will be
initialized after all physical devices have been probed and
initialized.
Signed-off-by: Declan Doherty
---
lib/librte_eal/common/eal_common_dev.c | 66 ++
Adding support to rte_eth_dev_data structure to support unique
name identifier for ethdevs to support adding slave ethdevs
(specifically virtual devices which have no public unique
identifier) to a link bonding device. This changes the API
rte_eth_dev_allocate() to require a const char *name when
a
Signed-off-by: Declan Doherty
---
config/common_bsdapp |5 +
config/common_linuxapp |5 +
lib/Makefile |1 +
lib/librte_pmd_bond/Makefile | 32 +
lib/librte_pmd_bond/rte_eth_bond.c | 2149
li
AThis patch contains the initial release of the Link Bonding PMD Library
Supporting bonding modes:
0 - Round Robin
1 - Active Backup
2 - Balance (Supporting 3 transmission polices)
layer 2, layer 2+3, layer 3+4
3 - Broadcast
Version 4 of patch set:
- Fixes some checkpatch formatting
Signed-off-by: Alan Carew
---
config/common_bsdapp | 2 +-
lib/librte_pmd_virtio/virtio_ethdev.c | 28 +++-
lib/librte_pmd_virtio/virtio_pci.h| 5 ++---
3 files changed, 30 insertions(+), 5 deletions(-)
diff --git a/config/common_bsdapp b/config/com
Following discussion with Stephen Hemminger and Neil Horman:
http://dpdk.org/ml/archives/dev/2014-June/003139.html
http://dpdk.org/ml/archives/dev/2014-June/00.html
http://dpdk.org/ml/archives/dev/2014-June/003295.html
There is no need for sysfs entries, instead localise the logic to
virtio_et
I can get this working after some changes.
1. I have pci_assign=buses and intel_iommu=on present in grub.conf ,
Removed them
2. Before running l2fwd application, removed ixgbe driver. I was actually
getting some kernel errors without these steps, while running l2fwd application.
Now, I can see th
Joubert,
By all means, look at the existing PMDs. It also helps if you have an existing
kernel driver to use/modify (preferably BSD based). That way you can have a
baseline to compare against.
At least, that is method I used.
Patrick
> On Jun 13, 2014, at 9:08 AM, Joubert Berger wrote:
>
Discription: This patch is aimed to fix the the pointer 'ctx1' uninitialized
error with gcc4.5.1 as described below:
"dpdk/lib/librte_kvargs/rte_kvargs.c:51:14: error: 'ctx1' may be used
uninitialized in this function"
Signed-off-by: Cao Min
Acked-by: Liu, Jijiang
Tested-by: Waterman Cao
---
Description: This patch is aimed to fix the the pointer 'ctx1' uninitialized
error with gcc4.5.1 as described below.
Download dpdk source code from http://dpdk.org, and compile the source
code(commit cc333208d5658fea642098b665cd429e6cda54a9).
It has the following compilation error on fedora14 wit
Hi Anatoly,
The signed-off-by line disappeared from v6 patches.
I assume to be
Signed-off-by: Anatoly Burakov
Please confirm.
--
Thomas
2014-06-13 23:52, Bruce Richardson:
> New file containing optimized receive and transmit functions which
> use 128bit vector instructions to improve performance. When conditions
> permit, these functions will be enabled at runtime by the device
> initialization routines already in the PMD.
>
> The
> -Original Message-
> From: Carew, Alan
> Sent: Thursday, June 05, 2014 3:39 PM
> To: dev at dpdk.org
> Cc: Carew, Alan
> Subject: [PATCH 0/4] librte_pmd_virtio :Fix: virtio_pci.h non-existent virtio
> feature bit-flag tested
>
> This series addresses an issue with librte_pmd_virtio where
Discription: This patch is aimed to fix the the pointer 'ctx1' uninitialized
error with gcc4.5.1 as described below:
"dpdk/lib/librte_kvargs/rte_kvargs.c:51:14: error: 'ctx1' may be used
uninitialized in this function"
Signed-off-by: Zhan Zhaochen
Acked-by: Liu, Jijiang
Tested-by: Waterman Cao
Description: This patch is aimed to fix the the pointer 'ctx1' uninitialized
error with gcc4.5.1 as described below.
Download dpdk source code from http://dpdk.org, and compile the source
code(commit cc333208d5658fea642098b665cd429e6cda54a9).
It has the following compilation error on fedora14 wit
Hi Thomas,
> The signed-off-by line disappeared from v6 patches.
> I assume to be
> Signed-off-by: Anatoly Burakov Please
> confirm.
Yes, sorry about that, was having a rather long day :-( Both VFIO and tailq
patches assume signoff.
Best regards,
Anatoly Burakov
DPDK SW Engineer
> -Original Message-
> From: Neil Horman [mailto:nhorman at tuxdriver.com]
> Sent: Friday, June 13, 2014 8:38 PM
> To: Doherty, Declan
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 2/5] Link Bonding PMD Library
> (librte_eal/librte_ether link bonding support changes)
>
> On Fri
> -Original Message-
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Wednesday, June 11, 2014 9:08 PM
> To: Carew, Alan
> Cc: Neil Horman; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 09/10] igbuio: show irq mode in sysfs
>
> This is what I am testing, along
Hi Bruce, Stephen,
> > Hello,
> >
> > I have seen a case where a secondary DPDK process tries to map uio
> > resource in which mmap() normally sends the corresponding virtual
> > address as a hint address. However on some instances mmap() returns a
> > virtual address that is not the hint address
> -Original Message-
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Friday, June 13, 2014 10:59 PM
> To: Doherty, Declan
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 2/5] Link Bonding PMD Library
> (librte_eal/librte_ether link bonding support changes)
On Mon, Jun 16, 2014 at 08:59:25AM +, Doherty, Declan wrote:
> > -Original Message-
> > From: Neil Horman [mailto:nhorman at tuxdriver.com]
> > Sent: Friday, June 13, 2014 8:38 PM
> > To: Doherty, Declan
> > Cc: dev at dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v3 2/5] Link Bonding PMD
42 matches
Mail list logo