[dpdk-dev] [PATCH 1/2] igb_uio: fix compability on old kernel

2014-09-01 Thread Guillaume Gaudonville
On 08/22/2014 08:09 PM, Robert Sanford wrote: > This is what we came up with. It works for us. In our kernel headers' > linux/pci.h, pci_num_vf is enclosed within "#ifdef CONFIG_PCI_IOV/#endif"; > pci_intx_mask_supported and pci_check_and_mask_intx are enclosed within > "#ifdef HAVE_PCI_SET_MWI/#en

[dpdk-dev] [PATCH 1/2] igb_uio: fix compability on old kernel

2014-09-01 Thread Guillaume Gaudonville
On 07/25/2014 07:36 PM, Stephen Hemminger wrote: > Add more compatibility wrappers, and split out all the wrapper > code to a separate file. Builds on Debian Squeeze (2.6.32) which > is oldest version of kernel current DPDK supports. > > Signed-off-by: Stephen Hemminger > > --- > lib/librte_eal/

[dpdk-dev] [PATCHv5] librte_acl make it build/work for 'default' target

2014-09-01 Thread Konstantin Ananyev
Make ACL library to build/work on 'default' architecture: - make rte_acl_classify_scalar really scalar (make sure it wouldn't use sse4 instrincts through resolve_priority()). - Provide two versions of rte_acl_classify code path: rte_acl_classify_sse() - could be build and used only on systems wi

[dpdk-dev] reg : adding grub entry with hugepages.

2014-09-01 Thread Anand S Angadi
On 09/01/2014 02:36 PM, Matthew Hall wrote: > On Mon, Sep 01, 2014 at 02:32:40PM +0530, Anand S Angadi wrote: >>> Hello everyone, >>> I am using fedora 16, i want to Add additional Grub entry with hugepages >>> enabled permanently can u tell me how can i add? >>> and wher can i add? > Try /etc/def

[dpdk-dev] reg : adding grub entry with hugepages.

2014-09-01 Thread Anand S Angadi
On 09/01/2014 02:22 PM, Zhang, Jerry wrote: > Hi, > >Here is an example to enable both 1G and 2M in kernel parameters. > > default_hugepagesz=1G hugepagesz=1G hugepages=8 hugepagesz=2M hugepages=512 > > > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Anand

[dpdk-dev] reg : adding grub entry with hugepages.

2014-09-01 Thread Anand S Angadi
Hello everyone, I am using fedora 16, i want to Add additional Grub entry with hugepages enabled permanently can u tell me how can i add? and wher can i add? -- Thanks & Regards, ANAND

[dpdk-dev] [PATCH 1/2] igb_uio: fix compability on old kernel

2014-09-01 Thread Thomas Monjalon
Hi Robert, 2014-08-26 11:08, Sanford, Robert: > >> This is what we came up with. It works for us. In our kernel headers' > >> linux/pci.h, pci_num_vf is enclosed within "#ifdef > >>CONFIG_PCI_IOV/#endif"; > >> pci_intx_mask_supported and pci_check_and_mask_intx are enclosed within > >> "#ifdef HAV

[dpdk-dev] [PATCHv4] librte_acl make it build/work for 'default' target

2014-09-01 Thread Thomas Monjalon
2014-08-29 17:58, Ananyev, Konstantin: > Good way to overcome the problem. > From what I am seeing it adds a tiny slowdown (as expected) ... > Though it provides a good flexibility and I don't have any better ideas. > So I'd say let stick with that approach. Nice work guys. I'd like to have this

[dpdk-dev] [PATCH] testpmd: fix crash in txonly mode and when using tx_first

2014-09-01 Thread Thomas Monjalon
2014-09-01 12:31, David Marchand: > From: Adrien Mazarguil > > This crash was believed fixed by commit > 5886ae07d211e4b5e49806dd183812beb31c67ad, > but the actual issue is that the core ID provided to rte_lcore_to_socket_id() > is > wrong. It must be looked up in fwd_lcores_cpuids[]. > > Sign

[dpdk-dev] [PATCH] testpmd: fix crash in txonly mode and when using tx_first

2014-09-01 Thread David Marchand
From: Adrien Mazarguil This crash was believed fixed by commit 5886ae07d211e4b5e49806dd183812beb31c67ad, but the actual issue is that the core ID provided to rte_lcore_to_socket_id() is wrong. It must be looked up in fwd_lcores_cpuids[]. Signed-off-by: Adrien Mazarguil Signed-off-by: David Mar

[dpdk-dev] [PATCH v2 17/17] eal: set log level from command line

2014-09-01 Thread David Marchand
Add a --log-level option to set the default eal log level. Signed-off-by: David Marchand --- lib/librte_eal/bsdapp/eal/eal.c| 42 +++ .../bsdapp/eal/include/eal_internal_cfg.h |1 + lib/librte_eal/linuxapp/eal/eal.c | 44 +

[dpdk-dev] [PATCH v2 16/17] e1000: add a message when forcing scatter mode

2014-09-01 Thread David Marchand
Signed-off-by: David Marchand --- lib/librte_pmd_e1000/em_rxtx.c |4 lib/librte_pmd_e1000/igb_rxtx.c | 14 ++ 2 files changed, 18 insertions(+) diff --git a/lib/librte_pmd_e1000/em_rxtx.c b/lib/librte_pmd_e1000/em_rxtx.c index 83ecb33..a6cea32 100644 --- a/lib/librte_pmd_

[dpdk-dev] [PATCH v2 15/17] e1000: always log init messages

2014-09-01 Thread David Marchand
'init' messages should always be logged and filtered at runtime by rte_log. All the more so as these messages are not in the datapath. Signed-off-by: David Marchand --- lib/librte_pmd_e1000/e1000_logs.h |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/librte_pmd_

[dpdk-dev] [PATCH v2 14/17] e1000: clean log messages

2014-09-01 Thread David Marchand
Clean log messages: - remove leading \n in some messages, - remove trailing \n in some messages, - split multi lines messages, - replace some PMD_INIT_LOG(DEBUG, "some_func") with PMD_INIT_FUNC_TRACE(). Signed-off-by: David Marchand --- lib/librte_pmd_e1000/e1000_logs.h |4 +- lib/librte_pmd

[dpdk-dev] [PATCH v2 13/17] e1000/base: add a _RAW macro for use by shared code

2014-09-01 Thread David Marchand
Since shared code always add a trailing \n, add a PMD_DRV_LOG_RAW macro that will not add one. Signed-off-by: David Marchand --- lib/librte_pmd_e1000/e1000/e1000_osdep.h |4 ++-- lib/librte_pmd_e1000/e1000_logs.h|9 ++--- 2 files changed, 8 insertions(+), 5 deletions(-) diff

[dpdk-dev] [PATCH v2 12/17] e1000: use the right debug macro

2014-09-01 Thread David Marchand
- We should not use DEBUGOUT* / DEBUGFUNC macros in non-shared code. These macros come as compat wrappers for shared code. - We should avoid calling RTE_LOG directly as pmd provides a wrapper for logs. Signed-off-by: David Marchand --- lib/librte_pmd_e1000/em_rxtx.c| 32 ++-

[dpdk-dev] [PATCH v2 11/17] i40e: add log messages when rx bulk mode is not usable

2014-09-01 Thread David Marchand
Signed-off-by: David Marchand --- lib/librte_pmd_i40e/i40e_rxtx.c | 29 - 1 file changed, 24 insertions(+), 5 deletions(-) diff --git a/lib/librte_pmd_i40e/i40e_rxtx.c b/lib/librte_pmd_i40e/i40e_rxtx.c index 70fabaa..f410600 100644 --- a/lib/librte_pmd_i40e/i40e_rxt

[dpdk-dev] [PATCH v2 10/17] i40e: always log init messages

2014-09-01 Thread David Marchand
'init' messages should always be logged and filtered at runtime by rte_log. All the more so as these messages are not in the datapath. Signed-off-by: David Marchand --- lib/librte_pmd_i40e/i40e_logs.h |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/librte_pmd_i4

[dpdk-dev] [PATCH v2 09/17] i40e: clean log messages

2014-09-01 Thread David Marchand
Clean log messages: - remove leading \n in some messages, - remove trailing \n in some messages, - split multi lines messages, - replace some PMD_INIT_LOG(DEBUG, "some_func") with PMD_INIT_FUNC_TRACE(). Signed-off-by: David Marchand --- lib/librte_pmd_i40e/i40e_ethdev.c| 418 +++

[dpdk-dev] [PATCH v2 08/17] i40e/base: add a _RAW macro for use by shared code

2014-09-01 Thread David Marchand
Since shared code always add a trailing \n, add a PMD_DRV_LOG_RAW macro that will not add one. Signed-off-by: David Marchand --- lib/librte_pmd_i40e/i40e/i40e_osdep.h |8 lib/librte_pmd_i40e/i40e_logs.h |9 ++--- 2 files changed, 10 insertions(+), 7 deletions(-) diff

[dpdk-dev] [PATCH v2 07/17] i40e: use the right debug macro

2014-09-01 Thread David Marchand
- Don't use DEBUGFUNC macro in non-shared code. - Don't use printf for logs. - We should avoid calling RTE_LOG directly as pmd provides a wrapper for logs. Signed-off-by: David Marchand --- lib/librte_pmd_i40e/i40e_ethdev.c| 146 +- lib/librte_pmd_i40e/i40e_e

[dpdk-dev] [PATCH v2 06/17] ixgbe: add log messages when rx bulk mode is not usable

2014-09-01 Thread David Marchand
Signed-off-by: David Marchand --- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 29 - 1 file changed, 24 insertions(+), 5 deletions(-) diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c index dbbe612..f1cecf7 100644 --- a/lib/librte_pmd_ixgbe/

[dpdk-dev] [PATCH v2 05/17] ixgbe: add a message when forcing scatter mode

2014-09-01 Thread David Marchand
Signed-off-by: David Marchand --- lib/librte_pmd_ixgbe/ixgbe_rxtx.c |8 1 file changed, 8 insertions(+) diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c index 981df60..dbbe612 100644 --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c +++ b/lib/librte_pmd_ixgb

[dpdk-dev] [PATCH v2 04/17] ixgbe: always log init messages

2014-09-01 Thread David Marchand
'init' messages should always be logged and filtered at runtime by rte_log. All the more so as these messages are not in the datapath. Signed-off-by: David Marchand --- lib/librte_pmd_ixgbe/ixgbe_logs.h |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/librte_pmd_

[dpdk-dev] [PATCH v2 03/17] ixgbe: clean log messages

2014-09-01 Thread David Marchand
Clean log messages: - remove leading \n in some messages, - remove trailing \n in some messages, - split multi lines messages, - replace some PMD_INIT_LOG(DEBUG, "some_func") with PMD_INIT_FUNC_TRACE(). Signed-off-by: David Marchand --- lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 150

[dpdk-dev] [PATCH v2 02/17] ixgbe/base: add a _RAW macro for use by shared code

2014-09-01 Thread David Marchand
Since shared code always add a trailing \n, add a PMD_DRV_LOG_RAW macro that will not add one. Signed-off-by: David Marchand --- lib/librte_pmd_ixgbe/ixgbe/ixgbe_osdep.h |4 ++-- lib/librte_pmd_ixgbe/ixgbe_logs.h|9 ++--- 2 files changed, 8 insertions(+), 5 deletions(-) diff

[dpdk-dev] [PATCH v2 01/17] ixgbe: use the right debug macro

2014-09-01 Thread David Marchand
- We should not use DEBUGOUT*/DEBUGFUNC macros in non-shared code. These macros come as compat wrappers for shared code. - We should avoid calling RTE_LOG directly as pmd provides a wrapper for logs. Signed-off-by: David Marchand --- lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c | 14 lib

[dpdk-dev] [PATCH v2 00/17] cleanup logs in main PMDs

2014-09-01 Thread David Marchand
Here is a patchset that reworks the log macro in e1000, ixgbe and i40e PMDs. The idea behind this is to make it easier to debug some init failures and to be sure of the datapath selected in these PMDs (rx / tx handlers selection). The PMDs changes involve adding more debug messages in the default

[dpdk-dev] reg : adding grub entry with hugepages.

2014-09-01 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zhang, Jerry > Sent: Monday, September 01, 2014 10:37 AM > To: Anand S Angadi > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] reg : adding grub entry with hugepages. > > >> Hello everyone, > >> I am using fedora

[dpdk-dev] reg : adding grub entry with hugepages.

2014-09-01 Thread Zhang, Jerry
>-Original Message- >From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Anand S Angadi >Sent: Monday, September 1, 2014 5:27 PM >To: Matthew Hall >Cc: dev at dpdk.org >Subject: Re: [dpdk-dev] reg : adding grub entry with hugepages. > >On 09/01/2014 02:36 PM, Matthew Hall wrote: >> On M

[dpdk-dev] reg : adding grub entry with hugepages.

2014-09-01 Thread Zhang, Jerry
>> Hello everyone, >> I am using fedora 16, i want to Add additional Grub entry with hugepages >enabled permanently can u tell me how can i add? >> and wher can i add? >> >> -- >> Thanks & Regards, >> ANAND >> >> >> >> >Hi Zhang, >Thank you for your reply, now I am using same thing but i want it pe

[dpdk-dev] [PATCH v2 6/6] testpmd: adding parameter to reconfig method to set socket_id when adding new port to portlist

2014-09-01 Thread Declan Doherty
Signed-off-by: Declan Doherty --- app/test-pmd/cmdline.c |2 +- app/test-pmd/testpmd.c |3 ++- app/test-pmd/testpmd.h |2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index b04a4e8..a0d88df 100644 --- a/app/test-pmd

[dpdk-dev] [PATCH v2 5/6] test app: adding support for generating variable sized packets

2014-09-01 Thread Declan Doherty
Signed-off-by: Declan Doherty --- app/test/packet_burst_generator.c | 22 +++--- app/test/packet_burst_generator.h |6 +- app/test/test_link_bonding.c | 14 +- 3 files changed, 21 insertions(+), 21 deletions(-) diff --git a/app/test/packet_burst_gene

[dpdk-dev] [PATCH v2 4/6] bond: free mbufs if transmission fails in bonding tx_burst functions

2014-09-01 Thread Declan Doherty
Fixing a number of corner cases that if transmission failed on slave devices then this could lead to leaked mbufs V2 addresses behaviouraly issues in the first version and packets are no longer freed in the bonding layer, except in the case of broadcast mode where in failures happen on more t

[dpdk-dev] [PATCH v2 3/6] bond: fix naming inconsistency in tx_burst_round_robin

2014-09-01 Thread Declan Doherty
Signed-off-by: Declan Doherty --- lib/librte_pmd_bond/rte_eth_bond_pmd.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c b/lib/librte_pmd_bond/rte_eth_bond_pmd.c index 683b146..70123fc 100644 --- a/lib/librte_pmd_bond/rte_

[dpdk-dev] [PATCH v2 2/6] bond: removing switch statement from rx burst method

2014-09-01 Thread Declan Doherty
Signed-off-by: Declan Doherty --- lib/librte_pmd_bond/rte_eth_bond_pmd.c | 62 ++-- 1 files changed, 35 insertions(+), 27 deletions(-) diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c b/lib/librte_pmd_bond/rte_eth_bond_pmd.c index cd3eecf..683b146 100644 --- a/

[dpdk-dev] [PATCH v2 1/6] bond: link status interrupt support

2014-09-01 Thread Declan Doherty
Adding support for lsc interrupt from bonded device to link bonding library with supporting unit tests in the test application. Signed-off-by: Declan Doherty --- app/test/test_link_bonding.c | 213 +++- lib/librte_pmd_bond/rte_eth_bond_api.c |4 + lib/l

[dpdk-dev] [PATCH v2 0/6] link bonding

2014-09-01 Thread Declan Doherty
This patch set adds support for link status interrupt in the link bonding pmd. It also contains some patches to tidy up the code structure and to of the link bonding code and to fix bugs relating to transmission failures in the under lying slave pmd which could lead to leaked mbufs. V2 addresse

[dpdk-dev] reg : adding grub entry with hugepages.

2014-09-01 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zhang, Jerry > Sent: Monday, September 01, 2014 9:52 AM > To: Anand S Angadi; dev at dpdk.org > Subject: Re: [dpdk-dev] reg : adding grub entry with hugepages. > > Hi, > > Here is an example to enable both 1G

[dpdk-dev] reg : adding grub entry with hugepages.

2014-09-01 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Matthew Hall > Sent: Monday, September 01, 2014 10:06 AM > To: Anand S Angadi > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] reg : adding grub entry with hugepages. > > On Mon, Sep 01, 2014 at 02:32:40PM +0530,

[dpdk-dev] reg : adding grub entry with hugepages.

2014-09-01 Thread Zhang, Jerry
Hi, Here is an example to enable both 1G and 2M in kernel parameters. default_hugepagesz=1G hugepagesz=1G hugepages=8 hugepagesz=2M hugepages=512 -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Anand S Angadi Sent: Monday, September 1, 2014 4:44 PM To: dev at d

[dpdk-dev] reg : adding grub entry with hugepages.

2014-09-01 Thread Matthew Hall
On Mon, Sep 01, 2014 at 02:32:40PM +0530, Anand S Angadi wrote: > >Hello everyone, > >I am using fedora 16, i want to Add additional Grub entry with hugepages > >enabled permanently can u tell me how can i add? > >and wher can i add? Try /etc/default/grub .