[dpdk-dev] [RFC PATCH 1/7] eal: add linear thread id as pthread-local variable

2014-12-22 Thread Ananyev, Konstantin
Hi Steve, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Cunming Liang > Sent: Thursday, December 11, 2014 2:05 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [RFC PATCH 1/7] eal: add linear thread id as > pthread-local variable > > > Signed-off-by: Cunmi

[dpdk-dev] [PATCH RFC 0/3] DPDK ethdev callback support

2014-12-22 Thread Thomas Monjalon
Hi Bruce, Callbacks, as hooks for applications, give more flexibility and are generally a good idea. In DPDK the main issue will be to avoid performance degradation. I see you use "unlikely" for callback branching. Could we reduce more the impact of this test by removing the queue array, i.e. havi

[dpdk-dev] [PATCH RFC 0/3] DPDK ethdev callback support

2014-12-22 Thread Bruce Richardson
On Mon, Dec 22, 2014 at 06:02:53PM +0100, Thomas Monjalon wrote: > Hi Bruce, > > Callbacks, as hooks for applications, give more flexibility and are > generally a good idea. > In DPDK the main issue will be to avoid performance degradation. > I see you use "unlikely" for callback branching. > Coul

[dpdk-dev] [PATCH 1/4] compat: Add infrastructure to support symbol versioning

2014-12-22 Thread Gonzalez Monroy, Sergio
> From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Monday, December 22, 2014 4:35 PM > > On Mon, Dec 22, 2014 at 02:01:10PM +, Gonzalez Monroy, Sergio wrote: > > > > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > > Sent: Saturday, December 20, 2014 9:02 PM > > We could mo

[dpdk-dev] [PATCH RFC 3/3] examples: example showing use of callbacks.

2014-12-22 Thread Bruce Richardson
Rough example showing how callbacks can be used to insert a timestamp into each packet on RX. Then on TX the timestamp is used to calculate the packet latency in cycles through the app. Signed-off-by: Bruce Richardson --- examples/rxtx_callbacks/Makefile | 57 ++ examples/rxtx_callbac

[dpdk-dev] [PATCH RFC 2/3] ethdev: Add in data rxtx callback support

2014-12-22 Thread Bruce Richardson
Add in support for inline processing of packets inside the RX or TX call. For an RX callback, what happens is that we get a set of packets from the NIC and then pass them to a callback function, if configured, to allow additional processing to be done on them, e.g. filling in more mbuf fields, befo

[dpdk-dev] [PATCH RFC 1/3] ethdev: rename callbacks field to intr_cbs

2014-12-22 Thread Bruce Richardson
The callbacks member of the rte_eth_dev structure has been renamed to intr_cbs to make it clear that it refers to callbacks from NIC interrupts. This then allows us to add other types of callbacks to the structure without ambiguity. Signed-off-by: Bruce Richardson --- app/test/virtual_pmd.c

[dpdk-dev] [PATCH RFC 0/3] DPDK ethdev callback support

2014-12-22 Thread Bruce Richardson
This RFC is for a small addition to the ethdev library, to add in support for callbacks at the RX and TX stages. This allows packet processing to be done on packets before they get returned to applications using rte_eth_rx_burst call. Use case: the first use case for this is to enable a consistent

[dpdk-dev] [PATCH v2 4/4] docs: Add ABI documentation

2014-12-22 Thread Neil Horman
Adding a document describing rudimentary ABI policy and adding notice space for any deprecation announcements Signed-off-by: Neil Horman CC: Thomas Monjalon CC: "Richardson, Bruce" --- doc/abi.txt | 17 + 1 file changed, 17 insertions(+) create mode 100644 doc/abi.txt diff --

[dpdk-dev] [PATCH v2 3/4] Add library version extenstion

2014-12-22 Thread Neil Horman
To differentiate libraries that break ABI, we add a library version number suffix to the library, which must be incremented when a given libraries ABI is broken. This patch enforces that addition, sets the initial abi soname extension to 1 for each library and creates a symlink to the base SONAME

[dpdk-dev] [PATCH v2 2/4] Provide initial versioning for all DPDK libraries

2014-12-22 Thread Neil Horman
Add linker version script files to each DPDK library to put a stake in the ground from which we can start cleaning up API's Signed-off-by: Neil Horman CC: Thomas Monjalon CC: "Richardson, Bruce" --- Change Notes: v2) * Updated export map to not require full path --- lib/librte_acl/Ma

[dpdk-dev] [PATCH v2 1/4] compat: Add infrastructure to support symbol versioning

2014-12-22 Thread Neil Horman
Add initial pass header files to support symbol versioning. Signed-off-by: Neil Horman CC: Thomas Monjalon CC: "Richardson, Bruce" CC: "Gonzalez Monroy, Sergio" Change Notes: V2) Moved ifeq to _INSTALL target --- lib/Makefile | 1 + lib/librte_compat/Makefile |

[dpdk-dev] [PATCH 1/4] compat: Add infrastructure to support symbol versioning

2014-12-22 Thread Neil Horman
On Mon, Dec 22, 2014 at 02:00:17PM -0500, Neil Horman wrote: > On Mon, Dec 22, 2014 at 05:09:55PM +, Gonzalez Monroy, Sergio wrote: > > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > > Sent: Monday, December 22, 2014 4:35 PM > > > > > > On Mon, Dec 22, 2014 at 02:01:10PM +, Gonz

[dpdk-dev] [PATCH 1/4] compat: Add infrastructure to support symbol versioning

2014-12-22 Thread Gonzalez Monroy, Sergio
Hi Neil, Just a couple of minor comments. > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Saturday, December 20, 2014 9:02 PM > Subject: [PATCH 1/4] compat: Add infrastructure to support symbol > versioning > > Add initial pass header files to support symbol versioning. > [...] >

[dpdk-dev] [PATCH 1/4] compat: Add infrastructure to support symbol versioning

2014-12-22 Thread Neil Horman
On Mon, Dec 22, 2014 at 05:09:55PM +, Gonzalez Monroy, Sergio wrote: > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > Sent: Monday, December 22, 2014 4:35 PM > > > > On Mon, Dec 22, 2014 at 02:01:10PM +, Gonzalez Monroy, Sergio wrote: > > > > > > > From: Neil Horman [mailto:nhor

[dpdk-dev] [PATCH RFC 0/3] DPDK ethdev callback support

2014-12-22 Thread Neil Horman
On Mon, Dec 22, 2014 at 05:33:07PM +, Bruce Richardson wrote: > On Mon, Dec 22, 2014 at 06:02:53PM +0100, Thomas Monjalon wrote: > > Hi Bruce, > > > > Callbacks, as hooks for applications, give more flexibility and are > > generally a good idea. > > In DPDK the main issue will be to avoid perf

[dpdk-dev] rte_mempool_create fails with ENOMEM

2014-12-22 Thread Newman Poborsky
On Sat, Dec 20, 2014 at 2:34 AM, Stephen Hemminger wrote: > You can reserve hugepages on the kernel cmdline (GRUB). Great, thanks, I'll try that! Newman > > On Fri, Dec 19, 2014 at 12:13 PM, Newman Poborsky > wrote: >> >> On Thu, Dec 18, 2014 at 9:03 PM, Ananyev, Konstantin < >> konstantin.ana

[dpdk-dev] [PATCH 1/4] compat: Add infrastructure to support symbol versioning

2014-12-22 Thread Neil Horman
On Mon, Dec 22, 2014 at 02:01:10PM +, Gonzalez Monroy, Sergio wrote: > Hi Neil, > > Just a couple of minor comments. > > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > Sent: Saturday, December 20, 2014 9:02 PM > > Subject: [PATCH 1/4] compat: Add infrastructure to support symbol >

[dpdk-dev] [PATCH 1/4] compat: Add infrastructure to support symbol versioning

2014-12-22 Thread Neil Horman
On Mon, Dec 22, 2014 at 02:01:10PM +, Gonzalez Monroy, Sergio wrote: > Hi Neil, > > Just a couple of minor comments. > > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > Sent: Saturday, December 20, 2014 9:02 PM > > Subject: [PATCH 1/4] compat: Add infrastructure to support symbol >

[dpdk-dev] [PATCH RFC 0/3] DPDK ethdev callback support

2014-12-22 Thread Stephen Hemminger
On Mon, 22 Dec 2014 16:47:21 + Bruce Richardson wrote: > This RFC is for a small addition to the ethdev library, to add in support for > callbacks at the RX and TX stages. This allows packet processing to be done on > packets before they get returned to applications using rte_eth_rx_burst cal

[dpdk-dev] [RFC PATCH 0/7] support multi-phtread per lcore

2014-12-22 Thread Stephen Hemminger
On Mon, 22 Dec 2014 09:46:03 + Bruce Richardson wrote: > On Mon, Dec 22, 2014 at 01:51:27AM +, Liang, Cunming wrote: > > ... > > > I'm conflicted on this one. However, I think far more applications would > > > be > > > broken > > > to start having to use thread_id in place of an lcore_id

[dpdk-dev] [RFC PATCH 0/7] support multi-phtread per lcore

2014-12-22 Thread Walukiewicz, Miroslaw
> -Original Message- > From: Richardson, Bruce > Sent: Monday, December 22, 2014 10:46 AM > To: Liang, Cunming > Cc: Walukiewicz, Miroslaw; dev at dpdk.org > Subject: Re: [dpdk-dev] [RFC PATCH 0/7] support multi-phtread per lcore > > On Mon, Dec 22, 2014 at 01:51:27AM +, Liang, Cunming

[dpdk-dev] [RFC PATCH 0/7] support multi-phtread per lcore

2014-12-22 Thread Bruce Richardson
On Mon, Dec 22, 2014 at 01:51:27AM +, Liang, Cunming wrote: > ... > > I'm conflicted on this one. However, I think far more applications would be > > broken > > to start having to use thread_id in place of an lcore_id than would be > > broken > > by having the lcore_id no longer actually corre

[dpdk-dev] [PATCH RFC 5/7] ethdev: unification of flow types

2014-12-22 Thread Zhang, Helin
Hi Konstantin > > - > > -/** > > * A structure used to define the input for IPV4 flow > > */ > > struct rte_eth_ipv4_flow { > > @@ -291,7 +302,7 @@ struct rte_eth_fdir_flow_ext { > > * A structure used to define the input for a flow director filter entry > > */ > > struct rte_eth_fdir_in

[dpdk-dev] [RFC PATCH 0/7] support multi-phtread per lcore

2014-12-22 Thread Liang, Cunming
... > I'm conflicted on this one. However, I think far more applications would be > broken > to start having to use thread_id in place of an lcore_id than would be broken > by having the lcore_id no longer actually correspond to a core. > I'm actually struggling to come up with a large number of sc

[dpdk-dev] [PATCH v6] VFIO: Avoid to enable vfio while the module not loaded

2014-12-22 Thread Qiu, Michael
On 12/19/2014 4:24 PM, Thomas Monjalon wrote: > 2014-12-19 07:09, Qiu, Michael: >> Hi Thomas, >> >> Will you plan to merge this patch? If yes, you plan to merge it into >> 1.8 or 2.0? > It won't be in 1.8 for 2 reasons: > - there is a risk to break something in some environments, so need more te