[dpdk-dev] some questions about rte_memcpy

2015-01-21 Thread Matthew Hall
On Thu, Jan 22, 2015 at 01:32:04PM +0800, Linhaifeng wrote: > Do you mean if call rte_memcpy before rte_eal_init() would crash?why? No guarantee. But a theory. It might use some things from the EAL init to figure out which version of the accelerated algorithm to use. Matthew.

[dpdk-dev] [PATCH v6 4/4] docs: Add ABI documentation

2015-01-21 Thread Thomas Monjalon
2015-01-21 14:43, Neil Horman: > On Wed, Jan 21, 2015 at 05:05:51PM +0100, Thomas Monjalon wrote: > > 2015-01-21 09:59, Neil Horman: > > > Considered and answered already. I'm in favor of listing macros and > > > structure > > > changes in the abi document, but I think an exhaustive list isn't ne

[dpdk-dev] Packet drops during non-exhaustive flood with OVS and 1.8.0

2015-01-21 Thread Andrey Korolyov
Hello, I observed that the latest OVS with dpdk-1.8.0 and igb_uio starts to drop packets earlier than a regular Linux ixgbe 10G interface, setup follows: receiver/forwarder: - 8 core/2 head system with E5-2603v2, cores 1-3 are given to OVS exclusively - n-dpdk-rxqs=6, rx scattering is not enabled

[dpdk-dev] some questions about rte_memcpy

2015-01-21 Thread Matthew Hall
On Thu, Jan 22, 2015 at 11:39:11AM +0800, Linhaifeng wrote: > Why call memcpy when n is constant variable? One theory. Many DPDK functions crash if they are called before rte_eal_init() is called. So perhaps this could be a cause, since that won't have been called when working on a constant? Ma

[dpdk-dev] DPDK - TX from lcore in packet distributor configuration

2015-01-21 Thread deco33000 Jog
21.01.2015, 20:16, "deco33000 Jog" : > 21.01.2015, 17:43, "Bruce Richardson" : >> ?On Wed, Jan 21, 2015 at 03:00:50PM +0100, deco33000 Jog wrote: >>> ??Hello, >>> >>> ??-- PROBLEM >>> ??I have a AF_PACKET socket which is in promiscuous mode to get all the NIC >>> traffic and let my apps do the w

[dpdk-dev] [PATCH v4 06/11] eal/linux/pci: Add functions for unmapping igb_uio resources

2015-01-21 Thread Tetsuya Mukawa
Hi Michael, On 2015/01/20 18:23, Qiu, Michael wrote: > On 1/19/2015 6:42 PM, Tetsuya Mukawa wrote: >> The patch adds functions for unmapping igb_uio resources. The patch is only >> for Linux and igb_uio environment. VFIO and BSD are not supported. >> >> v4: >> - Add paramerter checking. >> - Add h

[dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum forwarding engine

2015-01-21 Thread Olivier MATZ
Hi Konstantin, On 01/21/2015 05:28 PM, Ananyev, Konstantin wrote: >> I added the support of Ether over GRE, IP over GRE and IP over IP >> tunnels in csumonly to do the test. I ask the csum forward engine >> to calculate inner IP+TCP checksums, and outer IP (case 6 in [1]). >> Here are the results:

[dpdk-dev] [PATCH v4 05/11] ethdev: Add functions that will be used by port hotplug functions

2015-01-21 Thread Tetsuya Mukawa
Hi Michael, On 2015/01/21 11:40, Qiu, Michael wrote: > On 1/19/2015 6:42 PM, Tetsuya Mukawa wrote: >> The patch adds following functions. >> >> - rte_eth_dev_save() >> The function is used for saving current rte_eth_dev structures. >> - rte_eth_dev_get_changed_port() >> The function receives t

[dpdk-dev] [PATCH] Added missing extern 'C' decls in rte_ip_frag.h

2015-01-21 Thread Marc Sune
Signed-off-by: Marc Sune --- lib/librte_ip_frag/rte_ip_frag.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/librte_ip_frag/rte_ip_frag.h b/lib/librte_ip_frag/rte_ip_frag.h index 3989a5a..1083d44 100644 --- a/lib/librte_ip_frag/rte_ip_frag.h +++ b/lib/librte_ip_frag/rte_ip_frag.h

[dpdk-dev] [PATCH v6 4/4] docs: Add ABI documentation

2015-01-21 Thread Thomas Monjalon
2015-01-21 09:59, Neil Horman: > On Wed, Jan 21, 2015 at 11:25:48AM +0100, Thomas Monjalon wrote: > > 2015-01-20 16:17, Neil Horman: > > > Adding a document describing rudimentary ABI policy and adding notice > > > space for > > > any deprecation announcements > > > > > > Signed-off-by: Neil Horm

[dpdk-dev] [RFC 00/16] enhance checksum offload API

2015-01-21 Thread Stephen Hemminger
On Thu, 22 Jan 2015 00:36:19 +0100 Olivier Matz wrote: > The goal of this series is to clarify and simplify the mbuf offload API. > Several issues are solved: > > - simplify the definitions of PKT_TX_IP_CKSUM and PKT_TX_IPV4, each > flag has now only one meaning. No impact on the code. > > -

[dpdk-dev] [PATCH 0/4] DPDK memcpy optimization

2015-01-21 Thread Stephen Hemminger
On Wed, 21 Jan 2015 15:25:40 -0600 Jim Thompson wrote: > I?m not as concerned with compile times given the potential performance boost. Compile time matters. Right now full build of large project is fast. Like 2 minutes or less. Is this only the test applications (which can be disabled from th

[dpdk-dev] [PATCH 0/7] vmxnet3: driver enhancements

2015-01-21 Thread Stephen Hemminger
On Thu, 15 Jan 2015 12:02:11 +0100 Thomas Monjalon wrote: > Someone to review these patches? Any comments from Bruce Richardson

[dpdk-dev] [PATCH] doc: commands changed in testpmd_funcs for ethertype filter

2015-01-21 Thread Jingjing Wu
new commands for ethertype filter - ethertype_filter (port_id) (add|del) (mac_addr|mac_ignr) (mac_address) ethertype (ether_type) (drop|fwd) queue (queue_id) Signed-off-by: Jingjing Wu --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 46 +++-- 1 file change

[dpdk-dev] DPDK - TX from lcore in packet distributor configuration

2015-01-21 Thread Bruce Richardson
On Wed, Jan 21, 2015 at 03:00:50PM +0100, deco33000 Jog wrote: > Hello, > > -- PROBLEM > I have a AF_PACKET socket which is in promiscuous mode to get all the NIC > traffic and let my apps do the whole stuff. > > So I have one receiver and need to communicate the packet to different > threads/p

[dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum forwarding engine

2015-01-21 Thread Ananyev, Konstantin
Hi Olivier, > -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Wednesday, January 21, 2015 3:25 PM > To: Liu, Jijiang; Ananyev, Konstantin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum > forwarding eng

[dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum forwarding engine

2015-01-21 Thread Olivier MATZ
Hi, On 01/21/2015 04:12 AM, Liu, Jijiang wrote: > Ok, and why it should be our problem? > We have a lot of things done in a different manner then > linux/freebsd kernel drivers, Why now it became a problem? If linux doesn't need an equivalent flag for doing the same thing, it

[dpdk-dev] Q on Support for I217 and I218 Intel chipsets.

2015-01-21 Thread Ravi Kerur
Intel team, Please let me know what additional testing needs to be done for I217/I218? I have confined changes only to _osdep_ files and have done basic testing with testpmd utility. Since DPDK PMD driver supporting e1000e has been available for quite sometime, I have assumed basic testing for Tx

[dpdk-dev] [PATCH v7 4/4] docs: Add ABI documentation

2015-01-21 Thread Neil Horman
Adding a document describing rudimentary ABI policy and adding notice space for any deprecation announcements Signed-off-by: Neil Horman CC: Thomas Monjalon CC: "Richardson, Bruce" --- Change notes: v5) Updated documentation to add notes from Thomas M. v6) Moved abi.txt to guides/rel_notes/a

[dpdk-dev] [PATCH v7 3/4] Add library version extenstion

2015-01-21 Thread Neil Horman
To differentiate libraries that break ABI, we add a library version number suffix to the library, which must be incremented when a given libraries ABI is broken. This patch enforces that addition, sets the initial abi soname extension to 1 for each library and creates a symlink to the base SONAME

[dpdk-dev] [PATCH v7 2/4] Provide initial versioning for all DPDK libraries

2015-01-21 Thread Neil Horman
Add linker version script files to each DPDK library to put a stake in the ground from which we can start cleaning up API's Signed-off-by: Neil Horman CC: Thomas Monjalon CC: "Richardson, Bruce" --- Change Notes: v2) * Updated export map to not require full path --- lib/librte_acl/Ma

[dpdk-dev] [PATCH v7 1/4] compat: Add infrastructure to support symbol versioning

2015-01-21 Thread Neil Horman
Add initial pass header files to support symbol versioning. Signed-off-by: Neil Horman CC: Thomas Monjalon CC: "Richardson, Bruce" CC: "Gonzalez Monroy, Sergio" --- Change Notes: V2) Moved ifeq to _INSTALL target V3) Undo V2 changes and make librte_compat use the rte.install.

[dpdk-dev] [PATCH v7 01/26] version: 2.0.0-rc0

2015-01-21 Thread Neil Horman
On Wed, Jan 21, 2015 at 03:57:25PM -0500, Neil Horman wrote: > From: Thomas Monjalon > > Signed-off-by: Thomas Monjalon > --- > lib/librte_eal/common/include/rte_version.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_eal/common/include/rte_version

[dpdk-dev] [PATCH v7 10/26] nic_uio: fix thread structure compatibility for future FreeBSD

2015-01-21 Thread Neil Horman
From: Bruce Richardson Replace d_thread_t with struct thread in nic_uio. Ref: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196691 Quote: "The d_thread_t typedef is a compat shim to support FreeBSD 4.x. I'm planning to remove this shim from 11 and dpdk is very unlikely to ever be ported to 4

[dpdk-dev] [PATCH v7 09/26] app/testpmd: remove duplicated function for list parsing

2015-01-21 Thread Neil Horman
From: Bruce Richardson There were two static functions called "parse_item_list" in testpmd app. Since one was a superset of the functionality of the other, we can collapse the two calls down into a single one, shared between the two C files. Signed-off-by: Bruce Richardson Acked-by: Pablo de La

[dpdk-dev] [PATCH v7 08/26] bond: fix vlan flag interpretation

2015-01-21 Thread Neil Horman
From: Declan Doherty This patch contains a fix for link bonding handling of vlan tagged packets in mode 3 and 5. Currently xmit_slave_hash function misinterprets the PKT_RX_VLAN_PKT flag to mean that there is a vlan tag within the packet when in actually means that there is a valid entry in th

[dpdk-dev] [PATCH v7 07/26] vfio: avoid enabling while the module is not loaded

2015-01-21 Thread Neil Horman
From: Michael Qiu When vfio module is not loaded when kernel support vfio feature, the routine still try to open the container to get file description. This action is not safe, and of course got error messages: EAL: Detected 40 lcore(s) EAL: unsupported IOMMU type! EAL: VFIO support could not

[dpdk-dev] [PATCH v7 06/26] log: remove unnecessary stubs

2015-01-21 Thread Neil Horman
From: Stephen Hemminger The read/seek/close stub functions are unnecessary on the log stream. Per glibc fopencookie man page: cookie_read_function_t *read If *read is a null pointer, then reads from the custom stream always return end of file. cooki

[dpdk-dev] [PATCH v7 05/26] mem: search only dpdk hugetlbfs maps

2015-01-21 Thread Neil Horman
From: Vlad Zolotarov When scanning the hugetlbfs maps search only for the DPDK maps. This will allow the application create its own hugetlbfs mappings and use the DPDK facilities on the same hugetlbfs mount point. Signed-off-by: Vlad Zolotarov Acked-by: Thomas Monjalon --- lib/librte_eal/linu

[dpdk-dev] [PATCH v7 04/26] ethdev: fix missing parenthesis in mac check

2015-01-21 Thread Neil Horman
From: Pawel Wodkowski Fix check introduced in commit 4bdefaade6d1 (VMDQ enhancements). Signed-off-by: Pawel Wodkowski Acked-by: Thomas Monjalon --- lib/librte_ether/rte_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ethe

[dpdk-dev] [PATCH v7 03/26] eal: fix check for power of 2 in 0 case

2015-01-21 Thread Neil Horman
From: Ravi Kerur rte_is_power_of_2 returns true for 0 and 0 is not power_of_2. Fix by checking for n. Signed-off-by: Ravi Kerur Acked-by: Neil Horman --- lib/librte_eal/common/include/rte_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/includ

[dpdk-dev] [PATCH v7 02/26] mk: fix link to static combined library

2015-01-21 Thread Neil Horman
When building static archives with CONFIG_COMBINED_LIBS, we still need to specify --whole-archive to pull in all the proper constructors. Signed-off-by: Neil Horman Reported-by: Lyn M Tested-by: Lyn M Acked-by: Thomas Monjalon --- mk/rte.app.mk | 8 1 file changed, 4 insertions(+), 4

[dpdk-dev] [PATCH v7 01/26] version: 2.0.0-rc0

2015-01-21 Thread Neil Horman
From: Thomas Monjalon Signed-off-by: Thomas Monjalon --- lib/librte_eal/common/include/rte_version.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/common/include/rte_version.h b/lib/librte_eal/common/include/rte_version.h index d2686ae..a267040 1006

[dpdk-dev] [PATCH 0/4] DPDK memcpy optimization

2015-01-21 Thread Neil Horman
On Wed, Jan 21, 2015 at 11:49:47AM -0800, Stephen Hemminger wrote: > On Wed, 21 Jan 2015 13:26:20 + > Bruce Richardson wrote: > > > On Wed, Jan 21, 2015 at 02:21:25PM +0100, Marc Sune wrote: > > > > > > On 21/01/15 14:02, Bruce Richardson wrote: > > > >On Wed, Jan 21, 2015 at 01:36:41PM +010

[dpdk-dev] [PATCH v4 10/11] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-01-21 Thread Tetsuya Mukawa
Hi Michael, On 2015/01/21 12:49, Qiu, Michael wrote: > On 1/19/2015 6:43 PM, Tetsuya Mukawa wrote: >> These functions are used for attaching or detaching a port. >> When rte_eal_dev_attach() is called, the function tries to realize the >> device name as pci address. If this is done successfully, >

[dpdk-dev] [PATCH v4 07/11] eal/pci: Add a function to remove the entry of devargs list

2015-01-21 Thread Tetsuya Mukawa
Hi Michael, On 2015/01/21 11:55, Qiu, Michael wrote: > On 1/19/2015 6:42 PM, Tetsuya Mukawa wrote: >> The function removes the specified devargs entry from devargs_list. >> Also the patch adds sanity checking to rte_eal_devargs_add(). >> >> v4: >> - Fix sanity check code >> >> Signed-off-by: Tetsu

[dpdk-dev] [PATCH 0/4] DPDK memcpy optimization

2015-01-21 Thread Jim Thompson
I?m not as concerned with compile times given the potential performance boost. A long time ago (mid-80s) I was at Convex, and wanted to do a vector bcopy(), because it would make the I/O system (mostly disk then (*)) go faster. The architect explained to me that the vector registers were for app

[dpdk-dev] New to DPDK

2015-01-21 Thread Ravi Rao
Hi, Thanks for the inputs. I did download dpdk-1.8 and used your latest packet-gen-2.8.0 but I am getting this crash. Looks like I am missing or not specifying the correct arguments. Can you please help ? ./app/pktgen -c 03 -n 1 --proc-type auto --socket-mem 128 --file-prefix pg -- -T -P -m

[dpdk-dev] DPDK - TX from lcore in packet distributor configuration

2015-01-21 Thread deco33000 Jog
Hello, -- PROBLEM I have a AF_PACKET socket which is in promiscuous mode to get all the NIC traffic and let my apps do the whole stuff. So I have one receiver and need to communicate the packet to different threads/processes (lcore) so that they can process the rest of the packet (tcp/udp...)

[dpdk-dev] [PATCH v6 4/4] docs: Add ABI documentation

2015-01-21 Thread Neil Horman
On Wed, Jan 21, 2015 at 05:05:51PM +0100, Thomas Monjalon wrote: > 2015-01-21 09:59, Neil Horman: > > On Wed, Jan 21, 2015 at 11:25:48AM +0100, Thomas Monjalon wrote: > > > 2015-01-20 16:17, Neil Horman: > > > > Adding a document describing rudimentary ABI policy and adding notice > > > > space fo

[dpdk-dev] DPDK Community Call, Monday 2nd February, 17:00 GMT

2015-01-21 Thread O'driscoll, Tim
> From: O'driscoll, Tim > > > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > > > > On Tue, 20 Jan 2015 15:21:40 + > > "O'driscoll, Tim" wrote: > > > > > We had our last community call in December, and then took a break over > > the holiday period. I think we should reinstate

[dpdk-dev] [PATCH 0/4] DPDK memcpy optimization

2015-01-21 Thread Marc Sune
On 21/01/15 14:02, Bruce Richardson wrote: > On Wed, Jan 21, 2015 at 01:36:41PM +0100, Marc Sune wrote: >> On 21/01/15 04:44, Wang, Zhihong wrote: -Original Message- From: Richardson, Bruce Sent: Wednesday, January 21, 2015 12:15 AM To: Neil Horman Cc: Wang, Zhihon

[dpdk-dev] [PATCH] stats: remove useless memset's

2015-01-21 Thread David Marchand
Hello Stephen, On Wed, Jan 21, 2015 at 5:16 AM, wrote: > From: Stephen Hemminger > > The rte_eth_stats_get is the only API that should call the device > statistics function directly, and it already does a memset of the > resulting structure. Therefore doing memset() in the driver is > redundant

[dpdk-dev] Segmentation fault in ixgbe_rxtx_vec.c:444 with 1.8.0

2015-01-21 Thread Bruce Richardson
On Tue, Jan 20, 2015 at 11:39:03AM +0100, Martin Weiser wrote: > Hi again, > > I did some further testing and it seems like this issue is linked to > jumbo frames. I think a similar issue has already been reported by > Prashant Upadhyaya with the subject 'Packet Rx issue with DPDK1.8'. > In our ap

[dpdk-dev] [PATCH 0/4] DPDK memcpy optimization

2015-01-21 Thread Marc Sune
On 21/01/15 04:44, Wang, Zhihong wrote: > >> -Original Message- >> From: Richardson, Bruce >> Sent: Wednesday, January 21, 2015 12:15 AM >> To: Neil Horman >> Cc: Wang, Zhihong; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 0/4] DPDK memcpy optimization >> >> On Tue, Jan 20, 2015 at 10

[dpdk-dev] [PATCH 0/4] DPDK memcpy optimization

2015-01-21 Thread Bruce Richardson
On Wed, Jan 21, 2015 at 02:21:25PM +0100, Marc Sune wrote: > > On 21/01/15 14:02, Bruce Richardson wrote: > >On Wed, Jan 21, 2015 at 01:36:41PM +0100, Marc Sune wrote: > >>On 21/01/15 04:44, Wang, Zhihong wrote: > -Original Message- > From: Richardson, Bruce > Sent: Wednesday,

[dpdk-dev] [PATCH 0/4] DPDK memcpy optimization

2015-01-21 Thread Bruce Richardson
On Wed, Jan 21, 2015 at 01:36:41PM +0100, Marc Sune wrote: > > On 21/01/15 04:44, Wang, Zhihong wrote: > > > >>-Original Message- > >>From: Richardson, Bruce > >>Sent: Wednesday, January 21, 2015 12:15 AM > >>To: Neil Horman > >>Cc: Wang, Zhihong; dev at dpdk.org > >>Subject: Re: [dpdk-dev

[dpdk-dev] [PATCH 0/5] new ntuple filter replaces 2tuple and 5tuple filters

2015-01-21 Thread De Lara Guarch, Pablo
> -Original Message- > From: Wu, Jingjing > Sent: Thursday, January 15, 2015 1:46 AM > To: dev at dpdk.org > Cc: Wu, Jingjing; De Lara Guarch, Pablo; Cao, Min > Subject: [PATCH 0/5] new ntuple filter replaces 2tuple and 5tuple filters > > The patch set uses new filter_ctrl API to replace

[dpdk-dev] [PATCH 0/4] DPDK memcpy optimization

2015-01-21 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wang, Zhihong > Sent: Wednesday, January 21, 2015 3:44 AM > To: Richardson, Bruce; Neil Horman > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/4] DPDK memcpy optimization > > > > > -Original Mes

[dpdk-dev] DPDK Community Call, Monday 2nd February, 17:00 GMT

2015-01-21 Thread Stephen Hemminger
On Wed, 21 Jan 2015 14:39:17 + "O'driscoll, Tim" wrote: > > From: O'driscoll, Tim > > > > > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > > > > > > On Tue, 20 Jan 2015 15:21:40 + > > > "O'driscoll, Tim" wrote: > > > > > > > We had our last community call in December,

[dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum forwarding engine

2015-01-21 Thread Ananyev, Konstantin
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Wednesday, January 21, 2015 9:11 AM > To: Liu, Jijiang > Cc: Ananyev, Konstantin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum > forwarding engine > > Hi

[dpdk-dev] [PATCH 0/4] DPDK memcpy optimization

2015-01-21 Thread Stephen Hemminger
On Wed, 21 Jan 2015 13:26:20 + Bruce Richardson wrote: > On Wed, Jan 21, 2015 at 02:21:25PM +0100, Marc Sune wrote: > > > > On 21/01/15 14:02, Bruce Richardson wrote: > > >On Wed, Jan 21, 2015 at 01:36:41PM +0100, Marc Sune wrote: > > >>On 21/01/15 04:44, Wang, Zhihong wrote: > > -Or

[dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum forwarding engine

2015-01-21 Thread Stephen Hemminger
On Wed, 21 Jan 2015 03:12:35 + "Liu, Jijiang" wrote: > > Because the dpdk looks very similar to that part of linux driver. > > A guy from Intel who have already confirmed that the NVGRE is not supported > yet in Linux kernel. > > He said "So far as I know it is not yet supported and

[dpdk-dev] [PATCH 0/4] DPDK memcpy optimization

2015-01-21 Thread Bruce Richardson
On Wed, Jan 21, 2015 at 03:44:23AM +, Wang, Zhihong wrote: > Neil, Bruce, > > Some data first. > > Sandy Bridge without AVX2: > 1. original w/ 10 constant memcpy: 2'25" > 2. patch w/ 12 constant memcpy: 2'41" > 3. patch w/ 63 constant memcpy: 9'41" > > Haswell with AVX2: > 1. original w/

[dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf rss

2015-01-21 Thread Ouyang Changchun
To follow up the comments from Wodkowski, PawelX, remove this unnecessary check, as check_mq_mode has already check the queue number in device configure stage, if the queue number of vf is not correct, it will return error code and exit, so it doesn't need check again here in device start stage(not

[dpdk-dev] [PATCH v6 4/4] docs: Add ABI documentation

2015-01-21 Thread Thomas Monjalon
2015-01-20 16:17, Neil Horman: > Adding a document describing rudimentary ABI policy and adding notice space > for > any deprecation announcements > > Signed-off-by: Neil Horman > CC: Thomas Monjalon > CC: "Richardson, Bruce" > > --- > Change notes: > > v5) Updated documentation to add notes

[dpdk-dev] [PATCH] doc: commands changed in testpmd_funcs for ethertype filter

2015-01-21 Thread Thomas Monjalon
Hi Jingjing, Thanks for providing a patch quickly for the missing doc. I have a few comments. 2015-01-21 16:30, Jingjing Wu: > new commands for ethertype filter > - ethertype_filter (port_id) (add|del) (mac_addr|mac_ignr) > (mac_address) ethertype (ether_type) (drop|fwd) queue (queu

[dpdk-dev] [PATCH v6 4/4] docs: Add ABI documentation

2015-01-21 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman > Sent: Tuesday, January 20, 2015 9:18 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v6 4/4] docs: Add ABI documentation > > Adding a document describing rudimentary ABI policy and adding not

[dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum forwarding engine

2015-01-21 Thread Olivier MATZ
Hi Jijiang, On 01/21/2015 09:01 AM, Liu, Jijiang wrote: >>> I still don't understand why you are so eager to 'forbid' it. >>> Yes we support it for FVL, but no one forces you to use it. >> >> Well, how would you describe this 2 ways of doing the same thing in the >> offload API? Would you talk abo

[dpdk-dev] [PATCH v6 4/4] docs: Add ABI documentation

2015-01-21 Thread Neil Horman
On Wed, Jan 21, 2015 at 11:25:48AM +0100, Thomas Monjalon wrote: > 2015-01-20 16:17, Neil Horman: > > Adding a document describing rudimentary ABI policy and adding notice space > > for > > any deprecation announcements > > > > Signed-off-by: Neil Horman > > CC: Thomas Monjalon > > CC: "Richard

[dpdk-dev] DPDK Community Call, Monday 2nd February, 17:00 GMT

2015-01-21 Thread O'driscoll, Tim
> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Tuesday, January 20, 2015 5:11 PM > To: O'driscoll, Tim > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] DPDK Community Call, Monday 2nd February, 17:00 > GMT > > On Tue, 20 Jan 2015 15:21:40 +

[dpdk-dev] [PATCH v4 06/11] eal/linux/pci: Add functions for unmapping igb_uio resources

2015-01-21 Thread Tetsuya Mukawa
Hi Michael, On 2015/01/20 18:23, Qiu, Michael wrote: > On 1/19/2015 6:42 PM, Tetsuya Mukawa wrote: >> The patch adds functions for unmapping igb_uio resources. The patch is only >> for Linux and igb_uio environment. VFIO and BSD are not supported. >> >> v4: >> - Add paramerter checking. >> - Add h

[dpdk-dev] [PATCH v6 5/6] ixgbe: Config VF RSS

2015-01-21 Thread Wodkowski, PawelX
> -Original Message- > From: Ouyang, Changchun > Sent: Wednesday, January 21, 2015 3:44 AM > To: Wodkowski, PawelX; dev at dpdk.org > Cc: Ouyang, Changchun > Subject: RE: [dpdk-dev] [PATCH v6 5/6] ixgbe: Config VF RSS > > > > > -Original Message- > > From: Wodkowski, PawelX > >

[dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum forwarding engine

2015-01-21 Thread Liu, Jijiang
Hi, > -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Wednesday, January 21, 2015 2:16 AM > To: Ananyev, Konstantin; Liu, Jijiang > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and > csum forwarding engine > >

[dpdk-dev] [PATCH] stats: remove useless memset's

2015-01-21 Thread Neil Horman
On Tue, Jan 20, 2015 at 08:16:58PM -0800, stephen at networkplumber.org wrote: > From: Stephen Hemminger > > The rte_eth_stats_get is the only API that should call the device > statistics function directly, and it already does a memset of the > resulting structure. Therefore doing memset() in the

[dpdk-dev] [PATCH 0/4] DPDK memcpy optimization

2015-01-21 Thread Neil Horman
On Wed, Jan 21, 2015 at 12:02:57PM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wang, Zhihong > > Sent: Wednesday, January 21, 2015 3:44 AM > > To: Richardson, Bruce; Neil Horman > > Cc: dev at dpdk.org > > Subjec

[dpdk-dev] [PATCH v6 0/6] enicpmd: Cisco Systems Inc. VIC Ethernet PMD

2015-01-21 Thread Sujith Sankar (ssujith)
Hi David, Apologies for the delay. I was not able to find quality time to finish it as a few other things have been keeping me busy. But I shall work on it and provide the doc and the perf details soon. In the mean time, it would be great if you could point me to some resources on running pkt

[dpdk-dev] [PATCH v4 10/11] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-01-21 Thread Qiu, Michael
On 1/19/2015 6:43 PM, Tetsuya Mukawa wrote: > These functions are used for attaching or detaching a port. > When rte_eal_dev_attach() is called, the function tries to realize the > device name as pci address. If this is done successfully, > rte_eal_dev_attach() will attach physical device port. If

[dpdk-dev] [PATCH 0/4] DPDK memcpy optimization

2015-01-21 Thread Wang, Zhihong
> -Original Message- > From: Richardson, Bruce > Sent: Wednesday, January 21, 2015 12:15 AM > To: Neil Horman > Cc: Wang, Zhihong; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/4] DPDK memcpy optimization > > On Tue, Jan 20, 2015 at 10:11:18AM -0500, Neil Horman wrote: > > On Tue, J

[dpdk-dev] [PATCH 4/4] lib/librte_eal: Optimized memcpy in arch/x86/rte_memcpy.h for both SSE and AVX platforms

2015-01-21 Thread Wang, Zhihong
> -Original Message- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Wednesday, January 21, 2015 3:16 AM > To: Stephen Hemminger > Cc: Wang, Zhihong; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 4/4] lib/librte_eal: Optimized memcpy in > arch/x86/rte_memcpy.h for both SS

[dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum forwarding engine

2015-01-21 Thread Liu, Jijiang
Hi, > -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Wednesday, January 21, 2015 2:16 AM > To: Ananyev, Konstantin; Liu, Jijiang > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and > csum forwarding engine > >

[dpdk-dev] [PATCH v4 07/11] eal/pci: Add a function to remove the entry of devargs list

2015-01-21 Thread Qiu, Michael
On 1/19/2015 6:42 PM, Tetsuya Mukawa wrote: > The function removes the specified devargs entry from devargs_list. > Also the patch adds sanity checking to rte_eal_devargs_add(). > > v4: > - Fix sanity check code > > Signed-off-by: Tetsuya Mukawa > --- > lib/librte_eal/common/eal_common_devargs.c

[dpdk-dev] [PATCH v6 5/6] ixgbe: Config VF RSS

2015-01-21 Thread Ouyang, Changchun
> -Original Message- > From: Wodkowski, PawelX > Sent: Tuesday, January 20, 2015 5:35 PM > To: Ouyang, Changchun; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH v6 5/6] ixgbe: Config VF RSS > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ouy

[dpdk-dev] [PATCH v4 05/11] ethdev: Add functions that will be used by port hotplug functions

2015-01-21 Thread Qiu, Michael
On 1/19/2015 6:42 PM, Tetsuya Mukawa wrote: > The patch adds following functions. > > - rte_eth_dev_save() > The function is used for saving current rte_eth_dev structures. > - rte_eth_dev_get_changed_port() > The function receives the rte_eth_dev structures, then compare > these with current

[dpdk-dev] [PATCH v8 3/4] i40e: support of controlling hash functions

2015-01-21 Thread Zhang, Helin
Hi Thomas Sure, I will do it ASAP! Thank you for the helps! Regards, Helin > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, January 20, 2015 3:54 PM > To: Zhang, Helin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v8 3/4] i40e: