[dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read

2015-02-09 Thread Dumitrescu, Cristian
Hi Stephen, What is the reason not to clear statistics on read? Do you have a use-case / justification for it? (BTW, I see you added the reset functions, but was it also your intention to remove the memset to 0 from the stats read functions? :) ) Regards, Cristian -Original Message-

[dpdk-dev] Error seen while running testpmd sample application

2015-02-09 Thread Shankari Vaidyalingam
Hi, I'm trying to execute the testpmd sample appplication. I'm getting the below error and not able to execute the sample application. controller at controller-VirtualBox:~/software/dpdk-1.7.1$ sudo ./build/app/testpmd -c7 -n3 -- -i --nb-cores=2 --nb-ports=2 ./build/app/testpmd: error while

[dpdk-dev] Vhost-user roadmap

2015-02-09 Thread BenoƮt Canet
Hello Xie, I am testing your vhost-user patchset with the plumbing of my ongoing lower latency neutron implementation. Can you share with the list your roadmap of 2015 for the dpdk/vhost topic ? Best regards Beno?t

[dpdk-dev] [PATCH v4 14/17] mempool: add support to non-EAL thread

2015-02-09 Thread Olivier MATZ
Hi, On 02/09/2015 03:41 PM, Liang, Cunming wrote: >>> #ifdef RTE_LIBRTE_MEMPOOL_DEBUG >>> -#define __MEMPOOL_STAT_ADD(mp, name, n) do { \ >>> - unsigned __lcore_id = rte_lcore_id(); \ >>> - mp->stats[__lcore_id].name##_objs += n; \ >>>

[dpdk-dev] [PATCH v4 12/17] eal: set _lcore_id and _socket_id to (-1) by default

2015-02-09 Thread Olivier MATZ
Hi, On 02/09/2015 03:24 PM, Liang, Cunming wrote: >>> --- a/lib/librte_eal/linuxapp/eal/eal_thread.c >>> +++ b/lib/librte_eal/linuxapp/eal/eal_thread.c >>> @@ -57,8 +57,8 @@ >>> #include "eal_private.h" >>> #include "eal_thread.h" >>> >>> -RTE_DEFINE_PER_LCORE(unsigned, _lcore_id); >>>

[dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read

2015-02-09 Thread Neil Horman
On Mon, Feb 09, 2015 at 10:48:36PM +, Dumitrescu, Cristian wrote: > Hi Stephen, > > What is the reason not to clear statistics on read? Do you have a use-case / > justification for it? > > (BTW, I see you added the reset functions, but was it also your intention to > remove the memset to 0

[dpdk-dev] [PATCH v4 11/17] log: fix the gap to support non-EAL thread

2015-02-09 Thread Olivier MATZ
Hi, On 02/09/2015 03:19 PM, Liang, Cunming wrote: >>> --- a/lib/librte_eal/common/include/rte_log.h >>> +++ b/lib/librte_eal/common/include/rte_log.h >>> @@ -144,6 +144,11 @@ uint32_t rte_get_log_level(void); >>> void rte_set_log_type(uint32_t type, int enable); >>> >>> /** >>> + * Get the

[dpdk-dev] [PATCH v4 10/17] malloc: fix the issue of SOCKET_ID_ANY

2015-02-09 Thread Olivier MATZ
Hi, On 02/09/2015 03:08 PM, Liang, Cunming wrote: > > >> -Original Message- >> From: Olivier MATZ [mailto:olivier.matz at 6wind.com] >> Sent: Monday, February 09, 2015 4:01 AM >> To: Liang, Cunming; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v4 10/17] malloc: fix the issue of >>

[dpdk-dev] [PATCH v4 08/17] eal: apply affinity of EAL thread by assigned cpuset

2015-02-09 Thread Olivier MATZ
Hi, On 02/09/2015 02:48 PM, Liang, Cunming wrote: >> -Original Message- >> From: Olivier MATZ [mailto:olivier.matz at 6wind.com] >> Sent: Monday, February 09, 2015 4:01 AM >> To: Liang, Cunming; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v4 08/17] eal: apply affinity of EAL thread

[dpdk-dev] [PATCH v4 06/17] eal: add eal_common_thread.c for common thread API

2015-02-09 Thread Olivier MATZ
Hi, On 02/09/2015 02:12 PM, Liang, Cunming wrote: >>> +int >>> +rte_thread_get_affinity(rte_cpuset_t *cpusetp) >>> +{ >>> + if (!cpusetp) >>> + return -1; >> >> Same here. This is the only reason why rte_thread_get_affinity() could >> fail. Removing this test would allow to change the

[dpdk-dev] [PATCH v4 05/17] eal: new TLS definition and API declaration

2015-02-09 Thread Olivier MATZ
Hi, On 02/09/2015 01:45 PM, Liang, Cunming wrote: >>> +/** >>> + * Dump the current pthread cpuset. >>> + * This function is private to EAL. >>> + * >>> + * @param str >>> + * The string buffer the cpuset will dump to. >>> + * @param size >>> + * The string buffer size. >>> + */ >>> +#define

[dpdk-dev] [PATCH v4 04/17] eal: add support parsing socket_id from cpuset

2015-02-09 Thread Olivier MATZ
Hi, On 02/09/2015 01:26 PM, Liang, Cunming wrote: >>> @@ -50,4 +54,52 @@ __attribute__((noreturn)) void *eal_thread_loop(void >> *arg); >>> */ >>> void eal_thread_init_master(unsigned lcore_id); >>> >>> +/** >>> + * Get the NUMA socket id from cpu id. >>> + * This function is private to EAL.

[dpdk-dev] [PATCH v4 03/17] eal: fix wrong strnlen() return value in 32bit icc

2015-02-09 Thread Olivier MATZ
Hi, On 02/09/2015 12:57 PM, Liang, Cunming wrote: >>> @@ -469,7 +469,7 @@ eal_parse_lcores(const char *lcores) >>> /* Remove all blank characters ahead and after */ >>> while (isblank(*lcores)) >>> lcores++; >>> - i = strnlen(lcores, sysconf(_SC_ARG_MAX)); >>> + i =

[dpdk-dev] [PATCH] MAINTAINERS: claim metering, sched and pkt framework

2015-02-09 Thread Thomas Monjalon
2015-02-09 16:18, Dumitrescu, Cristian: > > About cfgfile, we are still waiting for the cleanup in qos_sched example: > > http://dpdk.org/ml/archives/dev/2014-October/006774.html > > Do you have news? > We are working on some enhancements on librte_cfg for release 2.1, so in > order to avoid

[dpdk-dev] [PATCH v4 01/17] eal: add cpuset into per EAL thread lcore_config

2015-02-09 Thread Olivier MATZ
Hi, On 02/09/2015 12:33 PM, Liang, Cunming wrote: >> On 02/02/2015 03:02 AM, Cunming Liang wrote: >>> The patch adds 'cpuset' into per-lcore configure 'lcore_config[]', >>> as the lcore no longer always 1:1 pinning with physical cpu. >>> The lcore now stands for a EAL thread rather than a logical

[dpdk-dev] [PATCH v6 1/2] librte_pmd_null: Add null PMD

2015-02-09 Thread Tetsuya Mukawa
On 2015/02/06 20:32, Iremonger, Bernard wrote: > Hi Tetsuya, > > My comments are in line below. > >> -Original Message- >> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] >> Sent: Friday, February 6, 2015 4:38 AM >> To: dev at dpdk.org >> Cc: Iremonger, Bernard; Tetsuya Mukawa >>

[dpdk-dev] [PATCH v4 01/17] eal: add cpuset into per EAL thread lcore_config

2015-02-09 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier MATZ > Sent: Monday, February 09, 2015 5:07 PM > To: Liang, Cunming; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 01/17] eal: add cpuset into per EAL thread > lcore_config > > Hi, > > On

[dpdk-dev] [PATCH v7] testpmd: Add port hotplug support

2015-02-09 Thread Tetsuya Mukawa
The patch introduces following commands. - port attach [ident] - port detach [port_id] - attach: attaching a port - detach: detaching a port - ident: pci address of physical device. Or device name and parameters of virtual device. (ex. :02:00.0, eth_pcap0,iface=eth0) -

[dpdk-dev] [PATCH v7] librte_pmd_pcap: Add port hotplug support

2015-02-09 Thread Tetsuya Mukawa
This patch adds finalization code to free resources allocated by the PMD. v6: - Fix a paramter of rte_eth_dev_free(). v4: - Change function name. Signed-off-by: Tetsuya Mukawa --- lib/librte_pmd_pcap/rte_eth_pcap.c | 40 ++ 1 file changed, 40 insertions(+)

[dpdk-dev] [PATCH v7 14/14] doc: Add port hotplug framework section to programmers guide

2015-02-09 Thread Tetsuya Mukawa
This patch adds a new section for describing port hotplug framework. Signed-off-by: Tetsuya Mukawa --- doc/guides/prog_guide/index.rst | 1 + doc/guides/prog_guide/port_hotplug_framework.rst | 110 +++ 2 files changed, 111 insertions(+) create mode 100644

[dpdk-dev] [PATCH v7 13/14] eal: Enable port hotplug framework in Linux

2015-02-09 Thread Tetsuya Mukawa
The patch enables CONFIG_RTE_LIBRTE_EAL_HOTPLUG in Linux configuration. Signed-off-by: Tetsuya Mukawa --- config/common_linuxapp | 5 + 1 file changed, 5 insertions(+) diff --git a/config/common_linuxapp b/config/common_linuxapp index d428f84..81055f8 100644 --- a/config/common_linuxapp

[dpdk-dev] [PATCH v7 12/14] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-02-09 Thread Tetsuya Mukawa
These functions are used for attaching or detaching a port. When rte_eal_dev_attach() is called, the function tries to realize the device name as pci address. If this is done successfully, rte_eal_dev_attach() will attach physical device port. If not, attaches virtual devive port. When

[dpdk-dev] [PATCH v7 10/14] eal/pci: Cleanup pci driver initialization code

2015-02-09 Thread Tetsuya Mukawa
- Add rte_eal_pci_close_one_dirver() The function is used for closing the specified driver and device. - Add pci_invoke_all_drivers() The function is based on pci_probe_all_drivers. But it can not only probe but also close drivers. - Add pci_close_all_drivers() The function tries to find a

[dpdk-dev] [PATCH v7 09/14] eal/pci: Add a function to remove the entry of devargs list

2015-02-09 Thread Tetsuya Mukawa
The function removes the specified devargs entry from devargs_list. Also, the patch adds sanity checking to rte_eal_devargs_add(). v5: - Change function definition of rte_eal_devargs_remove(). v4: - Fix sanity check code. Signed-off-by: Tetsuya Mukawa ---

[dpdk-dev] [PATCH v7 07/14] ethdev: Add functions that will be used by port hotplug functions

2015-02-09 Thread Tetsuya Mukawa
The patch adds following functions. - rte_eth_dev_save() The function is used for saving current rte_eth_dev structures. - rte_eth_dev_get_changed_port() The function receives the rte_eth_dev structures, then compare these with current values to know which port is actually attached or

[dpdk-dev] [PATCH v7 06/14] eal, ethdev: Add a function and function pointers to close ether device

2015-02-09 Thread Tetsuya Mukawa
The patch adds function pointer to rte_pci_driver and eth_driver structure. These function pointers are used when ports are detached. Also, the patch adds rte_eth_dev_uninit(). So far, it's not called by anywhere, but it will be called when port hotplug function is implemented. v6: - Fix

[dpdk-dev] [PATCH v7 04/14] eal/pci: Consolidate pci address comparison APIs

2015-02-09 Thread Tetsuya Mukawa
This patch replaces pci_addr_comparison() and memcmp() of pci addresses by eal_compare_pci_addr(). v5: - Fix pci_scan_one to handle pt_driver correctly. v4: - Fix calculation method of eal_compare_pci_addr(). - Add parameter checking. Signed-off-by: Tetsuya Mukawa ---

[dpdk-dev] [PATCH v7 03/14] eal/pci, ethdev: Remove assumption that port will not be detached

2015-02-09 Thread Tetsuya Mukawa
To remove assumption, do like followings. This patch adds "RTE_PCI_DRV_DETACHABLE" to drv_flags of rte_pci_driver structure. The flags indicate the driver can detach devices at runtime. Also, remove assumption that port will not be detached. To remove the assumption. - Add 'attached' member to

[dpdk-dev] [PATCH v7 01/14] eal_pci: Add flag to hold kernel driver type

2015-02-09 Thread Tetsuya Mukawa
From: Michael Qiu Currently, dpdk has no ability to know which type of driver( vfio-pci/igb_uio/uio_pci_generic) the device used. It only can check whether vfio is enabled or not staticly. It really useful to have the flag, becasue different type need to handle

[dpdk-dev] [PATCH v7 00/14] Port Hotplug Framework

2015-02-09 Thread Tetsuya Mukawa
This patch series adds a dynamic port hotplug framework to DPDK. With the patches, DPDK apps can attach or detach ports at runtime. The basic concept of the port hotplug is like followings. - DPDK apps must have responsibility to manage ports. DPDK apps only know which ports are attached or

[dpdk-dev] [ Information needed related to Packet Generator in DPDK and ThroughPut Analysis ]

2015-02-09 Thread Arkajit Ghosh
Hi Team, Can anyone please suggest me is there any packet generator which support Intel-DPDK and also can able to send the packets in a controlled way? [Controlled way means where I can able control the sending packets data rate and number of packets and it's size. ] Along with this please

[dpdk-dev] [PATCH] maintainer: claim review for virtio/vhost

2015-02-09 Thread Thomas Monjalon
> > I will be a volunteer of reviewing the following files: > >lib/librte_pmd_virtio/ > >doc/guides/prog_guide/poll_mode_drv_emulated_virtio_nic.rst > >lib/librte_vhost/ > >doc/guides/prog_guide/vhost_lib.rst > >examples/vhost/ > >doc/guides/sample_app_ug/vhost.rst > > > >

[dpdk-dev] ACL Issue with single field rule and rest with wild card entry

2015-02-09 Thread Ananyev, Konstantin
Hi Varun, > -Original Message- > From: Rapelly, Varun [mailto:vrapelly at sonusnet.com] > Sent: Friday, February 06, 2015 4:58 PM > To: Ananyev, Konstantin > Subject: FW: [dpdk-dev] ACL Issue with single field rule and rest with wild > card entry > > Sorry for too many mails. :) > > I

[dpdk-dev] [PATCH] maintainers: claim eal common and linux

2015-02-09 Thread Thomas Monjalon
2015-02-09 14:50, David Marchand: > As discussed with Thomas, I would like to take care of the common eal and > linux > implementation. > > Signed-off-by: David Marchand [...] > EAL API and common code > -M: Thomas Monjalon > +M: David Marchand Thank you David to assume this responsibility.

[dpdk-dev] [PATCH] MAINTAINERS: claim i40e and KNI

2015-02-09 Thread Thomas Monjalon
> Claim i40e and KNI modules. > > Signed-off-by: Helin Zhang Acked-by: Thomas Monjalon Applied, thanks

[dpdk-dev] [PATCH] MAINTAINERS: claim metering, sched and pkt framework

2015-02-09 Thread Dumitrescu, Cristian
Thank you, Thomas! We are working on some enhancements on librte_cfg for release 2.1, so in order to avoid unnecessary code churn, it is probably better to have the librte_cfgfile changes done first, then have a subsequent patch on qos_sched. Regards, Cristian -Original Message-

[dpdk-dev] [PATCH v3] maintainers: claim hash and lpm libraries

2015-02-09 Thread Thomas Monjalon
> > Signed-off-by: Bruce Richardson > > Acked-by: Helin Zhang Acked-by: Thomas Monjalon Applied, thanks

[dpdk-dev] [PATCH v2] maintainers: claim FreeBSD EAL and distributor

2015-02-09 Thread Thomas Monjalon
> > Signed-off-by: Bruce Richardson > > Acked-by: Pablo de Lara Acked-by: Thomas Monjalon Applied, thanks

[dpdk-dev] [PATCH] MAINTAINERS: claim IP fragmentation and ACL

2015-02-09 Thread Thomas Monjalon
> > Signed-off-by: Konstantin Ananyev > > Acked-by: Sergio Gonzalez Monroy Acked-by: Thomas Monjalon Applied, thanks

[dpdk-dev] [PATCH] MAINTAINERS: claim metering, sched and pkt framework

2015-02-09 Thread Thomas Monjalon
2015-02-06 13:13, Gonzalez Monroy, Sergio: > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Cristian Dumitrescu > > Sent: Wednesday, February 4, 2015 3:53 PM > > To: dev at dpdk.org > > Subject: [dpdk-dev] [PATCH] MAINTAINERS: claim metering, sched and pkt > > framework > > > > As

[dpdk-dev] [PATCH] maintainers: claim responsability for testpmd and user guide

2015-02-09 Thread Thomas Monjalon
> > Signed-off-by: Pablo de Lara [...] > > Driver testing tool > > +M: Pablo de Lara > > F: app/test-pmd/ > > F: doc/guides/testpmd_app_ug/ > > Acked-by: Sergio Gonzalez Monroy Acked-by: Thomas Monjalon Applied, thanks

[dpdk-dev] [PATCH v4 16/17] ring: add sched_yield to avoid spin forever

2015-02-09 Thread Ananyev, Konstantin
Hi Olivier, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier MATZ > Sent: Friday, February 06, 2015 3:20 PM > To: Liang, Cunming; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 16/17] ring: add sched_yield to avoid spin > forever > > Hi, > >

[dpdk-dev] [PATCH] maintainers: claim responsibility for VMXNET3 PMD

2015-02-09 Thread Thomas Monjalon
> Signed-off-by: Yong Wang > VMware vmxnet3 > +M: Yong Wang > F: lib/librte_pmd_vmxnet3/ > F: doc/guides/prog_guide/poll_mode_drv_paravirtual_vmxnets_nic.rst Acked-by: Thomas Monjalon Could you help reviewing these patches?

[dpdk-dev] [PATCH 0/3] update maintainers areas

2015-02-09 Thread Thomas Monjalon
> More files should be referenced in MAINTAINERS files: > - some (forgotten) docs can be co-maintained in doc and lib areas > - new ABI files > The script can now check for unknown files. > > Thomas Monjalon (3): > maintainers: dispatch more doc > maintainers: add ABI versioning >

[dpdk-dev] Atheros PMDs

2015-02-09 Thread Neil Horman
On Tue, Feb 10, 2015 at 01:24:02AM +0530, Akshay wrote: > Sorry for not mentioning. But I meant atheros wired nics. > Ah, I wasn't aware they made wired NICS. Regardless, no such PMD has been submitted for inclusion. They may have one that is proprietary, but none that I'm aware of Neil > On

[dpdk-dev] [PATCH v7 03/14] eal/pci, ethdev: Remove assumption that port will not be detached

2015-02-09 Thread Iremonger, Bernard
> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Monday, February 9, 2015 8:30 AM > To: dev at dpdk.org > Cc: Iremonger, Bernard; Qiu, Michael; Tetsuya Mukawa > Subject: [PATCH v7 03/14] eal/pci,ethdev: Remove assumption that port will > not be detached >

[dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read

2015-02-09 Thread Stephen Hemminger
On Mon, 9 Feb 2015 22:48:36 + "Dumitrescu, Cristian" wrote: > Hi Stephen, > > What is the reason not to clear statistics on read? Do you have a use-case / > justification for it? > > (BTW, I see you added the reset functions, but was it also your intention to > remove the memset to 0

[dpdk-dev] Atheros PMDs

2015-02-09 Thread Neil Horman
On Tue, Feb 10, 2015 at 12:11:54AM +0530, Akshay wrote: > Hi, > > Are there any PMDs available for Atheros? > > Regards, > Akshay. > The DPDK isn't currently able to handle wireless NICS. Neil

[dpdk-dev] [PATCH v4 14/17] mempool: add support to non-EAL thread

2015-02-09 Thread Liang, Cunming
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Monday, February 09, 2015 4:01 AM > To: Liang, Cunming; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 14/17] mempool: add support to non-EAL > thread > > Hi, > > On 02/02/2015 03:02 AM, Cunming

[dpdk-dev] [PATCH v2 15/15] mbuf: remove old packet type bit masks

2015-02-09 Thread Helin Zhang
As unified packet types are used instead, those old bit masks and the relevant macros for packet type indication need to be removed. Signed-off-by: Helin Zhang --- lib/librte_mbuf/rte_mbuf.c | 6 -- lib/librte_mbuf/rte_mbuf.h | 14 -- 2 files changed, 4 insertions(+), 16

[dpdk-dev] [PATCH v2 14/15] examples/l3fwd: support of unified packet type

2015-02-09 Thread Helin Zhang
To unify packet types among all PMDs, bit masks and relevant macros of packet type for ol_flags are replaced by unified packet type and relevant macros. Signed-off-by: Helin Zhang --- examples/l3fwd/main.c | 64 --- 1 file changed, 35

[dpdk-dev] [PATCH v2 12/15] examples/l3fwd-acl: support of unified packet type

2015-02-09 Thread Helin Zhang
To unify packet types among all PMDs, bit masks and relevant macros of packet type for ol_flags are replaced by unified packet type and relevant macros. Signed-off-by: Helin Zhang --- examples/l3fwd-acl/main.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) v2

[dpdk-dev] [PATCH v2 11/15] examples/ip_reassembly: support of unified packet type

2015-02-09 Thread Helin Zhang
To unify packet types among all PMDs, bit masks and relevant macros of packet type for ol_flags are replaced by unified packet type and relevant macros. Signed-off-by: Helin Zhang --- examples/ip_reassembly/main.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) v2 changes: * Used

[dpdk-dev] [PATCH v2 10/15] examples/ip_fragmentation: support of unified packet type

2015-02-09 Thread Helin Zhang
To unify packet types among all PMDs, bit masks and relevant macros of packet type for ol_flags are replaced by unified packet type and relevant macros. Signed-off-by: Helin Zhang --- examples/ip_fragmentation/main.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) v2 changes: *

[dpdk-dev] [PATCH v2 09/15] app/test: support of unified packet type

2015-02-09 Thread Helin Zhang
To unify packet types among all PMDs, bit masks and relevant macros of packet type for ol_flags are replaced by unified packet type and relevant macros. Signed-off-by: Helin Zhang Signed-off-by: Jijiang Liu --- app/test-pmd/csumonly.c | 6 +++--- app/test-pmd/rxonly.c | 9 +++-- 2 files

[dpdk-dev] [PATCH v2 07/15] vmxnet3: support of unified packet type

2015-02-09 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for ol_flags are replaced by unified packet type. Signed-off-by: Helin Zhang --- lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) v2 changes: * Used redefined packet types and enlarged

[dpdk-dev] [PATCH v2 05/15] i40e: support of unified packet type

2015-02-09 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for ol_flags are replaced by unified packet type. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e_rxtx.c | 786 ++-- 1 file changed, 512 insertions(+), 274 deletions(-) v2 changes: * Used

[dpdk-dev] [PATCH v2 04/15] ixgbe: support of unified packet type for vector

2015-02-09 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for ol_flags are replaced by unified packet type. Note that around 2% performance drop (64B) was observed of doing 4 ports (1 port per 82599 card) IO forwarding on the same SNB core. Signed-off-by: Cunming Liang Signed-off-by: Helin

[dpdk-dev] [PATCH v2 03/15] ixgbe: support of unified packet type

2015-02-09 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for ol_flags are replaced by unified packet type. Note that around 2.5% performance drop (64B) was observed of doing 4 ports (1 port per 82599 card) IO forwarding on the same SNB core. Signed-off-by: Helin Zhang ---

[dpdk-dev] [PATCH v2 02/15] e1000: support of unified packet type

2015-02-09 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for ol_flags are replaced by unified packet type. Signed-off-by: Helin Zhang --- lib/librte_pmd_e1000/igb_rxtx.c | 98 ++--- 1 file changed, 83 insertions(+), 15 deletions(-) v2 changes: * Used

[dpdk-dev] [PATCH v2 01/15] mbuf: add definitions of unified packet types

2015-02-09 Thread Helin Zhang
As there are only 6 bit flags in ol_flags for indicating packet types, which is not enough to describe all the possible packet types hardware can recognize. For example, i40e hardware can recognize more than 150 packet types. Unified packet type is composed of tunnel type, L3 type, L4 type and

[dpdk-dev] [PATCH v2 00/15] unified packet type

2015-02-09 Thread Helin Zhang
Currently only 6 bits which are stored in ol_flags are used to indicate the packet types. This is not enough, as some NIC hardware can recognize quite a lot of packet types, e.g i40e hardware can recognize more than 150 packet types. Hiding those packet types hides hardware offload capabilities

[dpdk-dev] [PATCH 2/2] i40e:enable TSO support

2015-02-09 Thread Jijiang Liu
This patch enables i40e TSO feature for both non-tunneling packet and tunneling packet. Signed-off-by: Jijiang Liu Signed-off-by: Miroslaw Walukiewicz --- lib/librte_pmd_i40e/i40e_rxtx.c | 99 --- lib/librte_pmd_i40e/i40e_rxtx.h | 13 + 2 files

[dpdk-dev] [PATCH 1/2] i40e:advertise TSO capability

2015-02-09 Thread Jijiang Liu
Advertise the DEV_TX_OFFLOAD_TCP_TSO flag in the PMD features. It means that the i40e PMD supports the offload of TSO. Signed-off-by: Jijiang Liu Signed-off-by: Miroslaw Walukiewicz --- lib/librte_pmd_i40e/i40e_ethdev.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git

[dpdk-dev] [PATCH 0/2] support TSO on i40e

2015-02-09 Thread Jijiang Liu
This patch set enables i40e TSO feature for both non-tunneling packet and tunneling packet. Change logs: v2 change: rework based on Olivier's patch set [PATCH v2 00/20] enhance tx checksum offload API http://dpdk.org/ml/archives/dev/2015-February/012375.html Jijiang Liu

[dpdk-dev] [PATCH 0/3] Enable uio_pci_generic support

2015-02-09 Thread Bruce Richardson
On Thu, Jan 29, 2015 at 05:28:16PM +0800, Danny Zhou wrote: > Linux kernel provides UIO as well as VFIO mechanism to support writing user > space device driver. Comparing to UIO which is available since 2.6.32 kernel, > the VFIO is introduced into kernel since version 3.6.0 with better interrupt >

[dpdk-dev] [PATCH v4 12/17] eal: set _lcore_id and _socket_id to (-1) by default

2015-02-09 Thread Liang, Cunming
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Monday, February 09, 2015 4:01 AM > To: Liang, Cunming; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 12/17] eal: set _lcore_id and _socket_id to > (-1) > by default > > Hi, > > On 02/02/2015

[dpdk-dev] [PATCH v4 11/17] log: fix the gap to support non-EAL thread

2015-02-09 Thread Liang, Cunming
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Monday, February 09, 2015 4:01 AM > To: Liang, Cunming; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 11/17] log: fix the gap to support non-EAL > thread > > Hi, > > On 02/02/2015 03:02 AM,

[dpdk-dev] [PATCH v4 10/17] malloc: fix the issue of SOCKET_ID_ANY

2015-02-09 Thread Liang, Cunming
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Monday, February 09, 2015 4:01 AM > To: Liang, Cunming; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 10/17] malloc: fix the issue of > SOCKET_ID_ANY > > Hi, > > On 02/02/2015 03:02 AM, Cunming

[dpdk-dev] [PATCH v4 09/17] enic: fix re-define freebsd compile complain

2015-02-09 Thread Liang, Cunming
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Monday, February 09, 2015 4:01 AM > To: Liang, Cunming; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 09/17] enic: fix re-define freebsd compile > complain > > Hi, > > On 02/02/2015 03:02 AM,

[dpdk-dev] [PATCH v4 08/17] eal: apply affinity of EAL thread by assigned cpuset

2015-02-09 Thread Liang, Cunming
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Monday, February 09, 2015 4:01 AM > To: Liang, Cunming; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 08/17] eal: apply affinity of EAL thread by > assigned cpuset > > Hi, > > On 02/02/2015 03:02

[dpdk-dev] [PATCH v7 08/14] eal/linux/pci: Add functions for unmapping igb_uio resources

2015-02-09 Thread Iremonger, Bernard
> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Monday, February 9, 2015 8:31 AM > To: dev at dpdk.org > Cc: Iremonger, Bernard; Qiu, Michael; Tetsuya Mukawa > Subject: [PATCH v7 08/14] eal/linux/pci: Add functions for unmapping igb_uio > resources > >

[dpdk-dev] mbuf: how to set data to NULL?

2015-02-09 Thread Kavanagh, Mark B
Hi Bruce, I figured as much, thanks for confirming. We'll probably go with a flag. Thanks again, Mark > -Original Message- > From: Richardson, Bruce > Sent: Monday, February 9, 2015 12:59 PM > To: Kavanagh, Mark B > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] mbuf: how to set data to

[dpdk-dev] [PATCH] enic: silence log message

2015-02-09 Thread David Marchand
On Sun, Feb 8, 2015 at 6:36 PM, Stephen Hemminger < stephen at networkplumber.org> wrote: > From: Stephen Hemminger > > Silence is normal. drivers should speak only when spoken to and not > be chatty. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_pmd_enic/enic_main.c | 2 -- > 1 file

[dpdk-dev] [PATCH v4 06/17] eal: add eal_common_thread.c for common thread API

2015-02-09 Thread Liang, Cunming
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Monday, February 09, 2015 4:00 AM > To: Liang, Cunming; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 06/17] eal: add eal_common_thread.c for > common thread API > > Hi, > > On 02/02/2015 03:02

[dpdk-dev] i40e: Steps and required configurations of how to achieve the best performance!

2015-02-09 Thread David Marchand
Hello Helin, On Thu, Oct 16, 2014 at 2:43 AM, Zhang, Helin wrote: > Hi Thomas > > > > Yes, your proposal it the perfect one, also the most complicated one. I > was thinking of that one as well, but we did not have enough time for that > in our 1.8 timeframe. > > In the long run, I agree with

[dpdk-dev] [PATCH v7 04/14] eal/pci: Consolidate pci address comparison APIs

2015-02-09 Thread Qiu, Michael
On 2/9/2015 4:31 PM, Tetsuya Mukawa wrote: > This patch replaces pci_addr_comparison() and memcmp() of pci addresses by > eal_compare_pci_addr(). > > v5: > - Fix pci_scan_one to handle pt_driver correctly. > v4: > - Fix calculation method of eal_compare_pci_addr(). > - Add parameter checking. > >

[dpdk-dev] mbuf: how to set data to NULL?

2015-02-09 Thread Bruce Richardson
On Mon, Feb 09, 2015 at 10:51:36AM +, Kavanagh, Mark B wrote: > Hi Bruce, > > As a follow-on to my previous question: I suppose what I'm really getting at > is trying to understand the implications of removing the data pointer, and > determine if it's possible to replicate behavior observed

[dpdk-dev] [PATCH v4 05/17] eal: new TLS definition and API declaration

2015-02-09 Thread Liang, Cunming
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Monday, February 09, 2015 4:00 AM > To: Liang, Cunming; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 05/17] eal: new TLS definition and API > declaration > > Hi, > > On 02/02/2015 03:02 AM,

[dpdk-dev] [PATCH v4 04/17] eal: add support parsing socket_id from cpuset

2015-02-09 Thread Liang, Cunming
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Monday, February 09, 2015 4:00 AM > To: Liang, Cunming; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 04/17] eal: add support parsing socket_id > from cpuset > > Hi, > > On 02/02/2015 03:02 AM,

[dpdk-dev] [PATCH] vhost: notify guest to fill buffer when there is no buffer

2015-02-09 Thread Linhaifeng
On 2015/2/9 10:57, Xu, Qian Q wrote: > Haifeng, > No matter mergeable =0 or 1, I have not met the issue that the vhost-user > crash when start VM. Have u changed the code? As you said below, vhost-switch > will notify guest after sending every packet, yes, it's the current code, and >

[dpdk-dev] [PATCH v4 03/17] eal: fix wrong strnlen() return value in 32bit icc

2015-02-09 Thread Liang, Cunming
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Monday, February 09, 2015 4:00 AM > To: Liang, Cunming; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 03/17] eal: fix wrong strnlen() return > value in > 32bit icc > > Hi, > > On 02/02/2015

[dpdk-dev] [PATCH v4 02/17] eal: new eal option '--lcores' for cpu assignment

2015-02-09 Thread Liang, Cunming
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Monday, February 09, 2015 4:00 AM > To: Liang, Cunming; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 02/17] eal: new eal option '--lcores' for > cpu > assignment > > Hi, > > On 02/02/2015 03:02

[dpdk-dev] [PATCH v4 01/17] eal: add cpuset into per EAL thread lcore_config

2015-02-09 Thread Liang, Cunming
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Monday, February 09, 2015 4:00 AM > To: Liang, Cunming; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 01/17] eal: add cpuset into per EAL thread > lcore_config > > Hi, > > On 02/02/2015 03:02 AM,

[dpdk-dev] mbuf: how to set data to NULL?

2015-02-09 Thread Kavanagh, Mark B
Hi Bruce, As a follow-on to my previous question: I suppose what I'm really getting at is trying to understand the implications of removing the data pointer, and determine if it's possible to replicate behavior observed in DPDK 1.7 (which we need in our use case). Take this situation for

[dpdk-dev] [PATCH 1/4] pci: allow access to PCI config space

2015-02-09 Thread David Marchand
Hello Stephen, - It looks a bit odd to me, we end up with something asymetric between uio / vfio wrt pci config space. Can we an api consistent between the two ? Does this mean that your pmd cannot work / has not been used with vfio ? - Anyway, I suppose we could reuse this api to remove the

[dpdk-dev] [PATCH v2 01/15] mbuf: add definitions of unified packet types

2015-02-09 Thread Bruce Richardson
On Mon, Feb 09, 2015 at 02:40:35PM +0800, Helin Zhang wrote: > As there are only 6 bit flags in ol_flags for indicating packet types, > which is not enough to describe all the possible packet types hardware > can recognize. For example, i40e hardware can recognize more than 150 > packet types.

[dpdk-dev] [PATCH] x32 ABI support, first iteration

2015-02-09 Thread Ananyev, Konstantin
> Subject: [PATCH] x32 ABI support, first iteration > > Signed-off-by: Konstantin Ananyev > Signed-off-by: Daniel Mrzyglod > --- > config/defconfig_x86_x32-native-linuxapp-gcc | 46 > mk/arch/x86_x32/rte.vars.mk | 63 > > 2

[dpdk-dev] [PATCH 2/2] i40e:enable TSO support

2015-02-09 Thread David Marchand
Hello, This patch does two things at the same time. Please split this to make it easier to understand (see comments below). On Mon, Feb 9, 2015 at 7:32 AM, Jijiang Liu wrote: > This patch enables i40e TSO feature for both non-tunneling packet and > tunneling packet. > > Signed-off-by: Jijiang

[dpdk-dev] [PATCH v4 25/26] virtio: Fix wmb issue

2015-02-09 Thread Ouyang Changchun
It needs use virtio_wmb instead of virtio_rmb for store memory barrier. Signed-off-by: Changchun Ouyang --- lib/librte_pmd_virtio/virtqueue.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_pmd_virtio/virtqueue.h b/lib/librte_pmd_virtio/virtqueue.h index

[dpdk-dev] [PATCH v4 24/26] virtio: Remove hotspots

2015-02-09 Thread Ouyang Changchun
Remove those hotspots which is unnecessary when early returning occurs; Signed-off-by: Changchun Ouyang --- lib/librte_pmd_virtio/virtio_rxtx.c | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/lib/librte_pmd_virtio/virtio_rxtx.c

[dpdk-dev] [PATCH v4 21/26] example/vhost: Add vlan-strip cmd line option

2015-02-09 Thread Ouyang Changchun
Support turn on/off RX VLAN strip on host, this let guest get the chance of using its software VALN strip functionality. Signed-off-by: Changchun Ouyang --- examples/vhost/main.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/examples/vhost/main.c

[dpdk-dev] [PATCH v4 20/26] example/vhost: Avoid inserting vlan twice

2015-02-09 Thread Ouyang Changchun
Check if it has already been vlan-tagged packet, if true, avoid inserting a duplicated vlan tag into it. This is a possible case when guest has the capability of inserting vlan tag. Signed-off-by: Changchun Ouyang --- examples/vhost/main.c | 45 - 1

[dpdk-dev] [PATCH v4 19/26] ether: Fix vlan strip/insert issue

2015-02-09 Thread Ouyang Changchun
Need swap the data from cpu to BE(big endian) for vlan-type. Signed-off-by: Changchun Ouyang --- lib/librte_ether/rte_ether.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_ether/rte_ether.h b/lib/librte_ether/rte_ether.h index 74f71c2..0797908 100644 ---

[dpdk-dev] [PATCH v4 18/26] virtio: Fix descriptor index issue

2015-02-09 Thread Ouyang Changchun
It should use vring descriptor index instead of used_ring index to index vq_descx. Signed-off-by: Changchun Ouyang --- lib/librte_pmd_virtio/virtio_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_pmd_virtio/virtio_rxtx.c

[dpdk-dev] [PATCH v4 17/26] virtio: Use port IO to get PCI resource.

2015-02-09 Thread Ouyang Changchun
Make virtio not require UIO for some security reasons, this is to match 6Wind's virtio-net-pmd. Signed-off-by: Changchun Ouyang --- changes in v3: Remove macro RTE_EAL_PORT_IO; virtio pmd could support uio and ioports method to get the address; lib/librte_pmd_virtio/Makefile|

[dpdk-dev] [PATCH v4 16/26] virtio: Free mbuf's with threshold

2015-02-09 Thread Ouyang Changchun
This makes virtio driver work like ixgbe. Transmit buffers are held until a transmit threshold is reached. The previous behavior was to hold mbuf's until the ring entry was reused which caused more memory usage than needed. Signed-off-by: Stephen Hemminger Signed-off-by: Changchun Ouyang ---

[dpdk-dev] [PATCH v4 15/26] virtio: Add ability to set MAC address

2015-02-09 Thread Ouyang Changchun
Need to have do special things to set default mac address. Signed-off-by: Stephen Hemminger Signed-off-by: Changchun Ouyang --- lib/librte_ether/rte_ethdev.h | 5 + lib/librte_pmd_virtio/virtio_ethdev.c | 24 2 files changed, 29 insertions(+) diff --git

[dpdk-dev] [PATCH v4 14/26] virtio: Add suport for multiple mac addresses

2015-02-09 Thread Ouyang Changchun
Virtio support multiple MAC addresses. Signed-off-by: Stephen Hemminger Signed-off-by: Changchun Ouyang --- lib/librte_pmd_virtio/virtio_ethdev.c | 94 ++- lib/librte_pmd_virtio/virtio_ethdev.h | 3 +- lib/librte_pmd_virtio/virtqueue.h | 34 - 3

[dpdk-dev] [PATCH v4 13/26] virtio: Add support for vlan filtering

2015-02-09 Thread Ouyang Changchun
Virtio supports vlan filtering. Signed-off-by: Stephen Hemminger Signed-off-by: Changchun Ouyang --- lib/librte_pmd_virtio/virtio_ethdev.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c

  1   2   >