[dpdk-dev] [PATCH v6 16/16] maintainers: claim for fm10k review

2015-02-17 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Claim for fm10k polling mode driver review. Signed-off-by: Chen Jing D(Mark) --- MAINTAINERS |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index a771fa3..e7a425b 100644 --- a/MAINTAINERS

[dpdk-dev] [PATCH v6 15/16] fm10k: add PF and VF interrupt handling function

2015-02-17 Thread Chen Jing D(Mark)
From: Jeff Shaw 1. Add functions to enable PF/VF interrupt. 2. Add function to process error message passed from interrupt. 2. Add 2 interrupt handling functions, one for PF and one for VF. 2. Enable interrupt after completing initialization of NIC. Signed-off-by: Jeff

[dpdk-dev] [PATCH v6 14/16] fm10k: add SRIOV-VF support

2015-02-17 Thread Chen Jing D(Mark)
From: Jeff Shaw fm10k pmd driver will support both PF and VF device with single copy of code. The reason is NIC maps registers with same function in PF and VF to same PCI I/O address. Then, PF/VF drivers use same address to access registers belonging to it, HW will

[dpdk-dev] [PATCH v6 13/16] fm10k: add function to set vlan

2015-02-17 Thread Chen Jing D(Mark)
From: Jeff Shaw Add fm10k_vlan_filter_set to set vlan. Signed-off-by: Jeff Shaw Signed-off-by: Chen Jing D(Mark) --- lib/librte_pmd_fm10k/fm10k_ethdev.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git

[dpdk-dev] [PATCH v6 12/16] fm10k: add scatter receive function

2015-02-17 Thread Chen Jing D(Mark)
From: Jeff Shaw 1. Add fm10k_recv_scattered_pkts function to receive jumbo frame and multi-segment packets. 2. Configure correct receive function in rx_init and dev_init. Signed-off-by: Jeff Shaw Signed-off-by: Chen Jing D(Mark) --- lib/librte_pmd_fm10k/fm10k.h

[dpdk-dev] [PATCH v6 11/16] fm10k: add PF RSS support

2015-02-17 Thread Chen Jing D(Mark)
From: Jeff Shaw 1. Configure RSS in fm10k_dev_rx_init function. 2. Add fm10k_rss_hash_update and fm10k_rss_hash_conf_get to get and inquery RSS configuration. Signed-off-by: Jeff Shaw Signed-off-by: Chen Jing D(Mark) --- lib/librte_pmd_fm10k/fm10k_ethdev.c | 156

[dpdk-dev] [PATCH v6 10/16] fm10k: add receive and tranmit function

2015-02-17 Thread Chen Jing D(Mark)
From: Jeff Shaw 1. Add fm10k_recv_pkts and fm10k_xmit_pkts functions. 2. Link app function pointer to actual fm10k recv/xmit functions. 3. Change Makefile to compile new file fm10k_rxtx.c Signed-off-by: Jeff Shaw Signed-off-by: Chen Jing D(Mark) ---

[dpdk-dev] [PATCH v6 09/16] fm10k: add dev start/stop functions

2015-02-17 Thread Chen Jing D(Mark)
From: Jeff Shaw 1. Add function to initialize RX queues. 2. Add function to initialize TX queues. 3. Add fm10k_dev_start, fm10k_dev_stop and fm10k_dev_close functions. 4. Add function to close mailbox service. Signed-off-by: Jeff Shaw Signed-off-by: Chen Jing

[dpdk-dev] [PATCH v6 07/16] fm10k: add Tx queue setup/release function

2015-02-17 Thread Chen Jing D(Mark)
From: Jeff Shaw Add fm10k_tx_queue_setup and fm10k_tx_queue_release functions. Signed-off-by: Jeff Shaw Signed-off-by: Chen Jing D(Mark) --- lib/librte_pmd_fm10k/fm10k_ethdev.c | 205 +++ 1 files changed, 205 insertions(+), 0

[dpdk-dev] [PATCH v6 06/16] fm10k: add Rx queue setup/release function

2015-02-17 Thread Chen Jing D(Mark)
From: Jeff Shaw Add fm10k_rx_queue_setup and fm10k_rx_queue_release functions. Signed-off-by: Jeff Shaw Signed-off-by: Chen Jing D(Mark) --- lib/librte_pmd_fm10k/fm10k_ethdev.c | 254 +++ 1 files changed, 254 insertions(+), 0

[dpdk-dev] [PATCH v6 05/16] fm10k: add reta update/requery functions

2015-02-17 Thread Chen Jing D(Mark)
From: Jeff Shaw 1. Add fm10k_reta_update and fm10k_reta_query functions. 2. Add fm10k_link_update and fm10k_dev_infos_get functions. Signed-off-by: Jeff Shaw Signed-off-by: Chen Jing D(Mark) --- lib/librte_pmd_fm10k/fm10k_ethdev.c | 162

[dpdk-dev] [PATCH v6 04/16] config: change config files to add fm10k into compile

2015-02-17 Thread Chen Jing D(Mark)
From: Jeff Shaw 1. Change config/common_bsdapp and config/common_linuxapp, add macros to control fm10k pmd driver compile for linux and bsd. 2. Change lib/Makefile to add fm10k driver into compile list. 3. Change mk/rte.app.mk to add fm10k lib into link.

[dpdk-dev] [PATCH v6 03/16] fm10k: register fm10k pmd PF driver

2015-02-17 Thread Chen Jing D(Mark)
From: Jeff Shaw 1. Add init function to scan and initialize fm10k PF device. 2. Add implementation to register fm10k pmd PF driver. 3. Add 3 functions fm10k_dev_configure, fm10k_stats_get and fm10k_stats_get. 4. Add fm10k.h to define macros and basic data structure.

[dpdk-dev] [PATCH v6 01/16] fm10k: add base driver

2015-02-17 Thread Chen Jing D(Mark)
From: Jeff Shaw Base driver is developed and maintained by Intel ND team, includes basic functional service to Intel Ethernet Switch FM1 Series of silicons. Any suggestion on bug fix and improvement within this directory is welcome, but need this team to change and

[dpdk-dev] [PATCH v6 00/16] lib/librte_pmd_fm10k : fm10k pmd driver

2015-02-17 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" The patch set add poll mode driver for the host interface of Intel Ethernet Switch FM1 Series of silicons, which integrate NIC and switch functionalities. The patch set include below features: 1. Basic RX/TX functions for PF/VF. 2. Interrupt

[dpdk-dev] [PATCH v3 5/5] l3fwd-power: enable one-shot rx interrupt and polling/interrupt mode switch

2015-02-17 Thread Zhou Danny
v3 changes - Add spinlock to ensure thread safe when accessing interrupt mask register v2 changes - Remove unused function which is for debug purpose Demonstrate how to handle per rx queue interrupt in a NAPI-like implementation in usersapce. PDK polling thread mainly works in polling mode and

[dpdk-dev] [PATCH v3 4/5] eal: add per rx queue interrupt handling based on VFIO

2015-02-17 Thread Zhou Danny
v3 changes: - Fix review comments v2 changes: - Fix compilation issue for a missed header file - Bug fix: free unreleased resources on the exception path before return - Consolidate coding style related review comments This patch does below: - Create multiple VFIO eventfd for rx queues. - Handle

[dpdk-dev] [PATCH v3 3/5] igb: enable rx queue interrupts for PF

2015-02-17 Thread Zhou Danny
v3 changes - Remove unnecessary variables in e1000_mac_info - Remove spinlok from PMD v2 changes - Consolidate review comments related to coding style The patch does below for igb PF: - Setup NIC to generate MSI-X interrupts - Set the IVAR register to map interrupt causes to vectors - Implement

[dpdk-dev] [PATCH v3 2/5] ixgbe: enable rx queue interrupts for both PF and VF

2015-02-17 Thread Zhou Danny
v3 changes - Remove spinlok from PMD v2 changes - Consolidate review comments related to coding style The patch does below things for ixgbe PF and VF: - Setup NIC to generate MSI-X interrupts - Set the IVAR register to map interrupt causes to vectors - Implement interrupt enable/disable

[dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt enable/disable functions

2015-02-17 Thread Zhou Danny
v3 changes - Add return value for interrupt enable/disable functions Add two dev_ops functions to enable and disable rx queue interrupts Signed-off-by: Danny Zhou Tested-by: Yong Liu --- lib/librte_ether/rte_ethdev.c | 43 lib/librte_ether/rte_ethdev.h | 57

[dpdk-dev] [PATCH v3 0/5] Interrupt mode PMD

2015-02-17 Thread Zhou Danny
v3 changes - Add return value for interrupt enable/disable functions - Move spinlok from PMD to L3fwd-power - Remove unnecessary variables in e1000_mac_info - Fix miscelleous review comments v2 changes - Fix compilation issue in Makefile for missed header file. - Consolidate internal and

[dpdk-dev] [PATCH v8 12/14] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-02-17 Thread Tetsuya Mukawa
On 2015/02/17 18:23, Thomas Monjalon wrote: > 2015-02-17 17:51, Tetsuya Mukawa: >> On 2015/02/17 10:48, Thomas Monjalon wrote: >>> 2015-02-16 13:14, Tetsuya Mukawa: +/* attach the new physical device, then store port_id of the device */ +static int +rte_eal_dev_attach_pdev(struct

[dpdk-dev] [PATCH v8 12/14] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-02-17 Thread Tetsuya Mukawa
On 2015/02/17 10:48, Thomas Monjalon wrote: > 2015-02-16 13:14, Tetsuya Mukawa: >> These functions are used for attaching or detaching a port. >> When rte_eal_dev_attach() is called, the function tries to realize the >> device name as pci address. If this is done successfully, >>

[dpdk-dev] [PATCH v8 07/14] ethdev: Add functions that will be used by port hotplug functions

2015-02-17 Thread Tetsuya Mukawa
On 2015/02/17 10:04, Thomas Monjalon wrote: > 2015-02-16 13:14, Tetsuya Mukawa: >> The patch adds following functions. >> >> - rte_eth_dev_save() >> The function is used for saving current rte_eth_dev structures. >> - rte_eth_dev_get_changed_port() >> The function receives the rte_eth_dev

[dpdk-dev] [PATCH v4 2/2] examples: introduce new l2fwd-headroom example

2015-02-17 Thread Pawel Wodkowski
This app demonstrate usage of new headroom library. It is basicaly orginal l2fwd with following modificantions to met headroom library requirements: - main_loop() was split into two jobs: forward job and flush job. Logic for those jobs is almost the same as in orginal application. - stats is moved

[dpdk-dev] [PATCH v4 1/2] librte_headroom: New library for checking core/system/app load

2015-02-17 Thread Pawel Wodkowski
This library provide API to measure time spend in particular parts of code and to calculate optimal polling time. To calculate a those statistics application code need to be devided into parts (called jobs) that do something. It is up to application to decide what is considered a job. Series of

[dpdk-dev] [PATCH v4 0/2] new headroom stats library and example application

2015-02-17 Thread Pawel Wodkowski
Hi community, I would like to introduce library for measuring load of some arbitrary jobs. It can be used to profile every kind of job sets on any arbitrary execution unit or tasking library. In provided l2fwd-headroom example I demonstrate how to use this library to select optimal rx burst poll

[dpdk-dev] [PATCH v3 2/2] tespmd: fix DCB in SRIOV mode support

2015-02-17 Thread Pawel Wodkowski
This patch incorporate fixes to support DCB in SRIOV mode for testpmd. Signed-off-by: Pawel Wodkowski --- app/test-pmd/cmdline.c | 4 ++-- app/test-pmd/testpmd.c | 39 +-- app/test-pmd/testpmd.h | 10 -- 3 files changed, 31 insertions(+), 22

[dpdk-dev] [PATCH v3 1/2] pmd: enable DCB in SRIOV

2015-02-17 Thread Pawel Wodkowski
This patch enables DCB in SRIOV mode for ixgbe (Niantic) driver. Signed-off-by: Pawel Wodkowski --- lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 2 +- lib/librte_pmd_ixgbe/ixgbe_pf.c | 19 ++- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 7 +++ 3 files changed, 14 insertions(+), 14

[dpdk-dev] [PATCH v3 0/2] new headroom stats library and example application

2015-02-17 Thread Pawel Wodkowski
Hi community, I would like to introduce library for measuring load of some arbitrary jobs. It can be used to profile every kind of job sets on any arbitrary execution unit or tasking library. In provided l2fwd-headroom example I demonstrate how to use this library to select optimal rx burst poll

[dpdk-dev] [PATCH v8 12/14] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-02-17 Thread Maxime Leroy
Hi Tetsuya, On Tue, Feb 17, 2015 at 9:51 AM, Tetsuya Mukawa wrote: > > > >> +/* get port_id enabled by above procedures */ > >> +if (rte_eth_dev_get_changed_port(devs, _port_id)) > >> +goto err2; > > [...] > > > >> /** > >> + * Uninitilization function called for each device

[dpdk-dev] Patches outstanding

2015-02-17 Thread Thomas Monjalon
2015-02-17 10:35, Stephen Hemminger: > There are currently 1039 patches outstanding on DPDK. > What is the schedule for getting these merged or resolved? Several patches are ready to be applied in coming days. Many patches are still waiting for closing discussions. > I don't think it would be

[dpdk-dev] [PATCH v2 2/2] examples: introduce new l2fwd-headroom example

2015-02-17 Thread Pawel Wodkowski
This app demonstrate usage of new headroom library. It is basicaly orginal l2fwd with following modificantions to met headroom library requirements: - main_loop() was split into two jobs: forward job and flush job. Logic for those jobs is almost the same as in orginal application. - stats is moved

[dpdk-dev] [PATCH v2 1/2] librte_headroom: New library for checking core/system/app load

2015-02-17 Thread Pawel Wodkowski
This library provide API to measure time spend in particular parts of code and to calculate optimal polling time. To calculate a those statistics application code need to be devided into parts (called jobs) that do something. It is up to application to decide what is considered a job. Series of

[dpdk-dev] [PATCH v2 0/2] new headroom stats library and example application

2015-02-17 Thread Pawel Wodkowski
Hi community, I would like to introduce library for measuring load of some arbitrary jobs. It can be used to profile every kind of job sets on any arbitrary execution unit or tasking library. In provided l2fwd-headroom example I demonstrate how to use this library to select optimal rx burst poll

[dpdk-dev] testpmd app issues

2015-02-17 Thread Bruce Richardson
On Tue, Feb 17, 2015 at 09:31:33AM -0700, Jeff Wang wrote: > Hi, > > I'm new to DPDK. > > I have gone through the user guide, set up environment, hugepages. I can > get the helloworld app work. Now, when I tried to play with the testpmd > app, I got the following issue: > > [root at localhost

[dpdk-dev] [PATCH v3 0/2] new headroom stats library and example application

2015-02-17 Thread Wodkowski, PawelX
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pawel Wodkowski > Sent: Tuesday, February 17, 2015 5:20 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v3 0/2] new headroom stats library and example > application > > Hi community, > I would like to

[dpdk-dev] [PATCH v2 3/4] examples: example showing use of callbacks.

2015-02-17 Thread Thomas Monjalon
2015-02-17 12:25, Bruce Richardson: > On Mon, Feb 16, 2015 at 06:34:37PM +0100, Thomas Monjalon wrote: > > 2015-02-16 15:16, Bruce Richardson: > > > On Mon, Feb 16, 2015 at 03:33:40PM +0100, Olivier MATZ wrote: > > > > Hi John, > > > > > > > > On 02/13/2015 04:39 PM, John McNamara wrote: > > > >

[dpdk-dev] [PATCH v2 3/4] examples: example showing use of callbacks.

2015-02-17 Thread Bruce Richardson
On Tue, Feb 17, 2015 at 11:08:10AM -0500, Neil Horman wrote: > On Tue, Feb 17, 2015 at 04:00:56PM +, Bruce Richardson wrote: > > On Tue, Feb 17, 2015 at 10:49:24AM -0500, Neil Horman wrote: > > > On Tue, Feb 17, 2015 at 01:50:58PM +, Bruce Richardson wrote: > > > > On Tue, Feb 17, 2015 at

[dpdk-dev] [PATCH v2 3/4] examples: example showing use of callbacks.

2015-02-17 Thread Bruce Richardson
On Tue, Feb 17, 2015 at 10:49:24AM -0500, Neil Horman wrote: > On Tue, Feb 17, 2015 at 01:50:58PM +, Bruce Richardson wrote: > > On Tue, Feb 17, 2015 at 02:28:02PM +0100, Olivier MATZ wrote: > > > Hi Bruce, > > > > > > On 02/17/2015 01:25 PM, Bruce Richardson wrote: > > > >On Mon, Feb 16,

[dpdk-dev] [PATCH v2 3/4] examples: example showing use of callbacks.

2015-02-17 Thread Bruce Richardson
On Tue, Feb 17, 2015 at 04:32:01PM +0100, Thomas Monjalon wrote: > 2015-02-17 12:25, Bruce Richardson: > > On Mon, Feb 16, 2015 at 06:34:37PM +0100, Thomas Monjalon wrote: > > > 2015-02-16 15:16, Bruce Richardson: > > > > On Mon, Feb 16, 2015 at 03:33:40PM +0100, Olivier MATZ wrote: > > > > > Hi

[dpdk-dev] [PATCH] testpmd: initialize rx_fc_en and tx_fc_en to zero

2015-02-17 Thread Pablo de Lara
rx_fc_en and tx_fc_en in cmd_link_flow_ctrl_set_parsed could be used without being initialized. Signed-off-by: Pablo de Lara --- app/test-pmd/cmdline.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index

[dpdk-dev] [PATCH v8 13/14] eal: Enable port hotplug framework in Linux

2015-02-17 Thread Tetsuya Mukawa
On 2015/02/17 10:25, Thomas Monjalon wrote: > 2015-02-16 13:14, Tetsuya Mukawa: >> The patch enables CONFIG_RTE_LIBRTE_EAL_HOTPLUG in Linux configuration. > This patch should be introduced earlier in the patchset. Sure, I will.

[dpdk-dev] [PATCH v8 11/14] ethdev: Add one dev_type parameter to rte_eth_dev_allocate

2015-02-17 Thread Tetsuya Mukawa
On 2015/02/17 10:24, Thomas Monjalon wrote: > 2015-02-16 13:14, Tetsuya Mukawa: >> This new parameter is needed to keep device type like physical or virtual. > Actually types are "PCI" and "virtual". OK, I will change above sentence to explain it more clearly. >> Port detaching processes are

[dpdk-dev] [PATCH v8 10/14] eal/pci: Cleanup pci driver initialization code

2015-02-17 Thread Tetsuya Mukawa
On 2015/02/17 10:18, Thomas Monjalon wrote: > 2015-02-16 13:14, Tetsuya Mukawa: >> - Add rte_eal_pci_close_one_dirver() >> The function is used for closing the specified driver and device. >> - Add pci_invoke_all_drivers() >> The function is based on pci_probe_all_drivers. But it can not only

[dpdk-dev] [PATCH v8 08/14] eal/linux/pci: Add functions for unmapping igb_uio resources

2015-02-17 Thread Tetsuya Mukawa
On 2015/02/17 10:11, Thomas Monjalon wrote: > 2015-02-16 13:14, Tetsuya Mukawa: >> The patch adds functions for unmapping igb_uio resources. The patch is only >> for Linux and igb_uio environment. VFIO and BSD are not supported. >> >> v8: >> - Fix typo. >> (Thanks to Iremonger, Bernard) >> v5:

[dpdk-dev] [PATCH v8 06/14] eal, ethdev: Add a function and function pointers to close ether device

2015-02-17 Thread Tetsuya Mukawa
On 2015/02/17 9:56, Thomas Monjalon wrote: > 2015-02-16 13:14, Tetsuya Mukawa: >> The patch adds function pointer to rte_pci_driver and eth_driver >> structure. These function pointers are used when ports are detached. >> Also, the patch adds rte_eth_dev_uninit(). So far, it's not called >> by

[dpdk-dev] [PATCH v8 05/14] ethdev: Add rte_eth_dev_free to free specified device

2015-02-17 Thread Tetsuya Mukawa
On 2015/02/17 9:46, Thomas Monjalon wrote: > 2015-02-16 13:14, Tetsuya Mukawa: >> This patch adds rte_eth_dev_free(). The function is used for changing an >> attached status of the device that has specified name. >> >> v6: >> - Use rte_eth_dev structure as the paramter of rte_eth_dev_free(). >>

[dpdk-dev] [PATCH v8 04/14] eal/pci: Consolidate pci address comparison APIs

2015-02-17 Thread Tetsuya Mukawa
On 2015/02/17 9:44, Thomas Monjalon wrote: > 2015-02-16 13:14, Tetsuya Mukawa: >> This patch replaces pci_addr_comparison() and memcmp() of pci addresses by >> eal_compare_pci_addr(). >> >> v8: >> - Fix pci_scan_one() to update sysfs values. >> (Thanks to Qiu, Michael and Iremonger, Bernard) >>

[dpdk-dev] [PATCH v8 03/14] eal/pci, ethdev: Remove assumption that port will not be detached

2015-02-17 Thread Tetsuya Mukawa
Hi Thomas, I appreciate for your all comments. On 2015/02/17 9:36, Thomas Monjalon wrote: > 2015-02-16 13:14, Tetsuya Mukawa: >> To remove assumption, do like followings. >> >> This patch adds "RTE_PCI_DRV_DETACHABLE" to drv_flags of rte_pci_driver >> structure. The flags indicate the driver can

[dpdk-dev] [PATCH v3 16/16] mbuf: remove old packet type bit masks

2015-02-17 Thread Helin Zhang
As unified packet types are used instead, those old bit masks and the relevant macros for packet type indication need to be removed. Signed-off-by: Helin Zhang --- lib/librte_mbuf/rte_mbuf.c | 6 -- lib/librte_mbuf/rte_mbuf.h | 14 -- 2 files changed, 4 insertions(+), 16

[dpdk-dev] [PATCH v3 15/16] examples/l3fwd: support of unified packet type

2015-02-17 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. Signed-off-by: Helin Zhang --- examples/l3fwd/main.c | 71 +-- 1 file changed, 40 insertions(+), 31 deletions(-) v2 changes: * Used

[dpdk-dev] [PATCH v3 14/16] examples/l3fwd-power: support of unified packet type

2015-02-17 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. Signed-off-by: Helin Zhang --- examples/l3fwd-power/main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) v2 changes: * Used redefined packet types and enlarged

[dpdk-dev] [PATCH v3 12/16] examples/ip_reassembly: support of unified packet type

2015-02-17 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. Signed-off-by: Helin Zhang --- examples/ip_reassembly/main.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) v2 changes: * Used redefined packet types and enlarged

[dpdk-dev] [PATCH v3 11/16] examples/ip_fragmentation: support of unified packet type

2015-02-17 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. Signed-off-by: Helin Zhang --- examples/ip_fragmentation/main.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) v2 changes: * Used redefined packet types and enlarged

[dpdk-dev] [PATCH v3 10/16] app/testpmd: support of unified packet type

2015-02-17 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. Signed-off-by: Helin Zhang Signed-off-by: Jijiang Liu --- app/test-pmd/csumonly.c | 10 +- app/test-pmd/rxonly.c | 9 +++-- 2 files changed, 8 insertions(+), 11

[dpdk-dev] [PATCH v3 09/16] app/test-pipeline: support of unified packet type

2015-02-17 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. Signed-off-by: Helin Zhang --- app/test-pipeline/pipeline_hash.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) v2 changes: * Used redefined packet types and

[dpdk-dev] [PATCH v3 08/16] vmxnet3: support of unified packet type

2015-02-17 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. Signed-off-by: Helin Zhang --- lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) v2 changes: * Used redefined packet types and

[dpdk-dev] [PATCH v3 07/16] enic: support of unified packet type

2015-02-17 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. Signed-off-by: Helin Zhang --- lib/librte_pmd_enic/enic_main.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) v2 changes: * Used redefined packet types and

[dpdk-dev] [PATCH v3 06/16] i40e: support of unified packet type

2015-02-17 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e_rxtx.c | 786 ++-- 1 file changed, 512 insertions(+), 274 deletions(-) v2 changes: *

[dpdk-dev] [PATCH v3 05/16] ixgbe: support of unified packet type

2015-02-17 Thread Helin Zhang
To unify packet type among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. Note that around 2.5% performance drop (64B) was observed of doing 4 ports (1 port per 82599 card) IO forwarding on the same SNB core. Signed-off-by: Helin Zhang ---

[dpdk-dev] [PATCH v3 04/16] e1000: support of unified packet type

2015-02-17 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. Signed-off-by: Helin Zhang --- lib/librte_pmd_e1000/igb_rxtx.c | 98 ++--- 1 file changed, 83 insertions(+), 15 deletions(-) v2 changes: * Used

[dpdk-dev] [PATCH v3 03/16] mbuf: add definitions of unified packet types

2015-02-17 Thread Helin Zhang
As there are only 6 bit flags in ol_flags for indicating packet types, which is not enough to describe all the possible packet types hardware can recognize. For example, i40e hardware can recognize more than 150 packet types. Unified packet type is composed of L2 type, L3 type, L4 type, tunnel

[dpdk-dev] [PATCH v3 02/16] ixgbe: support of unified packet type for vector

2015-02-17 Thread Helin Zhang
To unify the packet type, bit masks of packet type for ol_flags are replaced. In addition, more packet types (UDP, TCP and SCTP) are supported in vectorized ixgbe PMD. Note that around 2% performance drop (64B) was observed of doing 4 ports (1 port per 82599 card) IO forwarding on the same SNB

[dpdk-dev] [PATCH v3 00/16] unified packet type

2015-02-17 Thread Helin Zhang
Currently only 6 bits which are stored in ol_flags are used to indicate the packet types. This is not enough, as some NIC hardware can recognize quite a lot of packet types, e.g i40e hardware can recognize more than 150 packet types. Hiding those packet types hides hardware offload capabilities

[dpdk-dev] [PATCH v8 07/14] ethdev: Add functions that will be used by port hotplug functions

2015-02-17 Thread Tetsuya Mukawa
On 2015/02/16 21:41, Neil Horman wrote: > On Mon, Feb 16, 2015 at 01:14:26PM +0900, Tetsuya Mukawa wrote: >> The patch adds following functions. >> >> - rte_eth_dev_save() >> The function is used for saving current rte_eth_dev structures. >> - rte_eth_dev_get_changed_port() >> The function

[dpdk-dev] [PATCH v8 08/14] eal/linux/pci: Add functions for unmapping igb_uio resources

2015-02-17 Thread Tetsuya Mukawa
On 2015/02/16 21:45, Neil Horman wrote: > On Mon, Feb 16, 2015 at 01:14:27PM +0900, Tetsuya Mukawa wrote: >> The patch adds functions for unmapping igb_uio resources. The patch is only >> for Linux and igb_uio environment. VFIO and BSD are not supported. >> >> v8: >> - Fix typo. >> (Thanks to

[dpdk-dev] [PATCH v2 3/4] examples: example showing use of callbacks.

2015-02-17 Thread Olivier MATZ
Hi Bruce, On 02/17/2015 01:25 PM, Bruce Richardson wrote: > On Mon, Feb 16, 2015 at 06:34:37PM +0100, Thomas Monjalon wrote: >> 2015-02-16 15:16, Bruce Richardson: >>> In this specific instance, given that the application does little else, >>> there >>> is no real advantage to using the

[dpdk-dev] [PATCH v2 3/4] examples: example showing use of callbacks.

2015-02-17 Thread Neil Horman
On Tue, Feb 17, 2015 at 04:15:09PM +, Bruce Richardson wrote: > On Tue, Feb 17, 2015 at 11:08:10AM -0500, Neil Horman wrote: > > On Tue, Feb 17, 2015 at 04:00:56PM +, Bruce Richardson wrote: > > > On Tue, Feb 17, 2015 at 10:49:24AM -0500, Neil Horman wrote: > > > > On Tue, Feb 17, 2015 at

[dpdk-dev] [PATCH v2 3/4] examples: example showing use of callbacks.

2015-02-17 Thread Bruce Richardson
On Tue, Feb 17, 2015 at 02:28:02PM +0100, Olivier MATZ wrote: > Hi Bruce, > > On 02/17/2015 01:25 PM, Bruce Richardson wrote: > >On Mon, Feb 16, 2015 at 06:34:37PM +0100, Thomas Monjalon wrote: > >>2015-02-16 15:16, Bruce Richardson: > >>>In this specific instance, given that the application does

[dpdk-dev] [PATCH v5 15/17] fm10k: add PF and VF interrupt handling function

2015-02-17 Thread Chen, Jing D
Hi, From: David Marchand [mailto:david.march...@6wind.com] Sent: Friday, February 13, 2015 7:42 PM To: Chen, Jing D Cc: dev at dpdk.org; Zhang, Helin; Qiu, Michael; Neil Horman; Thomas Monjalon; Shaw, Jeffrey B Subject: Re: [PATCH v5 15/17] fm10k: add PF and VF interrupt handling function

[dpdk-dev] [PATCH v5 12/17] fm10k: Add scatter receive function

2015-02-17 Thread Chen, Jing D
Hi, From: David Marchand [mailto:david.march...@6wind.com] Sent: Friday, February 13, 2015 7:55 PM To: Chen, Jing D Cc: dev at dpdk.org; Zhang, Helin; Qiu, Michael; Neil Horman; Thomas Monjalon; Shaw, Jeffrey B Subject: Re: [PATCH v5 12/17] fm10k: Add scatter receive function Hello, On Fri,

[dpdk-dev] [PATCH v5 10/17] fm10k: add receive and tranmit function

2015-02-17 Thread Chen, Jing D
Hi, From: David Marchand [mailto:david.march...@6wind.com] Sent: Friday, February 13, 2015 7:54 PM To: Chen, Jing D Cc: dev at dpdk.org; Zhang, Helin; Qiu, Michael; Neil Horman; Thomas Monjalon; Shaw, Jeffrey B Subject: Re: [PATCH v5 10/17] fm10k: add receive and tranmit function On Fri, Feb

[dpdk-dev] [PATCH v5 10/17] fm10k: add receive and tranmit function

2015-02-17 Thread Chen, Jing D
Hi, From: David Marchand [mailto:david.march...@6wind.com] Sent: Friday, February 13, 2015 7:43 PM To: Chen, Jing D Cc: dev at dpdk.org; Zhang, Helin; Qiu, Michael; Neil Horman; Thomas Monjalon; Shaw, Jeffrey B Subject: Re: [PATCH v5 10/17] fm10k: add receive and tranmit function Hello,? On

[dpdk-dev] [PATCH v5 06/17] fm10k: add rx_queue_setup/release function

2015-02-17 Thread Chen, Jing D
Hi, From: David Marchand [mailto:david.march...@6wind.com] Sent: Friday, February 13, 2015 7:08 PM To: Chen, Jing D Cc: dev at dpdk.org; Zhang, Helin; Qiu, Michael; Neil Horman; Thomas Monjalon; Shaw, Jeffrey B Subject: Re: [PATCH v5 06/17] fm10k: add rx_queue_setup/release function Hello,?

[dpdk-dev] [PATCH v2 3/4] examples: example showing use of callbacks.

2015-02-17 Thread Bruce Richardson
On Mon, Feb 16, 2015 at 06:34:37PM +0100, Thomas Monjalon wrote: > 2015-02-16 15:16, Bruce Richardson: > > On Mon, Feb 16, 2015 at 03:33:40PM +0100, Olivier MATZ wrote: > > > Hi John, > > > > > > On 02/13/2015 04:39 PM, John McNamara wrote: > > > > From: Richardson, Bruce > > > > > > > >

[dpdk-dev] [PATCH v2 3/4] examples: example showing use of callbacks.

2015-02-17 Thread Declan Doherty
On 16/02/15 17:34, Thomas Monjalon wrote: > 2015-02-16 15:16, Bruce Richardson: >> On Mon, Feb 16, 2015 at 03:33:40PM +0100, Olivier MATZ wrote: >>> Hi John, >>> >>> On 02/13/2015 04:39 PM, John McNamara wrote: From: Richardson, Bruce Example showing how callbacks can be used to

[dpdk-dev] How to get register dumps of 82599 NICs with a dpdk application

2015-02-17 Thread sai kiran
Hi, We are trying to experiment with DPDK?s l2fwd application with two 82599 Intel 10G adapters. Am able to run the l2fwd application and traffic is successfully forwarded. We want to verify the NIC registers and ring descriptors when the ports are bound to DPDK. Is there a way like

[dpdk-dev] [PATCH v2 3/4] examples: example showing use of callbacks.

2015-02-17 Thread Neil Horman
On Tue, Feb 17, 2015 at 04:00:56PM +, Bruce Richardson wrote: > On Tue, Feb 17, 2015 at 10:49:24AM -0500, Neil Horman wrote: > > On Tue, Feb 17, 2015 at 01:50:58PM +, Bruce Richardson wrote: > > > On Tue, Feb 17, 2015 at 02:28:02PM +0100, Olivier MATZ wrote: > > > > Hi Bruce, > > > > > >

[dpdk-dev] [PATCH v2 6/7] rte_sched: eliminate floating point in calculating byte clock

2015-02-17 Thread Stephen Hemminger
On Mon, 16 Feb 2015 22:44:31 + "Dumitrescu, Cristian" wrote: > Hi Stephen, > > Sorry, NACK. > > 1. Overflow issue > As you declare cycles_per_byte as uint32_t, for a CPU frequency of 2-3 GHz, > the line of code below results in overflow: > port->cycles_per_byte = (rte_get_tsc_hz()

[dpdk-dev] [PATCH v3 4/5] eal: add per rx queue interrupt handling based on VFIO

2015-02-17 Thread Neil Horman
On Tue, Feb 17, 2015 at 09:47:18PM +0800, Zhou Danny wrote: > v3 changes: > - Fix review comments > > v2 changes: > - Fix compilation issue for a missed header file > - Bug fix: free unreleased resources on the exception path before return > - Consolidate coding style related review comments > >

[dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt enable/disable functions

2015-02-17 Thread Neil Horman
On Tue, Feb 17, 2015 at 09:47:15PM +0800, Zhou Danny wrote: > v3 changes > - Add return value for interrupt enable/disable functions > > Add two dev_ops functions to enable and disable rx queue interrupts > > Signed-off-by: Danny Zhou > Tested-by: Yong Liu > --- >

[dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt enable/disable functions

2015-02-17 Thread Neil Horman
On Tue, Feb 17, 2015 at 09:47:15PM +0800, Zhou Danny wrote: > v3 changes > - Add return value for interrupt enable/disable functions > > Add two dev_ops functions to enable and disable rx queue interrupts > > Signed-off-by: Danny Zhou > Tested-by: Yong Liu > --- >

[dpdk-dev] [PATCH v2 3/4] examples: example showing use of callbacks.

2015-02-17 Thread Neil Horman
On Tue, Feb 17, 2015 at 01:50:58PM +, Bruce Richardson wrote: > On Tue, Feb 17, 2015 at 02:28:02PM +0100, Olivier MATZ wrote: > > Hi Bruce, > > > > On 02/17/2015 01:25 PM, Bruce Richardson wrote: > > >On Mon, Feb 16, 2015 at 06:34:37PM +0100, Thomas Monjalon wrote: > > >>2015-02-16 15:16,

[dpdk-dev] Lcore-vports-queues mapping

2015-02-17 Thread kuldeep.sam...@wipro.com
I am using OVDK (dpdk openvswitch ), where I need to enhance the packet processing speed on DPDK data path by modifying lcore-- port-- queue mapping . -Original Message- From: Bruce Richardson [mailto:bruce.richard...@intel.com] Sent: Tuesday, February 17, 2015 3:59 PM To: Kuldeep

[dpdk-dev] Patches outstanding

2015-02-17 Thread Stephen Hemminger
There are currently 1039 patches outstanding on DPDK. What is the schedule for getting these merged or resolved? I don't think it would be reasonable to declare 2.0 as done until the patch backlog is 0!

[dpdk-dev] Previous DPDK version API documentation for app developers

2015-02-17 Thread Thomas Monjalon
2015-02-17 00:48, Matthew Hall: > On Feb 12, 2015, at 1:29 AM, Thomas Monjalon > wrote: > > Yes you can: make doc > > For doxygen API only: make doc-api-html > > For sphinx only: doc-guides-html. > > Hi Thomas, > > In 1.7 for me at least I found the target was called: doc-htmlapi . > > Did

[dpdk-dev] Lcore-vports-queues mapping

2015-02-17 Thread Bruce Richardson
On Tue, Feb 17, 2015 at 10:20:14AM +, kuldeep.samasi at wipro.com wrote: > Hi Bruce , > > Thanks for suggestion , I want to map the lcore -- vport -- queue manually by > command prompt , which program file I needs to enhance . > What application are you using? DPDK is primarily a set of

[dpdk-dev] [PATCH v8 12/14] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-02-17 Thread Thomas Monjalon
2015-02-17 17:51, Tetsuya Mukawa: > On 2015/02/17 10:48, Thomas Monjalon wrote: > > 2015-02-16 13:14, Tetsuya Mukawa: > >> +/* attach the new physical device, then store port_id of the device */ > >> +static int > >> +rte_eal_dev_attach_pdev(struct rte_pci_addr *addr, uint8_t *port_id) > >> +{ >

[dpdk-dev] Lcore-vports-queues mapping

2015-02-17 Thread kuldeep.sam...@wipro.com
Hi Bruce , Thanks for suggestion , I want to map the lcore -- vport -- queue manually by command prompt , which program file I needs to enhance . Regards Kuldeep -Original Message- From: Bruce Richardson [mailto:bruce.richard...@intel.com] Sent: Tuesday, February 17, 2015 3:44 PM

[dpdk-dev] [PATCH v8 00/19] support multi-pthread per core

2015-02-17 Thread Ananyev, Konstantin
> -Original Message- > From: Liang, Cunming > Sent: Tuesday, February 17, 2015 2:08 AM > To: dev at dpdk.org > Cc: Ananyev, Konstantin; olivier.matz at 6wind.com; nhorman at tuxdriver.com; > thomas.monjalon at 6wind.com; Liang, Cunming > Subject: [PATCH v8 00/19] support multi-pthread

[dpdk-dev] Lcore-vports-queues mapping

2015-02-17 Thread Bruce Richardson
On Tue, Feb 17, 2015 at 09:08:07AM +, kuldeep.samasi at wipro.com wrote: > Hi Team , > > I am using DPDK-1.7.1 , I am trying find out how to map lcore -- >vports -- > > queuesin code level as well as user command prompt level . > Suggestions are welcome on this . > > Hi, cores and ports

[dpdk-dev] [PATCH v8 19/19] timer: add support to non-EAL thread

2015-02-17 Thread Cunming Liang
Allow to setup timers only for EAL (lcore) threads (__lcore_id < MAX_LCORE_ID). E.g. ? dynamically created thread will be able to reset/stop timer for lcore thread, but it will be not allowed to setup timer for itself or another non-lcore thread. rte_timer_manage() for non-lcore thread would

[dpdk-dev] [PATCH v8 18/19] ring: add sched_yield to avoid spin forever

2015-02-17 Thread Cunming Liang
Add a sched_yield() syscall if the thread spins for too long, waiting other thread to finish its operations on the ring. That gives pre-empted thread a chance to proceed and finish with ring enqnue/dequeue operation. The purpose is to reduce contention on the ring. By ring_perf_test, it doesn't

[dpdk-dev] [PATCH v8 17/19] ring: add support to non-EAL thread

2015-02-17 Thread Cunming Liang
ring debug stat won't take care non-EAL thread. Signed-off-by: Cunming Liang --- v6 changes: rollback v5 changes v5 changes: check __lcore_id with LCORE_ID_ANY instead of RTE_MAX_LCORE lib/librte_ring/rte_ring.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff

[dpdk-dev] [PATCH v8 16/19] mempool: add support to non-EAL thread

2015-02-17 Thread Cunming Liang
For non-EAL thread, bypass per lcore cache, directly use ring pool. It allows using rte_mempool in either EAL thread or any user pthread. As in non-EAL thread, it directly rely on rte_ring and it's none preemptive. It doesn't suggest to run multi-pthread/cpu which compete the rte_mempool. It will

[dpdk-dev] [PATCH v8 15/19] eal: fix recursive spinlock in non-EAL thraed

2015-02-17 Thread Cunming Liang
In non-EAL thread, lcore_id alrways be LCORE_ID_ANY. It cann't be used as unique id for recursive spinlock. Then use rte_gettid() to replace it. Signed-off-by: Cunming Liang --- lib/librte_eal/common/include/generic/rte_spinlock.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[dpdk-dev] [PATCH v8 14/19] eal: set _lcore_id and _socket_id to (-1) by default

2015-02-17 Thread Cunming Liang
For those none EAL thread, *_lcore_id* shall always be LCORE_ID_ANY. The libraries using *_lcore_id* as index need to take care. *_socket_id* always be SOCKET_ID_ANY unitl the thread changes the affinity by rte_thread_set_affinity() Signed-off-by: Cunming Liang --- v5 changes: define

[dpdk-dev] [PATCH v8 13/19] log: fix the gap to support non-EAL thread

2015-02-17 Thread Cunming Liang
For those non-EAL thread, *_lcore_id* is invalid and probably larger than RTE_MAX_LCORE. The patch adds the check and allows only EAL thread using EAL per thread log level and log type. Others shares the global log level. Signed-off-by: Cunming Liang --- lib/librte_eal/common/eal_common_log.c

[dpdk-dev] [PATCH v8 12/19] malloc: fix the issue of SOCKET_ID_ANY

2015-02-17 Thread Cunming Liang
Add check for rte_socket_id(), avoid get unexpected return like (-1). By using rte_malloc_socket(), socket id is assigned by socket_arg. If socket_arg set to SOCKET_ID_ANY, it expects to use the socket id to which the current cores belongs. As the thread may affinity on a cpuset, the cores in the

  1   2   >