[dpdk-dev] [PATCH v8 03/14] eal/pci, ethdev: Remove assumption that port will not be detached

2015-02-18 Thread Tetsuya Mukawa
On 2015/02/18 21:33, Iremonger, Bernard wrote: > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tetsuya Mukawa >> Sent: Wednesday, February 18, 2015 10:58 AM >> To: Richardson, Bruce; Thomas Monjalon >> Cc: dev at dpdk.org; Neil Horman >> Subject: Re: [dpdk

[dpdk-dev] [PATCH v8 03/14] eal/pci, ethdev: Remove assumption that port will not be detached

2015-02-18 Thread Tetsuya Mukawa
On 2015/02/18 21:23, Bruce Richardson wrote: > On Wed, Feb 18, 2015 at 07:58:06PM +0900, Tetsuya Mukawa wrote: >> On 2015/02/18 19:03, Bruce Richardson wrote: >>> On Wed, Feb 18, 2015 at 10:57:25AM +0100, Thomas Monjalon wrote: 2015-02-18 15:10, Tetsuya Mukawa: > On 2015/02/18 10:54, Tetsu

[dpdk-dev] [PATCH v8 04/14] eal/pci: Consolidate pci address comparison APIs

2015-02-18 Thread Tetsuya Mukawa
On 2015/02/18 20:39, Iremonger, Bernard wrote: > >> -Original Message- >> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] >> Sent: Wednesday, February 18, 2015 10:33 AM >> To: Iremonger, Bernard >> Cc: Tetsuya Mukawa; dev at dpdk.org; ivan.boule at 6wind.com >> Subject: Re: [dpd

[dpdk-dev] [PATCH v2] doc: Add requirements for x32 ABI

2015-02-18 Thread Thomas Monjalon
> > This patch add requirements about compiler and distribution support. > > > > v2: > > spelling fixes > > > > Signed-off-by: Daniel Mrzyglod > > Acked-by: Pablo de Lara > > Thanks Daniel! Applied, thanks

[dpdk-dev] [PATCH] x32 ABI support, first iteration

2015-02-18 Thread Thomas Monjalon
> > > Signed-off-by: Konstantin Ananyev > > > Signed-off-by: Daniel Mrzyglod > > > > Acked-by: Konstantin Ananyev > > Acked-by: Pablo de Lara > > Just add that documentation should be updated for this. Applied, thanks

[dpdk-dev] [PATCH v2 0/6] Link Bonding mode 6 support (ALB)

2015-02-18 Thread Thomas Monjalon
Hi, 2015-02-13 16:12, Declan Doherty: > On 13/02/15 15:16, Michal Jastrzebski wrote: > > Michal Jastrzebski (6): > >net: changed arp_hdr struct declaration > >bond: add link bonding mode 6 implementation > >bond: add debug info for mode 6 link bonding > >bond: add example applicati

[dpdk-dev] [RFC PATCH] lib/librte_ethdev: Expand port identifier

2015-02-18 Thread Tetsuya Mukawa
Currently uint8_t is used for port identifier. This patch changes it, and use uint16_t as port identifier. This patch only changes ethdev library. ABI of the library will be kept even after applying it. Also, this patch involves following fixes. - Use "port_id" as variable name instead of "port".

[dpdk-dev] [PATCH v8 03/14] eal/pci, ethdev: Remove assumption that port will not be detached

2015-02-18 Thread Tetsuya Mukawa
On 2015/02/18 19:03, Bruce Richardson wrote: > On Wed, Feb 18, 2015 at 10:57:25AM +0100, Thomas Monjalon wrote: >> 2015-02-18 15:10, Tetsuya Mukawa: >>> On 2015/02/18 10:54, Tetsuya Mukawa wrote: On 2015/02/18 9:31, Thomas Monjalon wrote: > 2015-02-17 15:14, Tetsuya Mukawa: >> On 2015/

[dpdk-dev] [PATCH 0/3] doc: ACL - add description for new features.

2015-02-18 Thread Butler, Siobhan A
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Konstantin > Ananyev > Sent: Wednesday, February 18, 2015 4:29 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 0/3] doc: ACL - add description for new features. > > Konstantin Ananyev (3): > doc: Add re

[dpdk-dev] [PATCH v3 2/3] ethdev: Add rxtx callback support

2015-02-18 Thread Thomas Monjalon
2015-02-18 17:42, John McNamara: > From: Richardson, Bruce > > Add in support for inline processing of packets inside the RX or > TX call. For an RX callback, what happens is that we get a set of > packets from the NIC and then pass them to a callback function, if > configured, to allow additiona

[dpdk-dev] [PATCH 1/3] bond change warning

2015-02-18 Thread Thomas Monjalon
> Remove function name from warning. > > Signed-off-by: Pawel Wodkowski Other patches of series were split in other series. Applied, thanks

[dpdk-dev] [PATCH v4 0/4] Unit tests for mode 4

2015-02-18 Thread Thomas Monjalon
> > This patch series depends of "PMD ring" patches and should be applied after > > them > > to run successfully. > > > > v4 changes > > - Adapting to changes in the initialize_eth_header API > > - Fix linking problem against librte_pmd_bond.so for shared libraries > > - Patchset cleanup for smoot

[dpdk-dev] [PATCH] fm10k: fix clang unused function error

2015-02-18 Thread Wiles, Keith
On 2/18/15, 12:07 PM, "Shaw, Jeffrey B" wrote: >This commit fixes the following error which was reported when >compiling with clang by moving the function inside an >RTE_LIBRTE_FM10K_DEBUG_RX ifdef block. > >error: unused function 'dump_rxd' > >Signed-off-by: Jeff Shaw Acked-by: keith.wiles a

[dpdk-dev] [PATCH v8 08/14] eal/linux/pci: Add functions for unmapping igb_uio resources

2015-02-18 Thread Tetsuya Mukawa
On 2015/02/18 10:09, Thomas Monjalon wrote: > 2015-02-17 15:15, Tetsuya Mukawa: >> On 2015/02/17 10:11, Thomas Monjalon wrote: >>> 2015-02-16 13:14, Tetsuya Mukawa: +#ifdef ENABLE_HOTPLUG >>> Please avoid using #ifdef if not really necessary. >> I agree with you. >> In this case, only hotplug

[dpdk-dev] [PATCH v2 0/3] PMD ring MAC management, fix initialization, link up/down

2015-02-18 Thread Thomas Monjalon
> > Patch split into smaller parts to separate features from previous version. > > > > Tomasz Kulasek (3): > > PMD Ring - Add link up/down functions > > PMD Ring - Add MAC addr add/remove functions > > PMD Ring - Fix for per device management > > Acked-by: Declan Doherty Applied, thanks

[dpdk-dev] [PATCH] fm10k: fix clang warning flags

2015-02-18 Thread Wiles, Keith
On 2/18/15, 11:57 AM, "Shaw, Jeffrey B" wrote: >This commit fixes the following error which was reported when >compiling with clang by removing the option. > >error: unknown warning option '-Wno-unused-but-set-variable' > >Signed-off-by: Jeff Shaw Acked-by: keith.wiles at intel.com >--- > lib

[dpdk-dev] fm10k_rxtx.c does not compile

2015-02-18 Thread Thomas Monjalon
Hi Keith, 2015-02-18 17:01, Wiles, Keith: > I just pulled the code and found a unused function error ?dump_rxd()? > > I had to add the ifdef around the function and remove the ifdef inside the > function: > > #ifdef RTE_LIBRTE_FM10K_DEBUG_RX > static inline void dump_rxd(union fm10k_rx_desc *rx

[dpdk-dev] [PATCH] bond: fix for kvlist memory leak on rte_kvargs_process failure identified by klockwork scan

2015-02-18 Thread Thomas Monjalon
> > Signed-off-by: Declan Doherty > > Acked-by: Olivier Matz Applied, thanks

[dpdk-dev] [PATCH 0/2] rte_ethdev fix/improvement

2015-02-18 Thread Thomas Monjalon
> > This patch series include a fix and an improvement to rte_ethdev lib. > > > > Jia Yu (2): > > rte_ethdev: update link status (speed, duplex, link_up) after > > rte_eth_dev_start > > rte_ethdev: add return status for rte_eth_stats_get > > Acked-by: Helin Zhang Applied, thanks

[dpdk-dev] [PATCH v3 3/3] examples: example showing use of callbacks.

2015-02-18 Thread John McNamara
From: Richardson, Bruce Example showing how callbacks can be used to insert a timestamp into each packet on RX. On TX the timestamp is used to calculate the packet latency through the app, in cycles. Signed-off-by: Bruce Richardson Signed-off-by: John McNamara --- examples/rxtx_callbacks/Make

[dpdk-dev] [PATCH v3 2/3] ethdev: Add rxtx callback support

2015-02-18 Thread John McNamara
From: Richardson, Bruce Add in support for inline processing of packets inside the RX or TX call. For an RX callback, what happens is that we get a set of packets from the NIC and then pass them to a callback function, if configured, to allow additional processing to be done on them, e.g. filling

[dpdk-dev] [PATCH v3 1/3] ethdev: Rename callbacks field to link_intr_cbs

2015-02-18 Thread John McNamara
From: Richardson, Bruce The 'callbacks' member of the rte_eth_dev structure has been renamed to 'link_intr_cbs' to make it clear that it refers to callbacks from NIC interrupts. This allows us to add other types of callbacks to the structure without ambiguity. Signed-off-by: Bruce Richardson Si

[dpdk-dev] [PATCH v3 0/3] DPDK ethdev callback support

2015-02-18 Thread John McNamara
This patchset is for a small addition to the ethdev library, to add in support for callbacks at the RX and TX stages. This allows packet processing to be done on packets before they get returned to applications using rte_eth_rx_burst call. See the RFC cover letter for the use cases: http://dp

[dpdk-dev] fm10k_rxtx.c does not compile

2015-02-18 Thread Wiles, Keith
I believe Jeff @ Intel is going to submit a patch soon. On 2/18/15, 11:18 AM, "Thomas Monjalon" wrote: >Hi Keith, > >2015-02-18 17:01, Wiles, Keith: >> I just pulled the code and found a unused function error ?dump_rxd()? >> >> I had to add the ifdef around the function and remove the ifdef in

[dpdk-dev] fm10k_rxtx.c does not compile

2015-02-18 Thread Wiles, Keith
I just pulled the code and found a unused function error ?dump_rxd()? I had to add the ifdef around the function and remove the ifdef inside the function: #ifdef RTE_LIBRTE_FM10K_DEBUG_RX static inline void dump_rxd(union fm10k_rx_desc *rxd) { RTE_SET_USED(rxd); PMD_RX_LOG(DEBUG, "+-

[dpdk-dev] [PATCH v5 0/6] New Reorder Library

2015-02-18 Thread Thomas Monjalon
> This series introduces the new reorder library along with unit tests, > sample app and a new entry in the programmers guide describing the library. > > The library provides reordering of mbufs based on their sequence number. > > As mention in the patch describing the library, one use case is th

[dpdk-dev] [PATCH 3/3] doc: ACL - add description for max_size build parameter

2015-02-18 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- .../prog_guide/packet_classif_access_ctrl.rst | 52 +- 1 file changed, 51 insertions(+), 1 deletion(-) diff --git a/doc/guides/prog_guide/packet_classif_access_ctrl.rst b/doc/guides/prog_guide/packet_classif_access_ctrl.rst index d2

[dpdk-dev] [PATCH 2/3] doc: ACL - add description for different classification methods

2015-02-18 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- doc/guides/prog_guide/packet_classif_access_ctrl.rst | 16 1 file changed, 16 insertions(+) diff --git a/doc/guides/prog_guide/packet_classif_access_ctrl.rst b/doc/guides/prog_guide/packet_classif_access_ctrl.rst index e018c68..d2adbff 1006

[dpdk-dev] [PATCH 1/3] doc: Add restrictions for ACL rule fields

2015-02-18 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- doc/guides/prog_guide/packet_classif_access_ctrl.rst | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/doc/guides/prog_guide/packet_classif_access_ctrl.rst b/doc/guides/prog_guide/packet_classif_access_ctrl.rst index 72f4

[dpdk-dev] [PATCH 0/3] doc: ACL - add description for new features.

2015-02-18 Thread Konstantin Ananyev
Konstantin Ananyev (3): doc: Add restrictions for ACL rule fields doc: ACL - add description for different classification methods doc: ACL - add description for max_size build parameter .../prog_guide/packet_classif_access_ctrl.rst | 83 -- 1 file changed, 78 insert

[dpdk-dev] [PATCH] eal: add missing symbol export for rte_eal_iopl_init()

2015-02-18 Thread Panu Matilainen
On 02/18/2015 04:21 PM, Gonzalez Monroy, Sergio wrote: > On 18/02/2015 14:17, Panu Matilainen wrote: >> Signed-off-by: Panu Matilainen >> --- >> lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + >> lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 + >> 2 files changed, 2 insertions(+)

[dpdk-dev] [PATCH] eal: add missing symbol export for rte_eal_iopl_init()

2015-02-18 Thread Panu Matilainen
Signed-off-by: Panu Matilainen --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map index d362

[dpdk-dev] [PATCH v4 0/5] New Reorder Library

2015-02-18 Thread Thomas Monjalon
Hi Sergio, 2015-02-11 13:07, Sergio Gonzalez Monroy: > This series introduces the new reorder library along with unit tests, > sample app and a new entry in the programmers guide describing the library. > > The library provides reordering of mbufs based on their sequence number. > > As mention i

[dpdk-dev] [PATCH v8 03/14] eal/pci, ethdev: Remove assumption that port will not be detached

2015-02-18 Thread Tetsuya Mukawa
On 2015/02/18 10:54, Tetsuya Mukawa wrote: > On 2015/02/18 9:31, Thomas Monjalon wrote: >> 2015-02-17 15:14, Tetsuya Mukawa: >>> On 2015/02/17 9:36, Thomas Monjalon wrote: 2015-02-16 13:14, Tetsuya Mukawa: Is uint8_t sill a good size for hotpluggable virtual device ids? >>> I am not sure

[dpdk-dev] [PATCH v5 6/6] MAINTAINERS: add and claim reorder

2015-02-18 Thread Sergio Gonzalez Monroy
Add files related to reorder library and claim it. Signed-off-by: Sergio Gonzalez Monroy --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e7a425b..d7d672c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -264,6 +264,14 @@ F: app/test/test_d

[dpdk-dev] [PATCH v5 5/6] doc: new packet ordering app description

2015-02-18 Thread Sergio Gonzalez Monroy
This patch describes how to build and run he new packet ordering sample application that exercises the reorder library. Signed-off-by: Sergio Gonzalez Monroy --- doc/guides/sample_app_ug/index.rst | 1 + doc/guides/sample_app_ug/packet_ordering.rst | 102 +++

[dpdk-dev] [PATCH v5 4/6] doc: new reorder library description

2015-02-18 Thread Sergio Gonzalez Monroy
This patch introduces a new section in the programmers guide describing the reorder library. Signed-off-by: Sergio Gonzalez Monroy --- doc/guides/prog_guide/index.rst | 1 + doc/guides/prog_guide/reorder_lib.rst | 115 ++ 2 files changed, 116 insertions(+)

[dpdk-dev] [PATCH v5 3/6] examples: new sample app packet_ordering

2015-02-18 Thread Sergio Gonzalez Monroy
This new app makes use of the librte_reorder library. It requires at least 3 lcores for RX, Workers (1 or more) and TX threads. Communication between RX-Workers and Workers-TX is done by using rings. The flow of mbufs is the following: * RX thread gets mbufs from driver, set sequence number and e

[dpdk-dev] [PATCH v5 2/6] app: New reorder unit test

2015-02-18 Thread Sergio Gonzalez Monroy
Adding new reorder unit test for the test app. The command to run the unit test from the test shell is: reorder_autotest Signed-off-by: Reshma Pattan Signed-off-by: Sergio Gonzalez Monroy --- app/test/Makefile | 2 + app/test/test_reorder.c | 393

[dpdk-dev] [PATCH v5 1/6] reorder: new reorder library

2015-02-18 Thread Sergio Gonzalez Monroy
This library provides reordering capability for out of order mbufs based on a sequence number in the mbuf structure. Signed-off-by: Reshma Pattan Signed-off-by: Richardson Bruce Signed-off-by: Sergio Gonzalez Monroy --- config/common_bsdapp | 5 + config/common_linu

[dpdk-dev] [PATCH v5 0/6] New Reorder Library

2015-02-18 Thread Sergio Gonzalez Monroy
This series introduces the new reorder library along with unit tests, sample app and a new entry in the programmers guide describing the library. The library provides reordering of mbufs based on their sequence number. As mention in the patch describing the library, one use case is the packet dis

[dpdk-dev] [PATCH v1 1/3] eal: enable uio_pci_generic support

2015-02-18 Thread Thomas Monjalon
Hi Danny, I wanted to apply this patchset which was reviewed. But when having a quick overview, I've seen some strange additions. 2015-01-29 17:28, Danny Zhou: > 1) Unify procedure to retrieve BAR resource mapping information. > 2) Setup bus master bit in NIC's PCIe configuration space for uio_

[dpdk-dev] [PATCH v4 0/5] New Reorder Library

2015-02-18 Thread Gonzalez Monroy, Sergio
On 18/02/2015 14:22, Thomas Monjalon wrote: > Hi Sergio, > > 2015-02-11 13:07, Sergio Gonzalez Monroy: >> This series introduces the new reorder library along with unit tests, >> sample app and a new entry in the programmers guide describing the library. >> >> The library provides reordering of mbu

[dpdk-dev] [PATCH] eal: add missing symbol export for rte_eal_iopl_init()

2015-02-18 Thread Gonzalez Monroy, Sergio
On 18/02/2015 14:17, Panu Matilainen wrote: > Signed-off-by: Panu Matilainen > --- > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map

[dpdk-dev] [PATCH] mk: Rework gcc version detection to permit versions newer than 4.x

2015-02-18 Thread Panu Matilainen
Separately comparing major and minor versions becomes seriously clumsy when with major version changes, convert the entire version string into a numeric value (ie 4.6.0 becomes 460 and 5.0.0 becomes 500) and use that for comparisons. This simplifies the comparisons and makes gcc 5.0 naturally recog

[dpdk-dev] [RFC PATCH] lib/librte_ethdev: Expand port identifier

2015-02-18 Thread Marc Sune
On 18/02/15 13:31, Bruce Richardson wrote: > On Wed, Feb 18, 2015 at 12:30:07PM +, Bruce Richardson wrote: >> On Wed, Feb 18, 2015 at 08:02:49PM +0900, Tetsuya Mukawa wrote: >>> Currently uint8_t is used for port identifier. This patch changes it, >>> and use uint16_t as port identifier. >>> T

[dpdk-dev] [RFC PATCH] lib/librte_ethdev: Expand port identifier

2015-02-18 Thread Bruce Richardson
On Wed, Feb 18, 2015 at 01:05:10PM +, Wodkowski, PawelX wrote: > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > > Sent: Wednesday, February 18, 2015 1:32 PM > > To: Tetsuya Mukawa > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [R

[dpdk-dev] [RFC PATCH] lib/librte_ethdev: Expand port identifier

2015-02-18 Thread Bruce Richardson
On Wed, Feb 18, 2015 at 02:10:48PM +0100, Marc Sune wrote: > > On 18/02/15 13:31, Bruce Richardson wrote: > >On Wed, Feb 18, 2015 at 12:30:07PM +, Bruce Richardson wrote: > >>On Wed, Feb 18, 2015 at 08:02:49PM +0900, Tetsuya Mukawa wrote: > >>>Currently uint8_t is used for port identifier. Thi

[dpdk-dev] [PATCH v2 0/3] remove limit on devargs parameters length

2015-02-18 Thread Thomas Monjalon
2015-02-13 16:03, David Marchand: > Here is a little patchset that removes the limit on the devargs parameters > length. Previously, arguments specified by user would be stored in a static > buffer, while there is no particular reason why we should have such a > constraint, afaik. > > Changes sinc

[dpdk-dev] [PATCH v4 2/2] examples: introduce new l2fwd-headroom example

2015-02-18 Thread De Lara Guarch, Pablo
Hi Pawel, A few things to fix: > -Original Message- > From: Wodkowski, PawelX > Sent: Tuesday, February 17, 2015 4:42 PM > To: dev at dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [PATCH v4 2/2] examples: introduce new l2fwd-headroom example > > This app demonstrate usage of new headro

[dpdk-dev] [PATCH v4 1/2] librte_headroom: New library for checking core/system/app load

2015-02-18 Thread De Lara Guarch, Pablo
Hi Pawel, A few things to fix in this patch: > -Original Message- > From: Wodkowski, PawelX > Sent: Tuesday, February 17, 2015 4:42 PM > To: dev at dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [PATCH v4 1/2] librte_headroom: New library for checking > core/system/app load > > This lib

[dpdk-dev] test_mp_secondary??

2015-02-18 Thread Stephen Hemminger
Why is test_mp_secondary in export list for eal? $ git grep test_mp_secondary MAINTAINERS:F: app/test/test_mp_secondary.c app/test/Makefile:SRCS-y += test_mp_secondary.c app/test/test.c:{ "run_secondary_instances", test_mp_secondary }, app/test/test.h:int test_mp_secondary

[dpdk-dev] [RFC PATCH] lib/librte_ethdev: Expand port identifier

2015-02-18 Thread Wodkowski, PawelX
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > Sent: Wednesday, February 18, 2015 1:32 PM > To: Tetsuya Mukawa > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [RFC PATCH] lib/librte_ethdev: Expand port identifier > > On Wed, Feb 18, 2015 a

[dpdk-dev] [PATCH v8 03/14] eal/pci, ethdev: Remove assumption that port will not be detached

2015-02-18 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tetsuya Mukawa > Sent: Wednesday, February 18, 2015 10:58 AM > To: Richardson, Bruce; Thomas Monjalon > Cc: dev at dpdk.org; Neil Horman > Subject: Re: [dpdk-dev] [PATCH v8 03/14] eal/pci, ethdev: Remove assump

[dpdk-dev] [RFC PATCH] lib/librte_ethdev: Expand port identifier

2015-02-18 Thread Bruce Richardson
On Wed, Feb 18, 2015 at 12:30:07PM +, Bruce Richardson wrote: > On Wed, Feb 18, 2015 at 08:02:49PM +0900, Tetsuya Mukawa wrote: > > Currently uint8_t is used for port identifier. This patch changes it, > > and use uint16_t as port identifier. > > This patch only changes ethdev library. ABI of t

[dpdk-dev] [RFC PATCH] lib/librte_ethdev: Expand port identifier

2015-02-18 Thread Bruce Richardson
On Wed, Feb 18, 2015 at 08:02:49PM +0900, Tetsuya Mukawa wrote: > Currently uint8_t is used for port identifier. This patch changes it, > and use uint16_t as port identifier. > This patch only changes ethdev library. ABI of the library will be > kept even after applying it. > > Also, this patch in

[dpdk-dev] [PATCH v8 03/14] eal/pci, ethdev: Remove assumption that port will not be detached

2015-02-18 Thread Bruce Richardson
On Wed, Feb 18, 2015 at 07:58:06PM +0900, Tetsuya Mukawa wrote: > On 2015/02/18 19:03, Bruce Richardson wrote: > > On Wed, Feb 18, 2015 at 10:57:25AM +0100, Thomas Monjalon wrote: > >> 2015-02-18 15:10, Tetsuya Mukawa: > >>> On 2015/02/18 10:54, Tetsuya Mukawa wrote: > On 2015/02/18 9:31, Thom

[dpdk-dev] [PATCH v2 0/2] Removal of RTE_MBUF_REFCNT

2015-02-18 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Sergio Gonzalez Monroy > Sent: Wednesday, February 18, 2015 11:03 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2 0/2] Removal of RTE_MBUF_REFCNT > > This patch tries to remove the RTE_MBUF_REFCNT con

[dpdk-dev] [PATCH 2/2] Remove RTE_MBUF_REFCNT references

2015-02-18 Thread Olivier MATZ
Hi Konstantin, On 02/18/2015 11:47 AM, Ananyev, Konstantin wrote: >>> How was this managed before, since refcnt field seems to be necessary in >>> order >>> to effectively manage indirect mbufs? Is this just the case that this is >>> something >>> that never worked and that needs to be solved, o

[dpdk-dev] [PATCH 2/2] Remove RTE_MBUF_REFCNT references

2015-02-18 Thread Olivier MATZ
Hi, On 02/18/2015 11:37 AM, Bruce Richardson wrote: >>> How was this managed before, since refcnt field seems to be necessary in >>> order >>> to effectively manage indirect mbufs? Is this just the case that this is >>> something >>> that never worked and that needs to be solved, or is it someth

[dpdk-dev] [PATCH v8 04/14] eal/pci: Consolidate pci address comparison APIs

2015-02-18 Thread Iremonger, Bernard
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, February 18, 2015 10:33 AM > To: Iremonger, Bernard > Cc: Tetsuya Mukawa; dev at dpdk.org; ivan.boule at 6wind.com > Subject: Re: [dpdk-dev] [PATCH v8 04/14] eal/pci: Consolidate pci addr

[dpdk-dev] [PATCH 2/2] Remove RTE_MBUF_REFCNT references

2015-02-18 Thread Olivier MATZ
Hi, On 02/18/2015 11:22 AM, Bruce Richardson wrote: > On Wed, Feb 18, 2015 at 11:14:42AM +0100, Olivier MATZ wrote: >> On 02/18/2015 11:00 AM, Bruce Richardson wrote: >>> On Wed, Feb 18, 2015 at 09:48:58AM +, Ananyev, Konstantin wrote: Hi lads, > -Original Message- >

[dpdk-dev] [PATCH v8 04/14] eal/pci: Consolidate pci address comparison APIs

2015-02-18 Thread Thomas Monjalon
Hi Bernard, 2015-02-18 10:26, Iremonger, Bernard: > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tetsuya Mukawa > > On 2015/02/18 10:02, Thomas Monjalon wrote: > > > 2015-02-17 15:14, Tetsuya Mukawa: > > >> On 2015/02/17 9:44, Thomas Monjalon wrote: > > >>> 2015-02-16 13:14, Tetsuya Muk

[dpdk-dev] Using bypass on Silicom PE210G2BPi9 with Intel 82599ES chip

2015-02-18 Thread Martin Drašar
Hi, I hope that I am using the correct mailing list... I have a Silicom PE210G2BPi9 LR card with Intel 82599ES chip that has a bypass. Now I would like to turn the bypass on and off from software. However, I am having some problems with it. I am able to check whether the card supports the bypass

[dpdk-dev] [PATCH 2/2] Remove RTE_MBUF_REFCNT references

2015-02-18 Thread Olivier MATZ
On 02/18/2015 11:00 AM, Bruce Richardson wrote: > On Wed, Feb 18, 2015 at 09:48:58AM +, Ananyev, Konstantin wrote: >> Hi lads, >> >>> -Original Message- >>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson >>> Sent: Wednesday, February 18, 2015 9:36 AM >>> To: Ol

[dpdk-dev] [PATCH v2 2/2] Remove RTE_MBUF_REFCNT references

2015-02-18 Thread Sergio Gonzalez Monroy
This patch removes all references to RTE_MBUF_REFCNT, setting the refcnt field in the mbuf struct permanently. Signed-off-by: Sergio Gonzalez Monroy Acked-by: Olivier Matz --- app/test/test_link_bonding.c| 15 --- app/test/test_mbuf.c| 17 ---

[dpdk-dev] [PATCH v2 1/2] mbuf: Introduce IND_ATTACHED_MBUF flag

2015-02-18 Thread Sergio Gonzalez Monroy
Currently for mbufs with refcnt, we cannot free mbufs with external memory buffers (ie. vhost zero copy), as they are recognized as indirect attached mbufs and therefore we free the direct mbuf it points to, resulting in an error in the case of external memory buffers. We solve the issue by introd

[dpdk-dev] [PATCH v2 0/2] Removal of RTE_MBUF_REFCNT

2015-02-18 Thread Sergio Gonzalez Monroy
This patch tries to remove the RTE_MBUF_REFCNT config options and dependencies by introducing a new mbuf flag IND_ATTACHED_MBUF that would indicate when the mbuf is an indirect attached mbuf, to differentiate between indirect mbufs and mbufs with external memory buffers (ie. vhost zero copy). Pre

[dpdk-dev] [PATCH v8 03/14] eal/pci, ethdev: Remove assumption that port will not be detached

2015-02-18 Thread Thomas Monjalon
2015-02-18 15:10, Tetsuya Mukawa: > On 2015/02/18 10:54, Tetsuya Mukawa wrote: > > On 2015/02/18 9:31, Thomas Monjalon wrote: > >> 2015-02-17 15:14, Tetsuya Mukawa: > >>> On 2015/02/17 9:36, Thomas Monjalon wrote: > 2015-02-16 13:14, Tetsuya Mukawa: > Is uint8_t sill a good size for hotpl

[dpdk-dev] [PATCH v8 12/14] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-02-18 Thread Tetsuya Mukawa
On 2015/02/18 10:17, Thomas Monjalon wrote: > 2015-02-17 19:26, Tetsuya Mukawa: >> On 2015/02/17 18:23, Thomas Monjalon wrote: >>> 2015-02-17 17:51, Tetsuya Mukawa: On 2015/02/17 10:48, Thomas Monjalon wrote: > 2015-02-16 13:14, Tetsuya Mukawa: >> +/* attach the new physical device, th

[dpdk-dev] [PATCH v8 04/14] eal/pci: Consolidate pci address comparison APIs

2015-02-18 Thread Tetsuya Mukawa
On 2015/02/18 10:02, Thomas Monjalon wrote: > 2015-02-17 15:14, Tetsuya Mukawa: >> On 2015/02/17 9:44, Thomas Monjalon wrote: >>> 2015-02-16 13:14, Tetsuya Mukawa: @@ -356,13 +342,24 @@ pci_scan_one(int dev_pci_fd, struct pci_conf *conf) } else { struct rte_pci_

[dpdk-dev] [PATCH v8 03/14] eal/pci, ethdev: Remove assumption that port will not be detached

2015-02-18 Thread Tetsuya Mukawa
On 2015/02/18 9:31, Thomas Monjalon wrote: > 2015-02-17 15:14, Tetsuya Mukawa: >> On 2015/02/17 9:36, Thomas Monjalon wrote: >>> 2015-02-16 13:14, Tetsuya Mukawa: >>> Is uint8_t sill a good size for hotpluggable virtual device ids? >> I am not sure it's enough, but uint8_t is widely used in "rte_et

[dpdk-dev] [PATCH v8 12/14] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-02-18 Thread Tetsuya Mukawa
On 2015/02/18 1:15, Maxime Leroy wrote: > Hi Tetsuya, > > On Tue, Feb 17, 2015 at 9:51 AM, Tetsuya Mukawa wrote: >> +/* get port_id enabled by above procedures */ +if (rte_eth_dev_get_changed_port(devs, &new_port_id)) +goto err2; >>> [...] >>> /** + *

[dpdk-dev] [PATCH 2/2] Remove RTE_MBUF_REFCNT references

2015-02-18 Thread Olivier MATZ
Hi Bruce, On 02/18/2015 10:35 AM, Bruce Richardson wrote: > On Wed, Feb 18, 2015 at 10:16:56AM +0100, Olivier MATZ wrote: >> Hi Sergio, >> >> On 02/16/2015 05:08 PM, Sergio Gonzalez Monroy wrote: >>> This patch removes all references to RTE_MBUF_REFCNT, setting the refcnt >>> field in the mbuf str

[dpdk-dev] [PATCH 2/2] Remove RTE_MBUF_REFCNT references

2015-02-18 Thread Ananyev, Konstantin
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Wednesday, February 18, 2015 10:34 AM > To: Richardson, Bruce > Cc: Ananyev, Konstantin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] Remove RTE_MBUF_REFCNT references > > Hi, > > On 02/18/2015

[dpdk-dev] [PATCH 2/2] Remove RTE_MBUF_REFCNT references

2015-02-18 Thread Bruce Richardson
On Wed, Feb 18, 2015 at 11:33:48AM +0100, Olivier MATZ wrote: > Hi, > > On 02/18/2015 11:22 AM, Bruce Richardson wrote: > >On Wed, Feb 18, 2015 at 11:14:42AM +0100, Olivier MATZ wrote: > >>On 02/18/2015 11:00 AM, Bruce Richardson wrote: > >>>On Wed, Feb 18, 2015 at 09:48:58AM +, Ananyev, Konst

[dpdk-dev] [PATCH v8 04/14] eal/pci: Consolidate pci address comparison APIs

2015-02-18 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tetsuya Mukawa > Sent: Wednesday, February 18, 2015 1:55 AM > To: Thomas Monjalon > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v8 04/14] eal/pci: Consolidate pci address > comparison APIs > > On 2015/

[dpdk-dev] [PATCH 2/2] Remove RTE_MBUF_REFCNT references

2015-02-18 Thread Bruce Richardson
On Wed, Feb 18, 2015 at 11:14:42AM +0100, Olivier MATZ wrote: > On 02/18/2015 11:00 AM, Bruce Richardson wrote: > >On Wed, Feb 18, 2015 at 09:48:58AM +, Ananyev, Konstantin wrote: > >>Hi lads, > >> > >>>-Original Message- > >>>From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruc

[dpdk-dev] [PATCH 2/2] Remove RTE_MBUF_REFCNT references

2015-02-18 Thread Ananyev, Konstantin
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Wednesday, February 18, 2015 10:15 AM > To: Richardson, Bruce; Ananyev, Konstantin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] Remove RTE_MBUF_REFCNT references > > On 02/18/2015 11:00 AM

[dpdk-dev] [PATCH 2/2] Remove RTE_MBUF_REFCNT references

2015-02-18 Thread Olivier MATZ
Hi Sergio, On 02/16/2015 05:08 PM, Sergio Gonzalez Monroy wrote: > This patch removes all references to RTE_MBUF_REFCNT, setting the refcnt > field in the mbuf struct permanently. > > Signed-off-by: Sergio Gonzalez Monroy I think removing the refcount compile option goes in the right direction.

[dpdk-dev] fm10k_rxtx.c does not compile

2015-02-18 Thread Jeff Shaw
On Wed, Feb 18, 2015 at 05:29:02PM +, Wiles, Keith wrote: > I believe Jeff @ Intel is going to submit a patch soon. I sent patches to fix these errors. Thanks, Jeff

[dpdk-dev] [PATCH] fm10k: fix clang unused function error

2015-02-18 Thread Jeff Shaw
This commit fixes the following error which was reported when compiling with clang by moving the function inside an RTE_LIBRTE_FM10K_DEBUG_RX ifdef block. error: unused function 'dump_rxd' Signed-off-by: Jeff Shaw --- lib/librte_pmd_fm10k/fm10k_rxtx.c | 5 ++--- 1 file changed, 2 insertions(+),

[dpdk-dev] [PATCH v8 03/14] eal/pci, ethdev: Remove assumption that port will not be detached

2015-02-18 Thread Bruce Richardson
On Wed, Feb 18, 2015 at 10:57:25AM +0100, Thomas Monjalon wrote: > 2015-02-18 15:10, Tetsuya Mukawa: > > On 2015/02/18 10:54, Tetsuya Mukawa wrote: > > > On 2015/02/18 9:31, Thomas Monjalon wrote: > > >> 2015-02-17 15:14, Tetsuya Mukawa: > > >>> On 2015/02/17 9:36, Thomas Monjalon wrote: > > 2

[dpdk-dev] [PATCH 2/2] Remove RTE_MBUF_REFCNT references

2015-02-18 Thread Bruce Richardson
On Wed, Feb 18, 2015 at 09:48:58AM +, Ananyev, Konstantin wrote: > Hi lads, > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > > Sent: Wednesday, February 18, 2015 9:36 AM > > To: Olivier MATZ > > Cc: dev at dpdk.org > > Subject: Re:

[dpdk-dev] [PATCH] fm10k: fix clang warning flags

2015-02-18 Thread Jeff Shaw
This commit fixes the following error which was reported when compiling with clang by removing the option. error: unknown warning option '-Wno-unused-but-set-variable' Signed-off-by: Jeff Shaw --- lib/librte_pmd_fm10k/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[dpdk-dev] [PATCH 2/2] Remove RTE_MBUF_REFCNT references

2015-02-18 Thread Ananyev, Konstantin
Hi lads, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > Sent: Wednesday, February 18, 2015 9:36 AM > To: Olivier MATZ > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] Remove RTE_MBUF_REFCNT references > > On Wed, Feb 18, 2015 a

[dpdk-dev] [PATCH 2/2] Remove RTE_MBUF_REFCNT references

2015-02-18 Thread Bruce Richardson
On Wed, Feb 18, 2015 at 10:16:56AM +0100, Olivier MATZ wrote: > Hi Sergio, > > On 02/16/2015 05:08 PM, Sergio Gonzalez Monroy wrote: > >This patch removes all references to RTE_MBUF_REFCNT, setting the refcnt > >field in the mbuf struct permanently. > > > >Signed-off-by: Sergio Gonzalez Monroy >

[dpdk-dev] [PATCH v8 03/14] eal/pci, ethdev: Remove assumption that port will not be detached

2015-02-18 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tetsuya Mukawa > Sent: Wednesday, February 18, 2015 6:10 AM > To: Thomas Monjalon > Cc: dev at dpdk.org; Neil Horman > Subject: Re: [dpdk-dev] [PATCH v8 03/14] eal/pci, ethdev: Remove assumption > that port wi

[dpdk-dev] Vhost-user early adopter feedback

2015-02-18 Thread Benoît Canet
Hello Xie, As promized I integrated your vhost-user patchset from january in my vswitch. I just tried it, it works pretty well. I just had a minor bug with rte_vhost_driver_register taking ownership of the string patch pointer too late. I freed it out of habit just after registering in the cal

[dpdk-dev] rte_memcpy optimization patch to dpdk ver 1.7

2015-02-18 Thread Vithal S Mohare
Ok, crash, as expected. So, now dpdk mandates either AVX2 or SSSE2 supported CPUs. OR applications needs to handle it run-time. Thanks, -Vithal -Original Message- From: Neil Horman [mailto:nhor...@tuxdriver.com] Sent: Tuesday, February 17, 2015 6:32 PM To: Vithal S Mohare Cc: dev at

[dpdk-dev] [PATCH v8 12/14] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-02-18 Thread Thomas Monjalon
2015-02-17 19:26, Tetsuya Mukawa: > On 2015/02/17 18:23, Thomas Monjalon wrote: > > 2015-02-17 17:51, Tetsuya Mukawa: > >> On 2015/02/17 10:48, Thomas Monjalon wrote: > >>> 2015-02-16 13:14, Tetsuya Mukawa: > +/* attach the new physical device, then store port_id of the device */ > +stati

[dpdk-dev] [PATCH v8 08/14] eal/linux/pci: Add functions for unmapping igb_uio resources

2015-02-18 Thread Thomas Monjalon
2015-02-17 15:15, Tetsuya Mukawa: > On 2015/02/17 10:11, Thomas Monjalon wrote: > > 2015-02-16 13:14, Tetsuya Mukawa: > >> +#ifdef ENABLE_HOTPLUG > > Please avoid using #ifdef if not really necessary. > > I agree with you. > In this case, only hotplug functions call pci_unmap_resource(). > So this

[dpdk-dev] [PATCH v8 04/14] eal/pci: Consolidate pci address comparison APIs

2015-02-18 Thread Thomas Monjalon
2015-02-17 15:14, Tetsuya Mukawa: > On 2015/02/17 9:44, Thomas Monjalon wrote: > > 2015-02-16 13:14, Tetsuya Mukawa: > >> @@ -356,13 +342,24 @@ pci_scan_one(int dev_pci_fd, struct pci_conf *conf) > >>} > >>else { > >>struct rte_pci_device *dev2 = NULL; > >> + int ret; >

[dpdk-dev] [PATCH v3 0/5] Interrupt mode PMD

2015-02-18 Thread Liang, Cunming
Hi, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zhou Danny > Sent: Tuesday, February 17, 2015 9:47 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v3 0/5] Interrupt mode PMD > > v3 changes > - Add return value for interrupt enable/disable functions

[dpdk-dev] [PATCH v8 03/14] eal/pci, ethdev: Remove assumption that port will not be detached

2015-02-18 Thread Thomas Monjalon
2015-02-17 15:14, Tetsuya Mukawa: > On 2015/02/17 9:36, Thomas Monjalon wrote: > > 2015-02-16 13:14, Tetsuya Mukawa: > > Is uint8_t sill a good size for hotpluggable virtual device ids? > > I am not sure it's enough, but uint8_t is widely used in "rte_ethdev.c" > as port id. > If someone reports i

[dpdk-dev] [PATCH v6 00/16] lib/librte_pmd_fm10k : fm10k pmd driver

2015-02-18 Thread Thomas Monjalon
2015-02-17 22:18, Chen Jing D: > From: "Chen Jing D(Mark)" > > The patch set add poll mode driver for the host interface of Intel > Ethernet Switch FM1 Series of silicons, which integrate NIC and > switch functionalities. The patch set include below features: > > 1. Basic RX/TX functions for