[dpdk-dev] [PATCH] lpm: fix overflow issue

2015-02-22 Thread Igor Ryzhov
Hello again. Will anybody review this patch? This is really critical issue, because it can lead to memory corruption and break any program using LPM. CCing this to Bruce Richardson, because he is maintainer of LPM. Regards, Igor Ryzhov On Fri, Feb 20, 2015 at 4:16 PM, Igor Ryzhov wrote: > LPM

[dpdk-dev] [PATCH v3 0/5] Integrate flex filter in igb driver to new API

2015-02-22 Thread Thomas Monjalon
2015-02-21 01:53, Pablo de Lara: > The patch set uses new filter_ctrl API to replace old flex filter APIs. > It uses new functions and structure to replace old ones in igb driver, new > commands to replace old ones in testpmd, and removes the old APIs. > > v3 changes: > - fix testpmd documentati

[dpdk-dev] [PATCH v2 0/6] Integrate syn filter in igb/ixgbe driver to new API

2015-02-22 Thread Thomas Monjalon
> v2 changes: > - split one patch to patch series > - change the command's format in testpmd. > - return -ENOENT when deleting a disabled syn filter. > - add doc changes in testpmd_funcs.rst > - correct the errors reported by checkpatch.pl > > The patch set uses new filter_ctrl API to replace

[dpdk-dev] [PATCH v10 13/14] eal/pci: Add rte_eal_dev_attach/detach() functions

2015-02-22 Thread Tetsuya Mukawa
On 2015/02/21 21:49, Maxime Leroy wrote: > Hi Tetsuya, > > On Sat, Feb 21, 2015 at 4:49 AM, Tetsuya Mukawa wrote: >> On 2015/02/21 0:20, Maxime Leroy wrote: > [...] >>> Why you want to add devargs in the devargs_list, if there are no needs >>> to store this information ? >> In eal initialization c

[dpdk-dev] [PATCH v3 0/6] new ntuple filter replaces 2tuple and 5tuple filters

2015-02-22 Thread Thomas Monjalon
2015-02-20 17:29, De Lara Guarch, Pablo: > From: Wu, Jingjing > > > > v2 changes: > > - remove the code which is already applied in patch "Integrate ethertype > > filter in igb/ixgbe driver to new API". > > - modify commands' description in doc testpmd_funcs.rst. > > > > v3 change: > >

[dpdk-dev] Testpmd returns error.

2015-02-22 Thread Tetsuya Mukawa
Hi, In my environment, testpmd in latest master branch returns error like below. $ sudo ./tools/dpdk_nic_bind.py -b igb_uio :02:00.0 $ sudo ./x86_64-native-linuxapp-gcc/app/testpmd -c f -n 1 -- -i EAL: Detected lcore 0 as core 0 on socket 0 EAL: Detected lcore 1 as core 1 on socket 0 EAL: Det

[dpdk-dev] [PATCH] mk: add support for gdb debug info generation

2015-02-22 Thread Marc Sune
I don't like the proposed patch, but I am recovering this old thread because I agree on the problem statement. On 04/04/14 11:57, Ananyev, Konstantin wrote: > Hi Cyril, > We already do have 'EXTRA_CFLAGS' and 'EXTRA_LDFLAGS' that you can use to > enable debug, or any other compiler/linker option

[dpdk-dev] Testpmd returns error.

2015-02-22 Thread Thomas Monjalon
Hi Tetsuya, 2015-02-22 14:30, Tetsuya Mukawa: > Hi, > > In my environment, testpmd in latest master branch returns error like below. > > $ sudo ./tools/dpdk_nic_bind.py -b igb_uio :02:00.0 > $ sudo ./x86_64-native-linuxapp-gcc/app/testpmd -c f -n 1 -- -i > EAL: Detected lcore 0 as core 0 on

[dpdk-dev] Testpmd returns error.

2015-02-22 Thread David Marchand
Hello, On Sun, Feb 22, 2015 at 3:17 PM, Thomas Monjalon wrote: > Hi Tetsuya, > > > Someone, could you please check it? > > It is possible that this patchset was not correctly tested. > We might revert it or try to fix it. > I think the decision should be done by its authors (Danny, Bruce), > or

[dpdk-dev] [PATCH v2 00/11] qemu vhost-user support

2015-02-22 Thread Thomas Monjalon
2015-02-16 17:19, Tetsuya Mukawa: > On 2015/02/12 14:07, Huawei Xie wrote: > > vhost-user supports passing vring information to a seperate vhost enabled > > user space process, normally a user space vSwitch, through unix domain > > socket. > > > > In previous DPDK version, we implement a user spac

[dpdk-dev] [PATCH] lpm: fix overflow issue

2015-02-22 Thread Richardson, Bruce
Sorry I missed this Friday. I'll look at it shortly. On 21 Feb 2015, at 22:56, Igor Ryzhov mailto:iryzhov at nfware.com>> wrote: Hello again. Will anybody review this patch? This is really critical issue, because it can lead to memory corruption and break any program using LPM. CCing this t

[dpdk-dev] [PATCH] lpm: fix overflow issue

2015-02-22 Thread Igor Ryzhov
Great. The easiest way to reproduce the issue is to fill LPM table with rules using only one depth and try to add another one rule with same depth. Rule will be successfully added and memory will be corrupted. ???, 22 ??? 2015 ?. Richardson, Bruce ???: > Sorry I misse

[dpdk-dev] Testpmd returns error.

2015-02-22 Thread Richardson, Bruce
On 22 Feb 2015, at 16:19, David Marchand mailto:david.marchand at 6wind.com>> wrote: Hello, On Sun, Feb 22, 2015 at 3:17 PM, Thomas Monjalon mailto:thomas.monjalon at 6wind.com>> wrote: Hi Tetsuya, > Someone, could you please check it? It is possible that this patchset was not correctly tes

[dpdk-dev] [PATCH] lpm: fix overflow issue

2015-02-22 Thread Bruce Richardson
On Fri, Feb 20, 2015 at 04:16:46PM +0300, Igor Ryzhov wrote: > LPM table overflow may occur if table is full and added rule has the biggest > depth that already have some rules. > > Signed-off-by: Igor Ryzhov Acked-by: Bruce Richardson > --- > lib/librte_lpm/rte_lpm.c | 3 +++ > 1 file change

[dpdk-dev] Testpmd returns error.

2015-02-22 Thread Bruce Richardson
On Sun, Feb 22, 2015 at 06:51:58PM +, Richardson, Bruce wrote: > > > > > On 22 Feb 2015, at 16:19, David Marchand 6wind.com> wrote: > > Hello, > > On Sun, Feb 22, 2015 at 3:17 PM, Thomas Monjalon 6wind.com> wrote:

[dpdk-dev] Testpmd returns error.

2015-02-22 Thread Bruce Richardson
On Sun, Feb 22, 2015 at 02:30:02PM +0900, Tetsuya Mukawa wrote: > Hi, > > In my environment, testpmd in latest master branch returns error like below. > > $ sudo ./tools/dpdk_nic_bind.py -b igb_uio :02:00.0 > $ sudo ./x86_64-native-linuxapp-gcc/app/testpmd -c f -n 1 -- -i > EAL: Detected lcor

[dpdk-dev] [PATCH v2 0/7] unified flow types and RSS offload types

2015-02-22 Thread Thomas Monjalon
> > It unifies the flow types and RSS offload types for all PMDs. Previously > > flow > > types are defined specifically for i40e, and there has different RSS > > offloads > > tyeps for 1/10G and 40G seperately. This is not so convenient for > > application > > development, and not good for addi

[dpdk-dev] [PATCH 0/8] Improve build process

2015-02-22 Thread Neil Horman
On Fri, Feb 20, 2015 at 02:31:36PM +, Gonzalez Monroy, Sergio wrote: > On 13/02/2015 12:51, Neil Horman wrote: > >On Fri, Feb 13, 2015 at 11:08:02AM +, Gonzalez Monroy, Sergio wrote: > >>On 13/02/2015 10:14, Panu Matilainen wrote: > >>>On 02/12/2015 05:52 PM, Neil Horman wrote: > On Thu

[dpdk-dev] Appropriate DPDK data structures for TCP sockets

2015-02-22 Thread Stephen Hemminger
On Sat, 21 Feb 2015 16:38:45 -0800 Matthew Hall wrote: > So far I was using rte_hash, but it's single writer multi reader, which is > eventually going to need some more complicated locking and probably run kind > of slow. Also, I need some timer functions to delete dead sockets and so > forth,

[dpdk-dev] Appropriate DPDK data structures for TCP sockets

2015-02-22 Thread Matthew Hall
On Feb 22, 2015, at 4:02 PM, Stephen Hemminger wrote: > Use userspace RCU? or BSD RB_TREE Thanks Stephen, I think the RB_TREE stuff is single threaded mostly. But user-space RCU looks quite good indeed, I didn't know somebody ported it out of the kernel. I'll check it out. Matthew.