> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ouyang Changchun
> Sent: Friday, February 13, 2015 12:04 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] testpmd: HW vlan command
>
> This patch enables testpmd user can config port hw_vlan with more fi
> > Compilation fails in some distributions because of missing unistd.h
> > needed for pread/pwrite (seen with Suse):
> > lib/librte_eal/linuxapp/eal/eal_pci_uio.c:62:2:
> > error: implicit declaration of function ?pread?
> >
> > Fixes: 4a499c649590 ("eal/linux: enable uio_pci_gener
2015-02-02 13:18, Neil Horman:
> There was a request for an abi validation utiltyfor the ongoing ABI stability
> work. As it turns out there is a abi compliance checker in development that
> seems to be under active development and provides fairly detailed ABI
> compliance
> reports. Its not yet
2015-03-03 16:38, Bruce Richardson:
> The ENQUEUE_PTRS and DEQUEUE_PTRS macros defined in rte_ring.h are
> not meant to be global and are not prefixed with the RTE_ prefix.
> Therefore undef the macros at end of file to avoid pollution of the
> global namespace, in case ends apps end up wanting to
- Only x540 and 82599 devices support LRO.
- Add the appropriate HW configuration.
- Add RSC aware rx_pkt_burst() handlers:
- Implemented bulk allocation and non-bulk allocation versions.
- Add LRO-specific fields to rte_eth_rxmode, to rte_eth_dev_data
and to igb_
Enables LRO support in PMDs.
Signed-off-by: Vlad Zolotarov
---
config/common_linuxapp | 1 +
1 file changed, 1 insertion(+)
diff --git a/config/common_linuxapp b/config/common_linuxapp
index 97f1c9e..5b98595 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -137,6 +137,7 @@ CO
- ixgbe_rx_alloc_bufs():
- Reset the rte_mbuf fields only when requested.
- Take the RDT update out of the function.
- Add the stub when RTE_LIBRTE_IXGBE_RX_ALLOW_BULK_ALLOC is not defined.
- ixgbe_recv_scattered_pkts():
- Take the code that updates the fields of
According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should
be configured to the same value as HLREG0.RXCRCSTRP.
Clearing the RDRXCTL.RSCFRSTSIZE field for x540 is not required by the spec
but seems harmless.
Signed-off-by: Vlad Zolotarov
---
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 3
- Removed the not needed casting.
- Use the rte_le_to_cpu_xx()/rte_cpu_to_le_xx() when reading/setting HW
ring descriptor fields. There were a few places where fields were
accessed/written
directly, which would break on big endian platforms like Power PC.
- ixgbe_dev_rx_init():
This series adds the missing flow for enabling the LRO in the ethdev and
adds a support for this feature in the ixgbe PMD. There is a big hope that this
initiative is going to be picked up by some Intel developer that would add the
LRO support
to other Intel PMDs. ;)
The series starts with some c
On Tue, Mar 03, 2015 at 04:23:49PM +0100, Thomas Monjalon wrote:
> If verbose is off, auto-config-h.sh script should be quiet.
>
> Signed-off-by: Thomas Monjalon
> ---
> lib/librte_pmd_mlx4/Makefile | 10 +++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/lib/librte_p
On Tue, Mar 03, 2015 at 04:23:48PM +0100, Thomas Monjalon wrote:
> The mempool header forces error on -Wcast-qual and makes verbs.h failing.
> Let's include verbs before as a system header.
>
> Fixes: 7fae69eeff13 ("mlx4: new poll mode driver")
>
> Signed-off-by: Thomas Monjalon
> ---
> lib/lib
On Fri, 27 Feb 2015 11:38:25 +0100
David Marchand wrote:
> Ok, so after looking at this patchset, I would say this is the right
> direction, but still this is too limited.
> The ethdev part and the vfio eventfds part look acceptable to me.
> But thinking about it, I could just reuse a standard e
Since the following commit has already been merged into dpdk.org mainline,
commit: 42d2f78abcb77ecb769be4149df550308169ef0f
So update the prog guide for it.
Signed-off-by: Changchun Ouyang
---
.../prog_guide/i40e_ixgbe_igb_virt_func_drv.rst| 38 ++
1 file changed, 38 ins
The ENQUEUE_PTRS and DEQUEUE_PTRS macros defined in rte_ring.h are
not meant to be global and are not prefixed with the RTE_ prefix.
Therefore undef the macros at end of file to avoid pollution of the
global namespace, in case ends apps end up wanting to reuse those names.
Signed-off-by: Bruce Ric
On Tue, 3 Mar 2015 21:48:43 +0200
Vlad Zolotarov wrote:
> - Only x540 and 82599 devices support LRO.
> - Add the appropriate HW configuration.
> - Add RSC aware rx_pkt_burst() handlers:
>- Implemented bulk allocation and non-bulk allocation versions.
>- Add LRO-specif
On Tue, 3 Mar 2015 21:48:43 +0200
Vlad Zolotarov wrote:
> +
> + if (!bulk_alloc) {
> + __le64 dma =
> + rte_cpu_to_le_64(RTE_MBUF_DATA_DMA_ADDR_DEFAULT(nmb));
> + /*
> + * Update RX descriptor with the
On Tue, 3 Mar 2015 21:48:43 +0200
Vlad Zolotarov wrote:
> + next_desc:
> + /*
> + * The code in this whole file uses the volatile pointer to
> + * ensure the read ordering of the status and the rest of the
> + * descriptor fields (on the com
On Tue, 3 Mar 2015 21:48:43 +0200
Vlad Zolotarov wrote:
> + lro_bulk_alloc: 1, /**< RX LRO with bulk alloc is ON(1) /
> OFF(0) */
This is an internal decision and should not be exposed in the API.
We need less knobs not more.
From: Xuelin Shi
enforce rules for cpu and ixgbe exchanging data.
1. cpu use data owned by ixgbe must use rte_le_to_cpu_xx(...)
2. cpu fill data to ixgbe must use rte_cpu_to_le_xx(...)
Signed-off-by: Xuelin Shi
---
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 115 --
> -Original Message-
> From: Marc Sune [mailto:marc.sune at bisdn.de]
> Sent: Tuesday, March 03, 2015 2:39 PM
> To: Ananyev, Konstantin; Richardson, Bruce
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] mk: add support for gdb debug info generation
>
>
> On 03/03/15 14:31, Anany
The function print_client_stats was used in the example without being
clearly exported in the map file. So it breaks linking with shared library
when debug is enabled.
It's better to remove this function as it probably could be implemented
with statistics API.
Fixes: cc7e8ae84faa ("add example app
If verbose is off, auto-config-h.sh script should be quiet.
Signed-off-by: Thomas Monjalon
---
lib/librte_pmd_mlx4/Makefile | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/lib/librte_pmd_mlx4/Makefile b/lib/librte_pmd_mlx4/Makefile
index de50a5a..813 100644
---
The mempool header forces error on -Wcast-qual and makes verbs.h failing.
Let's include verbs before as a system header.
Fixes: 7fae69eeff13 ("mlx4: new poll mode driver")
Signed-off-by: Thomas Monjalon
---
lib/librte_pmd_mlx4/mlx4.c | 22 ++
1 file changed, 10 insertions(+)
With CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_INIT=y:
error: ?devname? undeclared (first use in this function)
Fixes: da978dfdc43b ("virtio: use port IO to get PCI resource")
Signed-off-by: Thomas Monjalon
---
lib/librte_pmd_virtio/virtio_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
The mempool header forces error on -Wcast-qual:
error: cast discards ?const? qualifier from pointer target type
Let's fix it by removing const qualifier of pci driver from commit
5e9f6d1340ff ("pci: reference driver structure for each device")
It's needed because the driver flags a
error: implicit declaration of function ?RTE_LOG?
Fixes: a6061d9e7075 ("fm10k: register PF driver")
Signed-off-by: Thomas Monjalon
---
lib/librte_pmd_fm10k/fm10k_logs.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_pmd_fm10k/fm10k_logs.h
b/lib/librte_pmd_fm10k/fm10k_logs.h
i
error: format ?%p? expects argument of type ?void *?,
but argument 5 has type ?const struct rte_mempool *? [-Werror=format=]
mp type is (const struct rte_mempool *) and must be casted into a simpler
type to be printed.
Signed-off-by: Thomas Monjalon
---
lib/librte_mempool/rte_mempool.h | 8
There are some compilation errors when debug options are enabled.
We should start thinking to test every patch with an all-yes configuration.
Unfortunately, we cannot force this kind of configuration because
some libraries depend on the availability of some libraries.
Thomas Monjalon (7):
mempoo
Hi Tetsuya,
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tetsuya Mukawa
> Sent: Wednesday, February 25, 2015 7:32 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v15] testpmd: Add port hotplug support
>
> The patch introduces following commands.
> -
remove the coma character by using ' character
Signed-off-by: Jingjing Wu
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index a99e14d..
On 03/03/15 14:31, Ananyev, Konstantin wrote:
>
>> -Original Message-
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson
>> Sent: Tuesday, March 03, 2015 1:03 PM
>> To: Marc Sune
>> Cc: dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] mk: add support for gdb debu
Thank you
-Original Message-
From: Bruce Richardson [mailto:bruce.richard...@intel.com]
Sent: 03 March 2015 13:45
To: Raz Amir
Cc: Thomas Monjalon; dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH] pci: save list of detached devices, and
re-probe during driver unload
On Tue, Mar 03, 2015 a
On 03/03/2015 02:19 PM, Marc Sune wrote:
>
> On 03/03/15 10:33, Bruce Richardson wrote:
>> On Mon, Mar 02, 2015 at 06:32:13PM +0100, Marc Sune wrote:
>>> On 22/02/15 12:51, Marc Sune wrote:
I don't like the proposed patch, but I am recovering this old thread
because I agree on the problem
> -Original Message-
> From: Qiu, Michael
> Sent: Tuesday, March 03, 2015 11:00 AM
> To: Wodkowski, PawelX; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] librte_eal/common: Fix cast from pointer to
> integer of different size
>
> On 3/3/2015 4:25 PM, Wodkowski, PawelX wrote:
> > On 2
2015-03-03 13:03, Bruce Richardson:
> On Tue, Mar 03, 2015 at 01:56:19PM +0100, Marc Sune wrote:
> > On 03/03/15 13:40, Panu Matilainen wrote:
> > >My 5c is that if anything, DPDK needs *less* places that muck around with
> > >compiler flags, not more. If you something like this for all the librari
On 03/03/15 14:03, Bruce Richardson wrote:
> On Tue, Mar 03, 2015 at 01:56:19PM +0100, Marc Sune wrote:
>> On 03/03/15 13:40, Panu Matilainen wrote:
>>> On 03/03/2015 02:19 PM, Marc Sune wrote:
On 03/03/15 10:33, Bruce Richardson wrote:
> On Mon, Mar 02, 2015 at 06:32:13PM +0100, Marc Sun
On 03/03/15 13:40, Panu Matilainen wrote:
> On 03/03/2015 02:19 PM, Marc Sune wrote:
>>
>> On 03/03/15 10:33, Bruce Richardson wrote:
>>> On Mon, Mar 02, 2015 at 06:32:13PM +0100, Marc Sune wrote:
On 22/02/15 12:51, Marc Sune wrote:
> I don't like the proposed patch, but I am recovering t
On Thu, Feb 26, 2015 at 06:33:20AM +, Raz Amir wrote:
> Added code that saves the pointers to the detached devices, during
> driver loading, and during driver unloading, go over the list,
> and re-attach them by calling device_probe_and_attach
> on each device.
>
> Signed-off-by: Raz Amir
Co
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson
> Sent: Tuesday, March 03, 2015 1:03 PM
> To: Marc Sune
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] mk: add support for gdb debug info generation
>
> On Tue, Mar 03, 2015 at 01:56:
Thanks.
What's next with the suggested parch?
On Mar 2, 2015, at 3:29 PM, Thomas Monjalon
wrote:
2015-03-02 13:58, Raz Amir:
> BTW, I don't see it in incoming patches page at
> http://dpdk.org/dev/patchwork/project/dpdk/list/?page=1
> Is it because I missed something in the code contribution in
On 03/03/15 10:33, Bruce Richardson wrote:
> On Mon, Mar 02, 2015 at 06:32:13PM +0100, Marc Sune wrote:
>> On 22/02/15 12:51, Marc Sune wrote:
>>> I don't like the proposed patch, but I am recovering this old thread
>>> because I agree on the problem statement.
>>>
>>> On 04/04/14 11:57, Ananyev,
On Tue, Mar 03, 2015 at 01:56:19PM +0100, Marc Sune wrote:
>
> On 03/03/15 13:40, Panu Matilainen wrote:
> >On 03/03/2015 02:19 PM, Marc Sune wrote:
> >>
> >>On 03/03/15 10:33, Bruce Richardson wrote:
> >>>On Mon, Mar 02, 2015 at 06:32:13PM +0100, Marc Sune wrote:
> On 22/02/15 12:51, Marc Sun
I do have Intel 8250 Gigabit Ethernet but run into error in testpmd with DPDK
1.8.0.
Is this a known issue or I might miss something
root at debian:/home/jkao/Media/dpdk-1.8.0# tools/dpdk_nic_bind.py --status
Network devices using DPDK-compatible driver
On Tue, Mar 03, 2015 at 01:30:29PM +0200, Raz Amir wrote:
> Thanks.
> What's next with the suggested parch?
>
Hi,
This patch needs to be reviewed and acked before it can be merged. I'll take a
look at it and test it today, I hope, if nobody else reviews and comments on it
before I get to it.
Re
On Thu, Feb 26, 2015 at 12:57:49PM +0800, Ouyang Changchun wrote:
First off, I think the title needs to be changed. How about something like:
"dpdk_nic_bind: don't exit if an unused module is missing"
> In virtio test, on guest
> 1. Bind virtio port to igb_uio driver;
> 2. Remove igb_uio module;
>
This patch fixes the segfault issue in the case vhost receives new
VHOST_SET_MEM_TABLE message without VHOST_VRING_GET_VRING_BASE(which we uses as
the stop message).
Signed-off-by: Huawei Xie
---
lib/librte_vhost/vhost_user/virtio-net-user.c | 4
1 file changed, 4 insertions(+)
diff --gi
Since codes for this new option(--vlan-strip) are already merged into mainline,
see: commit: e3d61d1609cb9b3ea851c7776bfbb60dcfe8844a.
So the doc need update for that.
Signed-off-by: Changchun Ouyang
---
doc/guides/sample_app_ug/vhost.rst | 8
1 file changed, 8 insertions(+)
diff --gi
/i686-native-linuxapp-gcc/include/rte_memcpy.h:592:23: error:
cast from pointer to integer of different size
[-Werror=pointer-to-int-cast]
dstofss = 16 - (int)((long long)(void *)dst & 0x0F) + 16;
Type 'long long' is 64-bit in i686 platform while 'void *'
is 32-bit.
Signed-off-by: Michael Qiu
On Tue, Mar 3, 2015 at 9:44 AM, Thomas Monjalon
wrote:
> Compilation fails in some distributions because of missing unistd.h
> needed for pread/pwrite (seen with Suse):
> lib/librte_eal/linuxapp/eal/eal_pci_uio.c:62:2:
> error: implicit declaration of function ?pread?
>
> Fixes: 4
On 3/3/2015 4:25 PM, Wodkowski, PawelX wrote:
> On 2015-03-03 03:20, Michael Qiu wrote:
>> /i686-native-linuxapp-gcc/include/rte_memcpy.h:592:23: error:
>> cast from pointer to integer of different size
>> [-Werror=pointer-to-int-cast]
>>
>>dstofss = 16 - (int)((long long)(void *)dst & 0x0F) +
Add some contents for vhost sample.
Signed-off-by: Changchun Ouyang
---
Change in v2:
-- Refine its format to fit well with other parts.
doc/guides/sample_app_ug/vhost.rst | 52 +-
1 file changed, 45 insertions(+), 7 deletions(-)
diff --git a/doc/guides/s
Compilation fails in some distributions because of missing unistd.h
needed for pread/pwrite (seen with Suse):
lib/librte_eal/linuxapp/eal/eal_pci_uio.c:62:2:
error: implicit declaration of function ?pread?
Fixes: 4a499c649590 ("eal/linux: enable uio_pci_generic support")
Signed-of
On Mon, Mar 02, 2015 at 06:32:13PM +0100, Marc Sune wrote:
>
> On 22/02/15 12:51, Marc Sune wrote:
> >I don't like the proposed patch, but I am recovering this old thread
> >because I agree on the problem statement.
> >
> >On 04/04/14 11:57, Ananyev, Konstantin wrote:
> >>Hi Cyril,
> >>We already
On 2015-03-03 03:20, Michael Qiu wrote:
> /i686-native-linuxapp-gcc/include/rte_memcpy.h:592:23: error:
> cast from pointer to integer of different size
> [-Werror=pointer-to-int-cast]
>
>dstofss = 16 - (int)((long long)(void *)dst & 0x0F) + 16;
>
> Type 'long long' is 64-bit in i686 platform w
From: Miroslaw Walukiewicz
The hash_key16_ext table allocates a cache entries to support
table overload cases.
The crash can occur when cache entry is free after use. The problem
is with computing the index of the free cache entry.
The patch fixes a problem.
Signed-off-by: Mirek Walukiewicz
-
On 3/2/2015 7:39 PM, Gonzalez Monroy, Sergio wrote:
> On 02/03/2015 07:27, Michael Qiu wrote:
>> /i686-native-linuxapp-gcc/include/rte_memcpy.h:592:23: error:
>> cast from pointer to integer of different size
>> [-Werror=pointer-to-int-cast]
>>
>>dstofss = 16 - (int)((long long)(void *)dst & 0x
57 matches
Mail list logo
