On 2015/03/09 11:23, Tetsuya Mukawa wrote:
> On 2015/03/06 19:32, Iremonger, Bernard wrote:
>
>> Hi Tetsuya,
>>
>> The above functions being added to /lib/librte_eal/bsdapp/eal/eal_pci.c are
>> very similar to the functions
>> in lib/librte_eal/linuxapp/eal/eal_pci.c the main difference seems to
This patch removes CONFIG_RTE_LIBRTE_EAL_HOTPLUG option, and enables it
as default in both Linux and BSD.
Also, to support port hotplug, rte_eal_pci_scan() and below missing
symbols should be exported to ethdev library.
- rte_eal_parse_devargs_str()
- rte_eal_pci_close_one()
-
The patch consolidates below functions, and implement these
in eal_common_pci_uio.c.
- pci_uio_map_secondary()
- pci_uio_map_resource()
- pci_uio_unmap()
- pci_uio_find_resource()
- pci_uio_unmap_resource()
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/Makefile
The patch consolidates below functions, and implemented in common
eal code.
- pci_map_resource()
- pci_unmap_resource()
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c| 24 -
lib/librte_eal/common/eal_common_pci.c | 43
The patch consolidates below functions, and implemented in common
eal code.
- pci_map_device()
- pci_unmap_device()
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 12 +++
lib/librte_eal/common/eal_common_pci.c | 57 +
This patch consolidates below functions, and implements these in common
eal code.
- rte_eal_pci_probe_one_driver()
- rte_eal_pci_close_one_driver()
Because pci_map_device() is only implemented in linuxapp, the patch
implements it in bsdapp too. This implemented function will be merged to
This patch consolidates below structures, and defines them in common code.
- struct pci_map
- strucy mapped_pci_resouces
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c| 24
lib/librte_eal/common/include/rte_pci.h| 28
This patch adds a new function called pci_uio_map_resource_by_index().
The function hides how to map uio resource in linuxapp and bsdapp.
With the function, pci_uio_map_resource() will be more abstracted.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 108
This patch adds a new function called pci_uio_alloc_uio_resource().
The function hides how to prepare uio resource in linuxapp and bsdapp.
With the function, pci_uio_map_resource() will be more abstracted.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 61
The function is implemented in both linuxapp and bsdapp, but interface
is different. The patch fixes the function of bsdapp to do same as
linuxapp. After applying it, file descriptor should be opened and
closed out of pci_map_resource().
Signed-off-by: Tetsuya Mukawa
---
This patch changes code that maps pci resources in bsdapp.
Linuxapp has almost same code. To consolidate both, fix implementation
of bsdapp to work same as linuxapp.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 24
1 file changed, 12
To merge pci code of linuxapp and bsdapp, this patch changes names
like below.
- uio_map to pci_map
- uio_resource to mapped_pci_resource
- uio_res_list to mapped_pci_res_list
Also, add 'path' variable to pci_map of bsdapp.
Signed-off-by: Tetsuya Mukawa
---
When pci_map_resource() is failed, mapaddr will be MAP_FAILED.
In this case, pci_map_addr should not be incremented.
The patch fixes it. Also, fix below.
- To shrink code, move close().
- Remove fail variable.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 10
When pci_uio_unmap_resource() is called, a file descriptor that is used
for uio configuration should be closed.
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
This patch fixes cording style of below files in linuxapp and bsdapp.
- eal_pci.c
- eal_pci_uio.c
Signed-off-by: Tetsuya Mukawa
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 67 ++-
lib/librte_eal/linuxapp/eal/eal_pci.c | 32 +--
This patch series adds port hotplug support to BSD.
Also, the patches consolidates pci uio functions of linuxapp and bsdapp.
Following patches cleanup pci uio code to consolidate later.
eal: Fix cording style of eal_pci.c and eal_pci_uio.c
eal: Close file descriptor of uio configuration
setup.sh uses /usr/bin/chmod, but depending on distribution, it is not always
there.
For example, Ubuntu has /bin/chmod. Fix this by removing the absolute path,
like it is
done e.g. with grep.
---
tools/setup.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
Due to API changes in functions ndo_dflt_bridge_getlink
and igb_ndo_fdb_add in kernel 3.19, DPDK would not build.
This patch solves the problem, by checking the kernel version
and adding the necessary new parameters
Signed-off-by: Pablo de Lara
---
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of John W. Linville
> Sent: Tuesday, March 10, 2015 6:36 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [RFC] af_packet: support port hotplug
>
> This patch adds finalization code to free resources allocated by
Added a parameter to the RX callback to pass in the number of
available RX packets in addition to the number of dequeued packets.
This provides the RX callback functions with additional information
that can be used to decide how packets from a burst are handled.
The TX callback doesn't require
This patch is a minor extension to the recent patchset for RX/TX callbacks
based on feedback from users implementing solutions based on it.
The patch adds a new parameter to the RX callback to pass in the number of
available RX packets in addition to the number of dequeued packets.
This provides
Given the circular dependencies between eal, malloc, mempool and ring
libraries and that eal does not have proper DT_NEEDED entries, we work
around it by forcing linking against mentioned libraries by preceding
them with --no-as-needed flag when building shared libraries.
This patch also does:
-
This patch mainly makes use of the LDLIBS variable when linking shared
libraries, setting proper DT_NEEDED entries.
This patch also fixes a few nits like syntax highlighting, the command
string (O_TO_S_CMD) used for linking shared libraries and the displayed
of dependencies when debugging is
When creating shared libraries, each library will be linked against
their dependant libraries, which are specified by new LDLIBS var.
Given the circular dependencies between eal, malloc, mempool and ring,
we work around it by not linking eal against its dependent libraries.
Therefore, eal will
Remove CONFIG_RTE_BUILD_COMBINE_LIBS and CONFIG_RTE_LIBNAME.
Signed-off-by: Sergio Gonzalez Monroy
---
config/common_bsdapp| 6 --
config/common_linuxapp | 6 --
config/defconfig_ppc_64-power8-linuxapp-gcc | 2 -
lib/Makefile
This patch series improves the DPDK build system mostly for shared
libraries (and a few nits for static libraries) with the following goals:
- Remove config option to build a combined library.
- For shared libraries, explicitly link against dependant
libraries (adding entries to DT_NEEDED).
On Thu, 12 Mar 2015 19:06:39 +
"Dumitrescu, Cristian" wrote:
>
>
> > -Original Message-
> > From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> > Sent: Tuesday, March 10, 2015 4:14 PM
> > To: Dumitrescu, Cristian
> > Cc: dev at dpdk.org; Stephen Hemminger; Stephen
On Thu, 12 Mar 2015 19:28:11 +
"Dumitrescu, Cristian" wrote:
> Hi Stephen,
>
> Thank you for adding flexibility over clearing the stats or not.
>
> I have one concern though: why change the stats read API to add a clear
> parameter rather than keep prototype for the stats functions
Hi Team ,
I am using DPDK-1.7.1 and trying to understand the logical flow of packet with
poll-mode driver .
How the packet is passing to user space --- > how the memory copy is doing from
pkt buffer to user space .
Code detail in DPDK code base .
Suggestions are welcome on this .
Regards
eth_driver already contains rte_pci_driver data structure.
Allocating rte_pci_driver without referencing it after bond
creation causes memory leakage.
---
lib/librte_pmd_bond/rte_eth_bond_api.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git
Thank you.
Can you tell when will the patch be pushed to the source code?
-Original Message-
From: Bruce Richardson [mailto:bruce.richard...@intel.com]
Sent: 11 March 2015 12:26
To: Raz Amir
Cc: dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4] pci: save list of detached devices, and
On Thu, Mar 12, 2015 at 09:38:46AM -0400, Neil Horman wrote:
> On Thu, Mar 12, 2015 at 10:43:24AM +, Qiu, Michael wrote:
> > On 3/11/2015 9:34 AM, Ouyang Changchun wrote:
> > > Fix possible memory leak issue: free kvlist before return;
> > > Fix possible resource lost issue: close qssockfd
Updated release notes release description notes:
- added new sample applications to list: Link Bonding,Skeleton, Callbacks,
Jobstats
- updated copyright date to 2015
- updated release number form 1.7.0 to 2.0
Signed-off-by: Siobhan Butler
---
doc/guides/rel_notes/rel_description.rst | 16
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Siobhan Butler
> Sent: Thursday, March 12, 2015 10:59 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: remove copyright from base of page
>
> Removing Intel copyright from base of page for each
Hi John.
On 2015/03/11 3:36, John W. Linville wrote:
> This patch adds finalization code to free resources allocated by
> the PMD. This is based on earlier patches for other PMDs by Tetsuya
> Mukawa , with corrections related to data->name.
>
> Signed-off-by: John W. Linville
> Cc: Tetsuya
Self-Nack - title mistake
> -Original Message-
> From: Butler, Siobhan A
> Sent: Thursday, March 12, 2015 11:36 AM
> To: dev at dpdk.org
> Cc: Butler, Siobhan A
> Subject: [PATCH] doc: update release notes description for new sample apps
> Updated release notes release description notes:
Signed-off-by: Siobhan Butler
---
doc/guides/rel_notes/rel_description.rst | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/doc/guides/rel_notes/rel_description.rst
b/doc/guides/rel_notes/rel_description.rst
index 49f32b9..2fb5379 100644
---
On 2015/03/12 11:05, Tetsuya Mukawa wrote:
> On 2015/03/12 7:25, Mcnamara, John wrote:
>> From: David Marchand [mailto:david.marchand at 6wind.com]
>> Sent: Wednesday, March 11, 2015 9:30 PM
>> To: Mcnamara, John
>> Cc: Tetsuya Mukawa; dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH 00/10] eal:
On Thu, Mar 12, 2015 at 10:57:18AM +, Qiu, Michael wrote:
> On 3/12/2015 6:50 PM, Bruce Richardson wrote:
> > On Thu, Mar 12, 2015 at 07:17:40PM +0900, Tetsuya Mukawa wrote:
> >> This patch fixes cording style of below files in linuxapp and bsdapp.
> >> - eal_pci.c
> >> - eal_pci_uio.c
> >>
On 2015/03/12 7:25, Mcnamara, John wrote:
>
> From: David Marchand [mailto:david.marchand at 6wind.com]
> Sent: Wednesday, March 11, 2015 9:30 PM
> To: Mcnamara, John
> Cc: Tetsuya Mukawa; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 00/10] eal: rte_tailq api cleanup
>
>>> I just tested the
On Thu, Mar 12, 2015 at 07:17:46PM +0900, Tetsuya Mukawa wrote:
> The function is implemented in both linuxapp and bsdapp, but interface
> is different. The patch fixes the function of bsdapp to do same as
> linuxapp. After applying it, file descriptor should be opened and
> closed out of
Removing Intel copyright from base of page for each document.
Signed-off-by: Siobhan Butler
---
doc/guides/conf.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/conf.py b/doc/guides/conf.py
index 385af03..fba34a6 100644
--- a/doc/guides/conf.py
+++
On 3/12/2015 6:50 PM, Bruce Richardson wrote:
> On Thu, Mar 12, 2015 at 07:17:40PM +0900, Tetsuya Mukawa wrote:
>> This patch fixes cording style of below files in linuxapp and bsdapp.
>> - eal_pci.c
>> - eal_pci_uio.c
>>
>> Signed-off-by: Tetsuya Mukawa
> Hi Tetsuya,
>
> While there is some
On Thu, Mar 12, 2015 at 07:17:40PM +0900, Tetsuya Mukawa wrote:
> This patch fixes cording style of below files in linuxapp and bsdapp.
> - eal_pci.c
> - eal_pci_uio.c
>
> Signed-off-by: Tetsuya Mukawa
Hi Tetsuya,
While there is some good cleanup here, I disagree with a number of the changes
On 3/11/2015 9:34 AM, Ouyang Changchun wrote:
> Fix possible memory leak issue: free kvlist before return;
> Fix possible resource lost issue: close qssockfd before return;
>
> Signed-off-by: Changchun Ouyang
> ---
> Change in v7:
> - Remove unnecessary '!= NULL' check before freeing it;
>
>
On Thu, Mar 12, 2015 at 10:43:24AM +, Qiu, Michael wrote:
> On 3/11/2015 9:34 AM, Ouyang Changchun wrote:
> > Fix possible memory leak issue: free kvlist before return;
> > Fix possible resource lost issue: close qssockfd before return;
> >
> > Signed-off-by: Changchun Ouyang
> > ---
> >
Hi David,
I have verified this patch working with ivshmem and vfio driver.
Testing environment:
Commit: 0a530f0d58b0304d3f7515bb14f81fd2b6e6931e
OS: Fedora20(3.11.10-301.fc20.x86_64)
GCC: gcc version 4.8.3 20140911
QEMU: 1.5.2 with additional ivshmem patch
2015-03-11 18:25, David Marchand:
> Commit a2348166ea18 ("tailq: move to dynamic tailq") introduced a bug in
> uio/vfio resources list init.
>
> These resources list were pointed at through a pointer initialised only once
> but
> too early in the eal init (before tailqs init).
>
> Fix this by
> -Original Message-
> From: Wodkowski, PawelX
> Sent: Wednesday, March 11, 2015 9:42 AM
> To: dev at dpdk.org
> Cc: Butler, Siobhan A
> Subject: [PATCH] doc: add l2fwd-jobstats user guide
>
> Signed-off-by: Pawel Wodkowski
> ---
> doc/guides/sample_app_ug/index.rst|
add vhost user documentation
Signed-off-by: Huawei Xie
---
doc/guides/prog_guide/vhost_lib.rst | 52 ++---
1 file changed, 42 insertions(+), 10 deletions(-)
diff --git a/doc/guides/prog_guide/vhost_lib.rst
b/doc/guides/prog_guide/vhost_lib.rst
index
add vhost user documentation
fix some minor issues
Signed-off-by: Huawei Xie
---
doc/guides/sample_app_ug/vhost.rst | 123 -
1 file changed, 94 insertions(+), 29 deletions(-)
diff --git a/doc/guides/sample_app_ug/vhost.rst
51 matches
Mail list logo
