[dpdk-dev] [PATCH] enic: disable debug traces

2015-04-07 Thread Thomas Monjalon
The function name is printed in each enic_ethdev function. Disable it by default with a new build option. Signed-off-by: Thomas Monjalon --- config/common_bsdapp | 1 + config/common_linuxapp| 1 + lib/librte_pmd_enic/enic_ethdev.c | 4 3 files changed, 6 insertions

[dpdk-dev] Crash related to virtio NICs in DPDK 2.0.0 on Freebsd 10.1 VM

2015-04-07 Thread Raz Amir
I am moving from dpdk 1.7.1 to 2.0.0 and I am experiencing a crash in any dpdk application, when rte_eal_init initializes the virtio NICs. I have Ubuntu 14.04.02, running a Freebsd 10.1 VM with 3 virtio NICs over qemu with kvm. I run testpmd (for example) inside the Freebsd VM and it crashes (mor

[dpdk-dev] [PATCH] doc: fix code-block syntax

2015-04-07 Thread Thomas Monjalon
Some blocks are not visible with some Sphinx versions because they are using the wrong keyword for code. Tested with Sphinx v1.1.3. Fixes: 1733be6d3147 ("doc: new eal multi-pthread feature") Fixes: ccefe752cab0 ("doc: add jobstats sample guide") Signed-off-by: Thomas Monjalon --- doc/guides/pr

[dpdk-dev] [RFC] Cuckoo hash for DPDK 2.1

2015-04-07 Thread yangguangje...@hotmail.com
hi Pablo, rte_hash uses Jenkins hash (http://burtleburtle.net/bob/hash/ ) in older dpdk veriosn,which is originated lookup2.c in 1996.Bob Jenkins updates his hash function named lookup3.c in 2006. The hash function is more faster than lookup2.c. why not continue to adopt the new hash fu

[dpdk-dev] [PATCH v3 1/5] mbuf: fix clone support when application uses private mbuf data

2015-04-07 Thread Olivier MATZ
Hi Konstantin, On 04/07/2015 02:40 PM, Ananyev, Konstantin wrote: > Hi Olivier, > >> -Original Message- >> From: Olivier MATZ [mailto:olivier.matz at 6wind.com] >> Sent: Monday, April 06, 2015 10:50 PM >> To: Ananyev, Konstantin; dev at dpdk.org >> Cc: zoltan.kiss at linaro.org; Richardson

[dpdk-dev] [snabb-devel] Re: memory barriers in virtq.lua?

2015-04-07 Thread Michael S. Tsirkin
On Tue, Apr 07, 2015 at 04:22:42PM +0200, Luke Gorrie wrote: > Hi Michael, > > I'm writing to follow up the previous discussion about memory barriers in > virtio-net device implementations, and Cc'ing the DPDK list because I believe > this is relevant to them too. > > First, thanks again for gett

[dpdk-dev] Running DPDK Binaries on a different Target

2015-04-07 Thread Venkat Thummala
Attaching the CPU Info. On 7 April 2015 at 17:28, Venkat Thummala wrote: > Hi, > > I have built a DPDK application [based on version 2.0] and run on the > native machine successfully. > > I have tried running the binary on a different machine, but it resulted in > a CRASH with the following back

[dpdk-dev] Running DPDK Binaries on a different Target

2015-04-07 Thread Venkat Thummala
Hi, I have built a DPDK application [based on version 2.0] and run on the native machine successfully. I have tried running the binary on a different machine, but it resulted in a CRASH with the following back trace. Please find the CPU info of the machines from the attachment. cpuinfo-1 - Nati

[dpdk-dev] [PATCH] eth_dev: make ether dev_ops const

2015-04-07 Thread Don Provan
-Original Message- >From: Stephen Hemminger [mailto:stephen at networkplumber.org] >Sent: Monday, April 06, 2015 11:05 AM >To: dev at dpdk.org >Subject: [dpdk-dev] [PATCH] eth_dev: make ether dev_ops const > >Ethernet device function tables should be immutable for correctness and >securit

[dpdk-dev] [PATCH v3 1/5] mbuf: fix clone support when application uses private mbuf data

2015-04-07 Thread Ananyev, Konstantin
Hi Olivier, > -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Tuesday, April 07, 2015 4:46 PM > To: Ananyev, Konstantin; dev at dpdk.org > Cc: zoltan.kiss at linaro.org; Richardson, Bruce > Subject: Re: [PATCH v3 1/5] mbuf: fix clone support when applicat

[dpdk-dev] [PATCH 4/5] bond mode 4: allow external state machine

2015-04-07 Thread Pawel Wodkowski
On 2015-04-07 16:18, Pawel Wodkowski wrote: > > Also, maybe a renaming "external_sm" to "state_machine_cb", set it to > against default one and using it without "if()" will simplify code. It > is no crucial but will eliminate couple of if's. In > rte_eth_bond_8023ad_ext_slowtx() you can compare it

[dpdk-dev] [snabb-devel] Re: memory barriers in virtq.lua?

2015-04-07 Thread Luke Gorrie
Hi Michael, I'm writing to follow up the previous discussion about memory barriers in virtio-net device implementations, and Cc'ing the DPDK list because I believe this is relevant to them too. First, thanks again for getting in touch and reviewing our code. I have now found a missed case where

[dpdk-dev] [PATCH 4/5] bond mode 4: allow external state machine

2015-04-07 Thread Pawel Wodkowski
On 2015-04-06 19:01, Eric Kinzie wrote: Interesting patch. I will closer look at this tomorrow. For now I have first comments: > +static void bond_mode_8023ad_ext_periodic_cb(void *arg); > + > #ifdef RTE_LIBRTE_BOND_DEBUG_8023AD > #define MODE4_DEBUG(fmt, ...) RTE_LOG(DEBUG, PMD, "%6u [Port

[dpdk-dev] [PATCH v2 6/6] eth: make dev_ops const

2015-04-07 Thread Stephen Hemminger
The ethernet device ops function table should be made const for safety and security. Signed-off-by: Stephen Hemminger --- v2 -- handle/fix virtual_pmd in earlier patches app/test/virtual_pmd.c | 30 +- lib/librte_ether/rte_ethdev.h|

[dpdk-dev] [PATCH v2 5/6] test: put dev_ops in private

2015-04-07 Thread Stephen Hemminger
The test PMD uses a special type of eth_dev_ops to test features. Rather allocating this separately, just put in the private data area. This allows for next change to make dev_ops const. Signed-off-by: Stephen Hemminger --- v2 -- split into separate patch and put dev_ops in private app/test/vir

[dpdk-dev] [PATCH v2 4/6] pmd: remove unnecessary if() before rte_free

2015-04-07 Thread Stephen Hemminger
Since rte_free accept NULL and does nothing, better to save space and remove these useless checks. Signed-off-by: Stephen Hemminger --- lib/librte_pmd_af_packet/rte_eth_af_packet.c | 14 ++ lib/librte_pmd_bond/rte_eth_bond_api.c | 13 + lib/librte_pmd_enic/enic_main

[dpdk-dev] [PATCH v2 3/6] examples: get rid of unneeded null checks before rte_free

2015-04-07 Thread Stephen Hemminger
rte_free handles getting passed a NULL pointer. Signed-off-by: Stephen Hemminger --- examples/vhost/main.c | 3 +-- examples/vhost_xen/vhost_monitor.c | 7 +++ examples/vm_power_manager/channel_manager.c | 6 ++ 3 files changed, 6 insertions(+), 10 deletion

[dpdk-dev] [PATCH v2 2/6] test: remove useless check of NULL before rte_free

2015-04-07 Thread Stephen Hemminger
rte_free like Glibc free allows rte_free(NULL) as null operation. Signed-off-by: Stephen Hemminger --- app/test/test_hash_perf.c | 2 +- app/test/virtual_pmd.c| 18 ++ 2 files changed, 7 insertions(+), 13 deletions(-) diff --git a/app/test/test_hash_perf.c b/app/test/test_h

[dpdk-dev] [PATCH v2 1/6] test: remove useless memset

2015-04-07 Thread Stephen Hemminger
Remove useless memset, since dev_private is created by rte_zmalloc it must already be zero. Signed-off-by: Stephen Hemminger --- app/test/virtual_pmd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c index f163562..39ecf80 100644 --- a/app/tes

[dpdk-dev] [PATCH 4/5] bond mode 4: allow external state machine

2015-04-07 Thread Eric Kinzie
On Tue Apr 07 16:18:08 +0200 2015, Pawel Wodkowski wrote: > On 2015-04-06 19:01, Eric Kinzie wrote: > > Interesting patch. I will closer look at this tomorrow. > > For now I have first comments: > > >+static void bond_mode_8023ad_ext_periodic_cb(void *arg); > >+ > > #ifdef RTE_LIBRTE_BOND_DEBUG

[dpdk-dev] [PATCH v3 1/5] mbuf: fix clone support when application uses private mbuf data

2015-04-07 Thread Ananyev, Konstantin
Hi Olivier, > -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Monday, April 06, 2015 10:50 PM > To: Ananyev, Konstantin; dev at dpdk.org > Cc: zoltan.kiss at linaro.org; Richardson, Bruce > Subject: Re: [PATCH v3 1/5] mbuf: fix clone support when applicat

[dpdk-dev] [PATCH] eth_dev: make ether dev_ops const

2015-04-07 Thread Stephen Hemminger
On Tue, Apr 7, 2015 at 10:21 AM, Don Provan wrote: > -Original Message- > >From: Stephen Hemminger [mailto:stephen at networkplumber.org] > >Sent: Monday, April 06, 2015 11:05 AM > >To: dev at dpdk.org > >Subject: [dpdk-dev] [PATCH] eth_dev: make ether dev_ops const > > > >Ethernet device

[dpdk-dev] Running DPDK Binaries on a different Target

2015-04-07 Thread Neil Horman
On Tue, Apr 07, 2015 at 05:30:15PM +0530, Venkat Thummala wrote: > Attaching the CPU Info. > > On 7 April 2015 at 17:28, Venkat Thummala > wrote: > > > Hi, > > > > I have built a DPDK application [based on version 2.0] and run on the > > native machine successfully. > > > > I have tried running

[dpdk-dev] CROSS_COMPILATION with custom toolchain

2015-04-07 Thread Shyam Sundar Govindaraj
Hi I am trying to build DPDK-2.0 with custom toolchain (binutils 2.24 , gcc 4.8.2 , glibc 2.19, linux-3.13-header). With CROSS variable properly set , even though DPDK is picking the right gcc from toolchain ,it ends up with below error since the libraries are taken from the build system and

[dpdk-dev] [RFC PATCHv2 5/8] add OSv support

2015-04-07 Thread Takuya ASADA
On Tue, Mar 24, 2015 at 10:52 PM, Neil Horman wrote: > On Sat, Mar 21, 2015 at 12:23:02PM +0900, Takuya ASADA wrote: > > Adding OSv support. > > Based on Linux/FreeBSD EAL, but calling OSv kernel APIs to access > devices, allocate contiguous memory, etc. > > > > Signed-off-by: Takuya ASADA > > -

[dpdk-dev] [RFC PATCHv3 7/7] doc: Add Getting Started Guide for OSv

2015-04-07 Thread Takuya ASADA
Described how to build DPDK for OSv, using "Capstan". Signed-off-by: Takuya ASADA --- doc/guides/index.rst | 1 + doc/guides/osv_gsg/build_dpdk.rst | 282 ++ doc/guides/osv_gsg/build_sample_apps.rst | 123 +++ doc/guides

[dpdk-dev] [RFC PATCHv3 6/7] app/test: support OSv

2015-04-07 Thread Takuya ASADA
Add support OSv EAL. Signed-off-by: Takuya ASADA --- app/test/test_eal_flags.c | 34 +- app/test/test_timer_perf.c | 2 +- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c index 0352f87..40a5c

[dpdk-dev] [RFC PATCHv3 5/7] add OSv support

2015-04-07 Thread Takuya ASADA
Adding OSv support. Based on Linux/FreeBSD EAL, but calling OSv kernel APIs to access devices, allocate contiguous memory, etc. Signed-off-by: Takuya ASADA --- config/{common_linuxapp => common_osvapp} | 29 +- ...xapp-gcc => defconfig_x86_64-native-osvapp-gcc} | 2 +- lib/librte_ea

[dpdk-dev] [RFC PATCHv3 4/7] eal: Add extern C on eal_private.h

2015-04-07 Thread Takuya ASADA
This is required to link with OSv EAL. Signed-off-by: Takuya ASADA --- lib/librte_eal/common/eal_private.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h index 4acf5a0..80b3d44 100644 --- a/lib/librte_eal/com

[dpdk-dev] [RFC PATCHv3 3/7] eal: Add extern C on eal_thread.h

2015-04-07 Thread Takuya ASADA
This is required to link with OSv EAL. Signed-off-by: Takuya ASADA --- lib/librte_eal/common/eal_thread.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/librte_eal/common/eal_thread.h b/lib/librte_eal/common/eal_thread.h index e4e76b9..794137f 100644 --- a/lib/librte_eal/common

[dpdk-dev] [RFC PATCHv3 2/7] eal: Add extern C on eal_hugepages.h

2015-04-07 Thread Takuya ASADA
This is required to link with OSv EAL. Signed-off-by: Takuya ASADA --- lib/librte_eal/common/eal_hugepages.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/librte_eal/common/eal_hugepages.h b/lib/librte_eal/common/eal_hugepages.h index 38edac0..b722aee 100644 --- a/lib/librte_e

[dpdk-dev] [RFC PATCHv3 1/7] mk: support compiling C++ code

2015-04-07 Thread Takuya ASADA
Since OSv is written in C++, we need to write OSv EAL in C++. To do so, we need to compile .cc files by $(CXX). This patch does not contain diff for clang and icc, but OSv EAL does not supported these toolchain, this is enough for now. Signed-off-by: Takuya ASADA --- mk/internal/rte.compile-pr

[dpdk-dev] [RFC PATCHv3 0/7] add OSv support

2015-04-07 Thread Takuya ASADA
This is 3rd version of OSv support patchset. Changelist: - sync with latest master - updated Capstan build script for OSv v0.19 - rte_eal_version.map fix - CONFIG_RTE_BUILD_SHARED_LIB=y and CONFIG_RTE_BUILD_COMBINE_LIBS=y by default - Check OSv NIC driver is loaded for each device, attach PMD