Add support copying scattered mbuf to vring which is done by dev_scatter_rx,
and check the 'next' pointer in mbuf on the fly to select suitable function to
rx packets.
Signed-off-by: Changchun Ouyang
---
lib/librte_vhost/vhost_rxtx.c | 116 +-
1 file chan
Remove these unnecessary vring descriptor length updating, vhost should not
change them.
virtio in front end should assign value to desc.len for both rx and tx.
Signed-off-by: Changchun Ouyang
---
lib/librte_vhost/vhost_rxtx.c | 18 +-
1 file changed, 1 insertion(+), 17 deletion
Extract codes into 2 common functions:
update_secure_len which is used to accumulate the buffer len in the vring
descriptors.
and fill_buf_vec which is used to fill struct buf_vec.
Signed-off-by: Changchun Ouyang
---
lib/librte_vhost/vhost_rxtx.c | 79 +--
Remove unnecessary new line.
Signed-off-by: Changchun Ouyang
---
lib/librte_vhost/vhost_rxtx.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/lib/librte_vhost/vhost_rxtx.c b/lib/librte_vhost/vhost_rxtx.c
index 06ae2df..a15578b 100644
--- a/lib/librte_vhost/vhost_rxt
Vring enqueue need consider the 2 cases:
1. Vring descriptors chained together, the first one is for virtio header, the
rest are for real
data, virtio driver in Linux usually use this scheme;
2. Only one descriptor, virtio header and real data share one single
descriptor, virtio-net pmd use
Fix enqueue/dequeue can't handle chained vring descriptors;
Remove unnecessary vring descriptor length updating;
Add support copying scattered mbuf to vring;
Changchun Ouyang (5):
lib_vhost: Fix enqueue/dequeue can't handle chained vring descriptors
lib_vhost: Refine code style
lib_vhost: Ex
My first preference would be to enable stats always. However, if the
majority feels that it should be optional,
your preference of 3, 2, 1 seems fine to me. I hope the same decision will
apply to port/table/other stats.
Raja
On 5/28/15, 12:26 PM, "Dumitrescu, Cristian"
wrote:
>Hi Raja,
>
>Thank
> -Original Message-
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Tuesday, May 26, 2015 10:58 PM
> To: Dumitrescu, Cristian
> Cc: Gajdzica, MaciejX T; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 01/10] table: added structure for storing
> table stats
>
Hi Raja,
Thanks for your input.
I think we have the following options identified so far for stats collection
configuration:
1. Stats configuration through the RTE_LOG_LEVEL
2. Single configuration flag global for all DPDK libraries
3. Single configuration flag per DPDK library
It would be good
On 28/05/15 18:06, Matt Laswell wrote:
> Hey Kyle,
>
> That's one way you can handle it, though I suspect you'll end up with some
> complexity elsewhere in your code to deal with remembering whether you
> should look at the original data or the copied and modified data. Another
> way is just to
>
>On 21/05/2015 17:59, Harish Patil wrote:
>> Hello dpdk-dev,
>>
>> I understand that the reserved memzones cannot be freed, as mentioned in
>> the DPDK specs. But I would like to know why? Is there any limitations?
>There should be a few threads in the mailing list related to this topic.
>Last th
Thx!
We will check it in our code
Nissim
-Original Message-
From: Zhang, Helin [mailto:helin.zh...@intel.com]
Sent: Wednesday, May 27, 2015 6:54 AM
To: Nissim Nisimov
Cc: 'dev at dpdk.org'
Subject: RE: Intel fortville not working with multi-segment
Hi Nissim
Sorry for late reply!
Toda
Add support to enable and disable reception of all multicast packets by the VF
using standard API
rte_eth_allmulticast_enable()/rte_eth_allmulticast_disable().
Signed-off-by: Yury Kylulin
---
drivers/net/e1000/igb_ethdev.c | 20
1 file changed, 20 insertions(+)
diff --gi
Hello,
Is there a function in DPDK to completely clone a pkt_mbuf including the
segments?
I am trying to build a packet mirroring application which sends packet out
through two separate interfaces, but the packet payload needs to be altered
before send.
Thanks,
Padam
Set the IP source and destination addresses in the IP header of the
ICMP reply as follows:
- Use the request IP source address as the reply IP destination address
- If the request IP destination address is a multicast IP address
- choose a reply IP source address different from the reques
Support the function "set_mc_addr_list" in the "ixgbe" and in the
"ixgbe-vf" Poll Mode Drivers.
Signed-off-by: Ivan Boule
---
drivers/net/ixgbe/ixgbe_ethdev.c | 32
1 file changed, 32 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ix
Support the PMD function "set_mc_addr_list" in the "igb", "igb-vf",
and "em" Poll Mode Drivers.
Signed-off-by: Ivan Boule
---
drivers/net/e1000/em_ethdev.c | 17 +
drivers/net/e1000/igb_ethdev.c | 18 ++
2 files changed, 35 insertions(+)
diff --git a/drivers
Add the new interactive command:
mcast_addr add|remove X
to add/remove the multicast MAC address to/from the set of
multicast addresses filtered by port .
Command used to test the function "rte_eth_dev_set_mc_addr_list"
that has been added to the API of PMDs.
Signed-off-by: Ivan Boule
---
With the current PMD API, the receipt of multicast packets on a given
port can only be enabled by invoking the "rte_eth_allmulticast_enable"
function.
This method may not work on Virtual Functions in SR-IOV architectures
when the host PF driver does not allow such operation on VFs.
In such cases, j
Introduce PMD API to set the list of multicast MAC addresses filtered
by a port.
Implemented in the following PMDs: igb, igbvf, em, ixgbe, and ixgbevf.
Implementation for physical PMDs i40e, i40evf, enic, and fm10k left
to their respective maintainers.
Ivan Boule (5):
ethdev: add multicast addre
2015-05-28 10:39, Thomas F Herbert:
> On 5/28/15 5:48 AM, Thomas Monjalon wrote:
> > 2015-05-27 16:48, Thomas F Herbert:
> >> This is a proposal to create a patch-test dpdk tree. I welcome feedback
> >> from the dpdk community on this proposal.
> >>
> >> This tree will consist of pre-integrated pat
Signed-off-by: Wei li
---
lib/librte_vhost/vhost_rxtx.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/lib/librte_vhost/vhost_rxtx.c b/lib/librte_vhost/vhost_rxtx.c
index 4809d32..2d3ea92 100644
--- a/lib/librte_vhost/vhost_rxtx.c
+++ b/lib/librte_vhost/vho
Pls see the patch: "Fix vhost enqueue/dequeue issue" for more fixing on the
vhost enqueue/dequeue.
We don't need this duplicated fix and it only fixes partial issue.
Thanks
Changchun
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen
> Hemminger
> Sent
On Thu, 28 May 2015 19:32:32 +
"Dumitrescu, Cristian" wrote:
> This is just adding a new field at the end of an API data structure. Based
> on input from multiple people and after reviewing the rules listed on
> http://dpdk.org/doc/guides/rel_notes/abi.html , I think this is an acceptable
On Tue, 5 May 2015 13:39:45 +0800
Cunming Liang wrote:
> + pci_dev->intr_handle.intr_vec =
> + rte_zmalloc("intr_vec",
> + dev_info.max_rx_queues * sizeof(int), 0);
> +
This and other drivers should be using rte_zmalloc_socket
On 2015-05-28 12:48, Wodkowski, PawelX wrote:
>>> Please only check if UTS_RELEASE is available on all Ubuntu versions DPDK
>> support.
>>
>> From some digging, it appears it entered the kernel tree in 2006 and
>> moved to include/generated/ in 2009 so I guess that should be fine for
>> DPDK builds
I have sent out another patch which has already included such fix,
That patch also fix other issue in rx path, and it is in reworking,
I will send out the v2 version soon.
Accordingly, this patch is a duplicated one.
Thanks
Changchun
> -Original Message-
> From: dev [mailto:dev-bounces at
This patch depends on the Port Hotplug Framework.
It implements the rte_dev_uninit_t() function for the link bonding pmd.
Changes in V2:
Rebased to use drivers/net/bonding dirctory
Free rx and tx queues following comments from Declan
Signed-off-by: Bernard Iremonger
---
drivers/net/bonding/rte_
On 5/28/15, 1:54 AM, "Simon K?gstr?m"
wrote:
>I spot a can of worms to be opened here :-)
>
>On 2015-05-27 22:48, Thomas F Herbert wrote:
>> Work Flow and Process:
>>
>> All patches will be taken from from public submissions to dpdk-dev.org
>> scraped from dpdk patchwork. Patches will be appli
On 2015-05-28 12:05, Wodkowski, PawelX wrote:
>>>
>>> -UBUNTU_KERNEL_CODE := $(shell cut -d' ' -f2 /proc/version_signature | \
>>> -cut -d'~' -f1 | cut -d- -f1,2 | tr .- $(comma))
>>> +UBUNTU_KERNEL_CODE := $(shell echo `grep UTS_RELEASE
>>> $(RTE_KERNELDIR)/include/generate
The requirements for rte_eth_tx_burst(), which calls a driver specific
function, in case of ixgbe, these two:
"It is the responsibility of the rte_eth_tx_burst() function to
transparently free the memory buffers of packets previously sent. This
feature is driven by the *tx_free_thresh* value su
2015-05-27 16:48, Thomas F Herbert:
> This is a proposal to create a patch-test dpdk tree. I welcome feedback
> from the dpdk community on this proposal.
>
> This tree will consist of pre-integrated patches submitted to dpdk-dev
> mailing list. The purpose of this tree is to help reduce the effo
I'm fairly new to dpdk, so I may be completely out to lunch on this, but
here's an idea to possibly improve performance compared to a straight copy
of the entire packet. If this idea makes sense, perhaps it could be added
to the mbuf library as an extension of the clone functionality?
If you are o
> -Original Message-
> From: Buriez, Patrice
> Sent: Thursday, May 28, 2015 1:07 PM
> To: Wodkowski, PawelX; Simon K?gstr?m; Zhang, Helin; Alexander Guy; Julien
> Cretin
> Cc: dev at dpdk.org
> Subject: RE: [PATCH] kni: Use utsrelease.h to determine Ubuntu kernel version
>
> Hi all,
> Pl
Prevent double initialization of the KNI subsytem.
Signed-off-by: Marc Sune
---
lib/librte_kni/rte_kni.c | 4
1 file changed, 4 insertions(+)
diff --git a/lib/librte_kni/rte_kni.c b/lib/librte_kni/rte_kni.c
index c5a0089..df0449f 100644
--- a/lib/librte_kni/rte_kni.c
+++ b/lib/librte_kni/r
Stephen, Helin, perhaps you have some comment about this patch?
// Simon
On 2015-05-07 15:17, Simon Kagstrom wrote:
> This is needed to add / remove interfaces in multicast groups via the
> ip tool.
>
> The callback does nothing - the same as the kernel tun.c.
>
> Signed-off-by: Simon Kagstrom
Hey Kyle,
That's one way you can handle it, though I suspect you'll end up with some
complexity elsewhere in your code to deal with remembering whether you
should look at the original data or the copied and modified data. Another
way is just to make a copy of the original mbuf, but have your copy
Hi all,
Please forgive top reply and bottom disclaimer.
Not sure anyway that this email will reach the mailing list, since I did not
subscribe to it.
I am worried about the removal of: cut -d'~' -f1
It was introduced by Pawel in commit 35170c52d0ae33dc30e69bcf681e5a17168bf11e
http://dpdk.org/brow
On 5/28/15 10:44 AM, Thomas Monjalon wrote:
> 2015-05-28 10:39, Thomas F Herbert:
>> On 5/28/15 5:48 AM, Thomas Monjalon wrote:
>>> 2015-05-27 16:48, Thomas F Herbert:
This is a proposal to create a patch-test dpdk tree. I welcome feedback
from the dpdk community on this proposal.
On 25/05/15 14:23, Bruce Richardson wrote:
> The file rte_kni.h depends upon a number of other headers, some of which
> are missing from the #include lines. The following #includes are added:
> * rte_memory.h - for the definition of phys_addr_t
> * rte_mempool.h - for the definition of mempoo
On 25/05/15 14:23, Bruce Richardson wrote:
> rte_pci.h depends upon stdio.h for the definition of the FILE type. Add
> in #include to the file to satisfy this dependency in cases
> where the including C file does not already include stdio.
>
> Signed-off-by: Bruce Richardson
> ---
> lib/librt
NAK. This causes more (unsuccessful) cleanup attempts on the descriptor ring.
What is motivating this change?
Regards,
Venky
> On May 28, 2015, at 1:42 AM, Zoltan Kiss wrote:
>
> This check doesn't do what's required by rte_eth_tx_burst:
> "When the number of previously sent packets reached
> -Original Message-
> From: Simon K?gstr?m [mailto:simon.kagstrom at netinsight.net]
> Sent: Thursday, May 28, 2015 12:37 PM
> To: Wodkowski, PawelX; Zhang, Helin; Alexander Guy; Julien Cretin; Buriez,
> Patrice
> Cc: dev at dpdk.org
> Subject: Re: [PATCH] kni: Use utsrelease.h to determi
On 28/05/2015 09:15, Simon K?gstr?m wrote:
> Thanks for the review, Sergio!
>
> On 2015-05-28 09:49, Gonzalez Monroy, Sergio wrote:
>>> @@ -325,6 +327,12 @@ rte_reorder_insert(struct rte_reorder_buffer *b,
>>> struct rte_mbuf *mbuf)
>>>uint32_t offset, position;
>>>struct cir_buffer
On 5/27/15 5:22 PM, Vincent JARDIN wrote:
> On 27/05/2015 22:48, Thomas F Herbert wrote:
>> Work Flow and Process:
>>
>> All patches will be taken from from public submissions to dpdk-dev.org
>> scraped from dpdk patchwork. Patches will be applied to the patch-test
>> tree and tested against HEAD
Thanks for the review, Sergio!
On 2015-05-28 09:49, Gonzalez Monroy, Sergio wrote:
>> @@ -325,6 +327,12 @@ rte_reorder_insert(struct rte_reorder_buffer *b,
>> struct rte_mbuf *mbuf)
>> uint32_t offset, position;
>> struct cir_buffer *order_buf = &b->order_buf;
>> +if (!b->is_init
Since Padam is going to be altering payload, he likely cannot use that API.
The rte_pktmbuf_clone() API doesn't make a copy of the payload. Instead,
it gives you a second mbuf whose payload pointer points back to the
contents of the first (and also increments the reference counter on the
first so
> >
> > -ifeq ($(shell test -f /proc/version_signature && lsb_release -si
> > 2>/dev/null),Ubuntu)
> > +ifeq ($(shell lsb_release -si 2>/dev/null),Ubuntu)
> > MODULE_CFLAGS += -DUBUNTU_RELEASE_CODE=$(shell lsb_release -sr | tr -
> d .)
> > -UBUNTU_KERNEL_CODE := $(shell cut -d' ' -f2 /proc/version
When we get the address of vring descriptor table in VHOST_SET_VRING_ADDR
message,
will try to reallocate virtio_net device and virtqueue to the same numa node.
Signed-off-by: Huawei Xie
---
config/common_linuxapp| 1 +
lib/librte_vhost/Makefile | 4 ++
lib/librte_vhost/virtio-net
use rte_malloc/free for virtio_net and virt queue allocation/free
Signed-off-by: Huawei Xie
---
lib/librte_vhost/virtio-net.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c
index 4672e67..19b7
The virtio_net device and vhost virt queue should be allocated on the same numa
node as vring descriptors.
When we firstly allocate the virtio_net device and vhost virt queue, we don't
know the numa node of vring descriptors.
When we receive the VHOST_SET_VRING_ADDR message, we get the numa node
Hi Eric,
> -Original Message-
> From: Eric Kinzie [mailto:ekinzie at brocade.com]
> Sent: Wednesday, May 27, 2015 7:20 PM
> To: Ananyev, Konstantin
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] ixgbe: fall back to non-vector rx
>
> On Wed May 27 10:20:39 + 2015, Ananyev, Kon
The default value of RTE_MAX_QUEUES_PER_PORT is 256, which is too small for
some configurations for i40e. There will return an error when configured queue
number is larger than 256 in
rte_eth_dev_configure().
For example, in vHost sample, PF queue number: 64, configured vmdq pool number:
63,
On Thu, 28 May 2015 17:05:19 +0200
Ivan Boule wrote:
> + if (port_id >= nb_ports) {
> + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id);
> + return -ENODEV;
> + }
> +
Use rte_eth_dev_is_valid_port() function instead.
On Thu, 28 May 2015 17:05:18 +0200
Ivan Boule wrote:
> Introduce PMD API to set the list of multicast MAC addresses filtered
> by a port.
> Implemented in the following PMDs: igb, igbvf, em, ixgbe, and ixgbevf.
> Implementation for physical PMDs i40e, i40evf, enic, and fm10k left
> to their respe
I spot a can of worms to be opened here :-)
On 2015-05-27 22:48, Thomas F Herbert wrote:
> Work Flow and Process:
>
> All patches will be taken from from public submissions to dpdk-dev.org
> scraped from dpdk patchwork. Patches will be applied to the patch-test
> tree and tested against HEAD as t
Sorry for the delay :)
On 20/05/2015 12:02, Simon Kagstrom wrote:
> We use sequence numbers from a generator which has potentially started
> long before the receiver. Therefore, the first number will typically
> be > 0. The rte_reorder code will not work in this case, since the
> packet is seen as
On Thu, 7 May 2015 15:17:54 +0200
Simon Kagstrom wrote:
> This is needed to add / remove interfaces in multicast groups via the
> ip tool.
>
> The callback does nothing - the same as the kernel tun.c.
>
> Signed-off-by: Simon Kagstrom
Yes, the dummy callback is needed, otherwise SIOCADDMULTI
On Thu, 28 May 2015 17:15:42 +0530
Padam Jeet Singh wrote:
> Hello,
>
> Is there a function in DPDK to completely clone a pkt_mbuf including the
> segments?
>
> I am trying to build a packet mirroring application which sends packet out
> through two separate interfaces, but the packet payloa
On Thu, 28 May 2015 16:19:44 +0800
Wei li wrote:
> + if (desc->flags & VRING_DESC_F_NEXT)
> + {
> + /* Discard first buffer as it is the virtio header */
> + desc = &vq->desc[desc->next];
> + vb_offset = 0;
> +
Hi guys
Could you help to review the code changes where you modified before?
Regards,
Helin
> -Original Message-
> From: Simon Kagstrom [mailto:simon.kagstrom at netinsight.net]
> Sent: Wednesday, May 27, 2015 7:45 PM
> To: dev at dpdk.org; Zhang, Helin
> Subject: [PATCH] kni: Use utsrel
61 matches
Mail list logo
