[dpdk-dev] [PATCH v7 4/8] vhost: rxtx: use queue id instead of constant ring index

2015-10-21 Thread Yuanhan Liu
On Wed, Oct 21, 2015 at 05:26:18PM +0300, Michael S. Tsirkin wrote: > On Wed, Oct 21, 2015 at 08:48:15PM +0800, Yuanhan Liu wrote: > > > Please note that for virtio devices, guest is supposed to > > > control the placement of incoming packets in RX queues. > > > > I may not follow you. > > > > En

[dpdk-dev] When I run test-pmd, most of received packets(loop-backed packet) have RX-error.

2015-10-21 Thread 최익성
Dear Kyle Larose and Sy Jong Choi. Thank you very much for your precious advices. I found the ierror counting function. It is ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) in ~/dpdk/lib/librte_pmd_ixgbe/ixgbe_ethdev.c. The rx-errors are due to IXGBE_MPC errors at r

[dpdk-dev] [PATCH v6 10/13] ixgbe: support VMDq RSS in non-SRIOV environment

2015-10-21 Thread Yuanhan Liu
> > > > Hi, > > > > Thanks for the review. However, as you might have seen, I dropped this > > patch in the lastest version. This patch is for using the NIC VMDq > > feature to link with VM multiple queue to demonstrate the multiple > > queue feature. However, this introduces too much limitation.

[dpdk-dev] [PATCH] Add error message when trying to use make option T= during build/clean

2015-10-21 Thread Olivier MATZ
Hi Francesco, On 10/14/2015 10:02 AM, Francesco wrote: > Hi Olivier, > thanks for reviewing the patch. However for me it is logical that T= > option is used for "config" target and then for building/cleaning only > O= is used. However it is not logical for me that install target > requires T= opti

[dpdk-dev] dpdk proposal installation process

2015-10-21 Thread Olivier MATZ
Hi Mario, On 10/20/2015 11:17 AM, Bruce Richardson wrote: > On Tue, Oct 20, 2015 at 12:21:00AM +, Arevalo, Mario Alfredo C wrote: >> Hi folks, >> >> Good day, this is a proposal in order to improve the dpdk install >> process, >> I would like to know your point of view about the next po

[dpdk-dev] [PATCH v6 10/13] ixgbe: support VMDq RSS in non-SRIOV environment

2015-10-21 Thread Yuanhan Liu
> > static int > > +ixgbe_config_vmdq_rss(struct rte_eth_dev *dev) > > +{ > > + struct ixgbe_hw *hw; > > + uint32_t mrqc; > > + > > + ixgbe_rss_configure(dev); > > + > > + hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); > > + > > + /* MRQC: enable VMDQ RSS */ > > + mrqc = IXGBE_R

[dpdk-dev] [PATCH v7 4/8] vhost: rxtx: use queue id instead of constant ring index

2015-10-21 Thread Yuanhan Liu
On Wed, Oct 21, 2015 at 01:31:55PM +0300, Michael S. Tsirkin wrote: > On Wed, Oct 21, 2015 at 11:48:10AM +0800, Yuanhan Liu wrote: > > From: Changchun Ouyang > > > > Do not use VIRTIO_RXQ or VIRTIO_TXQ anymore; use the queue_id > > instead, which will be set to a proper value for a specific queue

[dpdk-dev] [PATCH v3 2/4] nfp-uio: new uio driver for netronome nfp6000 card

2015-10-21 Thread Alejandro Lucero
On Wed, Oct 21, 2015 at 5:03 PM, Thomas Monjalon wrote: > 2015-10-21 16:57, Alejandro Lucero: > > I understand interest for not having another UIO driver does exist. We > > could maintain an external nfp_uio by now till either we get rid of it or > > we definitely find out it is really needed. an

[dpdk-dev] [PATCH] vhost: call write barrier before used index update

2015-10-21 Thread Nikita Kalyazin
Hi, > This has been discussed a number of times before on list, and the consensus > seems to be that the correct way to fix this is to introduce a set of specific > barrier operations that insert the correct barrier type on each architecture, > i.e. compiler barriers on IA, and full wmbs on archit

[dpdk-dev] [PATCH] The VMXNET3 PMD can't receive packet suddenly after a lot of traffic coming in

2015-10-21 Thread Thomas Monjalon
Any update? Yong, have you looked at it? 2015-07-24 09:58, Thomas Monjalon: > Hi Marco, > > It seems it is a new version of the patch. > Please, in order to ease patch management and review, could you add: > - a version number > - a changelog > - threading with previous patches

[dpdk-dev] [PATCH v2 2/2] examples: new example: l2fwd-ethtool

2015-10-21 Thread Thomas Monjalon
2015-07-23 11:00, Liang-Min Larry Wang: > examples/Makefile|1 + > examples/l2fwd-ethtool/Makefile | 48 + > examples/l2fwd-ethtool/l2fwd-app/Makefile| 58 ++ > examples/l2fwd-ethtool/l2fwd-app/main.c | 1025 > +

[dpdk-dev] [PATCH v2 1/2] Remove ABI requierment for external library builds.

2015-10-21 Thread Thomas Monjalon
2015-07-23 11:00, Liang-Min Larry Wang: > From: "Andrew G. Harvey" > --- a/mk/rte.extlib.mk > +++ b/mk/rte.extlib.mk > @@ -31,6 +31,8 @@ > > MAKEFLAGS += --no-print-directory > > +export EXTLIB_BUILD := 1 Is export really needed? Except that, this patch looks OK.

[dpdk-dev] [PATCH v3 2/4] nfp-uio: new uio driver for netronome nfp6000 card

2015-10-21 Thread Thomas Monjalon
2015-10-21 16:57, Alejandro Lucero: > I understand interest for not having another UIO driver does exist. We > could maintain an external nfp_uio by now till either we get rid of it or > we definitely find out it is really needed. any chance to accept nfp_uio by > now? No, there are some work curr

[dpdk-dev] [PATCH] fix lpm bugs

2015-10-21 Thread mablexidana
hi: We test some lpm cases and find some bugs, below is how to fix it. thanks :) --- lib/librte_lpm/rte_lpm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c index 163ba3c..b5199ff 100644 --- a/lib/librte_lpm/rte_lpm

[dpdk-dev] ixgbe: ierrors counter spuriously increasing in DPDK 2.1

2015-10-21 Thread Andriy Berestovskyy
Yes Marcin, The issue was discussed here: http://dpdk.org/ml/archives/dev/2015-September/023229.html You can either fix the ierrors in ixgbe_dev_stats_get() or implement a workaround in your app getting the extended statistics and counting out some of extended counters from the ierrors. Here is a

[dpdk-dev] [PATCH v7 4/8] vhost: rxtx: use queue id instead of constant ring index

2015-10-21 Thread Thomas Monjalon
2015-10-21 08:47, Stephen Hemminger: > On Wed, 21 Oct 2015 09:38:37 + > "Ananyev, Konstantin" wrote: > > I also don't understand what's wrong with using 'always_inline' here. > > As I understand the author wants compiler to *always inline* that function. > > So seems perfectly ok to use it her

[dpdk-dev] [PATCH] kni: allow per-net instances

2015-10-21 Thread Thomas Monjalon
Hi, It may look strange but you have to ask for reviews of your patches. Otherwise, people forget to check it. Helin, You are the KNI maintainer. Could you look at it please? 2015-07-02 18:12, Dex Chen: > There is a global variable 'device_in_use' which is used to make sure > only one instance is

[dpdk-dev] [PATCH 2/2] ixgbe: add memory barriers in vector rx/tx

2015-10-21 Thread Thomas Monjalon
2015-08-03 17:08, Thomas Monjalon: > 2015-06-29 11:28, Ananyev, Konstantin: > > There were several discussions about that subject already: > > why fence is not necessary here for IA and why we don't want to put it here: > > That I suppose was the last one: > > http://dpdk.org/ml/archives/dev/2015-A

[dpdk-dev] [PATCH 1/5] bnx2x: SR-IOV VF driver changes to support OOB PF driver

2015-10-21 Thread Thomas Monjalon
2015-10-21 15:24, Harish Patil: > > > >2015-09-11 17:42, Rasesh Mody: > >> From: Harish Patil > >> > >> Signed-off-by: Harish Patil > > > >Please explain your change a bit more. > > > > > > SR-IOV is supported using bnx2x poll mode driver running as VF driver and > native linux driver running as

[dpdk-dev] [PATCH v3] mem: command line option to delete hugepage backing files

2015-10-21 Thread Bruce Richardson
On Wed, Oct 21, 2015 at 04:22:45PM +, shesha Sreenivasamurthy (shesha) wrote: > When an application using huge-pages crash or exists, the hugetlbfs > backing files are not cleaned up. This is a patch to clean those files. > There are multi-process DPDK applications that may be benefited by tho

[dpdk-dev] [PATCH] drivers: fix shared library dependencies to external libraries

2015-10-21 Thread Nicolas Pernas Maradei
Hi, Are those the only two libraries with external dependencies? I took a quick look to the rte.app.mk file and there seem to be some others like -lfuse and -lnuma. Would it be possible to move those to their specific Makefiles as well? Thanks, Nico. On 10/21/2015 03:18 PM, Panu Matilainen wr

[dpdk-dev] [PATCH v7 4/8] vhost: rxtx: use queue id instead of constant ring index

2015-10-21 Thread Michael S. Tsirkin
On Wed, Oct 21, 2015 at 08:48:15PM +0800, Yuanhan Liu wrote: > > Please note that for virtio devices, guest is supposed to > > control the placement of incoming packets in RX queues. > > I may not follow you. > > Enqueuing packets to a RX queue is done at vhost lib, outside the > guest, how could

[dpdk-dev] [PATCH v3 2/4] nfp-uio: new uio driver for netronome nfp6000 card

2015-10-21 Thread Thomas Monjalon
2015-10-21 15:39, Alejandro Lucero: > On Wed, Oct 21, 2015 at 6:24 AM, David Marchand > wrote: > > Please, can you elaborate on the need for (yet another) uio driver, rather > > than make igb_uio work with your hardware ? [...] > I have been looking at the possibility of getting rid of nfp_uio. Th

[dpdk-dev] [PATCH v4] mem: command line option to delete hugepage backing files

2015-10-21 Thread shesha Sreenivasamurthy (shesha)
When an application using huge-pages crash or exists, the hugetlbfs backing files are not cleaned up. This is a patch to clean those files. There are multi-process DPDK applications that may be benefited by those backing files. Therefore, I have made that configurable so that the application that d

[dpdk-dev] [PATCH] drivers: fix shared library dependencies to external libraries

2015-10-21 Thread Panu Matilainen
Similar to commit 113c8e13c4201eee207723571f83aaf285277d75, but for bnx2x and pcap PMDs. Requiring applications to know about library internal details like dependencies to external helper libraries is a limitation of static linkage, shared libraries should always know their own dependencies for sa

[dpdk-dev] [PATCH] rte_alarm: modify it to make it not to be affected by discontinuous jumps in the system time

2015-10-21 Thread Thomas Monjalon
2015-10-13 17:33, Stephen Hemminger: > On Fri, 5 Jun 2015 10:46:36 +0800 > Wen-Chi Yang wrote: > > > Due to eal_alarm_callback() and rte_eal_alarm_set() use gettimeofday() > > to get the current time, and gettimeofday() is affected by jumps. > > > > For example, set up a rte_alarm which will be

[dpdk-dev] [PATCH] rte_alarm: modify it to make it not to be affected by discontinuous jumps in the system time

2015-10-21 Thread Thomas Monjalon
2015-10-14 07:09, Jay Rolette: > Back when this was first submitted in June, I mentioned that > CLOCK_MONOTONIC_RAW was ~10x slower than CLOCK_MONOTONIC: > > http://dpdk.org/ml/archives/dev/2015-June/018687.html > > It's not completely free from NTP frequency adjustments, but it won't have > any

[dpdk-dev] [PATCH] rte_alarm: modify it to make it not to be affected by discontinuous jumps in the system time

2015-10-21 Thread Thomas Monjalon
2015-10-13 17:33, Stephen Hemminger: > Agreed, this should be applied. > Does BSD version have same problem? Implementation of rte_alarm for BSD is empty. So I would say there is no such problem ;)

[dpdk-dev] [PATCH v7 4/8] vhost: rxtx: use queue id instead of constant ring index

2015-10-21 Thread Bruce Richardson
On 21/10/2015 16:52, Thomas Monjalon wrote: > 2015-10-21 08:47, Stephen Hemminger: >> On Wed, 21 Oct 2015 09:38:37 + >> "Ananyev, Konstantin" wrote: >>> I also don't understand what's wrong with using 'always_inline' here. >>> As I understand the author wants compiler to *always inline* that

[dpdk-dev] [PATCH v3 2/4] nfp-uio: new uio driver for netronome nfp6000 card

2015-10-21 Thread Alejandro Lucero
Wow! This is just what we (likely) need. We could have that support in our BSP but this is something yet to be approved. Setting per VF pci bus master and pci mask should also be added to BSP. Current PMD submitted would need nfp_uio by now for LSC interrupt support. As I said, this is not crit

[dpdk-dev] [PATCH v7 4/8] vhost: rxtx: use queue id instead of constant ring index

2015-10-21 Thread Bruce Richardson
On 21/10/2015 16:47, Stephen Hemminger wrote: > On Wed, 21 Oct 2015 09:38:37 + > "Ananyev, Konstantin" wrote: > minor nits: * this doesn't need to be marked as always inline, that is as they say in English "shooting a fly with a bazooka" >>> Stephen: >>> always_inline "

[dpdk-dev] [PATCH] vhost: call write barrier before used index update

2015-10-21 Thread Bruce Richardson
On 21/10/2015 16:42, Nikita Kalyazin wrote: > Hi, > >> This has been discussed a number of times before on list, and the consensus >> seems to be that the correct way to fix this is to introduce a set of >> specific >> barrier operations that insert the correct barrier type on each architecture,

[dpdk-dev] [PATCH v2 2/2] examples: new example: l2fwd-ethtool

2015-10-21 Thread Wang, Liang-min
Thomas, Let's put this patch on defer list because there are related work might take a different approach. Let's only review the make file change (PATCH 1/2). I believe "export" is needed since the variable is shared by all the build but it might be already included due to the mk file in

[dpdk-dev] [PATCH 1/6] xen: allow determining DOM0 at runtime

2015-10-21 Thread Thomas Monjalon
2015-09-28 17:44, Stephen Hemminger: > Add memory infrastructure for runtime Xen DOM0 support. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_eal/common/include/rte_memory.h | 30 - > lib/librte_eal/linuxapp/eal/eal_memory.c | 7 > lib/librte_eal/linuxapp/eal

[dpdk-dev] [PATCH 0/6] Xen DOM0 runtime support

2015-10-21 Thread Thomas Monjalon
2015-09-30 10:30, Stephen Hemminger: > On Wed, 30 Sep 2015 10:14:09 +0200 > David Marchand wrote: > > On Tue, Sep 29, 2015 at 2:44 AM, Stephen Hemminger < > > stephen at networkplumber.org> wrote: > > > It should be possible to build a single application or library > > > that will work both in Xen

[dpdk-dev] [PATCH 6/6] fm10k: use rte_eth_dma_zone_reserve

2015-10-21 Thread Thomas Monjalon
2015-10-04 20:44, David Marchand: > On Tue, Sep 29, 2015 at 2:44 AM, Stephen Hemminger < > > --- a/drivers/net/fm10k/fm10k_ethdev.c > > +++ b/drivers/net/fm10k/fm10k_ethdev.c > > -#ifdef RTE_LIBRTE_XEN_DOM0 > > q->hw_ring_phys_addr = rte_mem_phy2mch(mz->memseg_id, > > mz->phys_addr); > > -#

[dpdk-dev] [PATCH v7 4/8] vhost: rxtx: use queue id instead of constant ring index

2015-10-21 Thread Ananyev, Konstantin
> -Original Message- > From: Richardson, Bruce > Sent: Wednesday, October 21, 2015 4:56 PM > To: Stephen Hemminger; Ananyev, Konstantin > Cc: Michael S. Tsirkin; dev at dpdk.org; marcel at redhat.com; Changchun > Ouyang > Subject: Re: [dpdk-dev] [PATCH v7 4/8] vhost: rxtx: use queue id i

[dpdk-dev] [PATCH v3] mem: command line option to delete hugepage backing files

2015-10-21 Thread shesha Sreenivasamurthy (shesha)
When an application using huge-pages crash or exists, the hugetlbfs backing files are not cleaned up. This is a patch to clean those files. There are multi-process DPDK applications that may be benefited by those backing files. Therefore, I have made that configurable so that the application that d

[dpdk-dev] [PATCH 0/3] virtio: patches for 2.1+

2015-10-21 Thread Thomas Monjalon
2015-08-28 09:23, Stephen Hemminger: > These are some recently found bug fixes for virtio driver. > > Stephen Hemminger (3): > virtio: don't report link state feature unless available > virtio: fix Coverity unsigned warnings > virtio: fix possible NULL dereference > > drivers/net/virtio/vi

[dpdk-dev] [PATCH 2/2] virtio: allow running w/o vlan filtering

2015-10-21 Thread Thomas Monjalon
2015-08-05 12:49, Vincent JARDIN: > > Use '--disable-hw-vlan-filter' in testpmd command line will allow it > > continue to work. > > You can have a try. > > Yes, but not using this flag should not imply to exit. > > > I am not sure which one is better when app configures one feature but fail >

[dpdk-dev] [PATCH v4 2/2] doc: update release note for igb TSO support

2015-10-21 Thread Wang Xiao W
Signed-off-by: Wang Xiao W --- doc/guides/rel_notes/release_2_2.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/release_2_2.rst index 5687676..74ebd49 100644 --- a/doc/guides/rel_notes/release_2_2.rst +++ b/doc/guides/rel_no

[dpdk-dev] [PATCH v4 1/2] e1000: enable igb TSO support

2015-10-21 Thread Wang Xiao W
This patch enables igb TSO feature, the feature works on both PF and VF. The TCP segmentation offload needs to write the offload related information into the advanced context descriptors, which is similar to checksum offload. Signed-off-by: Wang Xiao W --- drivers/net/e1000/igb_ethdev.c | 6 +-

[dpdk-dev] [PATCH v4 0/2] e1000: enable igb TSO support

2015-10-21 Thread Wang Xiao W
v4: * Added ULL postfix to compare mask of igb_tx_offload. v3: * Removed the "unlikely" in check_tso_para function, for there was no obvious performance difference, let the branch predictor do the job. v2: * Reworded the old comment about union igb_vlan_macip which was no more used. * Correct

[dpdk-dev] [PATCH v4 20/20] vmxnet3: copy pci device info to eth_dev data

2015-10-21 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index a70be5c..2beee3e 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++ b/drivers/net/v

[dpdk-dev] [PATCH v4 19/20] virtio: copy pci device info to eth_dev data

2015-10-21 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- drivers/net/virtio/virtio_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 147aca1..5cd261b 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/v

[dpdk-dev] [PATCH v4 18/20] mlx4: copy pci device info to eth_dev data

2015-10-21 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- drivers/net/mlx4/mlx4.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index af31573..d2497cc 100644 --- a/drivers/net/mlx4/mlx4.c +++ b/drivers/net/mlx4/mlx4.c @@ -4972,6 +4972,9 @@ mlx4_pci_devinit(st

[dpdk-dev] [PATCH v4 17/20] enic: copy pci device info to eth_dev data

2015-10-21 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- drivers/net/enic/enic_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c index e385560..95baa8a 100644 --- a/drivers/net/enic/enic_ethdev.c +++ b/drivers/net/enic/enic_ethdev.c @@ -597,6

[dpdk-dev] [PATCH v4 16/20] cxgbe: copy pci device info to eth_dev data

2015-10-21 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- drivers/net/cxgbe/cxgbe_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c index a8e057b..3c406df 100644 --- a/drivers/net/cxgbe/cxgbe_ethdev.c +++ b/drivers/net/cxgbe/cxgbe_ethde

[dpdk-dev] [PATCH v4 15/20] bnx2x: copy pci device info to eth_dev data

2015-10-21 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- drivers/net/bnx2x/bnx2x_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c index 09b5920..fbcd5f4 100644 --- a/drivers/net/bnx2x/bnx2x_ethdev.c +++ b/drivers/net/bnx2x/bnx2x_ethde

[dpdk-dev] [PATCH v4 14/20] fm10k: copy pci device info to eth_dev data

2015-10-21 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- drivers/net/fm10k/fm10k_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c index a69c990..12be227 100644 --- a/drivers/net/fm10k/fm10k_ethdev.c +++ b/drivers/net/fm10k/fm10k_ethdev

[dpdk-dev] [PATCH v4 13/20] i40e: copy pci device info to eth_dev data

2015-10-21 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 3 +++ drivers/net/i40e/i40e_ethdev_vf.c | 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 2dd9fdc..bd81d4e 100644 --- a/drivers/net/i40e/i40e_ethdev

[dpdk-dev] [PATCH v4 12/20] e1000: copy pci device info to eth_dev data

2015-10-21 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- drivers/net/e1000/em_ethdev.c | 3 +++ drivers/net/e1000/igb_ethdev.c | 5 + 2 files changed, 8 insertions(+) diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c index 912f5dd..aa1bf48 100644 --- a/drivers/net/e1000/em_ethdev.c +++

[dpdk-dev] [PATCH v4 11/20] ixgbe: copy pci device info to eth_dev data

2015-10-21 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- drivers/net/ixgbe/ixgbe_ethdev.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index ec2918c..08b5cbb 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethd

[dpdk-dev] [PATCH v4 10/20] mpipe: remove pci device driver

2015-10-21 Thread Bernard Iremonger
From: David Hunt initialise dev_flags, kdrv, driver, drv_name and numa_node in eth_dev data. Signed-off-by: David Hunt Signed-off-by: Bernard Iremonger --- drivers/net/mpipe/mpipe_tilegx.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/mpipe/mpipe_til

[dpdk-dev] [PATCH v4 09/20] xenvirt: remove pci device driver

2015-10-21 Thread Bernard Iremonger
From: David Hunt Initialise dev_flags, driver, kdrv, drv_name and numa_node in eth_dev data. Signed-off-by: David Hunt Signed-off-by: Bernard Iremonger --- drivers/net/xenvirt/rte_eth_xenvirt.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/net/xenv

[dpdk-dev] [PATCH v4 08/20] af_packet: remove pci device driver

2015-10-21 Thread Bernard Iremonger
initialise dev_flags, driver, kdrv, drv_name and numa_node fields in eth_dev data. Signed-off-by: David Hunt Signed-off-by: Bernard Iremonger --- drivers/net/af_packet/rte_eth_af_packet.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/net/af_p

[dpdk-dev] [PATCH v4 07/20] pcap: remove pci device driver

2015-10-21 Thread Bernard Iremonger
remove rte_pcap_pmd and pci_dev. initialise dev_flags, driver, drv_name, kdrv and numa_node fields in eth_dev data Signed-off-by: Bernard Iremonger --- drivers/net/pcap/rte_eth_pcap.c | 31 +-- 1 file changed, 9 insertions(+), 22 deletions(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH v4 06/20] bonding: remove pci device driver

2015-10-21 Thread Bernard Iremonger
remove pci_dev, pci_drv, rte_bond_pmd and pci_id_table. initialise dev_flags, kdrv, driver, drv_name and numa_node fields in eth_dev data. handle numa_node for vdevs handle RTE_ETH_DEV_INTR_LSC for vdevs rename valid_bonded_device to check_for_bonded_device Signed-off-by: Bernard Iremonger ---

[dpdk-dev] [PATCH v4 05/20] ring: remove pci device driver

2015-10-21 Thread Bernard Iremonger
remove rte_ring_pmd and pci_dev. initialise dev_flags, driver, drv_name, kdrv and numa_node fields in eth_dev data. Signed-off-by: Bernard Iremonger --- drivers/net/ring/rte_eth_ring.c | 37 - 1 file changed, 8 insertions(+), 29 deletions(-) diff --git a/dri

[dpdk-dev] [PATCH v4 04/20] null: remove pci device driver

2015-10-21 Thread Bernard Iremonger
remove rte_null_pmd and pci_dev. initialise dev_flags, driver, drv_name, kdrv and numa_node fields in eth_dev data Signed-off-by: Bernard Iremonger --- drivers/net/null/rte_eth_null.c | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/drivers/net/n

[dpdk-dev] [PATCH v4 03/20] librte_ether: add function rte_eth_copy_dev_info()

2015-10-21 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- lib/librte_ether/rte_ethdev.c | 14 ++ lib/librte_ether/rte_ethdev.h | 14 ++ lib/librte_ether/rte_ether_version.map | 7 +++ 3 files changed, 35 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/lib

[dpdk-dev] [PATCH v4 02/20] librte_ether: add fields from rte_pci_driver to rte_eth_dev_data

2015-10-21 Thread Bernard Iremonger
add dev_flags to rte_eth_dev_data, add macros for dev_flags. add kdrv to rte_eth_dev_data. add numa_node to rte_eth_dev_data. add drv_name to rte_eth_dev_data. use dev_type to distinguish between vdev's and pdev's. remove pci_dev branches. update release notes. Signed-off-by: Bernard Iremonger --

[dpdk-dev] [PATCH v4 01/20] librte_eal: add RTE_KDRV_NONE for vdevs

2015-10-21 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- lib/librte_eal/common/include/rte_pci.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h index 83e3c28..334c12e 100644 --- a/lib/librte_eal/common/include/r

[dpdk-dev] [PATCH v4 00/20] remove pci driver from vdevs

2015-10-21 Thread Bernard Iremonger
There is a dummy pci driver in the vdev PMD's at present. This patch set removes the pci driver from the vdev PMD's. Changes have been made to librte_ether to handle vdevs and pdevs in the same way. The following vdev PMD's have had the pci driver removed: null ring bonding pcap af_packet xenvir

[dpdk-dev] [PATCH] hash: fix broken compatability with 2.0

2015-10-21 Thread Thomas Monjalon
2015-09-22 16:12, Stephen Hemminger: > Version 2.1 must retain source code compatability with 2.0, > all structure fields should be retained. If a field is no > longer used it should have been marked as deprecated. > > Fixes: 661e75ef8cac ("hash: rename unused field") > > Signed-off-by: Stephen H

[dpdk-dev] [PATCH 1/5] bnx2x: SR-IOV VF driver changes to support OOB PF driver

2015-10-21 Thread Harish Patil
> >2015-10-21 15:24, Harish Patil: >> > >> >2015-09-11 17:42, Rasesh Mody: >> >> From: Harish Patil >> >> >> >> Signed-off-by: Harish Patil >> > >> >Please explain your change a bit more. >> > >> > >> >> SR-IOV is supported using bnx2x poll mode driver running as VF driver >>and >> native linux d

[dpdk-dev] [PATCH v3 2/4] nfp-uio: new uio driver for netronome nfp6000 card

2015-10-21 Thread Alejandro Lucero
Hi David, On Wed, Oct 21, 2015 at 6:24 AM, David Marchand wrote: > Hello Alejandro, > > On Fri, Oct 16, 2015 at 12:45 PM, Alejandro.Lucero < > alejandro.lucero at netronome.com> wrote: > >> From: "Alejandro.Lucero" >> >> This patch adds a new UIO kernel driver for supporting PCI VFs with >> Net

[dpdk-dev] [PATCH v2] mem: command line option to delete hugepage backing files

2015-10-21 Thread Sergio Gonzalez Monroy
Hi Shesha, A few things: - For some reason the patch didn't upload properly to patchwork and the last bit of the patch is missing. The following link shows that the patch fails basic testing/compilation: http://dpdk.org/ml/archives/test-report/2015-October/000352.html - You seem to be sendi

[dpdk-dev] [PATCH 1/5] bnx2x: SR-IOV VF driver changes to support OOB PF driver

2015-10-21 Thread Harish Patil
> >2015-09-11 17:42, Rasesh Mody: >> From: Harish Patil >> >> Signed-off-by: Harish Patil > >Please explain your change a bit more. > > SR-IOV is supported using bnx2x poll mode driver running as VF driver and native linux driver running as PF (in host/hypervisor). There is no issue while runnin

[dpdk-dev] [PATCH v2 0/5] virtio: Tx performance improvements

2015-10-21 Thread Thomas Monjalon
2015-10-18 22:16, Stephen Hemminger: > This is a tested version of the virtio Tx performance improvements > that I posted earlier on the list, and described at the DPDK Userspace > meeting in Dublin. Together they get a 25% performance improvement for > both small packet and large multi-segment pac

[dpdk-dev] [PATCH v5 3/4] vhost: using EVENTFD_COPY2

2015-10-21 Thread Pavel Boldin
Xie, Please find my comments intermixed below. On Tue, Oct 20, 2015 at 12:52 PM, Xie, Huawei wrote: > Thanks Pavel for this work. > This is what we think is the better implementation for eventfd proxy, in > our last review. > Could you add an additional patch to remove the old implementation? >

[dpdk-dev] [PATCH 1/2] eal: move plugin loading to eal/common

2015-10-21 Thread Panu Matilainen
On 10/21/2015 02:53 PM, Thomas Monjalon wrote: > 2015-10-21 12:15, Bruce Richardson: >> On Wed, Oct 21, 2015 at 01:09:24PM +0200, David Marchand wrote: >>> On Wed, Oct 21, 2015 at 12:54 PM, Panu Matilainen >>> wrote: Btw, returning an error here would change current behavior of dpdk load

[dpdk-dev] [PATCH v7 4/8] vhost: rxtx: use queue id instead of constant ring index

2015-10-21 Thread Yuanhan Liu
On Tue, Oct 20, 2015 at 09:43:54PM -0700, Stephen Hemminger wrote: > On Wed, 21 Oct 2015 11:48:10 +0800 > Yuanhan Liu wrote: > > > > > +static inline int __attribute__((always_inline)) > > +is_valid_virt_queue_idx(uint32_t virtq_idx, int is_tx, uint32_t max_qp_idx) > > +{ > > + if ((is_tx ^ (

[dpdk-dev] [PATCH v7 3/8] vhost: vring queue setup for multiple queue support

2015-10-21 Thread Yuanhan Liu
On Tue, Oct 20, 2015 at 09:45:12PM -0700, Stephen Hemminger wrote: > On Wed, 21 Oct 2015 11:48:09 +0800 > Yuanhan Liu wrote: > > > struct virtio_net { > > - struct vhost_virtqueue *virtqueue[VIRTIO_QNUM];/**< Contains > > all virtqueue information. */ > > + struct vhost_virtqueue

[dpdk-dev] drivers/crypto sub-tree maintainer volunteer

2015-10-21 Thread Thomas Monjalon
2015-10-21 12:06, Declan Doherty: > On 21/10/15 10:34, Thomas Monjalon wrote: > > Should we create a separate mailing list and patchwork? > > personally I think keeping a single mailing list for the moment is > preferable. The mailing lists volume isn't so great yet I would say we need to reduce

[dpdk-dev] [PATCH v2] eal: don't reset getopt lib

2015-10-21 Thread Tiwei Bie
On Wed, Oct 21, 2015 at 07:33:42AM +0200, David Marchand wrote: > On Mon, Oct 19, 2015 at 3:16 PM, Bruce Richardson intel.com> > wrote: > > > On Mon, Oct 19, 2015 at 09:13:10PM +0800, Tiwei Bie wrote: > > > Someone may need to call rte_eal_init() with a fake argc/argv array > > > in the middle of

[dpdk-dev] [PATCH] MAINTAINERS: update maintainer for reorder library

2015-10-21 Thread Sergio Gonzalez Monroy
On 21/10/2015 11:50, Reshma Pattan wrote: > Updated maintainers list for reorder library > > Signed-off-by: Reshma Pattan > --- > MAINTAINERS |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 080a8e8..bdc0981 100644 > --- a/MAINTAIN

[dpdk-dev] [PATCH v2] app/test: fix reorder library unit test

2015-10-21 Thread Sergio Gonzalez Monroy
On 21/10/2015 11:50, Reshma Pattan wrote: > The reorder library unit test was performed under the assumption that the > start > sequence number was always 0. > This is not the case anymore as the start sequence number is initialized by > the first > packet inserted into the reorder buffer. > > Th

[dpdk-dev] [PATCH 1/2] eal: move plugin loading to eal/common

2015-10-21 Thread Panu Matilainen
On 10/21/2015 01:15 PM, David Marchand wrote: > On Wed, Oct 21, 2015 at 10:29 AM, Panu Matilainen > wrote: > >> There's no good reason to limit plugins to Linux, make it available >> on FreeBSD too. Refactor the plugin code from Linux EAL to common >> helper functions, also check for potential err

[dpdk-dev] [PATCH 1/2] eal: move plugin loading to eal/common

2015-10-21 Thread Thomas Monjalon
2015-10-21 12:15, Bruce Richardson: > On Wed, Oct 21, 2015 at 01:09:24PM +0200, David Marchand wrote: > > On Wed, Oct 21, 2015 at 12:54 PM, Panu Matilainen > > wrote: > > > > > > Btw, returning an error here would change current behavior of dpdk loading > > >> drivers. > > >> Not sure we want this

[dpdk-dev] [RFC PATCH v2] vhost: Add VHOST PMD

2015-10-21 Thread Tetsuya Mukawa
On 2015/10/19 22:27, Richardson, Bruce wrote: >> -Original Message- >> From: Panu Matilainen [mailto:pmatilai at redhat.com] >> Sent: Monday, October 19, 2015 2:26 PM >> To: Tetsuya Mukawa ; Richardson, Bruce >> ; Loftus, Ciara >> Cc: dev at dpdk.org; ann.zhuangyanying at huawei.com >> Sub

[dpdk-dev] [PATCH 4/6] docs: add getting started guides for multi-buffer pmd and qat pmd

2015-10-21 Thread Thomas Monjalon
2015-10-03 00:01, Declan Doherty: > doc/guides/cryptodevs/aesni_mb.rst | 76 ++ > doc/guides/cryptodevs/index.rst| 43 ++ > doc/guides/cryptodevs/qat.rst | 155 > + > doc/guides/index.rst | 1 + Please avoid se

[dpdk-dev] [PATCH v7 4/8] vhost: rxtx: use queue id instead of constant ring index

2015-10-21 Thread Michael S. Tsirkin
On Wed, Oct 21, 2015 at 11:48:10AM +0800, Yuanhan Liu wrote: > From: Changchun Ouyang > > Do not use VIRTIO_RXQ or VIRTIO_TXQ anymore; use the queue_id > instead, which will be set to a proper value for a specific queue > when we have multiple queue support enabled. > > For now, queue_id is stil

[dpdk-dev] [RFC PATCH v2] vhost: Add VHOST PMD

2015-10-21 Thread Tetsuya Mukawa
On 2015/10/20 23:13, Loftus, Ciara wrote: > + +static uint16_t +eth_vhost_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs) +{ + struct vhost_queue *r = q; + uint16_t i, nb_tx = 0; + + if (unlikely(r->internal == NULL)) + return 0; +

[dpdk-dev] [PATCH v3 6/6] example/ip_pipeline/pipeline: update flow_classification pipeline

2015-10-21 Thread Jasvinder Singh
From: Fan Zhang This patch updates the flow_classification pipeline for added key_mask parameter in 8/16-byte key hash parameters. The update provides user optional key_mask configuration item applying to the packets. Signed-off-by: Fan Zhang --- .../pipeline/pipeline_flow_classification_be.c

[dpdk-dev] [PATCH v3 5/6] example/ip_pipeline: add parse_hex_string for internal use

2015-10-21 Thread Jasvinder Singh
From: Fan Zhang This patch adds parse_hex_string function to parse hex string to uint8_t array. Signed-off-by: Fan Zhang --- examples/ip_pipeline/config_parse.c | 70 + examples/ip_pipeline/pipeline.h | 4 +++ 2 files changed, 74 insertions(+) diff --g

[dpdk-dev] [PATCH v3 4/6] app/test-pipeline: modify pipeline test

2015-10-21 Thread Jasvinder Singh
From: Fan Zhang Test-pipeline has been updated to work on added key_mask parameter for 8-byte key extendible bucket and LRU tables. Signed-off-by: Fan Zhang --- app/test-pipeline/pipeline_hash.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test-pipeline/pipeline_hash.c b/app/te

[dpdk-dev] [PATCH v3 3/6] app/test: modify app/test_table_combined and app/test_table_tables

2015-10-21 Thread Jasvinder Singh
From: Fan Zhang Tests have been updated to work on added key_mask parameter for 8-byte key extendible bucket and LRU tables. Signed-off-by: Fan Zhang --- app/test/test_table_combined.c | 5 - app/test/test_table_tables.c | 6 -- 2 files changed, 8 insertions(+), 3 deletions(-) diff

[dpdk-dev] [PATCH v3 2/6] librte_table: add 16 byte hash table operations with computed lookup

2015-10-21 Thread Jasvinder Singh
From: Fan Zhang This patch is to adding hash table operations for key signature computed on lookup ("do-sig") for LRU hash tables and Extendible buckets. Signed-off-by: Fan Zhang --- lib/librte_table/rte_table_hash.h | 8 + lib/librte_table/rte_table_hash_key16.c | 359

[dpdk-dev] [PATCH v3 1/6] librte_table: add key_mask parameter to 8- and 16-bytes key hash parameters

2015-10-21 Thread Jasvinder Singh
From: Fan Zhang This patch relates to ABI change proposed for librte_table. The key_mask parameter is added for 8-byte and 16-byte key extendible bucket and LRU tables.The release notes is updated and the deprecation notice is removed. Signed-off-by: Fan Zhang Signed-off-by: Jasvinder Singh -

[dpdk-dev] [PATCH v3 0/6] librte_table: add key_mask parameter to hash table parameter structure

2015-10-21 Thread Jasvinder Singh
This patchset links to ABI change announced for librte_table. The key_mask parameters has been added to the hash table parameter structure for 8-byte key and 16-byte key extendible bucket and LRU tables. v2: *updated release note v3: *merged release note with source code patch *fixed build error:

[dpdk-dev] [PATCH 1/2] eal: move plugin loading to eal/common

2015-10-21 Thread David Marchand
On Wed, Oct 21, 2015 at 12:54 PM, Panu Matilainen wrote: > > Btw, returning an error here would change current behavior of dpdk loading >> drivers. >> Not sure we want this as people may rely on this loading not failing. >> > > Yeah, dpdk currently doesn't fail if you pass garbage to -d, which is

[dpdk-dev] [PATCH v6 10/13] ixgbe: support VMDq RSS in non-SRIOV environment

2015-10-21 Thread Ananyev, Konstantin
Hi Yliu, > -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Wednesday, October 21, 2015 2:01 PM > To: Ananyev, Konstantin > Cc: dev at dpdk.org; Michael S. Tsirkin; marcel at redhat.com > Subject: Re: [dpdk-dev] [PATCH v6 10/13] ixgbe: support VMDq RSS

[dpdk-dev] [PATCH 8/8] app/testpmd:modify MAC address of csum forwarding

2015-10-21 Thread Jijiang Liu
The change will affect on the csum fwd performance. But I also think the change is necessary, or we cannot use csumonly fwd mode in a VM. Signed-off-by: Jijiang Liu --- app/test-pmd/csumonly.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/app/test-pmd/csumonly.c

[dpdk-dev] [PATCH 7/8] examples/vhost:support TX offload in vhost sample

2015-10-21 Thread Jijiang Liu
Change the vhost sample to support and test TX offload. Signed-off-by: Jijiang Liu --- examples/vhost/main.c | 128 ++--- 1 files changed, 111 insertions(+), 17 deletions(-) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index 9eac2d0..06

[dpdk-dev] [PATCH 6/8] lib/librte_vhost:dequeue vhost TX offload

2015-10-21 Thread Jijiang Liu
Dequeue vhost TX offload in vhost lib. Signed-off-by: Jijiang Liu --- lib/librte_vhost/vhost_rxtx.c | 108 - 1 files changed, 107 insertions(+), 1 deletions(-) diff --git a/lib/librte_vhost/vhost_rxtx.c b/lib/librte_vhost/vhost_rxtx.c index 7026bfa..a888

[dpdk-dev] [PATCH 5/8] driver/virtio:enqueue vhost TX offload

2015-10-21 Thread Jijiang Liu
Enqueue vhost TX checksum and TSO4/6 offload in virtio-net lib. Signed-off-by: Jijiang Liu --- drivers/net/virtio/virtio_rxtx.c | 61 ++ 1 files changed, 61 insertions(+), 0 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/vir

[dpdk-dev] [PATCH 4/8] driver/virtio:add vhost TX offload support capability

2015-10-21 Thread Jijiang Liu
Add vhost TX checksum and TSO support capability in vhost lib. Signed-off-by: Jijiang Liu --- lib/librte_vhost/virtio-net.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c index d0f1764..a5989a2 100644 -

[dpdk-dev] [PATCH 3/8] driver/virtio:add vhost TX offload support capability in virtio-net

2015-10-21 Thread Jijiang Liu
Add vhost TX checksum and TSO capabilities in virtio-net lib. Signed-off-by: Jijiang Liu --- drivers/net/virtio/virtio_ethdev.h |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h index 9026d42..6ee

[dpdk-dev] [PATCH 2/8] driver/virtio: record virtual address of virtio net header

2015-10-21 Thread Jijiang Liu
Record virtual address of virtio net header. Signed-off-by: Jijiang Liu --- drivers/net/virtio/virtio_ethdev.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 465d3cd..cb5dfee 100644 --- a/d

  1   2   >