[dpdk-dev] i40e: problem with rx packet drops not accounted in statistics

2015-10-22 Thread Zhang, Helin
Hi Martin Yes, we have a developer working on it now, and hopefully he will have something soon later on this fix. But what do you mean the performance problem? Did you mean the performance number is not good as expected, or else? Regards, Helin > -Original Message- > From: Martin Weis

[dpdk-dev] [PATCH 5/6] doc: Update BNX2X PMD documentation

2015-10-22 Thread Rasesh Mody
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, October 20, 2015 9:20 AM > > This patch can be avoided by updating the documentation with each code > change atomically. Agreed, will take care in next submission. This message and any

[dpdk-dev] [PATCH 4/6] config: Enable BNX2X driver build by default

2015-10-22 Thread Rasesh Mody
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, October 20, 2015 9:18 AM > > 2015-10-08 09:54, Rasesh Mody: > > From: Harish Patil > > > > Signed-off-by: Harish Patil > > Signed-off-by: Rasesh Mody > > You cannot enable bnx2x without gracefully handle miss of zlib

[dpdk-dev] [PATCH v2 6/6] ixgbe: implementation for fdir new modes' config

2015-10-22 Thread Lu, Wenzhuo
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, October 21, 2015 6:19 PM > To: Lu, Wenzhuo; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2 6/6] ixgbe: implementation for fdir new > modes' config > > > > > -Original Message- > > From: Lu, W

[dpdk-dev] [PATCH 1/3] fm10k: add multi-queue checking

2015-10-22 Thread Qiu, Michael
On 2015/10/15 19:07, He, Shaopeng wrote: > Hi, Michael > >> -Original Message- >> From: Qiu, Michael >> Sent: Thursday, October 15, 2015 2:28 PM >> To: He, Shaopeng; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 1/3] fm10k: add multi-queue checking >> >> On 2015/9/30 15:29, Shaopeng He

[dpdk-dev] DPDK patch backlog

2015-10-22 Thread Qiu, Michael
On 2015/10/16 22:25, Neil Horman wrote: > On Fri, Oct 16, 2015 at 10:45:23AM +0200, Thomas Monjalon wrote: >> 2015-10-15 14:44, Stephen Hemminger: >>> There are currently 428 patches in New state in DPDK patchwork. >>> >>> Thomas, could you start reducing that backlog? >> Yes >> >>> The simplest so

[dpdk-dev] DPDK patch backlog

2015-10-22 Thread Qiu, Michael
On 2015/10/21 17:05, Thomas Monjalon wrote: > 2015-10-21 11:48, Panu Matilainen: >> On 10/21/2015 11:25 AM, Thomas Monjalon wrote: >>> 2015-10-20 21:34, Stephen Hemminger: Patch backlog is not getting better, now at 486. How can we break this logjam? Do I need to make a new "rea

[dpdk-dev] [PATCH] fix lpm bugs

2015-10-22 Thread mablexidana
hi: Fixes: 25e4f515fe63 ("fix lpm bugs") the random test of lpm , multiple delete and add ip address, it do not recover the last right ip address. eg1: add a lot of routes: rule id : 1, ip : 16.32.0.0/19, next_hop : 62, rule id : 2, ip : 16.32.28.0/22, next_hop : 97, rule id :

[dpdk-dev] [PATCH v3 6/7] virtio: simple tx routine

2015-10-22 Thread Tan, Jianfeng
On 10/22/2015 10:26 AM, Jianfeng wrote: > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Huawei Xie > Sent: Tuesday, October 20, 2015 11:30 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v3 6/7] virtio: simple tx routine > > Changes in v3: > - Remove

[dpdk-dev] volunteer to be the maintainer of driver/net/intel sub-tree

2015-10-22 Thread Lu, Wenzhuo
Hi all, Following the discussion of DPDK user space and the maintenance of development sub-trees, I'd like to volunteer myself to be the maintainer of sub-tree driver/net/intel. It includes all the PMD of Intel NICs. And Helin can be my backup. I suggest we create a new directory to move the dri

[dpdk-dev] [PATCH v3 7/7] virtio: pick simple rx/tx func

2015-10-22 Thread Tan, Jianfeng
On 10/22/2015 10:45 AM, Jianfeng wrote: > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Huawei Xie > Sent: Tuesday, October 20, 2015 11:30 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v3 7/7] virtio: pick simple rx/tx func > > simple rx/tx func is e

[dpdk-dev] [PATCH] kni: allow per-net instances

2015-10-22 Thread Zhang, Helin
Hi Dex Two comments inlined. Thank you very much for the really good contribution to KNI! Regards, Helin > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Dex Chen > Sent: Thursday, July 2, 2015 6:12 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] kni

[dpdk-dev] [PATCH v3 5/7] virtio: virtio vec rx

2015-10-22 Thread Wang, Zhihong
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Huawei Xie > Sent: Tuesday, October 20, 2015 11:30 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v3 5/7] virtio: virtio vec rx > > With fixed avail ring, we don't need to get desc idx from avail ring.

[dpdk-dev] [PATCH] drivers: fix shared library dependencies to external libraries

2015-10-22 Thread Panu Matilainen
On 10/21/2015 07:30 PM, Nicolas Pernas Maradei wrote: > Hi, > > Are those the only two libraries with external dependencies? I took a > quick look to the rte.app.mk file and there seem to be some others like > -lfuse and -lnuma. Would it be possible to move those to their specific > Makefiles as we

[dpdk-dev] [PATCH v3 6/7] virtio: simple tx routine

2015-10-22 Thread Xie, Huawei
On 10/21/2015 2:58 AM, Stephen Hemminger wrote: > On Tue, 20 Oct 2015 23:30:06 +0800 > Huawei Xie wrote: > >> +desc_idx = (uint16_t)(vq->vq_used_cons_idx & >> +((vq->vq_nentries >> 1) - 1)); >> +free[0] = (struct rte_mbuf *)vq->vq_descx[desc_idx++].cookie; >> +nb_free = 1;

[dpdk-dev] [PATCH v3 5/7] virtio: virtio vec rx

2015-10-22 Thread Xie, Huawei
On 10/22/2015 12:04 PM, Wang, Zhihong wrote: > Wonder if the prefetch will actually help here. > Will prefetching rx_pkts[i] be more helpful? What is your concern prefetch the virtio ring? rx_pkts is local array, Why do we need to prefetch it?

[dpdk-dev] dpdk proposal installation process

2015-10-22 Thread Panu Matilainen
On 10/21/2015 10:15 PM, Olivier MATZ wrote: > Hi Mario, > > On 10/20/2015 11:17 AM, Bruce Richardson wrote: >> On Tue, Oct 20, 2015 at 12:21:00AM +, Arevalo, Mario Alfredo C wrote: >>> Hi folks, >>> >>>Good day, this is a proposal in order to improve the dpdk install >>> process, >>> I

[dpdk-dev] [PATCH 2/5] fm10k: enable Rx queue interrupts for PF and VF

2015-10-22 Thread Chen, Jing D
Hi, Best Regards, Mark > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Shaopeng He > Sent: Friday, September 25, 2015 1:37 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 2/5] fm10k: enable Rx queue interrupts for PF > and VF > > The patch does below

[dpdk-dev] [PATCH 7/8] i40e: get_dcb_info ops implement

2015-10-22 Thread Liu, Jijiang
> -Original Message- > From: Wu, Jingjing > Sent: Thursday, September 24, 2015 2:03 PM > To: dev at dpdk.org > Cc: Wu, Jingjing; Liu, Jijiang; Zhang, Helin; Tao, Zhe; Pei, Yulong > Subject: [PATCH 7/8] i40e: get_dcb_info ops implement > > This patch implements the get_dcb_info ops in

[dpdk-dev] [PATCH v3 0/7] Support new flow director modes on Intel x550 NIC

2015-10-22 Thread Wenzhuo Lu
This patch set adds 2 new flow director modes on Intel x550 NIC. The 2 new fdir modes are mac vlan mode and tunnel mode. The mac vlan mode can direct the flow based on the MAC address and VLAN TCI. The tunnel mode provides the support for VxLAN and NVGRE. x550 can recognize VxLAN and NVGRE packets,

[dpdk-dev] [PATCH v3 1/7] lib/librte_ether: modify the structures for fdir new modes

2015-10-22 Thread Wenzhuo Lu
Define the new modes and modify the filter and mask structures for the mac vlan and tunnel modes. Signed-off-by: Wenzhuo Lu --- lib/librte_ether/rte_eth_ctrl.h | 69 ++--- 1 file changed, 51 insertions(+), 18 deletions(-) diff --git a/lib/librte_ether/rte_eth

[dpdk-dev] [PATCH v3 2/7] app/testpmd: initialize the new fields for fdir mask

2015-10-22 Thread Wenzhuo Lu
When a port is enabled, there're default values for the parameters of fdir mask. For the new parameters, the default values also need to be set. Signed-off-by: Wenzhuo Lu --- app/test-pmd/testpmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testp

[dpdk-dev] [PATCH v3 4/7] app/testpmd: modify the output of the CLI show port fdir

2015-10-22 Thread Wenzhuo Lu
There're fdir mask and supported flow type in the output of the CLI, show port fdir. But not every parameter has meaning for all the fdir modes, and the supported flow type is meaningless for mac vlan and tunnel modes. So, we output different thing for different mode. Signed-off-by: Wenzhuo Lu --

[dpdk-dev] [PATCH v3 3/7] app/testpmd: new fdir modes for testpmd parameter

2015-10-22 Thread Wenzhuo Lu
For testpmd CLI's parameter pkt-filter-mode, there're new values supported for fdir new modes, perfect-mac-vlan, perfect-tunnel. Signed-off-by: Wenzhuo Lu --- app/test-pmd/parameters.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/parameters.c b/app/test-

[dpdk-dev] [PATCH v3 5/7] app/testpmd: modify and add fdir filter and mask CLIs for new modes

2015-10-22 Thread Wenzhuo Lu
The different fdir mode needs different parameters, so, the parameter *mode* is introduced to the CLI flow_director_filter and flow_director_mask. This parameter can pormpt the user to input the appropriate parameters for different mode. Please be aware, as we should set the fdir mode, the value of

[dpdk-dev] [PATCH v3 6/7] ixgbe: implementation for fdir new modes' config

2015-10-22 Thread Wenzhuo Lu
Implement the new CLIs for fdir mac vlan and tunnel modes, including flow_director_filter and flow_director_mask. Set the mask of fdir. Add, delete or update the entities of filter. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/ixgbe_ethdev.h | 3 + drivers/net/ixgbe/ixgbe_fdir.c | 261 +++

[dpdk-dev] [PATCH v3 7/7] doc: release notes update for flow director enhancement

2015-10-22 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- doc/guides/rel_notes/release_2_2.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/release_2_2.rst index bc9b00f..9d0a4d7 100644 --- a/doc/guides/rel_notes/release_2_2.rst +++ b/doc/guides/rel_note

[dpdk-dev] [PATCH v7 4/8] vhost: rxtx: use queue id instead of constant ring index

2015-10-22 Thread Xie, Huawei
On 10/21/2015 11:48 AM, Yuanhan Liu wrote: [...] > > #define MAX_PKT_BURST 32 > > +static inline int __attribute__((always_inline)) > +is_valid_virt_queue_idx(uint32_t virtq_idx, int is_tx, uint32_t max_qp_idx) > +{ > + if ((is_tx ^ (virtq_idx & 0x1)) || > + (virtq_idx >= max_qp_i

[dpdk-dev] [PATCH v2 0/2] i40e: Enlarge the number of supported queues

2015-10-22 Thread Helin Zhang
It enlarges the number of supported queues to hardware allowed maximum. There was a software limitation of 64 per physical port which is not reasonable. v2 changes: Fixed issues of using wrong configured number of VF queues. Helin Zhang (2): i40e: adjust the number of queues for RSS i40e: Enl

[dpdk-dev] [PATCH v2 1/2] i40e: adjust the number of queues for RSS

2015-10-22 Thread Helin Zhang
It adjusts the number of queues for RSS from power of 2 to any as long as it does not exceeds the hardware allowed. Signed-off-by: Helin Zhang --- drivers/net/i40e/i40e_ethdev.c| 8 drivers/net/i40e/i40e_ethdev_vf.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --gi

[dpdk-dev] [PATCH v2 2/2] i40e: Enlarge the number of supported queues

2015-10-22 Thread Helin Zhang
It enlarges the number of supported queues to hardware allowed maximum. There was a software limitation of 64 per physical port which is not reasonable. Signed-off-by: Helin Zhang --- config/common_bsdapp | 3 +- config/common_linuxapp | 3 +- drivers/net/i40e/i40e_ethdev.c

[dpdk-dev] [PATCH v2] ixgbe: Drop flow control frames from VFs

2015-10-22 Thread Wenzhuo Lu
This patch will drop flow control frames from being transmitted from VSIs. With this patch in place a malicious VF cannot send flow control or PFC packets out on the wire. V2: Reword the comments. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/ixgbe_pf.c | 43 ++

[dpdk-dev] ixgbe: ierrors counter spuriously increasing in DPDK 2.1

2015-10-22 Thread Martin Weiser
Hi Andriy, thank you for pointing this discussion out to me. I somehow missed it. Unfortunately it looks like the discussion stopped after Maryam made a good proposal so I will vote in on that and hopefully get things started again. Best regards, Martin On 21.10.15 17:53, Andriy Berestovskyy w

[dpdk-dev] [PATCH v4 0/2] e1000: enable igb TSO support

2015-10-22 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Wang, Xiao W > Sent: Wednesday, October 21, 2015 3:55 PM > To: dev at dpdk.org > Cc: Lu, Wenzhuo; Richardson, Bruce; Zhang, Helin; Wang, Xiao W > Subject: [PATCH v4 0/2] e1000: enable igb TSO support > > v4: > * Added ULL postfix to compare mask of igb_tx_

[dpdk-dev] i40e: problem with rx packet drops not accounted in statistics

2015-10-22 Thread Martin Weiser
Hi Helin, good to know that there is work being done on that issue. By performance problem I mean that theses packet discards start to appear at low bandwidths where I would not expect any packets to be dropped. On the same system we can reach higher bandwidths using ixgbe NICs without loosing a s

[dpdk-dev] volunteer to be the maintainer of driver/net/intel sub-tree

2015-10-22 Thread Thomas Monjalon
Hi Wenzhuo, 2015-10-22 02:49, Lu, Wenzhuo: > Hi all, > Following the discussion of DPDK user space and the maintenance of > development sub-trees, I'd like to volunteer myself to be the maintainer of > sub-tree driver/net/intel. It includes all the PMD of Intel NICs. And Helin > can be my backu

[dpdk-dev] ixgbe: account more Rx errors Issue

2015-10-22 Thread Martin Weiser
On 14.09.15 11:50, Tahhan, Maryam wrote: >> From: Kyle Larose [mailto:eomereadig at gmail.com] >> Sent: Wednesday, September 9, 2015 6:43 PM >> To: Tahhan, Maryam >> Cc: Olivier MATZ; Andriy Berestovskyy; dev at dpdk.org >> Subject: Re: [dpdk-dev] ixgbe: account more Rx errors Issue >> >> >> On Mo

[dpdk-dev] [PATCH v3 0/7] Support new flow director modes on Intel x550 NIC

2015-10-22 Thread Ananyev, Konstantin
> -Original Message- > From: Lu, Wenzhuo > Sent: Thursday, October 22, 2015 8:12 AM > To: dev at dpdk.org > Cc: Ananyev, Konstantin > Subject: [PATCH v3 0/7] Support new flow director modes on Intel x550 NIC > > This patch set adds 2 new flow director modes on Intel x550 NIC. > The 2 new

[dpdk-dev] [PATCH v3] mem: command line option to delete hugepage backing files

2015-10-22 Thread Sergio Gonzalez Monroy
On 21/10/2015 17:34, Bruce Richardson wrote: > On Wed, Oct 21, 2015 at 04:22:45PM +, shesha Sreenivasamurthy (shesha) > wrote: >> When an application using huge-pages crash or exists, the hugetlbfs >> backing files are not cleaned up. This is a patch to clean those files. >> There are multi-pr

[dpdk-dev] [PATCH v4] mem: command line option to delete hugepage backing files

2015-10-22 Thread Sergio Gonzalez Monroy
On 21/10/2015 18:21, shesha Sreenivasamurthy (shesha) wrote: > When an application using huge-pages crash or exists, the hugetlbfs > backing files are not cleaned up. This is a patch to clean those files. > There are multi-process DPDK applications that may be benefited by those > backing files. Th

[dpdk-dev] [PATCH v7 2/8] vhost-user: add VHOST_USER_GET_QUEUE_NUM message

2015-10-22 Thread Xie, Huawei
On 10/21/2015 11:48 AM, Yuanhan Liu wrote: > To tell the frontend (qemu) how many queue pairs we support. > > And it is initiated to VIRTIO_NET_CTRL_MQ_VQ_PAIRS_MAX. s/initiated/initialized/

[dpdk-dev] [PATCH v2 01/16] fm10k: add new vPMD file

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add new file fm10k_rxtx_vec.c and add it into compiling. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/Makefile |1 + drivers/net/fm10k/fm10k_rxtx_vec.c | 45 2 files changed, 46 insertions(+), 0 deletions(-)

[dpdk-dev] [PATCH v2 03/16] fm10k: Add a new func to initialize all parameters

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add new function fm10k_params_init to initialize all fm10k related variables. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k_ethdev.c | 34 ++ 1 files changed, 22 insertions(+), 12 deletions(-) diff --git a/drivers/net/

[dpdk-dev] [PATCH v2 05/16] fm10k: add 2 functions to parse pkt_type and offload flag

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add 2 functions, in which using SSE instructions to parse RX desc to get pkt_type and ol_flags in mbuf. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k_rxtx_vec.c | 127 1 files changed, 127 insertions(+), 0 deletions

[dpdk-dev] [PATCH v2 06/16] fm10k: add Vector RX function

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add func fm10k_recv_raw_pkts_vec to parse raw packets, in which includes possible chained packets. Add func fm10k_recv_pkts_vec to receive single mbuf packet. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h |1 + drivers/net/fm10k/fm10k_rxt

[dpdk-dev] [PATCH v2 07/16] fm10k: add func to do Vector RX condition check

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add func fm10k_rx_vec_condition_check to check if Vector RX func can be applied. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h |1 + drivers/net/fm10k/fm10k_rxtx_vec.c | 31 +++ 2 files changed, 32 insertions

[dpdk-dev] [PATCH v2 08/16] fm10k: add Vector RX scatter function

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add func fm10k_recv_scattered_pkts_vec to receive chained packets with SSE instructions. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h |2 + drivers/net/fm10k/fm10k_rxtx_vec.c | 88 2 files changed,

[dpdk-dev] [PATCH v2 00/16] Vector Rx/Tx PMD implementation for fm10k

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" v2: - Fix a typo issue - Fix an improper prefetch in vector RX function, in which prefetches un-initialized mbuf. - Remove limitation on number of desc pointer in vector RX function. - Re-organize some comments. - Add a new patch to fix a crash issue in vector RX

[dpdk-dev] [PATCH v2 10/16] fm10k: add func to release mbuf in case Vector RX applied

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Since Vector RX use different variables to trace RX HW ring, it leads to need different func to release mbuf properly. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h |1 + drivers/net/fm10k/fm10k_ethdev.c |6 ++ drivers/net/fm10k

[dpdk-dev] [PATCH v2 02/16] fm10k: add vPMD pre-condition check for each RX queue

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add condition check in rx_queue_setup func. If number of RX desc can't satisfy vPMD requirement, record it into a variable. Or call fm10k_rxq_vec_setup to initialize Vector RX. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h | 11 ---

[dpdk-dev] [PATCH v2 04/16] fm10k: add func to re-allocate mbuf for RX ring

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add function fm10k_rxq_rearm to re-allocate mbuf for used desc in RX HW ring. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h |9 drivers/net/fm10k/fm10k_ethdev.c |3 + drivers/net/fm10k/fm10k_rxtx_vec.c | 90 ++

[dpdk-dev] [PATCH v2 12/16] fm10k: use func pointer to reset TX queue and mbuf release

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Vector TX use different way to manage TX queue, it's necessary to use different functions to reset TX queue and release mbuf in TX queue. So, introduce 2 function pointers to do such ops. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h|9 +++

[dpdk-dev] [PATCH v2 09/16] fm10k: add function to decide best RX function

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add func fm10k_set_rx_function to decide best RX func in fm10k_dev_rx_init Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h|1 + drivers/net/fm10k/fm10k_ethdev.c | 36 2 files changed, 33 insertions(+),

[dpdk-dev] [PATCH v2 11/16] fm10k: add Vector TX function

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add Vector TX func fm10k_xmit_pkts_vec to transmit packets. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h |5 + drivers/net/fm10k/fm10k_rxtx_vec.c | 150 2 files changed, 155 insertions(+), 0 deletion

[dpdk-dev] [PATCH v2 14/16] fm10k: Add function to decide best TX func

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add func fm10k_set_tx_function to decide the best TX func in fm10k_dev_tx_init. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k.h|1 + drivers/net/fm10k/fm10k_ethdev.c | 38 -- 2 files changed, 37 insertio

[dpdk-dev] [PATCH v2 13/16] fm10k: introduce 2 funcs to reset TX queue and mbuf release

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add 2 funcs to reset TX queue and mbuf release when Vector TX applied. Signed-off-by: Chen Jing D(Mark) --- drivers/net/fm10k/fm10k_rxtx_vec.c | 68 1 files changed, 68 insertions(+), 0 deletions(-) diff --git a/drivers/net/fm10

[dpdk-dev] [PATCH v2 15/16] fm10k: fix a crash issue in vector RX func

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Vector RX function will process 4 packets at a time. When the RX ring wrapps to the tail and the left descriptor size is not multiple of 4, SW will overwrite memory that not belongs to it and cause crash. The fix will allocate additional 4 HW/SW spaces at the tail to avo

[dpdk-dev] [PATCH v2 16/16] doc: release notes update for fm10k Vector PMD

2015-10-22 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Update 2.2 release notes, add descriptions for Vector PMD implementation in fm10k driver. Signed-off-by: Chen Jing D(Mark) --- doc/guides/rel_notes/release_2_2.rst |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/doc/guides/rel_notes/releas

[dpdk-dev] [RFC PATCH v3 0/2] Add VHOST PMD

2015-10-22 Thread Tetsuya Mukawa
The patch introduces a new PMD. This PMD is implemented as thin wrapper of librte_vhost. I've submitted below patches in former patch sets. But it seems some issues were fixed already. - [PATCH 1/3] vhost: Fix return value of GET_VRING_BASE message - [PATCH 2/3] vhost: Fix RESET_OWNER handling

[dpdk-dev] [RFC PATCH v3 1/2] vhost: Add callback and private data for vhost PMD

2015-10-22 Thread Tetsuya Mukawa
These variables are needed to be able to manage one of virtio devices using both vhost library APIs and vhost PMD. For example, if vhost PMD uses current callback handler and private data provided by vhost library, A DPDK application that links vhost library cannot use some of vhost library APIs. T

[dpdk-dev] [RFC PATCH v3 2/2] vhost: Add VHOST PMD

2015-10-22 Thread Tetsuya Mukawa
The patch introduces a new PMD. This PMD is implemented as thin wrapper of librte_vhost. It means librte_vhost is also needed to compile the PMD. The vhost messages will be handled only when a port is started. So start a port first, then invoke QEMU. The PMD has 2 parameters. - iface: The parame

[dpdk-dev] [PATCH v7 4/8] vhost: rxtx: use queue id instead of constant ring index

2015-10-22 Thread Yuanhan Liu
On Wed, Oct 21, 2015 at 05:26:18PM +0300, Michael S. Tsirkin wrote: > On Wed, Oct 21, 2015 at 08:48:15PM +0800, Yuanhan Liu wrote: > > > Please note that for virtio devices, guest is supposed to > > > control the placement of incoming packets in RX queues. > > > > I may not follow you. > > > > En

[dpdk-dev] [PATCH v7 3/8] vhost: vring queue setup for multiple queue support

2015-10-22 Thread Xie, Huawei
On 10/21/2015 11:48 AM, Yuanhan Liu wrote: > All queue pairs, including the default (the first) queue pair, > are allocated dynamically, when a vring_call message is received > first time for a specific queue pair. > > This is a refactor work for enabling vhost-user multiple queue; > it should not

[dpdk-dev] [RFC PATCH v2] vhost: Add VHOST PMD

2015-10-22 Thread Tetsuya Mukawa
On 2015/10/21 19:22, Bruce Richardson wrote: > On Wed, Oct 21, 2015 at 09:25:12AM +0300, Panu Matilainen wrote: >> On 10/21/2015 07:35 AM, Tetsuya Mukawa wrote: >>> On 2015/10/19 22:27, Richardson, Bruce wrote: > -Original Message- > From: Panu Matilainen [mailto:pmatilai at redhat.

[dpdk-dev] [PATCH v7 1/8] vhost-user: add protocol features support

2015-10-22 Thread Xie, Huawei
On 10/21/2015 11:48 AM, Yuanhan Liu wrote: [...] > > VHOST_USER_PROTOCOL_FEATURES is initated to 0, as we don't support > s/initiated/initialized/

[dpdk-dev] Inconsistent statistics counters for pmd_i40e

2015-10-22 Thread Eimear Morrissey
Arnon Warshavsky wrote on 10/19/2015 03:46:22 PM: > From: Arnon Warshavsky > To: Eimear Morrissey/Ireland/IBM at IBMIE > Cc: dev at dpdk.org > Date: 10/19/2015 03:46 PM > Subject: Re: [dpdk-dev] Inconsistent statistics counters for pmd_i40e > > Hi Eimear > > This is the link I have. > https://

[dpdk-dev] [PATCH] tools: exit setup script without prompt

2015-10-22 Thread John McNamara
Exit tools/setup.sh script without prompting "Press enter to continue". The script can now be exited by typing the option number, "quit" or "q". Signed-off-by: John McNamara --- tools/setup.sh | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/tools/setup.sh b/t

[dpdk-dev] [PATCH v2 0/5] virtio: Tx performance improvements

2015-10-22 Thread Xie, Huawei
On 10/21/2015 9:20 PM, Thomas Monjalon wrote: > 2015-10-18 22:16, Stephen Hemminger: >> This is a tested version of the virtio Tx performance improvements >> that I posted earlier on the list, and described at the DPDK Userspace >> meeting in Dublin. Together they get a 25% performance improvement

[dpdk-dev] ixgbe: ierrors counter spuriously increasing in DPDK 2.1

2015-10-22 Thread Andriy Berestovskyy
Hi Martin, We agreed on the main point: it's an issue. IMO the implementation details are up to Maryam. There have been few patches, so I guess it will be fixed in 2.2. Andriy On Thu, Oct 22, 2015 at 9:46 AM, Martin Weiser wrote: > Hi Andriy, > > thank you for pointing this discussion out to m

[dpdk-dev] Inconsistent statistics counters for pmd_i40e

2015-10-22 Thread Arnon Warshavsky
You are right. Given this thread updated today http://dpdk.org/ml/archives/dev/2015-September/023480.html (updates from today still not there) It seems I was too quick to jump to conclusion. Just in case, when bound to i40e, can you run ethtool -i on that interface? It should show the fw version.

[dpdk-dev] [PATCH v7 3/8] vhost: vring queue setup for multiple queue support

2015-10-22 Thread Yuanhan Liu
On Thu, Oct 22, 2015 at 09:49:58AM +, Xie, Huawei wrote: > On 10/21/2015 11:48 AM, Yuanhan Liu wrote: > > All queue pairs, including the default (the first) queue pair, > > are allocated dynamically, when a vring_call message is received > > first time for a specific queue pair. > > > > This is

[dpdk-dev] [PATCH v7 4/8] vhost: rxtx: use queue id instead of constant ring index

2015-10-22 Thread Michael S. Tsirkin
On Thu, Oct 22, 2015 at 05:49:55PM +0800, Yuanhan Liu wrote: > On Wed, Oct 21, 2015 at 05:26:18PM +0300, Michael S. Tsirkin wrote: > > On Wed, Oct 21, 2015 at 08:48:15PM +0800, Yuanhan Liu wrote: > > > > Please note that for virtio devices, guest is supposed to > > > > control the placement of inco

[dpdk-dev] [PATCH v3 7/7] virtio: pick simple rx/tx func

2015-10-22 Thread Xie, Huawei
On 10/22/2015 10:50 AM, Tan, Jianfeng wrote: > On 10/22/2015 10:45 AM, Jianfeng wrote: > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Huawei Xie >> Sent: Tuesday, October 20, 2015 11:30 PM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH v3 7/7] virti

[dpdk-dev] [PATCH v3 2/4] nfp-uio: new uio driver for netronome nfp6000 card

2015-10-22 Thread Alejandro Lucero
Submitting just the PMD for integration makes sense. I will remove all the references to nfp_uio. My doubt is with documentation. Working with the NFP PMD will not be possible without nfp_uio. We could modify the documentation saying it is possible to use igb_uio, but this is not the right thing t

[dpdk-dev] volunteer to be the maintainer of driver/net/intel sub-tree

2015-10-22 Thread Lu, Wenzhuo
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, October 22, 2015 4:17 PM > To: Lu, Wenzhuo > Cc: dev at dpdk.org; Zhang, Helin; Richardson, Bruce > Subject: Re: volunteer to be the maintainer of driver/net/intel sub-tree > >

[dpdk-dev] [PATCHv6 0/9] ethdev: add new API to retrieve RX/TX queue information

2015-10-22 Thread Konstantin Ananyev
Add the ability for the upper layer to query: 1) configured RX/TX queue information. 2) information about RX/TX descriptors min/max/align numbers per queue for the device. v2 changes: - Add formal check for the qinfo input parameter. - As suggested rename 'rx_qinfo/tx_qinfo' to 'rxq_info/txq_info'

[dpdk-dev] [PATCHv6 1/9] ethdev: add new API to retrieve RX/TX queue information

2015-10-22 Thread Konstantin Ananyev
From: "Ananyev, Konstantin" Add the ability for the upper layer to query RX/TX queue information. Add into rte_eth_dev_info new fields to represent information about RX/TX descriptors min/max/alig nnumbers per queue for the device. Add new structures: struct rte_eth_rxq_info struct rte_eth_txq_i

[dpdk-dev] [PATCHv6 6/9] cxgbe: add HW specific desc_lim data into dev_info

2015-10-22 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- drivers/net/cxgbe/cxgbe_ethdev.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c index a8e057b..920e071 100644 --- a/drivers/net/cxgbe/cxgbe_ethdev.c +++ b/drivers/net/cxgbe/cxgb

[dpdk-dev] [PATCHv6 4/9] e1000: add support for eth_(rxq|txq)_info_get and (rx|tx)_desc_lim

2015-10-22 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- drivers/net/e1000/e1000_ethdev.h | 36 drivers/net/e1000/em_ethdev.c| 14 drivers/net/e1000/em_rxtx.c | 71 +++- drivers/net/e1000/igb_ethdev.c | 22 + drivers/net/e1000/

[dpdk-dev] [PATCHv6 8/9] testpmd: add new command to display RX/TX queue information

2015-10-22 Thread Konstantin Ananyev
From: "Ananyev, Konstantin" Signed-off-by: Konstantin Ananyev --- app/test-pmd/cmdline.c | 48 +++ app/test-pmd/config.c | 77 ++ app/test-pmd/testpmd.h | 2 ++ 3 files changed, 127 insertions(+) diff --git a/app/tes

[dpdk-dev] [PATCHv6 9/9] doc: release notes update for queue_info_get()

2015-10-22 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- doc/guides/rel_notes/release_2_2.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/release_2_2.rst index 4f75cff..33ea399 100644 --- a/doc/guides/rel_notes/release_2_2.rst +++ b/doc/gui

[dpdk-dev] [PATCHv6 2/9] i40e: add support for eth_(rxq|txq)_info_get and (rx|tx)_desc_lim

2015-10-22 Thread Konstantin Ananyev
This patch assumes that the patch: i40e: fix wrong alignment for the number of HW descriptors already applied. Signed-off-by: Konstantin Ananyev --- drivers/net/i40e/i40e_ethdev.c| 14 ++ drivers/net/i40e/i40e_ethdev.h| 5 + drivers/net/i40e/i40e_ethdev_vf.c | 12 +++

[dpdk-dev] [PATCHv6 5/9] fm10k: add HW specific desc_lim data into dev_info

2015-10-22 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- drivers/net/fm10k/fm10k_ethdev.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c index a69c990..9588dab 100644 --- a/drivers/net/fm10k/fm10k_ethdev.c +++ b/drivers/net/fm10k/

[dpdk-dev] [PATCHv6 7/9] vmxnet3: add HW specific desc_lim data into dev_info

2015-10-22 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index a70be5c..3745b7d 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++ b/

[dpdk-dev] [PATCHv6 3/9] ixgbe: add support for eth_(rxq|txq)_info_get and (rx|tx)_desc_lim

2015-10-22 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- drivers/net/ixgbe/ixgbe_ethdev.c | 23 ++ drivers/net/ixgbe/ixgbe_ethdev.h | 6 drivers/net/ixgbe/ixgbe_rxtx.c | 68 +--- drivers/net/ixgbe/ixgbe_rxtx.h | 21 + 4 files changed, 93 insertio

[dpdk-dev] [PATCH v4 0/7] virtio ring layout optimization and simple rx/tx processing

2015-10-22 Thread Huawei Xie
Changes in v2: - Remove the configure macro - Enable simple R/TX processing when user specifies simple txq flags - Reword some comments and commit messages Changes in v3: - Remove unnecessary NULL test for rte_free - Remove unnecessary assign of local var after free - Remove return at the end of v

[dpdk-dev] [PATCH v4 1/7] virtio: add virtio_rxtx.h header file

2015-10-22 Thread Huawei Xie
Would move all rx/tx related declarations into this header file in future. Add RTE_VIRTIO_PMD_MAX_BURST. Signed-off-by: Huawei Xie --- drivers/net/virtio/virtio_ethdev.c | 1 + drivers/net/virtio/virtio_rxtx.c | 1 + drivers/net/virtio/virtio_rxtx.h | 34 ++

[dpdk-dev] [PATCH v4 3/7] virtio: rx/tx ring layout optimization

2015-10-22 Thread Huawei Xie
Changes in V4: - fix the error in tx ring layout chart in this commit message. In DPDK based switching envrioment, mostly vhost runs on a dedicated core while virtio processing in guest VMs runs on different cores. Take RX for example, with generic implementation, for each guest buffer, a) virtio

[dpdk-dev] [PATCH v4 2/7] virtio: add software rx ring, fake_buf into virtqueue

2015-10-22 Thread Huawei Xie
Changes in v3: - Remove unnecessary NULL test for rte_free - Remove unnecessary assign of local var vq after free Add software RX ring in virtqueue. Add fake_mbuf in virtqueue for wraparound processing. Use global simple_rxtx to indicate whether simple rxtx is enabled Signed-off-by: Huawei Xie -

[dpdk-dev] [PATCH v4 4/7] virtio: fill RX avail ring with blank mbufs

2015-10-22 Thread Huawei Xie
fill avail ring with blank mbufs in virtio_dev_vring_start Signed-off-by: Huawei Xie --- drivers/net/virtio/Makefile | 2 +- drivers/net/virtio/virtio_rxtx.c| 6 ++- drivers/net/virtio/virtio_rxtx.h| 3 ++ drivers/net/virtio/virtio_rxtx_simple.c | 84 ++

[dpdk-dev] [PATCH v4 5/7] virtio: virtio vec rx

2015-10-22 Thread Huawei Xie
With fixed avail ring, we don't need to get desc idx from avail ring. virtio driver only has to deal with desc ring. This patch uses vector instruction to accelerate processing desc ring. Signed-off-by: Huawei Xie --- drivers/net/virtio/virtio_ethdev.h | 2 + drivers/net/virtio/virtio_rxt

[dpdk-dev] [PATCH v4 6/7] virtio: simple tx routine

2015-10-22 Thread Huawei Xie
Changes in v4: - move virtio_xmit_cleanup ahead to free descriptors earlier Changes in v3: - Remove return at the end of void function - Remove always_inline attribute for virtio_xmit_cleanup bulk free of mbufs when clean used ring. shift operation of idx could be saved if vq_free_cnt means free s

[dpdk-dev] [PATCH v4 7/7] virtio: pick simple rx/tx func

2015-10-22 Thread Huawei Xie
Changes in v4: Check merge-able feature when select simple rx/tx functions. simple rx/tx func is chose when merge-able rx is disabled and user specifies single segment and no offload support. Signed-off-by: Huawei Xie --- drivers/net/virtio/virtio_rxtx.c | 15 +++ 1 file changed, 1

[dpdk-dev] [PATCH v2 0/5] virtio: Tx performance improvements

2015-10-22 Thread Xie, Huawei
On 10/22/2015 6:39 PM, Xie, Huawei wrote: > On 10/21/2015 9:20 PM, Thomas Monjalon wrote: >> 2015-10-18 22:16, Stephen Hemminger: >>> This is a tested version of the virtio Tx performance improvements >>> that I posted earlier on the list, and described at the DPDK Userspace >>> meeting in Dublin.

[dpdk-dev] [PATCH v8 0/8] vhost-user multiple queues enabling

2015-10-22 Thread Yuanhan Liu
This patch set enables vhost-user multiple queue feature. v8: - put SET_VRING_ENABLE() patch before the patch actually enable mq, since that make more sense. - don't change the kickfd reset behavior for patch 3 - move virt_queue field to the end of virtio_net struct. - commen

[dpdk-dev] [PATCH v8 1/8] vhost-user: add protocol features support

2015-10-22 Thread Yuanhan Liu
The two protocol features messages are introduced by qemu vhost maintainer(Michael) for extendting vhost-user interface. Here is an excerpta from the vhost-user spec: Any protocol extensions are gated by protocol feature bits, which allows full backwards compatibility on both master an

[dpdk-dev] [PATCH v8 2/8] vhost-user: add VHOST_USER_GET_QUEUE_NUM message

2015-10-22 Thread Yuanhan Liu
To tell the frontend (qemu) how many queue pairs we support. And it is initiated to VIRTIO_NET_CTRL_MQ_VQ_PAIRS_MAX. Signed-off-by: Yuanhan Liu Acked-by: Flavio Leitner --- lib/librte_vhost/vhost_user/vhost-net-user.c | 7 +++ lib/librte_vhost/vhost_user/vhost-net-user.h | 1 + 2 files cha

[dpdk-dev] [PATCH v8 4/8] vhost: rxtx: use queue id instead of constant ring index

2015-10-22 Thread Yuanhan Liu
From: Changchun Ouyang Do not use VIRTIO_RXQ or VIRTIO_TXQ anymore; use the queue_id instead, which will be set to a proper value for a specific queue when we have multiple queue support enabled. For now, queue_id is still set with VIRTIO_RXQ or VIRTIO_TXQ, so it should not break anything. Sign

[dpdk-dev] [PATCH v8 5/8] virtio: fix deadloop due to reading virtio_net_config incorrectly

2015-10-22 Thread Yuanhan Liu
From: Changchun Ouyang The old code adjusts the config bytes we want to read depending on what kind of features we have, but we later cast the entire buf we read with "struct virtio_net_config", which is obviously wrong. The wrong config reading results to a dead loop at virtio_send_command() wh

[dpdk-dev] [PATCH v8 3/8] vhost: vring queue setup for multiple queue support

2015-10-22 Thread Yuanhan Liu
All queue pairs, including the default (the first) queue pair, are allocated dynamically, when a vring_call message is received first time for a specific queue pair. This is a refactor work for enabling vhost-user multiple queue; it should not break anything as it does no functional changes: we do

  1   2   >