[dpdk-dev] [PATCH v3] fm10k: fix wrong VLAN value in RX mbuf

2015-11-20 Thread Shaopeng He
vlan_tci should be copied from RX descriptor to mbuf, and flag PKT_RX_VLAN_PKT should be set for every RX packet, this patch fixes this issue. Packets in fm10k device always carry at least one VLAN tag. For those packets coming in without VLAN tag, the port default VLAN tag will be used. So in fm10

[dpdk-dev] [PATCH v3 1/6] szedata2: add new poll mode driver

2015-11-20 Thread Matej Vido
Hi, 2015-11-20 16:04 GMT+01:00 Thomas Monjalon : > Hi, > > I'm doing some last checks before merging. > > The libsze2 depends on libcommlbr so it would be better to list it on > https://www.liberouter.org/technologies/netcope/access-to-libsze2-library Thank you for reminding, I will edit it.

[dpdk-dev] [PATCH v4 2/2] vhost: Add VHOST PMD

2015-11-20 Thread Yuanhan Liu
On Fri, Nov 13, 2015 at 02:20:31PM +0900, Tetsuya Mukawa wrote: > +static pthread_mutex_t internal_list_lock = PTHREAD_MUTEX_INITIALIZER; > + > +static rte_atomic16_t nb_started_ports; > +pthread_t session_th; static? > + > +static struct rte_eth_link pmd_link = { > + .link_speed

[dpdk-dev] [PATCH] ring: Fix memory leakage in rte_pmd_ring_devuninit

2015-11-20 Thread Mauricio Vasquez B
When freeing the device it is also neccesary to free rx_queues and tx_queues Signed-off-by: Mauricio Vasquez B --- v2: Added extra control before freeing members of eth_dev->data drivers/net/ring/rte_eth_ring.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH] ring: Fix memory leakage in rte_pmd_ring_devuninit()

2015-11-20 Thread Mauricio Vásquez
On 20 November 2015 at 13:42, Richardson, Bruce wrote: > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Mcnamara, John > > Sent: Friday, November 20, 2015 12:32 PM > > To: Mauricio Vasquez B ; > > dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] ri

[dpdk-dev] [PATCH v2] vhost: Fix reset_owner message handling not to clear callfd

2015-11-20 Thread Yuanhan Liu
On Thu, Nov 19, 2015 at 06:07:00PM +0900, Tetsuya Mukawa wrote: > The patch fixes reset_owner message handling not to clear callfd, > because callfd will be valid while connection is establihed. > > Signed-off-by: Tetsuya Mukawa > > /* > @@ -467,6 +486,7 @@ static int > reset_owner(struc

[dpdk-dev] |ERROR| pw 9018 ethdev: add a missing sanity check for nb_tx_desc during txq setup

2015-11-20 Thread Rahul Lakkireddy
Hi all, I received this auto email regarding 'Unexpected Packets Drop' and it is referring to my patch. I don't think I've changed anything that could cause this. Kindly advise. Thanks, Rahul On Friday, November 11/20/15, 2015 at 03:14:51 -0800, sys_stv at intel.com wrote: > Test-Label: Intel

[dpdk-dev] [PATCH 2/2] cxgbe: fix unnecessary spinning for a lock with trylock instead

2015-11-20 Thread Rahul Lakkireddy
CXGBE PMD depends on an alarm to periodically transmit any pending coalesced packets and hence spins for a lock for each tx queue in the alarm callback. A better solution is to try to get a lock whenever possible, instead of spinning for it. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar S

[dpdk-dev] [PATCH 1/2] cxgbe: fix queue setup failure due to strict min desc requirement

2015-11-20 Thread Rahul Lakkireddy
Most dpdk examples and apps seem to initialize with a minimum of 128 rx descriptors and 512 tx descriptors for queue setup. However, CXGBE PMD enforces a minimum of 1024 descriptors. This causes the dpdk stack to return -EINVAL because the apps do not request the minimum required. The fix is to

[dpdk-dev] [PATCH 0/2] cxgbe: Minor fixes in cxgbe pmd

2015-11-20 Thread Rahul Lakkireddy
This series of patches fix some issues and recent regressions in cxgbe pmd. Patch 1 fixes a regression where queue setup for cxgbe pmd fails with -EINVAL because cxgbe pmd requires a min of 1024 descriptors, but most examples and apps initialize with 128 rx descriptors and 512 tx descriptors. Pat

[dpdk-dev] [PATCH] eal: fix compile error for old glibc caused by CLOCK_MONOTONIC_RAW

2015-11-20 Thread Thomas Monjalon
2015-11-19 11:23, Ferruh Yigit: > Fixes: d08d304508a8 ("eal/linux: make alarm not affected by system time > jump") > > CLOCK_MONOTONIC_RAW added in glibc 2.12, using this define in older > glibc versions cause compile error: > 'error: identifier "CLOCK_MONOTONIC_RAW" is undefined' > > This patch

[dpdk-dev] [PATCH] eal: fix plugindir processing to be filesystem agnostic

2015-11-20 Thread David Marchand
Hello Panu, On Wed, Nov 18, 2015 at 7:45 AM, Panu Matilainen wrote: > Not all filesystems supply struct dirent d_type field, in which case > everything in the specified directory would go ignored. One such > filesystem being XFS which RHEL 7 defaults to... stat() the entries > instead. > > Fixes

[dpdk-dev] Mellanox dpdk issues

2015-11-20 Thread Sotiris Salloumis
Hi all, I'm trying to build DPDK for Mellanox ( using MLNX_DPDK-2.1_1.1 ) but I get the following error following the guidelines i.e. make install T=x86_64-native-linuxapp-gcc == Build lib/librte_eal/linuxapp/igb_uio make[8]: *** /lib/modules/3.12.28-4-default/build: No such file or directory.

[dpdk-dev] [PATCH 1/2] doc: announce ABI change for cmdline buffer size

2015-11-20 Thread Olivier MATZ
Hi N?lio, On 11/10/2015 06:29 PM, Mcnamara, John wrote: > > >> -Original Message- >> From: Nelio Laranjeiro [mailto:nelio.laranjeiro at 6wind.com] >> Sent: Monday, November 9, 2015 4:48 PM >> To: dev at dpdk.org >> Cc: olivier.matz at 6wind.com; thomas.monjalon at 6wind.com; Mcnamara, Jo

[dpdk-dev] [PATCH v7 06/10] mbuf_offload: library to support attaching offloads to a mbuf

2015-11-20 Thread Declan Doherty
Hey Oliver, see reply inline. On 20/11/15 15:27, Olivier MATZ wrote: > Hi Declan, > > Please find some comments below. > > On 11/13/2015 07:58 PM, Declan Doherty wrote: >> This library add support for adding a chain of offload operations to a >> mbuf. It contains the definition of the rte_mbuf_of

[dpdk-dev] [PATCH v3 0/6] Virtual PMD using sze2 layer for COMBO cards

2015-11-20 Thread Thomas Monjalon
2015-11-10 15:18, Matej Vido: > This is virtual PMD which communicates with COMBO-80G and COMBO-100G > cards through sze2 layer. Communication with COMBO card is managed > through interface provided by libsze2 library and kernel modules > (combov3, szedata2_cv3). > > To compile and use PMD, it is

[dpdk-dev] [PATCH] vhost-user: fix enabling of queue pair

2015-11-20 Thread Victor Kaplansky
On Fri, Nov 20, 2015 at 03:45:00PM +0200, Victor Kaplansky wrote: > The VHOST_USER_SET_VRING_ENABLE request is sent for each queue in > queue-pair separately. So, a queue-pair should be considered > enabled only when both RX and TX queues are enabled. > > The old code caused segfault when last TX

[dpdk-dev] [PATCH] mk: fix extra options when linking lib through compiler

2015-11-20 Thread Thomas Monjalon
2015-11-20 16:40, Olivier MATZ: > On 11/20/2015 03:02 PM, Thomas Monjalon wrote: > > When using a linker option not known by the compiler like -rpath, > > the library linkage was failing. > > It is fixed by prefixing the option with -Wl, as it is done in other > > makefiles. > > > > Signed-off-by:

[dpdk-dev] [PATCH v9 3/3] doc: add user-space ethtool sample app guide

2015-11-20 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton > Sent: Friday, November 20, 2015 3:35 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v9 3/3] doc: add user-space ethtool sample app > guide > > Signed-off-by: Remy Horton > --- Acked-by:

[dpdk-dev] [PATCH v2] ACL: fix build for native-icc target on haswell fails

2015-11-20 Thread Thomas Monjalon
2015-11-20 15:59, Declan Doherty: > On 20/11/15 15:38, Konstantin Ananyev wrote: > > On HSW box with icc 16.0.0 build for x86_64-native-linuxapp-icc fails with: > > icc: command line warning #10120: overriding '-march=native' with '-msse4.1' > > ... > > dpdk.org/x86_64-native-linuxapp-icc/include/r

[dpdk-dev] [PATCH v9 2/3] example: add user-space ethtool sample application

2015-11-20 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton > Sent: Friday, November 20, 2015 3:35 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v9 2/3] example: add user-space ethtool sample > application > > Further enhancements to the userspace

[dpdk-dev] [PATCH] mk: fix compilation for icc version 16

2015-11-20 Thread Thomas Monjalon
2015-11-20 16:34, Olivier MATZ: > On 11/20/2015 03:34 PM, Declan Doherty wrote: > > This patch changes the ICC conditional check to disable > > -no-inline-max-size and -no-inline-max-total-size to be > > for all versions of icc greater than 14 and not just for version 15. > > > > Signed-off-by: De

[dpdk-dev] [PATCH] mk: fix extra options when linking lib through compiler

2015-11-20 Thread Olivier MATZ
Hi, On 11/20/2015 03:02 PM, Thomas Monjalon wrote: > When using a linker option not known by the compiler like -rpath, > the library linkage was failing. > It is fixed by prefixing the option with -Wl, as it is done in other > makefiles. > > Signed-off-by: Thomas Monjalon > --- > mk/rte.lib.mk

[dpdk-dev] [PATCH] mk: fix compilation for icc version 16

2015-11-20 Thread Olivier MATZ
Hi, On 11/20/2015 03:34 PM, Declan Doherty wrote: > This patch changes the ICC conditional check to disable > -no-inline-max-size and -no-inline-max-total-size to be > for all versions of icc greater than 14 and not just for version 15. > > Signed-off-by: Declan Doherty > --- > mk/toolchain/icc

[dpdk-dev] [PATCH 1/2] doc: announce ABI change for cmdline buffer size

2015-11-20 Thread Bruce Richardson
On Fri, Nov 20, 2015 at 05:28:43PM +0100, Olivier MATZ wrote: > Hi N?lio, > > On 11/10/2015 06:29 PM, Mcnamara, John wrote: > > > > > >> -Original Message- > >> From: Nelio Laranjeiro [mailto:nelio.laranjeiro at 6wind.com] > >> Sent: Monday, November 9, 2015 4:48 PM > >> To: dev at dpdk.

[dpdk-dev] [PATCH] mk: pass EXTRA_CFLAGS to AUTO_CPUFLAGS to enable local modifications

2015-11-20 Thread Olivier MATZ
Hi Simon, On 11/18/2015 08:53 AM, Simon Kagstrom wrote: > We have encountered a CPU where the AES-NI instruction set is disabled > due to export restrictions. Since the build machine and target machine > is different, using -native configs doesn't work, and on this CPU, the > application refuses t

[dpdk-dev] [PATCH v9 1/3] Remove ABI requirement for external library builds.

2015-11-20 Thread Wang, Liang-min
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton > Sent: Friday, November 20, 2015 3:35 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v9 1/3] Remove ABI requirement for external > library builds. > > Signed-off-by: Andrew G. Harvey > ---

[dpdk-dev] [PATCH v7 06/10] mbuf_offload: library to support attaching offloads to a mbuf

2015-11-20 Thread Olivier MATZ
Hi Declan, Please find some comments below. On 11/13/2015 07:58 PM, Declan Doherty wrote: > This library add support for adding a chain of offload operations to a > mbuf. It contains the definition of the rte_mbuf_offload structure as > well as helper functions for attaching offloads to mbufs an

[dpdk-dev] [PATCH v4 2/2] vhost: Add VHOST PMD

2015-11-20 Thread Rich Lane
On Thu, Nov 12, 2015 at 9:20 PM, Tetsuya Mukawa wrote: > +static uint16_t > +eth_vhost_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs) > +{ > ... > + > + /* Enqueue packets to guest RX queue */ > + nb_tx = rte_vhost_enqueue_burst(r->device, > + r->virtqueu

[dpdk-dev] [PATCH v3 1/6] szedata2: add new poll mode driver

2015-11-20 Thread Thomas Monjalon
Hi, I'm doing some last checks before merging. The libsze2 depends on libcommlbr so it would be better to list it on https://www.liberouter.org/technologies/netcope/access-to-libsze2-library A patch is needed in mk/ to allow linking these dependencies from a non-standard directory: http://dpdk.o

[dpdk-dev] [PATCH v2] ACL: fix build for native-icc target on haswell fails

2015-11-20 Thread Declan Doherty
On 20/11/15 15:38, Konstantin Ananyev wrote: > On HSW box with icc 16.0.0 build for x86_64-native-linuxapp-icc fails with: > icc: command line warning #10120: overriding '-march=native' with '-msse4.1' > ... > dpdk.org/x86_64-native-linuxapp-icc/include/rte_memcpy.h(96): error: > identifier "__m

[dpdk-dev] [PATCH] ethdev: add a missing sanity check for nb_tx_desc during txq setup

2015-11-20 Thread Rahul Lakkireddy
Add a sanity check for number of tx descriptors requested during tx queue setup. Return -EINVAL if the number requested does not meet the tx descriptor requirements of the device. Fixes: 80a1deb4c77a ("ethdev: add API to retrieve queue information") Signed-off-by: Rahul Lakkireddy Signed-off-by

[dpdk-dev] [PATCH] vhost-user: fix enabling of queue pair

2015-11-20 Thread Victor Kaplansky
The VHOST_USER_SET_VRING_ENABLE request is sent for each queue in queue-pair separately. So, a queue-pair should be considered enabled only when both RX and TX queues are enabled. The old code caused segfault when last TX queue was enabled. Signed-off-by: Victor Kaplansky --- lib/librte_vhost/v

[dpdk-dev] [PATCH v2] ACL: fix build for native-icc target on haswell fails

2015-11-20 Thread Konstantin Ananyev
On HSW box with icc 16.0.0 build for x86_64-native-linuxapp-icc fails with: icc: command line warning #10120: overriding '-march=native' with '-msse4.1' ... dpdk.org/x86_64-native-linuxapp-icc/include/rte_memcpy.h(96): error: identifier "__m256i" is undefined The reason is that icc treats "-march

[dpdk-dev] [PATCH v9 3/3] doc: add user-space ethtool sample app guide

2015-11-20 Thread Remy Horton
Signed-off-by: Remy Horton --- doc/guides/rel_notes/release_2_2.rst | 1 + doc/guides/sample_app_ug/ethtool.rst | 160 +++ doc/guides/sample_app_ug/index.rst | 1 + 3 files changed, 162 insertions(+) create mode 100644 doc/guides/sample_app_ug/ethtool.rst d

[dpdk-dev] [PATCH v9 2/3] example: add user-space ethtool sample application

2015-11-20 Thread Remy Horton
Further enhancements to the userspace ethtool implementation that was submitted in 2.1 and packaged as a self-contained sample application. Implements an rte_ethtool shim layer based on rte_ethdev API, along with a command prompt driven demonstration application. Signed-off-by: Remy Horton --- M

[dpdk-dev] [PATCH v9 1/3] Remove ABI requirement for external library builds.

2015-11-20 Thread Remy Horton
Signed-off-by: Andrew G. Harvey --- mk/rte.extlib.mk | 2 ++ mk/rte.lib.mk| 6 ++ 2 files changed, 8 insertions(+) diff --git a/mk/rte.extlib.mk b/mk/rte.extlib.mk index ba066bc..4d459e4 100644 --- a/mk/rte.extlib.mk +++ b/mk/rte.extlib.mk @@ -31,6 +31,8 @@ MAKEFLAGS += --no-print-dire

[dpdk-dev] [PATCH v9 0/3] User-space ethtool sample application

2015-11-20 Thread Remy Horton
Further enhancements to the userspace ethtool implementation that was submitted in 2.1 and packaged as a self-contained sample application. Implements an rte_ethtool shim layer based on rte_ethdev API, along with a command prompt driven demonstration application. This patchset depends on: * http:/

[dpdk-dev] [PATCH 17/17] ixgbe: add new device X550T1

2015-11-20 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- lib/librte_eal/common/include/rte_pci_dev_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_eal/common/include/rte_pci_dev_ids.h b/lib/librte_eal/common/include/rte_pci_dev_ids.h index e31b934..d088191 100644 --- a/lib/librte_eal/common/include/

[dpdk-dev] [PATCH 16/17] ixgbe/base: new defines for FW

2015-11-20 Thread Wenzhuo Lu
This patch addes some new defines for FW, and includes some minor change. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/base/ixgbe_common.c | 5 + drivers/net/ixgbe/base/ixgbe_phy.c| 4 +--- drivers/net/ixgbe/base/ixgbe_type.h | 39 +++ drivers/net/i

[dpdk-dev] [PATCH 15/17] ixgbe/base: prevent KR PHY reset in init

2015-11-20 Thread Wenzhuo Lu
This patch removes KR PHY reset from ixgbe_init_phy_ops_X550em. Since this function is meant to initialize function pointers for detected PHY type. Internal PHY reset was moved to ixgbe_setup_internal_phy_t_x550em which will now detect which mode does internal PHY work in, and setup it as required.

[dpdk-dev] [PATCH 14/17] ixgbe/base: add new iXFI configuration helper function

2015-11-20 Thread Wenzhuo Lu
This patch should allow native SPI SFP+ to work as we understand it now. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/base/ixgbe_x550.c | 86 ++--- 1 file changed, 52 insertions(+), 34 deletions(-) diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/ne

[dpdk-dev] [PATCH 13/17] ixgbe/base: support new thermal alarm

2015-11-20 Thread Wenzhuo Lu
This patch adds support for the new thermal sensor alarms indication. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/base/ixgbe_type.h | 4 drivers/net/ixgbe/base/ixgbe_x550.c | 22 +++--- 2 files changed, 23 insertions(+), 3 deletions(-) diff --git a/drivers/net/ixgbe/ba

[dpdk-dev] [PATCH 12/17] ixgbe/base: fill at least min credits to a TC credit refills

2015-11-20 Thread Wenzhuo Lu
Currently credit_refill and credit_max could be zero for a TC and that is causing Tx hang for CEE mode configuration, so to fix that have at min credit assigned to a TC and that is as what IEEE mode already does. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/base/ixgbe_dcb.c | 9 ++--- 1 f

[dpdk-dev] [PATCH 11/17] ixgbe/base: configure x550 MDIO clock speed

2015-11-20 Thread Wenzhuo Lu
The x550 MDIO clock speed must be configured prior to first MDIO read or write. The default MDIO clock speed is not valid, therefore the driver is configuring a valid speed prior to reading the copper PHY device id. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/base/ixgbe_x550.c | 16 +++--

[dpdk-dev] [PATCH 10/17] ixgbe/base: check mac type for iosf and phy

2015-11-20 Thread Wenzhuo Lu
Check mac type when accessing iosf registers and using the PHY token for PHY access. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/base/ixgbe_x550.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixg

[dpdk-dev] [PATCH 09/17] ixgbe/base: add flow director drop queue

2015-11-20 Thread Wenzhuo Lu
This patch adds ixgbe_set_fdir_drop_queue_82599 for enabling and setting flow director drop queue, and adds sets drop no match in ixgbe_init_fdir_perfect_82599 for x550. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/base/ixgbe_82599.c | 38 +++- drivers/net/ixgb

[dpdk-dev] [PATCH 08/17] ixgbe/base: add KR mode support

2015-11-20 Thread Wenzhuo Lu
KR auto-neg mode is what we will be using going forward. The SW interface for this mode is different than what was used for iXFI. While debugging, it was determined that the ucode diagnostic was no longer needed. This code has been removed to simplify the init flow. A subtle semaphore error in th

[dpdk-dev] [PATCH 07/17] ixgbe/base: add Flow Control Ethertype to ETQF filter list

2015-11-20 Thread Wenzhuo Lu
This patch adds the flow control ethertype to the defines for the ETQF filter list. This only adds the define. Each driver can add this ethertype to the filter. This is needed to prevent denial of service by malicious VFs sending out flow control packets. Signed-off-by: Wenzhuo Lu --- drivers/ne

[dpdk-dev] [PATCH 06/17] ixgbe/base: remove driver config of KX4 PHY

2015-11-20 Thread Wenzhuo Lu
The KX4 PHY will be configured by the NVM image. The driver had been overwriting this config. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/base/ixgbe_phy.c | 2 +- drivers/net/ixgbe/base/ixgbe_type.h | 11 --- drivers/net/ixgbe/base/ixgbe_x550.c | 39 +---

[dpdk-dev] [PATCH 05/17] ixgbe/base: add Single-port Sage Pond device ID

2015-11-20 Thread Wenzhuo Lu
Adds a new Sage Pond device X550T1. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/base/ixgbe_api.c| 1 + drivers/net/ixgbe/base/ixgbe_common.c | 1 + drivers/net/ixgbe/base/ixgbe_type.h | 1 + drivers/net/ixgbe/base/ixgbe_x550.c | 4 ++-- 4 files changed, 5 insertions(+), 2 deletions(-

[dpdk-dev] [PATCH 04/17] ixgbe/base: use mvals values instead of defines

2015-11-20 Thread Wenzhuo Lu
This patch changes code to use registers offsets stored in mvals table instead of values defined statically. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/base/ixgbe_82599.c | 4 +-- drivers/net/ixgbe/base/ixgbe_common.c | 58 +-- drivers/net/ixgbe/base/ixgbe_

[dpdk-dev] [PATCH 03/17] ixgbe/base: do not wait for signature rule addition

2015-11-20 Thread Wenzhuo Lu
Waiting for FDIRCMD completion is an expensive thing to do in the transmit hot path. This wait was added to catch problems with perfect filter rules, and, at least in the Linux driver, there is no error check anyway, so there is no point to adding the delay. So do not wait for completion. Change th

[dpdk-dev] [PATCH 02/17] ixgbe/base: avoid needless PHY access on copper phys

2015-11-20 Thread Wenzhuo Lu
Avoid a needless PHY access on copper phys to save the 10ms wait time for each PHY access. A helper function is introduced to actually do the register access and process the contents. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/base/ixgbe_phy.c | 72 ++--- dr

[dpdk-dev] [PATCH 01/17] ixgbe/base: update README

2015-11-20 Thread Wenzhuo Lu
Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/base/README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/base/README b/drivers/net/ixgbe/base/README index cec48a6..5d66f86 100644 --- a/drivers/net/ixgbe/base/README +++ b/drivers/net/ixgbe/base/README @

[dpdk-dev] [PATCH 00/17] Update ixgbe base code

2015-11-20 Thread Wenzhuo Lu
Short summary: *update README *avoid needless PHY access on copper phys *do not wait for signature rule addition *use mvals values instead of defines *add Single-port Sage Pond device ID *remove driver config of KX4 PHY *add Flow Control Ethertype to ETQF filter list *add KR mode support *add flow

[dpdk-dev] [PATCH] mk: fix extra options when linking lib through compiler

2015-11-20 Thread Thomas Monjalon
When using a linker option not known by the compiler like -rpath, the library linkage was failing. It is fixed by prefixing the option with -Wl, as it is done in other makefiles. Signed-off-by: Thomas Monjalon --- mk/rte.lib.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/mk/rte.lib.mk b/

[dpdk-dev] [PATCH v6 3/4] bond mode 4: allow external state machine

2015-11-20 Thread Eric Kinzie
On Tue Nov 03 11:48:57 + 2015, Ferruh Yigit wrote: > On Tue, Nov 03, 2015 at 01:31:45PM +0200, Panu Matilainen wrote: > > On 11/03/2015 01:02 PM, Ferruh Yigit wrote: > >> On Tue, Nov 03, 2015 at 08:48:16AM +0200, Panu Matilainen wrote: > >>> On 11/02/2015 06:42 PM, Eric Kinzie wrote: > On

[dpdk-dev] [PATCH] mk: fix compilation for icc version 16

2015-11-20 Thread Declan Doherty
This patch changes the ICC conditional check to disable -no-inline-max-size and -no-inline-max-total-size to be for all versions of icc greater than 14 and not just for version 15. Signed-off-by: Declan Doherty --- mk/toolchain/icc/rte.vars.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletio

[dpdk-dev] [PATCH v2] fm10k: fix wrong VLAN value in RX mbuf

2015-11-20 Thread Shaopeng He
vlan_tci should be copied from RX descriptor to mbuf, and flag PKT_RX_VLAN_PKT should be set for every RX packet, this patch fixes this issue. fm10k's Ethernet switch core associates a VLAN ID and VLAN PRI for each packet. For those packets coming in without a VLAN, the port default VLAN ID will be

[dpdk-dev] [PATCH v2] fm10k: fix wrong VLAN value in RX mbuf

2015-11-20 Thread He, Shaopeng
Hi, Mark > -Original Message- > From: Chen, Jing D > Sent: Friday, November 20, 2015 6:35 PM > To: He, Shaopeng; dev at dpdk.org > Cc: Qiu, Michael > Subject: RE: [PATCH v2] fm10k: fix wrong VLAN value in RX mbuf > > > Signed-off-by: Shaopeng He > > --- > > ChangeLog: > > > > v2: > > * c

[dpdk-dev] |ERROR| pw 9018 ethdev: add a missing sanity check for nb_tx_desc during txq setup

2015-11-20 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Rahul Lakkireddy > Sent: Friday, November 20, 2015 1:37 PM > To: dev at dpdk.org > Cc: Felix Marti; Kumar Sanghvi; Nirranjan Kirubaharan > Subject: Re: [dpdk-dev] |ERROR| pw 9018 ethdev: add a missing sanity ch

[dpdk-dev] [PATCH v4] doc: add contributors guide

2015-11-20 Thread John McNamara
Add a document to explain the DPDK patch submission and review process. Signed-off-by: John McNamara Acked-by: Harry van Haaren --- v4: * Fixes for mailing list comments. v3: * Add recommendation to test build the shared and combined libraries. v2: * Fixes for mailing list comments. * Fix fo

[dpdk-dev] [PATCH] ring: Fix memory leakage in rte_pmd_ring_devuninit()

2015-11-20 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Mcnamara, John > Sent: Friday, November 20, 2015 12:32 PM > To: Mauricio Vasquez B ; > dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ring: Fix memory leakage in > rte_pmd_ring_devuninit() > > > > > -

[dpdk-dev] [PATCH] ring: Fix memory leakage in rte_pmd_ring_devuninit()

2015-11-20 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Mauricio Vasquez B > Sent: Wednesday, November 18, 2015 10:29 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] ring: Fix memory leakage in > rte_pmd_ring_devuninit() > > When freeing the device, it is al

[dpdk-dev] [PATCH] eal: fix compile error for old glibc caused by pthread_setname_np()#

2015-11-20 Thread Bruce Richardson
On Thu, Nov 19, 2015 at 05:44:26PM +, Ferruh Yigit wrote: > Fixes: 67b6d3039e9e ("eal: set name to threads") > > pthread_setname_np() function added in glibc 2.12, using this function > in older glibc versions cause compile error: > error: implicit declaration of function "pthread_setname_np"

[dpdk-dev] [PATCH] ring: Fix memory leakage in rte_pmd_ring_devuninit()

2015-11-20 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Mauricio Vasquez B > Sent: Wednesday, November 18, 2015 10:29 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] ring: Fix memory leakage in > rte_pmd_ring_devuninit() > > When freeing the device, it is also

[dpdk-dev] [RFC PATCH 2/2] lib/librte_eal: Remove unnecessary hugepage zero-filling

2015-11-20 Thread Bruce Richardson
On Wed, Nov 18, 2015 at 11:09:06AM -0800, Stephen Hemminger wrote: > On Wed, 18 Nov 2015 16:13:32 + > "Richardson, Bruce" wrote: > > > > > > > > -Original Message- > > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen Hemminger > > > Sent: Wednesday, November 18, 201

[dpdk-dev] [PATCH v2 0/3] Remove CRC from byte counters

2015-11-20 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Harry van Haaren > Sent: Wednesday, November 18, 2015 10:48 AM > To: dev at dpdk.org > Cc: shemming at brocade.com > Subject: [dpdk-dev] [PATCH v2 0/3] Remove CRC from byte counters > > This patchset removes C

[dpdk-dev] [RFC PATCH 0/2] Virtio-net PMD Extension to work on host.

2015-11-20 Thread Tetsuya Mukawa
On 2015/11/20 11:35, Tetsuya Mukawa wrote: > On 2015/11/20 11:00, Xie, Huawei wrote: >> On 11/20/2015 2:16 AM, Rich Lane wrote: >>> What's the reason for using qemu as a middleman? Couldn't the new PMD >>> itself open /dev/vhost-net or the vhost-user socket and send the commands >>> to set up virtq

[dpdk-dev] [RFC PATCH 0/2] Virtio-net PMD Extension to work on host.

2015-11-20 Thread Tetsuya Mukawa
On 2015/11/20 11:00, Xie, Huawei wrote: > On 11/20/2015 2:16 AM, Rich Lane wrote: >> What's the reason for using qemu as a middleman? Couldn't the new PMD >> itself open /dev/vhost-net or the vhost-user socket and send the commands >> to set up virtqueues? That was the approach taken by Jianfeng's

[dpdk-dev] [PATCH] ethdev: add a missing sanity check for nb_tx_desc during txq setup

2015-11-20 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Rahul Lakkireddy > Sent: Friday, November 20, 2015 10:27 AM > To: dev at dpdk.org > Cc: Felix Marti; Kumar Sanghvi; Nirranjan Kirubaharan > Subject: [dpdk-dev] [PATCH] ethdev: add a missing sanity check for nb_

[dpdk-dev] [PATCH v2] fm10k: fix wrong VLAN value in RX mbuf

2015-11-20 Thread Chen, Jing D
> Signed-off-by: Shaopeng He > --- > ChangeLog: > > v2: > * change flag PKT_RX_VLAN_PKT to always set > * preserve the priority bits in vlan_tci > > drivers/net/fm10k/fm10k_rxtx.c | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/fm10k/fm10k_r

[dpdk-dev] [PATCH 17/17] ixgbe: add new device X550T1

2015-11-20 Thread Stephen Hemminger
On Fri, 20 Nov 2015 15:17:58 +0800 Wenzhuo Lu wrote: > Signed-off-by: Wenzhuo Lu > --- > lib/librte_eal/common/include/rte_pci_dev_ids.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/librte_eal/common/include/rte_pci_dev_ids.h > b/lib/librte_eal/common/include/rte_pci_dev_ids

[dpdk-dev] [PATCH v3] fm10k: fix wrong VLAN value in RX mbuf

2015-11-20 Thread Stephen Hemminger
On Fri, 20 Nov 2015 22:09:47 +0800 Shaopeng He wrote: > vlan_tci should be copied from RX descriptor to mbuf, > and flag PKT_RX_VLAN_PKT should be set for every RX packet, > this patch fixes this issue. > Packets in fm10k device always carry at least one VLAN tag. > For those packets coming in wi

[dpdk-dev] [PATCH RFC v2 2/2] lib/librte_eal: Remove unnecessary hugepage zero-filling

2015-11-20 Thread Stephen Hemminger
On Thu, 19 Nov 2015 20:53:48 -0500 Zhihong Wang wrote: > The kernel fills new allocated (huge) pages with zeros. > DPDK just has to touch the pages to trigger the allocation. > > Signed-off-by: Zhihong Wang The code is correct, and optimized. Don't you need to update the commit message since y

[dpdk-dev] [PATCH RFC v2 1/2] lib/librte_eal: Reduce timer initialization time

2015-11-20 Thread Stephen Hemminger
On Thu, 19 Nov 2015 20:53:47 -0500 Zhihong Wang wrote: > + struct timespec sleeptime = {.tv_nsec = 1E8 }; /* 1/10 second */ Why not NSEC_PER_SEC / 10

[dpdk-dev] [PATCH] fm10k: fix wrong VLAN value in RX mbuf

2015-11-20 Thread He, Shaopeng
Hi, Stephen > -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Friday, November 20, 2015 1:26 AM > To: He, Shaopeng > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] fm10k: fix wrong VLAN value in RX mbuf > > On Wed, 18 Nov 2015 16:50:09 +0

[dpdk-dev] [PATCH] fm10k: fix wrong VLAN value in RX mbuf

2015-11-20 Thread He, Shaopeng
Hi, Mark > -Original Message- > From: Chen, Jing D > Sent: Thursday, November 19, 2015 3:05 PM > To: He, Shaopeng; dev at dpdk.org > Cc: Qiu, Michael > Subject: RE: [PATCH] fm10k: fix wrong VLAN value in RX mbuf > > Hi, > > Worth to adding comments that vlan_tci is only valid in case > R

[dpdk-dev] [RFC PATCH 0/2] Virtio-net PMD Extension to work on host.

2015-11-20 Thread Xie, Huawei
On 11/20/2015 2:16 AM, Rich Lane wrote: > What's the reason for using qemu as a middleman? Couldn't the new PMD > itself open /dev/vhost-net or the vhost-user socket and send the commands > to set up virtqueues? That was the approach taken by Jianfeng's earlier RFC. Rich: Our initial POC also has a