[dpdk-dev] [PATCH v7 1/2] tools: Add support for handling built-in kernel modules

2016-02-08 Thread Kamil Rytarowski
ping? W dniu 29.01.2016 o 08:21, Yuanhan Liu pisze: > On Thu, Jan 28, 2016 at 02:13:53PM +0100, krytarowski at caviumnetworks.com > wrote: >> From: Kamil Rytarowski >> >> Currently dpdk_nic_bind.py detects Linux kernel modules via reading >> /proc/modules. Built-in ones aren't listed there and t

[dpdk-dev] [PATCH] mlx4: fix unneeded function error with clang v3.6

2016-02-08 Thread Bruce Richardson
When compiling with clang 3.6, the mlx4 driver gives the following error message about an unneeded function. CC mlx4.o .../drivers/net/mlx4/mlx4.c:136:20: fatal error: function 'wr_id_t_check' is not needed and will not be emitted [-Wunneeded-internal-declaration] static inline void wr_id_

[dpdk-dev] [PATCH] cryptodev: API change to rte_crypto_op bursts

2016-02-08 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Declan Doherty > Sent: Saturday, January 30, 2016 1:07 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] cryptodev: API change to rte_crypto_op bursts > > This patch modifies the crypto burst enqueue/dequ

[dpdk-dev] EAL Config

2016-02-08 Thread Sa Sa
I have a situation , Would it be great If you help me this out . I have a 2 ports NIC and a CPU with 20 Cores. How could I config EAL to have RX and TX ring of 2 ports on all Cores? Plus I want to inject packets into these 2 ports. How could I get memory from these 2 rings ?

[dpdk-dev] [PATCH 1/2] kdp: add kernel data path kernel module

2016-02-08 Thread Reshma Pattan
On 1/27/2016 4:32 PM, Ferruh Yigit wrote: > This kernel module is based on KNI module, but this one is stripped > version of it and only for data messages, no control functionality > provided. > > FIFO implementation of the KNI is kept exact same, but ethtool related > code removed and virtual ne

[dpdk-dev] [PATCH] docs: add statistics read frequency to fm10k guide

2016-02-08 Thread Thomas Monjalon
2016-02-08 15:42, Harry van Haaren: > This patch documents that the statistics of fm10k based NICs must be > read regularly in order to avoid an undetected 32 bit integer-overflow. > > Signed-off-by: Harry van Haaren > --- > doc/guides/nics/fm10k.rst| 16 > doc/guide

[dpdk-dev] [PATCH] tools: Fix typo in dpdk_nic_bind.py script.

2016-02-08 Thread Jeff Shaw
We should call sys.exit(), not divide sys by exit(). Signed-off-by: Jeff Shaw --- tools/dpdk_nic_bind.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/dpdk_nic_bind.py b/tools/dpdk_nic_bind.py index f02454e..a1923c5 100755 --- a/tools/dpdk_nic_bind.py +++ b/tools/dpdk

[dpdk-dev] [PATCH v4 0/4] fix performance/cache resource issues with 128-byte cache line targets

2016-02-08 Thread Jerin Jacob
On Mon, Feb 08, 2016 at 11:24:30AM +0100, Jan Viktorin wrote: > Hello Jerin, > > I failed to apply the v4 series. I've tried multiple bases. The v3 > applied successfully to v2.2.0-rc4. Could you give the proper working > base? Hello Jan, Please apply the depended "config: cleanup existing RTE_CA

[dpdk-dev] [PATCH] af_packet: make the device detachable

2016-02-08 Thread Iremonger, Bernard
Hi Wojciech, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wojciech Zmuda > Sent: Tuesday, January 5, 2016 2:05 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] af_packet: make the device detachable > > Fix memory leak when detaching virtual device.

[dpdk-dev] [PATCH] mk: fix examples build failure

2016-02-08 Thread Thomas Monjalon
Hi, 2015-12-24 20:38, steeven lee: > --- a/mk/internal/rte.extvars.mk > +++ b/mk/internal/rte.extvars.mk > # RTE_SDK_BIN must point to .config, include/ and lib/. > -RTE_SDK_BIN := $(RTE_SDK)/$(RTE_TARGET) > +RTE_SDK_BIN := $(RTE_SDK)/build RTE_TARGET is the right value here. To make it work wit

[dpdk-dev] [PATCH] docs: add statistics read frequency to fm10k guide

2016-02-08 Thread Van Haaren, Harry
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > 2016-02-08 15:42, Harry van Haaren: > > This patch documents that the statistics of fm10k based NICs must be > > read regularly in order to avoid an undetected 32 bit integer-overflow. > > > > Signed-off-by: Harry van Haaren > > --- >

[dpdk-dev] [PATCH 1/2] bnx2x: fix error handling in bnx2x_loop_obtain_resources()

2016-02-08 Thread Bruce Richardson
On Mon, Feb 08, 2016 at 07:53:46AM -0800, Charles (Chas) Williams wrote: > I am afraid I don't understand what you are asking. This was broken in the > commit that added bnx2x, 540a211084a7695a1c7bc43068934c140d6989be > Perfect. Generally, when adding a patch which fixes something, we add in a "

[dpdk-dev] [PATCH v2 3/5] virtio/vdev: add embeded device emulation

2016-02-08 Thread Tetsuya Mukawa
On 2016/02/05 20:20, Jianfeng Tan wrote: > To implement virtio vdev, we need way to interract with vhost backend. > And more importantly, needs way to emulate a device into DPDK. So this > patch acts as embedded device emulation. > > Depends on the type of vhost file: vhost-user is used if the give

[dpdk-dev] [PATCH] mempool: Reduce rte_mempool structure size

2016-02-08 Thread Wiles, Keith
>Hi Keith, > >Looks good, thanks. Please find some comments below. > >> [PATCH] mempool: Reduce rte_mempool structure size > >nit: we usually avoid uppercase letters in title Will make that change for v2. Why no uppercase letters in the title, seems a bit odd to me in this case?? > >On 02/03/201

[dpdk-dev] [PATCH 1/2] mlx4: add callback to set primary mac address

2016-02-08 Thread Bruce Richardson
On Wed, Jan 06, 2016 at 09:50:19AM +0100, Adrien Mazarguil wrote: > On Tue, Jan 05, 2016 at 07:00:08PM +0100, David Marchand wrote: > > Signed-off-by: David Marchand > > --- > > drivers/net/mlx4/mlx4.c | 17 + > > 1 file changed, 17 insertions(+) > > Acked-by: Adrien Mazarguil

[dpdk-dev] [PATCH] docs: add statistics read frequency to fm10k guide

2016-02-08 Thread Harry van Haaren
This patch documents that the statistics of fm10k based NICs must be read regularly in order to avoid an undetected 32 bit integer-overflow. Signed-off-by: Harry van Haaren --- doc/guides/nics/fm10k.rst| 16 doc/guides/rel_notes/release_2_3.rst | 4 2 files cha

[dpdk-dev] [PATCH] config: remove useless explicit includes of generated header

2016-02-08 Thread Thomas Monjalon
The file rte_config.h is automatically generated and included. No need to #include it. The example performance-thread needs a makefile fix to avoid overwriting the default cflags. Signed-off-by: Thomas Monjalon --- app/proc_info/main.c | 1 - app/test/test_po

[dpdk-dev] [PATCH v8 4/4] eal/linux: vfio: add pci ioport support

2016-02-08 Thread Santosh Shukla
Include vfio map/rd/wr support for pci ioport. Signed-off-by: Santosh Shukla --- v7->v8: - Remove rte_pci_ioport malloc and rte_free()/unmap() func from v7. - removed umap from git header. lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 36 ++-- 1 file changed, 24 inserti

[dpdk-dev] [PATCH v8 3/4] eal/linux: vfio: ignore mapping for ioport region

2016-02-08 Thread Santosh Shukla
vfio_pci_mmap() try to map all pci bars. ioport region are not mapped in vfio/kernel so ignore mmaping for ioport. Signed-off-by: Santosh Shukla Acked-by: Anatoly Burakov --- v7-->v8: - included Anatoly acked-by: lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 20 1 file ch

[dpdk-dev] [PATCH v7 4/4] eal/linux: vfio: add pci ioport support

2016-02-08 Thread Santosh Shukla
On Mon, Feb 8, 2016 at 2:21 PM, David Marchand wrote: > On Sun, Feb 7, 2016 at 2:51 PM, Santosh Shukla wrote: >> @@ -999,37 +1000,56 @@ int >> pci_vfio_ioport_map(struct rte_pci_device *dev, int bar, >> struct rte_pci_ioport *p) > > p is passed as a value, not a reference ..

[dpdk-dev] [PATCH v4 0/4] fix performance/cache resource issues with 128-byte cache line targets

2016-02-08 Thread Jerin Jacob
On Fri, Jan 29, 2016 at 01:15:51PM +0530, Jerin Jacob wrote: > This patchset fixes performance/cache resource issues with 128-byte cache > line targets > found in mbuf and bitmap DPDK libraries > > Currently, we have two DPDK targets(ThunderX and ppc_64) which are based on > 128-bytes cache line

[dpdk-dev] [PATCH v3 0/3] add lpm support for NEON

2016-02-08 Thread Jerin Jacob
On Fri, Jan 29, 2016 at 09:40:42AM +0530, Jerin Jacob wrote: > - This patch enables lpm for ARM > - Used architecture agnostic xmm_t to represent 128 bit SIMD variable in > rte_lpm_lookupx4 API definition > - Tested on Juno and Thunderx boards > - Tested and verified the changes with following DPDK

[dpdk-dev] [PATCH] hash: fix CRC32c computation

2016-02-08 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Monday, February 08, 2016 2:40 PM > To: De Lara Guarch, Pablo > Subject: FW: [dpdk-dev] [PATCH] hash: fix CRC32c computation > > > > From: Vincent JARDIN [mailto:vincent.jardin at 6wind.com] > Sent: Wednesday, December 23, 2015

[dpdk-dev] [PATCH] doc: drop old naming of the project

2016-02-08 Thread Thomas Monjalon
It was requested by Intel, more than one year ago, to replace the name "Intel DPDK" by "DPDK". Some references to the old name were still in some docs and code comments, leading to confusion. Fixes: ac8ada004c12 ("doc: remove Intel references from release notes") Signed-off-by: Thomas Monjalon -

[dpdk-dev] [PATCH] config: cleanup existing RTE_CACHE_LINE_SIZE selection scheme

2016-02-08 Thread Jerin Jacob
On Fri, Jan 29, 2016 at 09:54:55AM +0530, Jerin Jacob wrote: > On Tue, Dec 08, 2015 at 03:03:34PM +0530, Jerin Jacob wrote: > > On Mon, Dec 07, 2015 at 03:45:10PM +0100, Thomas Monjalon wrote: > > > 2015-12-07 19:52, Jerin Jacob: > > > > by default, all the targets will be configured with the 64-by

[dpdk-dev] [PATCH v2 0/9] pci cleanup and blacklist rework

2016-02-08 Thread Jan Viktorin
Hello David, I am confused a bit. I started to review the "[PATCH 0/9] prepare for rte_device / rte_driver" series and then I've noticed there are 2 patch series having "pci: no need for dynamic tailq init" patch there. But then, there is this v2 that does not have this patch. What is the right o

[dpdk-dev] [PATCH v2 3/5] eal/arm: adapt CPU flags check to the arch

2016-02-08 Thread Jerin Jacob
On Sat, Feb 06, 2016 at 11:17:11PM +0100, Thomas Monjalon wrote: > The structure feature_entry does not need leaf/subleaf > which were copied from x86 CPUID implementation. > > On x86, a valid flag is detected with the non-zero leaf value. > This check is replaced by a check with a dummy "none" re

[dpdk-dev] [PATCH v2 2/5] eal: move CPU flag functions out of headers

2016-02-08 Thread Jerin Jacob
On Sat, Feb 06, 2016 at 11:17:10PM +0100, Thomas Monjalon wrote: > The patch c344eab3ee has moved the hardware definition of CPU flags. > Now the functions checking these hardware flags are also moved. > The function rte_cpu_get_flag_enabled() is no more inline. > > The benefits are: > - remove rt

[dpdk-dev] [PATCH] nfp: fix non-x86 build

2016-02-08 Thread Alejandro Lucero
On Sat, Feb 6, 2016 at 9:51 PM, Thomas Monjalon wrote: > The file sys/io.h was included but it can be unavailable in some > non-x86 toolchains. > As others system includes in the file nfp_net.c, it seems useless, > so the easy fix is to remove them. > > Signed-off-by: Thomas Monjalon > --- > dr

[dpdk-dev] [PATCH] bnx2x: remove unused mbuf_alloc_size

2016-02-08 Thread Bruce Richardson
On Tue, Jan 05, 2016 at 04:53:28PM +, Harish Patil wrote: > > > >The mbuf_alloc_size is leftover from BSD or some other code base. > >It is set but never used in DPDK driver. After that the related defines > >can also be eliminated. > > > >Signed-off-by: Stephen Hemminger > >--- > > Acked-by

[dpdk-dev] [PATCH v8 4/4] eal/linux: vfio: add pci ioport support

2016-02-08 Thread Burakov, Anatoly
> Include vfio map/rd/wr support for pci ioport. > > Signed-off-by: Santosh Shukla > --- > v7->v8: > - Remove rte_pci_ioport malloc and rte_free()/unmap() func from v7. > - removed umap from git header. > > lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 36 ++--- > --- > 1 f

[dpdk-dev] [PATCH 2/3] examples/l3fwd: fix build without SSE4.1

2016-02-08 Thread De Lara Guarch, Pablo
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, February 03, 2016 6:57 PM > To: dev at dpdk.org > Cc: Ananyev, Konstantin; Wang, Zhihong; De Lara Guarch, Pablo; Dumitrescu, > Cristian > Subject: [PATCH 2/3] examples/l3fwd: fix build wi

[dpdk-dev] [PATCH] ixgbe: support multicast promiscuous mode on VF

2016-02-08 Thread Bruce Richardson
On Mon, Jan 04, 2016 at 04:07:16PM +0800, Wenzhuo Lu wrote: > Add multicast promiscuous mode support on ixgbe VF driver. > > Please note if we want to use this promiscuous mode, we need both PF > and VF driver to support it. The reason is this VF feature is > configged on PF. > If use kernel PF dr

[dpdk-dev] [PATCH v4 0/4] fix performance/cache resource issues with 128-byte cache line targets

2016-02-08 Thread Jan Viktorin
On Mon, 8 Feb 2016 16:22:17 +0530 Jerin Jacob wrote: > On Mon, Feb 08, 2016 at 11:24:30AM +0100, Jan Viktorin wrote: > > Hello Jerin, > > > > I failed to apply the v4 series. I've tried multiple bases. The v3 > > applied successfully to v2.2.0-rc4. Could you give the proper working > > base? >

[dpdk-dev] [PATCH 1/2] bnx2x: fix error handling in bnx2x_loop_obtain_resources()

2016-02-08 Thread Bruce Richardson
On Wed, Dec 30, 2015 at 07:37:50PM -0500, Chas Williams wrote: > From: "Charles (Chas) Williams" > > bnx2x_loop_obtain_resources() returns a struct containing the status and > the error message. If bnx2x_do_req4pf() fails, it shouldn't return both > of these fields set to 0 indicating failure an

[dpdk-dev] [PATCH 2/3] hash: fix header for C++

2016-02-08 Thread De Lara Guarch, Pablo
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, February 05, 2016 5:06 PM > To: De Lara Guarch, Pablo; Doherty, Declan; Horton, Remy > Cc: dev at dpdk.org > Subject: [PATCH 2/3] hash: fix header for C++ > > When built in a C++ applicatio

[dpdk-dev] [PATCH v2 3/4] Amazon ENA communication layer for DPDK platform

2016-02-08 Thread Stephen Hemminger
On Fri, 5 Feb 2016 19:20:28 +0100 Jan Medala wrote: > + > +typedef _Bool bool; > +#define true ((bool)1) > +#define false((bool)0) Why not just use ??

[dpdk-dev] [PATCH v2 1/4] Amazon ENA PCI defines and documentation

2016-02-08 Thread Stephen Hemminger
On Fri, 5 Feb 2016 19:20:26 +0100 Jan Medala wrote: > + > +#ifndef PCI_VENDOR_ID_AMAZON > +/** Vendor ID used by Amazon devices */ > +#define PCI_VENDOR_ID_AMAZON 0x1D0F > +#endif > + The goal is to eliminate the clobal rte_pci_dev_ids.h file, it doesn't scale.

[dpdk-dev] [PATCH] config: cleanup existing RTE_CACHE_LINE_SIZE selection scheme

2016-02-08 Thread Thomas Monjalon
2015-12-08 15:03, Jerin Jacob: > On Mon, Dec 07, 2015 at 03:45:10PM +0100, Thomas Monjalon wrote: > > 2015-12-07 19:52, Jerin Jacob: > > > by default, all the targets will be configured with the 64-byte cache line > > > size, targets which have different cache line size can be overridden > > > thro

[dpdk-dev] [PATCH 2/9] pci: register all pdev as pci drivers

2016-02-08 Thread Jan Viktorin
On Fri, 29 Jan 2016 15:08:29 +0100 David Marchand wrote: > pdev drivers are actually pci drivers. > Wrappers for ethdev and crypto pci drivers, that assume a 1 to 1 > association between pci device and upper device, have been added so that > current drivers are not impacted. It took me a while t

[dpdk-dev] [PATCH 1/5] mempool: add external mempool manager support

2016-02-08 Thread Olivier MATZ
Hi David, On 02/04/2016 05:47 PM, Hunt, David wrote: > Olivier, > Thanks for your comprehensive comments. I'm working on a v2 patch > based on feedback already received from Jerin, and I'll be sure to > include your feedback also. > Many thanks, > David. While answering to Keith, I realized

[dpdk-dev] [PATCH] mempool: Reduce rte_mempool structure size

2016-02-08 Thread Olivier MATZ
Hi Keith, Looks good, thanks. Please find some comments below. > [PATCH] mempool: Reduce rte_mempool structure size nit: we usually avoid uppercase letters in title On 02/03/2016 12:02 AM, Keith Wiles wrote: > diff --git a/lib/librte_mempool/rte_mempool.c > b/lib/librte_mempool/rte_mempool.c >

[dpdk-dev] [PATCH 1/9] pci: no need for dynamic tailq init

2016-02-08 Thread vikto...@rehivetech.com
On Fri, 29 Jan 2016 15:08:28 +0100 David Marchand wrote: > These lists can be initialized once and for all at build time. > With this, those lists are only manipulated in a common place > (and we could even make them private). > > A nice side effect is that pci drivers can now register in constr

[dpdk-dev] [PATCH v2 4/4] virtio: use pci ioport api

2016-02-08 Thread Santosh Shukla
On Sun, Feb 7, 2016 at 1:18 PM, David Marchand wrote: > Move all os / arch specifics to eal. > > Signed-off-by: David Marchand Reviewed-by: Santosh Shukla Tested-by: Santosh Shukla

[dpdk-dev] [PATCH v2 3/4] eal: introduce pci ioport api

2016-02-08 Thread Santosh Shukla
On Sun, Feb 7, 2016 at 1:18 PM, David Marchand wrote: > Most of the code is inspired on virtio driver. > rte_pci_ioport structure is filled at map time with anything needed for later > read / write calls. > At the moment, offset field is used to store a x86 ioport (uint16_t) and will > be reused

[dpdk-dev] [PATCH v4 0/4] fix performance/cache resource issues with 128-byte cache line targets

2016-02-08 Thread Jan Viktorin
Hello Jerin, I failed to apply the v4 series. I've tried multiple bases. The v3 applied successfully to v2.2.0-rc4. Could you give the proper working base? Applying patch #10232 using 'git am' Description: [dpdk-dev,v4,2/4] mbuf: fix performance/cache resource issue with 128-byte cache line targ

[dpdk-dev] [PATCH v7 2/4] virtio: Introduce config RTE_VIRTIO_INC_VECTOR

2016-02-08 Thread Santosh Shukla
On Mon, Feb 8, 2016 at 2:55 AM, Thomas Monjalon wrote: > 2016-02-07 19:21, Santosh Shukla: >> - virtio_recv_pkts_vec and other virtio vector friend apis are written for >> sse/avx instructions. For arm64 in particular, virtio vector implementation >> does not exist(todo). >> >> So virtio pmd d

[dpdk-dev] [PATCH v7 4/4] eal/linux: vfio: add pci ioport support

2016-02-08 Thread David Marchand
On Sun, Feb 7, 2016 at 2:51 PM, Santosh Shukla wrote: > @@ -999,37 +1000,56 @@ int > pci_vfio_ioport_map(struct rte_pci_device *dev, int bar, > struct rte_pci_ioport *p) p is passed as a value, not a reference ... > { > - RTE_SET_USED(dev); > - RTE_SET_USED(bar)

[dpdk-dev] [PATCH v7 2/2] vhost: Add VHOST PMD

2016-02-08 Thread Ferruh Yigit
On Fri, Feb 05, 2016 at 03:28:37PM +0900, Tetsuya Mukawa wrote: > On 2016/02/04 20:17, Ferruh Yigit wrote: > > On Thu, Feb 04, 2016 at 04:26:31PM +0900, Tetsuya Mukawa wrote: > > > > Hi Tetsuya, > > > >> The patch introduces a new PMD. This PMD is implemented as thin wrapper > >> of librte_vhost. I

[dpdk-dev] [PATCH v7 3/4] eal/linux: vfio: ignore mapping for ioport region

2016-02-08 Thread Burakov, Anatoly
> vfio_pci_mmap() try to map all pci bars. ioport region are not mapped in > vfio/kernel so ignore mmaping for ioport. > > Signed-off-by: Santosh Shukla > --- > lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 20 > 1 file changed, 20 insertions(+) > > diff --git a/lib/librte

[dpdk-dev] [PATCH 1/2] bnx2x: fix error handling in bnx2x_loop_obtain_resources()

2016-02-08 Thread Charles (Chas) Williams
I am afraid I don't understand what you are asking. This was broken in the commit that added bnx2x, 540a211084a7695a1c7bc43068934c140d6989be On 02/08/2016 05:51 AM, Bruce Richardson wrote: > On Wed, Dec 30, 2015 at 07:37:50PM -0500, Chas Williams wrote: >> From: "Charles (Chas) Williams" >> >> b