[dpdk-dev] New driver (large patch) question.

2016-03-02 Thread Bruce Richardson
On Thu, Mar 03, 2016 at 12:07:21AM +0100, Vincent JARDIN wrote: > Please, > > Le 02/03/2016 22:30, Stephen Hurd a ?crit : > >Too many of the DPDK drivers are bloated. > >>Recall the venerable paraphrase of Pascal, "I made this so long because I > >>did not have time to make it shorter." > >>https:

[dpdk-dev] [PATCH 1/3] kcp: add kernel control path kernel module

2016-03-02 Thread Thomas Monjalon
2016-03-02 12:21, Thomas Monjalon: > 2016-03-02 11:47, Vincent JARDIN: > > Le 02/03/2016 09:27, Panu Matilainen a ?crit : > > >>> I'd like to see these be merged. > > >>> > > >>> Jay > > >> > > >> The code is really not ready. I am okay with cooperative development > > >> but the current code needs

[dpdk-dev] New driver (large patch) question.

2016-03-02 Thread Thomas Monjalon
2016-03-02 14:06, Stephen Hurd: > The issue is that the big header in question is the whole hardware/firmware > interface definition. The comments in it are the only publicly available > documentation on the hardware I'm aware of. So you must keep the comments. > The driver itself doesn't have a

[dpdk-dev] [PATCH] drivers/net/bnxt New driver for Broadcom bnxt

2016-03-02 Thread Thomas Monjalon
Please do not submit some disabled code and avoid #ifdef. 2016-03-02 13:36, Stephen Hurd: > +static struct eth_dev_ops bnxt_dev_ops = { > + .dev_infos_get = bnxt_dev_info_get_op, > + .dev_configure = bnxt_dev_configure_op, > + .dev_start = bnxt_dev_start_op, > + .dev_stop =

[dpdk-dev] New driver (large patch) question.

2016-03-02 Thread Thomas Monjalon
2016-03-02 13:30, Stephen Hurd: > The bulk of the patch is the hardware interface header file. With all the > comments, it weighs in around 800k. If I strip the comments, it's around > 300k. If I both strip all the comments and remove all the currently unused > structures, I can get the entire p

[dpdk-dev] [PATCH] hash: fix memcmp function pointer in multi-process

2016-03-02 Thread Dhananjaya Reddy Eadala
Hi Pablo Thanks for the clarification. I just sent the patch using "git send-email". Probably that will show up as different mail thread. Thanks Dhana On Wed, Mar 2, 2016 at 9:22 AM, De Lara Guarch, Pablo < pablo.de.lara.guarch at intel.com> wrote: > Hi Dhana, > > > -Original Message- >

[dpdk-dev] [PATCH] hash: fix memcmp function pointer in multi-process environment

2016-03-02 Thread Dhana Eadala
We found a problem in dpdk-2.2 using under multi-process environment. Here is the brief description how we are using the dpdk: We have two processes proc1, proc2 using dpdk. These proc1 and proc2 are two different compiled binaries. proc1 is started as primary process and proc2 as secondary proce

[dpdk-dev] New driver (large patch) question.

2016-03-02 Thread Wiles, Keith
>The issue is that the big header in question is the whole hardware/firmware >interface definition. The comments in it are the only publicly available >documentation on the hardware I'm aware of. > >The driver itself doesn't have a lot of optional features in it, it's the >header file that's too b

[dpdk-dev] [PATCH v3] mk: stop on warning only in developer build

2016-03-02 Thread Bruce Richardson
On Wed, Mar 02, 2016 at 03:22:23PM +0100, Thomas Monjalon wrote: > From: Panu Matilainen > > Add RTE_DEVEL_BUILD make-variable which can be used to do things > differently when doing development vs building a release, > autodetected from source root .git presence and overridable via > commandline

[dpdk-dev] [PATCH v2] I217 and I218 changes

2016-03-02 Thread Bruce Richardson
On Wed, Mar 02, 2016 at 06:02:02AM -0800, Ravi Kerur wrote: > Hi, Wenzhuo, Bruce, I have superseded old patch with a new submission. > Please let me know if that approach is ok. > > Thanks, > Ravi Superceding patches is standard. Please mark the old patch as superceded in patchwork so it doesn't

[dpdk-dev] [PATCH] librte_port: fix segmentation fault for ring writer nodrop

2016-03-02 Thread Jasvinder Singh
Error log: [APP] Initializing PIPELINE0 ... pipeline> [APP] Initializing PIPELINE1 ... [PIPELINE1] Pass-through [APP] Initializing PIPELINE2 ... [PIPELINE2] Pass-through Segmentation fault (core dumped) Fixes: 5f4cd47309d6 ("port: add ring writer nodrop") Fixes: d58f69c54172 ("port: add ring

[dpdk-dev] [PATCH] librte_port: fix segmentation fault for ethdev writer nodrop

2016-03-02 Thread Jasvinder Singh
Error log: [APP] Initializing PIPELINE0 ... pipeline> [APP] Initializing PIPELINE1 ... [PIPELINE1] Pass-through Segmentation fault (core dumped) Fixes: 304c8091e90a ("port: add ethdev writer nodrop") Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu --- lib/librte_port/rte_port_

[dpdk-dev] [PATCH 0/3] add flag to disable CRC checksum offloading

2016-03-02 Thread Bruce Richardson
On Mon, Feb 15, 2016 at 05:55:22PM +0100, Paul Emmerich wrote: > This patch adds a new tx checksum offloading flag: PKT_TX_NO_CRC_CSUM. > This allows disabling CRC checksum offloading on a per-packet basis. > Doing this can be useful if you want to send out invalid packets on > purpose, e.g. in a p

[dpdk-dev] [PATCH] nfp: fix non-x86 build

2016-03-02 Thread Bruce Richardson
On Mon, Feb 08, 2016 at 02:27:59PM +, Alejandro Lucero wrote: > On Sat, Feb 6, 2016 at 9:51 PM, Thomas Monjalon > wrote: > > > The file sys/io.h was included but it can be unavailable in some > > non-x86 toolchains. > > As others system includes in the file nfp_net.c, it seems useless, > > so

[dpdk-dev] [PATCH v3 2/2] modify action handlers in test_pipeline and ip_pipeline

2016-03-02 Thread Jasvinder Singh
Changes are made to the ports and table action handlers defined in app/test_pipeline and ip_pipeline sample application. Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu --- app/test-pipeline/pipeline_acl.c | 3 +- app/test-pipeline/pipeline_hash.c

[dpdk-dev] [PATCH v3 1/2] librte_pipeline: add support for packet redirection at action handlers

2016-03-02 Thread Jasvinder Singh
Currently, there is no mechanism that allows the pipeline ports (in/out) and table action handlers to override the default forwarding decision (as previously configured per input port or in the table entry). Therefore, new pipeline API functions have been added which allows action handlers to hijac

[dpdk-dev] [PATCH v4 05/12] pmd/fm10k: add dev_ptype_info_get implementation

2016-03-02 Thread Chen, Jing D
Hi, -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jianfeng Tan Sent: Thursday, February 25, 2016 6:09 PM To: dev at dpdk.org Subject: [dpdk-dev] [PATCH v4 05/12] pmd/fm10k: add dev_ptype_info_get implementation Signed-off-by: Jianfeng Tan --- drivers/net/fm10k

[dpdk-dev] [PATCH 7/7] doc: add guide for new bnxt driver

2016-03-02 Thread Stephen Hurd
Initial guide for bnxt driver, documents current limitations and provides information link. Signed-off-by: Stephen Hurd --- doc/guides/nics/bnxt.rst | 49 1 file changed, 49 insertions(+) create mode 100644 doc/guides/nics/bnxt.rst diff --git a/

[dpdk-dev] [PATCH 6/7] doc: Add bnxt to overview table

2016-03-02 Thread Stephen Hurd
Signed-off-by: Stephen Hurd --- doc/guides/nics/overview.rst | 64 ++-- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/doc/guides/nics/overview.rst b/doc/guides/nics/overview.rst index d4c6ff4..e606bdf 100644 --- a/doc/guides/nics/overview.

[dpdk-dev] [PATCH 5/7] build: add bnxt PMD to build

2016-03-02 Thread Stephen Hurd
Signed-off-by: Stephen Hurd --- config/common_bsdapp | 5 + config/common_linuxapp | 5 + drivers/net/Makefile | 1 + mk/rte.app.mk | 1 + 4 files changed, 12 insertions(+) diff --git a/config/common_bsdapp b/config/common_bsdapp index 696382c..f37c7bb 100644 --- a/config/co

[dpdk-dev] [PATCH 4/7] maintainers: claim drivers/net/bnxt

2016-03-02 Thread Stephen Hurd
Claim ownership of new drivers/net/bnxt driver. Signed-off-by: Stephen Hurd --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 628bc05..6ee6c3c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -359,6 +359,10 @@ F: drivers/crypto/aesni_mb/ Intel

[dpdk-dev] [PATCH 3/7] drivers/net/bnxt new driver for Broadcom bnxt

2016-03-02 Thread Stephen Hurd
New driver for Broadcom bnxt (NexXtreme C-series) devices. Standards-compliant 10/25/50G support with 30MPPS full-duplex throughput http://www.broadcom.com/press/release.php?id=s923886 Signed-off-by: Stephen Hurd --- drivers/net/bnxt/Makefile | 79 ++ drivers/net/bnxt/bnxt.h

[dpdk-dev] [PATCH 2/7] lib/librte_eal: Add PCI IDs for Broadcom bnxt

2016-03-02 Thread Stephen Hurd
Add Broadcom Vendor ID and RTE_PCI_DEV_ID_DECL_BNXT() macro. Add Device IDs for Broadcom bnxt devices. Signed-off-by: Stephen Hurd --- lib/librte_eal/common/include/rte_pci_dev_ids.h | 45 ++--- 1 file changed, 40 insertions(+), 5 deletions(-) diff --git a/lib/librte_eal/com

[dpdk-dev] [PATCH 1/7] lib/librte_ether: Add 2/2.5/25/50Gbps link speeds

2016-03-02 Thread Stephen Hurd
Add additional ETH_LINK_SPEED_* macros for 2, 2.5, 25, and 50 Gbps links Signed-off-by: Stephen Hurd --- lib/librte_ether/rte_ethdev.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 16da821..cb40bbb 100644 --- a/lib/lib

[dpdk-dev] [PATCH 0/7] drivers/net/bnxt: new Broadcom bnxt driver

2016-03-02 Thread Stephen Hurd
New driver for Broadcom NetXtreme-C family of controllers and cards capable of up to 50Gbps link with 30Mpps throughput. v2: * Split into multiple patches * Add nic guide * Add features in overview.rst Stephen Hurd (7): lib/librte_ether: Add 2/2.5/25/50Gbps link speeds lib/librte_eal: Add PCI

[dpdk-dev] [PATCH v2 12/12] testpmd: extend commands for fdir's vlan input set

2016-03-02 Thread Jingjing Wu
This patch extended commands for filter's input set changing. It added vlan as filter's input fields. Signed-off-by: Jingjing Wu --- app/test-pmd/cmdline.c | 6 +++--- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff

[dpdk-dev] [PATCH v2 11/12] i40e: extend flow director to filter by vlan id

2016-03-02 Thread Jingjing Wu
This patch extended flow director to select vlan id as filter's input set and program the filter rule with vlan id. Signed-off-by: Jingjing Wu --- doc/guides/rel_notes/release_16_04.rst | 2 ++ drivers/net/i40e/i40e_ethdev.c | 11 drivers/net/i40e/i40e_fdir.c | 49 +++

[dpdk-dev] [PATCH v2 10/12] i40e: fix VLAN bitmasks for hash/fdir input sets for tunnels

2016-03-02 Thread Jingjing Wu
From: Andrey Chilikin This patch adds missing VLAN bitmask for inner frame in case of tunneling and fixes VLAN tags bitmasks for single or outer frame in case of tunneling. Fixes: 98f055707685 ("i40e: configure input fields for RSS or flow director") Signed-off-by: Andrey Chilikin --- drivers

[dpdk-dev] [PATCH v2 09/12] testpmd: extend commands for fdir's tunnel id input set

2016-03-02 Thread Jingjing Wu
This patch extended commands for filter's input set changing. It added GRE/Vxlan Tunnel as filter's input fields. Signed-off-by: Jingjing Wu --- app/test-pmd/cmdline.c | 27 +-- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 22 --

[dpdk-dev] [PATCH v2 08/12] i40e: extend flow director to filter by tunnel ID

2016-03-02 Thread Jingjing Wu
This patch extended flow director to select Vxlan/GRE tunnel ID as filter's input set and program the filter rule with the defined tunnel type. Signed-off-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev.c | 11 +++ drivers/net/i40e/i40e_fdir.c | 150 +++--

[dpdk-dev] [PATCH v2 07/12] librte_ether: extend rte_eth_fdir_flow to support tunnel format

2016-03-02 Thread Jingjing Wu
This patch changed rte_eth_fdir_flow from union to struct to support more packets formats, for example, Vxlan and GRE tunnel packets with IP inner frame. This patch also add new RTE_FDIR_TUNNEL_TYPE_GRE enum. Signed-off-by: Jingjing Wu --- doc/guides/rel_notes/deprecation.rst | 4 doc/g

[dpdk-dev] [PATCH v2 06/12] testpmd: extend commands for filter's input set changing

2016-03-02 Thread Jingjing Wu
This patch extended commands for filter's input set changing. It added tos, protocol and ttl as filter's input fields, and remove the words selection from flex payloads for flow director. Signed-off-by: Jingjing Wu --- app/test-pmd/cmdline.c | 100 ++-

[dpdk-dev] [PATCH v2 05/12] i40e: extend flow director to filter by more IP Header fields

2016-03-02 Thread Jingjing Wu
This patch extended flow director to select more IP Header fields as filter input set. Signed-off-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev.c | 69 ++ drivers/net/i40e/i40e_fdir.c | 26 +++- 2 files changed, 75 insertions(+), 20 deleti

[dpdk-dev] [PATCH v2 04/12] i40e: restore default setting on input set of filters

2016-03-02 Thread Jingjing Wu
This patch added a new function to set the input set to default when initialization. Signed-off-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev.c | 56 ++ 1 file changed, 56 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40

[dpdk-dev] [PATCH v2 03/12] i40e: remove flex payload from INPUT_SET_SELECT operation

2016-03-02 Thread Jingjing Wu
In this patch, flex payload is removed from valid fdir input set values. It is because all flex payload configuration can be set in struct rte_fdir_conf during device configure phase. And it is a more flexible configuration including flexpayload's selection, input set selection by word and mask set

[dpdk-dev] [PATCH v2 02/12] i40e: split function for input set change of hash and fdir

2016-03-02 Thread Jingjing Wu
This patch split function for input set changing of hash and fdir to avoid multiple check on different situation. Signed-off-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev.c | 233 + drivers/net/i40e/i40e_ethdev.h | 11 +- drivers/net/i40e/i40e_fdir.c

[dpdk-dev] [PATCH v2 01/12] ethdev: extend flow director to support input set selection

2016-03-02 Thread Jingjing Wu
This patch added RTE_ETH_INPUT_SET_L3_IP4_TTL, RTE_ETH_INPUT_SET_L3_IP6_HOP_LIMITS input field type and extended struct rte_eth_ipv4_flow and rte_eth_ipv6_flow to support filtering by tos, protocol and ttl. Signed-off-by: Jingjing Wu --- lib/librte_ether/rte_eth_ctrl.h | 8 1 file chang

[dpdk-dev] [PATCH v2 00/12] extend flow director's fields in i40e driver

2016-03-02 Thread Jingjing Wu
v2 changes: - rebase on dpdk-next-net/rel_16_04 - comments rewording. - redefine the value of RTE_ETH_INPUT_SET_L3_IP4_TTL to avoid ABI breaking. - remove ABI announce in Deprecation. - fix the ethertype setting when program filter in v1 patch set. This patch set extends flow director to supp

[dpdk-dev] [PATCH v5 2/2] doc: add introduction for fm10k FTAG based forwarding

2016-03-02 Thread Wang Xiao W
Add a brief introduction on FTAG, describe what's FTAG and how it works in forwarding. Signed-off-by: Wang Xiao W --- doc/guides/nics/fm10k.rst | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/fm10k.rst b/doc/guides/nics/fm10k.rst index dc5cb6e

[dpdk-dev] [PATCH v5 1/2] fm10k: enable FTAG based forwarding

2016-03-02 Thread Wang Xiao W
This patch enables reading sglort info into mbuf for RX and inserting an FTAG at the beginning of the packet for TX. The vlan_tci_outer field selected from rte_mbuf structure for sglort is not used in fm10k now. In FTAG based forwarding mode, the switch will forward packets according to glort info

[dpdk-dev] [PATCH v5 0/2] fm10k: enable FTAG based forwarding

2016-03-02 Thread Wang Xiao W
v5: * Used kvargs api to parse the devargs parameter. * Put release note into the driver patch. v4: * Removed the build time config option, used devargs to config FTAG. * Rebased on head of dpdk-next-net/rel_16_04 branch. v3: * Removed "\n" in PMD_INIT_LOG. * Returned "-ENOTSUP" instead of -1 in

[dpdk-dev] [PATCH] eal: arm64: introduce RTE_CPUFLAG_ATOMICS

2016-03-02 Thread Jerin Jacob
armv8.1 adds support for new atomic instructions. Linux kernel v4.3 onwards, the presence of atomic instruction support can detect through HWCAP_ATOMICS Signed-off-by: Jerin Jacob --- app/test/test_cpuflags.c | 3 +++ lib/librte_eal/common/arch/arm/rte_cpuflags.c

[dpdk-dev] [PATCH] eal: fix compile error in eal_timer.c caused by hpet

2016-03-02 Thread Thomas Monjalon
2016-01-28 14:16, ? ?: > Fix compile error when enable CONFIG_RTE_LIBEAL_USE_HPET. > > Error messages: > /root/dpdk-2.2.0/lib/librte_eal/linuxapp/eal/eal_timer.c: In function > ?rte_eal_hpet_init?: > /root/dpdk-2.2.0/lib/librte_eal/linuxapp/eal/eal_timer.c:222:2: error: > implicit declaration of

[dpdk-dev] [PATCH v4] enic: receive path performance improvements

2016-03-02 Thread John Daley
From: johndale This is a wholesale replacement of the Enic PMD receive path in order to improve performance and code clarity. The changes are: - Simplify and reduce code path length of receive function. - Put most of the fast-path receive funtions in one file. - Reduce the number of posted_index

[dpdk-dev] [PATCH v2 1/2] lpm: extend ip4 next_hop and add config structure

2016-03-02 Thread Thomas Monjalon
2016-03-02 16:23, Kobylinski, MichalX: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Sent: Wednesday, March 2, 2016 4:29 PM > > Is it possible to split the changes in next_hop and config structure? > > It is possible. Do you mean to put config structure into seperate patch-set?

[dpdk-dev] New driver (large patch) question.

2016-03-02 Thread Stephen Hurd
On Wed, Mar 2, 2016 at 4:29 PM, Thomas Monjalon wrote: > > Should I split additional definitions/documentation that's not currently > > used in the driver as well? Or should it stay as only enough to document > > what the driver already does? > > I don't understand the question. > If something i

[dpdk-dev] [PATCH] mk: fix error message

2016-03-02 Thread Thomas Monjalon
When specifying a wrong directory with RTE_SDK and RTE_TARGET to build an application, the error message about missing config file was wrong. Fixes: 6b62a72a70d0 ("mk: install a standard cutomizable tree") Reported-by: Steeven Lee Signed-off-by: Thomas Monjalon --- mk/internal/rte.extvars.mk |

[dpdk-dev] [PATCH 1/3] kcp: add kernel control path kernel module

2016-03-02 Thread Jim Thompson
> On Mar 2, 2016, at 6:03 AM, Vincent JARDIN > wrote: > > Le 02/03/2016 11:51, Jim Thompson a ?crit : >> Can we take it as a requirement to support FreeBSD this time around? > > Of course, all OS should be on the loop, but I guess, it would be per kernel > specific. What is ethtool on FreeBSD

[dpdk-dev] [PATCH v1 0/3] virtio vector and misc

2016-03-02 Thread Yuanhan Liu
On Tue, Mar 01, 2016 at 03:32:17PM +0530, Santosh Shukla wrote: > - 1st patch: let non-x86 arch use virtio pmd driver in non-vec > - 2nd patch: enable virtio arm support > - 3rd patch: update virtio for arm feature entry in release guide. Series looks good to me: Acked-by: Yuanhan Liu However,

[dpdk-dev] [PATCH v2 1/2] lpm: extend ip4 next_hop and add config structure

2016-03-02 Thread Thomas Monjalon
Hi, As suggested by Bruce, I'm looking to apply this patchset before the ARM one. Please check the comments below. Is it possible to split the changes in next_hop and config structure? > --- a/doc/guides/rel_notes/release_2_3.rst > +++ b/doc/guides/rel_notes/release_2_3.rst > @@ -18,7 +18,11 @@

[dpdk-dev] [PATCH v2 1/2] lpm: extend ip4 next_hop and add config structure

2016-03-02 Thread Kobylinski, MichalX
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, March 2, 2016 4:29 PM > To: Kobylinski, MichalX > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/2] lpm: extend ip4 next_hop and add config > structure > Importance: High > > H

[dpdk-dev] [PATCH 1/3] kcp: add kernel control path kernel module

2016-03-02 Thread Jay Rolette
On Tue, Mar 1, 2016 at 8:02 PM, Stephen Hemminger < stephen at networkplumber.org> wrote: > On Mon, 29 Feb 2016 08:33:25 -0600 > Jay Rolette wrote: > > > On Mon, Feb 29, 2016 at 5:06 AM, Thomas Monjalon < > thomas.monjalon at 6wind.com> > > wrote: > > > > > Hi, > > > I totally agree with Avi's co

[dpdk-dev] [PATCH] e1000: fix setting of VF MAC address

2016-03-02 Thread Bernard Iremonger
Allow reprogramming of the RAR with a zero mac address, to ensure that the VF traffic goes to the PF after stop, close and detach of the VF. Fixes: be2d648a2dd3 ("igb: add PF support") Fixes: d82170d27918 ("igb: add VF support") Signed-off-by: Bernard Iremonger --- drivers/net/e1000/igb_ethdev.c

[dpdk-dev] [PATCH 2/2 v4] i40e: Add floating VEB support in i40e

2016-03-02 Thread Zhe Tao
This patch add the support for floating VEB in i40e. All the VFs VSIs can decide whether to connect to the legacy VEB/VEPA or the floating VEB. When connect to the floating VEB a new floating VEB is created. Now all the VFs need to connect to floating VEB or legacy VEB, cannot connect to both of th

[dpdk-dev] [PATCH 1/2 v4] i40e: support floating VEB config

2016-03-02 Thread Zhe Tao
Add the new floating related argument option in the EAL. Using this parameter, all the samples can decide whether to use legacy VEB/VEPA or floating VEB. Even the floating argument is provided in the EAL, but this floating feature are only support for FVL so far. Signed-off-by: Zhe Tao --- doc/g

[dpdk-dev] [PATCH 0/2 v4] i40e: Add floating VEB support for i40e

2016-03-02 Thread Zhe Tao
This patch-set add the support for floating VEB in i40e. All the VFs VSIs can decide whether to connect to the legacy VEB/VEPA or the floating VEB. When connect to the floating VEB a new floating VEB is created. Now all the VFs need to connect to floating VEB or legacy VEB, cannot connect to both o

[dpdk-dev] [PATCH v3] mk: stop on warning only in developer build

2016-03-02 Thread Thomas Monjalon
From: Panu Matilainen Add RTE_DEVEL_BUILD make-variable which can be used to do things differently when doing development vs building a release, autodetected from source root .git presence and overridable via commandline. It is used it to enable -Werror compiler flag and may be extended to other

[dpdk-dev] New driver (large patch) question.

2016-03-02 Thread Stephen Hurd
On Wed, Mar 2, 2016 at 2:15 PM, Thomas Monjalon wrote: > > The comments in it are the only publicly available > > documentation on the hardware I'm aware of. > > So you must keep the comments. > That's my goal, but the comments are well over the 300k limit. > > The driver itself doesn't have a

[dpdk-dev] [PATCH] eal: arm64: introduce RTE_CPUFLAG_ATOMICS

2016-03-02 Thread Jan Viktorin
On Wed, 2 Mar 2016 18:50:59 +0530 Jerin Jacob wrote: > armv8.1 adds support for new atomic instructions. > Linux kernel v4.3 onwards, the presence of atomic instruction > support can detect through HWCAP_ATOMICS > > Signed-off-by: Jerin Jacob Reviewed-by: Jan Viktorin

[dpdk-dev] [PATCH v4 1/3] fm10k: enable FTAG based forwarding

2016-03-02 Thread Thomas Monjalon
2016-03-01 14:37, Stephen Hemminger: > On Tue, 1 Mar 2016 13:36:39 +0800 > Wang Xiao W wrote: > > +static int > > +fm10k_check_ftag(struct rte_devargs *devargs) > > +{ > > + if (devargs == NULL) > > + return 0; > > + > > + if (strstr(devargs->args, "enable_ftag=1") == NULL) > > +

[dpdk-dev] [PATCH v5 5/5] ixgbe: support VxLAN & NVGRE TX checksum off-load

2016-03-02 Thread Wenzhuo Lu
The patch add VxLAN & NVGRE TX checksum off-load. When the flag of outer IP header checksum offload is set, we'll set the context descriptor to enable this checksum off-load. Also update release note for VxLAN & NVGRE checksum off-load support. Signed-off-by: Wenzhuo Lu --- doc/guides/rel_notes

[dpdk-dev] [PATCH v5 4/5] ixgbe: support VxLAN & NVGRE RX checksum off-load

2016-03-02 Thread Wenzhuo Lu
X550 will do VxLAN & NVGRE RX checksum off-load automatically. This patch exposes the result of the checksum off-load. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/ixgbe_ethdev.c | 4 drivers/net/ixgbe/ixgbe_rxtx.c | 11 ++- lib/librte_ether/rte_ethdev.h| 1 + lib/librte_

[dpdk-dev] [PATCH v5 3/5] ixgbe: support UDP tunnel port config

2016-03-02 Thread Wenzhuo Lu
Add UDP tunnel port add/del support on ixgbe. Now only support VxLAN port configuration. Although according to the specification the VxLAN port has a default value 4789, it can be changed. We support VxLAN port configuration to meet the change. Note, the default value of VxLAN port in ixgbe NICs is

[dpdk-dev] [PATCH v5 2/5] i40e: rename the tunnel port config functions

2016-03-02 Thread Wenzhuo Lu
As the names of tunnel port config functions are not accurate, change them from tunnel_add/del to tunnel_port_add/del. And support both the old and new rte ops. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c | 22 -- 1 file changed, 12 insertions(+), 10 deletion

[dpdk-dev] [PATCH v5 1/5] lib/librte_ether: change function name of tunnel port config

2016-03-02 Thread Wenzhuo Lu
The names of function for tunnel port configuration are not accurate. They're tunnel_add/del, better change them to tunnel_port_add/del. As it may be an ABI change if change the names directly, the new functions are added but not remove the old ones. The old ones will be removed in the next release

[dpdk-dev] [PATCH v5 0/5] Support VxLAN & NVGRE checksum off-load on X550

2016-03-02 Thread Wenzhuo Lu
This patch set add the VxLAN & NVGRE checksum off-load support. Both RX and TX checksum off-load can be used for VxLAN & NVGRE. And the VxLAN port can be set, it's implemented in this patch set either. v2: - Update release note. v3: - Update RX/TX offload capability. - Reuse PKT_RX_EIP_CKSUM_BAD

[dpdk-dev] [PATCH v2] mk: replace the combined library with a linker script

2016-03-02 Thread Panu Matilainen
On 03/02/2016 02:40 PM, Thomas Monjalon wrote: > 2016-03-02 14:30, Panu Matilainen: >> On 03/01/2016 04:48 PM, Panu Matilainen wrote: >>> On 03/01/2016 03:40 PM, Thomas Monjalon wrote: ping I would like to be sure nothing is forgotten in this new revision. >>> >>> Sorry, didn't realize yo

[dpdk-dev] [PATCH v2] mk: replace the combined library with a linker script

2016-03-02 Thread Panu Matilainen
On 03/01/2016 04:48 PM, Panu Matilainen wrote: > On 03/01/2016 03:40 PM, Thomas Monjalon wrote: >> ping >> I would like to be sure nothing is forgotten in this new revision. > > Sorry, didn't realize you were waiting for input from me, it feels a bit > strange to comment on something supposedly com

[dpdk-dev] [PATCH] hash: fix memcmp function pointer in multi-process

2016-03-02 Thread De Lara Guarch, Pablo
Hi Dhana, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Dhananjaya Reddy > Eadala > Sent: Wednesday, March 02, 2016 2:02 PM > To: Qiu, Michael > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] hash: fix memcmp function pointer in multi- > process > >

[dpdk-dev] Multi Queue Support With Mellanox 40GbE NIC - MT27500 Family [ConnectX-3]

2016-03-02 Thread Olga Shern
Hi Suresh, RSS configuration is not supported with ConnectX-3 PMD. We added this support for ConnectX-4 PMD, available in DPDK 2.2. Best Regards, Olga -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Suresh Paruchuri Sent: Tuesday, March 01, 2016 8:03 PM To: use

[dpdk-dev] [PATCH v1 0/3] virtio vector and misc

2016-03-02 Thread Santosh Shukla
On Wed, Mar 2, 2016 at 2:02 PM, Yuanhan Liu wrote: > On Tue, Mar 01, 2016 at 03:32:17PM +0530, Santosh Shukla wrote: >> - 1st patch: let non-x86 arch use virtio pmd driver in non-vec >> - 2nd patch: enable virtio arm support >> - 3rd patch: update virtio for arm feature entry in release guide. >

[dpdk-dev] New driver (large patch) question.

2016-03-02 Thread Stephen Hurd
The issue is that the big header in question is the whole hardware/firmware interface definition. The comments in it are the only publicly available documentation on the hardware I'm aware of. The driver itself doesn't have a lot of optional features in it, it's the header file that's too big. O

[dpdk-dev] [PATCH] drivers/net/bnxt New driver for Broadcom bnxt

2016-03-02 Thread Stephen Hemminger
Please split into pieces, at a minimum: * changes to base DPDK code, you are changing lib/librte_ether * driver files * config to enable, MAINTAINERS etc. Also lots and lots of checkpatch errors: Results of: DPDK_CHECKPATCH_PATH=$HOME/kernel/linux/scripts/checkpatch.pl ./scripts/checkpatch

[dpdk-dev] [PATCH v2] mk: replace the combined library with a linker script

2016-03-02 Thread Thomas Monjalon
2016-03-02 14:30, Panu Matilainen: > On 03/01/2016 04:48 PM, Panu Matilainen wrote: > > On 03/01/2016 03:40 PM, Thomas Monjalon wrote: > >> ping > >> I would like to be sure nothing is forgotten in this new revision. > > > > Sorry, didn't realize you were waiting for input from me, it feels a bit >

[dpdk-dev] [PATCH] drivers/net/bnxt New driver for Broadcom bnxt

2016-03-02 Thread Stephen Hurd
Initial new driver for Broadcom bnxt (Cumulus) devices. - Adds drivers/net/bnxt and the librte_pmd_bnxt - Adds bnxt PCI IDs - Adds support for 2/2.5/25/50Gbps modes to rte_ethdev.h Signed-off-by: Stephen Hurd --- MAINTAINERS |4 + config/common_bsdapp

[dpdk-dev] New driver (large patch) question.

2016-03-02 Thread Stephen Hurd
The bulk of the patch is the hardware interface header file. With all the comments, it weighs in around 800k. If I strip the comments, it's around 300k. If I both strip all the comments and remove all the currently unused structures, I can get the entire patch down just below 300k, but that make

[dpdk-dev] [PATCH 1/3] kcp: add kernel control path kernel module

2016-03-02 Thread Vincent JARDIN
Le 02/03/2016 11:51, Jim Thompson a ?crit : > Can we take it as a requirement to support FreeBSD this time around? Of course, all OS should be on the loop, but I guess, it would be per kernel specific. What is ethtool on FreeBSD? Or can you start porting ethtool on FreeBSD?

[dpdk-dev] [PATCH v4] af_packet: make the device detachable

2016-03-02 Thread Wojciech Zmuda
Allow dynamic deallocation of af_packet device through proper API functions. To achieve this: * set device flag to RTE_ETH_DEV_DETACHABLE * implement rte_pmd_af_packet_devuninit() and expose it through rte_driver.uninit() * copy device name to ethdev->data to make discoverable with rte_eth_dev_

[dpdk-dev] [PATCH v3] af_packet: make the device detachable

2016-03-02 Thread Wojciech Żmuda
Hi Panu, >I think its okay to remove without going through the deprecation process. > just drop the accidentally exported symbol from the 2.0 definition. Well, this is what I've done so far. I'm going to post v4 patch modifying release_16_04.rst instead of release_2_3.rst, then. Thank you for sha

[dpdk-dev] [PATCH 1/3] kcp: add kernel control path kernel module

2016-03-02 Thread Thomas Monjalon
2016-03-02 11:47, Vincent JARDIN: > Le 02/03/2016 09:27, Panu Matilainen a ?crit : > >>> I'd like to see these be merged. > >>> > >>> Jay > >> > >> The code is really not ready. I am okay with cooperative development > >> but the current code needs to go into a staging type tree. > >> No compatibil

[dpdk-dev] [PATCH v4 3/3] maintainers: claim responsibility for arm64 specific files of hash and lpm

2016-03-02 Thread Jerin Jacob
On Tue, Mar 01, 2016 at 06:47:46PM +0100, Thomas Monjalon wrote: > 2016-02-12 17:58, Jerin Jacob: > > +F: lib/librte_lpm/rte_lpm_neon.h > > This line should be in the previous patch. Will fix in v5 > > > +F: lib/librte_hash/rte_crc_arm64.h > > +F: lib/librte_hash/rte_cmp_arm64.h > > Yes, hash

[dpdk-dev] [PATCH v3 5/5] doc: update doc for tcpdump feature

2016-03-02 Thread Reshma Pattan
Added tcpdump design changes to proc_info section of sample application user guide. Added tcpdump design changes to env abstraction layer section of programmers guide. Updated Release notes Signed-off-by: Reshma Pattan --- doc/guides/prog_guide/env_abstraction_layer.rst | 43 -

[dpdk-dev] [PATCH v3 4/5] lib/librte_eal: add tcpdump support in primary process

2016-03-02 Thread Reshma Pattan
Added tcpdump functionality to eal interrupt thread. Enhanced interrupt thread to support tcpdump socket and message processing from secondary. Created new mempool and rings to handle packets of tcpdump. Added rte_eth_rxtx_callbacks for ingress/egress packets processing for tcpdump. Added funct

[dpdk-dev] [PATCH v3 3/5] app/proc_info: add tcpdump support in secondary process

2016-03-02 Thread Reshma Pattan
Added below optional command line options for tcpdump support. 1)--tcupdump '(port,queue)' ==> port id and queue can be valid queue number or '*'. User need to specify specific queue id to capture packets on given queue for given port. (OR) '*' to capture packets from all queues of given port. 2)

[dpdk-dev] [PATCH v3 2/5] drivers/net/pcap: add public api to create pcap device

2016-03-02 Thread Reshma Pattan
Added new public api to create pcap device from pcaps. Added new header file for API declaration. Added new public api to version map Signed-off-by: Reshma Pattan --- drivers/net/pcap/Makefile |4 +- drivers/net/pcap/rte_eth_pcap.c | 156 +--

[dpdk-dev] [PATCH v3 1/5] app/test-pmd: fix nb_rxq and nb_txq checks

2016-03-02 Thread Reshma Pattan
Made testpmd changes to validate nb_rxq/nb_txq zero value changes of librte_ether. Signed-off-by: Reshma Pattan --- app/test-pmd/cmdline.c| 11 +-- app/test-pmd/parameters.c | 14 +- app/test-pmd/testpmd.c| 28 +--- 3 files changed, 39 in

[dpdk-dev] [PATCH v3 0/5] add dpdk packet capture support for tcpdump

2016-03-02 Thread Reshma Pattan
This patch set include the design to capture packets from dpdk ports for tcpdump. This patch set include test-pmd changes to verify below patch set. http://dpdk.org/dev/patchwork/patch/9750/ http://dpdk.org/dev/patchwork/patch/9751/ http://dpdk.org/dev/patchwork/patch/9752/ Dependencies 1: Patch

[dpdk-dev] [PATCH v4 2/3] lpm: add support for NEON

2016-03-02 Thread Jerin Jacob
On Tue, Mar 01, 2016 at 06:46:04PM +0100, Thomas Monjalon wrote: > 2016-02-12 17:58, Jerin Jacob: > > # fails to compile on ARM > > -CONFIG_RTE_LIBRTE_LPM=n > > -CONFIG_RTE_LIBRTE_TABLE=n > > -CONFIG_RTE_LIBRTE_PIPELINE=n > > The associated examples cannot compile. > Maybe it's too early to enabl

[dpdk-dev] [PATCH v4 1/3] lpm: make rte_lpm_lookupx4 API definition architecture agnostic

2016-03-02 Thread Jerin Jacob
On Tue, Mar 01, 2016 at 06:42:35PM +0100, Thomas Monjalon wrote: > 2016-02-12 17:58, Jerin Jacob: > > -Used architecture agnostic xmm_t to represent 128 bit SIMD variable > > > > -Introduced vect_* API abstraction in app/test to test rte_lpm_lookupx4 > > API in architecture agnostic way > > > >

[dpdk-dev] tcp/ip stack based on dpdk is ready

2016-03-02 Thread zimeiw
hi, The tcp/ip stack is developed based on dpdk. tcp/ip stack and APP deployment. |---| |---| |---| | APP | | APP | | APP | | | | | | | | | | | | |

[dpdk-dev] [PATCH 1/3] kcp: add kernel control path kernel module

2016-03-02 Thread Vincent JARDIN
Le 02/03/2016 09:27, Panu Matilainen a ?crit : >>> I'd like to see these be merged. >>> >>> Jay >> >> The code is really not ready. I am okay with cooperative development >> but the current code needs to go into a staging type tree. >> No compatibility, no ABI guarantees, more of an RFC. >> Don't w

[dpdk-dev] New driver (large patch) question.

2016-03-02 Thread Thomas Monjalon
Hi, 2016-03-01 19:56, Stephen Hurd: > I submitted a new driver on Friday, and it was rejected for being over 300k. > > The rejection email suggested contacing dev-owner at dpdk.org, which I did on > Monday with no reply. > > What's the process to submit patches larger than the mailing list size

[dpdk-dev] [PATCH v4 2/4] kcp: add kernel control path kernel module

2016-03-02 Thread Ferruh Yigit
On 3/1/2016 11:10 PM, Stephen Hemminger wrote: > On Tue, 1 Mar 2016 15:41:58 + > Ferruh Yigit wrote: > >> +struct kcp_ethtool_msg { >> +int cmd_id; >> +int port_id; >> +unsigned int flag; >> +char input_buffer[KCP_ETHTOOL_MSG_LEN]; >> +char output_buffer[KCP_ETHTOOL_MSG_L

[dpdk-dev] [PATCH v4 2/4] kcp: add kernel control path kernel module

2016-03-02 Thread Ferruh Yigit
On 3/1/2016 11:06 PM, Stephen Hemminger wrote: > On Tue, 1 Mar 2016 15:41:58 + > Ferruh Yigit wrote: > >> +#ifdef RTE_KCP_KO_DEBUG >> +#define KCP_DBG(args...) pr_info(args) >> +#else >> +#define KCP_DBG(args...) >> +#en > > Why not use pr_debug() which is compile enabled already and suppor

[dpdk-dev] [PATCH v2] app/testpmd Fix max_socket detection

2016-03-02 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen Hurd > Sent: Wednesday, January 13, 2016 10:24 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2] app/testpmd Fix max_socket detection > > Previously, max_socket was set to the highest numbered

[dpdk-dev] [PATCH v5 1/5] lib/librte_ether: change function name of tunnel port config

2016-03-02 Thread Panu Matilainen
On 03/02/2016 08:45 AM, Wenzhuo Lu wrote: > The names of function for tunnel port configuration are not > accurate. They're tunnel_add/del, better change them to > tunnel_port_add/del. > As it may be an ABI change if change the names directly, the > new functions are added but not remove the old on

[dpdk-dev] [PATCH v1] virtio: Use cpuflag for vector api

2016-03-02 Thread Yuanhan Liu
On Wed, Mar 02, 2016 at 02:10:14AM +, Qiu, Michael wrote: > On 3/1/2016 5:46 PM, Santosh Shukla wrote: > > On Tue, Mar 1, 2016 at 2:41 PM, Qiu, Michael > > wrote: > >> On 2/26/2016 4:53 PM, Santosh Shukla wrote: > >>> Check cpuflag macro before using vectored api. > >>> -virtio_recv_pkts_vec(

[dpdk-dev] [PATCH 1/3] kcp: add kernel control path kernel module

2016-03-02 Thread Panu Matilainen
On 03/02/2016 04:02 AM, Stephen Hemminger wrote: > On Mon, 29 Feb 2016 08:33:25 -0600 > Jay Rolette wrote: > >> On Mon, Feb 29, 2016 at 5:06 AM, Thomas Monjalon > 6wind.com> >> wrote: >> >>> Hi, >>> I totally agree with Avi's comments. >>> This topic is really important for the future of DPDK. >>>

[dpdk-dev] [PATCH v4 4/4] ena: DPDK polling-mode driver for Amazon Elastic Network Adapters (ENA)

2016-03-02 Thread Panu Matilainen
On 03/01/2016 06:46 PM, Jan Medala wrote: > This is a PMD for the Amazon ethernet ENA family. > The driver operates variety of ENA adapters through feature negotiation > with the adapter and upgradable commands set. > ENA driver handles PCI Physical and Virtual ENA functions. > > Signed-off-by: Evg

[dpdk-dev] [PATCH v2 4/6] bond mode 4: allow external state machine

2016-03-02 Thread Iremonger, Bernard
Hi Eric, > > > > @@ -157,6 +159,7 @@ struct rte_eth_bond_8023ad_conf { > > > > uint32_t tx_period_ms; > > > > uint32_t rx_marker_period_ms; > > > > uint32_t update_timeout_ms; > > > > + rte_eth_bond_8023ad_ext_slowrx_fn slowrx_cb; > > > > }; > > > > > > This still

  1   2   >