[dpdk-dev] [PATCH v11 0/8] ethdev: 100G and link speed API refactoring

2016-03-22 Thread Thomas Monjalon
2016-03-17 19:08, Thomas Monjalon: > There are still too few tests and reviews, especially for > autonegotiation with Intel devices (patch #6). > I would not be surprised to see some bugs in this rework. Any feedback about autoneg in e1000/ixgbe/i40e? Has it been tested before its integration in R

[dpdk-dev] Question on examples/multi_process app

2016-03-22 Thread Harish Patil
Hi, I have a question regarding symmetric_mp and mp_server applications under examples/multi_process. In those apps, rte_eth_promiscuous_enable() is called before rte_eth_dev_start(). Is this the correct way to initialize the port/device? As per the description in http://dpdk.org/doc/api/rte__ethde

[dpdk-dev] [PATCH 1/8] lpm: Fix pointer aliasing issues

2016-03-22 Thread Thomas Monjalon
2016-02-25 21:30, Bruce Richardson: > On Thu, Feb 25, 2016 at 01:48:34PM -0500, Aaron Conole wrote: > > /** > > + * Convert from tbl_entry types to integer types > > + */ > > +static inline uint16_t > > +rte_lpm_tbl24_entry_to_uint16(const struct rte_lpm_tbl24_entry *entry) > > +{ > > + union {

[dpdk-dev] [PATCH 3/8] drivers/net/e1000: Fix missing brackets

2016-03-22 Thread Thomas Monjalon
2016-03-01 13:02, Panu Matilainen: > On 02/26/2016 03:13 PM, Aaron Conole wrote: > > "Lu, Wenzhuo" writes: > >> Normally we will not maintain the base code. It's just taken from kernel > >> driver. > >> Agree with you that the whitespace is misleading. But as it's no real > >> impact. I'd like to

[dpdk-dev] Error when starting testpmd in dpdk 2.2.0 ("Creation of mbuf pool for socket 0 failed")

2016-03-22 Thread Kevin Wilson
Hi, I am getting the following error while running testpmd: RING: Cannot reserve memory EAL: Error - exiting with code: 1 Cause: Creation of mbuf pool for socket 0 failed I am running it thus: build/app/testpmd --log-level 8 -c7 -n3 -- \ -i --nb-cores=2 --nb-ports=2 --pkt-filter-mode=

[dpdk-dev] multi-segment mbuf

2016-03-22 Thread Clarylin L
Sorry my bad. The mbuf size has been accidentally changed to 3000. After fixing this by setting mbuf size to 2048, multi-segment mbuf still doesn't work. I was trying to send 2500-byte packets to the target system and was expecting to see two-segment mbuf chain), but got errors on it. Tue Mar 22

[dpdk-dev] [PATCH 1/8] lpm: Fix pointer aliasing issues

2016-03-22 Thread Aaron Conole
Thomas Monjalon writes: > 2016-02-25 21:30, Bruce Richardson: >> On Thu, Feb 25, 2016 at 01:48:34PM -0500, Aaron Conole wrote: >> > /** >> > + * Convert from tbl_entry types to integer types >> > + */ >> > +static inline uint16_t >> > +rte_lpm_tbl24_entry_to_uint16(const struct rte_lpm_tbl24_ent

[dpdk-dev] Issues with openvswitch2.5+dpdk2.2+kvm/virtio-pci

2016-03-22 Thread Daniele Di Proietto
Hi Christian, thanks for the report. I've managed to reproduce the problem and I observed two separate issues: 1) short version: it appears to be a problem in DPDK 2.2 and it should be fixed by 9a0615af7746("virtio: fix restart"), now on master. long version: for every DPDK device added to OVS

[dpdk-dev] [PATCH v2 0/3] Extend list of supported algorithms in L2fwd-crypto

2016-03-22 Thread Pablo de Lara
New cipher/authentication algorithms are supported in cryptodev, so L2fwd-crypto needs to have the list of supported algorithms updated. Changes in v2: - Added other two algorithms - Modified offset and length in bits for SNOW3G algorithms Pablo de Lara (3): l2fwd-crypto: add SNOW3G algorithms

[dpdk-dev] [PATCH v2 1/3] l2fwd-crypto: add SNOW3G algorithms

2016-03-22 Thread Pablo de Lara
Since SNOW3G UEA2/UIA2 are supported now by both HW and SW, l2fwd-crypto may use them, extending the list of algorithms parsed from command line. Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 48 +++- 1 file changed, 39 insertions(+), 9 d

[dpdk-dev] [PATCH v2 2/3] l2fwd-crypto: add AES GCM in auth algo list

2016-03-22 Thread Pablo de Lara
AES GCM is an algorithm for both ciphering and authentication, but the authentication algorithm was missing in the list of supported algorithms that can be passed from command line. Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 5 - 1 file changed, 4 insertions(+), 1 deleti

[dpdk-dev] [PATCH v2 3/3] l2fwd-crypto: add NULL in cipher/auth algo list

2016-03-22 Thread Pablo de Lara
NULL crypto operation is now supported, but l2fwd-crypto was missing an update on the list of supported algorithms that can be passed from command line. Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/examples/l2fwd-crypto/m

[dpdk-dev] [PATCH v2 0/7] Various fixes to compile with gcc6

2016-03-22 Thread Aaron Conole
This series brings a number of code cleanups to allow building using gcc6, with various legitimate warnings being fixed. Some of these fixes are to the drivers area, making this series a bit atypical. However, the fixes identified in patches 2 and 3 are actual bugs and should be fixed. The first

[dpdk-dev] [PATCH v2 1/7] app/test/test: Fix missing brackets

2016-03-22 Thread Aaron Conole
The test application calls printf(...) with the suite->suite_name argument. The intent (based on whitespace) in the printf is to check suite->suite_name first and then apply the printf. This doesn't happen due to missing brackets. Signed-off-by: Aaron Conole Acked-by: Panu Matilainen --- v2: * N

[dpdk-dev] [PATCH v2 2/7] drivers/net/e1000: Fix missing brackets

2016-03-22 Thread Aaron Conole
The register read/write mphy functions have misleading whitespace around the locked check. This cleanup merely preserves the existing functionality while improving the ready check. Fixes commit 38db3f7f50bd ("e1000: update base driver") Signed-off-by: Aaron Conole --- v2: * Changed from "whitesp

[dpdk-dev] [PATCH v2 3/7] drivers/net/e1000: Fix missing lsc interrupt check brackets

2016-03-22 Thread Aaron Conole
The device lsc interrupt check has a misleading whitespace around it which can be improved by adding appropriate braces to the check. Since the ret variable was checked after previous assignment, this introduces no functional change. Fixes commit 921a72008f76 ("e1000: add Rx interrupt handler") S

[dpdk-dev] [PATCH v2 4/7] drivers/net/ixgbe: Fix vlan filter missing brackets

2016-03-22 Thread Aaron Conole
The ixgbe vlan filter code has an if check with an incorrect whitespace. Signed-off-by: Aaron Conole Acked-by: Panu Matilainen Acked-by: Helin Zhang --- v2: * No change (apart from adding ACKs) drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --gi

[dpdk-dev] [PATCH v2 5/7] drivers/net/e1000/igb: Signed left shift operator

2016-03-22 Thread Aaron Conole
Tell the compiler to use an unsigned constant for the config shifts. Signed-off-by: Aaron Conole Acked-by: Panu Matilainen Acked-by: Helin Zhang --- v2: * No change (apart from adding ACKs) drivers/net/e1000/igb_pf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driv

[dpdk-dev] [PATCH v2 6/7] drivers/net/ixgbe: Signed left shift operator

2016-03-22 Thread Aaron Conole
Tell the compiler to use an unsigned constant for the config shifts. Signed-off-by: Aaron Conole Acked-by: Panu Matilainen Acked-by: Helin Zhang --- v2: * No change (apart from adding ACKs) drivers/net/ixgbe/ixgbe_pf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dr

[dpdk-dev] [PATCH v2 7/7] drivers/net/ixgbe: Fix uninitialized warning

2016-03-22 Thread Aaron Conole
Silence a compiler warning that this variable may be used uninitialized. Signed-off-by: Aaron Conole Acked-by: Helin Zhang --- v2: * No change (apart from adding ACK) drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_

[dpdk-dev] Question on examples/multi_process app

2016-03-22 Thread Bruce Richardson
On Tue, Mar 22, 2016 at 08:03:42PM +, Harish Patil wrote: > Hi, > I have a question regarding symmetric_mp and mp_server applications under > examples/multi_process. In those apps, rte_eth_promiscuous_enable() is > called before rte_eth_dev_start(). Is this the correct way to initialize > the p

[dpdk-dev] [PATCH v5 0/9] extend flow director fields in i40e driver

2016-03-22 Thread Bruce Richardson
On Mon, Mar 21, 2016 at 02:18:43PM +0800, Jingjing Wu wrote: > v5 changes: > - remove the reorganizing of struct rte_eth_fdir_flow > - remove fdir supporting on Tunnel Id > - rebase to latest dpdk/master > Thomas, given the above removal, are you ok with the ethdev changes now present in this pa

[dpdk-dev] [PATCH v5 0/9] extend flow director fields in i40e driver

2016-03-22 Thread Thomas Monjalon
2016-03-22 21:51, Bruce Richardson: > On Mon, Mar 21, 2016 at 02:18:43PM +0800, Jingjing Wu wrote: > > v5 changes: > > - remove the reorganizing of struct rte_eth_fdir_flow > > - remove fdir supporting on Tunnel Id > > - rebase to latest dpdk/master > > > Thomas, given the above removal, are you

[dpdk-dev] [PATCH v5 1/9] ethdev: extend flow director for input selection

2016-03-22 Thread Thomas Monjalon
2016-03-21 14:18, Jingjing Wu: > This patch added RTE_ETH_INPUT_SET_L3_IP4_TTL, > RTE_ETH_INPUT_SET_L3_IP6_HOP_LIMITS input field type and extended > struct rte_eth_ipv4_flow and rte_eth_ipv6_flow to support filtering > by tos, protocol and ttl. [...] > --- a/doc/guides/rel_notes/deprecation.rst >

[dpdk-dev] [PATCH] ethdev: fix rte_eth_dev_xstats_get with NULL

2016-03-22 Thread Stephen Hemminger
Normal usage of rte_eth_dev_xstats_get is to call twice. The first time the function is called with portid, xstats = NULL and n = 0; this returns the number of entries in the statistics table that need to be allocated. The problem is that the routine adds a count value to NULL (0) and assumes that

[dpdk-dev] multi-segment mbuf

2016-03-22 Thread Stephen Hemminger
Read the source. A multi-segment mbuf has the first mbuf with nb_segs > 1 and chained by next pointer. It is a bug in the creator of the mbuf, if number of segments and next chain don't match. There is a rte_pktmbuf_dump(), you can use to look at how your mbuf is formatted. On Tue, Mar 22, 2016

[dpdk-dev] [PATCH] mk: toolchain: gcc: query the compiler macros to obtain the gcc version

2016-03-22 Thread Thomas Monjalon
2016-03-22 17:13, Markos Chandras: > This is similar to what's being used in the Linux kernel. Querying the > GCC macros directly gives more accurate results compared to -dumpversion > which could vary across distributions. > > Signed-off-by: Markos Chandras > --- > In openSUSE Tumbleweed (and in

[dpdk-dev] multi-segment mbuf

2016-03-22 Thread Clarylin L
On my setup, the sending host is a regular one without running dpdk. It sends out 2500-byte packet without fragmentation to the dpdk node. Isn't it the enic pmd driver that is responsible for fetch the packet and format the mbuf (or mbuf chain if required)? Or do you mean I need to write my own co

[dpdk-dev] multi-segment mbuf

2016-03-22 Thread Clarylin L
Ok...I think you meant there's a bug in the driver code when formatting multi-segment mbuf. On Tue, Mar 22, 2016 at 3:13 PM, Stephen Hemminger < stephen at networkplumber.org> wrote: > Read the source. > > A multi-segment mbuf has the first mbuf with nb_segs > 1 and chained by > next pointer. > I

[dpdk-dev] [PATCH] igb_uio: fix vmware e1000 input/output error

2016-03-22 Thread Stephen Hemminger
On Mon, 21 Mar 2016 11:07:56 +0100 Thomas Monjalon wrote: > 2016-03-21 17:01, Qian Xu: > > INTX is badly emulated in Vmware, INTX toggle check didn't work > > with Vmware e1000 device. The patch is to fix the issue. > > Is it possible to detect a VMware e1000 device? > > > --- a/lib/librte_eal/

[dpdk-dev] [PATCH] mk: toolchain: gcc: query the compiler macros to obtain the gcc version

2016-03-22 Thread Markos Chandras
Hi, On 22/03/16 22:34, Thomas Monjalon wrote: > 2016-03-22 17:13, Markos Chandras: >> This is similar to what's being used in the Linux kernel. Querying the >> GCC macros directly gives more accurate results compared to -dumpversion >> which could vary across distributions. >> >> Signed-off-by: Ma

<    1   2