[dpdk-dev] [PATCH] doc: virtio pmd versions

2016-04-20 Thread Zhihong Wang
This patch explains all the versions of current virtio pmd implementation, what's the difference, and how to choose the right version. Signed-off-by: Zhihong Wang --- doc/guides/nics/virtio.rst | 57 ++ 1 file changed, 57 insertions(+) diff --git a/do

[dpdk-dev] [PATCH] jobstats: Fix a typo in rte_jobstat.h.

2016-04-20 Thread Rami Rosen
jobstats: max_exec_time represents Maximum execute time and not Minimum execute time. Signed-off-by: Rami Rosen --- lib/librte_jobstats/rte_jobstats.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_jobstats/rte_jobstats.h b/lib/librte_jobstats/rte_jobstats.h inde

[dpdk-dev] Memory leak when adding/removing vhost_user ports

2016-04-20 Thread Yuanhan Liu
On Wed, Apr 20, 2016 at 08:18:49AM +0200, Christian Ehrhardt wrote: > On Wed, Apr 20, 2016 at 7:04 AM, Yuanhan Liu > wrote: > > On Tue, Apr 19, 2016 at 06:33:50PM +0200, Christian Ehrhardt wrote: > > [...]? > > > With that applied one (and only one) of my two guests looses > connectivi

[dpdk-dev] [PATCH 4/4] maintainers: claim responsibility for ixgbe vector PMD on ARM

2016-04-20 Thread Jianbo Liu
Signed-off-by: Jianbo Liu --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1953ea2..07a9a44 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -142,6 +142,7 @@ F: lib/librte_eal/common/include/arch/arm/*_64.h F: lib/librte_acl/acl_run_neon.* F: lib/

[dpdk-dev] [PATCH 3/4] ixgbe: enable ixgbe vector PMD on ARMv8a platform

2016-04-20 Thread Jianbo Liu
Signed-off-by: Jianbo Liu --- config/defconfig_arm64-armv8a-linuxapp-gcc | 1 - 1 file changed, 1 deletion(-) diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfig_arm64-armv8a-linuxapp-gcc index 9abeca4..98cc054 100644 --- a/config/defconfig_arm64-armv8a-linuxapp-gcc +++ b

[dpdk-dev] [PATCH 2/4] ixgbe: implement vector PMD for arm architecture

2016-04-20 Thread Jianbo Liu
use ARM NEON intrinsic to implement ixgbe vPMD Signed-off-by: Jianbo Liu --- drivers/net/ixgbe/ixgbe_rxtx_vec.c | 4 + drivers/net/ixgbe/ixgbe_rxtx_vec_neon.h | 371 2 files changed, 375 insertions(+) create mode 100644 drivers/net/ixgbe/ixgbe_rxtx_vec_ne

[dpdk-dev] [PATCH 1/4] ixgbe: rearrange vector PMD code for x86

2016-04-20 Thread Jianbo Liu
move SSE-dependent code to new file "ixgbe_rxtx_vec_sse.h" Signed-off-by: Jianbo Liu --- drivers/net/ixgbe/ixgbe_rxtx_vec.c | 369 + drivers/net/ixgbe/ixgbe_rxtx_vec_sse.h | 408 + 2 files changed, 409 insertions(+), 368 deletions(-

[dpdk-dev] [RFC PATCH 2/2] testpmd: add portfwd commands

2016-04-20 Thread Zhihong Wang
This patch adds command support for portfwd, to enable run time configuration. Command details: 1) set fwd port switch forwarding engine to portfwd 2) show route show port info and forwarding rules for portfwd 3) set route packets from will be dispatched to

[dpdk-dev] [RFC PATCH 1/2] testpmd: add portfwd engine

2016-04-20 Thread Zhihong Wang
This patch implements a general purpose forwarding engine in testpmd namely "portfwd", to enable performance analysis and tuning for poll mode drivers in vSwitching scenarios. Features of portfwd: 1) Build up traffic from simple rx/tx to complex scenarios easily 2) Rich performance statist

[dpdk-dev] [RFC PATCH 0/2] performance utility in testpmd

2016-04-20 Thread Zhihong Wang
This RFC patch proposes a general purpose forwarding engine in testpmd namely "portfwd", to enable performance analysis and tuning for poll mode drivers in vSwitching scenarios. Problem statement - vSwitching is more I/O bound in a lot of cases since there are a lot of LLC/cross-

[dpdk-dev] [RFC PATCH v1 0/3] Remove string operations from xstats

2016-04-20 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of David Harton > (dharton) > Sent: Wednesday, April 20, 2016 5:04 PM > To: Horton, Remy ; dev at dpdk.org > Subject: Re: [dpdk-dev] [RFC PATCH v1 0/3] Remove string operations from > xstats > > > Again, I can pro

[dpdk-dev] [PATCH] examples/performance-thread: fix size of destination port ids in l3fwd-thread

2016-04-20 Thread Tomasz Kulasek
After extending IPv4 next hop in lpm library, size of dst_port array was changed from 16 to 32 bits in l3fwd-thread example, without modification of the rest of path written for 16 bit value. This patch uses similar approach for fix, like in commit 8353a36a9b4b ("examples/l3fwd: fix size of destin

[dpdk-dev] [PATCH v5 10/10] qede: Enable PMD build

2016-04-20 Thread Harish Patil
>On Wed, Apr 20, 2016 at 10:51:06AM +0200, Thomas Monjalon wrote: >> 2016-04-20 00:14, Harish Patil: >> > >2016-03-31 19:15, Rasesh Mody: >> > >> --- a/config/common_base >> > >> +++ b/config/common_base >> > >> +CONFIG_RTE_LIBRTE_QEDE_RX_COAL_US=24 >> > >> +CONFIG_RTE_LIBRTE_QEDE_TX_COAL_US=48 >>

[dpdk-dev] [PATCH] power: fix argument cannot be negative

2016-04-20 Thread Daniel Mrzyglod
Fix issue reported by Coverity. Coverity ID 13269 & 13266: Function strerror(errno) has built strings only for non-negative errno values. for negative values of errno it describe error as "Unknown error -errno" to be more descriptive i put string "channel not found" taken from header. The negativ

[dpdk-dev] [PATCH v5 10/10] qede: Enable PMD build

2016-04-20 Thread Harish Patil
> >2016-04-20 00:14, Harish Patil: >> >2016-03-31 19:15, Rasesh Mody: >> >> --- a/config/common_base >> >> +++ b/config/common_base >> >> +CONFIG_RTE_LIBRTE_QEDE_RX_COAL_US=24 >> >> +CONFIG_RTE_LIBRTE_QEDE_TX_COAL_US=48 >> > >> >It looks to be some tuning which could be done at runtime. Isn't it? >

[dpdk-dev] [RFC PATCH v1 0/3] Remove string operations from xstats

2016-04-20 Thread David Harton (dharton)
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton > Sent: Friday, April 15, 2016 10:44 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [RFC PATCH v1 0/3] Remove string operations from > xstats > > The current extended ethernet statistics fetching inv

[dpdk-dev] [PATCH v1] drivers/net/i40e: fix incorrect register dump offset

2016-04-20 Thread Bruce Richardson
On Thu, Apr 14, 2016 at 03:08:07AM +, Wu, Jingjing wrote: > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton > > Sent: Wednesday, April 13, 2016 5:45 PM > > To: Zhang, Helin > > Cc: dev at dpdk.org > > Subject: [dpdk-dev] [PATCH v1] driv

[dpdk-dev] [PATCH] ixgbe: checkpatch cleanups

2016-04-20 Thread Bruce Richardson
On Fri, Apr 08, 2016 at 01:48:05AM +, Lu, Wenzhuo wrote: > Hi, > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen Hemminger > > Sent: Friday, April 8, 2016 7:45 AM > > To: Zhang, Helin; Ananyev, Konstantin > > Cc: dev at dpdk.org; Stephen He

[dpdk-dev] [PATCH v3 01/13] e1000: move pci device ids to driver

2016-04-20 Thread David Marchand
On Wed, Apr 20, 2016 at 3:29 PM, Neil Horman wrote: >> +#ifndef RTE_PCI_DEV_ID_DECL_EM >> +#define RTE_PCI_DEV_ID_DECL_EM(vend, dev) >> +#endif >> + >> +#ifndef PCI_VENDOR_ID_INTEL >> +/** Vendor ID used by Intel devices */ >> +#define PCI_VENDOR_ID_INTEL 0x8086 >> +#endif >> + > This is broken, P

[dpdk-dev] [PATCH 0/3 v7] i40e: Add floating VEB support for i40e

2016-04-20 Thread Bruce Richardson
On Fri, Mar 25, 2016 at 04:41:57PM +0800, Zhe Tao wrote: > This patch-set add the support for floating VEB in i40e. > All the VFs VSIs can decide whether to connect to the legacy VEB/VEPA or > the floating VEB. When connect to the floating VEB a new floating VEB is > created. Now all the VFs need t

[dpdk-dev] [PATCH v3 0/3] xen: netfront poll mode driver

2016-04-20 Thread Bruce Richardson
On Tue, Mar 22, 2016 at 10:55:26AM +0100, Jan Blunck wrote: > v3 changes: > - removed fake PCI interface > - removed struct virt_eth_driver > - check for UIO name and version > - added basic documentation > > Jan Blunck (3): > xen: Add UIO kernel driver > xen: Add netfront poll mode driver >

[dpdk-dev] TSO support for Virtio_pmd

2016-04-20 Thread Tan, Jianfeng
Hi Nissim, On 4/20/2016 2:10 PM, Nissim Nisimov wrote: > Hi all, > > I see some additions in dpdk 16.04 to support TSO for vhost-user dpdk driver > with vanilla linux virtio VM. > > Does dpdk Virtio driver support TSO with the current code? Virtio pmd driver does not support TSO for now. > if n

[dpdk-dev] Couple of PMD questions

2016-04-20 Thread Bruce Richardson
On Wed, Apr 20, 2016 at 07:22:57AM -0500, Jay Rolette wrote: > On Wed, Apr 20, 2016 at 4:10 AM, Bruce Richardson < > bruce.richardson at intel.com> wrote: > > > On Tue, Apr 19, 2016 at 03:16:37PM -0500, Jay Rolette wrote: > > > In ixgbe_dev_rx_init(), there is this bit of code: > > > > > > /

[dpdk-dev] [PATCH v3 13/13] app: introduce dpdk-obj-info tool

2016-04-20 Thread David Marchand
Export some useful information for startup scripts and debug. For now, only pci drivers are handled. Example for a static binary: marchand at gloops:~/git/dpdk$ ./build/app/dpdk-obj-info ./build/app/testpmd pci:driver=cxgbe,flags=needmapping,lsc pci:driver=cxgbe,id=vendor=1425,device=5400,subvendo

[dpdk-dev] [PATCH v3 12/13] drivers: export pci drivers

2016-04-20 Thread David Marchand
Signed-off-by: David Marchand --- drivers/net/mlx4/mlx4.c | 1 + drivers/net/mlx5/mlx5.c | 1 + drivers/net/virtio/virtio_ethdev.c | 1 + lib/librte_eal/common/include/rte_pci.h | 7 +++ 4 files changed, 10 insertions(+) diff --git a/drivers/net/mlx4/mlx4

[dpdk-dev] [PATCH v3 11/13] drivers: constify pci id tables

2016-04-20 Thread David Marchand
Signed-off-by: David Marchand --- drivers/crypto/qat/rte_qat_cryptodev.c | 2 +- drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++-- drivers/net/cxgbe/cxgbe_ethdev.c | 2 +- drivers/net/ena/ena_ethdev.c | 2 +- drivers/net/nfp/nfp_net.c | 2 +- 5 files changed, 6 inserti

[dpdk-dev] [PATCH v3 10/13] pci: no need for global device ids list

2016-04-20 Thread David Marchand
Now that all pci device ids are in their respective drivers, we can remove this header. Signed-off-by: David Marchand --- doc/api/doxy-api-index.md | 1 - lib/librte_eal/common/Makefile | 2 +- lib/librte_eal/common/include/rte_pci_dev_ids.h | 93

[dpdk-dev] [PATCH v3 09/13] ena: remove unneeded pci macro

2016-04-20 Thread David Marchand
I suppose this is a remnant of rte_pci_dev_ids.h, just remove this. Signed-off-by: David Marchand --- drivers/net/ena/ena_ethdev.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 2b60a67..efa5e31 100644

[dpdk-dev] [PATCH v3 08/13] bnx2x: move pci device ids to driver

2016-04-20 Thread David Marchand
Reused defines from the driver and moved broadcom vendor id macro. Signed-off-by: David Marchand --- drivers/net/bnx2x/bnx2x.c | 3 +- drivers/net/bnx2x/bnx2x_ethdev.c| 21 +++-- lib/librte_eal/common/include/rte_pci_dev_ids.h | 60 -

[dpdk-dev] [PATCH v3 07/13] enic: move pci device ids to driver

2016-04-20 Thread David Marchand
Moved cisco vendor id since the driver had no such information. Signed-off-by: David Marchand --- drivers/net/enic/enic_ethdev.c | 13 + lib/librte_eal/common/include/rte_pci_dev_ids.h | 17 - 2 files changed, 5 insertions(+), 25 deletions(-) diff --

[dpdk-dev] [PATCH v3 06/13] vmxnet3: move pci device ids to driver

2016-04-20 Thread David Marchand
Moved vmware device ids macro since the driver had no such information. Signed-off-by: David Marchand --- drivers/net/vmxnet3/vmxnet3_ethdev.c| 9 - lib/librte_eal/common/include/rte_pci_dev_ids.h | 16 2 files changed, 4 insertions(+), 21 deletions(-) diff

[dpdk-dev] [PATCH v3 05/13] virtio: move pci device ids to driver

2016-04-20 Thread David Marchand
Reused defines from virtio_pci.h. Signed-off-by: David Marchand --- drivers/net/virtio/virtio_ethdev.c | 7 ++- lib/librte_eal/common/include/rte_pci_dev_ids.h | 17 - 2 files changed, 2 insertions(+), 22 deletions(-) diff --git a/drivers/net/virtio/virtio_ethd

[dpdk-dev] [PATCH v3 04/13] fm10k: move pci device ids to driver

2016-04-20 Thread David Marchand
Since the base driver already defines all pci device ids, no need to redefine them, let's just drop the previous RTE_PCI_DEV_ID_DECL* stuff. Signed-off-by: David Marchand --- drivers/net/fm10k/fm10k_ethdev.c| 7 +++--- lib/librte_eal/common/include/rte_pci_dev_ids.h | 29 ---

[dpdk-dev] [PATCH v3 03/13] i40e: move pci device ids to driver

2016-04-20 Thread David Marchand
Since the base driver already defines all pci device ids, no need to redefine them, let's just drop the previous RTE_PCI_DEV_ID_DECL* stuff. Signed-off-by: David Marchand --- drivers/net/i40e/i40e_ethdev.c | 21 ++-- drivers/net/i40e/i40e_ethdev_vf.c | 9 ++--

[dpdk-dev] [PATCH v3 02/13] ixgbe: move pci device ids to driver

2016-04-20 Thread David Marchand
test application and kni still want to know ixgbe pci devices. So let's create a header in the driver that will be used by them. Same comment as for e1000 driver, we can't reuse base/ headers at the moment because of macros redefinitions nightmare. Signed-off-by: David Marchand --- app/test-pmd

[dpdk-dev] [PATCH v3 01/13] e1000: move pci device ids to driver

2016-04-20 Thread David Marchand
test application and kni still want to know e1000 pci devices. So let's create headers in the driver that will be used by them. I wanted to reuse base/ headers, but because of some headaches trying to resolve macros redefinition collisions in kni (with ixgbe next commit), I left it as is. Signed-

[dpdk-dev] [PATCH v3 00/13] kill global pci device id list

2016-04-20 Thread David Marchand
This patchset moves all pci device ids from eal to the pmds that need them. Global pci device id list is then removed. A new tool (name to be discussed) has been added to retrieve some information from the dpdk elf objects. I can't work on this subject at the moment, so please feel free to make t

[dpdk-dev] [PATCH v2 00/17] prepare for rte_device / rte_driver

2016-04-20 Thread Jan Viktorin
On Wed, 20 Apr 2016 13:05:24 +0100 Bruce Richardson wrote: > On Wed, Apr 20, 2016 at 01:44:00PM +0200, David Marchand wrote: > > Following discussions with Jan [1] and some cleanup I started on pci code, > > here is a patchset that reworks pdev drivers registration and hotplug api. > > > > The s

[dpdk-dev] [PATCH v2 05/17] eal: introduce init macros

2016-04-20 Thread Jan Viktorin
Hello, just an idea... On Wed, 20 Apr 2016 13:44:05 +0200 David Marchand wrote: > Introduce a RTE_INIT macro used to mark an init function as a constructor. > Current eal macros have been converted to use this (no functional impact). > RTE_EAL_PCI_REGISTER is added as a helper for pci drivers.

[dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt

2016-04-20 Thread Stephen Hurd
> It's not for testing, more for code review and to help understand the code > [though > as you say, we do need to ensure that each commit doesn't actually break > the > build]. > Right now, the driver code goes in as a single commit - which makes it a > hard > enough task to review and see what is

[dpdk-dev] perfomance of rte_lpm rule subsystem

2016-04-20 Thread Wiles, Keith
>I just realizied that my patch could be confusing. I want to emphasize that it >contains two completly different and independent set of changes. One is new >rule subsystem and the other is 64 bit next hop. Maybe I should've prepared a >patch with only rule changes, but I wanted to discuss fist

[dpdk-dev] [PATCH v3 01/13] e1000: move pci device ids to driver

2016-04-20 Thread Neil Horman
On Wed, Apr 20, 2016 at 03:39:59PM +0200, David Marchand wrote: > On Wed, Apr 20, 2016 at 3:29 PM, Neil Horman wrote: > >> +#ifndef RTE_PCI_DEV_ID_DECL_EM > >> +#define RTE_PCI_DEV_ID_DECL_EM(vend, dev) > >> +#endif > >> + > >> +#ifndef PCI_VENDOR_ID_INTEL > >> +/** Vendor ID used by Intel devices

[dpdk-dev] KNI port type in IP pipeline

2016-04-20 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Moon-Sang Lee > Sent: Friday, April 15, 2016 8:13 AM > To: dev at dpdk.org > Subject: [dpdk-dev] KNI port type in IP pipeline > > According to pp. 145 of DPDK programmer's guide 2.2.0, the KNI port type is > d

[dpdk-dev] [PATCH 4/4] testpmd: reconfigure forwarding after changing portlist

2016-04-20 Thread Bernard Iremonger
Set nb_fwd_ports to zero on quit. Check portlist has been set before displaying forwarding configuration. Fixes: d3a274ce9dee ("app/testpmd: handle SIGINT and SIGTERM") Fixes: af75078fece3 ("first public release") Signed-off-by: Bernard Iremonger --- app/test-pmd/config.c | 8 ++-- app/tes

[dpdk-dev] [PATCH 3/4] testpmd: check port is not forwarding in stop_port and close_port

2016-04-20 Thread Bernard Iremonger
Add calls to port_is_forwarding function. Remove checks on test_done variable. Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") Signed-off-by: Bernard Iremonger --- app/test-pmd/testpmd.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff

[dpdk-dev] [PATCH 2/4] testpmd: don't update fwding config when attaching/detaching a port

2016-04-20 Thread Bernard Iremonger
Remove checks on test_done variable. Remove code to update forwarding configuration. Fixes: edab33b1c01d ("app/testpmd: support port hotplug") Signed-off-by: Bernard Iremonger --- app/test-pmd/testpmd.c | 28 +--- 1 file changed, 1 insertion(+), 27 deletions(-) diff --g

[dpdk-dev] [PATCH 1/4] testpmd: add function port_is_forwarding

2016-04-20 Thread Bernard Iremonger
Add function port_is_forwarding to check whether a port is forwarding or not. Signed-off-by: Bernard Iremonger --- app/test-pmd/config.c | 18 +- app/test-pmd/testpmd.h | 3 ++- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd

[dpdk-dev] [PATCH 0/4] testpmd forwarding

2016-04-20 Thread Bernard Iremonger
Modify testpmd to allow stop, close, detach and attach of a port without stopping forwarding. Bernard Iremonger (4): testpmd: add function port_is_forwarding testpmd: don't update fwding config when attaching/detaching a port testpmd: check port is not forwarding in stop_port and close_port

[dpdk-dev] [PATCH v2 17/17] ethdev: get rid of device type

2016-04-20 Thread David Marchand
Now that hotplug has been moved to eal, there is no reason to keep the device type in this layer. Signed-off-by: David Marchand --- app/test/virtual_pmd.c| 2 +- drivers/net/af_packet/rte_eth_af_packet.c | 2 +- drivers/net/bonding/rte_eth_bond_api.c| 2 +- drivers/net

[dpdk-dev] [PATCH v2 16/17] ethdev: convert to eal hotplug

2016-04-20 Thread David Marchand
Remove bus logic from ethdev hotplug by using eal for this. Current api is preserved: - the last port that has been created is tracked to return it to the application when attaching, - the internal device name is reused when detaching. We can not get rid of ethdev hotplug yet since we still nee

[dpdk-dev] [PATCH v2 15/17] eal: add hotplug operations for pci and vdev

2016-04-20 Thread David Marchand
hotplug which deals with resources should come from the layer that already handles them, i.e. eal. For both attach and detach operations, 'name' is used to select the bus that will handle the request. Signed-off-by: David Marchand --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 8 +

[dpdk-dev] [PATCH v2 14/17] ethdev: do not scan all pci devices on attach

2016-04-20 Thread David Marchand
No need to scan all devices, we only need to update the device being attached. Signed-off-by: David Marchand --- lib/librte_eal/common/eal_common_pci.c | 11 --- lib/librte_ether/rte_ethdev.c | 3 --- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/lib/librte_eal

[dpdk-dev] [PATCH v2 13/17] pci: add a helper to update a device

2016-04-20 Thread David Marchand
This helper updates a pci device object with latest information it can find. It will be used mainly for hotplug code. Signed-off-by: David Marchand --- lib/librte_eal/bsdapp/eal/eal_pci.c | 49 +++ lib/librte_eal/common/eal_private.h | 13 ++ lib/librt

[dpdk-dev] [PATCH v2 12/17] pci: add a helper for device name

2016-04-20 Thread David Marchand
eal is a better place than crypto / ethdev for naming resources. Add a helper in eal and make use of it in crypto / ethdev. Signed-off-by: David Marchand --- lib/librte_cryptodev/rte_cryptodev.c| 27 --- lib/librte_eal/common/include/rte_pci.h | 25 +++

[dpdk-dev] [PATCH v2 11/17] eal/linux: move back interrupt thread init before setting affinity

2016-04-20 Thread David Marchand
Now that virtio pci driver is initialized in a constructor, iopl() stuff happens early enough so that interrupt thread can be created right after plugin loading. This way, chelsio driver should be happy again [1]. [1] http://dpdk.org/ml/archives/dev/2015-November/028289.html Signed-off-by: David

[dpdk-dev] [PATCH v2 10/17] ethdev: get rid of eth driver register callback

2016-04-20 Thread David Marchand
Now that all pdev are pci drivers, we don't need to register ethdev drivers through a dedicated channel. Signed-off-by: David Marchand --- lib/librte_ether/rte_ethdev.c | 22 -- lib/librte_ether/rte_ethdev.h | 12 lib/librte_ether/rte_ether_vers

[dpdk-dev] [PATCH v2 09/17] crypto: get rid of crypto driver register callback

2016-04-20 Thread David Marchand
Now that all pdev are pci drivers, we don't need to register crypto drivers through a dedicated channel. Signed-off-by: David Marchand --- lib/librte_cryptodev/rte_cryptodev.c | 22 --- lib/librte_cryptodev/rte_cryptodev_pmd.h | 30 -- lib/

[dpdk-dev] [PATCH v2 08/17] drivers: convert all pdev drivers as pci drivers

2016-04-20 Thread David Marchand
Simplify crypto and ethdev pci drivers init by using newly introduced init macros and helpers. Those drivers then don't need to register as "rte_driver"s anymore. virtio and mlx* drivers use the general purpose RTE_INIT macro, as they both need some special stuff to be done before registering a pc

[dpdk-dev] [PATCH v2 07/17] ethdev: export init/uninit common wrappers for pci drivers

2016-04-20 Thread David Marchand
Preparing for getting rid of eth_drv, here are two wrappers that can be used by pci drivers that assume a 1 to 1 association between pci resource and upper interface. Signed-off-by: David Marchand --- lib/librte_ether/rte_ethdev.c | 14 +++--- lib/librte_ether/rte_ethdev.h

[dpdk-dev] [PATCH v2 06/17] crypto: export init/uninit common wrappers for pci drivers

2016-04-20 Thread David Marchand
Preparing for getting rid of rte_cryptodev_driver, here are two wrappers that can be used by pci drivers that assume a 1 to 1 association between pci resource and upper interface. Signed-off-by: David Marchand --- lib/librte_cryptodev/rte_cryptodev.c | 16 lib/librte_c

[dpdk-dev] [PATCH v2 05/17] eal: introduce init macros

2016-04-20 Thread David Marchand
Introduce a RTE_INIT macro used to mark an init function as a constructor. Current eal macros have been converted to use this (no functional impact). RTE_EAL_PCI_REGISTER is added as a helper for pci drivers. Suggested-by: Jan Viktorin Signed-off-by: David Marchand --- lib/librte_eal/common/inc

[dpdk-dev] [PATCH v2 04/17] eal: remove duplicate function declaration

2016-04-20 Thread David Marchand
rte_eal_dev_init is declared in both eal_private.h and rte_dev.h since its introduction. This function has been exported in ABI, so remove it from eal_private.h Fixes: e57f20e05177 ("eal: make vdev init path generic for both virtual and pci devices") Signed-off-by: David Marchand --- lib/librte

[dpdk-dev] [PATCH v2 03/17] drivers: align pci driver definitions

2016-04-20 Thread David Marchand
Pure coding style, but it might make it easier later if we want to move fields in rte_cryptodev_driver and eth_driver structures. Signed-off-by: David Marchand --- drivers/crypto/qat/rte_qat_cryptodev.c | 2 +- drivers/net/ena/ena_ethdev.c | 2 +- drivers/net/nfp/nfp_net.c

[dpdk-dev] [PATCH v2 02/17] crypto: no need for a crypto pmd type

2016-04-20 Thread David Marchand
This information is not used and just adds noise. Signed-off-by: David Marchand --- lib/librte_cryptodev/rte_cryptodev.c | 8 +++- lib/librte_cryptodev/rte_cryptodev.h | 2 -- lib/librte_cryptodev/rte_cryptodev_pmd.h | 3 +-- 3 files changed, 4 insertions(+), 9 deletions(-) diff --g

[dpdk-dev] [PATCH v2 01/17] pci: no need for dynamic tailq init

2016-04-20 Thread David Marchand
These lists can be initialized once and for all at build time. With this, those lists are only manipulated in a common place (and we could even make them private). A nice side effect is that pci drivers can now register in constructors. Signed-off-by: David Marchand Reviewed-by: Jan Viktorin --

[dpdk-dev] [PATCH v2 00/17] prepare for rte_device / rte_driver

2016-04-20 Thread David Marchand
Following discussions with Jan [1] and some cleanup I started on pci code, here is a patchset that reworks pdev drivers registration and hotplug api. The structures changes mentioned in [1] are still to be done, but at least, I think we are one step closer to it. Before this patchset, rte_driver

[dpdk-dev] [PATCH v2 00/17] prepare for rte_device / rte_driver

2016-04-20 Thread Bruce Richardson
On Wed, Apr 20, 2016 at 01:44:00PM +0200, David Marchand wrote: > Following discussions with Jan [1] and some cleanup I started on pci code, > here is a patchset that reworks pdev drivers registration and hotplug api. > > The structures changes mentioned in [1] are still to be done, but at least,

[dpdk-dev] [RFC] examples: remove l3fwd-vf example

2016-04-20 Thread Thomas Monjalon
2015-08-04 17:12, Ananyev, Konstantin: > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Qiu, Michael > > Actually, l3fwd works fine with fm10k vf. > > > > I don't know what's the exact reason of l3fwd-vf still in DPDK, > > at least we could make full support for vf in l3fwd instead of ano

[dpdk-dev] [PATCH] pci: remove deprecated specific config

2016-04-20 Thread Thomas Monjalon
> >> The driver i40e was using a specific PCI config before the release 16.04. > >> From 16.04, it is always enabled in i40e (commit 56465cfaf). > >> The API has been deprecated in the commit 68f77593823cab. > >> The igb_uio implementation has been deprecated in commit b7cf8e155. > >> The config he

[dpdk-dev] compile error on ubuntu 14.4.4 kernel 4.2.0-27-generic in qemu

2016-04-20 Thread Sharath
Root cause: Default cpu config when the VM has be been started by qemu does not support SSE. I have resolved this issue. Here the resolution which I used. Might be helpful for others Method 1 After Configuring VM by GUI based Virtual Machine Manager, go to the CPU config & make SSE as "Required"

[dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt

2016-04-20 Thread Bruce Richardson
On Tue, Apr 19, 2016 at 01:51:32PM -0700, Stephen Hurd wrote: > On Tue, Apr 19, 2016 at 7:19 AM, Bruce Richardson < > bruce.richardson at intel.com> wrote: > > > On Fri, Mar 04, 2016 at 01:05:24PM -0800, Stephen Hurd wrote: > > > New driver for Broadcom bnxt (NexXtreme C-series) devices. > > > > T

[dpdk-dev] [PATCH] port: bump ABI for pcap file support

2016-04-20 Thread Thomas Monjalon
> > Support of PCAP file has been added to rte_port in release 16.04 > > as NEXT_ABI. It is in the standard ABI of the release 16.07. > > > > Signed-off-by: Thomas Monjalon > > Acked-by: Cristian Dumitrescu Applied

[dpdk-dev] [PATCH v2] ethdev: remove deprecated statistics

2016-04-20 Thread Remy Horton
On 20/04/2016 10:47, Thomas Monjalon wrote: > Some statistics were deprecated since release 2.1 (49f386542af4). > The last deprecated counter to be used was imcasts. > > The VF loopback statistics are also removed as they are used only > in igb and duplicated in extended statistics. > > The new c

[dpdk-dev] [PATCH v2] ethdev: remove deprecated statistics

2016-04-20 Thread Thomas Monjalon
Some statistics were deprecated since release 2.1 (49f386542af4). The last deprecated counter to be used was imcasts. The VF loopback statistics are also removed as they are used only in igb and duplicated in extended statistics. The new counters should be added to extended statistics. Signed-of

[dpdk-dev] Couple of PMD questions

2016-04-20 Thread Andriy Berestovskyy
Hi Jay, On Tue, Apr 19, 2016 at 10:16 PM, Jay Rolette wrote: > Should the driver error out in that case instead of only "sort of" working? +1, we hit the same issue. Error or log message would help. > If I support a max frame size of 9216 bytes (exactly a 1K multiple to make > the NIC happy), t

[dpdk-dev] [RFC] examples: remove l3fwd-vf example

2016-04-20 Thread Ananyev, Konstantin
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, April 20, 2016 11:47 AM > To: Ananyev, Konstantin > Cc: Qiu, Michael; Zhang, Helin; Liu, Yong; Cao, Waterman; dev at dpdk.org > Subject: Re: [dpdk-dev] [RFC] examples: remove l

[dpdk-dev] [PATCH 1/1] lib/librte_eal: fix resource leak

2016-04-20 Thread David Marchand
On Tue, Apr 19, 2016 at 6:27 PM, Marcin Kerlin wrote: > Fix issue reported by Coverity. > > Coverity ID 13295, 13296, 13303: > Resource leak: The system resource will not be reclaimed > and reused, reducing the future availability of the resource. > In rte_eal_hugepage_attach: Leak of memory or p

[dpdk-dev] [PATCH] eal: remove useless internal function from memcpy headers

2016-04-20 Thread David Marchand
On Tue, Apr 19, 2016 at 10:47 PM, Thomas Monjalon wrote: > The function rte_memcpy_func() is used in ARM and PPC implementations > of rte_memcpy(). > There are some useless copies in Tile and some ARM branches. > It was also declared without doxygen comment in the generic header. > > Signed-off-by

[dpdk-dev] [PATCH] remove poisoned flags

2016-04-20 Thread David Marchand
On Tue, Apr 19, 2016 at 10:19 PM, Thomas Monjalon wrote: > Some flags were poisoned after having been removed from EAL and mbuf > in releases 1.8 (b10eef348d, 62814bc2e9) and 2.0 (4769bc5a27cc). > After several releases, they have probably disappeared from the applications. > > Signed-off-by: Thom

[dpdk-dev] [PATCH v5 05/10] qede: Add core driver

2016-04-20 Thread Thomas Monjalon
2016-04-20 01:09, Rasesh Mody: > Hi Thomas, > > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Sent: Tuesday, April 19, 2016 5:59 AM > > > > 2016-03-31 19:15, Rasesh Mody: > > > +ifeq ($(OS_TYPE),Linux) > > > +CFLAGS_ECORE_DRIVER += -Wno-shift-negative-value endif > > > > I se

[dpdk-dev] [PATCH v5 10/10] qede: Enable PMD build

2016-04-20 Thread Thomas Monjalon
2016-04-20 00:14, Harish Patil: > >2016-03-31 19:15, Rasesh Mody: > >> --- a/config/common_base > >> +++ b/config/common_base > >> +CONFIG_RTE_LIBRTE_QEDE_RX_COAL_US=24 > >> +CONFIG_RTE_LIBRTE_QEDE_TX_COAL_US=48 > > > >It looks to be some tuning which could be done at runtime. Isn't it? > > That?

[dpdk-dev] Couple of PMD questions

2016-04-20 Thread Jay Rolette
On Wed, Apr 20, 2016 at 9:05 AM, Bruce Richardson < bruce.richardson at intel.com> wrote: > On Wed, Apr 20, 2016 at 07:22:57AM -0500, Jay Rolette wrote: > > On Wed, Apr 20, 2016 at 4:10 AM, Bruce Richardson < > > bruce.richardson at intel.com> wrote: > > > > > On Tue, Apr 19, 2016 at 03:16:37PM -0

[dpdk-dev] [PATCH v5 10/10] qede: Enable PMD build

2016-04-20 Thread Bruce Richardson
On Wed, Apr 20, 2016 at 10:51:06AM +0200, Thomas Monjalon wrote: > 2016-04-20 00:14, Harish Patil: > > >2016-03-31 19:15, Rasesh Mody: > > >> --- a/config/common_base > > >> +++ b/config/common_base > > >> +CONFIG_RTE_LIBRTE_QEDE_RX_COAL_US=24 > > >> +CONFIG_RTE_LIBRTE_QEDE_TX_COAL_US=48 > > > > >

[dpdk-dev] Recall: [PATCH 3/3 v7] i40e: Add global reset support for i40e

2016-04-20 Thread Wu, Jingjing
Wu, Jingjing would like to recall the message, "[dpdk-dev][PATCH 3/3 v7] i40e: Add global reset support for i40e".

[dpdk-dev] [PATCH 3/3 v7] i40e: Add global reset support for i40e

2016-04-20 Thread Wu, Jingjing
Hi, zhe Beside hein's global reset concern. I have another comment: Do you copy the following codes from i40e kernel driver? Have You done the Protext IP scan for it? Just let you know that linux kernel is GPL liscense, we can Not just copy code from it without any modification. Thanks Jingjing

[dpdk-dev] Couple of PMD questions

2016-04-20 Thread Bruce Richardson
On Tue, Apr 19, 2016 at 03:16:37PM -0500, Jay Rolette wrote: > In ixgbe_dev_rx_init(), there is this bit of code: > > /* >* Configure the RX buffer size in the BSIZEPACKET field of >* the SRRCTL register of the queue. >* The value is in 1 KB resolution. Valid values c

[dpdk-dev] ixgbe : query regarding your code changes for VF mac add

2016-04-20 Thread Ivan Boule
Hi Santosh, I do not get exactly what you attempt to do on a VF. Are you first deleting the so-called permanent MAC address by a call to the function ixgbevf_remove_mac_addr() ? This operation is not allowed. Can you explain exactly the sequence of operations that are done, so that I can understan

[dpdk-dev] [PATCH v3 01/13] e1000: move pci device ids to driver

2016-04-20 Thread Neil Horman
On Wed, Apr 20, 2016 at 02:43:44PM +0200, David Marchand wrote: > test application and kni still want to know e1000 pci devices. > So let's create headers in the driver that will be used by them. > > I wanted to reuse base/ headers, but because of some headaches trying to > resolve > macros redef

[dpdk-dev] Memory leak when adding/removing vhost_user ports

2016-04-20 Thread Christian Ehrhardt
On Wed, Apr 20, 2016 at 7:04 AM, Yuanhan Liu wrote: > On Tue, Apr 19, 2016 at 06:33:50PM +0200, Christian Ehrhardt wrote: > [...] > > With that applied one (and only one) of my two guests looses > connectivity after > > removing the ports the first time. > > Yeah, that's should be because I invo

[dpdk-dev] perfomance of rte_lpm rule subsystem

2016-04-20 Thread Alexander Kiselev
I just realizied that my patch could be confusing. I want to emphasize that it contains two completly different and independent set of changes. One is new rule subsystem and the other is 64 bit next hop. Maybe I should've prepared a patch with only rule changes, but I wanted to discuss fist and

[dpdk-dev] basic forwarding example not working

2016-04-20 Thread Christian Ehrhardt
Hi, I think your log is cut short. At least in what you posted I don't see the "card skipped" issue anymore. Also I don't see the segfault at the end anymore. Actually there is no error left in this second log. I never used basicfwd so far - maybe it is something special to it that breaks your cas

[dpdk-dev] Couple of PMD questions

2016-04-20 Thread Jay Rolette
On Wed, Apr 20, 2016 at 4:35 AM, Andriy Berestovskyy wrote: > Hi Jay, > > On Tue, Apr 19, 2016 at 10:16 PM, Jay Rolette wrote: > > Should the driver error out in that case instead of only "sort of" > working? > > +1, we hit the same issue. Error or log message would help. > > > If I support a ma

[dpdk-dev] [PATCH 2/3 v7] i40e: Add floating VEB support in i40e

2016-04-20 Thread Wu, Jingjing
> @@ -3830,12 +3844,22 @@ i40e_vsi_release(struct i40e_vsi *vsi) > i40e_veb_release(vsi->veb); > } > > + if (vsi->floating_veb) { > + TAILQ_FOREACH(vsi_list, &vsi->floating_veb->head, list) { > + if (i40e_vsi_release(vsi_list->vsi) != I40E_SU

[dpdk-dev] Couple of PMD questions

2016-04-20 Thread Jay Rolette
On Wed, Apr 20, 2016 at 4:10 AM, Bruce Richardson < bruce.richardson at intel.com> wrote: > On Tue, Apr 19, 2016 at 03:16:37PM -0500, Jay Rolette wrote: > > In ixgbe_dev_rx_init(), there is this bit of code: > > > > /* > >* Configure the RX buffer size in the BSIZEPACKET field of > >

[dpdk-dev] TSO support for Virtio_pmd

2016-04-20 Thread Nissim Nisimov
Hi all, I see some additions in dpdk 16.04 to support TSO for vhost-user dpdk driver with vanilla linux virtio VM. Does dpdk Virtio driver support TSO with the current code? if not, is there any plan to support it in the future? Thanks, Nissim

[dpdk-dev] rte_hash_del_key crash in multi-process environment

2016-04-20 Thread 张伟
Thanks so much! That fixes my problem. At 2016-04-19 15:39:16, "De Lara Guarch, Pablo" wrote: >Hi, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of ?? >> Sent: Tuesday, April 19, 2016 5:58 AM >> To: De Lara Guarch, Pablo >> Cc: Thomas Monjalon; Go

[dpdk-dev] ixgbe : query regarding your code changes for VF mac add

2016-04-20 Thread santosh
Hi Ivan, Thanks for your response. Let me explain you the issue that we are facing on our virtual router in VMware environment. 1. We are using ixgbe driver , SRIOV enabled . root at localhost:~# lspci "Intel Corporation 82599 Ethernet Controller Virtual Function" 2. "mx86-bgl-1

[dpdk-dev] [PATCH v5 05/10] qede: Add core driver

2016-04-20 Thread Rasesh Mody
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, April 19, 2016 6:18 AM > > 2016-03-31 19:15, Rasesh Mody: > > The Qlogic Everest Driver for Ethernet(QEDE) Poll Mode Driver(PMD) is > > the DPDK specific module for QLogic FastLinQ QL4 25G/40G CNA > > family of adap

[dpdk-dev] [PATCH v5 05/10] qede: Add core driver

2016-04-20 Thread Rasesh Mody
Hi Thomas, > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, April 19, 2016 5:59 AM > > 2016-03-31 19:15, Rasesh Mody: > > +ifeq ($(OS_TYPE),Linux) > > +CFLAGS_ECORE_DRIVER += -Wno-shift-negative-value endif > > I see an error with clang: > fatal error: unknown warni

[dpdk-dev] [PATCH v5 10/10] qede: Enable PMD build

2016-04-20 Thread Harish Patil
> >2016-03-31 19:15, Rasesh Mody: >> --- a/config/common_base >> +++ b/config/common_base >> +CONFIG_RTE_LIBRTE_QEDE_RX_COAL_US=24 >> +CONFIG_RTE_LIBRTE_QEDE_TX_COAL_US=48 > >It looks to be some tuning which could be done at runtime. Isn't it? That?s right. Can you please suggest if there is any b

  1   2   >