> > The rte_eth_dev_count() function will never return a value greater
> > than RTE_MAX_ETHPORTS, so that checking is useless.
> >
> > Signed-off-by: Mauricio Vasquez B > studenti.polito.it>
>
> Acked-by: Ferruh Yigit
Applied, thanks
> > bulk functions expect that all memory is set with zeros
> >
> > Fixes: 67ebdbef0c31 ("examples/ip_pipeline: add bulk update of firewall
> > rules")
> >
> > Signed-off-by: Daniel Mrzyglod
>
> Acked-by: Cristian Dumitrescu
Applied, thanks
> > CID 124567:
> > In the function app_init_eal(struct app params * app) number of
> > entries into array exceeds the size of the array if the conditions
> > are fulfilled.
> >
> > Fixes: 7f64b9c004aa ("examples/ip_pipeline: rework config file syntax")
> >
> > Signed-off-by: Marcin Kerlin
>
>
> > Fix issue reported by Coverity.
> >
> > Coverity ID 13207:
> > Value returned from a function is not checked for errors before being used.
> >
> > Fixes: 07db4a975094 ("examples/distributor: new sample app")
> >
> > Signed-off-by: Marcin Kerlin
>
> Acked-by: Reshma Pattan
Applied,
2016-04-27 15:22, Michal Kobylinski:
> Fix issue reported by Coverity.
>
> Coverity ID 30701: Infinite loop: The loop does not have a normal
> termination condition, so will continue until an abnormal condition
> arises. In rte_netmap_poll: Infinite loop with unsatisfiable exit
> condition.
>
>
"check flow configuration error"
> > Fix issue reported by Coverity.
> >
> > Coverity ID 30693: Unchecked return value
> > check_return: Calling rte_meter_srtcm_config without checking return
> > value.
> >
> > Fixes: e6541fdec8b2 ("meter: initial import")
> >
> > Signed-off-by: Slawomir
> > Fix issue reported by Coverity.
> >
> > Coverity ID 30690: Bad bit shift operation
> > large_shift: In expression 1ULL << i, left shifting by more than 63 bits
> > has undefined behavior. The shift amount, i, is as much as 127.
> >
> > Fixes: de3cfa2c9823 ("sched: initial import")
> >
> >
> > Subject: [PATCH v4] examples/qos_sched: fix bad bit shift operation
Slawomir, please use --in-reply-to when sending a new revision,
to let us see the full history in our mailer and in the archives.
[...]
> > diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c
> > index
copy-paste is the cause of this error.
The headline should show which error is fixed (or briefly its impact area).
Here: "fix error message"
> > Fix issue reported by Coverity.
> >
> > Coverity ID 30699: Copy-paste error;
> > rx_port in pconf->rx_port looks like a copy-paste error.
> >
> >
> > Fix issue reported by Coverity.
> >
> > Coverity ID 30704: Negative loop bound
> > negative_returns: Using unsigned variable n_tokens in a loop exit condition.
> >
> > Fixes: de3cfa2c9823 ("sched: initial import")
> >
> > Signed-off-by: Slawomir Mrozowicz
>
> Acked-by: Cristian Dumitrescu
> > Fix issue reported by Coverity.
> >
> > Coverity ID 30708: Out-of-bounds read
> > overrun-local: Overrunning array tokens of 8 8-byte elements
> > at element index 4294967294 (byte offset 34359738352)
> > using index i (which evaluates to 4294967294).
> >
> > Fixes: de3cfa2c9823 ("sched:
Unchecked return value: value returned from a function rdline_init is
not checked, fix added checking return value and in the case of failure
frees memory and return null pointer.
Fixes: af75078fece3 ("first public release")
Coverity ID 13204
Signed-off-by: Marcin Kerlin
---
>There is no inverse of rte_mempool_create, so this patch adds one.
>The typical usage of rte_mempool_create is to create a pool at
>initialization time and only to free it upon program exit, so an
>rte_mempool_free function at first seems to be of little value.
>However, it is very useful as a
On 05/16/2016 04:18 PM, Fan Zhang wrote:
> The ABI changes are planned for rte_port_sink_params, which will be
> supported from release 16.11. Here announces that ABI changes in detail.
>
> Signed-off-by: Fan Zhang
> Acked-by: Cristian Dumitrescu
> ---
> doc/guides/rel_notes/deprecation.rst | 4
This tool searches for the primer sting PMD_DRIVER_INFO= in any ELF binary,
and, if found parses the remainder of the string as a json encoded string,
outputting the results in either a human readable or raw, script parseable
format
Signed-off-by: Neil Horman
CC: Bruce Richardson
CC: Thomas
Modify the compilation makefile to identify C files that export PMD information,
and use that to trigger execution of the pmdinfo binary. If the execution of
pmdinfo is successful, compile the output C file to an object, and use the
linker to do relocatable linking on the resultant object file
Modify the PMD_REGISTER_DRIVER macro, bifurcating it into two
(PMD_REGISTER_DRIVER_PDEV and PMD_REGISTER_DRIVER_VDEV. Both of these do the
same thing the origional macro did, but both add the definition of a string
variable that informs interested parties of the name of the pmd, and the former
pmdinfo is a tool used to parse object files and build json strings for use in
later determining hardware support in a dso or application binary. pmdinfo
looks for the non-exported symbol names this_pmd_name and this_pmd_tbl
(where n is a integer counter). It records the name of each of these
Hey all-
So heres attempt number 2 at a method for exporting PMD hardware support
information. As we discussed previously, the consensus seems to be that pmd
information should be:
1) Able to be interrogated on any ELF binary (application binary or individual
DSO)
2) Equally functional
2016-05-16 14:11, Wiles, Keith:
> >2016-05-13 15:48, Wiles, Keith:
> >> I create this new tool to combine some information and use /sys/devices
> >> instead. What I was hoping was some of you could try this script and see
> >> if it works correctly. Also I was hope to find out if this script is
Hi John,
> Reviewed-by: John McNamara
> Acked-by: John McNamara
The meaning of Reviewed-by and Acked-by can be slightly different
but I don't think we need to put both.
In this case, as the doc maintainer, your ack should be fine.
By the way, I'm totally OK to discuss a better description of
On 2016-05-16 14:43, Pattan, Reshma wrote:
>>> This was added to allow devices, at least with one direction (RX/TX)
>> supported. As, devices with both directions disabled doesn't make sense
>> right?
>>
>> Well, not for running them, no. But this is a part of the shutdown procedure
>> between
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Monday, May 16, 2016 3:32 PM
> To: Wiles, Keith
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [RFC PATCH] tools:new tool for system info CPU,
> memory and huge pages
>
> 2016-05-16
Hello Bruce,
Although having this support does not harm anyone, I am not convinced that
it is useful, mainly because there exists the single-thread limitation in
other PMDs. Then, if an application has to use different kind of NICs (i.e,
different PMDs) it has to implement the locking strategies.
2016-05-16 14:39 GMT+02:00 Mcnamara, John :
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
>> The next statement is probably a useless copy paste of the coverity
>> report.
>>
>> > In send_msg: Negative value used as argument to a function expecting a
>> > positive value
2016-05-10 17:49, Daniel Mrzyglod:
> CID30691:
> If the buffer is treated as a null terminated string in later operations,
> a buffer overflow or over-read may occur.
>
> In add_vm: The string buffer may not have a null terminator if the source
> string's length is equal to the buffer size
>
>
>2016-05-16 14:11, Wiles, Keith:
>> >2016-05-13 15:48, Wiles, Keith:
>> >> I create this new tool to combine some information and use /sys/devices
>> >> instead. What I was hoping was some of you could try this script and see
>> >> if it works correctly. Also I was hope to find out if this
2016-05-09 11:38, Daniel Mrzyglod:
> Fix issue reported by Coverity.
> Coverity ID 30692
Better to put reference on top of Fixes: line.
> If the function returns an error value, the error value may be mistaken for
> a normal value.
>
> In kni_free_kni: Value returned from a function is not
Hi Beilei,
On 05/13/2016 10:15 AM, Beilei Xing wrote:
> This patch enables configuring MTU for i40e.
> Since changing MTU needs to reconfigure queue, stop port first
> before configuring MTU.
>
> Signed-off-by: Beilei Xing
> ---
> v3 changes:
> Add frame size with extra I40E_VLAN_TAG_SIZE.
>
The ABI changes are planned for rte_port_sink_params, which will be
supported from release 16.11. Here announces that ABI changes in detail.
Signed-off-by: Fan Zhang
Acked-by: Cristian Dumitrescu
---
doc/guides/rel_notes/deprecation.rst | 4
1 file changed, 4 insertions(+)
diff --git
The ABI changes are planned for rte_port_source_params, which will be
supported from release 16.11. Here announces that ABI changes in detail.
Signed-off-by: Fan Zhang
Acked-by: Cristian Dumitrescu
---
doc/guides/rel_notes/deprecation.rst | 4
1 file changed, 4 insertions(+)
diff --git
The ABI changes are planned for rte_port_source_params and
rte_port_sink_params, which will be supported from release 16.11. Here
announces that ABI changes in detail.
Fan Zhang (2):
doc: announce ABI change of struct rte_port_source_params
doc: announce ABI change of struct
The title do not convey the real issue.
We should be more concerned by an issue of "wrong error message"
rather than an "argument" which "cannot be negative".
2016-04-20 16:39, Daniel Mrzyglod:
> Fix issue reported by Coverity.
> Coverity ID 13269 & 13266:
It is better to put these references
On Mon, May 16, 2016 at 03:12:10PM +0200, Mauricio V?squez wrote:
> Hello Bruce,
>
> Although having this support does not harm anyone, I am not convinced that
> it is useful, mainly because there exists the single-thread limitation in
> other PMDs. Then, if an application has to use different
>2016-05-13 15:48, Wiles, Keith:
>> I create this new tool to combine some information and use /sys/devices
>> instead. What I was hoping was some of you could try this script and see if
>> it works correctly. Also I was hope to find out if this script is useful and
>> what other features you
Hi Wenzhuo,
On 05/04/2016 11:10 PM, Wenzhuo Lu wrote:
> When the physical link is down and recover later,
> the VF link cannot recover until the user stop and
> start it manually.
> This patch implements the automatic recovery of VF
> port.
> The automatic recovery bases on the link up/down
>
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Monday, May 16, 2016 2:00 PM
> ...
> > A question on this point. Is it just that the Coverity message is
> > useless in this case or in general? For other error/warning fixes we
> > include the
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jingjing Wu
> Sent: Friday, May 13, 2016 6:15 AM
> To: david.marchand at 6wind.com
> Cc: dev at dpdk.org; Wu, Jingjing ; Yang, Ziye
> ; Richardson, Bruce
> Subject: [dpdk-dev] [PATCH] doc: known issue on EAL
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Kobylinski, MichalX
> Sent: Monday, May 16, 2016 1:51 PM
> To: Thomas Monjalon
> Cc: dev at dpdk.org; Dumitrescu, Cristian
> Subject: Re: [dpdk-dev] [PATCH] cfgfile: fix integer overflow
> ...
> Coverity
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Monday, May 16, 2016 12:06 PM
> To: Kobylinski, MichalX
> Cc: dev at dpdk.org; Dumitrescu, Cristian
> Subject: Re: [dpdk-dev] [PATCH] cfgfile: fix integer overflow
> Importance: High
>
>
> -Original Message-
> From: Simon K?gstr?m [mailto:simon.kagstrom at netinsight.net]
> Sent: Monday, May 16, 2016 11:33 AM
> To: Pattan, Reshma ; dev at dpdk.org;
> thomas.monjalon at 6wind.com
> Subject: Re: [PATCH / RFC ] ethdev: Allow rte_eth_dev_configure with zero
> RX/TX queues
>
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Monday, May 16, 2016 1:17 PM
> To: Mrzyglod, DanielX T
> Cc: dev at dpdk.org; Carew, Alan
> Subject: Re: [dpdk-dev] [PATCH] power: fix argument cannot be negative
>
> The next
On 2016-05-16 12:24, Pattan, Reshma wrote:
>> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
>> index
>> a31018e..5481d45 100644
>> --- a/lib/librte_ether/rte_ethdev.c
>> +++ b/lib/librte_ether/rte_ethdev.c
>> @@ -944,11 +944,6 @@ rte_eth_dev_configure(uint8_t port_id,
On 5/15/2016 5:48 AM, ALeX Wang wrote:
> Hi,
>
> When using the kni module to test my application inside
> debian (virtualbox) VM (kernel version 4.4), I get the
>
> "KNI: Out of memory"
>
> from syslog every time I `tcpreply` packets through
> the kni interface.
>
> After checking source
2016-04-28 11:09, Dumitrescu, Cristian:
> From: Kobylinski, MichalX
> > Fix issue reported by Coverity.
> >
> > Coverity ID 13289: Integer overflowed argument: The argument will be too
> > small or even negative, likely resulting in unexpected behavior (for
> > example, under-allocation in a
Hi Konstantin,
Now, the attach operation increases refcnt, but the detach does not decrease it.
I think both operations should affect refcnt or not.
Which design is intended?
In "6.7. Direct and Indirect Buffers" of Programmer's Guide,
it is mentioned that "...whenever an indirect buffer is
This allows releasing RX/TX queue memory.
---
We're using DPDK 16.04 and have a test suite which performs a sequence
of separate tests of the type
allocate mempool
rte_eth_dev_configure(port, n_rxq, n_txq, ...)
setup rx/tx queues
rte_eth_dev_start(port)
stop rx/tx queues
2016-05-13 15:48, Wiles, Keith:
> I create this new tool to combine some information and use /sys/devices
> instead. What I was hoping was some of you could try this script and see if
> it works correctly. Also I was hope to find out if this script is useful and
> what other features you would
Hi Slawomir,
On 05/12/2016 02:46 PM, Slawomir Mrozowicz wrote:
> Fix issue reported by Coverity.
>
> Coverity ID 13243: Division or modulo by zero
> In function call rte_mempool_xmem_size, division by expression total_size
> which may be zero has undefined behavior.
>
> Fixes: 148f963fb532
2016-05-16 11:46, Hiroyuki MIKITA:
> Now, the attach operation increases refcnt, but the detach does not decrease
> it.
> I think both operations should affect refcnt or not.
> Which design is intended?
>
> In "6.7. Direct and Indirect Buffers" of Programmer's Guide,
> it is mentioned that
> -Original Message-
> From: Olivier Matz [mailto:olivier.matz at 6wind.com]
> Sent: Friday, May 13, 2016 2:28 PM
> To: dev at dpdk.org
> Cc: Mcnamara, John
> Subject: [PATCH] doc: move rel_notes instructions as comments
>
> We don't want to have this instructions in the generated docs,
Hi Hiroyuki,
On 05/15/2016 05:50 PM, Hiroyuki Mikita wrote:
> The rte_pktmbuf_detach() function should decrease refcnt on a direct
> buffer.
>
> Signed-off-by: Hiroyuki Mikita
> ---
> lib/librte_mbuf/rte_mbuf.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git
On Mon, May 16, 2016 at 01:48:01AM +, Tan, Jianfeng wrote:
> > On Fri, May 13, 2016 at 09:54:33AM +0800, Tan, Jianfeng wrote:
> > >
> > > So, I'd suggest something like following:
> > >
> > > if (is_vdev(..)) {
> > >
> > >
> > > The blocker issue of your suggestion is that we
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton
> Sent: Friday, May 6, 2016 12:11 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [RFC PATCH v2 1/3] rte: change xstats to use integer
> keys
>
> Signed-off-by: Remy Horton
> ---
Acked-by: Maryam Tahhan
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton
> Sent: Friday, May 6, 2016 12:11 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [RFC PATCH v2 0/3] Remove string operations from
> xstats
>
> The current extended ethernet statistics fetching involve doing several
> string
> -Original Message-
> From: Simon Kagstrom [mailto:simon.kagstrom at netinsight.net]
> Sent: Monday, May 16, 2016 10:34 AM
> To: dev at dpdk.org; thomas.monjalon at 6wind.com; Pattan, Reshma
>
> Subject: [PATCH / RFC ] ethdev: Allow rte_eth_dev_configure with zero RX/TX
> queues
>
>
There is no inverse of rte_mempool_create, so this patch adds one.
The typical usage of rte_mempool_create is to create a pool at
initialization time and only to free it upon program exit, so an
rte_mempool_free function at first seems to be of little value.
However, it is very useful as a sanity
Hi Hiroyuki,
>
> Hi Konstantin,
>
> Now, the attach operation increases refcnt, but the detach does not decrease
> it.
> I think both operations should affect refcnt or not.
> Which design is intended?
>
> In "6.7. Direct and Indirect Buffers" of Programmer's Guide,
> it is mentioned that
Hi Ferruh,
Thx for pointing out the 'fill alloc_q with these mubfs _until it gets
full_.',
I saw the size of all queues are 'KNI_FIFO_COUNT_MAX (1024)'...
The corresponding memory required is more than what I specify as
'socket_mem' (since i'm using VM)...
Also, in my use case, I only
Hi Yuanhan,
> -Original Message-
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Friday, May 13, 2016 12:45 PM
> To: Tan, Jianfeng
> Cc: dev at dpdk.org; Xie, Huawei; rich.lane at bigswitch.com; mst at
> redhat.com;
> nakajima.yoshihiro at lab.ntt.co.jp; p.fedin at
The rte_pktmbuf_detach() function should decrease refcnt on a direct
buffer.
Signed-off-by: Hiroyuki Mikita
---
lib/librte_mbuf/rte_mbuf.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index 529debb..3b117ca 100644
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Hiroyuki Mikita
> Sent: Sunday, May 15, 2016 4:51 PM
> To: olivier.matz at 6wind.com
> Cc: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] mbuf: decrease refcnt when detaching
>
> The rte_pktmbuf_detach()
62 matches
Mail list logo
