Hello Thomas,
On Fri, May 13, 2016 at 6:20 PM, Thomas Monjalon
wrote:
> 2016-04-29 17:23, Mauricio Vasquez B:
> > The RTE_ETH_VALID_PORTID_OR_ERR_RET macro is used in some places
> > to check if a port id is valid or not. This commit makes use of it in
> > some new parts of the code.
>
> There
The RTE_ETH_VALID_PORTID_OR_ERR_RET macro is used in some places
to check if a port id is valid or not. This commit makes use of it in
some new parts of the code.
Signed-off-by: Mauricio Vasquez B
---
v2:
- add missed case
- change also cases in examples/ethtool/lib/rte_ethtool.c
examples/etht
Dumping of devices in a unittest is useless. Instead, test whether the test
has been set up well - i.e. there are no devices.
Signed-off-by: Jan Viktorin
---
app/test/test_pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test/test_pci.c b/app/test/test_pci.c
inde
Scan the PCI bus by providing a fake sysfs with a PCI device. The fake sysfs
is a packed file hierarchy linked into the test.
Signed-off-by: Jan Viktorin
---
app/test/Makefile | 1 +
app/test/test_pci.c| 58 +++--
The SYSFS_PCI_DEVICES is a constant that makes the PCI testing difficult as
it points to an absolute path. We remove using this constant and introducing
a function pci_get_sysfs_path that gives the same value. However, the user can
pass a SYSFS_PCI_DEVICES env variable to override the path. It is n
The current test_pci is just a single test case that tests the blacklisting
of devices. Rename it to test_pci_blacklist and call it from the test_pci.
The setup and cleanup are moved out of the test_pci_blacklist entirely
to cover all other tests.
Signed-off-by: Jan Viktorin
---
v3:
* improved co
Signed-off-by: Jan Viktorin
---
app/test/test_pci.c | 47 ++-
1 file changed, 34 insertions(+), 13 deletions(-)
diff --git a/app/test/test_pci.c b/app/test/test_pci.c
index 8b7c8bb..50078a0 100644
--- a/app/test/test_pci.c
+++ b/app/test/test_pci.c
@@
The test unregisters all drivers before start. The drivers were stored
into a fixed-sized array. This is inflexible. This patch change this to
utilize a linked list for the same purpose.
Signed-off-by: Jan Viktorin
---
v3:
* fixed commit message
* used "backup" to describe the real_pci_driver_lis
When a more complex resource (a file hierarchy) is needed, packing every single
file as a single resource would be very ineffective. For that purpose, it is
possible to pack the files into a tar archive, extract it before test from the
resource and finally clean up all the created files.
This patc
A resource can be written into the target filesystem by calling resource_fwrite
or resource_fwrite_file. Such file can be created before a test is started and
removed after the test finishes.
Signed-off-by: Jan Viktorin
---
app/test/resource.c | 35 +++
app/t
To include resources from other source that the C source code we can take
advantage of the objcopy behaviour, i.e. packing of an arbitrary file as an
object file that is linked to the target program.
A linked object file is always accessible as a pair
extern const char beg_;
extern const char end
The program objcopy uses non-standard conventions to name the target and arch.
Define the values for supported architectures.
FIXME: tile and ppc_64 are not present.
Signed-off-by: Jan Viktorin
---
mk/arch/arm/rte.vars.mk | 5 +
mk/arch/arm64/rte.vars.mk | 5 +
mk/arch/i686/rte.va
Certain internal mechanisms of DPDK access different file system structures
(e.g. /sys/bus/pci/devices). It is difficult to test those cases automatically
by a unit test when such path is not hard-coded and there is no simple way how
to distribute fake ones with the current testing environment.
Th
Hello,
the third round with fixes based on suggestions by T. Monjalon.
This patch set introduces a mechanism to include a resource (in general a blob)
into the test binary. This allows to make tests less dependent on the target
testing environment. The first use case is testing of PCI bus scan by
On Fri, 13 May 2016 09:22:23 +0800
Jianbo Liu wrote:
> On 6 May 2016 at 21:47, Jan Viktorin wrote:
> > Generalize the PCI-specific pci_unbind_kernel_driver. It is now divided into
> > two parts. First, determination of the path and string identification of the
> > device to be unbound. Second, t
On Fri, 13 May 2016 11:28:18 +0800
Jianbo Liu wrote:
> On 6 May 2016 at 21:47, Jan Viktorin wrote:
> > This option has the same meaning for the SoC infra as the --no-pci
> > for the PCI infra.
> >
> > Signed-off-by: Jan Viktorin
> > ---
> > lib/librte_eal/common/eal_common_options.c | 5 +
Hello Olivier...
On Tue, 17 May 2016 15:56:32 +0200
Olivier MATZ wrote:
> Hi Jan,
>
> On 05/17/2016 02:34 PM, Jan Viktorin wrote:
> > Hello,
> >
> > I was trying to find out the status of the mempool rework and found
> > this 36-pieces long patch set:
> >
> > http://dpdk.org/ml/archives/dev/201
2016-05-12 00:44, Jianfeng Tan:
> This patch adds an option, --huge-trybest, to use a recover mechanism to
> the case that there are not so many hugepages (declared in sysfs), which
> can be used. It relys on a mem access to fault-in hugepages, and if fails
relys -> relies
> with SIGBUS, recover
Hello Jianfeng,
On Thu, May 12, 2016 at 2:44 AM, Jianfeng Tan wrote:
> This patch adds an option, --huge-trybest, to use a recover mechanism to
> the case that there are not so many hugepages (declared in sysfs), which
> can be used. It relys on a mem access to fault-in hugepages, and if fails
>
On Mon, May 9, 2016 at 6:13 PM, Olivier Matz wrote:
> From: Maxime Leroy
>
> The functions rte_log_cur_msg_loglevel() and rte_log_cur_msg_logtype()
> return the current log level/type for the message being processed. They
> are used when implementing a user-defined logging stream.
>
> The current
Hello Olivier,
On Tue, May 17, 2016 at 11:59 AM, Olivier Matz
wrote:
> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
> b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
> index ac449c5..077ad96 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_p
Added programmers guide for librte_pdump.
Added sample application guide for app/pdump application.
Updated release note for packet capture framework changes.
Signed-off-by: Reshma Pattan
---
MAINTAINERS | 3 +
doc/guides/prog_guide/index.rst | 1 +
doc/gu
Call rte_pdump_init and rte_pdump_uninit for packet
capturing initialization and uninitialization.
Signed-off-by: Reshma Pattan
---
app/test-pmd/testpmd.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 26a174c..e131363 100644
--- a
New tool added for packet capturing on dpdk.
This tool supports command line options.
This tool runs as secondary process by default.
Command line supports various parameters to capture
the packets.
User should pass on a)port and queue (or) b)pci address
and queue (or) c)device name and queue to
Added new library for packet capturing support.
Added public api rte_pdump_init, applications should call
this as part of their application setup to have packet
capturing framework ready.
Added public api rte_pdump_uninit to un initialize the packet
capturing framework.
Added public apis rte_pdu
Converted rte_eth_dev_get_port_by_name to public API.
Signed-off-by: Reshma Pattan
---
lib/librte_ether/rte_ethdev.c | 2 +-
lib/librte_ether/rte_ethdev.h | 15 +++
lib/librte_ether/rte_ether_version.map | 1 +
3 files changed, 17 insertions(+), 1 deletion(-)
dif
Add new fields to rte_eth_dev_info struct
New fields nb_rx_queues and nb_tx_queues are added to
rte_eth_dev_info structure.
Changes to API rte_eth_dev_info_get() are done to update
these new fields to rte_eth_dev_info object.
Signed-off-by: Reshma Pattan
---
lib/librte_ether/rte_ethdev.c
Added new public api rte_eth_add_first_rx_callback to add given
callback as head of list.
Signed-off-by: Reshma Pattan
---
lib/librte_ether/rte_ethdev.c | 35 ++
lib/librte_ether/rte_ethdev.h | 27 ++
lib/librte_ether/rte_
Added spinlocks around add/remove logic of rxtx callbacks to
avoid corruption of callback lists in multithreaded context.
Signed-off-by: Reshma Pattan
---
lib/librte_ether/rte_ethdev.c | 82 +--
1 file changed, 40 insertions(+), 42 deletions(-)
diff --git
This patchset include below changes
1)Changes to librte_ether.
2)New library librte_pdump added for packet capture framework.
3)New app/pdump tool added for packet capturing.
4)Test pmd changes done to initialize packet capture framework.
5)Documentation update.
1)librte_pdump
==
To su
Hi Gayathri,
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of
> gayathri.manepalli at wipro.com
> Sent: Friday, May 13, 2016 7:44 AM
> To: dev at dpdk.org
> Cc: Stokes, Ian
> Subject: [dpdk-dev] [ovs-dev] Traffic scheduling by qos_sched library in
> DPDK
>
>
This patch fixes the NULL packet processing problem. Originally,
pipeline's write attempt to NULL packets generated by source
port may crash the application.
This patch fixes the problem by enforcing each source port
defined in cfg file containing a user specified or default pcap
file path.
Fixes
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jerin Jacob
> Sent: Saturday, May 7, 2016 4:17 PM
> To: dev at dpdk.org
> Cc: thomas.monjalon at 6wind.com; Richardson, Bruce
> ; Jerin Jacob
> ; Slawomir Rosek
>
> Subject: [dpdk-dev] [PATCH 19/20] thunderx/nic
2016-05-17 13:44, Ananyev, Konstantin:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > 2016-05-17 12:59, Ananyev, Konstantin:
> > > > > The rte_pktmbuf_detach() function should decrease refcnt on a direct
> > > > > buffer.
> > > >
> > > > As you have noticed, "whenever the indirec
Hi Jan,
On 05/17/2016 02:34 PM, Jan Viktorin wrote:
> Hello,
>
> I was trying to find out the status of the mempool rework and found
> this 36-pieces long patch set:
>
> http://dpdk.org/ml/archives/dev/2016-April/037464.html
>
> (I failed to apply it to 16.04, 2.1.0, current HEAD.)
It should be i
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Tuesday, May 17, 2016 3:19 PM
> To: Ananyev, Konstantin
> Cc: dev at dpdk.org; Hiroyuki Mikita; olivier.matz at 6wind.com
> Subject: Re: [dpdk-dev] [PATCH v2] mbuf: decrease refcnt when detaching
>
2016-05-17 12:59, Ananyev, Konstantin:
> > > The rte_pktmbuf_detach() function should decrease refcnt on a direct
> > > buffer.
> >
> > As you have noticed, "whenever the indirect buffer is detached,
> > the reference counter on the direct buffer is decremented."
> > So the current behaviour of rt
2016-05-17 13:37, Fan Zhang:
> This patch fixes the NULL packet processing problem. Originally,
> the write to NULL packets generated by source port will crash
> the ip pipeline application. This patch enforces, unless
> specified, a default pcap file path to be read.
I failed to understand.
Pleas
2016-05-17 01:53, Hiroyuki Mikita:
> The rte_pktmbuf_detach() function should decrease refcnt on a direct
> buffer.
>
> Signed-off-by: Hiroyuki Mikita
> ---
> v2:
> * introduced a new function rte_pktmbuf_detach2() which decrease refcnt.
As you have noticed, "whenever the indirect buffer is deta
Hello,
I was trying to find out the status of the mempool rework and found
this 36-pieces long patch set:
http://dpdk.org/ml/archives/dev/2016-April/037464.html
(I failed to apply it to 16.04, 2.1.0, current HEAD.)
and some bits around:
http://dpdk.org/ml/archives/dev/2016-May/038390.html
http
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Tuesday, May 17, 2016 2:40 PM
> To: Ananyev, Konstantin
> Cc: dev at dpdk.org; Hiroyuki Mikita; olivier.matz at 6wind.com
> Subject: Re: [dpdk-dev] [PATCH v2] mbuf: decrease refcnt when detaching
>
This patch fixes the NULL packet processing problem. Originally,
the write to NULL packets generated by source port will crash
the ip pipeline application. This patch enforces, unless
specified, a default pcap file path to be read.
Fixes: 0e1e7d53 ("add pcap file source")
Signed-off-by: Fan Zhang
Hi Thomas,
> > The rte_pktmbuf_detach() function should decrease refcnt on a direct
> > buffer.
> >
> > Signed-off-by: Hiroyuki Mikita
> > ---
> > v2:
> > * introduced a new function rte_pktmbuf_detach2() which decrease refcnt.
>
> As you have noticed, "whenever the indirect buffer is detached,
Now that virtio pmd is supported on ppc, enable it.
Signed-off-by: Olivier Matz
---
config/defconfig_ppc_64-power8-linuxapp-gcc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/config/defconfig_ppc_64-power8-linuxapp-gcc
b/config/defconfig_ppc_64-power8-linuxapp-gcc
index 9eb
From: David Marchand
Although ppc supports both endianesses, qemu supposes that the cpu is
big endian and enforces this for the virtio-net stuff.
Fix PCI accesses in legacy mode. Only ppc64le is supported at the moment.
Signed-off-by: David Marchand
Signed-off-by: Olivier Matz
---
drivers/ne
On PPC64, the ioports are mapped in memory. Implement the missing part
of ioport API for PPC64 when using uio. This may also work on other
architectures but it has not been tested.
Signed-off-by: David Marchand
Signed-off-by: Olivier Matz
---
lib/librte_eal/common/include/rte_pci.h| 4 +-
Split pci_parse_sysfs_resource() and introduce
pci_parse_one_sysfs_resource() that parses one line of sysfs resource
file.
This new function will be exported and used in next commits when
mapping the ioports resources.
No functional change.
Signed-off-by: Olivier Matz
---
lib/librte_eal/linuxa
In a previous commit, the file used to map the PCI resources changed
from "/dev/uio" to "/sys/bus/pci/devices//resource", making
the comment wrong. Remove it.
Fixes: 9e67561acd1a ("eal/linux: mmap uio resources using resourceX files")
Signed-off-by: Olivier Matz
---
lib/librte_eal/linuxapp/eal/e
>From iopl(2) man page: "This call is mostly for the x86 architecture. On
many other architectures it does not exist or will always return an
error".
This patch removes the call to iopl() in rte_eal_iopl_init() for
architectures other than x86, and always return 0 (success). This was
already done
Fix some typos and add missing comments related to ioports API in
rte_pci.h.
Fixes: 756ce64b1 ("eal: introduce PCI ioport API")
Signed-off-by: Olivier Matz
---
lib/librte_eal/common/include/rte_pci.h | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/lib/librte_eal/comm
This patchset allows virtio-net pmd to run on ppc64 processors.
The main thing that as missing was the support of ioports in EAL.
It also fixes some endianess issues in PCI config accesses in
legacy mode.
v1 -> v2:
- fix read/write lengths management in virtio (this fixes
the reading of mac
On Tue, May 17, 2016 at 01:53:20AM +0900, Hiroyuki Mikita wrote:
> The rte_pktmbuf_detach() function should decrease refcnt on a direct
> buffer.
>
> Signed-off-by: Hiroyuki Mikita
> ---
> v2:
> * introduced a new function rte_pktmbuf_detach2() which decrease refcnt.
> * marked rte_pktmbuf_detach
On 5/16/2016 4:31 PM, ALeX Wang wrote:
> Hi Ferruh,
>
> Thx for pointing out the 'fill alloc_q with these mubfs _until it gets
> full_.',
>
> I saw the size of all queues are 'KNI_FIFO_COUNT_MAX (1024)'...
> The corresponding memory required is more than what I specify as
> 'socket_mem' (since i'
Hi Hiroyuki,
>
> The rte_pktmbuf_detach() function should decrease refcnt on a direct
> buffer.
>
> Signed-off-by: Hiroyuki Mikita
> ---
> v2:
> * introduced a new function rte_pktmbuf_detach2() which decrease refcnt.
> * marked rte_pktmbuf_detach() as deprecated.
> * added comments about refcn
From: Marcin Kerlin
The value returned by rdline_init() was not checked in cmdline_new().
On error, free the allocated memory and return NULL.
This condition should not happen today, but it's safer to do the check
in case rdline_init() is updated.
Fixes: af75078fece3 ("first public release")
Co
Hi,
On 05/17/2016 09:55 AM, Mrozowicz, SlawomirX wrote:
> Hi,
>
> Noticed is that in the file:
>
> app/test-pmd/mempool.c
>
> using of the function munmap() could cause a problem.
>
> Coverity static code analyzer provide error (CID 13184) in line 158:
>
> munmap frees incorrect pointer uv.
>
> I
On 17 May 2016 at 03:07, Ferruh Yigit wrote:
> On 5/16/2016 4:31 PM, ALeX Wang wrote:
> > Hi Ferruh,
> >
> > Thx for pointing out the 'fill alloc_q with these mubfs _until it gets
> > full_.',
> >
> > I saw the size of all queues are 'KNI_FIFO_COUNT_MAX (1024)'...
> > The corresponding memory req
Hi Wenzhuo,
On 05/17/2016 03:11 AM, Lu, Wenzhuo wrote:
>> -Original Message-
>> From: Olivier Matz [mailto:olivier.matz at 6wind.com]
>> If I understand well, ixgbevf_dev_link_up_down_handler() is called by
>> ixgbevf_recv_pkts_fake() on a dataplane core. It means that the core that
>> acq
Hello Benjamin,
On 05/16/2016 09:56 PM, Walker, Benjamin wrote:
> On Mon, 2016-05-16 at 16:57 +, Wiles, Keith wrote:
>>>
>>> There is no inverse of rte_mempool_create, so this patch adds one.
>>> The typical usage of rte_mempool_create is to create a pool at
>>> initialization time and only to
The log unit test was checking display of low priority messages.
It was not working if RTE_LOG_LEVEL is not RTE_LOG_DEBUG.
It is even easier to see since the default level is INFO (9b9d7ca).
Now the test use ERR and CRIT levels which should be always enabled
while not trigerring syslog output on t
Hello Thomas,
On Wed, May 4, 2016 at 3:34 PM, Thomas Monjalon
wrote:
> The log unit test was checking display of low priority messages.
> It was not working if RTE_LOG_LEVEL is not RTE_LOG_DEBUG.
> It is even easier to see since the default level is INFO (9b9d7ca).
>
> Now the test use ERR and CR
2016-05-11 16:43, Olivier Matz:
> Many drivers provide their own implementation of rte_mbuf_raw_alloc(),
> duplicating the code. Introduce a new public function in rte_mbuf to
> allocate a raw mbuf (uninitialized).
>
> Signed-off-by: Olivier Matz
Applied, thanks
Hi Olivier,
> -Original Message-
> From: Olivier MATZ [mailto:olivier.matz at 6wind.com]
> Sent: Tuesday, May 17, 2016 3:51 PM
> To: Lu, Wenzhuo; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 3/4] ixgbe: automatic link recovery on VF
>
> Hi Wenzhuo,
>
> On 05/17/2016 03:11 AM, Lu, Wen
Thanks for adding this, I've been missing this function!
On 2016-05-16 21:56, Walker, Benjamin wrote:
> On Mon, 2016-05-16 at 16:57 +, Wiles, Keith wrote:
>> The big question is how do you know the mempool is not being used someplace?
>
> That's the user's responsibility. Use after free is c
Hi,
Noticed is that in the file:
app/test-pmd/mempool.c
using of the function munmap() could cause a problem.
Coverity static code analyzer provide error (CID 13184) in line 158:
munmap frees incorrect pointer uv.
I noticed information on the net:
https://www.ibm.com/support/knowledgecenter/SSLT
> > We don't want to have this instructions in the generated docs, so use
> > comments. It's also less confusing for people adding entries in the
> > documentation.
> >
> > Signed-off-by: Olivier Matz
>
> Good idea.
>
> Reviewed-by: John McNamara
> Acked-by: John McNamara
Applied, thanks
2016-04-14 11:42, Olivier Matz:
> From: Keith Wiles
>
> The rte_mempool structure is changed, which will cause an ABI change
> for this structure. Providing backward compat is not reasonable
> here as this structure is used in multiple defines/inlines.
The deprecation notice must be removed by t
Shucong:
The validation for patches has been done.
-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Horton, Remy
Sent: Friday, April 29, 2016 1:41 PM
To: dev at dpdk.org
Subject: [dpdk-dev] [PATCH v1 0/3] Keep-alive enhancements
This patchset adds enhanceme
The rte_pktmbuf_detach() function should decrease refcnt on a direct
buffer.
Signed-off-by: Hiroyuki Mikita
---
v2:
* introduced a new function rte_pktmbuf_detach2() which decrease refcnt.
* marked rte_pktmbuf_detach() as deprecated.
* added comments about refcnt to rte_pktmbuf_attach() and rte_p
Hi all,
Thanks for suggestions.
I think the Oliver's first option is good.
I introduce the new function and will replace rte_pktmbuf_detach()
with it in a future release.
2016-05-16 18:13 GMT+09:00 Thomas Monjalon :
> 2016-05-16 11:46, Hiroyuki MIKITA:
>> Now, the attach operation increases refc
Hi Olivier,
> -Original Message-
> From: Olivier Matz [mailto:olivier.matz at 6wind.com]
> Sent: Monday, May 16, 2016 8:01 PM
> To: Lu, Wenzhuo; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 3/4] ixgbe: automatic link recovery on VF
>
> Hi Wenzhuo,
>
> On 05/04/2016 11:10 PM, Wenzhuo
71 matches
Mail list logo
