[dpdk-dev] [PATCH] ip_pipeline: fix parsing error in TM port section

2016-06-21 Thread Thomas Monjalon
2016-06-16 10:04, Jasvinder Singh: > Replace APP_PARAM_ADD_LINK_FOR_TXQ with APP_PARAM_ADD_LINK_FOR_TM macro > in TM (Traffic Manager) port section parsing function. This macro adds > nic ports entry specified in TM port section of the application > configuration file to the application parameters

[dpdk-dev] [PATCH v3] lib/table: fix wrong type of nht field

2016-06-21 Thread Thomas Monjalon
2016-06-21 15:20, Michal Kobylinski: > Change type of nht field from uint32_t to uint8_t and increase max of > next hops. > > nht_entry and nht should be declared as uint8_t because > entry_size is in bytes and is given as a parameter to compute > the position in nht array. > > Fixes:

[dpdk-dev] [PATCH v6 1/4] lib/librte_ether: support device reset

2016-06-21 Thread Jerin Jacob
On Tue, Jun 21, 2016 at 02:03:15PM +, Ananyev, Konstantin wrote: > > > > > > > > Hi Wenzhuo, > > > > > > > > > > > > > > > > > > On Mon, Jun 20, 2016 at 02:24:27PM +0800, Wenzhuo Lu > > > > > > > > > > > > wrote: > > > > > > > > > > > > > Add an API to reset the device. > > > > > > > > > >

[dpdk-dev] [PATCH v3 1/3] port: add kni interface support

2016-06-21 Thread Ethan
Hi Cristian, New patch has been submitted. All comments are fixed except this one: "Here is one bug for you, you need to make sure you add the following line here: param->parsed = 1;" I think the new convention is to set this flag by the macro PARSE_CHECK_DUPLICATE_SECTION. BTW, although

[dpdk-dev] [PATCH v6 1/4] lib/librte_ether: support device reset

2016-06-21 Thread Jerin Jacob
On Tue, Jun 21, 2016 at 01:10:40PM +, Ananyev, Konstantin wrote: > > > > > > Hi Konstantin, > > > > > Hi Jerin, > > > > > > > -Original Message- > > > > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > > > > Sent: Tuesday, June 21, 2016 9:56 AM > > > > To: Lu, Wenzhuo

[dpdk-dev] [PATCH v4 4/4] doc: kni port support in the packet framework

2016-06-21 Thread Ethan Zhuang
From: WeiJie Zhuang add some descriptions for the kni port in the packet framework Signed-off-by: WeiJie Zhuang --- doc/api/doxy-api-index.md| 1 + doc/guides/sample_app_ug/ip_pipeline.rst | 112 +++ 2 files changed, 84

[dpdk-dev] [PATCH 3/3] app/pdump: fix string overflow

2016-06-21 Thread Ferruh Yigit
On 6/21/2016 4:18 PM, Reshma Pattan wrote: > using source length in strncpy can cause destination > overflow if destination length is not big enough to > handle the source string. Changes are made to use destination > size instead of source length in strncpy. > > Coverity issue 127351: string

[dpdk-dev] [PATCH v4 1/4] port: kni interface support

2016-06-21 Thread Thomas Monjalon
> > From: WeiJie Zhuang > > > > add KNI port type to the packet framework > > > > Signed-off-by: WeiJie Zhuang > > Series-acked-by: Cristian Dumitrescu Applied, thanks

[dpdk-dev] [PATCH v4 00/17] prepare for rte_device / rte_driver

2016-06-21 Thread Shreyansh jain
Self NACK. Rebase over master before posting series broke compilation. Apologies. On Tuesday 21 June 2016 05:32 PM, Shreyansh Jain wrote: > * Original patch series is from David Marchand [1], [2]. > * Cover letter text has been modified to make it author agnostic > > David created the original

[dpdk-dev] [PATCH] kni : fix build errors for gcc --version >= 6.1

2016-06-21 Thread Thomas Monjalon
2016-06-21 13:27, Ferruh Yigit: > On 6/21/2016 12:43 PM, Anupam Kapoor wrote: > > This commit fixes build errors triggered due misleading indentation. > > > > Fixes: 38db3f7f50bde (e1000: update base driver) > Fixes: b9ee370557f1 ("kni: update kernel driver ethtool baseline") > > > Fixes:

[dpdk-dev] [PATCH v2] examples/ip_pipeline: fix build error for gcc 4.8

2016-06-21 Thread Dumitrescu, Cristian
> -Original Message- > From: Mrzyglod, DanielX T > Sent: Tuesday, June 21, 2016 10:36 AM > To: Singh, Jasvinder ; Dumitrescu, Cristian > > Cc: dev at dpdk.org; Mrzyglod, DanielX T > Subject: [PATCH v2] examples/ip_pipeline: fix build error for gcc 4.8 > > This patch fixes a

[dpdk-dev] [PATCH v3 00/25] Refactor mlx5 to improve performance

2016-06-21 Thread Ferruh Yigit
On 6/21/2016 8:23 AM, Nelio Laranjeiro wrote: > Enhance mlx5 with a data path that bypasses Verbs. > > The first half of this patchset removes support for functionality completely > rewritten in the second half (scatter/gather, inline send), while the data > path is refactored without Verbs. > >

[dpdk-dev] [PATCH v4 17/17] ethdev: get rid of device type

2016-06-21 Thread Shreyansh Jain
Now that hotplug has been moved to eal, there is no reason to keep the device type in this layer. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- app/test/virtual_pmd.c| 2 +- drivers/net/af_packet/rte_eth_af_packet.c | 2 +-

[dpdk-dev] [PATCH v4 16/17] ethdev: convert to eal hotplug

2016-06-21 Thread Shreyansh Jain
Remove bus logic from ethdev hotplug by using eal for this. Current api is preserved: - the last port that has been created is tracked to return it to the application when attaching, - the internal device name is reused when detaching. We can not get rid of ethdev hotplug yet since we still

[dpdk-dev] [PATCH v4 15/17] eal: add hotplug operations for pci and vdev

2016-06-21 Thread Shreyansh Jain
hotplug which deals with resources should come from the layer that already handles them, i.e. eal. For both attach and detach operations, 'name' is used to select the bus that will handle the request. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain ---

[dpdk-dev] [PATCH v4 14/17] ethdev: do not scan all pci devices on attach

2016-06-21 Thread Shreyansh Jain
No need to scan all devices, we only need to update the device being attached. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_pci.c | 11 --- lib/librte_ether/rte_ethdev.c | 3 --- 2 files changed, 8 insertions(+), 6

[dpdk-dev] [PATCH v4 13/17] pci: add a helper to update a device

2016-06-21 Thread Shreyansh Jain
This helper updates a pci device object with latest information it can find. It will be used mainly for hotplug code. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/eal_pci.c | 49 +

[dpdk-dev] [PATCH v4 12/17] pci: add a helper for device name

2016-06-21 Thread Shreyansh Jain
eal is a better place than crypto / ethdev for naming resources. Add a helper in eal and make use of it in crypto / ethdev. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c| 27 ---

[dpdk-dev] [PATCH v4 11/17] eal/linux: move back interrupt thread init before setting affinity

2016-06-21 Thread Shreyansh Jain
Now that virtio pci driver is initialized in a constructor, iopl() stuff happens early enough so that interrupt thread can be created right after plugin loading. This way, chelsio driver should be happy again [1]. [1] http://dpdk.org/ml/archives/dev/2015-November/028289.html Signed-off-by: David

[dpdk-dev] [PATCH v4 10/17] ethdev: get rid of eth driver register callback

2016-06-21 Thread Shreyansh Jain
Now that all pdev are pci drivers, we don't need to register ethdev drivers through a dedicated channel. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_ether/rte_ethdev.c | 22 -- lib/librte_ether/rte_ethdev.h | 12

[dpdk-dev] [PATCH v4 09/17] crypto: get rid of crypto driver register callback

2016-06-21 Thread Shreyansh Jain
Now that all pdev are pci drivers, we don't need to register crypto drivers through a dedicated channel. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 22 --- lib/librte_cryptodev/rte_cryptodev_pmd.h | 30

[dpdk-dev] [PATCH v4 08/17] drivers: convert all pdev drivers as pci drivers

2016-06-21 Thread Shreyansh Jain
Simplify crypto and ethdev pci drivers init by using newly introduced init macros and helpers. Those drivers then don't need to register as "rte_driver"s anymore. virtio and mlx* drivers use the general purpose RTE_INIT macro, as they both need some special stuff to be done before registering a

[dpdk-dev] [PATCH v4 07/17] ethdev: export init/uninit common wrappers for pci drivers

2016-06-21 Thread Shreyansh Jain
Preparing for getting rid of eth_drv, here are two wrappers that can be used by pci drivers that assume a 1 to 1 association between pci resource and upper interface. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_ether/rte_ethdev.c | 14 +++---

[dpdk-dev] [PATCH v4 06/17] crypto: export init/uninit common wrappers for pci drivers

2016-06-21 Thread Shreyansh Jain
Preparing for getting rid of rte_cryptodev_driver, here are two wrappers that can be used by pci drivers that assume a 1 to 1 association between pci resource and upper interface. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c |

[dpdk-dev] [PATCH v4 05/17] eal: introduce init macros

2016-06-21 Thread Shreyansh Jain
Introduce a RTE_INIT macro used to mark an init function as a constructor. Current eal macros have been converted to use this (no functional impact). RTE_EAL_PCI_REGISTER is added as a helper for pci drivers. RTE_EAL_PCI_REGISTER assumes that object expanded contains a pci_drv member.

[dpdk-dev] [PATCH v4 04/17] eal: remove duplicate function declaration

2016-06-21 Thread Shreyansh Jain
rte_eal_dev_init is declared in both eal_private.h and rte_dev.h since its introduction. This function has been exported in ABI, so remove it from eal_private.h Fixes: e57f20e05177 ("eal: make vdev init path generic for both virtual and pci devices") Signed-off-by: David Marchand Signed-off-by:

[dpdk-dev] [PATCH v4 03/17] drivers: align pci driver definitions

2016-06-21 Thread Shreyansh Jain
Pure coding style, but it might make it easier later if we want to move fields in rte_cryptodev_driver and eth_driver structures. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- drivers/crypto/qat/rte_qat_cryptodev.c | 2 +- drivers/net/ena/ena_ethdev.c | 2 +-

[dpdk-dev] [PATCH v4 02/17] crypto: no need for a crypto pmd type

2016-06-21 Thread Shreyansh Jain
This information is not used and just adds noise. Signed-off-by: David Marchand Signed-off-by: Shreyansh Jain --- lib/librte_cryptodev/rte_cryptodev.c | 8 +++- lib/librte_cryptodev/rte_cryptodev.h | 2 -- lib/librte_cryptodev/rte_cryptodev_pmd.h | 3 +-- 3 files changed, 4

[dpdk-dev] [PATCH v4 01/17] pci: no need for dynamic tailq init

2016-06-21 Thread Shreyansh Jain
These lists can be initialized once and for all at build time. With this, those lists are only manipulated in a common place (and we could even make them private). A nice side effect is that pci drivers can now register in constructors. Signed-off-by: David Marchand Reviewed-by: Jan Viktorin

[dpdk-dev] [PATCH v4 00/17] prepare for rte_device / rte_driver

2016-06-21 Thread Shreyansh Jain
* Original patch series is from David Marchand [1], [2]. * Cover letter text has been modified to make it author agnostic David created the original patchset based on the discussions on list [3]. Being a large piece of work, this patchset introduces first level of changes for generalizing the

[dpdk-dev] Assembly code

2016-06-21 Thread Mahdi Moradmand Badie
Dear All, I used the default format of Makefile (as follow) which is available in the examples, I was wondering how I could generate the assembly (main.s) related to my main.c, via Makefile. PS. using -S doesn't work :( ifeq ($(RTE_SDK),) $(error "Please define RTE_SDK environment variable")

[dpdk-dev] [PATCH v3 15/30] ixgbe/base: refactor NW management interface ops

2016-06-21 Thread Bruce Richardson
On Wed, Jun 15, 2016 at 03:53:25PM +0800, Beilei Xing wrote: > This patch adds ixgbe_read_mng_if_sel_x550em to read NW_MNG_IF_SEL > register and save fields such as PHY MDIO_ADD. > > Signed-off-by: Beilei Xing NW == "network" or something else? Please expand the acronym. Also, this commit

[dpdk-dev] weak functions in some drivers

2016-06-21 Thread Ferruh Yigit
Hi Damjan, On 6/21/2016 4:01 PM, Damjan Marion (damarion) wrote: > > Hello, > > We just spent few hours troubleshooting why vPMD is not working > in i40e driver. Conclusion was that problem is caused by linker > linking the wrong instance of the i40e_rx_vec_dev_conf_condition_check(...). > >

[dpdk-dev] [PATCH] bnxt: Add Cumulus+ PCI ID

2016-06-21 Thread Ajit Khaparde
This patch adds support for Cumulus+ Ethernet adapters. These Cumulus+ Ethernet adapters support 10Gb/25Gb/40Gb/50Gb speeds. Signed-off-by: Ajit Khaparde --- lib/librte_eal/common/include/rte_pci_dev_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git

[dpdk-dev] [PATCH] mbuf: extend rte_mbuf_prefetch_part* to support more prefetching methods

2016-06-21 Thread Olivier Matz
Hi, On 06/02/2016 11:30 AM, Jerin Jacob wrote: > On Thu, Jun 02, 2016 at 05:04:13PM +0800, Jianbo Liu wrote: >> On 1 June 2016 at 14:00, Jerin Jacob >> wrote: >>> On Wed, Jun 01, 2016 at 11:29:47AM +0800, Jianbo Liu wrote: On 1 June 2016 at 03:28, Olivier MATZ wrote: > Hi Jianbo,

[dpdk-dev] [PATCH] kni : fix build errors for gcc --version >= 6.1

2016-06-21 Thread Anupam Kapoor
On Tue, Jun 21, 2016 at 3:40 PM, Ferruh Yigit wrote: > Hi Anupam, > > Thank you for the patch. > > > On 6/21/2016 9:37 AM, Anupam Kapoor wrote: > > This commit fixes build errors triggered due misleading indentation. > > > > Fixes: 366113dbfb696 (e1000: suppress misleading indentation warning) >

[dpdk-dev] [PATCH 3/3] app/pdump: fix string overflow

2016-06-21 Thread Reshma Pattan
using source length in strncpy can cause destination overflow if destination length is not big enough to handle the source string. Changes are made to use destination size instead of source length in strncpy. Coverity issue 127351: string overflow Fixes: caa7028276b8 ("app/pdump: add tool for

[dpdk-dev] [PATCH 2/3] pdump: fix string overflow

2016-06-21 Thread Reshma Pattan
using source length in strncpy can cause destination overflow if destination length is not big enough to handle the source string. Changes are made to use destination size instead of source length in strncpy. Cverity issue 127350: string overflow Fixes: 278f945402c5 ("pdump: add new library for

[dpdk-dev] [PATCH 1/3] pdump: check getenv return value

2016-06-21 Thread Reshma Pattan
getenv can return a NULL pointer if the match for SOCKET_PATH_HOME is not found in the environment. NULL check is added to return immediately without calling mkdir. Coverity issue 127344: return value check Coverity issue 127347: null pointer dereference Fixes: 278f945402c5 ("pdump: add new

[dpdk-dev] [PATCH 0/3] fix coverity issues in packet capture framework

2016-06-21 Thread Reshma Pattan
This patchset fixes coverity issues in pdump library and pdump tool. Reshma Pattan (3): pdump: check getenv return value pdump: fix string overflow app/pdump: fix string overflow app/pdump/main.c | 4 ++-- lib/librte_pdump/rte_pdump.c | 53

[dpdk-dev] [PATCH] igb_uio: fix build with backported kernel

2016-06-21 Thread Thomas Monjalon
2016-06-15 16:57, Ferruh Yigit: > Following compile error observed with CentOS 6.8, which uses kernel > kernel-devel-2.6.32-642.el6.x86_64: > > CC eal_thread.o > .../build/lib/librte_eal/linuxapp/igb_uio/igb_uio.c: > In function 'igbuio_msix_mask_irq': >

[dpdk-dev] weak functions in some drivers

2016-06-21 Thread Damjan Marion (damarion)
> On 21 Jun 2016, at 09:01, Ferruh Yigit wrote: > > Hi Damjan, > > On 6/21/2016 4:01 PM, Damjan Marion (damarion) wrote: >> >> Hello, >> >> We just spent few hours troubleshooting why vPMD is not working >> in i40e driver. Conclusion was that problem is caused by linker >> linking the

[dpdk-dev] [PATCH v2 0/2] fix Coverity issues

2016-06-21 Thread Thomas Monjalon
> Remy Horton (2): > app/test-pmd: fix Coverity issues > examples/l2fwd-keepalive: fix Coverity issues Applied with titles reworded as suggested by Pablo, thanks

[dpdk-dev] [PATCH v3 08/30] ixgbe/base: add KR support for X550em_a devices

2016-06-21 Thread Bruce Richardson
On Wed, Jun 15, 2016 at 03:53:18PM +0800, Beilei Xing wrote: > Implement KR support for X550em_a devices. > > Signed-off-by: Beilei Xing Ideally, this patch should be right after patch 6 - "refactor eee setup for X550" since that patch does the setup for this one, and refers to it. /Bruce

[dpdk-dev] [PATCH v6 00/38] new bnxt poll mode driver library

2016-06-21 Thread Bruce Richardson
On Tue, Jun 21, 2016 at 09:25:18AM -0500, Ajit Khaparde wrote: > Bruce, > We have a set of patches which add support to a couple of new Broadcom PCI > devices. > Should I use the dpdk-next-net/rel_16_07 to push them out? > Let me know if there is any other way to do this. > > Thanks > They

[dpdk-dev] [PATCH v3 00/25] Refactor mlx5 to improve performance

2016-06-21 Thread Yuanhan Liu
Hi, Here is an off-topic comment: would you please add following line to the sendemail section of your git config file? chainreplyto = false That would let me to break the long threads in my client much easier. Otherwise, it's hard for me to do it, leading that your thread occupies several

[dpdk-dev] [PATCH v3 02/30] ixgbe/base: add sgmii link for X550

2016-06-21 Thread Bruce Richardson
On Wed, Jun 15, 2016 at 03:53:12PM +0800, Beilei Xing wrote: > It adds sgmii link for X550. > A commit message like this which just restates the commit title can just be omitted. However, it would be nice to have a little more detail about the patch in the commit message. Regards, /Bruce

[dpdk-dev] [PATCH v3 01/30] ixgbe/base: add new VF requests for mailbox API

2016-06-21 Thread Bruce Richardson
On Wed, Jun 15, 2016 at 03:53:11PM +0800, Beilei Xing wrote: > It adds two new VF requests of IXGBE_VF_GET_RETA and > IXGBE_VF_GET_RSS_KEY for mailbox API. > General comment - please don't start commit messages with "It". There is no previous noun in the text for the "it" to refer to. Thanks,

[dpdk-dev] [PATCH v3] qat: fix for VFs not getting recognized

2016-06-21 Thread Thomas Monjalon
2016-06-21 10:03, Deepak Kumar Jain: > From: "Jain, Deepak K" > > Updated the code to use RTE_PCI_DEVICE. > > Fixes: 701c8d80c820 ("pci: support class id probing") > > Signed-off-by: Jain, Deepak K Applied, thanks

[dpdk-dev] [PATCH v3 05/30] ixgbe/base: fix checksum error of checking PHY token

2016-06-21 Thread Bruce Richardson
On Wed, Jun 15, 2016 at 03:53:15PM +0800, Beilei Xing wrote: > This patch sets the Host Interface PHY token command > checksum to the checksum default of 0xFF, therefore > the checksum is not checked by the firmware. Otherwise > the command fails with a checksum failed error. > I think this

[dpdk-dev] [RFC] librte_vhost: Add unix domain socket fd registration

2016-06-21 Thread Yuanhan Liu
On Fri, Jun 17, 2016 at 11:32:36AM -0400, Aaron Conole wrote: > Prior to this commit, the only way to add a vhost-user socket to the > system is by relying on librte_vhost to open the unix domain socket and > add it to the unix socket list. This is problematic for applications > which would like

[dpdk-dev] [PATCH v3] lib/table: fix wrong type of nht field

2016-06-21 Thread Michal Kobylinski
Change type of nht field from uint32_t to uint8_t and increase max of next hops. nht_entry and nht should be declared as uint8_t because entry_size is in bytes and is given as a parameter to compute the position in nht array. Fixes: dc81ebbacaeb ("lpm: extend IPv4 next hop field")

[dpdk-dev] [PATCH v2] lib/table: fix wrong type of nht field

2016-06-21 Thread Thomas Monjalon
> > Change type of nht field from uint32_t to uint8_t and increase max of > > next hops. > > > > Fixes: dc81ebbacaeb ("lpm: extend IPv4 next hop field") > > Signed-off-by: Michal Kobylinski > > --- > > v2: > > - removed changing from file: pipeline_routing_be.h > > - changed macro:

[dpdk-dev] weak functions in some drivers

2016-06-21 Thread Damjan Marion (damarion)
Hello, We just spent few hours troubleshooting why vPMD is not working in i40e driver. Conclusion was that problem is caused by linker linking the wrong instance of the i40e_rx_vec_dev_conf_condition_check(...). That function is defined 2 times, once in i40e_rxtx.c and once in

[dpdk-dev] [PATCH] mem: skip memory locking on failure

2016-06-21 Thread Panu Matilainen
On 06/14/2016 05:12 PM, Olivier MATZ wrote: > Hi Panu, > > On 06/14/2016 03:21 PM, Panu Matilainen wrote: >> On 06/13/2016 01:26 PM, Olivier Matz wrote: >>> Since recently [1], it is not possible to run the dpdk with user >>> (non-root) privileges and the --no-huge option. This is because the eal

[dpdk-dev] [PATCH 1/3] mk: fix librte_pipeline dependency list truncation

2016-06-21 Thread Panu Matilainen
On 06/21/2016 01:58 PM, Dumitrescu, Cristian wrote: > > >> -Original Message- >> From: Panu Matilainen [mailto:pmatilai at redhat.com] >> Sent: Tuesday, June 21, 2016 11:45 AM >> To: Richardson, Bruce >> Cc: Dumitrescu, Cristian ; dev at dpdk.org; >> christian.ehrhardt at canonical.com;

[dpdk-dev] random pkt generator PMD

2016-06-21 Thread Yerden Zhumabekov
I've developed some preliminary version of the driver. The code is derived from Null PMD, but required a lot of rework. It uses following devargs to generate packets: 1) edit=offset:size:[rnd|value] Edit a field within an mbuf packet data with given offset and size. Mark it as 'rnd' or

[dpdk-dev] queue to VF assigment in SR-IOV

2016-06-21 Thread Mauricio Vásquez
Hello Alexander, On Mon, Jun 13, 2016 at 6:02 PM, Alexander Duyck wrote: > On Mon, Jun 13, 2016 at 4:56 AM, Mauricio V?squez > wrote: > > Hello Alexander, > > > > On Tue, Jun 7, 2016 at 11:31 PM, Alexander Duyck < > alexander.duyck at gmail.com> > > wrote: > >> > >> On Tue, Jun 7, 2016 at

[dpdk-dev] [PATCH v6 04/27] net/thunderx/base: add mbox APIs for PF/VF communication

2016-06-21 Thread Ferruh Yigit
On 6/17/2016 2:29 PM, Jerin Jacob wrote: > DPDK nicvf driver doesn't have access to NIC's PF address space. > Introduce a mailbox mechanism to communicate with PF driver through > shared 128bit register interface. > > Signed-off-by: Jerin Jacob > Signed-off-by: Maciej Czekaj > Signed-off-by:

[dpdk-dev] [PATCH v6 19/27] net/thunderx: add single and multi segment Tx functions

2016-06-21 Thread Ferruh Yigit
Hi Jerin, On 6/17/2016 2:29 PM, Jerin Jacob wrote: > Signed-off-by: Jerin Jacob > Signed-off-by: Maciej Czekaj > Signed-off-by: Kamil Rytarowski > Signed-off-by: Zyta Szpak > Signed-off-by: Slawomir Rosek > Signed-off-by: Radoslaw Biernacki > --- ... > diff --git

[dpdk-dev] [PATCH v3 00/25] Refactor mlx5 to improve performance

2016-06-21 Thread Thomas Monjalon
2016-06-21 11:44, Ferruh Yigit: > Although this is really detail, for multi version patchsets, if there is > a preferred way between (A) or (B) I would like to learn too? In my opinion, A and B are fine. And I prefer B. > A) > > - [0/N] > - - [1/N] > - - [2/N] > - - [v2 0/N] > - - - [v2 1/N] >

[dpdk-dev] [PATCH v6 1/4] lib/librte_ether: support device reset

2016-06-21 Thread Jerin Jacob
On Tue, Jun 21, 2016 at 08:24:36AM +, Lu, Wenzhuo wrote: > Hi Jerin, Hi Wenzhuo, > > > > > > On Mon, Jun 20, 2016 at 02:24:27PM +0800, Wenzhuo Lu wrote: > > > > > > > Add an API to reset the device. > > > > > > > It's for VF device in this scenario, kernel PF + DPDK VF. > > > > > > > When

[dpdk-dev] [PATCH] kni : fix build errors for gcc --version >= 6.1

2016-06-21 Thread Anupam Kapoor
This commit fixes build errors triggered due misleading indentation. Fixes: 366113dbfb696 (e1000: suppress misleading indentation warning) Signed-off-by: Anupam Kapoor --- lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_phy.c | 12

[dpdk-dev] [PATCH v2] i40e: modify the meaning of single VLAN type

2016-06-21 Thread Panu Matilainen
On 06/21/2016 01:29 PM, Bruce Richardson wrote: > On Mon, Jun 13, 2016 at 04:03:32PM +0800, Beilei Xing wrote: >> In current i40e codebase, if single VLAN header is added in a packet, >> it's treated as inner VLAN. Generally, a single VLAN header is >> treated as the outer VLAN header. So change

[dpdk-dev] [PATCH v2 6/6] ena: fix for icc compiler

2016-06-21 Thread Jan Medala
Signed-off-by: Alexander Matushevsky Signed-off-by: Jakub Palider Signed-off-by: Jan Medala --- drivers/net/ena/ena_ethdev.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index d0927f7..928b37f 100644

[dpdk-dev] [PATCH v2 5/6] ena: fix memory management issue

2016-06-21 Thread Jan Medala
After allocating memzone it's required to zeroize memory in it. Freeing memzone with function dedicated for memoryzones. Signed-off-by: Alexander Matushevsky Signed-off-by: Jakub Palider Signed-off-by: Jan Medala --- drivers/net/ena/base/ena_plat_dpdk.h | 6 -- 1 file changed, 4

[dpdk-dev] [PATCH v2 4/6] ena: allocate coherent memory in node-aware way

2016-06-21 Thread Jan Medala
Signed-off-by: Alexander Matushevsky Signed-off-by: Jakub Palider Signed-off-by: Jan Medala --- drivers/net/ena/base/ena_com.c | 51 ++-- drivers/net/ena/base/ena_plat_dpdk.h | 23 drivers/net/ena/ena_ethdev.c | 15 +++ 3

[dpdk-dev] [PATCH v2 3/6] ena: disable readless communication regarding to HW revision

2016-06-21 Thread Jan Medala
Signed-off-by: Alexander Matushevsky Signed-off-by: Jakub Palider Signed-off-by: Jan Medala --- drivers/net/ena/ena_ethdev.c | 12 +++- drivers/net/ena/ena_ethdev.h | 2 ++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c

[dpdk-dev] [PATCH v2 2/6] ena: add debug area and host information

2016-06-21 Thread Jan Medala
Signed-off-by: Alexander Matushevsky Signed-off-by: Jakub Palider Signed-off-by: Jan Medala --- drivers/net/ena/ena_ethdev.c | 193 ++- drivers/net/ena/ena_ethdev.h | 38 + 2 files changed, 230 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v2 1/6] ena: update of ENA communication layer

2016-06-21 Thread Jan Medala
Signed-off-by: Alexander Matushevsky Signed-off-by: Jakub Palider Signed-off-by: Jan Medala --- drivers/net/ena/base/ena_com.c | 203 ++- drivers/net/ena/base/ena_com.h | 82 +++-- drivers/net/ena/base/ena_defs/ena_admin_defs.h | 107 +-

[dpdk-dev] [PATCH v2 0/6] ena: update PMD to cooperate with latest ENA firmware

2016-06-21 Thread Jan Medala
As requested, big patch splitted into logical pieces for easier review. Improved style and fixed icc compiler issues. Jan Medala (6): ena: update of ENA communication layer ena: add debug area and host information ena: disable readless communication regarding to HW revision ena: allocate

[dpdk-dev] [PATCH] qat: addition of optimized content descriptor for AES128-SHA1-HMAC

2016-06-21 Thread Griffin, John
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, June 21, 2016 2:50 PM > To: Griffin, John > Cc: dev at dpdk.org; Jain, Deepak K ; De Lara > Guarch, Pablo > Subject: Re: [dpdk-dev] [PATCH] qat: addition of optimized content >

[dpdk-dev] [PATCH] qat: addition of optimized content descriptor for AES128-SHA1-HMAC

2016-06-21 Thread John Griffin
Adding an optimized content descriptor for AES128-SHA1-HMAC to improve thoughput performance. Signed-off-by: John Griffin --- drivers/crypto/qat/qat_adf/qat_algs.h| 7 ++ drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 91 drivers/crypto/qat/qat_crypto.c

[dpdk-dev] [PATCH] kni : fix build errors for gcc --version >= 6.1

2016-06-21 Thread Ferruh Yigit
On 6/21/2016 12:43 PM, Anupam Kapoor wrote: > This commit fixes build errors triggered due misleading indentation. > > Fixes: 38db3f7f50bde (e1000: update base driver) Fixes: b9ee370557f1 ("kni: update kernel driver ethtool baseline") > Fixes: 3fc5ca2f63529 (kni: initial import) > > >

[dpdk-dev] [PATCH v2] lib/table: fix wrong type of nht field

2016-06-21 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, June 21, 2016 2:16 PM > To: Dumitrescu, Cristian ; Kobylinski, > MichalX > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] lib/table: fix wrong type of nht field > > > > Change

[dpdk-dev] [PATCH v6 1/4] lib/librte_ether: support device reset

2016-06-21 Thread Ananyev, Konstantin
> > Hi Konstantin, > > > Hi Jerin, > > > > > -Original Message- > > > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > > > Sent: Tuesday, June 21, 2016 9:56 AM > > > To: Lu, Wenzhuo > > > Cc: Stephen Hemminger; dev at dpdk.org; Ananyev, Konstantin; Richardson, > > >

[dpdk-dev] [PATCH v6 1/4] lib/librte_ether: support device reset

2016-06-21 Thread Jerin Jacob
On Tue, Jun 21, 2016 at 06:14:29AM +, Lu, Wenzhuo wrote: > Hi Jerin, Stephen, > > > > -Original Message- > > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > > Sent: Tuesday, June 21, 2016 11:51 AM > > To: Stephen Hemminger > > Cc: Lu, Wenzhuo; dev at dpdk.org; Ananyev,

[dpdk-dev] [PATCH v2] i40e: modify the meaning of single VLAN type

2016-06-21 Thread Bruce Richardson
On Mon, Jun 13, 2016 at 04:03:32PM +0800, Beilei Xing wrote: > In current i40e codebase, if single VLAN header is added in a packet, > it's treated as inner VLAN. Generally, a single VLAN header is > treated as the outer VLAN header. So change corresponding register > for single VLAN. > At the

[dpdk-dev] [PATCH v2] i40e: modify the meaning of single VLAN type

2016-06-21 Thread Bruce Richardson
On Tue, Jun 21, 2016 at 02:06:38PM +0300, Panu Matilainen wrote: > On 06/21/2016 01:29 PM, Bruce Richardson wrote: > >On Mon, Jun 13, 2016 at 04:03:32PM +0800, Beilei Xing wrote: > >>In current i40e codebase, if single VLAN header is added in a packet, > >>it's treated as inner VLAN. Generally, a

[dpdk-dev] [PATCH v3 0/9] IPSec Enhancements

2016-06-21 Thread Thomas Monjalon
> > Sergio Gonzalez Monroy (9): > > examples/ipsec-secgw: fix esp padding check > > examples/ipsec-secgw: fix stack smashing error > > examples/ipsec-secgw: add build option and cleanup > > examples/ipsec-secgw: rework ipsec execution loop > > examples/ipsec-secgw: fix no sa found case >

[dpdk-dev] [PATCH v4 1/4] port: kni interface support

2016-06-21 Thread Dumitrescu, Cristian
> -Original Message- > From: Ethan Zhuang [mailto:zhuangwj at gmail.com] > Sent: Tuesday, June 21, 2016 11:56 AM > To: Dumitrescu, Cristian > Cc: dev at dpdk.org; Singh, Jasvinder ; Yigit, > Ferruh ; WeiJie Zhuang > Subject: [PATCH v4 1/4] port: kni interface support > > From: WeiJie

[dpdk-dev] [PATCH v3 1/2] ethdev: add callback to get register size in bytes

2016-06-21 Thread Zyta Szpak
OK, I will do the v4. On 17.06.2016 12:20, Thomas Monjalon wrote: > 2016-06-13 16:51, Remy Horton: >> On 12/06/2016 15:51, Zyta Szpak wrote: >>> I would prefer having only one function rte_eth_dev_get_regs() >>> which returns length and width if data is NULL. >>> The first call is

[dpdk-dev] [PATCH v3 1/2] mempool: add stack (lifo) mempool handler

2016-06-21 Thread Olivier Matz
Hi, On 06/21/2016 11:28 AM, Ananyev, Konstantin wrote: I was proposing only to move only the new handler(lib/librte_mempool/rte_mempool_stack.c). Not any library or any other common code. Just like DPDK crypto device, Even if it is software implementation its better

[dpdk-dev] [PATCH v2] examples/ip_pipeline: fix build error for gcc 4.8

2016-06-21 Thread Daniel Mrzyglod
This patch fixes a maybe-uninitialized warning when compiling DPDK with GCC 4.8 examples/ip_pipeline/pipeline/pipeline_common_fe.c: In function 'app_pipeline_track_pktq_out_to_link': examples/ip_pipeline/pipeline/pipeline_common_fe.c:66:31: error: 'reader' may be used uninitialized in this

[dpdk-dev] [PATCH v3 1/3] port: add kni interface support

2016-06-21 Thread Dumitrescu, Cristian
Hi Ethan, Thanks very much for sending the new version. You are absolutely right about the param->parsed issue, sorry, my fault. I think you need to use the --cover-letter flag for git format-patch command. You can practice by sending the patch set to your email address first before you send

[dpdk-dev] [PATCH] lib/table: fix wrong type of nht field

2016-06-21 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michal Jastrzebski > Sent: Monday, June 20, 2016 11:10 AM > To: dev at dpdk.org > Cc: Kobylinski, MichalX > Subject: [dpdk-dev] [PATCH] lib/table: fix wrong type of nht field > > From: Michal Kobylinski >

[dpdk-dev] [PATCH] lib/table: fix wrong type of nht field

2016-06-21 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Monday, June 20, 2016 11:14 AM > To: Jastrzebski, MichalX K ; Kobylinski, > MichalX > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] lib/table: fix wrong type of nht field > >

[dpdk-dev] [PATCH] bnx2x: Correctly determine MSIX vector count

2016-06-21 Thread Bruce Richardson
On Tue, Jun 21, 2016 at 05:55:19AM +, Harish Patil wrote: > > > >From: "Charles (Chas) Williams" > > > >If MSIX is available, the vector count given by the table size is one > >less than the actual count. This count also limits the receive and > >transmit queue resources the VF can support.

[dpdk-dev] [PATCH 2/3] pdump: fix missing dependency on libpthread

2016-06-21 Thread Panu Matilainen
Fixes: 278f945402c5 ("pdump: add new library for packet capture") Signed-off-by: Panu Matilainen --- lib/librte_pdump/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_pdump/Makefile b/lib/librte_pdump/Makefile index af81a28..a506c4d 100644 --- a/lib/librte_pdump/Makefile

[dpdk-dev] [PATCH 1/3] mk: fix librte_pipeline dependency list truncation

2016-06-21 Thread Dumitrescu, Cristian
> -Original Message- > From: Panu Matilainen [mailto:pmatilai at redhat.com] > Sent: Tuesday, June 21, 2016 11:45 AM > To: Richardson, Bruce > Cc: Dumitrescu, Cristian ; dev at dpdk.org; > christian.ehrhardt at canonical.com; thomas.monjalon at 6wind.com > Subject: Re: [dpdk-dev] [PATCH

[dpdk-dev] [PATCH v3 00/25] Refactor mlx5 to improve performance

2016-06-21 Thread Nélio Laranjeiro
On Tue, Jun 21, 2016 at 04:05:44PM +0800, Yuanhan Liu wrote: > On Tue, Jun 21, 2016 at 10:00:34AM +0200, N?lio Laranjeiro wrote: > > On Tue, Jun 21, 2016 at 03:43:08PM +0800, Yuanhan Liu wrote: > > > Hi, > > > > > > Here is an off-topic comment: would you please add following line to > > > the

[dpdk-dev] [PATCH v3] qat: fix for VFs not getting recognized

2016-06-21 Thread Deepak Kumar Jain
From: "Jain, Deepak K" Updated the code to use RTE_PCI_DEVICE. Fixes: 701c8d80c820 ("pci: support class id probing") Signed-off-by: Jain, Deepak K --- v3: kept PCI id in the driver file v2: updated code to use RTE_PCI_DEVICE drivers/crypto/qat/rte_qat_cryptodev.c |

[dpdk-dev] [PATCH 1/3] mk: fix librte_pipeline dependency list truncation

2016-06-21 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen > Sent: Tuesday, June 21, 2016 9:12 AM > To: dev at dpdk.org > Cc: christian.ehrhardt at canonical.com; thomas.monjalon at 6wind.com > Subject: [dpdk-dev] [PATCH 1/3] mk: fix librte_pipeline

[dpdk-dev] [PATCH v3 00/25] Refactor mlx5 to improve performance

2016-06-21 Thread Nélio Laranjeiro
On Tue, Jun 21, 2016 at 03:43:08PM +0800, Yuanhan Liu wrote: > Hi, > > Here is an off-topic comment: would you please add following line to > the sendemail section of your git config file? > > chainreplyto = false > > That would let me to break the long threads in my client much easier. >

[dpdk-dev] [PATCH v4 2/3] bnx2x: enhance stats get

2016-06-21 Thread Remy Horton
Morning, On 11/05/2016 01:58, Rasesh Mody wrote: [..] >>> We shall split this patch into an enhancement and a bug fix. >> >> Keep in mind that the xstats API is changing so that stats_get() no >> longer includes strings: >> >> http://thread.gmane.org/gmane.comp.networking.dpdk.devel/37079 >>

[dpdk-dev] [PATCH] dropping librte_ivshmem - was log: deprecate history dump

2016-06-21 Thread Panu Matilainen
On 06/10/2016 12:26 AM, Thomas Monjalon wrote: > Looking a bit more into librte_ivshmem, the documentation says we need > a Qemu patch but the URL doesn't exist anymore: > https://01.org/packet-processing/intel%C2%AE-ovdk > -> 404 Oops, we couldn't find that page > > I've never

[dpdk-dev] [DPDK16.04: Error While compiling]

2016-06-21 Thread amartya....@wipro.com
Hi, Its VM fedora21, gcc 4.9. Thanks, Amartya -Original Message- From: Anupam Kapoor [mailto:akap...@parallelwireless.com] Sent: Tuesday, June 21, 2016 2:54 PM To: Amartya Kumar Das (MFG & Tech) Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [DPDK16.04: Error While compiling] ** This

[dpdk-dev] [PATCH v3 1/2] mempool: add stack (lifo) mempool handler

2016-06-21 Thread Ananyev, Konstantin
> -Original Message- > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > Sent: Tuesday, June 21, 2016 4:35 AM > To: Ananyev, Konstantin > Cc: Thomas Monjalon; dev at dpdk.org; Hunt, David; olivier.matz at 6wind.com; > viktorin at rehivetech.com; shreyansh.jain at nxp.com >

[dpdk-dev] [PATCH v6 1/4] lib/librte_ether: support device reset

2016-06-21 Thread Ananyev, Konstantin
Hi Jerin, > -Original Message- > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > Sent: Tuesday, June 21, 2016 9:56 AM > To: Lu, Wenzhuo > Cc: Stephen Hemminger; dev at dpdk.org; Ananyev, Konstantin; Richardson, > Bruce; Chen, Jing D; Liang, Cunming; Wu, Jingjing; Zhang, >

[dpdk-dev] [PATCH v6 00/38] new bnxt poll mode driver library

2016-06-21 Thread Ajit Khaparde
Bruce, We have a set of patches which add support to a couple of new Broadcom PCI devices. Should I use the dpdk-next-net/rel_16_07 to push them out? Let me know if there is any other way to do this. Thanks On Thu, Jun 16, 2016 at 1:51 PM, Ajit Khaparde wrote: > > On Thu, Jun 16, 2016 at 9:24

  1   2   >