Re: [dpdk-dev] dev Digest, Vol 128, Issue 78

2017-02-07 Thread Devanath S
Hi *, We are trying to use dpdk in our security product. But the packet flow in it requires synchronous encryption and decryption. Is this possible with DPDK and its software crypto library? Regards, Dev

Re: [dpdk-dev] [PATCH] i40e: fix oversize packet counter not incrementing for large packets

2017-02-07 Thread Wu, Jingjing
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wu, Jingjing > Sent: Monday, November 28, 2016 10:20 AM > To: Michael Bieniek ; Zhang, Helin > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] i40e: fix oversize packet counter not > incrementing for large p

[dpdk-dev] [PATCH v4 4/4] mbuf: fix bitmask of Tx offload flags

2017-02-07 Thread Jingjing Wu
Add missed PKT_TX_MACSEC and PKT_TX_IEEE1588_TMST flags to bitmask of all supported packet Tx offload features flags. Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation") Signed-off-by: Jingjing Wu --- lib/librte_mbuf/rte_mbuf.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v4 3/4] net/e1000: fix bitmask of supported Tx flags

2017-02-07 Thread Jingjing Wu
Add missed PKT_TX_IEEE1588_TMST to bitmask of all supported packet Tx flags. Fixes: 2b76648872c9 ("net/e1000: add Tx preparation") Signed-off-by: Jingjing Wu --- drivers/net/e1000/igb_rxtx.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/e1000/igb_rxtx.c b

[dpdk-dev] [PATCH v4 1/4] net/i40e: fix bitmask of supported Tx flags

2017-02-07 Thread Jingjing Wu
PKT_TX_TUNNEL_MASK and PKT_TX_IEEE1588_TMST are missed in bitmask of all supported packet Tx flags by i40e. It will cause packet preparing fail when sending tunnel packets with Tx offload. This patch fixes it. Fixes: 3f33e643e5c6 ("net/i40e: add Tx preparation") Signed-off-by: Jingjing Wu --- dr

[dpdk-dev] [PATCH v4 2/4] net/ixgbe: fix bitmask of supported Tx flags

2017-02-07 Thread Jingjing Wu
Add missed PKT_TX_IEEE1588_TMST to bitmask of all supported packet Tx flags. Fixes: 7829b8d52be0 ("net/ixgbe: add Tx preparation") Signed-off-by: Jingjing Wu --- drivers/net/ixgbe/ixgbe_rxtx.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx

[dpdk-dev] [PATCH v4 0/4] fix bitmask of supported Tx flags

2017-02-07 Thread Jingjing Wu
Some Tx offload flags are missed in bitmask of all supported packet Tx flags, it will cause rte_eth_tx_prepare fails when Tx burst packets. v4 change: - add PKT_TX_IEEE1588_TMST to PKT_TX_OFFLOAD_MASK v3 changes: - add PKT_TX_MACSEC to PKT_TX_OFFLOAD_MASK - refine code of drivers' TX_OFFLOAD_M

Re: [dpdk-dev] [RFC 1/2] doc: introduction to prgdev

2017-02-07 Thread Liang, Cunming
On 1/20/2017 11:21 AM, Chen Jing D(Mark) wrote: This is the documentation to describe what prgdev is, how to use prgdev API and accomplish an image download. Signed-off-by: Chen Jing D(Mark) --- doc/guides/prog_guide/prgdev_lib.rst | 457 ++ 1 files changed

Re: [dpdk-dev] [PATCH] net/i40e: fix wrong device flag setup

2017-02-07 Thread Yuanhan Liu
On Tue, Feb 07, 2017 at 10:32:32AM +, Ferruh Yigit wrote: > On 2/7/2017 10:24 AM, Ferruh Yigit wrote: > > On 2/3/2017 11:36 PM, Qi Zhang wrote: > >> dev_flags is wrong overwritten by RTE_ETH_DEV_DETACHABLE after > >> rte_eth_copy_pci_info. > >> ... > Hi Yuanhan, > > I saw while checking for th

Re: [dpdk-dev] [PATCH] doc: update the document for virtio xstats feature

2017-02-07 Thread Yuanhan Liu
On Tue, Feb 07, 2017 at 05:40:30PM +0800, Jiayu Hu wrote: > Currently, extended statistics has been supported by virtio. But there > are no corresponding document updates. Therefore, this patch is to update > the document for virtio xstats feature. > > Signed-off-by: Jiayu Hu Acked-by: Yuanhan L

[dpdk-dev] [PATCH] net/i40e: i40e PMD check enhancement

2017-02-07 Thread Wenzhuo Lu
Change is_i40e_pmd to is_device_supported to make it more generic. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c | 42 -- 1 file changed, 20 insertions(+), 22 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_

Re: [dpdk-dev] buf->hash.rss always empty with i40e

2017-02-07 Thread Wu, Jingjing
> -Original Message- > From: tom.barbe...@ulg.ac.be [mailto:tom.barbe...@ulg.ac.be] > Sent: Monday, February 6, 2017 11:08 PM > To: Ananyev, Konstantin > Cc: Richardson, Bruce ; dev@dpdk.org; Zhang, > Helin ; Wu, Jingjing > Subject: Re: buf->hash.rss always empty with i40e > > Hi Konst

Re: [dpdk-dev] [PATCH v3] net/ixgbe: clean up rte_eth_dev_info_get

2017-02-07 Thread Lu, Wenzhuo
Hi Ferruh, Jingjing, > -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, February 7, 2017 10:10 PM > To: dev@dpdk.org; Wu, Jingjing > Cc: Lu, Wenzhuo; Iremonger, Bernard > Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe: clean up rte_eth_dev_info_get > > On 2/7/2017 2:08 PM, Ferruh Y

Re: [dpdk-dev] [PATCH v2 3/5] net/ixgbe: fix bitmask of supported Tx flags

2017-02-07 Thread Ananyev, Konstantin
> -Original Message- > From: Wu, Jingjing > Sent: Tuesday, February 7, 2017 2:30 AM > To: Ananyev, Konstantin ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2 3/5] net/ixgbe: fix bitmask of supported Tx > flags > > > > > -Original Message- > > From: Ananyev, Konstantin > > S

[dpdk-dev] [PATCH] crypto: fix incorrect key setting

2017-02-07 Thread Pablo de Lara
When ciphering and authenticating in the same operation (cipher-then-auth or auth-then-cipher), the cipher key and authentication key was set with the same key, in SNOW3G, KASUMI and ZUC PMDs. They were using the key of the first transform structure, instead of using the keys of the two different t

Re: [dpdk-dev] cryptodev - Session and queue pair relationship

2017-02-07 Thread Declan Doherty
On 06/02/17 13:35, Akhil Goyal wrote: Hi, Hey Akhil, see my thoughts inline I have some issues w.r.t the mapping sessions and queue pairs. As per my understanding: - Number of sessions may be large – they are independent of number of queue pairs Yes, cryptodev assumes no implicit connectio

Re: [dpdk-dev] [PATCH 1/2] pkg: add aarch64 support

2017-02-07 Thread Thomas Monjalon
2017-01-18 22:46, Anders Roxell: > Signed-off-by: Anders Roxell Series applied, thanks

Re: [dpdk-dev] [PATCH v1] doc: add distributor library API change notice

2017-02-07 Thread Van Haaren, Harry
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt > Sent: Monday, February 6, 2017 8:08 AM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Hunt, David > > Subject: [dpdk-dev] [PATCH v1] doc: add distributor library API change notice > > Given that the pa

Re: [dpdk-dev] [PATCH] pkg: add dkms to build kernel module

2017-02-07 Thread Thomas Monjalon
Hi, So the idea is to package DPDK kernel modules with DKMS. And if we do not want to use DKMS, we just have to remove this part? Could we better identify the DKMS part to remove? Or add a variable to switch between the 2 modes? 2017-01-18 22:45, Anders Roxell: > +MAKE="source /usr/share/dpdk/bui

Re: [dpdk-dev] vhost user MTU and promisc mode

2017-02-07 Thread Michael S. Tsirkin
On Tue, Feb 07, 2017 at 04:27:16PM +, Tan, Jianfeng wrote: > > > > -Original Message- > > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > > Sent: Monday, February 6, 2017 6:20 PM > > To: Tan, Jianfeng > > Cc: m...@redhat.com; Liu, Yuanhan; dev@dpdk.org > > Subject: Re: vho

[dpdk-dev] [PATCH] doc: add limitations section to cryptoperf guide

2017-02-07 Thread Trahe, Fiona
Add limitations to use of the dpdk-test-crypto-perf tool for hardware accelerator measurements Signed-off-by: Fiona Trahe --- doc/guides/tools/cryptoperf.rst | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/doc/guides/tools/cryptoperf.rst b/doc/guides/too

Re: [dpdk-dev] vhost user MTU and promisc mode

2017-02-07 Thread Tan, Jianfeng
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Monday, February 6, 2017 6:20 PM > To: Tan, Jianfeng > Cc: m...@redhat.com; Liu, Yuanhan; dev@dpdk.org > Subject: Re: vhost user MTU and promisc mode > > Hi Jianfeng, > > On 02/06/2017 07:39 AM, Tan

Re: [dpdk-dev] [PATCH v3 1/4] net/i40e: fix bitmask of supported Tx flags

2017-02-07 Thread Ferruh Yigit
On 2/7/2017 3:45 PM, Wu, Jingjing wrote: >>> +#ifdef RTE_LIBRTE_IEEE1588 >>> +#define I40E_TX_IEEE1588_TMST PKT_TX_IEEE1588_TMST #else #define >>> +I40E_TX_IEEE1588_TMST 0 #endif >>> + >>> #define I40E_TX_CKSUM_OFFLOAD_MASK (\ >>> PKT_TX_IP_CKSUM |\ >>>

Re: [dpdk-dev] [PATCH] igb_uio: map dummy dma forcing iommu domain attachment

2017-02-07 Thread Ferruh Yigit
Hi Alejandro, On 1/18/2017 12:27 PM, Alejandro Lucero wrote: > For using a DPDK app when iommu is enabled, it requires to > add iommu=pt to the kernel command line. But using igb_uio driver > makes DMAR errors because the device has not an IOMMU domain. Please help to understand the scope of the

Re: [dpdk-dev] [PATCH v3 1/4] net/i40e: fix bitmask of supported Tx flags

2017-02-07 Thread Wu, Jingjing
> > +#ifdef RTE_LIBRTE_IEEE1588 > > +#define I40E_TX_IEEE1588_TMST PKT_TX_IEEE1588_TMST #else #define > > +I40E_TX_IEEE1588_TMST 0 #endif > > + > > #define I40E_TX_CKSUM_OFFLOAD_MASK (\ > > PKT_TX_IP_CKSUM |\ > > PKT_TX_L4_MASK |

Re: [dpdk-dev] [PATCH v3] net/i40evf: fix reporting of imissed packets

2017-02-07 Thread Wu, Jingjing
> -Original Message- > From: Yigit, Ferruh > Sent: Thursday, December 8, 2016 2:30 AM > To: Tom Crugnale ; Wu, Jingjing > ; Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] net/i40evf: fix reporting of imissed > packets > > On 12/6/2016 8:16 PM, Tom Crugnale wrote:

Re: [dpdk-dev] [PATCH v2] net/i40e: set no drop for traffic class

2017-02-07 Thread Wu, Jingjing
> -Original Message- > From: Sexton, Rory > Sent: Thursday, January 19, 2017 6:38 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Marjanovic, Nemanja > Subject: RE: [PATCH v2] net/i40e: set no drop for traffic class > > Perhaps the best solution is as suggested to set > rte_eth_conf.dcb_cap

Re: [dpdk-dev] [PATCH 4/4] app/test: unit test case to exercise eventdev vdev uninit

2017-02-07 Thread Van Haaren, Harry
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, February 6, 2017 5:24 AM > To: dev@dpdk.org > Cc: Richardson, Bruce ; hemant.agra...@nxp.com; > Eads, Gage > ; Van Haaren, Harry ; Jerin > Jacob > > Subject: [dpdk-dev] [PATCH 4/4] app/test:

Re: [dpdk-dev] [PATCH 3/4] event/skeleton: add vdev uninit support

2017-02-07 Thread Van Haaren, Harry
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, February 6, 2017 5:24 AM > To: dev@dpdk.org > Cc: Richardson, Bruce ; hemant.agra...@nxp.com; > Eads, Gage > ; Van Haaren, Harry ; Jerin > Jacob > > Subject: [dpdk-dev] [PATCH 3/4] event/skel

Re: [dpdk-dev] [PATCH 2/4] evendev: add vdev uninit support

2017-02-07 Thread Van Haaren, Harry
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, February 6, 2017 5:24 AM > To: dev@dpdk.org > Cc: Richardson, Bruce ; hemant.agra...@nxp.com; > Eads, Gage > ; Van Haaren, Harry ; Jerin > Jacob > > Subject: [dpdk-dev] [PATCH 2/4] evendev: a

Re: [dpdk-dev] [PATCH 1/4] eventdev: fix event driver name to eventdev lookup

2017-02-07 Thread Van Haaren, Harry
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, February 6, 2017 5:24 AM > To: dev@dpdk.org > Cc: Richardson, Bruce ; hemant.agra...@nxp.com; > Eads, Gage > ; Van Haaren, Harry ; Jerin > Jacob > > Subject: [dpdk-dev] [PATCH 1/4] eventdev:

Re: [dpdk-dev] i40e_aq_get_phy_capabilities() fails when using SFP+ with no link

2017-02-07 Thread Zhang, Helin
Hi Oliver Very good to know that good news! Thank you! Regards, Helin -Original Message- From: Olivier MATZ [mailto:olivier.m...@6wind.com] Sent: Tuesday, February 7, 2017 10:56 PM To: Zhang, Helin Cc: Zhang, Qi Z ; Ivan Nardi ; dev@dpdk.org; Olivier MATZ ; Christos Ricudis ; Rowden,

Re: [dpdk-dev] i40e_aq_get_phy_capabilities() fails when using SFP+ with no link

2017-02-07 Thread Olivier MATZ
Hi Helin, On Mon, 6 Feb 2017 01:36:45 +, "Zhang, Helin" wrote: > Hi guys > > There may have firmware dependencies, new DPDK version + old firmware > version may not work. Please refer to below link to see what type of > firmware has been validated with 16.11 DPDK. > http://dpdk.org/doc/guide

Re: [dpdk-dev] [PATCH v2] i40e: Fix eth_i40e_dev_init sequence on ThunderX

2017-02-07 Thread Ferruh Yigit
On 11/18/2016 12:52 PM, Satha Rao wrote: > i40e_asq_send_command: rd32 & wr32 under ThunderX gives unpredictable >results. To solve this include rte memory barriers > > Signed-off-by: Satha Rao I remove this patch from patchwork. "I/O device memory read/write API" patch s

[dpdk-dev] [PATCH] examples/l2fwd-crypto: fix overflow

2017-02-07 Thread Pablo de Lara
This commit fixes an array overflow when number of crypto devices is higher than 32. Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application") Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/exam

[dpdk-dev] [PATCH RFCv3 19/19] ring: add event ring implementation

2017-02-07 Thread Bruce Richardson
DEMO ONLY: add an event ring implementation to demonstrate how rings for new types can be efficiently added by reusing existing rte ring functions. Signed-off-by: Bruce Richardson --- app/test/Makefile| 1 + app/test/test_event_ring.c | 85 +++ lib/librte_ring/Makefi

[dpdk-dev] [PATCH RFCv3 18/19] ring: add object size parameter to memory size calculation

2017-02-07 Thread Bruce Richardson
Add in an extra parameter for the ring element size to the function which calculates the amount of memory needed for a ring. Signed-off-by: Bruce Richardson --- lib/librte_ring/rte_ring.c | 6 +++--- lib/librte_ring/rte_ring.h | 5 - 2 files changed, 7 insertions(+), 4 deletions(-) diff --g

[dpdk-dev] [PATCH RFCv3 13/19] ring: allow dequeue fns to return remaining entry count

2017-02-07 Thread Bruce Richardson
Add an extra parameter to the ring dequeue burst/bulk functions so that those functions can optionally return the amount of remaining objs in the ring. This information can be used by applications in a number of ways, for instance, with single-consumer queues, it provides a max dequeue size which i

[dpdk-dev] [PATCH RFCv3 16/19] ring: create common function for updating tail idx

2017-02-07 Thread Bruce Richardson
Both producer and consumer use the same logic for updating the tail index so merge into a single function. Signed-off-by: Bruce Richardson --- lib/librte_ring/rte_ring.h | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/lib/librte_ring/rte_rin

[dpdk-dev] [PATCH RFCv3 17/19] ring: allow macros to work with any type of object

2017-02-07 Thread Bruce Richardson
Modify the enqueue and dequeue macros to support copying any type of object by passing in the exact object type. We no longer need a placeholder element array in the ring structure, since the macros just take the address of the end of the structure, so remove it, leaving the rte_ring structure as a

[dpdk-dev] [PATCH RFCv3 15/19] ring: separate out head index manipulation for enq/deq

2017-02-07 Thread Bruce Richardson
We can write a single common function for head manipulation for enq and a common one for deq, allowing us to have a single worker function for enq and deq, rather than two of each. Update all other inline functions to use the new functions. Signed-off-by: Bruce Richardson --- lib/librte_ring/rte

[dpdk-dev] [PATCH RFCv3 14/19] ring: reduce scope of local variables

2017-02-07 Thread Bruce Richardson
The local variable i is only used for loop control so define it in the enqueue and dequeue blocks directly, rather than at the function level. Signed-off-by: Bruce Richardson --- lib/librte_ring/rte_ring.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/librte_ring/

[dpdk-dev] [PATCH RFCv3 12/19] examples/quota_watermark: use ring space for watermarks

2017-02-07 Thread Bruce Richardson
Now that the enqueue function returns the amount of space in the ring, we can use that to replace the old watermark functionality. Update the example app to do so, and re-enable it in the examples Makefile. NOTE: RFC, THIS IS NOT YET TESTED Signed-off-by: Bruce Richardson --- examples/Makefile

[dpdk-dev] [PATCH RFCv3 09/19] ring: remove watermark support

2017-02-07 Thread Bruce Richardson
Remove the watermark support. A future commit will add support for having enqueue functions return the amount of free space in the ring, which will allow applications to implement their own watermark checks, while also being more useful to the app. Signed-off-by: Bruce Richardson --- app/test/co

[dpdk-dev] [PATCH RFCv3 11/19] ring: allow enq fns to return free space value

2017-02-07 Thread Bruce Richardson
Add an extra parameter to the ring enqueue burst/bulk functions so that those functions can optionally return the amount of free space in the ring. This information can be used by applications in a number of ways, for instance, with single-producer queues, it provides a max enqueue size which is gu

[dpdk-dev] [PATCH RFCv3 10/19] ring: make bulk and burst fn return vals consistent

2017-02-07 Thread Bruce Richardson
The bulk fns for rings returns 0 for all elements enqueued and negative for no space. Change that to make them consistent with the burst functions in returning the number of elements enqueued/dequeued, i.e. 0 or N. This change also allows the return value from enq/deq to be used directly without a

[dpdk-dev] [PATCH RFCv3 07/19] ring: remove debug setting

2017-02-07 Thread Bruce Richardson
The debug option only provided some statistics to the user most of which could be tracked by the application itself. Remove this as a compile time option, and feature, simplifying the code somewhat. Signed-off-by: Bruce Richardson --- app/test/test_ring.c | 410

[dpdk-dev] [PATCH RFCv3 08/19] ring: remove the yield when waiting for tail update

2017-02-07 Thread Bruce Richardson
There was a compile time setting to enable a ring to yield when it entered a loop in mp or mc rings waiting for the tail pointer update. Build time settings are not recommended for enabling/disabling features, and since this was off by default, remove it completely. If needed, a runtime enabled equ

[dpdk-dev] [PATCH RFCv3 05/19] crypto/null: use ring size function

2017-02-07 Thread Bruce Richardson
Rather than reading the size directly from the ring structure, use the dedicated function for that purpose. Signed-off-by: Bruce Richardson --- drivers/crypto/null/null_crypto_pmd_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/null/null_crypto_pmd_ops.c

[dpdk-dev] [PATCH RFCv3 06/19] ring: eliminate duplication of size and mask fields

2017-02-07 Thread Bruce Richardson
The size and mask fields are duplicated in both the producer and consumer data structures. Move them out of that into the top level structure so they are not duplicated. Signed-off-by: Bruce Richardson --- app/test/test_ring.c | 6 +++--- lib/librte_ring/rte_ring.c | 20 ++

[dpdk-dev] [PATCH RFCv3 04/19] ring: add a function to return the ring size

2017-02-07 Thread Bruce Richardson
Applications and other libraries should not be reading inside the rte_ring structure directly to get the ring size. Instead add a fn to allow it to be queried. Signed-off-by: Bruce Richardson --- lib/librte_ring/rte_ring.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/lib/l

[dpdk-dev] [PATCH RFCv3 03/19] ring: create common structure for prod and cons metadata

2017-02-07 Thread Bruce Richardson
create a common structure to hold the metadata for the producer and the consumer, since both need essentially the same information - the head and tail values, the ring size and mask. Signed-off-by: Bruce Richardson --- lib/librte_ring/rte_ring.h | 32 1 file chan

[dpdk-dev] [PATCH RFCv3 02/19] ring: remove split cacheline build setting

2017-02-07 Thread Bruce Richardson
There has been for some time in the rte_rings a build-time config value to optionally split the producer and consumer information on to separate cachelines. This should not really need to be a tunable, so just remove the option and set the information to be always split. For improved performance us

[dpdk-dev] [PATCH RFCv3 01/19] app/pdump: fix duplicate macro definition

2017-02-07 Thread Bruce Richardson
RTE_RING_SZ_MASK is redefined here with the original definition in rte_ring.h. Since rte_ring.h is already included, just remove the duplicate definition here. Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing") Signed-off-by: Bruce Richardson --- app/pdump/main.c | 1 - 1 file cha

[dpdk-dev] [PATCH RFCv3 00/19] ring cleanup and generalization

2017-02-07 Thread Bruce Richardson
This patchset make a set of, sometimes non-backward compatible, cleanup changes to the rte_ring code in order to improve it. The resulting code is shorter*, since the existing functions are restructured to reduce code duplication, as well as being more consistent in behaviour. The specific changes

Re: [dpdk-dev] [PATCH] config: add default MPIPE PMD config to common base

2017-02-07 Thread Thomas Monjalon
2017-01-30 17:00, Ferruh Yigit: > On 1/30/2017 10:46 AM, Thomas Monjalon wrote: > > 2017-01-30 10:40, Ferruh Yigit: > >> --- a/config/common_base > >> +++ b/config/common_base > >> @@ -219,6 +219,12 @@ CONFIG_RTE_LIBRTE_MLX5_DEBUG=n > >> CONFIG_RTE_LIBRTE_MLX5_TX_MP_CACHE=8 > >> > >> # > >> +#

Re: [dpdk-dev] [PATCH] net/i40e: fix tunnel filter issue

2017-02-07 Thread Ferruh Yigit
On 2/6/2017 8:52 AM, Beilei Xing wrote: > Creating IPv4 flow and IPv6 flow will cause confilct error. > Root cause is there's no IP info included in tunnel filter > input. > > Fixes: 425c3325f0b0 ("net/i40e: store tunnel filter") > Fixes: d416530e6358 ("net/i40e: parse tunnel filter") > > Signed-

Re: [dpdk-dev] [PATCH v2] net/i40e: fix parsing tunnel filter issue

2017-02-07 Thread Ferruh Yigit
On 2/6/2017 5:29 AM, Beilei Xing wrote: > VNI of VXLAN is parsed wrongly. The root cause is that > array vni in item VXLAN also uses network byte ordering. > > Fixes: d416530e6358 ("net/i40e: parse tunnel filter") > > Signed-off-by: Beilei Xing Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/i40e: fix tunnel filter issue

2017-02-07 Thread Ferruh Yigit
On 2/6/2017 8:52 AM, Beilei Xing wrote: > Creating IPv4 flow and IPv6 flow will cause confilct error. > Root cause is there's no IP info included in tunnel filter > input. > > Fixes: 425c3325f0b0 ("net/i40e: store tunnel filter") > Fixes: d416530e6358 ("net/i40e: parse tunnel filter") > > Signed-

Re: [dpdk-dev] [PATCH v2] net/ena: solve problem with host attributes

2017-02-07 Thread Ferruh Yigit
On 2/6/2017 11:56 AM, Jakub Palider wrote: > The hardware may reject adding host_info in case support for > host_info is missing in the list of supported features. On the > other hand the list of supported featues may contain support > for the host_info - typical bootstrap problem. > This patch sol

Re: [dpdk-dev] [PATCH v3] net/ixgbe: clean up rte_eth_dev_info_get

2017-02-07 Thread Ferruh Yigit
On 2/7/2017 2:08 PM, Ferruh Yigit wrote: > On 2/7/2017 6:33 AM, Wenzhuo Lu wrote: >> It's not appropriate to call rte_eth_dev_info_get in PMD, >> as rte_eth_dev_info_get need to get info from PMD. >> Remove rte_eth_dev_info_get from PMD code and get the >> info directly. >> >> Signed-off-by: Wenzhu

Re: [dpdk-dev] [PATCH v3] net/ixgbe: clean up rte_eth_dev_info_get

2017-02-07 Thread Ferruh Yigit
On 2/7/2017 6:33 AM, Wenzhuo Lu wrote: > It's not appropriate to call rte_eth_dev_info_get in PMD, > as rte_eth_dev_info_get need to get info from PMD. > Remove rte_eth_dev_info_get from PMD code and get the > info directly. > > Signed-off-by: Wenzhuo Lu Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v3 7/7] net/tap: move closing fds to pmd close from pmd stop

2017-02-07 Thread Ferruh Yigit
On 2/7/2017 8:51 AM, Pascal Mazon wrote: <...> >> Signed-off-by: Keith Wiles <...> > Acked-by: Pascal Mazon Series applied to dpdk-next-net/master, thanks. ( patch 1/7: docs: fix tap PMD docs for device name patch 4/7: Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") patch 5/7: checkp

Re: [dpdk-dev] [PATCH v3 1/4] net/i40e: fix bitmask of supported Tx flags

2017-02-07 Thread Ferruh Yigit
On 2/7/2017 3:22 AM, Jingjing Wu wrote: > PKT_TX_TUNNEL_MASK and PKT_TX_IEEE1588_TMST are missed in bitmask > of all supported packet Tx flags by i40e. It will cause packet preparing > fail when sending tunnel packets with Tx offload. > This patch fixes it. > > Fixes: 3f33e643e5c6 ("net/i40e: add

Re: [dpdk-dev] [PATCH] doc: update the document for virtio xstats feature

2017-02-07 Thread Remy Horton
Does virtio_vec.ini need updating as well? On 07/02/2017 09:40, Jiayu Hu wrote: Currently, extended statistics has been supported by virtio. But there are no corresponding document updates. Therefore, this patch is to update the document for virtio xstats feature. Signed-off-by: Jiayu Hu ---

Re: [dpdk-dev] [PATCH] doc: announce kni_vhost removal

2017-02-07 Thread Ferruh Yigit
On 11/17/2016 1:27 PM, Ferruh Yigit wrote: > Signed-off-by: Ferruh Yigit > --- > doc/guides/prog_guide/kernel_nic_interface.rst | 2 ++ > doc/guides/rel_notes/deprecation.rst | 6 ++ > 2 files changed, 8 insertions(+) > > diff --git a/doc/guides/prog_guide/kernel_nic_interface.rst

Re: [dpdk-dev] [PATCH v1] doc: add distributor library API change notice

2017-02-07 Thread Bruce Richardson
On Mon, Feb 06, 2017 at 08:08:29AM +, David Hunt wrote: > Given that the packet distributor library improvements (1) will > not be in 17.02, I plan on doing some consolidation of the > API for burst operation for 17.05, merging the two api's into > one, with options for single or burst operatio

Re: [dpdk-dev] [PATCH] net/i40e: fix wrong device flag setup

2017-02-07 Thread Ferruh Yigit
On 2/7/2017 10:24 AM, Ferruh Yigit wrote: > On 2/3/2017 11:36 PM, Qi Zhang wrote: >> dev_flags is wrong overwritten by RTE_ETH_DEV_DETACHABLE after >> rte_eth_copy_pci_info. >> >> Fixes: 22dda618c00c ("pci: separate detaching ethernet ports from PCI >> devices") >> >> Signed-off-by: Qi Zhang >> -

Re: [dpdk-dev] [PATCH] doc: add tested platforms and nics and OSes

2017-02-07 Thread Thomas Monjalon
2017-02-04 03:57, Pei, Yulong: > Hi Thomas, > > Did you notice this patch ? do you have any comments ? Hi, For this patch, I prefer waiting the go (ack) from John.

[dpdk-dev] [PATCH] app/crypto-perf: fix total_ops value validation

2017-02-07 Thread Kuba Kozak
Added total_ops value validation in parse_total_ops() function. Coverity issue: 141070 Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Kuba Kozak --- app/test-crypto-perf/cperf_options_parsing.c | 8 +++- 1 file changed, 7 insertions(+), 1 del

Re: [dpdk-dev] [PATCH] net/i40e: fix wrong device flag setup

2017-02-07 Thread Ferruh Yigit
On 2/3/2017 11:36 PM, Qi Zhang wrote: > dev_flags is wrong overwritten by RTE_ETH_DEV_DETACHABLE after > rte_eth_copy_pci_info. > > Fixes: 22dda618c00c ("pci: separate detaching ethernet ports from PCI > devices") > > Signed-off-by: Qi Zhang > --- > drivers/net/bnxt/bnxt_ethdev.c | 2 +-

Re: [dpdk-dev] 17.02-rc2: i40e and LSC

2017-02-07 Thread Ivan Nardi
Hi Qi thanks for pointing me to that patch! Regards Ivan On 7 February 2017 at 02:13, Zhang, Qi Z wrote: > Hi Ivan: > This is a bug and is fixed with below patch > http://dpdk.org/dev/patchwork/patch/20163/ > Regards > Qi > >> -Original Message- >> From: dev [mailto:dev-b

Re: [dpdk-dev] i40e and memory allocations restricted on node 1

2017-02-07 Thread Ivan Nardi
Hi Helin no luck with the latest nvm PMD: eth_i40e_dev_init(): FW 5.0 API 1.5 NVM 05.00.05 eetrack 800028ac RING: Cannot reserve memory HASH: memory allocation failed PMD: i40e_init_ethtype_filter_list(): Failed to create ethertype hash table! EAL: Error - exiting with code: 1 It seems to me the

Re: [dpdk-dev] [PATCH] eventdev: limit port link operation to configured queues

2017-02-07 Thread Nipun Gupta
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, February 06, 2017 11:00 > To: dev@dpdk.org > Cc: bruce.richard...@intel.com; Hemant Agrawal > ; gage.e...@intel.com; > harry.van.haa...@intel.com; Nipun Gupta ; Jerin Jacob > > Subject: [dpdk

Re: [dpdk-dev] [PATCH v2 07/15] event/sw: add support for event queues

2017-02-07 Thread Van Haaren, Harry
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Tuesday, February 7, 2017 6:58 AM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Richardson, Bruce > Subject: Re: [PATCH v2 07/15] event/sw: add support for event queues > > On Mon, Feb 06, 2017 at 10:2

[dpdk-dev] [PATCH v3] app/test-crypto-perf: fix compilation under FreeBSD

2017-02-07 Thread Daniel Mrzyglod
This patch fixes error: implicit declaration of function 'getline' Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Daniel Mrzyglod --- v3: * remove gcc from commit subject because it's common for all compillers v2: * rewrite patch messege * add fix

[dpdk-dev] [PATCH] doc: update the document for virtio xstats feature

2017-02-07 Thread Jiayu Hu
Currently, extended statistics has been supported by virtio. But there are no corresponding document updates. Therefore, this patch is to update the document for virtio xstats feature. Signed-off-by: Jiayu Hu --- doc/guides/nics/features/virtio.ini | 1 + 1 file changed, 1 insertion(+) diff --g

Re: [dpdk-dev] Hotplug support for VFIO

2017-02-07 Thread Alejandro Lucero
It seems none is working on this VFIO support. I will work on this if there is no reply to this thread saying the opposite the next days. On Thu, Feb 2, 2017 at 12:58 PM, Eelco Chaudron wrote: > On 02/02/17 13:05, Burakov, Anatoly wrote: > >> Hi Eelco, >> >> Please forgive me my ignorance on th

[dpdk-dev] [PATCH] app/test-crypto-perf: fix uninitialized scalar variable

2017-02-07 Thread Aleksander Gajewski
Fix problem with uninitialized nb_cryptodevs variable by initialize it with 0 value. Program could jump to err label without running cperf_initialize_cryptodev() function. Coverity issue: 141073 Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Aleksan

[dpdk-dev] [PATCH] app/test-crypto-perf: fix buffer not null terminated

2017-02-07 Thread Aleksander Gajewski
Fix problem: the string buffer may not have a null terminator if the source string's length is equal to the buffer size. Coverity issue: 141069 Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Aleksander Gajewski --- app/test-crypto-perf/cperf_optio

Re: [dpdk-dev] [PATCH v3 7/7] net/tap: move closing fds to pmd close from pmd stop

2017-02-07 Thread Pascal Mazon
On Mon, 6 Feb 2017 13:40:38 -0600 Keith Wiles wrote: > At the same time remove closing fds code from pmd stop routine. > > Signed-off-by: Keith Wiles > --- > drivers/net/tap/rte_eth_tap.c | 18 +++--- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/drivers/net

Re: [dpdk-dev] [PATCH] eventdev: update event port link and unlink callbacks

2017-02-07 Thread Jerin Jacob
On Tue, Feb 07, 2017 at 12:34:37AM +0530, Nipun Gupta wrote: > Added a pointer to the rte_eventdev type in the event port > link and unlink callbacks. This device shall be used by some > of the event drivers to fetch queue related information. > > Also, update the skeleton eventdev driver with cor