Re: [dpdk-dev] [PATCH v3] eventdev: amend timeout criteria comment for burst dequeue

2017-03-07 Thread Nipun Gupta
Thanks Jerin. Patchwork still shows this patch in new state. Does this matter or shall I move it to accepted state? Regards, Nipun > -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, March 06, 2017 18:52 > To: Nipun Gupta > Cc: dev@dpdk.org; H

[dpdk-dev] [PATCH] net/ixgbe: delete useless function declaration

2017-03-07 Thread Wei Zhao
delete useless function declarations in file ixgbe_flow.c and adjust function defination position to aviod compile error. Signed-off-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_flow.c | 142 - 1 file changed, 26 insertions(+), 116 deletions(-) diff --git a/d

[dpdk-dev] [PATCH v3] doc: fix parameter of virtio_user for container

2017-03-07 Thread Yong Wang
Update the "Virtio_user for Container Networking" doc, add the "--file-prefix" option to testpmd in host and container to avoid hugepage config file conflict. Fixes: 50665deebda0 ("doc: add guide to use virtio-user for container networking") Signed-off-by: Yong Wang --- v3: * Modify the commit

Re: [dpdk-dev] [RFC PATCH] net/virtio: Align Virtio-net header on cache line in receive path

2017-03-07 Thread Yao, Lei A
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Monday, March 6, 2017 10:11 PM > To: Yuanhan Liu > Cc: Liang, Cunming ; Tan, Jianfeng > ; dev@dpdk.org; Wang, Zhihong > ; Yao, Lei A > Subject: Re: [RFC PATCH] net/virtio: Align Virtio-net header on

[dpdk-dev] [PATCH v2 18/18] net/fm10k/base: add base driver information

2017-03-07 Thread Qi Zhang
Add base driver information in Makefile. Signed-off-by: Qi Zhang --- drivers/net/fm10k/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/fm10k/Makefile b/drivers/net/fm10k/Makefile index afcbd1d..3985c0b 100644 --- a/drivers/net/fm10k/Makefile +++ b/drivers/net/fm10k/Makef

[dpdk-dev] [PATCH v2 17/18] net/fm10k/base: request reset when mbx->state changes

2017-03-07 Thread Qi Zhang
Multiple IES API resets can cause a race condition where the mailbox interrupt request bits can be cleared before being handled. This can leave certain mailbox messages from the PF to be untreated and the PF will enter in some inactive state. If this situation occurs, the IES API will initiate a ma

[dpdk-dev] [PATCH v2 15/18] net/fm10k/base: improve re-map queues handle

2017-03-07 Thread Qi Zhang
Avoid potential FUM fault errors on a VF when updating MAC address and VLAN information. Only use the register flow when the mailbox is disconnected, by checking if the enqueue_tx returns FM10K_MBX_ERR_NO_MBX. If the mailbox message can be sent, there is no reason to bother with the register writes

[dpdk-dev] [PATCH v2 16/18] net/fm10k/base: replace macros

2017-03-07 Thread Qi Zhang
Other shared code bases are planning on using IS_MULTICAST_ETHER_ADDR and friends without leaving the driver name in the macro. Remove reference to FM10K here so that we can re-use the specific compat flags from Linux. Signed-off-by: Qi Zhang --- drivers/net/fm10k/base/fm10k_pf.c | 10 +---

[dpdk-dev] [PATCH v2 14/18] net/fm10k/base: add macro for geneve tunnel offload

2017-03-07 Thread Qi Zhang
add necessary macro to support geneve tunnel offload. Signed-off-by: Qi Zhang --- drivers/net/fm10k/base/fm10k_type.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/fm10k/base/fm10k_type.h b/drivers/net/fm10k/base/fm10k_type.h index d43e40c..931633d 100644 --- a/drivers/net/fm1

[dpdk-dev] [PATCH v2 13/18] net/fm10k/base: don't stop reset

2017-03-07 Thread Qi Zhang
Don't report FM10K_ERR_REQUESTS_PENDING when we fail to disable queues within the timeout. This can occur due to a hardware Tx hang, or when the switch ethernet fabric is resetting while we are transmitting traffic. It can sometimes take up to 500ms before the Tx DMA engine gives up. Instead, just

[dpdk-dev] [PATCH v2 09/18] net/fm10k/base: update comment regarding reserved bits check

2017-03-07 Thread Qi Zhang
The original comment may be read incorrectly as referring to checking the *entire* length is zero. However, it merely checks only the reserved bits of both length and reserved in a small amount of code. Update the comment to indicate this is a clever trick and clearly spell out that it only checks

[dpdk-dev] [PATCH v2 10/18] net/fm10k/base: improve VF's multi-bit VLAN update requests

2017-03-07 Thread Qi Zhang
The VF uses a multi-bit update request to clear unused VLANs whenever it resets. However, an accident in a previous refactor broke multi-bit updates for VFs, due to misreading a comment in fm10k_vf.c and attempting to reduce code duplication. The problem occurs because a multi-bit request has a non

[dpdk-dev] [PATCH v2 12/18] net/fm10k/base: add macros for global interrupt

2017-03-07 Thread Qi Zhang
Add two macros for global interrupt. Signed-off-by: Qi Zhang --- drivers/net/fm10k/base/fm10k_mbx.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/fm10k/base/fm10k_mbx.h b/drivers/net/fm10k/base/fm10k_mbx.h index edc57df..2fac012 100644 --- a/drivers/net/fm10k/base/fm10k_mbx.

[dpdk-dev] [PATCH v2 11/18] net/fm10k/base: enable lport map request

2017-03-07 Thread Qi Zhang
If the fm10k interface is brought up, but the switch manager software is not running, the driver will continuously request the lport map every few seconds in the base driver watchdog routine. Eventually after several minutes the switch mailbox Tx fifo will fill up and the mailbox will timeout, resu

[dpdk-dev] [PATCH v2 08/18] net/fm10k/base: use different name for override bit

2017-03-07 Thread Qi Zhang
Use a new #define FM10K_VLAN_OVERRIDE even though we're using the exact same bit. The reason for this is clarity in the code, otherwise you can read FM10K_VLAN_CLEAR and think it should be removed. Also add a comment explaining why the FM10K_VLAN_OVERRIDE bit is set. Signed-off-by: Qi Zhang ---

[dpdk-dev] [PATCH v2 06/18] net/fm10k/base: add new item to lport msg attr

2017-03-07 Thread Qi Zhang
Add FM10K_PF_ATTR_ID_ERR, since it is possible for the switch manager to send out an error message indicating status of the LPORT_MAP due to zero allocated bandwidth. Signed-off-by: Qi Zhang --- drivers/net/fm10k/base/fm10k_pf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/f

[dpdk-dev] [PATCH v2 07/18] net/fm10k/base: update comment

2017-03-07 Thread Qi Zhang
The diagram represents bit layout of the multi-bit VLAN update message format. Re-draw the numbers using base 8, and mark the bit values every 8 bits at the top. This should make it more easy to grasp the table quickly. Signed-off-by: Qi Zhang --- drivers/net/fm10k/base/fm10k_pf.c | 4 ++-- 1 fi

[dpdk-dev] [PATCH v2 04/18] net/fm10k/base: add error code

2017-03-07 Thread Qi Zhang
Add API error code for when PEP is not scheduled. Signed-off-by: Qi Zhang --- drivers/net/fm10k/base/fm10k_pf.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/fm10k/base/fm10k_pf.h b/drivers/net/fm10k/base/fm10k_pf.h index c84b1bc..ca125c2 100644 --- a/drivers/net/fm10k/base/

[dpdk-dev] [PATCH v2 05/18] net/fm10k/base: clean up the logic

2017-03-07 Thread Qi Zhang
Clean up the logic in fm10k_tlv_attr_parse, we should not reply on that FM10K_NOT_IMPLEMENTED is greater than zero, as this can easily cause confusion. The patch also correct a minor document error. Signed-off-by: Qi Zhang --- drivers/net/fm10k/base/fm10k_tlv.c | 16 +--- 1 file chan

[dpdk-dev] [PATCH v2 03/18] net/fm10k/base: expose macros needed by DPDK

2017-03-07 Thread Qi Zhang
Add back macros that DPDK required and remove the redundant ones in fm10k_osdep.h. Signed-off-by: Qi Zhang --- drivers/net/fm10k/base/fm10k_osdep.h | 17 drivers/net/fm10k/base/fm10k_type.h | 50 2 files changed, 50 insertions(+), 17 deletions(-

[dpdk-dev] [PATCH v2 02/18] net/fm10k/base: reset multicast mode when deleting lport

2017-03-07 Thread Qi Zhang
Deleting lport when multicast mod is configured to FM10K_XCAST_MODE_ALLMULTI or FM10K_XCAST_MODE_PROMISC will result in generating orphaned multicast-group entries in the switch manager. Before deleting the lport, reset multicast mode to FM10K_XCAST_MODE_NONE to flush out these multicast-group entr

[dpdk-dev] [PATCH v2 01/18] net/fm10k/base: add a flag to indicate VF trust mode

2017-03-07 Thread Qi Zhang
Adds boolean flag in fm10k_vf_info to support configuring a VF to be trusted. Signed-off-by: Qi Zhang --- drivers/net/fm10k/base/fm10k_type.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/fm10k/base/fm10k_type.h b/drivers/net/fm10k/base/fm10k_type.h index 3fc8f13..fe3e498 1

[dpdk-dev] [PATCH v2 00/18] net/fm10k: update base code.

2017-03-07 Thread Qi Zhang
The patch set update to latest fm10k base code, there is no significent features be added, but include couple enhancement like clean up the logic for tlv attr parse, improve VF multi-bit VLAN handle etc, also with some code/comment clean as well. v2: - add base code information - correct cou

Re: [dpdk-dev] [PATCH v2] doc: fix parameter of virtio_user for container

2017-03-07 Thread Yuanhan Liu
On Wed, Mar 08, 2017 at 12:17:51AM -0500, Yong Wang wrote: > Update the "Virtio_user for Container Networking" doc, add the > "--file-prefix" option to testpmd in host and container to avoid > hugepage config file conflict. > > Fixes: 50665deebda0 ("doc: add guide to use virtio-user for container

[dpdk-dev] [PATCH v2] doc: fix parameter of virtio_user for container

2017-03-07 Thread Yong Wang
Update the "Virtio_user for Container Networking" doc, add the "--file-prefix" option to testpmd in host and container to avoid hugepage config file conflict. Fixes: 50665deebda0 ("doc: add guide to use virtio-user for container networking") --- v2: * Modify the fixline from two lines to one lin

Re: [dpdk-dev] Issues with ixgbe and rte_flow

2017-03-07 Thread Lu, Wenzhuo
Hi Le Scouarnec, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Le Scouarnec Nicolas > Sent: Tuesday, March 7, 2017 7:12 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh > Subject: [dpdk-dev] Issues with ixgbe and rte_flow > > Dear all, > > I have been using the new

Re: [dpdk-dev] [PATCH v2 4/7] vhost: Add API to get MTU value

2017-03-07 Thread Yuanhan Liu
On Mon, Mar 06, 2017 at 09:27:37AM +0100, Maxime Coquelin wrote: > This patch implements the function for the application to > get the MTU value. > > rte_vhost_mtu_get() fills the mtu parameter with the MTU value > set in QEMU if VIRTIO_NET_F_MTU has been negotiated and returns 0, > -ENOTSUP other

[dpdk-dev] [PATCH] maintainers: update for vmxnet3

2017-03-07 Thread Shrikrishna Khare
Taking over DPDK vmxnet3 driver maintainer role. Signed-off-by: Shrikrishna Khare Acked-by: Yong Wang --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 01160d0..3c8aefa 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -376,7 +376,7

Re: [dpdk-dev] [PATCH v2 2/7] vhost: vhost-user: Add MTU protocol feature support

2017-03-07 Thread Yuanhan Liu
On Mon, Mar 06, 2017 at 09:27:35AM +0100, Maxime Coquelin wrote: > +static int > +vhost_user_net_set_mtu(struct virtio_net *dev, struct VhostUserMsg *msg) > +{ > + if (msg->payload.u64 < VIRTIO_MIN_MTU || > + msg->payload.u64 > VIRTIO_MAX_MTU) { > + RTE_LOG(ERR,

Re: [dpdk-dev] [PATCH] doc: fix parameter of virtio_user for container

2017-03-07 Thread Yuanhan Liu
On Tue, Mar 07, 2017 at 08:48:45AM -0500, Yong Wang wrote: > Update the "Virtio_user for Container Networking" doc, add the > "--file-prefix" option to testpmd in host and container to avoid > hugepage config file conflict. > > Fixes: 50665deebda0 ("doc: add guide to use virtio-user for container

Re: [dpdk-dev] [PATCH v2 6/6] net/i40e: implement descriptor status API

2017-03-07 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Wednesday, March 8, 2017 12:00 AM > To: dev@dpdk.org; thomas.monja...@6wind.com; Ananyev, Konstantin; Lu, > Wenzhuo; Zhang, Helin; Wu, Jingjing; adrien.mazarg...@6wind.com; > nelio.laranje...@6wind.com >

Re: [dpdk-dev] [PATCH v2 3/6] net/e1000: implement descriptor status API (igb)

2017-03-07 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Wednesday, March 8, 2017 12:00 AM > To: dev@dpdk.org; thomas.monja...@6wind.com; Ananyev, Konstantin; Lu, > Wenzhuo; Zhang, Helin; Wu, Jingjing; adrien.mazarg...@6wind.com; > nelio.laranje...@6wind.com >

[dpdk-dev] [PATCH v3] net/bonding: reduce slave starvation on rx poll

2017-03-07 Thread Keith Wiles
When polling the bonded ports for RX packets the old driver would always start with the first slave in the list. If the requested number of packets is filled on the first port in a two port config then the second port could be starved or have larger number of missed packet errors. The code attempt

[dpdk-dev] [PATCH v2] net/bonding: reduce slave starvation on rx poll

2017-03-07 Thread Keith Wiles
When polling the bonded ports for RX packets the old driver would always start with the first slave in the list. If the requested number of packets is filled on the first port in a two port config then the second port could be starved or have larger number of missed packet errors. The code attempt

Re: [dpdk-dev] [PATCH v5 0/3] new API to free consumed buffers in Tx ring

2017-03-07 Thread Thomas Monjalon
2017-01-27 13:37, Billy McFall: > Add a new API to free consumed buffers on TX ring. This addresses two > scenarios: > 1) Flooding a packet and want to reuse existing mbuf to avoid a packet > copy. Increment the reference count of the packet and poll new API until > reference count is decremented.

Re: [dpdk-dev] [PATCH v2 0/7] virtio/vhost: Add MTU feature support

2017-03-07 Thread Thomas Monjalon
2017-03-06 09:27, Maxime Coquelin: > This series target v17.05 release. I think you should add an entry in the release notes.

[dpdk-dev] [PATCH] net/bonding: reduce slave starvation on rx poll

2017-03-07 Thread Keith Wiles
When polling the bonded ports for RX packets the old driver would always start with the first slave in the list. If the requested number of packets is filled on the first port in a two port config then the second port could be starved or have larger number of missed packet errors. The code attempt

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-07 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Monday, March 6, 2017 8:07 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; jerin.ja...@caviumnetworks.com; > balasubramanian.manoha...@cavium.com; hemant.agra...@nxp.com; > shreyansh.j...@nxp.com; W

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add capability control API

2017-03-07 Thread Wiles, Keith
> On Mar 7, 2017, at 6:56 AM, Thomas Monjalon wrote: > > 2017-03-07 10:14, Dumitrescu, Cristian: >> From: Stephen Hemminger [mailto:step...@networkplumber.org] >>> On Mon, 6 Mar 2017 20:41:27 + >>> "Wiles, Keith" wrote: >>> Being able to add features without having to change DPDK mayb

Re: [dpdk-dev] [PATCH] doc: fix parameter of virtio_user for container

2017-03-07 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yong Wang > Sent: Tuesday, March 7, 2017 1:49 PM > To: Tan, Jianfeng ; yuanhan@linux.intel.com > Cc: dev@dpdk.org; Yong Wang > Subject: [dpdk-dev] [PATCH] doc: fix parameter of virtio_user for > container >

Re: [dpdk-dev] [PATCH v9 17/18] doc: distributor library changes for new burst API

2017-03-07 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt > Sent: Monday, March 6, 2017 9:11 AM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Hunt, David > > Subject: [dpdk-dev] [PATCH v9 17/18] doc: distributor library changes for > new burst API > > Signed-

Re: [dpdk-dev] [PATCHv8 00/46] NXP DPAA2 PMD

2017-03-07 Thread Ferruh Yigit
On 3/3/2017 12:46 PM, Hemant Agrawal wrote: > The patch series adds NXP’s QorIQ-Layerscape DPAA2 Architecture based > fsl-mc bus driver and network SoC PMD. This version of the driver > supports NXP LS208xA, LS204xA and LS108x families Network SoCs. > > DPAA2, or Data Path Acceleration Architectu

Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed buffers in Tx ring

2017-03-07 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Billy McFall > Sent: Friday, January 27, 2017 6:38 PM > To: thomas.monja...@6wind.com; Lu, Wenzhuo ; > olivier.m...@6wind.com > Cc: dev@dpdk.org; Billy McFall > Subject: [dpdk-dev] [PATCH v5 1/3] ethdev: new API

[dpdk-dev] [PATCH v2 4/4] net/tap: set MTU on the remote

2017-03-07 Thread Pascal Mazon
Signed-off-by: Pascal Mazon --- drivers/net/tap/rte_eth_tap.c | 29 +++-- 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index ed71cddfe0b3..34e56813cedb 100644 --- a/drivers/net/tap/rte_eth_tap.

[dpdk-dev] [PATCH v2 2/4] net/tap: reflect tap flags on the remote

2017-03-07 Thread Pascal Mazon
Synchronize PROMISC and ALLMULTI flags to the remote netdevice if possible. Leave the IFF_UP flag as it is, however. Signed-off-by: Pascal Mazon Acked-by: Olga Shern --- drivers/net/tap/rte_eth_tap.c | 36 +++- drivers/net/tap/tap.h | 2 ++ 2 files chan

[dpdk-dev] [PATCH v2 3/4] net/tap: use the remote MAC address if available

2017-03-07 Thread Pascal Mazon
The remote on a tap is most likely used with netdevices that are not under DPDK control. Outgoing traffic is supposed to use the source MAC address of the remote netdevice. This commit synchronizes the MAC address of the local tap netdevice with the remote one. Of course, it is still possible to

[dpdk-dev] [PATCH v2 1/4] net/tap: add remote netdevice traffic capture

2017-03-07 Thread Pascal Mazon
By default, a tap netdevice is of no use when not fed by a separate process. The ability to automatically feed it from another netdevice allows applications to capture any kind of traffic normally destined to the kernel stack. This patch implements this ability through a new optional "remote" para

[dpdk-dev] [PATCH v2 0/4] remote netdevice traffic capture

2017-03-07 Thread Pascal Mazon
This patchset adds the special "remote" feature to the tap PMD, that actually enables capturing traffic from another netdevice. This is especially useful to get packets into the DPDK app, when the remote netdevice has no DPDK support. The "remote" feature requires flow API support as flow rules wi

[dpdk-dev] [PATCH v3 5/6] net/tap: add packet type management

2017-03-07 Thread Pascal Mazon
Advertize RTE_PTYPE_UNKNOWN since tap does not report any packet type. Signed-off-by: Pascal Mazon --- doc/guides/nics/features/tap.ini | 1 + drivers/net/tap/rte_eth_tap.c| 15 +++ 2 files changed, 16 insertions(+) diff --git a/doc/guides/nics/features/tap.ini b/doc/guides/nic

[dpdk-dev] [PATCH v3 6/6] net/tap: add flow control management

2017-03-07 Thread Pascal Mazon
A tap netdevice does not support flow control; ensure nothing but RTE_FC_NONE mode can be set. Signed-off-by: Pascal Mazon --- doc/guides/nics/features/tap.ini | 1 + drivers/net/tap/rte_eth_tap.c| 19 +++ 2 files changed, 20 insertions(+) diff --git a/doc/guides/nics/featu

Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed buffers in Tx ring

2017-03-07 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Billy McFall > Sent: Tuesday, March 7, 2017 2:30 PM > To: Thomas Monjalon > Cc: Lu, Wenzhuo ; olivier.m...@6wind.com; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed > buf

[dpdk-dev] [PATCH v3 4/4] net/tap: add basic flow API patterns and actions

2017-03-07 Thread Pascal Mazon
Supported flow rules are now mapped to TC rules on the tap netdevice. The netlink message used for creating the TC rule is stored in struct rte_flow. That way, by simply changing a metadata in it, we can require for the rule deletion without further parsing. Supported items: - eth: src and dst (wi

[dpdk-dev] [PATCH v3 2/4] net/tap: add preliminary support for rte_flow

2017-03-07 Thread Pascal Mazon
The flow API provides the ability to classify packets received by a tap netdevice. This patch only implements skeleton functions for flow API support, no patterns are supported yet. Signed-off-by: Pascal Mazon Acked-by: Olga Shern --- doc/guides/nics/features/tap.ini | 1 + drivers/net/tap/M

[dpdk-dev] [PATCH v3 3/4] net/tap: add netlink back-end for flow API

2017-03-07 Thread Pascal Mazon
Each kernel netdevice may have queueing disciplines set for it, which determine how to handle the packet (mostly on egress). That's part of the TC (Traffic Control) mechanism. Through TC, it is possible to set filter rules that match specific packets, and act according to what is in the rule. This

[dpdk-dev] [PATCH v3 0/4] net/tap: support flow API

2017-03-07 Thread Pascal Mazon
This series add support for the flow API in tap PMD. It enables filtering specific packets incoming on the tap netdevice, to process only desired ones. Under the hood, it uses kernel TC (traffic control), which takes place very early in the stack, and supports most common pattern items and actions

[dpdk-dev] [PATCH v3 1/4] net/tap: move private elements to external header

2017-03-07 Thread Pascal Mazon
In the next patch, access to struct pmd_internals will be necessary in tap_flow.c to store the flows. Signed-off-by: Pascal Mazon Acked-by: Olga Shern --- drivers/net/tap/Makefile | 1 + drivers/net/tap/rte_eth_tap.c | 34 ++-- drivers/net/tap/tap.h | 73 ++

[dpdk-dev] [PATCH v3 4/6] net/tap: add MTU management

2017-03-07 Thread Pascal Mazon
The MTU is assigned to the tap netdevice according to the argument, but packet transmission and reception just write/read on an fd with the default limit being the socket buffer size. Signed-off-by: Pascal Mazon --- doc/guides/nics/features/tap.ini | 1 + drivers/net/tap/rte_eth_tap.c| 37 +

[dpdk-dev] [PATCH v3 3/6] net/tap: add multicast addresses management

2017-03-07 Thread Pascal Mazon
A tap netdevice actually receives every packet, without any filtering whatsoever. There is no need for any multicast address registration to receive multicast packets. Signed-off-by: Pascal Mazon --- doc/guides/nics/features/tap.ini | 1 + drivers/net/tap/rte_eth_tap.c| 13 + 2

[dpdk-dev] [PATCH v3 2/6] net/tap: add speed capabilities

2017-03-07 Thread Pascal Mazon
Tap PMD is flexible, it supports any speed. Signed-off-by: Pascal Mazon --- doc/guides/nics/features/tap.ini | 1 + drivers/net/tap/rte_eth_tap.c| 35 +++ 2 files changed, 36 insertions(+) diff --git a/doc/guides/nics/features/tap.ini b/doc/guides/nics/featu

[dpdk-dev] [PATCH v3 0/6] net/tap: add additional management ops

2017-03-07 Thread Pascal Mazon
Add a few eth_dev ops to the tap PMD for completeness. We want it to behave as much as possible as a standard PMD. v2 change: - use snprintf in tap_mtu set v3 change: - call tap_mac_set() only once in tap_setup_queue() Pascal Mazon (6): net/tap: add MAC address management ops net/tap: ad

[dpdk-dev] [PATCH v3 1/6] net/tap: add MAC address management ops

2017-03-07 Thread Pascal Mazon
Set a random MAC address when probing the device, as to not leave an empty MAC in pmd->eth_addr. This MAC will be set on the tap netdevice as soon as it's been created using tun_alloc(). As the tap_mac_add() function depend on the fd in the first rxq, move code from tun_alloc() to tap_setup_queue(

[dpdk-dev] [PATCH v3] eventdev: fix links map initialization for SW PMD

2017-03-07 Thread Gage Eads
This patch initializes the links_map array entries to EVENT_QUEUE_SERVICE_PRIORITY_INVALID, as expected by rte_event_port_links_get(). This is necessary for the sw eventdev PMD, which does not initialize links_map when rte_event_port_setup() calls rte_event_port_unlink(). Fixes: e36bf651b3ca2 ("ev

Re: [dpdk-dev] [PATCHv8 19/46] pool/dpaa2: add DPAA2 hardware offloaded mempool

2017-03-07 Thread Ferruh Yigit
On 3/3/2017 12:46 PM, Hemant Agrawal wrote: > Adding NXP DPAA2 architecture specific mempool support. > > This patch also registers a dpaa2 type MEMPOOL OPS > > Signed-off-by: Hemant Agrawal Cc'ing Olivier and Dave. Hi Olivier, Dave, Can you please help reviewing this patch? Thanks, ferruh

Re: [dpdk-dev] [PATCHv8 00/46] NXP DPAA2 PMD

2017-03-07 Thread Thomas Monjalon
2017-03-03 18:16, Hemant Agrawal: > v8: > * rebased over master (17.02: 35b09d76) > * Removed all drivers/common/* code and moved to drivers/bus/fslmc Looks to be the best place for these libraries (except outside of DPDK ;) Thanks for having moved them in the bus sub-directory.

Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed buffers in Tx ring

2017-03-07 Thread Thomas Monjalon
2017-03-07 09:29, Billy McFall: > On Mon, Feb 27, 2017 at 8:48 AM, Thomas Monjalon > wrote: > > I think you could use rte_errno (while keeping negative return codes). > > > > I can do that if you want, but if I understand your comment, it will make > the implementation of the function not as clea

[dpdk-dev] [PATCH v2 6/6] net/i40e: implement descriptor status API

2017-03-07 Thread Olivier Matz
Signed-off-by: Olivier Matz --- doc/guides/nics/features/i40e.ini| 2 ++ doc/guides/nics/features/i40e_vec.ini| 2 ++ doc/guides/nics/features/i40e_vf.ini | 2 ++ doc/guides/nics/features/i40e_vf_vec.ini | 2 ++ drivers/net/i40e/i40e_ethdev.c | 2 ++ drivers/net/i40

[dpdk-dev] [PATCH v2 4/6] net/e1000: implement descriptor status API (em)

2017-03-07 Thread Olivier Matz
Signed-off-by: Olivier Matz --- doc/guides/nics/features/e1000.ini | 2 ++ drivers/net/e1000/e1000_ethdev.h | 3 +++ drivers/net/e1000/em_ethdev.c | 2 ++ drivers/net/e1000/em_rxtx.c| 51 ++ 4 files changed, 58 insertions(+) diff --git a/doc/

[dpdk-dev] [PATCH v2 5/6] net/mlx5: implement descriptor status API

2017-03-07 Thread Olivier Matz
Since there is no "descriptor done" flag like on Intel drivers, the approach is different on mlx5 driver. - for Tx, we call txq_complete() to free descriptors processed by the hw, then we check if the descriptor is between tail and head - for Rx, we need to browse the cqes, managing compressed on

[dpdk-dev] [PATCH v2 2/6] net/ixgbe: implement descriptor status API

2017-03-07 Thread Olivier Matz
Signed-off-by: Olivier Matz --- doc/guides/nics/features/ixgbe.ini| 2 ++ doc/guides/nics/features/ixgbe_vec.ini| 2 ++ doc/guides/nics/features/ixgbe_vf.ini | 2 ++ doc/guides/nics/features/ixgbe_vf_vec.ini | 2 ++ drivers/net/ixgbe/ixgbe_ethdev.c | 4 +++ drivers/n

[dpdk-dev] [PATCH v2 3/6] net/e1000: implement descriptor status API (igb)

2017-03-07 Thread Olivier Matz
Signed-off-by: Olivier Matz --- doc/guides/nics/features/igb.ini| 2 ++ doc/guides/nics/features/igb_vf.ini | 2 ++ drivers/net/e1000/e1000_ethdev.h| 3 +++ drivers/net/e1000/igb_ethdev.c | 2 ++ drivers/net/e1000/igb_rxtx.c| 45 + 5 fi

[dpdk-dev] [PATCH v2 0/6] get status of Rx and Tx descriptors

2017-03-07 Thread Olivier Matz
This patchset introduces a new ethdev API: - rte_eth_rx_descriptor_status() - rte_eth_tx_descriptor_status() The Rx API is aims to replace rte_eth_rx_descriptor_done() which does almost the same, but does not differentiate the case of a descriptor used by the driver (not returned to the hw). The

[dpdk-dev] [PATCH v2 1/6] ethdev: add descriptor status API

2017-03-07 Thread Olivier Matz
Introduce a new API to get the status of a descriptor. For Rx, it is almost similar to rx_descriptor_done API, except it differentiates "used" descriptors (which are hold by the driver and not returned to the hardware). For Tx, it is a new API. The descriptor_done() API, and probably the rx_queu

Re: [dpdk-dev] [PATCH v2 0/4] net/tap: support flow API

2017-03-07 Thread Wiles, Keith
> On Mar 7, 2017, at 9:05 AM, Pascal Mazon wrote: > > Hi Keith, > > I'm working on a v3 for that series: > > - I added info regarding flow API support in tap.rst doc > - I fixed support for kernels where flower/vlan was not supported. > > Do you have any other remarks, or can I send the v3 (h

Re: [dpdk-dev] [PATCH v2 0/4] net/tap: support flow API

2017-03-07 Thread Pascal Mazon
Hi Keith, I'm working on a v3 for that series: - I added info regarding flow API support in tap.rst doc - I fixed support for kernels where flower/vlan was not supported. Do you have any other remarks, or can I send the v3 (hopefully ok for integration)? I'll send a v2 for the latest series (in

Re: [dpdk-dev] [PATCH 00/11] Support flow API in Solarflare PMD

2017-03-07 Thread Andrew Rybchenko
On 03/07/2017 04:27 PM, Ferruh Yigit wrote: On 3/2/2017 4:03 PM, Andrew Rybchenko wrote: Support simple queue destination flow API filters in Solarflare libefx-based PMD including: - Ethernet source/destination, EtherType exact matching - VLAN ID exact matching including double-tagging - I

Re: [dpdk-dev] [PATCH 02/11] net/sfc/base: improve API to get supported filter matches

2017-03-07 Thread Ferruh Yigit
On 3/7/2017 2:47 PM, Andrew Rybchenko wrote: > On 03/07/2017 04:25 PM, Ferruh Yigit wrote: >> On 3/2/2017 4:03 PM, Andrew Rybchenko wrote: >>> From: Mark Spender >>> >>> The previous API had various problems, including the length of the >>> caller provided buffer not being specified, no means bein

Re: [dpdk-dev] [PATCH 02/11] net/sfc/base: improve API to get supported filter matches

2017-03-07 Thread Andrew Rybchenko
On 03/07/2017 04:25 PM, Ferruh Yigit wrote: On 3/2/2017 4:03 PM, Andrew Rybchenko wrote: From: Mark Spender The previous API had various problems, including the length of the caller provided buffer not being specified, no means being available to discover how big the buffer needs to be, and a

Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed buffers in Tx ring

2017-03-07 Thread Billy McFall
Thomas, Thanks for your comments. See inline. On Mon, Feb 27, 2017 at 8:48 AM, Thomas Monjalon wrote: > 2017-01-27 13:37, Billy McFall: > > --- a/doc/guides/nics/features/default.ini > > +++ b/doc/guides/nics/features/default.ini > > @@ -55,6 +55,7 @@ FW version = > > EEPROM dump

[dpdk-dev] [PATCH] net/ixgbe: Put correct id values in ixgbevf_dev_xstats_get

2017-03-07 Thread Ido Barnea (ibarnea)
Without setting the id, calling xstats_get twice with same array causes memory corruption. Also, if IXGBEVF_NB_XSTATS will be different than 1 in the future, this will cause issues. Signed-off-by: Ido Barnea --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [dpdk-dev] [PATCH 6/6] doc: introduction to prgdev

2017-03-07 Thread Chen, Jing D
> > > > > > > +Another reason to provide bind/unbind action is programmble > > > > +devices, like FPGA, are not identified driver by 'vendor ID' and > > > > +'device ID', they might not be changed in all the ways, even FPGA > > > > +is fully programmed. So, it depends on internal mechanism of > > >

Re: [dpdk-dev] [PATCH 00/11] Support flow API in Solarflare PMD

2017-03-07 Thread Ferruh Yigit
On 3/2/2017 4:03 PM, Andrew Rybchenko wrote: > Support simple queue destination flow API filters in Solarflare > libefx-based PMD including: > - Ethernet source/destination, EtherType exact matching > - VLAN ID exact matching including double-tagging > - IPv4/6 source/destination and IP protocol

Re: [dpdk-dev] [PATCH 02/11] net/sfc/base: improve API to get supported filter matches

2017-03-07 Thread Ferruh Yigit
On 3/2/2017 4:03 PM, Andrew Rybchenko wrote: > From: Mark Spender > > The previous API had various problems, including the length of the > caller provided buffer not being specified, no means being available > to discover how big the buffer needs to be, and a lack of clarity of > what the resulti

Re: [dpdk-dev] [PATCH 07/11] net/sfc: add IPV4 in flow API filters support

2017-03-07 Thread Ferruh Yigit
On 3/2/2017 4:03 PM, Andrew Rybchenko wrote: > From: Roman Zhukov > > Exact match of IP protocol, source and destination > addresses is supported by parser. > EtherType match is enforced to IPv4 EtherType. > > Signed-off-by: Roman Zhukov > Signed-off-by: Andrew Rybchenko > Reviewed-by: Andrew

Re: [dpdk-dev] [PATCH 05/11] net/sfc: add flow API filters support

2017-03-07 Thread Ferruh Yigit
On 3/2/2017 4:03 PM, Andrew Rybchenko wrote: > From: Roman Zhukov > > Only pattern items VOID, ETH and actions VOID, QUEUE is now > supported. > > Signed-off-by: Roman Zhukov > Signed-off-by: Andrew Rybchenko <...> > diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c > new

[dpdk-dev] Minutes of techboard meeting 2017-03-02

2017-03-07 Thread Olivier MATZ
Hi, A meeting of the DPDK technical board was held last Wednesday, 2017-03-02. Below are the meeting minutes. Please note that meetings are open to all to attend. The next meeting is planned for March 20th, and any topics to be referred to the tech board for discussion at that meeting should be e

Re: [dpdk-dev] [PATCH v3] eal: sPAPR IOMMU support in pci probing for vfio-pci in ppc64le

2017-03-07 Thread Thomas Monjalon
Chao, there is an issue with your mailer: it is not quoting original email. Please check html is disabled and remove useless context when replying. 2017-03-07 20:03, Chao Zhu: > From: Gowrishankar Muthukrishnan > > Below changes adds pci probing support for vfio-pci devices in power8. > > v3 -

Re: [dpdk-dev] [PATCH 6/6] doc: introduction to prgdev

2017-03-07 Thread Thomas Monjalon
2017-03-07 11:12, Bruce Richardson: > On Tue, Mar 07, 2017 at 10:34:06AM +, Chen, Jing D wrote: > > From: Thomas Monjalon > > > > +Any devices, having the capability to store/load a piece of info > > > > +to/from the deivce then changed hardware behavior, and applicable to > > > > +prgdev progr

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add capability control API

2017-03-07 Thread Thomas Monjalon
2017-03-07 10:14, Dumitrescu, Cristian: > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > On Mon, 6 Mar 2017 20:41:27 + > > "Wiles, Keith" wrote: > > > > > Being able to add features without having to change DPDK maybe a strong > > feature for companies that have special needs

[dpdk-dev] [PATCH] doc: fix parameter of virtio_user for container

2017-03-07 Thread Yong Wang
Update the "Virtio_user for Container Networking" doc, add the "--file-prefix" option to testpmd in host and container to avoid hugepage config file conflict. Fixes: 50665deebda0 ("doc: add guide to use virtio-user for container networking") Signed-off-by: Yong Wang --- doc/guides/howto/virtio_

Re: [dpdk-dev] [PATCH] doc: announce TSO support on mlx5 driver

2017-03-07 Thread Ferruh Yigit
On 3/6/2017 11:55 AM, Shahaf Shuler wrote: > Signed-off-by: Shahaf Shuler Applied to dpdk-next-net/master, thanks.

[dpdk-dev] Issue with rte_eth_dev_set_vlan_offload

2017-03-07 Thread Hemant Agrawal
Hi, Currently the "rte_eth_dev_set_vlan_offload" support setting of three different capabilities on the port i.e. strip, filter and extend The current implementation only returns error when this API is not implemented by the PMD. 1. First issue is that the documentation say

Re: [dpdk-dev] [PATCH v3 0/7] vmxnet3: upgrade to version 3

2017-03-07 Thread Ferruh Yigit
On 3/6/2017 10:55 PM, Shrikrishna Khare wrote: > vmxnet3 emulation has recently added several new features which includes > support for new commands the driver can issue to emulation, change in > descriptor fields etc. This patch series extends the vmxnet3 driver to > leverage these new features. >

Re: [dpdk-dev] [PATCH 0/7] vmxnet3: upgrade to version 3

2017-03-07 Thread Ferruh Yigit
On 3/6/2017 5:25 PM, Shrikrishna Khare wrote: > > > On Fri, 3 Mar 2017, Ferruh Yigit wrote: > >>> Shrikrishna Khare (7): >>> vmxnet3: prepare for version 3 changes >>> vmxnet3: introduce generalized command interface to configure the >>> device >>> vmxnet3: allow variable length transm

Re: [dpdk-dev] [PATCH v3] eal: sPAPR IOMMU support in pci probing for vfio-pci in ppc64le

2017-03-07 Thread Chao Zhu
-Original Message- From: Gowrishankar [mailto:gowrishanka...@linux.vnet.ibm.com] Sent: 2017年3月6日 23:04 To: dev@dpdk.org Cc: Chao Zhu ; Anatoly Burakov ; Thomas Monjalon ; Gowrishankar Muthukrishnan Subject: [PATCH v3] eal: sPAPR IOMMU support in pci probing for vfio-pci in ppc64le From:

[dpdk-dev] [PATCH] net/mlx5: fix TSO TCP checksum flag

2017-03-07 Thread Shahaf Shuler
Since PKT_TX_TCP_SEG implies PKT_TX_TCP_CKSUM, the PMD must force this flag. The fix applied for both tunneled and non-tunneled packets. Fixes: 19c5dc66b851 ("net/mlx5: add hardware TSO support") Fixes: 751f56489e31 ("net/mlx5: add hardware TSO support for VXLAN and GRE") Cc: sta...@dpdk.org Sign

[dpdk-dev] [PATCH v2 13/14] ring: create common function for updating tail idx

2017-03-07 Thread Bruce Richardson
Both producer and consumer use the same logic for updating the tail index so merge into a single function. Signed-off-by: Bruce Richardson --- lib/librte_ring/rte_ring.h | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/lib/librte_ring/rte_rin

[dpdk-dev] [PATCH v2 14/14] ring: make ring struct and enq/deq macros type agnostic

2017-03-07 Thread Bruce Richardson
Modify the enqueue and dequeue macros to support copying any type of object by passing in the exact object type. Rather than using the "ring" structure member of rte_ring, which is of type "array of void *", instead have the macros take the start of the ring a a pointer value, thereby leaving the r

[dpdk-dev] [PATCH v2 12/14] ring: separate out head index manipulation for enq/deq

2017-03-07 Thread Bruce Richardson
We can write a single common function for head manipulation for enq and a common one for deq, allowing us to have a single worker function for enq and deq, rather than two of each. Update all other inline functions to use the new functions. Signed-off-by: Bruce Richardson --- lib/librte_ring/rte

[dpdk-dev] [PATCH v2 09/14] ring: allow dequeue fns to return remaining entry count

2017-03-07 Thread Bruce Richardson
Add an extra parameter to the ring dequeue burst/bulk functions so that those functions can optionally return the amount of remaining objs in the ring. This information can be used by applications in a number of ways, for instance, with single-consumer queues, it provides a max dequeue size which i

[dpdk-dev] [PATCH v2 11/14] ring: reduce scope of local variables

2017-03-07 Thread Bruce Richardson
The local variable i is only used for loop control so define it in the enqueue and dequeue blocks directly, rather than at the function level. Signed-off-by: Bruce Richardson --- lib/librte_ring/rte_ring.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/librte_ring/

  1   2   >