[dpdk-dev] [PATCH v3 3/4] net: add arm64 neon version of CRC compute APIs

2017-05-03 Thread Ashwin Sekhar T K
Added CRC compute APIs for arm64 utilizing the pmull capability Added new file net_crc_neon.h to hold the arm64 pmull CRC implementation Verified the changes with crc_autotest unit test case Signed-off-by: Ashwin Sekhar T K --- v2: * Fixed merge conflict in MAINTAINERS v3: * Moved feature dete

[dpdk-dev] [PATCH v3 4/4] test: add tests for arm64 CRC neon versions

2017-05-03 Thread Ashwin Sekhar T K
Verified the changes with crc_autotest unit test case Signed-off-by: Ashwin Sekhar T K --- v2: * Fixed checkpatch errors/warnings test/test/test_crc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/test/test/test_crc.c b/test/test/test_crc.c index cd5af69..9f2a17d 100644 --- a/tes

[dpdk-dev] [PATCH v3 1/4] mk: add crypto capability for generic armv8a and thunderx

2017-05-03 Thread Ashwin Sekhar T K
armv8-a has optional CRYPTO extension which adds the AES, PMULL, SHA1 and SHA2 capabilities. -march=armv8-a+crypto enables code generation for the ARMv8-A architecture together with the optional CRYPTO extensions. added the following flags to detect the corresponding capability at compile time *

[dpdk-dev] [PATCH v3 2/4] eal: move gcc version definition to common header

2017-05-03 Thread Ashwin Sekhar T K
moved the definition of GCC_VERSION from lib/librte_table/rte_lru.h to lib/librte_eal/common/include/rte_common.h Tested compilation on arm64 with gcc Tested compilation on x86 with gcc and clang Signed-off-by: Ashwin Sekhar T K --- v3: * Moved changes for GCC_VERSION into a separate commit * M

Re: [dpdk-dev] [RFC] service core concept header implementation

2017-05-03 Thread Jerin Jacob
-Original Message- > Date: Wed, 3 May 2017 12:29:21 +0100 > From: Harry van Haaren > To: dev@dpdk.org > CC: Harry van Haaren , > bruce.richard...@intel.com, hemant.agra...@nxp.com, nipun.gu...@nxp.com, > narender.vang...@intel.com, jerin.ja...@caviumnetworks.com, > gage.e...@intel.com >

Re: [dpdk-dev] [PATCH] [RFC] cryptodev: crypto operation restructuring

2017-05-03 Thread Akhil Goyal
Hi Sergio, On 5/3/2017 7:48 PM, Sergio Gonzalez Monroy wrote: On 03/05/2017 12:01, Akhil Goyal wrote: Hi Pablo, On 4/28/2017 11:33 PM, Pablo de Lara wrote: This is a proposal to correct and improve the current crypto operation (rte_crypto_op) and symmetric crypto operation (rte_crypto_sym_op)

Re: [dpdk-dev] [PATCH] kni: fix unit test segfault

2017-05-03 Thread gowrishankar muthukrishnan
Hi Ferruh, Even w/o this patch, I mostly find mbufs returned by rte_kni_rx_burst() always 0 (or sometimes 1) where as more than 32000 mbufs approx created in ingress side for this test. dpdk/test/test $ ./test -l 0,1,2 --socket-mem 1024 Am I missing something required for this unit test ?.

Re: [dpdk-dev] [dpdk-stable] [PATCH 11/11] net/qede: fix to limit CFLAGS to base files

2017-05-03 Thread Yuanhan Liu
On Thu, May 04, 2017 at 12:14:30AM +, Mody, Rasesh wrote: > > > > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > > Sent: Monday, May 01, 2017 11:15 PM > > > > On Tue, Apr 25, 2017 at 12:28:46AM -0700, Rasesh Mody wrote: > > > From: Rasesh Mody > > > > > > Changes included in this

Re: [dpdk-dev] [dpdk-stable] [PATCH 11/11] net/qede: fix to limit CFLAGS to base files

2017-05-03 Thread Mody, Rasesh
> From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: Monday, May 01, 2017 11:15 PM > > On Tue, Apr 25, 2017 at 12:28:46AM -0700, Rasesh Mody wrote: > > From: Rasesh Mody > > > > Changes included in this fix > > - limit CFLAGS to base files > > - fix to remove/mark unused members >

Re: [dpdk-dev] [PATCH] kni: fix ethtool build with kernel 4.11

2017-05-03 Thread Nicolas Dichtel
Le 03/05/2017 à 18:43, Ferruh Yigit a écrit : > On 5/3/2017 5:39 PM, Nicolas Dichtel wrote: >> Le 03/05/2017 à 18:00, Ferruh Yigit a écrit : >>> build error: >>> .../build/build/lib/librte_eal/linuxapp/kni/igb_main.c:1034:10: >>> error: implicit declaration of function ‘pci_enable_msix’ >>> [-Werro

Re: [dpdk-dev] [PATCH 1/2] net: add arm64 neon version of CRC compute APIs

2017-05-03 Thread Jan Viktorin
On Fri, 28 Apr 2017 10:19:20 + "Sekhar, Ashwin" wrote: > Hi Jan, > Thanks for the comments. Please see my responses inline. > > On Friday 28 April 2017 03:25 PM, Jan Viktorin wrote: > > Hello Ashwin Sekhar, > > > > some comments below... > > [...] > >> > >> #include > >> +#include > >>

Re: [dpdk-dev] [PATCH] kni: fix ethtool build with kernel 4.11

2017-05-03 Thread Ferruh Yigit
On 5/3/2017 5:39 PM, Nicolas Dichtel wrote: > Le 03/05/2017 à 18:00, Ferruh Yigit a écrit : >> build error: >> .../build/build/lib/librte_eal/linuxapp/kni/igb_main.c:1034:10: >> error: implicit declaration of function ‘pci_enable_msix’ >> [-Werror=implicit-function-declaration] >> err = pci_ena

Re: [dpdk-dev] [PATCH] kni: fix ethtool build with kernel 4.11

2017-05-03 Thread Nicolas Dichtel
Le 03/05/2017 à 18:00, Ferruh Yigit a écrit : > build error: > .../build/build/lib/librte_eal/linuxapp/kni/igb_main.c:1034:10: > error: implicit declaration of function ‘pci_enable_msix’ > [-Werror=implicit-function-declaration] > err = pci_enable_msix(pdev, > ^~~ > >

[dpdk-dev] [PATCH] kni: fix unit test segfault

2017-05-03 Thread Ferruh Yigit
To clean alloc_q, which has physicall addresses of the mbufs, kni lib free the pkt_mempool, but this leads a crash in kni unit test. KNI library shouldn't free the pkt_mempool. Implementation updated to find the mbufs in the alloc_q and return them back to mempool. Fixes: 8eba5ebd1811 ("kni: fix

[dpdk-dev] [PATCH] kni: fix ethtool build with kernel 4.11

2017-05-03 Thread Ferruh Yigit
build error: .../build/build/lib/librte_eal/linuxapp/kni/igb_main.c:1034:10: error: implicit declaration of function ‘pci_enable_msix’ [-Werror=implicit-function-declaration] err = pci_enable_msix(pdev, ^~~ This build error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL co

Re: [dpdk-dev] [PATCH] doc: notice for changes in kni structures

2017-05-03 Thread Stephen Hemminger
On Wed, 3 May 2017 17:01:31 +0530 Hemant Agrawal wrote: > Signed-off-by: Hemant Agrawal > --- > doc/guides/rel_notes/deprecation.rst | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index a3e7c72..0

Re: [dpdk-dev] [PATCH] [RFC] cryptodev: crypto operation restructuring

2017-05-03 Thread Sergio Gonzalez Monroy
On 03/05/2017 12:01, Akhil Goyal wrote: Hi Pablo, On 4/28/2017 11:33 PM, Pablo de Lara wrote: This is a proposal to correct and improve the current crypto operation (rte_crypto_op) and symmetric crypto operation (rte_crypto_sym_op) structures, shrinking their sizes to fit both structures into

Re: [dpdk-dev] [RFC PATCH 4/5] kni: add support to get gso_size info

2017-05-03 Thread Alejandro Lucero
I guess this is just need this for tso offload. isn't it? Just asking because I have done some work adding gather and tso offload to kni and I was wondering if this is duplicated job from my part. If you are wondering what KNI offload means, since it is not talking to any hw, the offload is regar

[dpdk-dev] [PATCH v2] app/testpmd: support non contiguous socket ids

2017-05-03 Thread Shahaf Shuler
The test assumes the socket ids are contiguous. This is not necessarily the case on all servers and may cause mempool creation to fail. Fixing it by detecting the list of valid socket ids and use it for the mempool creation. Fixes: 7acf894d07d1 ("app/testpmd: detect numa socket count") CC: sta..

Re: [dpdk-dev] [PATCH v1] doc: fix usertools path in pvp benchmark doc

2017-05-03 Thread Maxime Coquelin
On 05/02/2017 02:51 PM, John McNamara wrote: Update doc to the new dpdk-devbind.py usertools path. Fixes: 58a2551a160f ("doc: introduce PVP reference benchmark") Signed-off-by: John McNamara --- doc/guides/howto/pvp_reference_benchmark.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[dpdk-dev] [PATCH] app/testpmd: support non contiguous socket ids

2017-05-03 Thread Shahaf Shuler
The test assumes the socket ids are contiguous. This is not necessarily the case on all servers and may cause mempool creation to fail. Fixing it be detecting the list of valid socket ids and use it for the mempool creation. Fixes: 7acf894d07d1 ("app/testpmd: detect numa socket count") CC: sta..

[dpdk-dev] [PATCH] doc: notice for changes in kni structures

2017-05-03 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- doc/guides/rel_notes/deprecation.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index a3e7c72..0c1ef2c 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/

[dpdk-dev] [RFC] service core concept header implementation

2017-05-03 Thread Harry van Haaren
This patch adds a service header to DPDK EAL. This header is an RFC for a mechanism to allow DPDK components request a callback function to be invoked. The application can set the number of service cores, and a coremask for each particular services. The implementation of this functionality in rte_

[dpdk-dev] [RFC] Service Cores concept

2017-05-03 Thread Harry van Haaren
This RFC introduces the concept of a service-core. A service core invokes a function when an lcore is required to perform some work. An example use-case is the eventdev; with the octeontx PMD, events are scheduled in the hardware. With the software eventdev PMD an lcore is required to perform this

[dpdk-dev] [RFC PATCH 5/5] kni: support multiple userspace process working with kni module

2017-05-03 Thread Hemant Agrawal
in case of multiple application using the same KNI module, protect that one application will only clean it's own devices. Signed-off-by: Hemant Agrawal --- lib/librte_eal/linuxapp/kni/kni_dev.h | 1 + lib/librte_eal/linuxapp/kni/kni_misc.c | 21 +++-- 2 files changed, 16 insert

[dpdk-dev] [RFC PATCH 3/5] kni: init and change request for mtu

2017-05-03 Thread Hemant Agrawal
1. Configure initial mtu. 2. Message to userspace for mtu change Signed-off-by: Hemant Agrawal --- lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h | 1 + lib/librte_eal/linuxapp/kni/kni_misc.c| 2 ++ lib/librte_kni/rte_kni.c

[dpdk-dev] [RFC PATCH 4/5] kni: add support to get gso_size info

2017-05-03 Thread Hemant Agrawal
Inform userspace about gso size info Signed-off-by: Hemant Agrawal --- lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h | 3 ++- lib/librte_eal/linuxapp/kni/kni_net.c | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp

[dpdk-dev] [RFC PATCH 2/5] kni: add support for promisc mode set

2017-05-03 Thread Hemant Agrawal
message to userspace on promisc mode change Signed-off-by: Hemant Agrawal --- .../linuxapp/eal/include/exec-env/rte_kni_common.h | 2 ++ lib/librte_eal/linuxapp/kni/kni_net.c| 20 lib/librte_kni/rte_kni.c | 5 + lib/librte_

[dpdk-dev] [RFC PATCH 1/5] kni: change and configure mac address

2017-05-03 Thread Hemant Agrawal
This patch adds following: 1. option to configure the mac address during create 2. inform usespace, if mac address is being changed in linux Signed-off-by: Hemant Agrawal --- .../linuxapp/eal/include/exec-env/rte_kni_common.h| 3 +++ lib/librte_eal/linuxapp/kni/kni_misc.c

Re: [dpdk-dev] [PATCH] [RFC] cryptodev: crypto operation restructuring

2017-05-03 Thread Akhil Goyal
Hi Pablo, On 4/28/2017 11:33 PM, Pablo de Lara wrote: This is a proposal to correct and improve the current crypto operation (rte_crypto_op) and symmetric crypto operation (rte_crypto_sym_op) structures, shrinking their sizes to fit both structures into two 64-byte cache lines as one of the go

Re: [dpdk-dev] [RFC 17.08] Flow classification library

2017-05-03 Thread Mcnamara, John
> -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Friday, April 21, 2017 11:38 AM > To: Yigit, Ferruh > Cc: dev@dpdk.org; Mcnamara, John ; Tahhan, Maryam > > Subject: Re: [dpdk-dev] [RFC 17.08] Flow classification library > Any other opinions on this p

Re: [dpdk-dev] [PATCH] app/testpmd: fix compilation when bitrate lib is disabled

2017-05-03 Thread Remy Horton
On 03/05/2017 08:02, Pablo de Lara wrote: Fixes: e25e6c70fb56 ("app/testpmd: add --bitrate-stats option") Signed-off-by: Pablo de Lara --- app/test-pmd/testpmd.c | 2 ++ 1 file changed, 2 insertions(+) Acked-by: Remy Horton

Re: [dpdk-dev] [PATCH] net/mlx5: fix Tx max inline with TSO

2017-05-03 Thread Adrien Mazarguil
On Wed, May 03, 2017 at 09:55:35AM +0300, Shahaf Shuler wrote: > When TSO is enabled, Verbs layer aggregates the TSO > inline size with the txq inline size for the Tx creation, > while the PMD takes the maximum among them. > > Fixing it by adjusting the max inline parameter before > passing to to

[dpdk-dev] [PATCH 1/2] doc: update mlx5 supported OFED and FW

2017-05-03 Thread Shahaf Shuler
Update the supported Mellanox OFED and FW versions. Signed-off-by: Shahaf Shuler --- doc/guides/nics/mlx5.rst | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 0783aebdd..da6dc278e 100644 --- a/doc/guides/nics

[dpdk-dev] [PATCH 2/2] doc: update mlx4 supported OFED and FW

2017-05-03 Thread Shahaf Shuler
Update the supported Mellanox OFED and FW versions. Signed-off-by: Shahaf Shuler --- doc/guides/nics/mlx4.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/mlx4.rst b/doc/guides/nics/mlx4.rst index 3ab1def9a..f1f26d4f9 100644 --- a/doc/guides/nics/mlx4.r

Re: [dpdk-dev] [PATCH v2] net/e1000: fix VF MAC address set problem

2017-05-03 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Yang, Qiming > Sent: Wednesday, May 3, 2017 1:53 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Lu, Wenzhuo; Yang, Qiming > Subject: [PATCH v2] net/e1000: fix VF MAC address set problem > > We find that VF receive address register is not set if MAC address i

Re: [dpdk-dev] [PATCH v2] net/e1000: fix VF received problem

2017-05-03 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Yang, Qiming > Sent: Wednesday, May 3, 2017 1:52 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Lu, Wenzhuo; Yang, Qiming > Subject: [PATCH v2] net/e1000: fix VF received problem > > VF default MAC address be added in PF Mac address list instead of VF MAC >

[dpdk-dev] [PATCH] app/testpmd: fix compilation when bitrate lib is disabled

2017-05-03 Thread Pablo de Lara
Fixes: e25e6c70fb56 ("app/testpmd: add --bitrate-stats option") Signed-off-by: Pablo de Lara --- app/test-pmd/testpmd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index dfe6442..776b8dd 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-

Re: [dpdk-dev] [PATCH] net/mlx5: fix Tx max inline with TSO

2017-05-03 Thread Nélio Laranjeiro
On Wed, May 03, 2017 at 09:55:35AM +0300, Shahaf Shuler wrote: > When TSO is enabled, Verbs layer aggregates the TSO > inline size with the txq inline size for the Tx creation, > while the PMD takes the maximum among them. > > Fixing it by adjusting the max inline parameter before > passing to to