Re: [dpdk-dev] New Coverity defects in VFIO

2017-05-11 Thread Alejandro Lucero
On Thu, May 11, 2017 at 5:38 PM, Stephen Hemminger < step...@networkplumber.org> wrote: > Looks like obvious C array bounds issues... > > Right. I will send a patch today. Thanks > Begin forwarded message: > > Date: Thu, 11 May 2017 06:32:38 -0700 > From: scan-ad...@coverity.com > To: step...@

Re: [dpdk-dev] [PATCH v3 6/6] config: add clang support for armv8a linuxapp

2017-05-11 Thread Jianbo Liu
On 12 May 2017 at 13:45, Ashwin Sekhar T K wrote: > Moved all common defines from defconfig_arm64-armv8a-linuxapp-gcc > to common_armv8a_linuxapp. > > Created new config arm64-armv8a-linuxapp-clang which adds the > clang support to armv8a. > > Now defconfigs arm64-armv8a-linuxapp-gcc/clang contain

[dpdk-dev] [PATCH] memzone: Check socket_id value when creating memzone.

2017-05-11 Thread Tonghao Zhang
If the socket_id is invalid (e.g. -2, -3), the memzone_reserve_aligned_thread_unsafe should return the EINVAL and not ENOMEM. To avoid it, we should check the socket_id before calling malloc_heap_alloc. Signed-off-by: Tonghao Zhang --- lib/librte_eal/common/eal_common_memzone.c | 3 ++- 1 file c

Re: [dpdk-dev] [PATCH v4 3/4] net: add arm64 neon version of CRC compute APIs

2017-05-11 Thread Jianbo Liu
On 9 May 2017 at 17:53, Ashwin Sekhar T K wrote: > Added CRC compute APIs for arm64 utilizing the pmull > capability > > Added new file net_crc_neon.h to hold the arm64 pmull > CRC implementation > > Verified the changes with crc_autotest unit test case > > Signed-off-by: Ashwin Sekhar T K > ---

[dpdk-dev] [PATCH v3 3/6] net/thunderx: fix compile errors for armv8a clang

2017-05-11 Thread Ashwin Sekhar T K
Replaced usage of %a0 in inline assembly with [%x0] Signed-off-by: Ashwin Sekhar T K Reviewed-by: Jerin Jacob --- drivers/net/thunderx/base/nicvf_plat.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/thunderx/base/nicvf_plat.h b/drivers/net/thunderx/base/nicvf_

[dpdk-dev] [PATCH v3 6/6] config: add clang support for armv8a linuxapp

2017-05-11 Thread Ashwin Sekhar T K
Moved all common defines from defconfig_arm64-armv8a-linuxapp-gcc to common_armv8a_linuxapp. Created new config arm64-armv8a-linuxapp-clang which adds the clang support to armv8a. Now defconfigs arm64-armv8a-linuxapp-gcc/clang contain only the CONFIG_RTE_TOOLCHAIN* defines and all other common de

[dpdk-dev] [PATCH v3 1/6] eal: pause while busy-waiting for slave

2017-05-11 Thread Ashwin Sekhar T K
Instead of simply busy-waiting for slave in rte_eal_wait_lcore() do rte_pause(). This will give power savings. This also fixes warning -Wempty-body seen with armv8a clang compilation. Signed-off-by: Ashwin Sekhar T K Suggested-by: Jerin Jacob --- lib/librte_eal/common/eal_common_launch.c | 3 +

[dpdk-dev] [PATCH v3 2/6] hash: compile armv8a CRC32 support conditionally

2017-05-11 Thread Ashwin Sekhar T K
Compile the armv8a CRC32 support only if the machine has the CRC extensions i.e if RTE_MACHINE_CPUFLAG_CRC32 is defined. Removed the .arch assembly directives as these are no more necessary. Signed-off-by: Ashwin Sekhar T K Reviewed-by: Jerin Jacob --- lib/librte_hash/Makefile| 2 ++ l

[dpdk-dev] [PATCH v3 4/6] acl: fix warning seen with armv8a clang

2017-05-11 Thread Ashwin Sekhar T K
Fixed warning -Wunknown-warning-option seen with armv8a clang compilation. Signed-off-by: Ashwin Sekhar T K Reviewed-by: Jerin Jacob --- lib/librte_acl/Makefile | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/librte_acl/Makefile b/lib/librte_acl/Makefile index e2dacd

[dpdk-dev] [PATCH v3 5/6] eal/arm: fix warnings seen with armv8a clang

2017-05-11 Thread Ashwin Sekhar T K
Fixed warning -Wasm-operand-widths seen with armv8a clang compilation. Signed-off-by: Ashwin Sekhar T K Reviewed-by: Jerin Jacob --- lib/librte_eal/common/include/arch/arm/rte_byteorder.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/arch/arm/

[dpdk-dev] [PATCH v3 0/6] Add clang compilation support for armv8a linuxapp

2017-05-11 Thread Ashwin Sekhar T K
This series of patches adds the clang compilation support for armv8a linuxapp. Patch 1 adds an rte_pause() to a tight while loop in rte_eal_wait_lcore(). It fixes warning -Wempty-body seen with armv8a clang compilation. Patch 2 is basically for removing the usage of assembly directive ".arch arm

Re: [dpdk-dev] [PATCH v2 2/6] config: add clang support for armv8a linuxapp

2017-05-11 Thread Jerin Jacob
-Original Message- > Date: Thu, 11 May 2017 07:33:12 -0700 > From: Ashwin Sekhar T K > To: jerin.ja...@caviumnetworks.com, tho...@monjalon.net, > maciej.cze...@caviumnetworks.com, vikto...@rehivetech.com, > jianbo@linaro.org, bruce.richard...@intel.com, > pablo.de.lara.gua...@intel.

[dpdk-dev] librte_acl : add , delete rules at runtime

2017-05-11 Thread Srinivasreddy R
Hi all, I want to add , delete acl rules at run time . I have multiple threads accessing the same acl context. can some one suggest is it possible . thanks srinivas

Re: [dpdk-dev] [PATCH v3 5/7] examples/l3fwd: add neon support for l3fwd

2017-05-11 Thread Jianbo Liu
On 11 May 2017 at 18:27, Sekhar, Ashwin wrote: > On Thu, 2017-05-11 at 18:01 +0800, Jianbo Liu wrote: >> On 11 May 2017 at 17:49, Sekhar, Ashwin >> wrote: >> > >> > Hi Jianbo, >> > >> > Thanks for v3. Small compilation error. See inline comment. >> > Otherwise >> > it looks fine. >> > >> > On Thu

[dpdk-dev] "Port 0 is not present on the board" when building DPDK libraries as shared

2017-05-11 Thread Mastorakis, Spyridon
Hi guys, When I compile the DPDK libraries as shared (by modifying the base_config file) and try to run an application (e.g., l3fwd), I get an error that port 0 is not present on board. I have cleaned the system several times (unbinded NICs, removed igb_uio and uio modules and hugepage mapping

Re: [dpdk-dev] [PATCH v1] doc: change doc line length limit in contributors guide

2017-05-11 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, May 11, 2017 6:18 PM > To: Mcnamara, John > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] doc: change doc line length limit in > contributors guide > > 11/05/2017 18:11,

Re: [dpdk-dev] [PATCH v1] doc: change doc line length limit in contributors guide

2017-05-11 Thread Thomas Monjalon
11/05/2017 18:11, Mcnamara, John: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > ... > > > -* The recommended style for the DPDK documentation is to put sentences > > on separate lines. > > > - This allows for easier reviewing of patches. > > > - Multiple sentences which are not se

Re: [dpdk-dev] [PATCH 05/28] bnxt: add support for PF/VF communications

2017-05-11 Thread Ajit Khaparde
On Thu, May 11, 2017 at 12:00 PM, Ferruh Yigit wrote: > On 3/28/2017 4:48 AM, Ajit Khaparde wrote: > > Set up interrupts and default completion ring during device init to > > allow VF communications. > > > > Request most VF HWRM commands be forwarded to the PF driver. In the > > future, this sho

Re: [dpdk-dev] [PATCH 05/28] bnxt: add support for PF/VF communications

2017-05-11 Thread Ferruh Yigit
On 3/28/2017 4:48 AM, Ajit Khaparde wrote: > Set up interrupts and default completion ring during device init to > allow VF communications. > > Request most VF HWRM commands be forwarded to the PF driver. In the > future, this should be configurable. > > Fix reporting of active VFs. > > Add a l

Re: [dpdk-dev] New Coverity defects in VFIO

2017-05-11 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Thursday, May 11, 2017 5:39 PM > To: Alejandro Lucero ; dev@dpdk.org > Subject: [dpdk-dev] New Coverity defects in VFIO > > Looks like obvious C array bounds issues... > Hi Stephen,

Re: [dpdk-dev] [RFC] eventdev: add event adapter for ethernet Rx queues

2017-05-11 Thread Jerin Jacob
-Original Message- > Date: Tue, 9 May 2017 15:38:46 -0500 > From: Gage Eads > To: dev@dpdk.org > CC: nikhil@intel.com, jerin.ja...@caviumnetworks.com, > tho...@monjalon.net, bruce.richard...@intel.com, > harry.van.haa...@intel.com, hemant.agra...@nxp.com, nipun.gu...@nxp.com, > nare

[dpdk-dev] New Coverity defects in VFIO

2017-05-11 Thread Stephen Hemminger
Looks like obvious C array bounds issues... Begin forwarded message: Date: Thu, 11 May 2017 06:32:38 -0700 From: scan-ad...@coverity.com To: step...@networkplumber.org Subject: New Defects reported by Coverity Scan for DPDK Data Plane Development Kit Hi, Please find the latest report on new d

Re: [dpdk-dev] [PATCH v1] doc: change doc line length limit in contributors guide

2017-05-11 Thread Mcnamara, John
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, May 11, 2017 4:23 PM > To: Mcnamara, John > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] doc: change doc line length limit in > contributors guide > > ... > > -* The recommended style fo

[dpdk-dev] [PATCH] vhost: check malloc return value when allocating guest pages

2017-05-11 Thread Jens Freimann
When we try to allocate guest pages we need to check the return value of malloc(). Print an error message and return when it fails. Signed-off-by: Jens Freimann --- lib/librte_vhost/vhost_user.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte

Re: [dpdk-dev] [PATCH v1] doc: change doc line length limit in contributors guide

2017-05-11 Thread Thomas Monjalon
11/05/2017 16:09, John McNamara: > The DPDK documentation guidelines state that lines should be wrapped as > follows: > > * The recommended style for the DPDK documentation is to put sentences on > separate lines. This allows for easier reviewing of patches. ... > * Long sentences should be wrap

[dpdk-dev] [PATCH v2 6/6] eal: pause while busy-waiting for slave

2017-05-11 Thread Ashwin Sekhar T K
Instead of simply busy-waiting for slave in rte_eal_wait_lcore() do rte_pause(). This will give power savings. This also fixes warning -Wempty-body seen with armv8a clang compilation. Signed-off-by: Ashwin Sekhar T K --- lib/librte_eal/common/eal_common_launch.c | 3 ++- 1 file changed, 2 inser

[dpdk-dev] [PATCH v2 5/6] eal/arm: fix warnings seen with armv8a clang

2017-05-11 Thread Ashwin Sekhar T K
Fixed warning -Wasm-operand-widths seen with armv8a clang compilation. Signed-off-by: Ashwin Sekhar T K Reviewed-by: Jerin Jacob --- lib/librte_eal/common/include/arch/arm/rte_byteorder.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/arch/arm/

[dpdk-dev] [PATCH v2 3/6] net/thunderx: fix compile errors for armv8a clang

2017-05-11 Thread Ashwin Sekhar T K
Replaced usage of %a0 in inline assembly with [%x0] Signed-off-by: Ashwin Sekhar T K Reviewed-by: Jerin Jacob --- drivers/net/thunderx/base/nicvf_plat.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/thunderx/base/nicvf_plat.h b/drivers/net/thunderx/base/nicvf_

[dpdk-dev] [PATCH v2 4/6] acl: fix warning seen with armv8a clang

2017-05-11 Thread Ashwin Sekhar T K
Fixed warning -Wunknown-warning-option seen with armv8a clang compilation. Signed-off-by: Ashwin Sekhar T K Reviewed-by: Jerin Jacob --- lib/librte_acl/Makefile | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/librte_acl/Makefile b/lib/librte_acl/Makefile index e2dacd

[dpdk-dev] [PATCH v2 2/6] config: add clang support for armv8a linuxapp

2017-05-11 Thread Ashwin Sekhar T K
Moved all common defines from defconfig_arm64-armv8a-linuxapp-gcc to common_armv8a_linuxapp. Created new config arm64-armv8a-linuxapp-clang which adds the clang support to armv8a. Now defconfigs arm64-armv8a-linuxapp-gcc/clang contain only the CONFIG_RTE_TOOLCHAIN* defines and all other common de

[dpdk-dev] [PATCH v2 0/6] Add clang compilation support for armv8a linuxapp

2017-05-11 Thread Ashwin Sekhar T K
This series of patches adds the clang compilation support for armv8a linuxapp. Patch 1 is basically for removing the usage of assembly directive ".arch armv8-a+crc" as this is not understood by clang. For removing these directives, compilation of armv8a crc32 support is made conditional and is o

[dpdk-dev] [PATCH v2 1/6] hash: compile armv8a CRC32 support conditionally

2017-05-11 Thread Ashwin Sekhar T K
Compile the armv8a CRC32 support only if the machine has the CRC extensions i.e if RTE_MACHINE_CPUFLAG_CRC32 is defined. Removed the .arch assembly directives as these are no more necessary. Signed-off-by: Ashwin Sekhar T K Reviewed-by: Jerin Jacob --- lib/librte_hash/Makefile| 2 ++ l

Re: [dpdk-dev] [PATCH v3 2/3] vhost: free guest_pages in vhost_backend_cleanup()

2017-05-11 Thread Jens Freimann
On Thu, May 11, 2017 at 04:33:11PM +0200, Dariusz Stojaczyk wrote: > This patch fixes a memory leak. > virtio_net::guest_pages is allocated in vhost_setup_mem_table(), > reallocated in add_one_guest_page(), but never freed. > > Signed-off-by: Dariusz Stojaczyk > --- > lib/librte_vhost/vhost_user

Re: [dpdk-dev] [PATCH] app/crypto-perf: add minimise-offload-cost flag

2017-05-11 Thread Kusztal, ArkadiuszX
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fiona Trahe > Sent: Tuesday, May 09, 2017 5:14 PM > To: dev@dpdk.org; Mrozowicz, SlawomirX > > Cc: Doherty, Declan ; Griffin, John > ; De Lara Guarch, Pablo > ; Trahe, Fiona > Subject: [dpdk-dev] [PATCH] app/cry

[dpdk-dev] [PATCH v1] doc: change doc line length limit in contributors guide

2017-05-11 Thread John McNamara
The DPDK documentation guidelines state that lines should be wrapped as follows: * The recommended style for the DPDK documentation is to put sentences on separate lines. This allows for easier reviewing of patches. ... * Long sentences should be wrapped at 120 characters +/- 10 characters. Th

Re: [dpdk-dev] [PATCH 0/6] add clang compilation support for armv8a linuxapp

2017-05-11 Thread Sekhar, Ashwin
The warning comes only when CFLAGS "-g -ggdb" are given and this seems to be an issue with clang. I am seeing some related bugs on llvm mailing list. https://www.mail-archive.com/llvm-bugs@lists.llvm.org/msg05498.html http://lists.llvm.org/pipermail/llvm-bugs/2016-July/048288.html Even a simple c

Re: [dpdk-dev] [PATCH v3 1/3] vhost: fix malloc in rte_vhost_get_mem_table()

2017-05-11 Thread Jens Freimann
On Thu, May 11, 2017 at 04:33:10PM +0200, Dariusz Stojaczyk wrote: > Amount of allocated memory was too small, causing buffer overflow. > > Signed-off-by: Dariusz Stojaczyk > --- > lib/librte_vhost/vhost.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Jens Freimann

[dpdk-dev] [PATCH v1] doc: add template release notes for 17.08

2017-05-11 Thread John McNamara
Add template release notes for DPDK 17.08 with inline comments and explanations of the various sections. Signed-off-by: John McNamara --- doc/guides/rel_notes/release_17_08.rst | 198 + 1 file changed, 198 insertions(+) create mode 100644 doc/guides/rel_notes/rel

[dpdk-dev] [PATCH v1] metrics: fix Coverity warnings

2017-05-11 Thread Remy Horton
Fixes memory access errors detected by Coverity. All cases are the maximum permissable value causing an out-by-one overrun. Coverity issue 143433: Memory - illigal access Coverity issue 143434: Memory - illigal access Coverity issue 143460: Memory - corruptins Coverity issue 143464: Memory - illig

[dpdk-dev] [RFC PATCH v2 3/3] cryptodev: added asym queue pair and session apis

2017-05-11 Thread Umesh Kartha
Added asymmetric operation queue pairs to device file. Added asymmetric session creation/initialisation/deletion APIs. Added asymmetric queue pair APIs to device ops. Added APIs to attach asym session to queue pairs. Signed-off-by: Umesh Kartha --- lib/librte_cryptodev/rte_cryptodev.c | 352

[dpdk-dev] [RFC PATCH v2 2/3] cryptodev: asymmetric algorithm capability definitions

2017-05-11 Thread Umesh Kartha
Added asymmetric algorithm capability structures, operation error codes, application helper functions. Added asymmetric algorithm/operation variants, capability query APIs. Signed-off-by: Umesh Kartha --- lib/librte_cryptodev/rte_crypto.h| 135 ++- lib/librte_cryptodev/rte_cryptodev.

[dpdk-dev] [RFC PATCH v2 1/3] cryptodev: added asymmetric algorithms

2017-05-11 Thread Umesh Kartha
Added asymmetric xform structures, operation definitions, operation parameters. Added asymmetric algorithms RSA, DH, ECDH, DSA, ECDSA, MODEXP, FECC, MOD-INVERSE. Added curves (all curves supported by libcrypto as of now). Signed-off-by: Umesh Kartha --- lib/librte_cryptodev/rte_crypto_asym.h | 1

[dpdk-dev] [RFC PATCH v2 0/3] specifications for asymmetric crypto algorithms

2017-05-11 Thread Umesh Kartha
This RFC contains specifications for asymmetric crypto algorithms. Asymmetric crypto algorithms are essential part of protocols such as SSL/TLS. As the current DPDK crypto library lacks support for asymmetric crypto algorithms, this RFC is an attempt to address it. Cavium offers PCI hardware acce

Re: [dpdk-dev] [PATCH v2 1/3] vhost: fix malloc in rte_vhost_get_mem_table

2017-05-11 Thread Stojaczyk, DariuszX
The size variable is still used a few lines later: memcpy(m->regions, dev->mem->regions, size); That line is ok. Only the amount of malloc'ed memory was too small. -Original Message- From: Jens Freimann [mailto:jfrei...@redhat.com] Sent: Thursday, May 11, 2017 1:42 PM To: Stojaczyk, Dariu

[dpdk-dev] [PATCH v2] kni: add new mbuf in alloc_q only based on its empty slots

2017-05-11 Thread Gowrishankar
From: Gowrishankar Muthukrishnan In kni_allocate_mbufs(), we attempt to add max_burst (32) count of mbuf always into alloc_q, which is excessively leading too many rte_pktmbuf_ free() when alloc_q is contending at high packet rate (for eg 10Gig data). In a situation when alloc_q fifo can only acc

Re: [dpdk-dev] [PATCH v2 1/3] vhost: fix malloc in rte_vhost_get_mem_table

2017-05-11 Thread Jens Freimann
On Thu, May 11, 2017 at 12:56:46PM +0200, Dariusz Stojaczyk wrote: > Amount of allocated memory was too small, causing buffer overflow. > > Signed-off-by: Dariusz Stojaczyk > --- > Removed Gerrit Change-Id > lib/librte_vhost/vhost.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > di

Re: [dpdk-dev] [PATCH] maintainers: claim responsability for xen

2017-05-11 Thread Tan, Jianfeng
Hi Thomas and all, Apologize for being an unqualified maintainer. > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, May 5, 2017 6:04 AM > To: Joao Martins; Konrad Rzeszutek Wilk; Tan, Jianfeng > Cc: Konrad Rzeszutek Wilk; dev@dpdk.org; Xen-devel >

[dpdk-dev] [PATCH] kni: add new mbuf in alloc_q only based on its empty slots

2017-05-11 Thread Gowrishankar
From: Gowrishankar Muthukrishnan In kni_allocate_mbufs(), we attempt to add max_burst (32) count of mbuf always into alloc_q, which is excessively leading too many rte_pktmbuf_free() when alloc_q is contending at high packet rate (for eg 10Gig data). In a situation when alloc_q fifo can only acco

[dpdk-dev] [PATCH v3 2/3] vhost: free guest_pages in vhost_backend_cleanup()

2017-05-11 Thread Dariusz Stojaczyk
This patch fixes a memory leak. virtio_net::guest_pages is allocated in vhost_setup_mem_table(), reallocated in add_one_guest_page(), but never freed. Signed-off-by: Dariusz Stojaczyk --- lib/librte_vhost/vhost_user.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_vhost/vhost

[dpdk-dev] [PATCH v3 3/3] vhost: access VhostUsrMsg via packed struct

2017-05-11 Thread Dariusz Stojaczyk
From: Daniel Verkamp Fixes unaligned access to fields. Signed-off-by: Daniel Verkamp Signed-off-by: Dariusz Stojaczyk --- Fixed checkpatch warnings lib/librte_vhost/vhost_user.c | 60 +++ 1 file changed, 32 insertions(+), 28 deletions(-) diff --git a/l

[dpdk-dev] [PATCH] net/ark: fix for Coverity issues

2017-05-11 Thread John Miller
Fixes: 9c7188a68d7b ("net/ark: provide API for hardware modules pktchkr and pktgen") Coverity issue: 144513 Fixes: 727b3fe292bc ("net/ark: integrate PMD") Coverity issue: 144514 Fixes: 9c7188a68d7b ("net/ark: provide API for hardware modules pktchkr and pktgen") Coverity issue: 144512 Fixes: 1

[dpdk-dev] [PATCH v3 1/3] vhost: fix malloc in rte_vhost_get_mem_table()

2017-05-11 Thread Dariusz Stojaczyk
Amount of allocated memory was too small, causing buffer overflow. Signed-off-by: Dariusz Stojaczyk --- lib/librte_vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c index 0b19d2e..1f565fb 100644 --- a/lib/librte_

[dpdk-dev] [PATCH v3 0/3] vhost undefined behavior fixes

2017-05-11 Thread Dariusz Stojaczyk
Fixes for memory-related undefined behavior issues in rte_vhost. Daniel Verkamp (1): vhost: access VhostUsrMsg via packed struct Dariusz Stojaczyk (2): vhost: fix malloc in rte_vhost_get_mem_table() vhost: free guest_pages in vhost_backend_cleanup() lib/librte_vhost/vhost.c | 2 +-

[dpdk-dev] [PATCH 1/2] test/test_mbuf: Remove mempool global var

2017-05-11 Thread Santosh Shukla
Cc: sta...@dpdk.org Signed-off-by: Santosh Shukla --- test/test/test_mbuf.c | 100 +- 1 file changed, 51 insertions(+), 49 deletions(-) diff --git a/test/test/test_mbuf.c b/test/test/test_mbuf.c index d3ea812e5..ba93ac783 100644 --- a/test/test/tes

[dpdk-dev] [PATCH 2/2] test/test_mbuf: Free mempool on exit

2017-05-11 Thread Santosh Shukla
Cc: sta...@dpdk.org Signed-off-by: Santosh Shukla --- test/test/test_mbuf.c | 48 +++- 1 file changed, 31 insertions(+), 17 deletions(-) diff --git a/test/test/test_mbuf.c b/test/test/test_mbuf.c index ba93ac783..d6cf4d611 100644 --- a/test/test/test_m

Re: [dpdk-dev] [PATCH v3 5/7] examples/l3fwd: add neon support for l3fwd

2017-05-11 Thread Sekhar, Ashwin
On Thu, 2017-05-11 at 18:01 +0800, Jianbo Liu wrote: > On 11 May 2017 at 17:49, Sekhar, Ashwin > wrote: > > > > Hi Jianbo, > > > > Thanks for v3. Small compilation error. See inline comment. > > Otherwise > > it looks fine. > > > > On Thu, 2017-05-11 at 17:25 +0800, Jianbo Liu wrote: > > > > >

[dpdk-dev] [PATCH v2] drivers/net/i40e/i40e_fdir.c: Improved i40e FDIR programming times

2017-05-11 Thread Michael Lilja
During my work (https://www.napatech.com/hw-acceleration-via-rte_flow/) on a flowtable application example that use rte_flow I discovered that the rte_flow programming times on a i40e was +11ms. The patch below result in an average programming time of 22usec with a max of 60usec instead of +11ms.

[dpdk-dev] [PATCH 6/6] eal: switchover to architecture specific rte pause function

2017-05-11 Thread Jerin Jacob
Remove rte_pause() definition from rte_common.h and switchover to architecture specific rte_pause.h Signed-off-by: Jerin Jacob --- examples/distributor/main.c | 1 + examples/l2fwd-jobstats/main.c | 1 + examples/performance-thread/l3fwd-t

[dpdk-dev] [PATCH 5/6] eal/ppc64: rte pause implementation for ppc64

2017-05-11 Thread Jerin Jacob
The patch does not provide any functional change for ppc64 with respect to existing rte_pause() definition. CC: Chao Zhu Signed-off-by: Jerin Jacob --- .../common/include/arch/ppc_64/rte_pause.h | 51 ++ 1 file changed, 51 insertions(+) create mode 100644 lib/librte

[dpdk-dev] [PATCH 4/6] eal/x86: rte pause implementation for x86

2017-05-11 Thread Jerin Jacob
The patch does not provide any functional change for x86 with respect to existing rte_pause() definition. CC: Bruce Richardson CC: Konstantin Ananyev Signed-off-by: Jerin Jacob --- lib/librte_eal/common/include/arch/x86/rte_pause.h | 59 ++ 1 file changed, 59 insertions(+)

[dpdk-dev] [PATCH 3/6] eal/arm64: rte pause implementation for arm64

2017-05-11 Thread Jerin Jacob
CC: Jianbo Liu Signed-off-by: Jerin Jacob --- lib/librte_eal/common/include/arch/arm/rte_pause.h | 4 ++ .../common/include/arch/arm/rte_pause_64.h | 55 ++ 2 files changed, 59 insertions(+) create mode 100644 lib/librte_eal/common/include/arch/arm/rte_pause_64.h d

[dpdk-dev] [PATCH 2/6] eal/arm32: rte pause implementation for arm32

2017-05-11 Thread Jerin Jacob
The patch does not provide any functional change for ARM32 with respect to existing rte_pause() definition. CC: Jan Viktorin CC: Jianbo Liu Signed-off-by: Jerin Jacob --- lib/librte_eal/common/include/arch/arm/rte_pause.h | 46 +++ .../common/include/arch/arm/rte_pause_32.h

[dpdk-dev] [PATCH 1/6] eal: change rte pause as architecture specific function

2017-05-11 Thread Jerin Jacob
Each architecture may have different instructions for optimized and power consumption aware rte_pause() implementation. Signed-off-by: Jerin Jacob --- doc/api/doxy-api-index.md | 3 +- lib/librte_eal/common/Makefile| 2 +- lib/librte_eal/common/inclu

Re: [dpdk-dev] [PATCH v3 5/7] examples/l3fwd: add neon support for l3fwd

2017-05-11 Thread Jianbo Liu
On 11 May 2017 at 17:49, Sekhar, Ashwin wrote: > Hi Jianbo, > > Thanks for v3. Small compilation error. See inline comment. Otherwise > it looks fine. > > On Thu, 2017-05-11 at 17:25 +0800, Jianbo Liu wrote: >> Use ARM NEON intrinsics to accelerate l3 fowarding. >> >> Signed-off-by: Jianbo Liu >>

[dpdk-dev] [PATCH] event/sw: add queue-to-port stats

2017-05-11 Thread Harry van Haaren
This patch targets the next-eventdev tree. This commit adds a new statistic to the SW eventdev PMD. The statistic shows how many packets were sent from a queue to a port. This provides information on how traffic from a specific queue is being load-balanced to worker cores. Note that these numbers

Re: [dpdk-dev] [PATCH v3 5/7] examples/l3fwd: add neon support for l3fwd

2017-05-11 Thread Sekhar, Ashwin
Hi Jianbo, Thanks for v3. Small compilation error. See inline comment. Otherwise it looks fine. On Thu, 2017-05-11 at 17:25 +0800, Jianbo Liu wrote: > Use ARM NEON intrinsics to accelerate l3 fowarding. > > Signed-off-by: Jianbo Liu > --- [...] > +/** > + * Process one packet: > + * Update sou

[dpdk-dev] [PATCH v3 6/7] examples/l3fwd: add the times of hash multi-lookup for different Archs

2017-05-11 Thread Jianbo Liu
New macro to define how many times of hash lookup in one time, and this makes the code more concise. Signed-off-by: Jianbo Liu --- examples/l3fwd/l3fwd_em_hlm.h | 241 +- 1 file changed, 71 insertions(+), 170 deletions(-) diff --git a/examples/l3fwd/l3fwd

[dpdk-dev] [PATCH v3 7/7] examples/l3fwd: change the guard macro name for header file

2017-05-11 Thread Jianbo Liu
As l3fwd_em_sse.h is renamed to l3fwd_em_sequential.h, change the macro to __L3FWD_EM_SEQUENTIAL_H__ to maintain consistency. Signed-off-by: Jianbo Liu --- examples/l3fwd/l3fwd_em_sequential.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/l3fwd/l3fwd_em_seque

[dpdk-dev] [PATCH v3 5/7] examples/l3fwd: add neon support for l3fwd

2017-05-11 Thread Jianbo Liu
Use ARM NEON intrinsics to accelerate l3 fowarding. Signed-off-by: Jianbo Liu --- examples/l3fwd/l3fwd_em.c| 4 +- examples/l3fwd/l3fwd_em_hlm.h| 17 ++- examples/l3fwd/l3fwd_em_hlm_neon.h | 74 ++ examples/l3fwd/l3fwd_em_sequential.h | 18 ++- examples/l3fwd/l

[dpdk-dev] [PATCH v3 0/7] accelerate examples/l3fwd with NEON on ARM64 platform

2017-05-11 Thread Jianbo Liu
v3: - remove unnecessary perfetch for rte_mbuf - fix typo in git log - Ashwin's suggestions for performance on ThunderX v2: - change name of l3fwd_em_sse.h to l3fwd_em_sequential.h - add the times of hash multi-lookup for different Archs - performance tuning on ThunderX: prefetching, s

[dpdk-dev] [PATCH v3 2/7] examples/l3fwd: rename l3fwd_em_sse.h to l3fwd_em_sequential.h

2017-05-11 Thread Jianbo Liu
The l3fwd_em_sse.h is enabled by NO_HASH_LOOKUP_MULTI. Renaming it because it's only for sequential hash lookup, and doesn't include any x86 SSE instructions. Signed-off-by: Jianbo Liu --- examples/l3fwd/l3fwd_em.c| 2 +- examples/l3fwd/{l3fwd_em_sse.h => l3fwd_em

[dpdk-dev] [PATCH v3 1/7] examples/l3fwd: extract arch independent code from multi hash lookup

2017-05-11 Thread Jianbo Liu
Extract common code from l3fwd_em_hlm_sse.h, and add to the new file l3fwd_em_hlm.h. Signed-off-by: Jianbo Liu --- examples/l3fwd/l3fwd_em.c | 2 +- examples/l3fwd/l3fwd_em_hlm.h | 302 ++ examples/l3fwd/l3fwd_em_hlm_sse.h | 280 +

[dpdk-dev] [PATCH v3 4/7] examples/l3fwd: rearrange the code for lpm_l3fwd

2017-05-11 Thread Jianbo Liu
Signed-off-by: Jianbo Liu Some common code can be used by other ARCHs, move to l3fwd_lpm.c --- examples/l3fwd/l3fwd_lpm.c | 83 ++ examples/l3fwd/l3fwd_lpm.h | 26 + examples/l3fwd/l3fwd_lpm_sse.h | 66 -

[dpdk-dev] [PATCH v3 3/7] examples/l3fwd: extract common code from multi packet send

2017-05-11 Thread Jianbo Liu
Keep x86 related code in l3fwd_sse.h, and move common code to l3fwd_common.h, which will be used by other Archs. Signed-off-by: Jianbo Liu --- examples/l3fwd/l3fwd_common.h | 293 ++ examples/l3fwd/l3fwd_sse.h| 255 +---

Re: [dpdk-dev] [RFC][PATCH 0/5] cryptodev: Adding support for inline crypto processing of IPsec flows

2017-05-11 Thread Radu Nicolau
Hi, Just a comment on the last question On 5/11/2017 6:27 AM, Boris Pismenny wrote: 5. The addition of inline crypto metadata into the rte_mbuf structure to allow the required egress metadata to be given to the NIC PMD to build the necessary transmit descriptors in tx_burst processing when th

[dpdk-dev] [PATCH] ethernet api: Document rte_eth_vmdq_rx_conf

2017-05-11 Thread Tom Barbette
>From documentation it is very unclear how VMDq configuration can be tweaked, and online search offer very poor results. This patch will ultimately spawn an online documentation page for the rte_eth_vmdq_rx_conf struct which will eventually add a bit of documentation about the rx_mode tag and how

[dpdk-dev] [PATCH v2 3/3] vhost: access VhostUsrMsg via packed struct

2017-05-11 Thread Dariusz Stojaczyk
From: Daniel Verkamp Fixes unaligned access to fields. Signed-off-by: Daniel Verkamp Signed-off-by: Dariusz Stojaczyk --- Removed Gerrit Change-Id lib/librte_vhost/vhost_user.c | 56 +-- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/li

[dpdk-dev] [PATCH v2 1/3] vhost: fix malloc in rte_vhost_get_mem_table

2017-05-11 Thread Dariusz Stojaczyk
Amount of allocated memory was too small, causing buffer overflow. Signed-off-by: Dariusz Stojaczyk --- Removed Gerrit Change-Id lib/librte_vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c index 0b19d2e..1f565fb

[dpdk-dev] [PATCH v2 2/3] vhost: free virtio_net::guest_pages in vhost_backend_cleanup()

2017-05-11 Thread Dariusz Stojaczyk
guest_pages is being allocated in vhost_setup_mem_table(), reallocated in add_one_guest_page(), but never freed. This patch fixes a memory leak. Signed-off-by: Dariusz Stojaczyk --- Removed Gerrit Change-Id lib/librte_vhost/vhost_user.c | 4 1 file changed, 4 insertions(+) diff --git a/lib