Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: extended list of operations for ddp processing

2017-06-27 Thread Xing, Beilei
Hi Andrey, > -Original Message- > From: Chilikin, Andrey > Sent: Tuesday, June 27, 2017 9:35 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Wu, Jingjing > ; Chilikin, Andrey > Subject: [PATCH v3 1/2] net/i40e: extended list of operations for ddp > processing > > This patch adds ability to re

Re: [dpdk-dev] [RFC] eventdev: add event adapter for ethernet Rx queues

2017-06-27 Thread Rao, Nikhil
On 6/26/2017 6:49 PM, Jerin Jacob wrote: Nikhil, Now that Harry send first version of service core patch? Are you planning for new version with above comments? Yes. I will post a new version. Thanks, Nikhil

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: enable ddp remove profile feature

2017-06-27 Thread Xing, Beilei
> -Original Message- > From: Chilikin, Andrey > Sent: Tuesday, June 27, 2017 9:35 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Wu, Jingjing > ; Chilikin, Andrey > Subject: [PATCH v3 2/2] app/testpmd: enable ddp remove profile feature > > New command 'ddp del (port) (profile_path)' removes p

[dpdk-dev] [PATCH 1/2] cxgbe: update supported port module types

2017-06-27 Thread Rahul Lakkireddy
Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- drivers/net/cxgbe/base/t4fw_interface.h | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/net/cxgbe/base/t4fw_interface.h b/drivers/net/cxgbe/base/t4fw_interface.h index 6283fe9..6ca4f31 1

[dpdk-dev] [PATCH 0/2] cxgbe: fix supported speed capabilities

2017-06-27 Thread Rahul Lakkireddy
Patch 1 updates supported port module types. Patch 2 uses port type to determine the supported speed capabilities. Thanks, Rahul Rahul Lakkireddy (2): cxgbe: update supported port module types cxgbe: fix supported speed capabilities doc/guides/nics/features/cxgbe.ini | 2 +- drivers/

[dpdk-dev] [PATCH 2/2] cxgbe: fix supported speed capabilities

2017-06-27 Thread Rahul Lakkireddy
Use port type to determine the supported speed capabilities. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- doc/guides/nics/features/cxgbe.ini | 2 +- drivers/net/cxgbe/cxgbe.h | 1 + drivers/net/cxgbe/cxgbe_ethdev.c | 2 +- drivers/net/cxgbe/cxgbe_main.c

Re: [dpdk-dev] bug: virtio PMD sends malformed packets for 32-bit processes on 64-bit kernel

2017-06-27 Thread Tan, Jianfeng
> -Original Message- > From: Frederico Cadete [mailto:frederico.cadete-...@oneaccess-net.com] > Sent: Tuesday, June 27, 2017 9:32 PM > To: yuanhan@linux.intel.com; maxime.coque...@redhat.com; Tan, > Jianfeng > Cc: John Sucaet; dev@dpdk.org > Subject: Re: bug: virtio PMD sends malforme

[dpdk-dev] [PATCH] net/ixgbe: link check enhancement on VF

2017-06-27 Thread Wenzhuo Lu
From: Liang-min Wang In current implementation, when checking VF link state, PF state is checked too, although the function has a parameter to tell if PF state checking is needed. But in some scenario, user may not care about the PF state. This patch enables the unused parameter to only check the

Re: [dpdk-dev] [PATCH v7 1/3] lib: add Generic Receive Offload API framework

2017-06-27 Thread Jiayu Hu
Hi Konstantin, On Wed, Jun 28, 2017 at 07:42:01AM +0800, Ananyev, Konstantin wrote: > Hi Jiayu, > > > -Original Message- > > From: Hu, Jiayu > > Sent: Monday, June 26, 2017 7:44 AM > > To: dev@dpdk.org > > Cc: Tan, Jianfeng ; Ananyev, Konstantin > > ; step...@networkplumber.org; > > y...

Re: [dpdk-dev] [PATCH v5 16/19] devargs: introduce cleaner parsing helper

2017-06-27 Thread Wiles, Keith
> On Jun 20, 2017, at 4:35 PM, Gaetan Rivet wrote: > > Introduce a more versatile helper to parse device strings. This > helper expects a generic rte_devargs structure as storage in order not > to require any API changes in the future, should this structure be > updated. > > The old equivalent

Re: [dpdk-dev] [PATCH v7 1/3] lib: add Generic Receive Offload API framework

2017-06-27 Thread Ananyev, Konstantin
Hi Jiayu, > -Original Message- > From: Hu, Jiayu > Sent: Monday, June 26, 2017 7:44 AM > To: dev@dpdk.org > Cc: Tan, Jianfeng ; Ananyev, Konstantin > ; step...@networkplumber.org; > y...@fridaylinux.org; Wu, Jingjing ; Yao, Lei A > ; Wiles, Keith ; Bie, > Tiwei ; Hu, Jiayu > Subject: [P

Re: [dpdk-dev] [PATCH v6 09/11] pci: implement find_device bus operation

2017-06-27 Thread Stephen Hemminger
On Tue, 27 Jun 2017 18:11:16 +0200 Gaetan Rivet wrote: > + int start_found = !!(start == NULL); > + > + FOREACH_DEVICE_ON_PCIBUS(dev) { > + if (!start_found) { > + if (&dev->device == start) > + start_found = 1; > +

Re: [dpdk-dev] [PATCH v2] drivers/net: add support for IF-MIB and EtherLike-MIB for ixgbe

2017-06-27 Thread Stephen Hemminger
On Mon, 26 Jun 2017 10:39:07 +0100 Radu Nicolau wrote: > +static const struct rte_ixgbe_xstats_name_off ixgbe_if_mib_strings[] = { > + {"ifNumber", offsetof(struct ixgbe_if_mib_stats, if_number)}, > + {"ifIndex", offsetof(struct ixgbe_if_mib_stats, if_index)}, > + {"ifType", offsetof(

Re: [dpdk-dev] [PATCH v2] drivers/net: add support for IF-MIB and EtherLike-MIB for e1000

2017-06-27 Thread Stephen Hemminger
On Mon, 26 Jun 2017 10:42:13 +0100 Radu Nicolau wrote: > From: Michal Jastrzebski > > If-MIB xstats: > ifNumber > ifIndex > ifType > ifMtu > ifSpeed > ifPhysAddress > ifOperStatus > ifLastChange > ifHighSpeed > ifConnectorPresent > ifCounterDiscontinuityTime > > EtherLike-MIB xstats: > dot3Pau

Re: [dpdk-dev] [PATCH v2 06/12] cryptodev: move vdev functions to a separate file

2017-06-27 Thread De Lara Guarch, Pablo
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Tuesday, June 27, 2017 6:12 PM > To: Thomas Monjalon ; Yigit, Ferruh > > Cc: dev@dpdk.org; Doherty, Declan > Subject: Re: [dpdk-dev] [PATCH v2 06/12] cryptodev: move vdev funct

Re: [dpdk-dev] [PATCH v5 16/19] devargs: introduce cleaner parsing helper

2017-06-27 Thread Thomas Monjalon
21/06/2017 01:35, Gaetan Rivet: > +int > +rte_eal_devargs_parse(const char *dev, > + struct rte_devargs *da); You need to export this new function: --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map +++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map @@ -203,6 +203,7 @@ DPDK_17

Re: [dpdk-dev] [PATCH v2] ethdev: add flow API rule copy function

2017-06-27 Thread Thomas Monjalon
19/05/2017 17:21, Gaetan Rivet: > +/** > + * Flow elements description tables. > + */ > +struct rte_flow_desc_data { > + const char *name; > + size_t size; > +}; > + > +extern const struct rte_flow_desc_data rte_flow_desc_item[]; > +extern size_t rte_flow_nb_item; > + > +extern const struct

Re: [dpdk-dev] [PATCH v2] ethdev: add flow API rule copy function

2017-06-27 Thread Thomas Monjalon
19/05/2017 17:21, Gaetan Rivet: > --- a/lib/librte_ether/rte_flow.c > +++ b/lib/librte_ether/rte_flow.c > @@ -33,12 +33,70 @@ > > #include > > +#include > #include > #include > #include "rte_ethdev.h" > #include "rte_flow_driver.h" > #include "rte_flow.h" > > +/** Generate flow_item

Re: [dpdk-dev] [PATCH v5 2/7] bus: introduce parsing functionality

2017-06-27 Thread Jan Blunck
On Wed, Jun 21, 2017 at 1:30 AM, Gaetan Rivet wrote: > This operation can be used either to validate that a device > representation can be understood by a bus, as well as store the resulting > specialized device representation in any format determined by the bus. > Again, I don't think this makes

Re: [dpdk-dev] [PATCH v5 1/7] bus: fix bus name registration

2017-06-27 Thread Jan Blunck
On Wed, Jun 21, 2017 at 1:30 AM, Gaetan Rivet wrote: > The default bus registration function should not result in buses > registering with double quotes within their names. > This is breaking expectations with users. All other registration macro pass the names through the stringification. The pro

Re: [dpdk-dev] [PATCH v6 05/11] bus: introduce hotplug functionality

2017-06-27 Thread Jan Blunck
On Tue, Jun 27, 2017 at 6:11 PM, Gaetan Rivet wrote: > From: Jan Blunck > > Signed-off-by: Jan Blunck > Signed-off-by: Gaetan Rivet > --- > lib/librte_eal/common/eal_common_bus.c | 2 ++ > lib/librte_eal/common/include/rte_bus.h | 31 +++ > 2 files changed, 33 ins

Re: [dpdk-dev] [PATCH v5 5/7] bus: add helper to find a bus from a device name

2017-06-27 Thread Jan Blunck
On Wed, Jun 21, 2017 at 1:30 AM, Gaetan Rivet wrote: > Find which bus should be able to parse this device name into an internal > device representation. > > Signed-off-by: Gaetan Rivet > --- > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + > lib/librte_eal/common/eal_common_bus.c

[dpdk-dev] Getting PF link status to DPDK-VF in case of SR-IOV

2017-06-27 Thread Dey, Souvik
Hi Ferruh/Lu, I see that both of you have posted multiple patches in DPDK wrt IXGBE SR-IOV and PF to VF link status/ I am trying to use DPDK 16.11 and do see that it has the support of both pinging VF when PF link status changes and also VF support of mailbox msg when PF link is

Re: [dpdk-dev] [PATCH v2 06/12] cryptodev: move vdev functions to a separate file

2017-06-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, June 27, 2017 5:09 PM > To: Yigit, Ferruh > Cc: dev@dpdk.org; De Lara Guarch, Pablo > ; Doherty, Declan > > Subject: Re: [dpdk-dev] [PATCH v2 06/12] cryptodev: move vdev functions > to a separate

Re: [dpdk-dev] [PATCH v3] test/test_mbuf: remove mempool global var

2017-06-27 Thread Thomas Monjalon
26/06/2017 12:04, Santosh Shukla: > Currently, pool resources are allocated statically > and are not freed. Results of that test can not run more than once. > > Fix removes static dependency from test application and > now allocating and freeing resources dynamically. > Test runs for more than onc

Re: [dpdk-dev] [PATCH v5 5/7] bus: add helper to find a bus from a device name

2017-06-27 Thread Bruce Richardson
On Wed, Jun 21, 2017 at 01:30:34AM +0200, Gaetan Rivet wrote: > Find which bus should be able to parse this device name into an internal > device representation. > > Signed-off-by: Gaetan Rivet > --- Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v5 4/7] pci: implement parse bus operation

2017-06-27 Thread Bruce Richardson
On Wed, Jun 21, 2017 at 01:30:33AM +0200, Gaetan Rivet wrote: > Signed-off-by: Gaetan Rivet > --- > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 7 +++ > lib/librte_eal/common/eal_common_bus.c | 16 > lib/librte_eal/common/eal_common_pci.c | 19 +++

Re: [dpdk-dev] [PATCH v3 7/8] mk: sort object files when building deps lists

2017-06-27 Thread Thomas Monjalon
27/06/2017 16:51, Luca Boccassi: > On Tue, 2017-06-27 at 15:52 +0200, Thomas Monjalon wrote: > > 27/06/2017 12:43, Luca Boccassi: > > > On Tue, 2017-06-27 at 01:20 +0200, Thomas Monjalon wrote: > > > > 23/06/2017 20:41, lbocc...@brocade.com: > > > > > From: Luca Boccassi > > > > > > > > > > In or

[dpdk-dev] [PATCH v6 10/11] pci: implement hotplug bus operation

2017-06-27 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_pci.c | 44 ++ 1 file changed, 44 insertions(+) diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c index ab55041..e30d2d1 100644 --- a/lib/librte_eal/common

[dpdk-dev] [PATCH v6 11/11] dev: use new hotplug API in attach / detach

2017-06-27 Thread Gaetan Rivet
From: Jan Blunck This new generic API allows attach and detach to be compatible with all buses supporting hotplug. Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_dev.c | 92 ++ 1 file changed, 70 insertions(+), 22 del

[dpdk-dev] [PATCH v6 09/11] pci: implement find_device bus operation

2017-06-27 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_pci.c | 21 + 1 file changed, 21 insertions(+) diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c index 78b097e..ab55041 100644 --- a/lib/librte_eal/common/eal_common_p

[dpdk-dev] [PATCH v6 08/11] vdev: use standard bus registration function

2017-06-27 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_vdev.c | 18 +- lib/librte_eal/common/include/rte_vdev.h | 2 ++ 2 files changed, 3 insertions(+), 17 deletions(-) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c in

[dpdk-dev] [PATCH v6 07/11] vdev: implement hotplug bus operation

2017-06-27 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_vdev.c | 36 + 1 file changed, 36 insertions(+) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index 625a8e2..f5c557f 100644 --- a/lib/librte_eal/comm

[dpdk-dev] [PATCH v6 06/11] vdev: implement find_device bus operation

2017-06-27 Thread Gaetan Rivet
From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_vdev.c | 21 + 1 file changed, 21 insertions(+) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index 0037a64..625a8e

[dpdk-dev] [PATCH v6 03/11] bus: add helper to find which bus holds a device

2017-06-27 Thread Gaetan Rivet
From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 25 + lib/librte_eal/common/include/rte_bus.h | 5 + lib/librte_eal/linuxapp

[dpdk-dev] [PATCH v6 05/11] bus: introduce hotplug functionality

2017-06-27 Thread Gaetan Rivet
From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_bus.c | 2 ++ lib/librte_eal/common/include/rte_bus.h | 31 +++ 2 files changed, 33 insertions(+) diff --git a/lib/librte_eal/common/eal_common_bus.c b/li

[dpdk-dev] [PATCH v6 04/11] bus: add bus iterator to find a device

2017-06-27 Thread Gaetan Rivet
From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 17 lib/librte_eal/common/include/rte_bus.h | 26 + lib/librte_e

[dpdk-dev] [PATCH v6 02/11] bus: add device iterator method

2017-06-27 Thread Gaetan Rivet
From: Jan Blunck This new method allows buses to expose their devices in a controlled manner. A comparison function is provided by the user to discriminate between devices, using arbitrary data as identifier. It is possible to start an iteration from a specific point, in order to continue a sear

[dpdk-dev] [PATCH v6 01/11] bus: add bus iterator to find a bus

2017-06-27 Thread Gaetan Rivet
From: Jan Blunck This helper allows to iterate over all registered buses and find one matching data used as parameter. Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 20 +++

[dpdk-dev] [PATCH v6 00/11] bus: attach / detach API

2017-06-27 Thread Gaetan Rivet
Following the work from Jan: This patchset introduces the attach / detach API to rte_bus. The rte_device structure is used as the generic device representation. This API is implemented for the virtual bus. The functions rte_eal_dev_attach and rte_eal_dev_detach are updated to use this new interfa

Re: [dpdk-dev] [PATCH v2 06/12] cryptodev: move vdev functions to a separate file

2017-06-27 Thread Thomas Monjalon
27/06/2017 17:11, Ferruh Yigit: > On 6/27/2017 3:28 PM, Thomas Monjalon wrote: > > 27/06/2017 11:51, De Lara Guarch, Pablo: > >> From: Thomas Monjalon [mailto:tho...@monjalon.net] > >>> 23/06/2017 14:52, Declan Doherty: > On 21/06/2017 7:28 AM, Pablo de Lara wrote: > > Move all functions h

Re: [dpdk-dev] [PATCH v5 0/7] rte_bus parse API

2017-06-27 Thread Bruce Richardson
On Wed, Jun 21, 2017 at 01:30:29AM +0200, Gaetan Rivet wrote: > Following the evolutions announced in [1], here is the first part of > the rte_devargs rework planned for 17.08. The rationale has been partially > explained in [2]. > > This first part covers the introduction of the necessary facilit

Re: [dpdk-dev] [PATCH v5 3/7] vdev: implement parse bus operation

2017-06-27 Thread Bruce Richardson
On Wed, Jun 21, 2017 at 01:30:32AM +0200, Gaetan Rivet wrote: > Signed-off-by: Gaetan Rivet > --- > lib/librte_eal/common/eal_common_vdev.c | 60 > + > 1 file changed, 31 insertions(+), 29 deletions(-) > > diff --git a/lib/librte_eal/common/eal_common_vdev.c > b

Re: [dpdk-dev] [PATCH v5 2/7] bus: introduce parsing functionality

2017-06-27 Thread Bruce Richardson
On Wed, Jun 21, 2017 at 01:30:31AM +0200, Gaetan Rivet wrote: > This operation can be used either to validate that a device > representation can be understood by a bus, as well as store the resulting > specialized device representation in any format determined by the bus. > > Signed-off-by: Gaetan

Re: [dpdk-dev] [PATCH v5 1/7] bus: fix bus name registration

2017-06-27 Thread Bruce Richardson
On Wed, Jun 21, 2017 at 01:30:30AM +0200, Gaetan Rivet wrote: > The default bus registration function should not result in buses > registering with double quotes within their names. > > Fixes: a97725791eec ("bus: introduce bus abstraction") > Cc: sta...@dpdk.org > > Signed-off-by: Gaetan Rivet

Re: [dpdk-dev] [PATCH] app/testpmd: update ddp add command parameters

2017-06-27 Thread Ferruh Yigit
On 6/27/2017 4:12 PM, Ferruh Yigit wrote: > On 6/27/2017 1:06 PM, Andrey Chilikin wrote: >> This patch adds optional output file path to 'ddp add' command: >> 'ddp add (port) (profile_path[,output_path])' >> >> Signed-off-by: Andrey Chilikin > > Reviewed-by: Ferruh Yigit Series applied to dpdk-

Re: [dpdk-dev] [PATCH] app/testpmd: update ddp add command parameters

2017-06-27 Thread Ferruh Yigit
On 6/27/2017 1:06 PM, Andrey Chilikin wrote: > This patch adds optional output file path to 'ddp add' command: > 'ddp add (port) (profile_path[,output_path])' > > Signed-off-by: Andrey Chilikin Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v2 06/12] cryptodev: move vdev functions to a separate file

2017-06-27 Thread Ferruh Yigit
On 6/27/2017 3:28 PM, Thomas Monjalon wrote: > 27/06/2017 11:51, De Lara Guarch, Pablo: >> From: Thomas Monjalon [mailto:tho...@monjalon.net] >>> 23/06/2017 14:52, Declan Doherty: On 21/06/2017 7:28 AM, Pablo de Lara wrote: > Move all functions handling virtual devices to a separate header

Re: [dpdk-dev] [PATCH v5 04/12] bus: add bus iterator to find a device

2017-06-27 Thread Bruce Richardson
On Tue, Jun 27, 2017 at 05:05:14PM +0200, Gaëtan Rivet wrote: > On Tue, Jun 27, 2017 at 02:54:34PM +0100, Bruce Richardson wrote: > > On Mon, Jun 26, 2017 at 02:22:02AM +0200, Gaetan Rivet wrote: > > > From: Jan Blunck > > > > > > Signed-off-by: Jan Blunck > > > Signed-off-by: Gaetan Rivet > >

Re: [dpdk-dev] [PATCH v5 12/12] eal: make virtual driver probe and remove take rte_vdev_device

2017-06-27 Thread Bruce Richardson
On Tue, Jun 27, 2017 at 04:47:20PM +0200, Gaëtan Rivet wrote: > On Tue, Jun 27, 2017 at 02:58:55PM +0100, Bruce Richardson wrote: > > On Mon, Jun 26, 2017 at 02:22:10AM +0200, Gaetan Rivet wrote: > > > From: Jan Blunck > > > > > > This is a preparation to embed the generic rte_device into the rte

Re: [dpdk-dev] [PATCH v5 04/12] bus: add bus iterator to find a device

2017-06-27 Thread Gaëtan Rivet
On Tue, Jun 27, 2017 at 02:54:34PM +0100, Bruce Richardson wrote: > On Mon, Jun 26, 2017 at 02:22:02AM +0200, Gaetan Rivet wrote: > > From: Jan Blunck > > > > Signed-off-by: Jan Blunck > > Signed-off-by: Gaetan Rivet > > --- > > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + > > lib/l

Re: [dpdk-dev] [PATCH v3 7/8] mk: sort object files when building deps lists

2017-06-27 Thread Luca Boccassi
On Tue, 2017-06-27 at 15:52 +0200, Thomas Monjalon wrote: > 27/06/2017 12:43, Luca Boccassi: > > On Tue, 2017-06-27 at 01:20 +0200, Thomas Monjalon wrote: > > > 23/06/2017 20:41, lbocc...@brocade.com: > > > > From: Luca Boccassi > > > > > > > > In order to achieve reproducible builds, always use

Re: [dpdk-dev] [PATCH v5 00/12] bus: attach / detach API

2017-06-27 Thread Gaëtan Rivet
On Tue, Jun 27, 2017 at 03:08:17PM +0100, Bruce Richardson wrote: > On Mon, Jun 26, 2017 at 02:21:58AM +0200, Gaetan Rivet wrote: > > Following the work from Jan: > > > > This patchset introduces the attach / detach API to rte_bus. > > The rte_device structure is used as the generic device represe

Re: [dpdk-dev] [PATCH v5 12/12] eal: make virtual driver probe and remove take rte_vdev_device

2017-06-27 Thread Gaëtan Rivet
On Tue, Jun 27, 2017 at 02:58:55PM +0100, Bruce Richardson wrote: > On Mon, Jun 26, 2017 at 02:22:10AM +0200, Gaetan Rivet wrote: > > From: Jan Blunck > > > > This is a preparation to embed the generic rte_device into the rte_eth_dev > > also for virtual devices. > > > > Signed-off-by: Jan Blunc

Re: [dpdk-dev] [PATCH] eal/pci: reduce log verbosity

2017-06-27 Thread Thomas Monjalon
27/06/2017 16:23, Ferruh Yigit: > When debug level logging enabled (--log-level=8) each driver failed to > probe the device printed, like: > > EAL: Driver (net_ark) doesn't match the device > EAL: Driver (net_avp) doesn't match the device > EAL: Driver (net_bnxt) doesn't match the device > EAL: Dr

Re: [dpdk-dev] [PATCH v2 06/12] cryptodev: move vdev functions to a separate file

2017-06-27 Thread Thomas Monjalon
27/06/2017 11:51, De Lara Guarch, Pablo: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 23/06/2017 14:52, Declan Doherty: > > > On 21/06/2017 7:28 AM, Pablo de Lara wrote: > > > > Move all functions handling virtual devices to a separate header > > > > file "rte_cryptodev_vdev.h", in orde

Re: [dpdk-dev] [PATCH v4 00/17] net/i40e: base code update

2017-06-27 Thread Ferruh Yigit
On 6/27/2017 3:00 PM, Jingjing Wu wrote: > v4 changes: > - fix more checkpatch warnings > > v3 changes: > - extra patch to update README > - remove unnecessary code > - fix checkpatch warning > > v2 changes: > - fix compile issue > - update from package from 2017.05.24 to 2017.06.23 > > i4

[dpdk-dev] [PATCH] eal/pci: reduce log verbosity

2017-06-27 Thread Ferruh Yigit
When debug level logging enabled (--log-level=8) each driver failed to probe the device printed, like: EAL: Driver (net_ark) doesn't match the device EAL: Driver (net_avp) doesn't match the device EAL: Driver (net_bnxt) doesn't match the device EAL: Driver (net_cxgbe) doesn't match the device EAL:

[dpdk-dev] [PATCH v2 5/5] app/testpmd: add command to test NIC restoration

2017-06-27 Thread Wei Dai
When a NIC is reset, a message will show it. And then user can run the command "reset_port port_id" to reset the port and to keep same port id without any without any configuration. This patch adds a testpmd command "reconfig_port port_id" to test whether the port can be reconfigured to have succes

[dpdk-dev] [PATCH v2 4/5] app/testpmd: add command to test NIC reset

2017-06-27 Thread Wei Dai
When a NIC is reset, a message will show it. And then user can run the command "reset_port port_id" to process it. Signed-off-by: Wei Dai --- app/test-pmd/cmdline.c | 31 +++ app/test-pmd/config.c | 13 + app/test-pmd/testpmd.h | 1 + 3 files changed, 45

[dpdk-dev] [PATCH v2 3/5] net/i40e: add support of reset

2017-06-27 Thread Wei Dai
Reset a NIC by calling dev_uninit() and then dev_init(). Go through the same way in NIC PCI remove without release of ethdev resource and then NIC PCI probe function without ethdev resource allocation. Signed-off-by: Wei Dai --- drivers/net/i40e/i40e_ethdev.c| 16 drivers/ne

[dpdk-dev] [PATCH v2 2/5] net/ixgbe: add support of reset

2017-06-27 Thread Wei Dai
Reset a NIC by calling dev_uninit and then dev_init. Go through same way in NIC PCI remove without release of ethdev resource and then NIC PCI probe function without ethdev resource allocation. Signed-off-by: Wei Dai --- drivers/net/ixgbe/ixgbe_ethdev.c | 38 +

[dpdk-dev] [PATCH v2 1/5] ethdev: add support of NIC reset

2017-06-27 Thread Wei Dai
A DPDK application can reset a NIC and keep its port id afterwards. It means that all SW resources allocated in ethdev layer should be kept and SW and HW resources of the NIC in PMD need to be reset in similar way that it runs PCI dev_uninit() and then dev_init(). The sequence of dev_uninit() and

[dpdk-dev] [PATCH v2 0/5] Support NIC reset and keep same port id

2017-06-27 Thread Wei Dai
Sometimes a port have to be reset. After reset, if the port goes through PCI remove() and then PCI probe() for restoration, its port id may be changed and this is not expected by some customer DPDK application. Normally, PCI probe() includes two parts: one is in rte_ethdev layer and the other is c

Re: [dpdk-dev] [PATCH v2] net/tap: restore state of remote device when closing

2017-06-27 Thread Pascal Mazon
Hi, Looks good to me. Acked-by: Pascal Mazon On 06/27/2017 02:33 PM, Thomas Monjalon wrote: When exiting a DPDK application, the TAP remote was left with the link down even if it was initially up. The device flags of the remote netdevice are saved when probing, and restored when calling the

[dpdk-dev] [PATCH v4 17/17] net/i40e/base: update base code info

2017-06-27 Thread Jingjing Wu
Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/README b/drivers/net/i40e/base/README index 0da9f67..59e76c2 100644 --- a/drivers/net/i40e/base/README +++ b/drivers/net/i40e/base/README @@ -34,7

Re: [dpdk-dev] [PATCH v5 00/12] bus: attach / detach API

2017-06-27 Thread Bruce Richardson
On Mon, Jun 26, 2017 at 02:21:58AM +0200, Gaetan Rivet wrote: > Following the work from Jan: > > This patchset introduces the attach / detach API to rte_bus. > The rte_device structure is used as the generic device representation. > > This API is implemented for the virtual bus. > The functions r

[dpdk-dev] [PATCH v4 16/17] net/i40e: use set switch aq instead of register setting

2017-06-27 Thread Jingjing Wu
TPID can be set by set_switch_config aq, change the TPID setting by set_switch_config on new FW release. Signed-off-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev.c | 102 + 1 file changed, 62 insertions(+), 40 deletions(-) diff --git a/drivers/net/i40e

[dpdk-dev] [PATCH v4 13/17] net/i40e/base: avoid reset timeout issue

2017-06-27 Thread Jingjing Wu
This patch allows detection of upcoming core reset in case NIC gets stuck while performing FLR reset. The i40e_pf_reset() function returns I40E_ERR_NOT_READY when global reset was detected. Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_common.c | 8 1 file changed, 8 inserti

[dpdk-dev] [PATCH v4 15/17] net/i40e/base: extend processing of DDP

2017-06-27 Thread Jingjing Wu
This patch adds extended processing of DDP packages: - Execution of adminq command sections to support AQ-depended profiles, for example, for programming cloud filters types. - Ability to write a profile without registering it in the list of applied profiles, to be used for AQ-depended prof

[dpdk-dev] [PATCH v4 11/17] net/i40e/base: use admin queue for setting LEDs behavior

2017-06-27 Thread Jingjing Wu
Instead of accessing register directly, use newly added AQC in order to blink LEDs. Introduce and utilize a new flag to prevent excessive API version checking. Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_adminq.c | 6 ++ drivers/net/i40e/base/i40e_common.c | 148 +

[dpdk-dev] [PATCH v4 12/17] net/i40e/base: avoid potential null pointer dereference

2017-06-27 Thread Jingjing Wu
Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c index 3f3b275..78ed2a8 100644 --- a/drivers/net/i40e/base/i40e_common.c +++ b/driver

[dpdk-dev] [PATCH v4 14/17] net/i40e/base: add EEPROM checksum verification

2017-06-27 Thread Jingjing Wu
This patch ensures PFs mutually exclusive access to NVM. Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_nvm.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i40e_nvm.c index 90521fa..a1e7830

[dpdk-dev] [PATCH v4 10/17] net/i40e/base: add support for switch parameters

2017-06-27 Thread Jingjing Wu
Adds double VLAN tagging ethertype fields to Set Switch Parameters AQ command. These were added in firmware API 1.7. Callers of i40e_aq_set_switch_config() can specify the ethertypes to use by filling out the corresponding fields in struct i40e_hw. Signed-off-by: Jingjing Wu --- drivers/net/i4

[dpdk-dev] [PATCH v4 09/17] net/i40e/base: update FW AQ API version to 1.7

2017-06-27 Thread Jingjing Wu
Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_adminq_cmd.h | 10 +- drivers/net/i40e/base/i40e_common.c | 5 +++-- drivers/net/i40e/base/i40e_type.h | 4 3 files changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b

[dpdk-dev] [PATCH v4 08/17] net/i40e/base: track id can be 0

2017-06-27 Thread Jingjing Wu
track_id == 0 is valid for “read only” profiles when profile does not have any “write” commands. Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_common.c| 7 +-- drivers/net/i40e/base/i40e_prototype.h | 12 +++- 2 files changed, 8 insertions(+), 11 deletions(-) diff -

[dpdk-dev] [PATCH v4 07/17] net/i40e/base: report supported link modes

2017-06-27 Thread Jingjing Wu
Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_adminq_cmd.h | 22 +++--- drivers/net/i40e/base/i40e_common.c | 18 +++--- 2 files changed, 34 insertions(+), 6 deletions(-) diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40

[dpdk-dev] [PATCH v4 06/17] net/i40e/base: add new phy types for 25G AOC and ACC

2017-06-27 Thread Jingjing Wu
This patch adds new phy types for 25G Active Optical Cables (AOC) and Active Copper Cables (ACC) support. Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_adminq_cmd.h | 4 drivers/net/i40e/base/i40e_common.c | 2 ++ 2 files changed, 6 insertions(+) diff --git a/drivers/net/i4

[dpdk-dev] [PATCH v4 05/17] net/i40e/base: store the requested FEC information

2017-06-27 Thread Jingjing Wu
Store information about FEC modes, that were requested. It will be used in printing link status information function and this way there is no need to call admin queue there. Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_common.c | 4 drivers/net/i40e/base/i40e_type.h | 1 + 2

[dpdk-dev] [PATCH v4 04/17] net/i40e/base: add support for Adaptive Virtual Function

2017-06-27 Thread Jingjing Wu
Add device id define and mac_type assignment needed for Adaptive Virtual Function. Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_common.c | 1 + drivers/net/i40e/base/i40e_devids.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/ne

[dpdk-dev] [PATCH v4 02/17] net/i40e/base: sync nvmupdate command and adminq subtask

2017-06-27 Thread Jingjing Wu
During NVMupdate, state machine gets into unrecoverable state because i40e_clean_adminq_subtask can get scheduled after the admin queue command but before other state variables are updated. This patch adds locking around admin queue command and update of state variables so that adminq_subtask will

[dpdk-dev] [PATCH v4 03/17] net/i40e/base: add AQ command for read/write PHY registers

2017-06-27 Thread Jingjing Wu
This patch adds new additional command for accessing to PHY registers. Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_adminq_cmd.h | 18 + drivers/net/i40e/base/i40e_common.c | 70 + drivers/net/i40e/base/i40e_prototype.h | 9 + 3 file

[dpdk-dev] [PATCH v4 01/17] net/i40e/base: use new virtchnl header file

2017-06-27 Thread Jingjing Wu
Modify the necessary files to be compatible with the new virtchnl.h file instead of relying on i40e_virtchnl.h variant. This mostly changes references to VIRTCHNL_ variables by removing prefix of I40E_. Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_common.c| 24 +- drivers/net/i

[dpdk-dev] [PATCH v4 00/17] net/i40e: base code update

2017-06-27 Thread Jingjing Wu
v4 changes: - fix more checkpatch warnings v3 changes: - extra patch to update README - remove unnecessary code - fix checkpatch warning v2 changes: - fix compile issue - update from package from 2017.05.24 to 2017.06.23 i40e base code upate. The main changes are: - use virtchnl.h instead

Re: [dpdk-dev] [PATCH v5 12/12] eal: make virtual driver probe and remove take rte_vdev_device

2017-06-27 Thread Bruce Richardson
I'm also not sure about the commit title of this patch. It doesn't match my understanding of what the patch does. /Bruce On Mon, Jun 26, 2017 at 02:22:10AM +0200, Gaetan Rivet wrote: > From: Jan Blunck > > This is a preparation to embed the generic rte_device into the rte_eth_dev > also for vir

Re: [dpdk-dev] [PATCH v5 12/12] eal: make virtual driver probe and remove take rte_vdev_device

2017-06-27 Thread Bruce Richardson
On Mon, Jun 26, 2017 at 02:22:10AM +0200, Gaetan Rivet wrote: > From: Jan Blunck > > This is a preparation to embed the generic rte_device into the rte_eth_dev > also for virtual devices. > > Signed-off-by: Jan Blunck > Signed-off-by: Gaetan Rivet > --- > lib/librte_eal/common/eal_common_dev.

Re: [dpdk-dev] [PATCH v5 04/12] bus: add bus iterator to find a device

2017-06-27 Thread Bruce Richardson
On Mon, Jun 26, 2017 at 02:22:02AM +0200, Gaetan Rivet wrote: > From: Jan Blunck > > Signed-off-by: Jan Blunck > Signed-off-by: Gaetan Rivet > --- > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + > lib/librte_eal/common/eal_common_bus.c | 24 +++ > lib/lib

Re: [dpdk-dev] [PATCH v3 7/8] mk: sort object files when building deps lists

2017-06-27 Thread Thomas Monjalon
27/06/2017 12:43, Luca Boccassi: > On Tue, 2017-06-27 at 01:20 +0200, Thomas Monjalon wrote: > > 23/06/2017 20:41, lbocc...@brocade.com: > > > From: Luca Boccassi > > > > > > In order to achieve reproducible builds, always use the same > > > order when listing object files to build dependencies l

Re: [dpdk-dev] [PATCH v2 3/6] net/vmxnet3: Generate link-state change notifications

2017-06-27 Thread Ferruh Yigit
On 6/15/2017 1:16 PM, Charles (Chas) Williams wrote: > From: Robert Shearman > > Generate link-state change notifications by listening to interrupts > generated by the device. Make use of the existing > vmxnet3_process_events function that was compiled out, but change it > to call vmxnet3_dev_lin

Re: [dpdk-dev] [PATCH v5 11/12] pci: implement hotplug bus operation

2017-06-27 Thread Bruce Richardson
On Mon, Jun 26, 2017 at 02:22:09AM +0200, Gaetan Rivet wrote: > Signed-off-by: Gaetan Rivet > --- > lib/librte_eal/common/eal_common_pci.c | 44 > ++ > 1 file changed, 44 insertions(+) > > diff --git a/lib/librte_eal/common/eal_common_pci.c > b/lib/librte_eal/co

Re: [dpdk-dev] [PATCH v5 10/12] pci: implement find_device bus operation

2017-06-27 Thread Bruce Richardson
On Mon, Jun 26, 2017 at 02:22:08AM +0200, Gaetan Rivet wrote: > Signed-off-by: Gaetan Rivet > --- > lib/librte_eal/common/eal_common_pci.c | 13 + > 1 file changed, 13 insertions(+) > Acked-by: Bruce Richardson

[dpdk-dev] [PATCH v3 2/2] app/testpmd: enable ddp remove profile feature

2017-06-27 Thread Andrey Chilikin
New command 'ddp del (port) (profile_path)' removes previously loaded profile and deletes it from the list of the loaded profiles. Signed-off-by: Andrey Chilikin --- app/test-pmd/cmdline.c | 74 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 +

[dpdk-dev] [PATCH v3 0/2] net/i40e: extended list of operations for ddp processing

2017-06-27 Thread Andrey Chilikin
This patch adds two new operations for dynamic device personalisation: * remove already loaded profile and delete it from the list * write profile without registering it This patchset depends on: [PATCH v2 00/16] net/i40e: base code update http://dpdk.org/ml/archives/dev/2017-June/068732.html http

[dpdk-dev] [PATCH v3 1/2] net/i40e: extended list of operations for ddp processing

2017-06-27 Thread Andrey Chilikin
This patch adds ability to remove already loaded profile or write profile without registering it Signed-off-by: Andrey Chilikin --- drivers/net/i40e/rte_pmd_i40e.c | 87 + drivers/net/i40e/rte_pmd_i40e.h | 6 ++- 2 files changed, 66 insertions(+), 27 dele

[dpdk-dev] [PATCH v3 17/17] net/i40e/base: update base code info

2017-06-27 Thread Jingjing Wu
Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/README b/drivers/net/i40e/base/README index 0da9f67..59e76c2 100644 --- a/drivers/net/i40e/base/README +++ b/drivers/net/i40e/base/README @@ -34,7

[dpdk-dev] [PATCH v3 15/17] net/i40e/base: extend processing of DDP

2017-06-27 Thread Jingjing Wu
This patch adds extended processing of DDP packages: - Execution of adminq command sections to support AQ-depended profiles, for example, for programming cloud filters types. - Ability to write a profile without registering it in the list of applied profiles, to be used for AQ-depended prof

[dpdk-dev] [PATCH v3 14/17] net/i40e/base: add EEPROM checksum verification

2017-06-27 Thread Jingjing Wu
This patch ensures PFs mutually exclusive access to NVM. Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_nvm.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i40e_nvm.c index 90521fa..a1e7830

[dpdk-dev] [PATCH v3 16/17] net/i40e: use set switch aq instead of register setting

2017-06-27 Thread Jingjing Wu
TPID can be set by set_switch_config aq, change the TPID setting by set_switch_config on new FW release. Signed-off-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev.c | 102 + 1 file changed, 62 insertions(+), 40 deletions(-) diff --git a/drivers/net/i40e

[dpdk-dev] [PATCH v3 12/17] net/i40e/base: avoid potential null pointer dereference

2017-06-27 Thread Jingjing Wu
Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c index 3f3b275..78ed2a8 100644 --- a/drivers/net/i40e/base/i40e_common.c +++ b/driver

[dpdk-dev] [PATCH v3 11/17] net/i40e/base: use admin queue for setting LEDs behavior

2017-06-27 Thread Jingjing Wu
Instead of accessing register directly, use newly added AQC in order to blink LEDs. Introduce and utilize a new flag to prevent excessive API version checking. Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_adminq.c | 6 ++ drivers/net/i40e/base/i40e_common.c | 148 +

  1   2   >