Re: [dpdk-dev] [PATCH 01/19] devtools: add simple script to find duplicate includes

12/07/2017 01:05, Stephen Hemminger: > On Tue, 11 Jul 2017 22:33:55 +0200 > Thomas Monjalon wrote: > > > Hi Stephen, > > > > 11/07/2017 20:55, Stephen Hemminger: > > > This is just a simple check script to find obvious duplications. > > > > > > Signed-off-by: Stephen Hemminger > > > --- > > >

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

> -Original Message- > From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] > Sent: Friday, July 7, 2017 7:14 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh; Gregory Etelson; Thomas Monjalon; Stephen Hemminger; > Tan, Jianfeng; Lu, Wenzhuo > Subject: [PATCH v2] igb_uio: issue FLR

Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file

> -Original Message- > From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] > Sent: Monday, July 10, 2017 6:43 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; Yigit, Ferruh; Gregory Etelson; Thomas Monjalon; > Stephen Hemminger; Lu, Wenzhuo > Subject: Re: [PATCH v2] igb_uio: issue

Re: [dpdk-dev] [RFC] pci: force address of mappings in secondary process

> -Original Message- > From: Gonzalez Monroy, Sergio > Sent: Tuesday, July 11, 2017 7:36 PM > To: Tan, Jianfeng; Stephen Hemminger; dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC] pci: force address of mappings in secondary > process > > On 11/07/2017 02:56, Tan, Jianfeng wrote: > >> -O

Re: [dpdk-dev] [PATCH] vhost: fix vhost-user init failed

This is needed for RC2 as lots of test cases are affected. Thanks & Regards, Yu Liu -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jens Freimann Sent: Monday, July 10, 2017 5:48 PM To: Yang, Zhiyong Cc: dev@dpdk.org; y...@fridaylinux.org; maxime.coque...@redhat.c

Re: [dpdk-dev] [PATCH v3] test: add delay time in test alarm

> > > > -Original Message- > > From: Yang, Qiming > > Sent: Tuesday, June 20, 2017 11:24 AM > > To: dev@dpdk.org > > Cc: Chen, Jing D ; Wu, Jingjing > > ; Yang, Qiming > > Subject: [PATCH v3] test: add delay time in test alarm > > > > Because accuracy of timing to the microsecond is not g

[dpdk-dev] [PATCH v9 11/11] net/failsafe: support flow API isolation mode

Signed-off-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_ether.c | 34 +++-- drivers/net/failsafe/failsafe_flow.c| 29 drivers/net/failsafe/failsafe_private.h | 4 3 files changed, 65 insertions(+), 2 deletions(-) diff --g

[dpdk-dev] [PATCH v9 09/11] net/failsafe: support device removal

Listen to INTR_RMV events issued by slaves. Add atomic flags on slave queues to detect use of slave bursts function. If a removal is detected, set the recollection flag on this slave. During a slave upkeep round, if its recollection flag is set and its burst functions are not in use by any thread,

[dpdk-dev] [PATCH v9 08/11] net/failsafe: add fast burst functions

Signed-off-by: Gaetan Rivet Acked-by: Olga Shern --- drivers/net/failsafe/failsafe_private.h | 8 +++ drivers/net/failsafe/failsafe_rxtx.c| 124 ++-- 2 files changed, 112 insertions(+), 20 deletions(-) diff --git a/drivers/net/failsafe/failsafe_private.h b/dri

[dpdk-dev] [PATCH v9 10/11] net/failsafe: support link status change event

Signed-off-by: Gaetan Rivet --- doc/guides/nics/features/failsafe.ini | 1 + drivers/net/failsafe/failsafe.c | 1 + drivers/net/failsafe/failsafe_ether.c | 18 ++ drivers/net/failsafe/failsafe_ops.c | 23 +++ drivers/net/failsafe/failsafe_priv

[dpdk-dev] [PATCH v9 07/11] net/failsafe: support offload capabilities

Signed-off-by: Gaetan Rivet Acked-by: Olga Shern --- doc/guides/nics/features/failsafe.ini | 6 ++ drivers/net/failsafe/failsafe_ops.c | 131 +- 2 files changed, 135 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/features/failsafe.ini b/doc/guide

[dpdk-dev] [PATCH v9 05/11] net/failsafe: add flexible device definition

Add the "exec" device type. The parameters given to this type of device will be executed in a shell. The output of this command is then used as a definition for a device. That command can be re-interpreted if the related device is not plugged-in. It allows for a device definition to react to syste

[dpdk-dev] [PATCH v9 04/11] net/failsafe: add plug-in support

Periodically check for the existence of a device. If a device has not been initialized and exists on the system, then it is probed and configured. The configuration process strives to synchronize the states between the plugged-in sub-device and the fail-safe device. Signed-off-by: Gaetan Rivet A

[dpdk-dev] [PATCH v9 03/11] net/failsafe: add fail-safe PMD

Introduce the fail-safe poll mode driver initialization and enable its build infrastructure. This PMD allows for applications to benefit from true hot-plugging support without having to implement it. It intercepts and manages Ethernet device removal events issued by slave PMDs and re-initializes

[dpdk-dev] [PATCH v9 06/11] net/failsafe: support flow API

Signed-off-by: Gaetan Rivet Acked-by: Olga Shern --- doc/guides/nics/features/failsafe.ini | 1 + drivers/net/failsafe/Makefile | 1 + drivers/net/failsafe/failsafe.c | 1 + drivers/net/failsafe/failsafe_eal.c | 1 + drivers/net/failsafe/failsafe_ether.c | 70 +

[dpdk-dev] [PATCH v9 02/11] ethdev: count devices consistently

Make the rte_eth_dev_count() return the number of available devices even after some are detached by the hotplug API or put in a deferred state. Signed-off-by: Gaetan Rivet --- lib/librte_ether/rte_ethdev.c | 16 +--- lib/librte_ether/rte_ethdev.h | 13 ++--- 2 files changed,

[dpdk-dev] [PATCH v9 01/11] ethdev: add deferred intermediate device state

This device state means that the device is managed externally, by whichever party has set this state (PMD or application). Note: this new device state is only an information. The related device structure and operators are still valid and can be used normally. It is however made private by device

[dpdk-dev] [PATCH v9 00/11] introduce fail-safe PMD

This PMD intercepts and manages Ethernet device removal events issued by slave PMDs and re-initializes them transparently when brought back so that existing applications do not need to be modified to benefit from true hot-plugging support. The stacked PMD approach shares many similarities with the

[dpdk-dev] [PATCH v3 5/8] pci: use given name as generic name

When an application requests the use of a PCI device, it can currently interchangeably use either the longform DomBDF format (:00:00.0) or the shorter BDF format (00:00.0). When a device is inserted via the hotplug API, it must first be scanned and then will be identified by its name using `fi

[dpdk-dev] [PATCH v3 8/8] bus: remove useless plug parameter

The prior scan should link the relevant rte_devargs to the newly allocated rte_device. As such, it is useless to pass device arguments to the plug callback. Those arguments are available within the devargs field of the rte_device structure. Fixes: 7c8810f43f6e ("bus: introduce device plug/unplug")

[dpdk-dev] [PATCH v3 7/8] pci: fix hotplug operations

The device handle is already known and does not have to be infered from the PCI address. The relevant helpers are already available within the PCI bus to avoid searching for a handle already known. Additionally, rte_memcpy.h was erroneously included. Fixes: 00e62aae69c0 ("bus/pci: implement plug/

[dpdk-dev] [PATCH v3 6/8] pci: fix generic driver pointer on probe error

The field is set but never resetted on error. This marks the device as being attached while it is not, and forbid further attempts to hotplug it. Fixes: 7917d5f5ea46 ("pci: initialize generic driver pointer") Cc: sta...@dpdk.org Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_p

[dpdk-dev] [PATCH v3 4/8] eal: fix hotplug add / remove

The hotplug API requires a few properties that were not previously explicitly enforced: - Idempotency, two consecutive scans should result in the same state. - Upon returning, internal devices are now allocated and available through the new `find_device` operator, meaning that they should

[dpdk-dev] [PATCH v3 3/8] devargs: introduce insert function

Some buses will operate either in whitelist or blacklist mode. This mode is currently passed down by the rte_eal_devargs_add function with the devtype argument. When inserting devices using the hotplug API, the implicit assumption is that this device is being whitelisted, meaning that it is explic

[dpdk-dev] [PATCH v3 2/8] devargs: introduce removal function

Hotplug support introduces the possibility of removing devices from the system. Allocated resources must be freed. Extend the rte_devargs API to allow freeing allocated resources. This API is experimental and bound to change. It is currently designed as a symetrical to rte_eal_devargs_add(), but

[dpdk-dev] [PATCH v3 0/8] fix hotplug API

Sending those fixes as separate patches as they stand on their own. This series improves usability of the hotplug API and fixes a few issues with existing implementations. The hotplug API can be tested with the fail-safe PMD[1]. Its documentation describes how to declare slaves and how to use it.

[dpdk-dev] [PATCH v3 1/8] vdev: implement plug operation

This method must be implemented to allow using a unified, generic API to hotplug devices, including virtual ones. VDEV devices actually exist unattached after performing a scan on the rte_devargs list. As such it makes sense to be able to perform a device hotplug afterward. Finally, missing this

[dpdk-dev] [PATCH 13/13] devargs: remove bus field

This removes the enum rte_bus field ``bus`` from struct rte_devargs. Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_vdev.c | 1 - lib/librte_eal/common/include/rte_devargs.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/l

[dpdk-dev] [PATCH 12/13] devargs: remove type field

This removes the enum rte_devtype field ``type`` from struct rte_devargs. Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_vdev.c | 1 - lib/librte_eal/common/include/rte_devargs.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/

[dpdk-dev] [PATCH 08/13] devargs: use busname

This makes the devargs code itself require the rte_devargs type field for properly functioning. Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_devargs.c | 42 ++ 1 file changed, 26 insertions(+), 16 deletions(-) diff --git a/lib/librte_eal/common/eal_

[dpdk-dev] [PATCH 11/13] vdev: use busname

Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_vdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index ff6a3b571..d04015582 100644 --- a/lib/librte_eal/common/eal_common_vde

[dpdk-dev] [PATCH 09/13] devargs: parse "bus=" argument

Let the rte_eal_devargs_parse() function parse the "bus=" argument. Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_devargs.c | 131 ++--- test/test/test_devargs.c | 19 + 2 files changed, 102 insertions(+), 48 deletions(-) diff --gi

[dpdk-dev] [PATCH 10/13] pci: use busname

Signed-off-by: Jan Blunck --- drivers/net/virtio/virtio_pci.c| 3 +-- lib/librte_eal/common/eal_common_pci.c | 9 + 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c index e6eda75b6..a81322969 100644 --

[dpdk-dev] [PATCH 07/13] devargs: add busname string field

This adds the busname as a string to struct rte_devargs. The function rte_eal_devargs_add() is adding the busname based on the devtype which is ok for now since the function is deprecated anyway. As a side-effect this is also no longer validating the PCI device name. This was done only for PCI dev

[dpdk-dev] [PATCH 06/13] devargs: use bus configuration interface to set scanning mode

Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_devargs.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c index 92c77c30e..691538095 100644

[dpdk-dev] [PATCH 04/13] pci: use scan_mode configuration

When scanning/probing devices the bus should use its configuration instead of looking at the devargs->type field. Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_pci.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/common/eal_common_pci.c

[dpdk-dev] [PATCH 05/13] bus: add configuration interface for buses

Signed-off-by: Jan Blunck --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 16 lib/librte_eal/common/include/rte_bus.h | 9 + lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 + 4 files changed, 27

[dpdk-dev] [PATCH 02/13] devargs: fix unittest

Since the scan-mode of the bus is now based on the bus configuration it isn't possible to have blacklisted and whitelisted devices existing for the same bus. This fixes the unittest to reflect that. Signed-off-by: Jan Blunck --- test/test/test_devargs.c | 8 +--- 1 file changed, 5 insertions

[dpdk-dev] [PATCH 03/13] devargs: deprecate enum rte_devtype based functions

The enum rte_devtype will need to get extended every time we add a bus. Mark all related functions as deprecated for 17.11. Signed-off-by: Jan Blunck --- doc/guides/rel_notes/deprecation.rst| 7 +++ lib/librte_eal/common/include/rte_devargs.h | 3 +++ 2 files changed, 10 insertions(+

[dpdk-dev] [PATCH 00/13] devargs fixes

The changes to enum rte_devtype that got merged into 17.08-rc1 are breaking API without prior notice. This series is reworking the rte_devargs changes in a way hopefully compliant to the new failover PMD and still keeping API compatible with earlier releases. Jan Blunck (13): Revert "devargs: ma

[dpdk-dev] [PATCH 01/13] Revert "devargs: make device types generic"

This (partially) reverts commit bd279a79366f50a4893fb84db91bbf64b56f9fb1. --- lib/librte_eal/common/eal_common_devargs.c | 4 ++-- lib/librte_eal/common/eal_common_options.c | 6 ++--- lib/librte_eal/common/eal_common_pci.c | 4 ++-- lib/librte_eal/common/eal_common_vdev.c | 1 + li

Re: [dpdk-dev] [PATCH] lib/rib: Add Routing Information Base library

Thanks, I'll change it. 2017-07-11 23:28 GMT+03:00 Stephen Hemminger : > On Tue, 11 Jul 2017 19:33:05 + > Medvedkin Vladimir wrote: > > > + > > +#define ROUNDUP(x, y) x - 1) >> (32 - y)) + 1) << (32 - y)) > > There is already RTE_ALIGN_FLOOR/RTE_ALIGN_CEIL > > > > +#define RTE_DIR24_8_

[dpdk-dev] [PATCH v2 3/3] vdev: allocate empty str args

Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_vdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index 5abdba091..e00dda9aa 100644 --- a/lib/librte_eal/common/eal_common_vdev.c +++ b/lib/

[dpdk-dev] [PATCH v2 1/3] vdev: get name from embedded device

Instead of getting the name from the devargs lets take it from the rte_device. Signed-off-by: Jan Blunck --- lib/librte_eal/common/include/rte_vdev.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/common/include/rte_vdev.h b/lib/librte_eal/common/include/

[dpdk-dev] [PATCH v2 2/3] vdev: directly use rte_bus reference

It isn't necessary to use rte_bus_find_by_name() to find a reference to our own bus. Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_vdev.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common

[dpdk-dev] [PATCH v2 0/3] vdev patches for -rc2

Three trivial vdev patches for -rc2. Please review and apply. Changes since v0: - Fix review comments by Gaetan Jan Blunck (3): vdev: get name from embedded device vdev: directly use rte_bus reference vdev: allocate empty str args lib/librte_eal/common/eal_common_vdev.c | 11 +++

Re: [dpdk-dev] [RFC] Add RIB library

Actually that is vendor specific. For example Juniper takes all route information from protocol specific tables and compiles it in rib (yes, they call it rib) so-called inet.0 (for ipv4 default VRF). In general RIB contains control plane information and is used for control plane purpose such as fib

Re: [dpdk-dev] [PATCH 01/19] devtools: add simple script to find duplicate includes

On Tue, 11 Jul 2017 22:33:55 +0200 Thomas Monjalon wrote: > Hi Stephen, > > 11/07/2017 20:55, Stephen Hemminger: > > This is just a simple check script to find obvious duplications. > > > > Signed-off-by: Stephen Hemminger > > --- > > devtools/dup_include.pl | 64 > >

Re: [dpdk-dev] [PATCH v8 03/11] net/failsafe: add fail-safe PMD

On Wed, Jul 12, 2017 at 12:21:24AM +0200, Thomas Monjalon wrote: > 11/07/2017 23:48, Gaëtan Rivet: > > On Tue, Jul 11, 2017 at 09:57:51PM +0200, Thomas Monjalon wrote: > > > 11/07/2017 01:19, Gaetan Rivet: > > > > --- /dev/null > > > > +++ b/drivers/net/failsafe/failsafe_args.c > > > [...] > > > >

Re: [dpdk-dev] [PATCH v8 03/11] net/failsafe: add fail-safe PMD

11/07/2017 23:48, Gaëtan Rivet: > On Tue, Jul 11, 2017 at 09:57:51PM +0200, Thomas Monjalon wrote: > > 11/07/2017 01:19, Gaetan Rivet: > > > --- /dev/null > > > +++ b/drivers/net/failsafe/failsafe_args.c > > [...] > > > +#include > > > > Do you really need errno in this file? > > It's used for e

Re: [dpdk-dev] [PATCH v2 4/8] eal: fix hotplug add / remove

11/07/2017 01:19, Gaetan Rivet: > New device should be represented by an rte_devargs prior to being > plugged. Why this assumption? Please start by stated the issue to solve. > Device parameters are available to rte_devices via their devargs field. > This field should be set up as soon as possibl

Re: [dpdk-dev] [PATCH v2 3/8] devargs: introduce insert function

11/07/2017 01:19, Gaetan Rivet: > This new function expects a fully-formed rte_devargs, previously parsed > and allocated. > > It does not check whether the new rte_devargs is compatible with current > bus configuration, but will replace any eventual existing one for the same > device. Please exp

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 5/8] pci: use given name as generic name

11/07/2017 01:19, Gaetan Rivet: > The PCI device is referenced by other DPDK systems by the name of its > parameter, not by the system name. I don't understand this sentence. Please give an example. > Moreover, this name should be set once and for all, as early as > possible. This means linking t

Re: [dpdk-dev] [PATCH v8 03/11] net/failsafe: add fail-safe PMD

On Tue, Jul 11, 2017 at 09:57:51PM +0200, Thomas Monjalon wrote: > 11/07/2017 01:19, Gaetan Rivet: > > --- /dev/null > > +++ b/drivers/net/failsafe/failsafe_args.c > [...] > > +#include > > Do you really need errno in this file? It's used for error handling on strtoull and popen. Why, is it a pr

Re: [dpdk-dev] [PATCH 01/19] devtools: add simple script to find duplicate includes

Hi Stephen, 11/07/2017 20:55, Stephen Hemminger: > This is just a simple check script to find obvious duplications. > > Signed-off-by: Stephen Hemminger > --- > devtools/dup_include.pl | 64 > + > 1 file changed, 64 insertions(+) > create mode 1

Re: [dpdk-dev] [RFC] Add RIB library

On Tue, 11 Jul 2017 19:33:04 + Medvedkin Vladimir wrote: > Hi, > > I want to introduce new library for ip routing lookup that have some > advantages > over current LPM library. In short: > - Increases the speed of control plane operations against lpm such as >adding/deleting ro

Re: [dpdk-dev] [PATCH] lib/rib: Add Routing Information Base library

On Tue, 11 Jul 2017 19:33:05 + Medvedkin Vladimir wrote: > + > +#define ROUNDUP(x, y) x - 1) >> (32 - y)) + 1) << (32 - y)) There is already RTE_ALIGN_FLOOR/RTE_ALIGN_CEIL > +#define RTE_DIR24_8_GET_TBL24_P(fib, ip) \ > + ((void *)&((uint8_t *)fib->tbl24)[(ip

Re: [dpdk-dev] [RFC] pci: force address of mappings in secondary process

On Tue, 11 Jul 2017 12:35:39 +0100 Sergio Gonzalez Monroy wrote: > On 11/07/2017 02:56, Tan, Jianfeng wrote: > >> -Original Message- > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen > >> Hemminger > >> Sent: Tuesday, July 11, 2017 9:13 AM > >> To: dev@dpdk.org > >> Cc: St

Re: [dpdk-dev] [PATCH v8 03/11] net/failsafe: add fail-safe PMD

11/07/2017 01:19, Gaetan Rivet: > --- /dev/null > +++ b/drivers/net/failsafe/failsafe_args.c [...] > +#include Do you really need errno in this file?

Re: [dpdk-dev] [PATCH] net/i40e: fix VF Tx bytes

On Sat, 8 Jul 2017 15:54:25 -0400 Qi Zhang wrote: > CRC size on Tx path is not necessary to be excluded. > > Fixes: 98abce237ba7 ("net/i40e: fix VF statistics") > Cc: sta...@dpdk.org > > Signed-off-by: Qi Zhang > --- > drivers/net/i40e/i40e_ethdev.c | 3 --- > 1 file changed, 3 deletions(-)

Re: [dpdk-dev] [PATCH 2/2] vdev: directly use rte_bus reference

On Tue, Jul 11, 2017 at 3:09 PM, Gaëtan Rivet wrote: > Hi Jan, > > On Tue, Jul 11, 2017 at 02:56:49PM -0400, Jan Blunck wrote: >> It isn't necessary to use rte_bus_find_by_name() to find a reference to >> our own bus. >> >> Signed-off-by: Jan Blunck >> --- >> lib/librte_eal/common/eal_common_vde

Re: [dpdk-dev] [ovs-dev] [PATCH v2 0/4] rhel/fedora: non-root OvS out of the box

Aaron Conole writes: > Aaron Conole writes: > >> This series attempts to introduce the ability to start and use >> Open vSwitch 'out of the box' as a non-root user. It does this by >> modifying the service files to pass the recently introduced --ovs-user >> argument around, and by making some m

Re: [dpdk-dev] [PATCH 0/9] fix hotplug API

On Tue, Jul 11, 2017 at 03:07:02PM -0400, Jan Blunck wrote: > On Tue, Jul 11, 2017 at 12:02 PM, Gaëtan Rivet wrote: > > On Sun, Jul 09, 2017 at 04:19:05PM +0200, Thomas Monjalon wrote: > >> 09/07/2017 12:38, Jan Blunck: > >> > On Sat, Jul 8, 2017 at 9:45 PM, Gaetan Rivet > >> > wrote: > >> > > S

Re: [dpdk-dev] [PATCH 2/2] vdev: directly use rte_bus reference

Hi Jan, On Tue, Jul 11, 2017 at 02:56:49PM -0400, Jan Blunck wrote: > It isn't necessary to use rte_bus_find_by_name() to find a reference to > our own bus. > > Signed-off-by: Jan Blunck > --- > lib/librte_eal/common/eal_common_vdev.c | 9 + > 1 file changed, 5 insertions(+), 4 deletion

[dpdk-dev] [PATCH] lib/rib: Add Routing Information Base library

RIB is an alternative to current LPM library. It solves the following problems - Increases the speed of control plane operations against lpm such as adding/deleting routes - Adds abstraction from dataplane algorythms, so it is possible to add different ip route lookup algorythms such as DXR

[dpdk-dev] [RFC] Add RIB library

Hi, I want to introduce new library for ip routing lookup that have some advantages over current LPM library. In short: - Increases the speed of control plane operations against lpm such as adding/deleting routes - Adds abstraction from dataplane algorythms, so it is possible to a

[dpdk-dev] [PATCH 2/2] vdev: directly use rte_bus reference

It isn't necessary to use rte_bus_find_by_name() to find a reference to our own bus. Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_vdev.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common

[dpdk-dev] [PATCH 1/2] vdev: get name from embedded device

Instead of getting the name from the devargs lets take it from the rte_device. Signed-off-by: Jan Blunck --- lib/librte_eal/common/include/rte_vdev.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/common/include/rte_vdev.h b/lib/librte_eal/common/include/

[dpdk-dev] [PATCH 0/2] vdev patches for -rc2

Two trivial vdev patches for -rc2. Please review and apply. Jan Blunck (2): vdev: get name from embedded device vdev: directly use rte_bus reference lib/librte_eal/common/eal_common_vdev.c | 9 + lib/librte_eal/common/include/rte_vdev.h | 4 ++-- 2 files changed, 7 insertions(+), 6

[dpdk-dev] [PATCH 19/19] test/test: remove duplicate includes

Signed-off-by: Stephen Hemminger --- test/test/test_alarm.c| 1 - test/test/test_atomic.c | 1 - test/test/test_eal_flags.c| 1 - test/test/test_malloc.c | 1 - test/test/test_mbuf.c | 1 - test/test/test_mp_secondary.c | 4 test/test/test_per_lcore.c| 1 -

[dpdk-dev] [PATCH 18/19] test/test-pipeline: remove duplicate include of rte_per_lcore.h

Signed-off-by: Stephen Hemminger --- test/test-pipeline/config.c | 1 - test/test-pipeline/init.c| 1 - test/test-pipeline/main.c| 1 - test/test-pipeline/runtime.c | 2 -- 4 files changed, 5 deletions(-) diff --git a/test/test-pipeline/config.c b/test/test-pipeline/config.c index 1b397

[dpdk-dev] [PATCH 17/19] app/test-pmd: remove duplicate includes

Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c| 1 - app/test-pmd/config.c | 1 - app/test-pmd/csumonly.c | 2 -- app/test-pmd/flowgen.c| 1 - app/test-pmd/iofwd.c | 1 - app/test-pmd/macfwd.c | 1 - app/test-pmd/macswap.c| 1 - app/test-pmd/parameters.c |

[dpdk-dev] [PATCH 15/19] fsmlc: remove duplicated includes

Signed-off-by: Stephen Hemminger --- drivers/bus/fslmc/fslmc_vfio.c | 2 -- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfio.c index 725faabab312..e10443c5bc05 100644 --- a/drivers

[dpdk-dev] [PATCH 14/19] dpaa2: remove duplicated includes

Signed-off-by: Stephen Hemminger --- drivers/event/dpaa2/dpaa2_eventdev.c | 1 - drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 1 - drivers/net/dpaa2/dpaa2_ethdev.c | 1 - drivers/net/dpaa2/dpaa2_rxtx.c | 1 - 4 files changed, 4 deletions(-) diff --git a/drivers/event/dpaa2/dp

[dpdk-dev] [PATCH 16/19] app/proc-info: remove duplicate include

Signed-off-by: Stephen Hemminger --- app/proc_info/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/app/proc_info/main.c b/app/proc_info/main.c index d4f6a8236e3f..8b753a2ee01b 100644 --- a/app/proc_info/main.c +++ b/app/proc_info/main.c @@ -53,7 +53,6 @@ #include #include #include

[dpdk-dev] [PATCH 13/19] vmxnet3: remove duplicated include of rte_atomic.h

Signed-off-by: Stephen Hemminger --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index 72ec67c01cdd..ab5a824c8b91 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++ b/driver

[dpdk-dev] [PATCH 09/19] ixgbe: remove duplicate include of rte_atomic.h

Signed-off-by: Stephen Hemminger --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 - drivers/net/ixgbe/ixgbe_flow.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index a0ae089c5118..6bc9146d8f4d 100644 --- a/drivers/net/ixgbe/ix

[dpdk-dev] [PATCH 12/19] cxgbe: remove duplicated includes

Signed-off-by: Stephen Hemminger --- drivers/net/cxgbe/cxgbe_ethdev.c | 1 - drivers/net/cxgbe/cxgbe_main.c | 1 - drivers/net/cxgbe/sge.c | 1 - 3 files changed, 3 deletions(-) diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c index 981dd478e5a8..7bca45

[dpdk-dev] [PATCH 11/19] virtio: remove duplicated includes

Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 1 - drivers/net/virtio/virtio_user_ethdev.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c i

[dpdk-dev] [PATCH 10/19] i40e: remove duplicate include of rte_atomic.h

Signed-off-by: Stephen Hemminger --- drivers/net/i40e/i40e_ethdev_vf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index bab09f814215..dc6c79449d14 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i

[dpdk-dev] [PATCH 08/19] bnxt: remove duplicate include of unistd.h

Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/bnxt_hwrm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index da078f9edfa8..3583ec732ded 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -33,8

[dpdk-dev] [PATCH 07/19] timer: remove duplicate include of rte_per_lcore.h

Signed-off-by: Stephen Hemminger --- lib/librte_timer/rte_timer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c index dda9baf5506d..5ee084080060 100644 --- a/lib/librte_timer/rte_timer.c +++ b/lib/librte_timer/rte_timer.c @@ -46,7 +

[dpdk-dev] [PATCH 06/19] cuckoo_hash: remove duplicate include of rte_log.h

Signed-off-by: Stephen Hemminger --- lib/librte_hash/rte_cuckoo_hash.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_hash/rte_cuckoo_hash.c b/lib/librte_hash/rte_cuckoo_hash.c index 5b2b8ddeb098..87b25c016a71 100644 --- a/lib/librte_hash/rte_cuckoo_hash.c +++ b/lib/librte_hash/rt

[dpdk-dev] [PATCH 05/19] lpm: remove duplicate include of errno.h

Signed-off-by: Stephen Hemminger --- lib/librte_lpm/rte_lpm.c | 1 - lib/librte_lpm/rte_lpm6.c | 1 - 2 files changed, 2 deletions(-) diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c index 978ac6013ecf..64c074e987e9 100644 --- a/lib/librte_lpm/rte_lpm.c +++ b/lib/librte_lpm/rte_

[dpdk-dev] [PATCH 04/19] distributor: remove duplicate include of rte_compat.h

Signed-off-by: Stephen Hemminger --- lib/librte_distributor/rte_distributor.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_distributor/rte_distributor.c b/lib/librte_distributor/rte_distributor.c index c4e31b8c4245..20ba9ffbc84c 100644 --- a/lib/librte_distributor/rte_distributo

[dpdk-dev] [PATCH 02/19] eal: remove duplicate includes

Include files only need to be refrenced once per file. Signed-off-by: Stephen Hemminger --- lib/librte_eal/bsdapp/eal/eal.c | 2 -- lib/librte_eal/bsdapp/eal/eal_pci.c | 2 -- lib/librte_eal/bsdapp/eal/eal_thread.c | 1 - lib/librte_eal/common/eal_common_dev.c |

[dpdk-dev] [PATCH 03/19] cmdline: remove duplicate include of errno.h

Signed-off-by: Stephen Hemminger --- lib/librte_cmdline/cmdline_parse_etheraddr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_cmdline/cmdline_parse_etheraddr.c b/lib/librte_cmdline/cmdline_parse_etheraddr.c index dbfe4a613413..da02d2c9f8cb 100644 --- a/lib/librte_cmdline/cmdlin

[dpdk-dev] [PATCH 01/19] devtools: add simple script to find duplicate includes

This is just a simple check script to find obvious duplications. Signed-off-by: Stephen Hemminger --- devtools/dup_include.pl | 64 + 1 file changed, 64 insertions(+) create mode 100755 devtools/dup_include.pl diff --git a/devtools/dup_include.pl

[dpdk-dev] [PATCH 00/19] cleanup duplicate includes

Using a simple script (in first patch), discovered that there was lots of #include file sloppiness in DPDK. This patch series fixes everything but base drivers and examples. Stephen Hemminger (19): devtools: add simple script to find duplicate includes eal: remove duplicate includes cmdline

Re: [dpdk-dev] [pull-request] next-tm 17.08 pre-rc1

> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, July 10, 2017 5:58 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; jerin.ja...@caviumnetworks.com; > hemant.agra...@nxp.com; Singh, Jasvinder ; > Lu, Wenzhuo ; O'Driscoll, Tim > ; Glynn, Michael J

[dpdk-dev] [PATCH v3] ether: add support for vtune task tracing

From: Ilia Kurakin The patch adds tracing of loop iterations that yielded no packets in a DPDK application. It is using ITT task API: https://software.intel.com/en-us/node/544206 We suppose the flow of using this tracing would assume the user has ITT lib and header on machine and re-build DP

[dpdk-dev] [PATCH v3] The patch adds tracing of loop iterations that yielded no packets in a DPDK application. It is using ITT task API: https://software.intel.com/en-us/node/544206

From: Ilia Kurakin We suppose the flow of using this tracing would assume the user has ITT lib and header on machine and re-build DPDK with additional make parameters: make EXTRA_CFLAGS=-I EXTRA_LDLIBS="-L -littnotify" Signed-off-by: Ilia Kurakin --- -V2 change: ITT tasks co

[dpdk-dev] [PATCH] pci: fix level of scan debug log on BSD

Printing the number of scanned devices should be a debug log, not an error. Signed-off-by: Thomas Monjalon --- lib/librte_eal/bsdapp/eal/eal_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal/bsdapp/eal/eal_pci.c index

Re: [dpdk-dev] [RFC 0/7] ipsec inline

On 10/07/2017 8:35 AM, Boris Pismenny wrote: In this RFC we introduce a infrastructure for IPSec inline hardware offloading. This RFC introduces device capabilities, configuration API and data path processing. We also provide a comparison with a previous RFC posted on the list for this feature.

Re: [dpdk-dev] [PATCH v2 6/8] mbuf: use 2 bytes for port and nbsegments

> On Jul 11, 2017, at 10:23 AM, Morten Brørup > wrote: > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon >> Sent: Tuesday, July 11, 2017 5:06 PM >> To: Morten Brørup >> Cc: dev@dpdk.org; Wiles, Keith; Olivier Matz; Wang, Zhihong; Yuanhan >>

[dpdk-dev] : rx_no_dma_resources starts climbing on Intel 82599 SR-IOV ports

Hello All, Perhaps you can shade some light on an interesting problem we have. I am working with Intel 82599 NICs in a SR-IOV mode. After several hours of running traffic we checked port statistics on a host and saw that the counter rx_no_dma_resources began climbing on some ports. At that exac

Re: [dpdk-dev] [PATCH v2 6/8] mbuf: use 2 bytes for port and nbsegments

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, July 11, 2017 5:06 PM > To: Morten Brørup > Cc: dev@dpdk.org; Wiles, Keith; Olivier Matz; Wang, Zhihong; Yuanhan > Liu; Ananyev, Konstantin; Richardson, Bruce; Chilikin, Andrey; Jan

Re: [dpdk-dev] [PATCH v2 6/8] mbuf: use 2 bytes for port and nb segments

11/07/2017 15:30, Morten Brørup: > Morten Brørup wrote: > > Olivier Matz wrote: > > > As I said in a previous message, I think a good first step would be to > > > introduce a typedef for the port number: rte_eth_port_num_t. > > > It can still be uint8_t for now, and can be switched to 16 bits in on

Re: [dpdk-dev] DPAA2 build errors with GCC 7

On 7/11/2017 2:50 PM, Thomas Monjalon wrote: I see some compilation errors with DPAA2 target, using aarch64-linux-gnu-gcc 7.1.0: drivers/net/dpaa2/dpaa2_ethdev.c:1257:15: error: this statement may fall through [-Werror=implicit-fallthrough=] cfg.options &= ~DPNI_LINK_OPT_ASYM_PAUSE; drivers/

[dpdk-dev] [PATCH 8/8] drivers: add newline in RTE LOG usages in dpaa2

Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 46 +-- drivers/mempool/dpaa2/dpaa2_hw_mempool.c| 12 ++--- drivers/net/dpaa2/base/dpaa2_hw_dpni.c | 10 ++-- drivers/net/dpaa2/dpaa2_ethdev.c| 71 +++-- 4

  1   2   >