Re: [dpdk-dev] [PATCH] net/mlx5: change start pointer of compressed completion

2017-07-13 Thread Nélio Laranjeiro
On Wed, Jul 12, 2017 at 03:09:54PM -0700, Yongseok Koh wrote: > On a host having 128B cacheline size, some devices insert 64B padding in > each completion entry to avoid partial cacheline write by HW. But, as the > padding is ahead of completion data, casting a completion entry to > compressed mini

Re: [dpdk-dev] [PATCH v9 03/11] net/failsafe: add fail-safe PMD

2017-07-13 Thread Thomas Monjalon
12/07/2017 01:26, Gaetan Rivet: > Introduce the fail-safe poll mode driver initialization and enable its > build infrastructure. There are some assert() in this code. It does not compile: fatal error: use of GNU statement expression extension Please replace them with RTE_ASSERT (and remove

[dpdk-dev] [PATCH] test: fix the parameter issue of test case

2017-07-13 Thread Herbert Guan
When test case "test_balance_l23_tx_burst_ipv4_toggle_ip_addr" is calling balance_l23_tx_burst(), the ip_addr instead of mac_addr should be toggled according to the test name. Signed-off-by: Herbert Guan --- test/test/test_link_bonding.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [dpdk-dev] [PATCH] net/failsafe: do not probe device if plugged out

2017-07-13 Thread Gaëtan Rivet
On Thu, Jul 13, 2017 at 08:52:33AM +0200, Thomas Monjalon wrote: > 12/07/2017 22:39, Gaëtan Rivet: > > Hi Thomas, > > > > Nice idea. A few remarks below: > > > > On Wed, Jul 12, 2017 at 08:28:12PM +0200, Thomas Monjalon wrote: > > > FOREACH_SUBDEV(sdev, i, dev) { > > > if (sdev->state

Re: [dpdk-dev] [PATCH] vhost: fix vhost-user init failed

2017-07-13 Thread Yao, Lei A
> -Original Message- > From: Yang, Zhiyong > Sent: Monday, July 10, 2017 4:07 PM > To: dev@dpdk.org > Cc: y...@fridaylinux.org; maxime.coque...@redhat.com; Yao, Lei A > ; Yang, Zhiyong > Subject: [PATCH] vhost: fix vhost-user init failed > > Exception handling is executed in the normal

Re: [dpdk-dev] [PATCH v3 04/11] linuxapp/eal_pci: get iommu class

2017-07-13 Thread santosh
Hi Sergio, On Wednesday 12 July 2017 01:50 PM, Sergio Gonzalez Monroy wrote: > On 11/07/2017 07:16, Santosh Shukla wrote: >> Get iommu class of PCI device on the bus and returns preferred iova >> mapping mode for that bus. >> >> Algorithm for iova scheme selection for PCI bus: >> 0. Look for devi

Re: [dpdk-dev] [PATCH] test: fix the parameter issue of test case

2017-07-13 Thread Jianbo Liu
On 13 July 2017 at 16:00, Herbert Guan wrote: > When test case "test_balance_l23_tx_burst_ipv4_toggle_ip_addr" is > calling balance_l23_tx_burst(), the ip_addr instead of mac_addr > should be toggled according to the test name. > > Signed-off-by: Herbert Guan > --- > test/test/test_link_bonding.

[dpdk-dev] [PATCH] mempool: add notice to change mempool API/ABI

2017-07-13 Thread Santosh Shukla
An API/ABI change is planned for 17.11 to change following * Remove unused flag param from rte_mempool_generic_get and _put. * Change data type for mempool 'flag' from int to unsigned int. Refer [1]. * Add struct rte_mempool * param into func rte_mempool_xmem_size, rte_mempool_xmem_usage to ma

Re: [dpdk-dev] [PATCH] net/failsafe: do not probe device if plugged out

2017-07-13 Thread Thomas Monjalon
13/07/2017 10:14, Gaëtan Rivet: > On Thu, Jul 13, 2017 at 08:52:33AM +0200, Thomas Monjalon wrote: > > 12/07/2017 22:39, Gaëtan Rivet: > > > Hi Thomas, > > > > > > Nice idea. A few remarks below: > > > > > > On Wed, Jul 12, 2017 at 08:28:12PM +0200, Thomas Monjalon wrote: > > > > FOREACH_

[dpdk-dev] [PATCH v2 0/6] Infrastructure to support octeontx HW mempool manager

2017-07-13 Thread Santosh Shukla
v2: (Note: v2 work is based on deprecation notice [1], It's for 17.11) In order to support octeontx HW mempool manager, the common mempool layer must meet below condition. - Object start address should be block size (total elem size) aligned. - Object must have the physically contiguous address wi

[dpdk-dev] [PATCH v2 3/6] mempool: detect physical contiguous object in pool

2017-07-13 Thread Santosh Shukla
The memory area containing all the objects must be physically contiguous. Introducing MEMPOOL_F_CAPA_PHYS_CONTIG flag for such use-case. The flag useful to detect whether pool area has sufficient space to fit all objects. If not then return -ENOSPC. This way, we make sure that all object within a

[dpdk-dev] [PATCH v2 2/6] mempool: get the mempool capability

2017-07-13 Thread Santosh Shukla
Allow mempool to advertise its capability. A handler been introduced called rte_mempool_ops_get_capabilities. - Upon ->get_capabilities call, mempool driver will advertise capability by updating to 'mp->flags'. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- v1 -- v2: - Added RTE_FU

[dpdk-dev] [PATCH v2 4/6] mempool: add mempool arg in xmem size and usage

2017-07-13 Thread Santosh Shukla
xmem_size and xmem_usage need to know the status of mp->flag. Following patch will make use of that. Signed-off-by: Santosh Shukla --- v1 -- v2: - added new mempool param in xmem_size/usage, Per deprecation notice [1] and discussion based on thread [2] [1] http://dpdk.org/dev/patchwork/patch/268

[dpdk-dev] [PATCH v2 1/6] mempool: fix flags data type

2017-07-13 Thread Santosh Shukla
mp->flags is int and mempool API updates unsigned int value in 'flags', so fix the 'flags' data type. Patch also does mp->flags cleanup like: * Remove redundant 'flags' API description from - __rte_mempool_generic_put - __rte_mempool_generic_get * Remove unused 'flags' param from - rte_memp

[dpdk-dev] [PATCH v5 0/3] EAL change for using a config file for DPDK

2017-07-13 Thread Kuba Kozak
This patchset introduce a mechanism for running dpdk application with parameters provided by configuration file. A new API for EAL takes a config file data type - either loaded from file, or built up programmatically in the application - and extracts DPDK parameters from it to be used when eal in

[dpdk-dev] [PATCH v2 5/6] mempool: introduce block size align flag

2017-07-13 Thread Santosh Shukla
Some mempool hw like octeontx/fpa block, demands block size (/total_elem_sz) aligned object start address. Introducing an MEMPOOL_F_POOL_BLK_SZ_ALIGNED flag. If this flag is set: - Align object start address to a multiple of total_elt_sz. - Allocate one additional object. Additional object is need

[dpdk-dev] [PATCH v2 6/6] mempool: update range info to pool

2017-07-13 Thread Santosh Shukla
HW pool manager e.g. Octeontx SoC demands s/w to program start and end address of pool. Currently, there is no such handle in external mempool. Introducing rte_mempool_update_range handle which will let HW(pool manager) know when common layer selects hugepage: For each hugepage - update its start/e

Re: [dpdk-dev] [PATCH] ethdev: fix build with gcc 5.4.0

2017-07-13 Thread Thomas Monjalon
06/07/2017 23:45, Thomas Monjalon: > Seen on Ubuntu 16.04 with GCC 5.4.0: > > lib/librte_ether/rte_ethdev.c: In function 'get_mac_addr_index': > lib/librte_ether/rte_ethdev.c:2369:26: error: > 'dev_info.max_mac_addrs' may be used uninitialized in this function > > Indeed, rte_eth_dev_info_get() d

Re: [dpdk-dev] [PATCH 14/19] dpaa2: remove duplicated includes

2017-07-13 Thread Hemant Agrawal
On 7/12/2017 12:25 AM, Stephen Hemminger wrote: Signed-off-by: Stephen Hemminger --- drivers/event/dpaa2/dpaa2_eventdev.c | 1 - drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 1 - drivers/net/dpaa2/dpaa2_ethdev.c | 1 - drivers/net/dpaa2/dpaa2_rxtx.c | 1 - 4 files changed, 4

Re: [dpdk-dev] [PATCH 15/19] fsmlc: remove duplicated includes

2017-07-13 Thread Hemant Agrawal
On 7/12/2017 12:25 AM, Stephen Hemminger wrote: Signed-off-by: Stephen Hemminger --- drivers/bus/fslmc/fslmc_vfio.c | 2 -- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfio.c ind

[dpdk-dev] [PATCH 1/3] net/ixgbe: fix lsc interrupt

2017-07-13 Thread Jingjing Wu
If LSC flag is changed to off last device start, the enable flag is not cleared in HW. This patch fixes it. Fixes: 0eb609239efd ("ixgbe: enable Rx queue interrupts for PF and VF") Cc: sta...@dpdk.org Signed-off-by: Jingjing Wu --- drivers/net/ixgbe/ixgbe_ethdev.c | 15 +++ 1 file ch

[dpdk-dev] [PATCH 3/3] net/e1000: fix lsc interrupt

2017-07-13 Thread Jingjing Wu
If LSC flag is changed to off last device start, the enable flag is not cleared in HW. This patch fixes it. Fixes: c3cd3de0ab50 ("igb: enable Rx queue interrupts for PF") Cc: sta...@dpdk.org Signed-off-by: Jingjing Wu --- drivers/net/e1000/igb_ethdev.c | 15 +++ 1 file changed, 11 i

[dpdk-dev] [PATCH 2/3] net/i40e: fix lsc interrupt

2017-07-13 Thread Jingjing Wu
If LSC flag is changed to off last device start, the enable flag is not cleared in HW. This patch fixes it. Fixes: f4668a33efe5 ("net/i40e: fix link status change interrupt") Cc: sta...@dpdk.org Signed-off-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev.c | 4 ++-- 1 file changed, 2 insertions

[dpdk-dev] [PATCH] app/testpmd: fix bonding initialization due to unproper name

2017-07-13 Thread Michal Jastrzebski
when creating a bond device in testpmd, a name for a device must meet the correct convention described in the documentation: The device name must start with the net_bonding prefix followed by numbers or letters. Change for ALB mempool allocation - mem_name was too long. Fixes: 9bf4901d1a11 ("bus/v

Re: [dpdk-dev] [PATCH] app/testpmd: add flow isolate all parameter

2017-07-13 Thread Thomas Monjalon
10/07/2017 14:46, Adrien Mazarguil: > On Sun, Jul 09, 2017 at 11:08:05AM +0300, Vasily Philipov wrote: > > Providing this parameter requests flow API isolated mode on all ports at > > initialization time. It ensures all traffic is received through the > > configured flow rules only (see flow comman

[dpdk-dev] [PATCH v5 0/3] EAL change for using a config file for DPDK

2017-07-13 Thread Kuba Kozak
This patchset introduce a mechanism for running dpdk application with parameters provided by configuration file. A new API for EAL takes a config file data type - either loaded from file, or built up programmatically in the application - and extracts DPDK parameters from it to be used when eal in

[dpdk-dev] [PATCH v5 1/3] eal: add functions parsing EAL arguments

2017-07-13 Thread Kuba Kozak
added function rte_eal_configure which configure Environment Abstraction Layer (EAL) using configuration structure. Signed-off-by: Kuba Kozak Suggested-by: Bruce Richardson --- lib/Makefile| 3 + lib/librte_eal/bsdapp/eal/Makefile | 4 + lib/

[dpdk-dev] [PATCH v5 3/3] app/testpmd: add parse options from JSON cfg file

2017-07-13 Thread Kuba Kozak
This patch shows usage of Jansson library to parse application arguments from JSON config file. https://github.com/akheron/jansson If a --cfgfile-path option is passed into commandline non EAL section, then the disired JSON file is loaded and used by app. In case when JSON doesn't exist an INI f

[dpdk-dev] [PATCH v5 2/3] app/testpmd: add parse options from cfg file

2017-07-13 Thread Kuba Kozak
This patch shows how to pass arguments to application using config.ini file. If a --cfgfile-path option is passed into commandline non EAL section, then the file is loaded and used by app. If a config.ini file is present in current working directory, and no --cfgfile-path option is passed in, co

[dpdk-dev] [PATCH] eal: disable NUMA related warnings on non-NUMA systems

2017-07-13 Thread Hemant Agrawal
Disabling NUMA warnings on non-NUMA systems. "EAL: eal_parse_sysfs_value(): cannot open sysfs value /sys/bus/pci/devices/:00:00.0/numa_node EAL: numa_node is invalid or not present. Set it 0 as default EAL: cannot open /proc/self/numa_maps, consider that all memory is in socket

[dpdk-dev] [PATCH] crypto/dpaa2_sec: fix the return of supported API

2017-07-13 Thread Akhil Goyal
call to dpaa2_sec_dev_configure() is made mandatory, but dpaa2_sec_pmd returns a ENOTSUP which results in device not getting configured. dpaa2_sec PMD does not need any further configuration to be done in dpaa2_sec_dev_configure, hence returning 0 Fixes: e5cbdfc53765 ("crypto/dpaa2_sec: add basic

Re: [dpdk-dev] [PATCH v3 07/11] linuxapp/eal: auto detect iova mode

2017-07-13 Thread Hemant Agrawal
On 7/11/2017 11:46 AM, Santosh Shukla wrote: - Moving late bus scanning to up..just after eal_parsing. - Auto detect iova mapping mode, based on the result of rte_bus_scan_iommu_class. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- lib/librte_eal/linuxapp/eal/eal.c | 16 ++

[dpdk-dev] [PATCH] crypto/aesni_mb: fix possible crypto job leak

2017-07-13 Thread Pablo de Lara
When dequeueing operations from an AESNI-MB device, crypto jobs are dequeued from the internal scheduler in the Multi-buffer library. If the number of jobs available to retrieve are higher than the number of crypto operations that are required, then an extra job is retrieved (due to an incorrect c

Re: [dpdk-dev] [PATCH v3 07/11] linuxapp/eal: auto detect iova mode

2017-07-13 Thread Hemant Agrawal
On 7/13/2017 4:59 PM, Hemant Agrawal wrote: On 7/11/2017 11:46 AM, Santosh Shukla wrote: - Moving late bus scanning to up..just after eal_parsing. - Auto detect iova mapping mode, based on the result of rte_bus_scan_iommu_class. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob ---

[dpdk-dev] [PATCH] eal: fslmc bus need vfio enabled for non PCI case as well

2017-07-13 Thread Hemant Agrawal
In case no_pci is configured, fslmc bus will still need the the vfio to be enabled. Signed-off-by: Hemant Agrawal --- lib/librte_eal/linuxapp/eal/eal.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index 7c78f2d.

Re: [dpdk-dev] [PATCH v3 ] ethdev: introduce lock-free txq capability flag

2017-07-13 Thread Hemant Agrawal
On 7/10/2017 10:29 PM, Jerin Jacob wrote: Introducing the DEV_TX_OFFLOAD_MT_LOCKFREE TX capability flag. if a PMD advertises DEV_TX_OFFLOAD_MT_LOCKFREE capable, multiple threads can invoke rte_eth_tx_burst() concurrently on the same tx queue without SW lock. This PMD feature will be useful in the

Re: [dpdk-dev] [PATCH 01/19] devtools: add simple script to find duplicate includes

2017-07-13 Thread Wiles, Keith
> On Jul 13, 2017, at 1:56 AM, Thomas Monjalon wrote: > > 12/07/2017 23:59, Stephen Hemminger: >> On Tue, 11 Jul 2017 22:33:55 +0200 >> Thomas Monjalon wrote: >> >>> Thank you for this script, but... it is written in Perl! >>> I don't think it is a good idea to add yet another language to DPDK

[dpdk-dev] [PATCH] crypto/qat: fix authentication offset and length for GMAC

2017-07-13 Thread Arek Kusztal
Authentication length and offset need to be set like for any other authentication algorithms as it no longer uses aad pointer Fixes: b79e4c00af0e ("cryptodev: use AES-GCM/CCM as AEAD algorithms") Signed-off-by: Arek Kusztal --- drivers/crypto/qat/qat_crypto.c | 7 ++- 1 file changed, 2 inse

Re: [dpdk-dev] [PATCH 01/19] devtools: add simple script to find duplicate includes

2017-07-13 Thread Thomas Monjalon
13/07/2017 14:19, Wiles, Keith: > > > On Jul 13, 2017, at 1:56 AM, Thomas Monjalon wrote: > > > > 12/07/2017 23:59, Stephen Hemminger: > >> On Tue, 11 Jul 2017 22:33:55 +0200 > >> Thomas Monjalon wrote: > >> > >>> Thank you for this script, but... it is written in Perl! > >>> I don't think it

Re: [dpdk-dev] [PATCH] cryptodev: deprecate rte_cryptodev_create_vdev()

2017-07-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: Jan Blunck [mailto:jblu...@gmail.com] On Behalf Of Jan Blunck > Sent: Wednesday, July 12, 2017 9:16 PM > To: dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > > Subject: [PATCH] cryptodev: deprecate rte_cryptodev_create_vdev() > > This function is

Re: [dpdk-dev] [PATCH] crypto/qat: fix authentication offset and length for GMAC

2017-07-13 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Thursday, July 13, 2017 1:35 PM > To: dev@dpdk.org > Cc: Trahe, Fiona ; De Lara Guarch, Pablo > ; > Griffin, John ; Jain, Deepak K > ; Kusztal, ArkadiuszX > > Subject: [PATCH] crypto/qat: fix authentication offset and length for

Re: [dpdk-dev] [PATCH 07/13] devargs: add busname string field

2017-07-13 Thread Gaëtan Rivet
On Tue, Jul 11, 2017 at 07:25:06PM -0400, Jan Blunck wrote: > This adds the busname as a string to struct rte_devargs. The function > rte_eal_devargs_add() is adding the busname based on the devtype which > is ok for now since the function is deprecated anyway. > > As a side-effect this is also no

Re: [dpdk-dev] [PATCH 1/3] net/ixgbe: fix lsc interrupt

2017-07-13 Thread Lu, Wenzhuo
Hi, -Original Message- From: Wu, Jingjing Sent: Thursday, July 13, 2017 5:43 AM To: Lu, Wenzhuo Cc: dev@dpdk.org; Wu, Jingjing ; sta...@dpdk.org Subject: [PATCH 1/3] net/ixgbe: fix lsc interrupt If LSC flag is changed to off last device start, the enable flag is not cleared in HW. This

Re: [dpdk-dev] [PATCH 3/3] net/e1000: fix lsc interrupt

2017-07-13 Thread Lu, Wenzhuo
Hi, -Original Message- From: Wu, Jingjing Sent: Thursday, July 13, 2017 5:43 AM To: Lu, Wenzhuo Cc: dev@dpdk.org; Wu, Jingjing ; sta...@dpdk.org Subject: [PATCH 3/3] net/e1000: fix lsc interrupt If LSC flag is changed to off last device start, the enable flag is not cleared in HW. This

[dpdk-dev] [PATCH 1/5] doc: fix supported algorithm table for AESNI GCM PMD

2017-07-13 Thread Pablo de Lara
AESNI GCM PMD now supports 192-bit keys for AES-GCM, so the supported algorithm table should be updated. Fixes: 6f16aab09a91 ("crypto/aesni_gcm: migrate to Multi-buffer library") Signed-off-by: Pablo de Lara --- doc/guides/cryptodevs/features/aesni_gcm.ini | 1 + 1 file changed, 1 insertion(+)

[dpdk-dev] [PATCH 0/5] Fix crypto PMDs documentation

2017-07-13 Thread Pablo de Lara
Patchset with some fixes/additions for crypto PMDs documents. Pablo de Lara (5): doc: fix supported algorithm table for AESNI GCM PMD doc: remove incorrect limitation on QAT PMD doc: remove incorrect limitation on AESNI MB PMD doc: add missing algorithm in limitations for QAT doc: extend

[dpdk-dev] [PATCH 2/5] doc: remove incorrect limitation on QAT PMD

2017-07-13 Thread Pablo de Lara
QAT supports authentication only operations, for any authentication algorithm (such as SHA1-HMAC), as long as it is supported by QAT, so it means that it is not necessary to create a chained operation in order to use these algorithms. Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices")

[dpdk-dev] [PATCH 3/5] doc: remove incorrect limitation on AESNI MB PMD

2017-07-13 Thread Pablo de Lara
AESNI MB PMD supports sessionless operations, but the documentation was stating that only operations with session were supported. Fixes: 924e84f87306 ("aesni_mb: add driver for multi buffer based crypto") CC: sta...@dpdk.org Signed-off-by: Pablo de Lara --- doc/guides/cryptodevs/aesni_mb.rst |

[dpdk-dev] [PATCH 4/5] doc: add missing algorithm in limitations for QAT

2017-07-13 Thread Pablo de Lara
For KASUMI, SNOW3G and ZUC algorithms, offsets and lengths of the data to cipher or authenticate is provided in bits, but QAT does not support non-byte aligned values, although only KASUMI and SNOW3G were mentioned. Fixes: d9b7d5bbc845 ("crypto/qat: add ZUC EEA3/EIA3 capability") Cc: sta...@dpdk.o

[dpdk-dev] [PATCH 5/5] doc: extend installation section on SNOW3G/KASUMI PMDs

2017-07-13 Thread Pablo de Lara
SNOW3G and KASUMI SW libraries encrypt buffers assuming that they are padded to a specific block size. This behaviour can be changed to avoid buffer overflow, by modifying the Makefile of these libraries. Therefore, the Installation section in the SNOW3G and KASUMI documentation has been extended,

Re: [dpdk-dev] [PATCH 09/13] devargs: parse "bus=" argument

2017-07-13 Thread Gaëtan Rivet
I still disagree with parsing the body of devargs to retrieve bus information. They should not be mixed. This conceptual discrepancy can be seen plainly in the code structure: you emulate librte_kvargs because you do not want to depend on it within the EAL, but copy its behavior and are forced to

[dpdk-dev] [PATCH] mempool/dpaa2: alloc pool data dynamically

2017-07-13 Thread Hemant Agrawal
In order to support multiprocess applications, pool data is to be allocated on dynamic memory instead of existing usages of global variable. Signed-off-by: Nipun Gupta --- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers

[dpdk-dev] [RFC] ethdev: add IF-MIB attributes implementation

2017-07-13 Thread Reshma Pattan
The RFC shows implementation of IF-MIB attributes in ethdev layer. These attributes are implemeted from the information available from rte_eth_dev_data struct. The new APIs are added, to allow applications to trigger IF-MIB attribute initialization and the implementation based on the port id. IF-M

[dpdk-dev] [PATCH] cryptodev: fix KASUMI F9 expected parameters

2017-07-13 Thread Pablo de Lara
For KASUMI F9 algorithm, COUNT, FRESH and DIRECTION input values need to be contiguous with the message, as described in the KASUMI and QAT PMD documentation. Before, the COUNT and FRESH values were set as part of the AAD (now IV), but always set before the beginning of the message. Since now the

Re: [dpdk-dev] [PATCH v2] doc: add missing devices in test-crypto-perf

2017-07-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Wednesday, July 12, 2017 5:17 PM > To: Akhil Goyal ; dev@dpdk.org > Cc: hemant.agra...@nxp.com; Doherty, Declan > > Subject: Re: [dpdk-dev] [PATCH v2] doc: add missing devices in t

Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix possible crypto job leak

2017-07-13 Thread Declan Doherty
On 13/07/2017 4:35 AM, Pablo de Lara wrote: When dequeueing operations from an AESNI-MB device, crypto jobs are dequeued from the internal scheduler in the Multi-buffer library. If the number of jobs available to retrieve are higher than the number of crypto operations that are required, then an

[dpdk-dev] [PATCH v7 0/5] Support NIC reset and keep same port id

2017-07-13 Thread Wei Dai
This patch set adds a function rte_eth_dev_reset( ) in rte_ethdev layer. Sometimes a port have to be reset passively. For example a PF is reset, all its VFs should also be reset by application itself to align with the PF. A DPDK application also can call this function to trigger an initative port

[dpdk-dev] [PATCH v7 1/5] ethdev: add support of NIC reset

2017-07-13 Thread Wei Dai
This patch adds a new eth_dev layer API function rte_eth_dev_reset(). A DPDK application can call this function to reset a NIC and keep its port id afterwards. It means that all SW resources allocated in ethdev layer should be kept and SW and HW resources of the NIC in PMD need to be reset in simil

[dpdk-dev] [PATCH v7 3/5] net/i40e: add support of reset

2017-07-13 Thread Wei Dai
Reset a NIC by calling dev_uninit() and then dev_init(). Go through the same way in NIC PCI remove without release of ethdev resource and then NIC PCI probe function without ethdev resource allocation. Signed-off-by: Wei Dai --- drivers/net/i40e/i40e_ethdev.c| 28

[dpdk-dev] [PATCH v7 5/5] doc: add description of the NIC reset API

2017-07-13 Thread Wei Dai
Signed-off-by: Wei Dai --- doc/guides/prog_guide/poll_mode_drv.rst | 40 + 1 file changed, 40 insertions(+) diff --git a/doc/guides/prog_guide/poll_mode_drv.rst b/doc/guides/prog_guide/poll_mode_drv.rst index 4987f70..60518fc 100644 --- a/doc/guides/prog_guide/po

[dpdk-dev] [PATCH v7 2/5] net/ixgbe: add support of reset

2017-07-13 Thread Wei Dai
Reset a NIC by calling dev_uninit and then dev_init. Go through same way in NIC PCI remove without release of ethdev resource and then NIC PCI probe function without ethdev resource allocation. Signed-off-by: Wei Dai --- drivers/net/ixgbe/ixgbe_ethdev.c | 47 +

[dpdk-dev] [PATCH v7 4/5] app/testpmd: enhance command to test NIC reset

2017-07-13 Thread Wei Dai
When PF is reset, a message will show it and all its VF need to be reset. User can run the command "port reset port_id" to reset the VF port and to keep same port id without any configuration. Then user can run "port stop port_id" and "port start port_id" to reconfigure its forwarding mode and parm

Re: [dpdk-dev] [PATCH v6 1/4] ethdev: add support of NIC reset

2017-07-13 Thread Dai, Wei
> > Subject: RE: [dpdk-dev] [PATCH v6 1/4] ethdev: add support of NIC > > reset > > > > > > > + * A DPDK application also can call this function to trigger an > > > + initative > > > + * port reset. > > > > When apart from the above use case? Even if it is above case, we should > have some event to

[dpdk-dev] [RFC v2] ethdev: add IF-MIB attributes implementation

2017-07-13 Thread Reshma Pattan
The RFC shows implementation of IF-MIB attributes in ethdev layer. These attributes are implemented from the information available from rte_eth_dev_data struct. The new APIs are added, to allow applications to trigger IF-MIB attribute initialization and the implementation based on the port id. IF-

Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix possible crypto job leak

2017-07-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: Doherty, Declan > Sent: Thursday, July 13, 2017 4:56 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH] crypto/aesni_mb: fix possible crypto job leak > > On 13/07/2017 4:35 AM, Pablo de Lara wrote: > > When dequeueing o

Re: [dpdk-dev] [PATCH 0/5] Fix crypto PMDs documentation

2017-07-13 Thread Declan Doherty
On 13/07/2017 6:36 AM, Pablo de Lara wrote: Patchset with some fixes/additions for crypto PMDs documents. Pablo de Lara (5): doc: fix supported algorithm table for AESNI GCM PMD doc: remove incorrect limitation on QAT PMD doc: remove incorrect limitation on AESNI MB PMD doc: add missing

Re: [dpdk-dev] [PATCH] cryptodev: remove AAD size in auth capabilities

2017-07-13 Thread Declan Doherty
On 11/07/2017 7:30 AM, Pablo de Lara wrote: Additional Authenticated Data (AAD) was removed from the authentication parameters, but still the supported size was part of the authentication capabilities of a PMD. Fixes: 4428eda8bb75 ("cryptodev: remove AAD from authentication structure") Signed-o

Re: [dpdk-dev] [PATCH 04/13] pci: use scan_mode configuration

2017-07-13 Thread Gaëtan Rivet
On Tue, Jul 11, 2017 at 07:25:03PM -0400, Jan Blunck wrote: > When scanning/probing devices the bus should use its configuration instead > of looking at the devargs->type field. > With this patch, how do you probe a device that was previously blacklisted? The answers I see to this question are p

Re: [dpdk-dev] [PATCH v3 07/11] linuxapp/eal: auto detect iova mode

2017-07-13 Thread santosh
On Thursday 13 July 2017 04:59 PM, Hemant Agrawal wrote: > On 7/11/2017 11:46 AM, Santosh Shukla wrote: >> - Moving late bus scanning to up..just after eal_parsing. >> - Auto detect iova mapping mode, based on the result of >> rte_bus_scan_iommu_class. >> >> Signed-off-by: Santosh Shukla >> Sig

Re: [dpdk-dev] [PATCH v3 ] ethdev: introduce lock-free txq capability flag

2017-07-13 Thread santosh
On Monday 10 July 2017 10:29 PM, Jerin Jacob wrote: > Introducing the DEV_TX_OFFLOAD_MT_LOCKFREE TX capability flag. > if a PMD advertises DEV_TX_OFFLOAD_MT_LOCKFREE capable, multiple threads > can invoke rte_eth_tx_burst() concurrently on the same tx queue without > SW lock. This PMD feature will

Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

2017-07-13 Thread Jerin Jacob
-Original Message- > Date: Thu, 13 Jul 2017 08:56:48 +0530 > From: "Rao, Nikhil" > To: Jerin Jacob > CC: gage.e...@intel.com, dev@dpdk.org, tho...@monjalon.net, > bruce.richard...@intel.com, harry.van.haa...@intel.com, > hemant.agra...@nxp.com, nipun.gu...@nxp.com, narender.vang...@inte

Re: [dpdk-dev] [PATCH 09/13] devargs: parse "bus=" argument

2017-07-13 Thread Jan Blunck
On Thu, Jul 13, 2017 at 9:40 AM, Gaëtan Rivet wrote: > I still disagree with parsing the body of devargs to retrieve bus > information. They should not be mixed. > I agree. I always said that it should be passed explicitly. If we agree on this I'll fix the signature of rte_eal_devargs_parse() acc

Re: [dpdk-dev] [PATCH 04/13] pci: use scan_mode configuration

2017-07-13 Thread Jan Blunck
On Thu, Jul 13, 2017 at 1:59 PM, Gaëtan Rivet wrote: > On Tue, Jul 11, 2017 at 07:25:03PM -0400, Jan Blunck wrote: >> When scanning/probing devices the bus should use its configuration instead >> of looking at the devargs->type field. >> > > With this patch, how do you probe a device that was prev

Re: [dpdk-dev] [PATCH v3 3/8] devargs: introduce insert function

2017-07-13 Thread Jan Blunck
On Wed, Jul 12, 2017 at 1:20 PM, Gaëtan Rivet wrote: > On Wed, Jul 12, 2017 at 04:20:48AM -0400, Jan Blunck wrote: >> On Tue, Jul 11, 2017 at 7:25 PM, Gaetan Rivet wrote: >> > Some buses will operate either in whitelist or blacklist mode. >> > This mode is currently passed down by the rte_eal_dev

Re: [dpdk-dev] [PATCH 04/13] pci: use scan_mode configuration

2017-07-13 Thread Thomas Monjalon
13/07/2017 21:42, Jan Blunck: > On Thu, Jul 13, 2017 at 1:59 PM, Gaëtan Rivet wrote: > > On Tue, Jul 11, 2017 at 07:25:03PM -0400, Jan Blunck wrote: > >> When scanning/probing devices the bus should use its configuration instead > >> of looking at the devargs->type field. > >> > > > > With this pa

Re: [dpdk-dev] [RFC v2] ethdev: add IF-MIB attributes implementation

2017-07-13 Thread Stephen Hemminger
On Thu, 13 Jul 2017 17:24:27 +0100 Reshma Pattan wrote: > diff --git a/lib/librte_ether/rte_ethdev_pci.h > b/lib/librte_ether/rte_ethdev_pci.h > index 69aab03..f829407 100644 > --- a/lib/librte_ether/rte_ethdev_pci.h > +++ b/lib/librte_ether/rte_ethdev_pci.h > @@ -37,6 +37,7 @@ > #include > #

Re: [dpdk-dev] [PATCH] vhost: fix vhost-user init failed

2017-07-13 Thread Yuanhan Liu
On Mon, Jul 10, 2017 at 11:48:27AM +0200, Jens Freimann wrote: > >@@ -668,7 +668,7 @@ rte_vhost_driver_register(const char *path, uint64_t > >flags) > > } > > > > vhost_user.vsockets[vhost_user.vsocket_cnt++] = vsocket; > >- > >+goto out; > >out_mutex: > > if (pthread_mutex_destroy

[dpdk-dev] Issue with TX of Jumbo frames on 10G interfaces ONLY

2017-07-13 Thread Yeddula, Avinash
Hi All, In order to support Jumbo frames for our application, I made the below changes. The intention, here is to use "linked-mbufs instead of using 1 single 9k MBUF". With the below changes, I'm able to send/receive 9k size frames on 1G interfaces successfully. No issues what so ever with 1

[dpdk-dev] [PATCH] test/crypto: fix ARMV8 crypto performance test application

2017-07-13 Thread Srisivasubramanian S
Session was null as test_crypto_session not initialised. Fixes: b3bbd9e5f265 ("cryptodev: support device independent sessions") Signed-off-by: Srisivasubramanian S --- test/test/test_cryptodev_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test/test_cryptodev_pe

Re: [dpdk-dev] [PATCH v3] ether: add support for vtune task tracing

2017-07-13 Thread Jerin Jacob
-Original Message- > Date: Tue, 11 Jul 2017 20:48:06 +0300 > From: ilia.kura...@intel.com > To: dev@dpdk.org > CC: jerin.ja...@caviumnetworks.com, konstantin.anan...@intel.com, > keith.wi...@intel.com, dmitry.gala...@intel.com, Ilia Kurakin > > Subject: [PATCH v3] ether: add support for

[dpdk-dev] FW: [PATCH v3] test: add delay time in test alarm

2017-07-13 Thread Yang, Qiming
Hi, Thomas Can this patch be applied? Qiming > -Original Message- > From: Chen, Jing D > Sent: Wednesday, July 12, 2017 9:31 AM > To: Yang, Qiming ; dev@dpdk.org > Cc: Wu, Jingjing > Subject: RE: [PATCH v3] test: add delay time in test alarm > > > > > > > > -Original Message- >

[dpdk-dev] [PATCH] net/i40e: add invalid queue id checking for VF

2017-07-13 Thread Beilei Xing
There's only invalid queue id checking for PF, this patch adds invalid queue id checking for VF. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_flow.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index 9

[dpdk-dev] [PATCH v2] net/i40e: add checking invalid VF queue id for FDIR

2017-07-13 Thread Beilei Xing
There's only invalid queue id checking for PF when creating FDIR rules, this patch adds checking invalid queue id for VF. Signed-off-by: Beilei Xing --- v2 changes: - rework commit log. drivers/net/i40e/i40e_flow.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers