[dpdk-dev] [PATCH] net/virtio: fix coding style

2017-07-16 Thread Tiwei Bie
Make the code more readable. No functional change. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_rxtx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index fbc96df..e30377c 100644 --- a/driver

[dpdk-dev] [PATCH] net/ixgbe: remove an unnecessary goto

2017-07-16 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- drivers/net/ixgbe/ixgbe_tm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_tm.c b/drivers/net/ixgbe/ixgbe_tm.c index b76d186..cdcf45c 100644 --- a/drivers/net/ixgbe/ixgbe_tm.c +++ b/drivers/net/ixgbe/ixgbe_tm.c @@ -1029,8 +1029,6 @@ ixgb

[dpdk-dev] [PATCH] net/i40e: remove an unnecessary goto

2017-07-16 Thread Tiwei Bie
Signed-off-by: Tiwei Bie --- drivers/net/i40e/i40e_tm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/i40e/i40e_tm.c b/drivers/net/i40e/i40e_tm.c index 56013b1..d90313a 100644 --- a/drivers/net/i40e/i40e_tm.c +++ b/drivers/net/i40e/i40e_tm.c @@ -962,8 +962,6 @@ i40e_hierarchy_c

[dpdk-dev] [PATCH] net/ixgbe: add queue index check in filter

2017-07-16 Thread Wei Zhao
Add queue index check when create filter rule, or filter with invalid queue id can be created successfully. Signed-off-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_flow.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/ne

[dpdk-dev] [PATCH] net/ixgbe: add queue index check in filter

2017-07-16 Thread Wei Zhao
From: root Add queue index check when create filter rule, or filter with invalid queue id can be created successfully. Signed-off-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_flow.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_flow.c

Re: [dpdk-dev] Need help on dpdk packet-generator

2017-07-16 Thread harshavardhan Reddy
EAL: No free hugepages reported in hugepages-1048576kB EAL: No free hugepages reported in hugepages-2048kB PANIC in rte_eal_init(): Means you have to allocate hugepages before starting this app. http://dpdk.org/doc/guides/linux_gsg/sys_reqs.html#running-dpdk-applications On Mon, Jul 17, 2017 at

Re: [dpdk-dev] [PATCH] net/ixgbe: fix Rx/Tx queue interrupt for x550 devices

2017-07-16 Thread Yang, Zhiyong
Hi,Qiming: > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang > Sent: Monday, July 17, 2017 1:35 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Lu, Wenzhuo ; Yang, Qiming > > Subject: [dpdk-dev] [PATCH] net/ixgbe: fix Rx/Tx queue interrupt for x550 > dev

[dpdk-dev] Need help on dpdk packet-generator

2017-07-16 Thread Mahesh Ishwar Mathad
Hi team, Kernel Version : 4.5 DPDK Version :16.07.2 PKT-GEN Version: 3.3.4 I am trying to execute dpdk pkt-gen application to generator L2 traffic on DPDK ports. But I am getting errors while executing command : ./app/pktgen -c 0x7 -n 3 -- -p 0x1 -P -m "[1:2].0" Since I am allocating

[dpdk-dev] [PATCH] examples/qos_sched: fix core limit for lower num of lcore

2017-07-16 Thread Hemant Agrawal
APP_MAX_LCORES is hardcoded as 64. This will cause build err when RTE_MAX_LCORE is less then 64. "args.c:127:22: error: iteration 8 invokes undefined behavior [-Werror=aggressive-loop-optimizations] if (cfg->lcore_role[i] == ROLE_RTE) ~~~^~~ args.c:126:2: note: within

[dpdk-dev] [PATCH] net/ixgbe: fix Rx/Tx queue interrupt for x550 devices

2017-07-16 Thread Qiming Yang
x550 devices not do interrupt vector mapping before enable Rx/Tx queue interrupt, makes interrupt mode can't work neither with igb_uio or VFIO. Fixes: d2e72774e58c ("ixgbe/base: support X550") Signed-off-by: Qiming Yang --- drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++- 1 file changed, 2 insertions(

[dpdk-dev] [PATCH] net/ixgbe: fix drop action for signature match

2017-07-16 Thread Qi Zhang
Drop action is not supported by signature match, should return error when try to create a signature match flow with drop action. Fixes: a948d33bc05a ("net/ixgbe: enable signature match for consistent API") Signed-off-by: Qi Zhang --- drivers/net/ixgbe/ixgbe_flow.c | 8 1 file changed,

[dpdk-dev] Rx Can't receive anymore packet after received 1.5 billion packet.

2017-07-16 Thread vuonglv
Hi DPDK team, Sorry when I send this email to both of group users and dev. But I have big problem: Rx core on my application can not receive anymore packet after I did the stress test to it (~1 day Rx core received ~ 1.5 billion packet). Rx core still alive but didn't receive any packet and did

[dpdk-dev] [problem] a problem about rx-tx queues when using VF interface of x553 10G-ethernet NIC

2017-07-16 Thread Bill Bonaparte
Hi all, I encounter a problem that there are two of the four queues working for dpdk-apps when using the VF interface of intel x553 10G-ethernet NIC. Straightly speaking, there are no packets coming into the last two queues, no matter what packets I send to the dpdk-apps. I checked

Re: [dpdk-dev] [PATCH v7 0/5] Support NIC reset and keep same port id

2017-07-16 Thread Thomas Monjalon
13/07/2017 17:53, Wei Dai: > chagnes: > v7: > add description of NIC reset in doc/poll_mode_drv.rst Thanks for bringing more explanations. The texts have to be reviewed by a native english speaker. About the organization of the doc, it is good to explain the VF use case in the prog guide as you

Re: [dpdk-dev] [PATCH v5 0/7] service cores: cover letter

2017-07-16 Thread Thomas Monjalon
Hi Harry, I like the service concept! 11/07/2017 16:19, Harry van Haaren: > Harry van Haaren (7): > service cores: header and implementation > service cores: EAL init changes > service cores: coremask parsing > service cores: add unit tests > event/sw: enable SW PMD with service capabil

Re: [dpdk-dev] [PATCH v10 03/11] net/failsafe: add fail-safe PMD

2017-07-16 Thread Gaëtan Rivet
On Sun, Jul 16, 2017 at 05:58:13PM +0200, Thomas Monjalon wrote: > Hi Gaetan, > > 15/07/2017 19:57, Gaetan Rivet: > > +#. Start testpmd. The slave device should be blacklisted from normal EAL > > + operations to avoid probing it twice when in PCI blacklist mode. > > + > > + .. code-block:: con

Re: [dpdk-dev] [PATCH v10 03/11] net/failsafe: add fail-safe PMD

2017-07-16 Thread Thomas Monjalon
Hi Gaetan, 15/07/2017 19:57, Gaetan Rivet: > +#. Start testpmd. The slave device should be blacklisted from normal EAL > + operations to avoid probing it twice when in PCI blacklist mode. > + > + .. code-block:: console > + > + $RTE_TARGET/build/app/testpmd -c 0xff -n 4 \ > + -w '

Re: [dpdk-dev] [PATCH 00/19] cleanup duplicate includes

2017-07-16 Thread Thomas Monjalon
11/07/2017 20:55, Stephen Hemminger: > Using a simple script (in first patch), discovered that there was > lots of #include file sloppiness in DPDK. This patch series > fixes everything but base drivers and examples. > > Stephen Hemminger (19): > devtools: add simple script to find duplicate in

Re: [dpdk-dev] [RFC 00/14] link status API improvement and bugfixes

2017-07-16 Thread Andrew Rybchenko
On 07/14/2017 09:30 PM, Stephen Hemminger wrote: While writing new driver, I noticed a lot of unnecessary duplication of code in drivers for handling the eth_dev link status information. While consolidating this, it also became obvious that several drivers have bugs in this are because they don't

Re: [dpdk-dev] [RFC 09/14] sfc: use new rte_eth_link helpers

2017-07-16 Thread Andrew Rybchenko
On 07/14/2017 09:30 PM, Stephen Hemminger wrote: Use the new API (_rte_eth_link_update) to handle link status update. ALso fixes a bug where this driver was not returning -1 when link status changed. It is really good that you raise it, since: - as far as I can see the return value of the li

Re: [dpdk-dev] [RFC 01/14] ethdev: add link status read/write functions

2017-07-16 Thread Andrew Rybchenko
On 07/14/2017 09:30 PM, Stephen Hemminger wrote: Many drivers are all doing copy/paste of the same code to atomicly update the link status. Reduce duplication, and allow for future changes by having common function for this. Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.c |

Re: [dpdk-dev] [RFC 13/14] szedata: use _rte_eth_link_update

2017-07-16 Thread Andrew Rybchenko
On 07/14/2017 09:30 PM, Stephen Hemminger wrote: Yet another driver which was not returing correct value on link change. Signed-off-by: Stephen Hemminger --- drivers/net/szedata2/rte_eth_szedata2.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/driver

Re: [dpdk-dev] [RFC 02/14] virtio: use eth_link_read/write (and bug fix)

2017-07-16 Thread Andrew Rybchenko
On 07/14/2017 09:30 PM, Stephen Hemminger wrote: Use the new code in ethdev to handle link status update. Also, virtio was not correctly setting the autoneg flags since its speed should be marked as fixed. Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_ethdev.c | 54 +-

[dpdk-dev] TX descriptor is not done

2017-07-16 Thread Alexander Kiselev
Hi. Exсume me for bothering you here in the dev list. I was trying to get some help in the users list, but the only answer I got suggested to post here. I am facing "TX descriptor is not done" problem that appears when I am using two i40e ports (x710-da2 nic) as slave ports of a bonding (lacp

Re: [dpdk-dev] [PATCH v2] cryptodev: fix KASUMI F9 expected parameters

2017-07-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Friday, July 14, 2017 5:17 PM > To: De Lara Guarch, Pablo ; Doherty, > Declan ; Jain, Deepak K > ; Griffin, John ; Kusztal, > ArkadiuszX > Cc: dev@dpdk.org > Subject: RE: [PATCH v2] cryptodev: fix KASUMI F9 expected parameters > > Hi Pab

Re: [dpdk-dev] [PATCH 0/5] Fix crypto PMDs documentation

2017-07-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, July 13, 2017 6:37 AM > To: Doherty, Declan ; Trahe, Fiona > ; Griffin, John ; Jain, > Deepak K > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > Subject: [PATCH 0/5] Fix crypto PMDs documentation > > Patchset with some f

[dpdk-dev] [PATCH v2] net/tap: remove Linux version check

2017-07-16 Thread Raslan Darawsheh
Remove checks of Linux kernel version in order to support kernel with backported features. the expected behavior with a kernel that doesn't support flower and other bits is the following: -flow validate can return successfully -flow create using the same rule fails. Using the "rem