Re: [dpdk-dev] [PATCH v2] net/i40e: fix PF notify issue when VF not up

2017-07-28 Thread Li, Xiaoyun
1. At first, I add vs state modification as follows, but it will show a warning when I check the patch. The warning says that usually the else after return or break would not be executed. if (i >= VFRESET_MAX_WAIT_CNT) { PMD_DRV_LOG(ERR, "VF reset timeout")

[dpdk-dev] [PATCH] app/crypto-perf: fix csv output

2017-07-28 Thread Pablo de Lara
When using CSV, the output of the throughput performance numbers was not correct, representing decimal numbers incorrectly. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara --- app/test-crypto-perf/cperf_test_throug

[dpdk-dev] [PATCH v3] net/i40e: fix PF notify issue when VF not up

2017-07-28 Thread Xiaoyun Li
This patch stops PF from sending messages to inactive VF and modifies VF state to active when VF reset is completed. Fixes: 4861cde46116 ("i40e: new poll mode driver") Cc: sta...@dpdk.org Signed-off-by: Xiaoyun Li --- drivers/net/i40e/i40e_pf.c | 29 - 1 file changed

[dpdk-dev] [disscussion] mlx4 driver MLX4_PMD_TX_MP_CACHE default vaule

2017-07-28 Thread chenchanghu
Hi, When I used the mlx4 pmd, I meet a problem about MLX4_PMD_TX_MP_CACHE vaule, which is used for Memory pool to Memory region translation. The detail test is descripted below. 1.Test environmemt infomation: a. Linux distribution: CentOS b. dpdk version: dpdk-16.04 c. Ethernet dev

[dpdk-dev] [PATCH] lib/librte_ether: remove the repeat code

2017-07-28 Thread Zhiyong Yang
The code eth_dev->intr_handle = &dev->intr_handle; has duplicate code in the function rte_eth_copy_pci_info(), remove it here. Signed-off-by: Zhiyong Yang --- lib/librte_ether/rte_ethdev_pci.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_ether/rte_ethdev_pci.h b/lib/librte_ethe

Re: [dpdk-dev] [disscussion] mlx4 driver MLX4_PMD_TX_MP_CACHE default vaule

2017-07-28 Thread Adrien Mazarguil
Hi, On Fri, Jul 28, 2017 at 07:58:48AM +, chenchanghu wrote: > Hi, > When I used the mlx4 pmd, I meet a problem about > MLX4_PMD_TX_MP_CACHE vaule, which is used for Memory pool to Memory region > translation. The detail test is descripted below. > 1.Test environmemt infomation: >

Re: [dpdk-dev] [PATCH] Fix bash path in shebangs

2017-07-28 Thread Bruce Richardson
On Thu, Jul 27, 2017 at 02:41:46PM -0600, asom...@gmail.com wrote: > From: Alan Somers > > "/bin/bash" is a Linuxism. "/usr/bin/env bash" is portable. > > Signed-off-by: Alan Somers > --- > examples/performance-thread/l3fwd-thread/test.sh | 2 +- > usertools/dpdk-setup.sh

Re: [dpdk-dev] [PATCH] doc: add testpmd bonding mode 4 aggregators mode

2017-07-28 Thread Mcnamara, John
> -Original Message- > From: Mrzyglod, DanielX T > Sent: Thursday, July 27, 2017 7:41 AM > To: Mcnamara, John ; Doherty, Declan > > Cc: dev@dpdk.org; Mrzyglod, DanielX T > Subject: [PATCH] doc: add testpmd bonding mode 4 aggregators mode > > Add testpmd commands for setting aggregators

Re: [dpdk-dev] [PATCH 1/3] doc: move kernel drivers to a new chapter

2017-07-28 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Wednesday, July 26, 2017 6:18 PM > To: tho...@monjalon.net > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 1/3] doc: move kernel drivers to a new chapter > > The UIO and VFIO sections should

Re: [dpdk-dev] [PATCH 2/3] doc: cleanup UIO hard requirement

2017-07-28 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Wednesday, July 26, 2017 6:18 PM > To: tho...@monjalon.net > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 2/3] doc: cleanup UIO hard requirement > > UIO is not a must for all PMDs. > > Cle

[dpdk-dev] [PATCH] app/crypto-perf: display error message

2017-07-28 Thread Pablo de Lara
If the crypto operation pool size is too small, the pool might run out of operations, if all the crypto operations are still being used and have not been freed. To inform the user about this, the application should display an error message, asking the user to increase the pool size through the app

Re: [dpdk-dev] [PATCH 3/3] doc: move i40e specific to i40e guide

2017-07-28 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Wednesday, July 26, 2017 6:18 PM > To: tho...@monjalon.net > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 3/3] doc: move i40e specific to i40e guide > > The Linux Getting Started Guide cont

Re: [dpdk-dev] [disscussion] mlx4 driver MLX4_PMD_TX_MP_CACHE default vaule

2017-07-28 Thread chenchanghu
Hi Adrien, Thanks very much! I have got the question about MLX4_PMD_TX_MP_CACHE value, we will modify this value to suit our applications. However, in the 2 clients or more clients test, we found that the function 'txq->if_qp->send_pending' and 'txq->if_qp->send_flush(txq->qp)' in 'mlx4_tx

[dpdk-dev] [PATCH] config: add openssl in arm64-dpaa2-linuxapp-gcc

2017-07-28 Thread Akhil Goyal
Signed-off-by: Akhil Goyal --- config/defconfig_arm64-dpaa2-linuxapp-gcc | 6 ++ 1 file changed, 6 insertions(+) diff --git a/config/defconfig_arm64-dpaa2-linuxapp-gcc b/config/defconfig_arm64-dpaa2-linuxapp-gcc index 8a42944..7de2d4e 100644 --- a/config/defconfig_arm64-dpaa2-linuxapp-gcc +

[dpdk-dev] [PATCH] crypto/openssl: performance improvements

2017-07-28 Thread Akhil Goyal
key and algo are added in the openssl ctx during session initialization instead of adding it for each packet. Also in case of HMAC the openssl APIs HMAC_XXX give better performance for all HMAC cases. Signed-off-by: Akhil Goyal --- Tested on arm and xeon machines autotest passed with no issues,

[dpdk-dev] [PATCH] crypto/openssl: add openssl path for cross compile

2017-07-28 Thread Akhil Goyal
OPENSSL_PATH should be defined in case openssl driver is cross compiled Signed-off-by: Akhil Goyal --- doc/guides/cryptodevs/openssl.rst | 4 drivers/crypto/openssl/Makefile | 1 + mk/rte.app.mk | 2 +- 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/

Re: [dpdk-dev] [PATCH] net/i40e: add VLAN stripping support for VF

2017-07-28 Thread Olivier MATZ
Hi Beilei, On Tue, 4 Jul 2017 16:26:16 +0800 Beilei Xing wrote: > VLAN stripping configuration is supported only for DPDK PF > previously. Since kernel PF supports VLAN stripping now, this > patch adds VLAN stripping support for both DPDK PF and kernel > PF. > If I understand correctly, enabl

Re: [dpdk-dev] [PATCH v4 1/3] doc: update mlx5 supported features

2017-07-28 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Wednesday, July 26, 2017 6:03 PM > To: tho...@monjalon.net > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v4 1/3] doc: update mlx5 supported features > > Supported features which were not i

Re: [dpdk-dev] [PATCH v4 2/3] doc: update release notes for mlx driver

2017-07-28 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Wednesday, July 26, 2017 6:03 PM > To: tho...@monjalon.net > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v4 2/3] doc: update release notes for mlx > driver > > Signed-off-by: Shahaf Shuler

Re: [dpdk-dev] [PATCH] crypto/openssl: performance improvements

2017-07-28 Thread De Lara Guarch, Pablo
Hi Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Friday, July 28, 2017 12:08 PM > To: dev@dpdk.org; Doherty, Declan > Cc: De Lara Guarch, Pablo ; > hemant.agra...@nxp.com; Akhil Goyal > Subject: [PATCH] crypto/openssl: performance improvements > >

Re: [dpdk-dev] [disscussion] mlx4 driver MLX4_PMD_TX_MP_CACHE default vaule

2017-07-28 Thread Adrien Mazarguil
Hi Changhu, On Fri, Jul 28, 2017 at 10:52:45AM +, chenchanghu wrote: > Hi Adrien, > Thanks very much! I have got the question about MLX4_PMD_TX_MP_CACHE value, > we will modify this value to suit our applications. > However, in the 2 clients or more clients test, we found that the functi

Re: [dpdk-dev] [PATCH] crypto/openssl: performance improvements

2017-07-28 Thread Akhil Goyal
On 7/28/2017 5:28 PM, De Lara Guarch, Pablo wrote: Hi Akhil, -Original Message- From: Akhil Goyal [mailto:akhil.go...@nxp.com] Sent: Friday, July 28, 2017 12:08 PM To: dev@dpdk.org; Doherty, Declan Cc: De Lara Guarch, Pablo ; hemant.agra...@nxp.com; Akhil Goyal Subject: [PATCH] crypto

Re: [dpdk-dev] [PATCH] crypto/openssl: performance improvements

2017-07-28 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Akhil Goyal > Sent: Friday, July 28, 2017 1:03 PM > To: De Lara Guarch, Pablo ; > dev@dpdk.org; Doherty, Declan > Cc: hemant.agra...@nxp.com > Subject: Re: [dpdk-dev] [PATCH] crypto/openssl: performance > improve

Re: [dpdk-dev] [PATCH v4 3/3] doc: update mlx guides

2017-07-28 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Wednesday, July 26, 2017 6:03 PM > To: tho...@monjalon.net > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v4 3/3] doc: update mlx guides > > Update the guides with: >* New supported fea

Re: [dpdk-dev] [PATCH v2] doc: add how to enable empty cycles profiling

2017-07-28 Thread Mcnamara, John
> -Original Message- > From: Kurakin, Ilia > Sent: Wednesday, July 26, 2017 4:20 PM > To: dev@dpdk.org > Cc: jerin.ja...@caviumnetworks.com; Mcnamara, John > ; Galanov, Dmitry ; > Kurakin, Ilia > Subject: [PATCH v2] doc: add how to enable empty cycles profiling > > From: Ilia Kurakin >

[dpdk-dev] [PATCH] doc: add cryptodev sample code

2017-07-28 Thread Pablo de Lara
In order to illustrate in a simple way how to use the cryptodev API to perform a basic crypto operation, sample code has been added in the Programmer's Guide. Signed-off-by: Pablo de Lara --- doc/guides/prog_guide/cryptodev_lib.rst | 206 1 file changed, 206 inse

Re: [dpdk-dev] [PATCH] cryptodev: deprecate rte_cryptodev_create_vdev()

2017-07-28 Thread Sergio Gonzalez Monroy
On 12/07/2017 21:15, Jan Blunck wrote: This function is an alias for rte_vdev_init() which is scheduled to move out of the rte_eal library. Lets deprecate this function to be able to remove it from the cryptodev library in 17.11. Signed-off-by: Jan Blunck --- Acked-by: Sergio Gonzalez Monroy

[dpdk-dev] [PATCH v5 1/3] doc: update mlx5 supported features

2017-07-28 Thread Shahaf Shuler
Supported features which were not included: * ARMv8 * Extended stats Not supported features which were wrongly included: * Inner L3 checksum * Inner L4 checksum Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil Acked-by: John McNamara --- doc/guides/n

[dpdk-dev] [PATCH v5 2/3] doc: update release notes for mlx driver

2017-07-28 Thread Shahaf Shuler
Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil Acked-by: John McNamara --- doc/guides/rel_notes/release_17_08.rst | 126 + 1 file changed, 126 insertions(+) diff --git a/doc/guides/rel_notes/release_17_08.rst b/doc/guides/re

[dpdk-dev] [PATCH v5 3/3] doc: update mlx guides

2017-07-28 Thread Shahaf Shuler
Update the guides with: * New supported features. * Supported OFED and FW versions. * Quick start guide. * Performance tunning guide. Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- On v5: - Fix doc compliation error. - replace hint with note

Re: [dpdk-dev] [PATCH] cryptodev: deprecate rte_cryptodev_create_vdev()

2017-07-28 Thread De Lara Guarch, Pablo
> -Original Message- > From: Jan Blunck [mailto:jblu...@gmail.com] On Behalf Of Jan Blunck > Sent: Wednesday, July 12, 2017 9:16 PM > To: dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > > Subject: [PATCH] cryptodev: deprecate rte_cryptodev_create_vdev() > > This function is

Re: [dpdk-dev] [PATCH] doc: add cryptodev sample code

2017-07-28 Thread Mcnamara, John
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Friday, July 28, 2017 7:03 AM > To: Mcnamara, John ; Doherty, Declan > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH] doc: add cryptodev sample code > > In order to illustrate in a simple way how to use the crypto

Re: [dpdk-dev] [PATCH] doc: complete sample command line for crypto PMDs

2017-07-28 Thread Mcnamara, John
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, July 26, 2017 2:00 AM > To: Mcnamara, John ; Doherty, Declan > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH] doc: complete sample command line for crypto PMDs > > Documentation of some virtual crypto P

Re: [dpdk-dev] [PATCH v2 6/6] doc: announce ethdev API change for detach flag

2017-07-28 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gaetan Rivet > Sent: Wednesday, July 26, 2017 2:36 PM > To: dev@dpdk.org > Cc: Gaetan Rivet > Subject: [dpdk-dev] [PATCH v2 6/6] doc: announce ethdev API change for > detach flag > > The flag RTE_ETH_DEV_DETACHA

Re: [dpdk-dev] [PATCH 5/7] doc: list NPAR as supported feature in qede

2017-07-28 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Rasesh Mody > Sent: Monday, July 24, 2017 11:19 AM > To: dev@dpdk.org > Cc: Shahed Shaikh ; dept-engdpdk...@cavium.com > Subject: [dpdk-dev] [PATCH 5/7] doc: list NPAR as supported feature in > qede > > From: Sha

[dpdk-dev] [pktgen PATCH] Fix dpdk-version.sh on Fedora

2017-07-28 Thread Timothy Redaelli
Fedora and RHEL dpdk-devel package installs rte_version.h inside $RTE_INCLUDE (/usr/include/dpdk) instead of $RTE_SDK Signed-off-by: Timothy Redaelli --- tools/dpdk-version.sh | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/tools/dpdk-version.sh b/tools/dpdk

Re: [dpdk-dev] [PATCH] doc: complete sample command line for crypto PMDs

2017-07-28 Thread De Lara Guarch, Pablo
> -Original Message- > From: Mcnamara, John > Sent: Friday, July 28, 2017 4:53 PM > To: De Lara Guarch, Pablo ; Doherty, > Declan > Cc: dev@dpdk.org > Subject: RE: [PATCH] doc: complete sample command line for crypto PMDs > > > > > -Original Message- > > From: De Lara Guarch,

Re: [dpdk-dev] [PATCH] doc: add cryptodev sample code

2017-07-28 Thread De Lara Guarch, Pablo
> -Original Message- > From: Mcnamara, John > Sent: Friday, July 28, 2017 4:52 PM > To: De Lara Guarch, Pablo ; Doherty, > Declan > Cc: dev@dpdk.org > Subject: RE: [PATCH] doc: add cryptodev sample code > > > > > -Original Message- > > From: De Lara Guarch, Pablo > > Sent: Fri

Re: [dpdk-dev] [PATCH] app/crypto-perf: display error message

2017-07-28 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Friday, July 28, 2017 3:15 AM > To: Doherty, Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > Subject: [PATCH] app/crypto-perf: display error message > > If the crypto operation pool size is too small, the pool might run ou

Re: [dpdk-dev] [PATCH] app/crypto-perf: fix csv output

2017-07-28 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Friday, July 28, 2017 12:33 AM > To: Doherty, Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] app/crypto-perf: fix csv output > > When usi

Re: [dpdk-dev] [pktgen PATCH] Fix dpdk-version.sh on Fedora

2017-07-28 Thread Wiles, Keith
> On Jul 28, 2017, at 11:08 AM, Timothy Redaelli wrote: > > Fedora and RHEL dpdk-devel package installs rte_version.h inside > $RTE_INCLUDE (/usr/include/dpdk) instead of $RTE_SDK > > Signed-off-by: Timothy Redaelli > --- > tools/dpdk-version.sh | 16 ++-- > 1 file changed, 10 inser

[dpdk-dev] [pull-request] next-crypto 17.08 rc3

2017-07-28 Thread Pablo de Lara
The following changes since commit 67c4b6db68e199247b5dbd63f560582640b180bf: version: 17.08-rc2 (2017-07-21 19:33:46 +0300) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-crypto for you to fetch changes up to ff217c51ab2482b10cbc4c3b8db3adbb4de9dbc2: doc: add

[dpdk-dev] [PATCH] app/testpmd: fix error prompt

2017-07-28 Thread Wenzhuo Lu
There're '\n's missing, so the error prompt looks bad. Fixes: 3af72783d1fd ("app/testpmd: configure event display") Fixes: 7ee3e9446290 ("app/testpmd: add --flow-isolate-all option") CC: sta...@dpdk.org Signed-off-by: Wenzhuo Lu --- app/test-pmd/parameters.c | 6 +++--- 1 file changed, 3 insert

[dpdk-dev] [PATCH] ethdev: remove wrong doxygen for rte_eth_copy_pci_info().

2017-07-28 Thread Rami Rosen
This trivial patch removes wrong comments about the return value of the rte_eth_copy_pci_info() method. The method return value type is void. Signed-off-by: Rami Rosen --- lib/librte_ether/rte_ethdev_pci.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/librte_ether/rte_ethdev_pci.h b/

[dpdk-dev] [PATCH] net/virtio: fix MAC addr not correct read

2017-07-28 Thread Jianfeng Tan
When virtio-net devices are bound to uio_pci_generic, we get the wrong mac addr by virtio PMD. The wrong mac addr is a addr that is 4-byte left shift of the correct addr. It's a regression bug introduced by the cleanup patch below. The condition of if we set use_msix should be if msix is actually

[dpdk-dev] 答复: [disscussion] mlx4 driver MLX4_PMD_TX_MP_CACHE default value

2017-07-28 Thread chenchanghu
Hi Adrien, Your suggestion is appreciated *very much*. 1) We can make sure the 5ms time spent is in the function send_pending()/send_flush(). The test code is below remarks: gettimeofday(&start_time, NULL); err = txq->if_qp->send_pending (txq->qp,