Re: [dpdk-dev] using rte_flow via tespmd with Intel X552

2017-08-01 Thread TETSURO NAKAMURA
Wei Zhao - san (Cc'ing Wenzhuo - san) According to the e-mail thread [1] in April, you have a document about command format when creating flows on ixgbe NIC. I would appreciate your uploading that document to community or could you just share it with me via an e-mail ?? [1] http://dpdk.org/ml/a

[dpdk-dev] traffic management based on dpdk qos_sched

2017-08-01 Thread Mahesh Ishwar Mathad
Hi all, I am trying to run dpdk qos_sched sample application, through that application how can i manage network traffic. Is there any change has to be done to profile.cfg ? Regards, Mahesh Mathad. %MCEPASTEBIN% Disclaimer:- The information contained in this electronic message and any att

Re: [dpdk-dev] [PATCH] net/vmxnet3: restore correct filtering

2017-08-01 Thread Shrikrishna Khare
On Mon, 24 Jul 2017, Charles (Chas) Williams wrote: > We should only restore shadow_vfta when hw_vlan_filter is active. > Otherwise, we should restore the previous filtering behavior. > > Fixes: f003fc383487("vmxnet3: enable vlan filtering") > Cc: sta...@dpdk.org > > Signed-off-by: Chas Willia

Re: [dpdk-dev] [PATCH] net/vmxnet3: restore correct filtering

2017-08-01 Thread Shrikrishna Khare
On Tue, 1 Aug 2017, Charles (Chas) Williams wrote: > > > On 08/01/2017 07:41 PM, Shrikrishna Khare wrote: > > > > > > On Mon, 24 Jul 2017, Charles (Chas) Williams wrote: > > > > > We should only restore shadow_vfta when hw_vlan_filter is active. > > > Otherwise, we should restore the previo

Re: [dpdk-dev] [PATCH] net/i40e: add VLAN stripping support for VF

2017-08-01 Thread Xing, Beilei
Hi Olivier, > -Original Message- > From: Olivier MATZ [mailto:olivier.m...@6wind.com] > Sent: Friday, July 28, 2017 7:43 PM > To: Xing, Beilei > Cc: Wu, Jingjing ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40e: add VLAN stripping support for VF > > Hi Beilei, > > On Tue, 4 Ju

Re: [dpdk-dev] [PATCH] net/vmxnet3: restore correct filtering

2017-08-01 Thread Charles (Chas) Williams
On 08/01/2017 07:41 PM, Shrikrishna Khare wrote: On Mon, 24 Jul 2017, Charles (Chas) Williams wrote: We should only restore shadow_vfta when hw_vlan_filter is active. Otherwise, we should restore the previous filtering behavior. Fixes: f003fc383487("vmxnet3: enable vlan filtering") Cc: sta

Re: [dpdk-dev] [PATCH] net/vmxnet3: restore correct filtering

2017-08-01 Thread Shrikrishna Khare
On Mon, 24 Jul 2017, Charles (Chas) Williams wrote: > We should only restore shadow_vfta when hw_vlan_filter is active. > Otherwise, we should restore the previous filtering behavior. > > Fixes: f003fc383487("vmxnet3: enable vlan filtering") > Cc: sta...@dpdk.org > > Signed-off-by: Chas Willia

[dpdk-dev] [PATCH] net/i40e: fix data segment buffer length

2017-08-01 Thread Qi Zhang
Buffer length be configured for each data segment should not exceed the requested value, or device may fill data that exceed the boundary of memory that be reserved. Fixes: 4861cde46116 ("i40e: new poll mode driver") Cc: sta...@dpdk.org Signed-off-by: Jianfeng Tan Signed-off-by: Qi Zhang --- d

[dpdk-dev] [PATCH] eal: read and parse device option separately

2017-08-01 Thread Gaetan Rivet
When the EAL parses the common options given to the application, not all subsystems are available. Some device drivers are registered afterward upon dynamic plugin loading. Devices using those drivers are thus unable to be parsed by any drivers and are rejected. Store the device options first and

Re: [dpdk-dev] [PATCH v1 03/48] net/mlx4: check max number of ports dynamically

2017-08-01 Thread Legacy, Allain
> -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Tuesday, August 01, 2017 12:54 PM <...> > @@ -5946,12 +5949,11 @@ mlx4_arg_parse(const char *key, const char *val, > void *out) > return -errno; > } > if (strcmp(MLX4_PMD_PORT

[dpdk-dev] [PATCH v1 48/48] net/mlx4: clean up includes and comments

2017-08-01 Thread Adrien Mazarguil
Add missing includes and sort them, then update/remove comments around them for consistency. Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 40 --- drivers/net/mlx4/mlx4.h | 3 +-- drivers/net/mlx4/mlx4_flow.c | 5 + drivers/net/

[dpdk-dev] [PATCH v1 47/48] net/mlx4: separate memory management functions

2017-08-01 Thread Adrien Mazarguil
No impact on functionality. Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/Makefile | 1 + drivers/net/mlx4/mlx4.c| 115 - drivers/net/mlx4/mlx4.h| 8 +- drivers/net/mlx4/mlx4_mr.c | 183 4 files changed, 188 ins

[dpdk-dev] [PATCH v1 46/48] net/mlx4: rename private functions in flow API

2017-08-01 Thread Adrien Mazarguil
While internal static functions do not cause link time conflicts, this differentiates them from their mlx5 PMD counterparts while debugging. No impact on functionality. Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 4 ++-- drivers/net/mlx4/mlx4_flow.c | 30 +++-

[dpdk-dev] [PATCH v1 45/48] net/mlx4: group flow API handlers in common file

2017-08-01 Thread Adrien Mazarguil
Only the common filter control operation callback needs to be exposed. No impact on functionality. Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 48 +- drivers/net/mlx4/mlx4_flow.c | 72 --- drivers/net/mlx4/mlx4_f

[dpdk-dev] [PATCH v1 44/48] net/mlx4: separate Rx configuration functions

2017-08-01 Thread Adrien Mazarguil
Private functions are now prefixed with "mlx4_" to prevent them from conflicting with their mlx5 PMD counterparts at link time. No impact on functionality. Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/Makefile| 1 + drivers/net/mlx4/mlx4.c | 592 +-

[dpdk-dev] [PATCH v1 43/48] net/mlx4: separate Tx configuration functions

2017-08-01 Thread Adrien Mazarguil
Private functions are now prefixed with "mlx4_" to prevent them from conflicting with their mlx5 PMD counterparts at link time. No impact on functionality. Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/Makefile| 1 + drivers/net/mlx4/mlx4.c | 421 +-

[dpdk-dev] [PATCH v1 40/48] net/mlx4: separate Rx/Tx definitions

2017-08-01 Thread Adrien Mazarguil
Except for a minor documentation update on internal structure definitions to make them more Doxygen-friendly, there is no impact on functionality. Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 13 +--- drivers/net/mlx4/mlx4.h | 69 +--- drivers/net/mlx

[dpdk-dev] [PATCH v1 39/48] net/mlx4: separate interrupt handling

2017-08-01 Thread Adrien Mazarguil
Private functions are now prefixed with "mlx4_" to prevent them from conflicting with their mlx5 PMD counterparts at link time. No impact on functionality. Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/Makefile| 1 + drivers/net/mlx4/mlx4.c | 340 +-

[dpdk-dev] [PATCH v1 42/48] net/mlx4: separate device control functions

2017-08-01 Thread Adrien Mazarguil
Private functions are now prefixed with "mlx4_" to prevent them from conflicting with their mlx5 PMD counterparts at link time. No impact on functionality. Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/Makefile | 1 + drivers/net/mlx4/mlx4.c| 752 +-

[dpdk-dev] [PATCH v1 41/48] net/mlx4: separate Rx/Tx functions

2017-08-01 Thread Adrien Mazarguil
This commit groups all data plane functions (Rx/Tx) into a separate file and adjusts header files accordingly. Private functions are now prefixed with "mlx4_" to prevent them from conflicting with their mlx5 PMD counterparts at link time. No impact on functionality. Signed-off-by: Adrien Mazargu

[dpdk-dev] [PATCH v1 36/48] net/mlx4: refactor interrupt FD settings

2017-08-01 Thread Adrien Mazarguil
File descriptors used for interrupts processing must be made non-blocking. Doing so as soon as they are opened instead of waiting until they are needed is more efficient as it avoids performing redundant system calls and run through their associated error-handling code later on. Signed-off-by: Ad

[dpdk-dev] [PATCH v1 33/48] net/mlx4: separate debugging macros

2017-08-01 Thread Adrien Mazarguil
The new definitions also rely on the existing DPDK logging subsystem instead of using fprintf() directly. Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 2 +- drivers/net/mlx4/mlx4.h | 46 --- drivers/net/mlx4/mlx4_flow.c | 1 + drivers/net/mlx4/mlx4

[dpdk-dev] [PATCH v1 35/48] net/mlx4: rename alarm field

2017-08-01 Thread Adrien Mazarguil
Make clear this field is related to interrupt handling. Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 14 +++--- drivers/net/mlx4/mlx4.h | 6 +++--- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index 7

[dpdk-dev] [PATCH v1 37/48] net/mlx4: clean up interrupt functions prototypes

2017-08-01 Thread Adrien Mazarguil
The naming scheme for these functions is overly verbose and not accurate enough, with too many "handler" functions that are difficult to differentiate (e.g. mlx4_dev_link_status_handler(), mlx4_dev_interrupt_handler() and priv_dev_status_handler()). This commit renames them and removes the unneces

[dpdk-dev] [PATCH v1 38/48] net/mlx4: compact interrupt functions

2017-08-01 Thread Adrien Mazarguil
Link status (LSC) and removal (RMV) interrupts share a common handler and are toggled simultaneously from common install/uninstall functions. Four additional wrapper functions (two for each interrupt type) are currently necessary because the PMD maintains an internal configuration state for interr

[dpdk-dev] [PATCH v1 34/48] net/mlx4: use a single interrupt handle

2017-08-01 Thread Adrien Mazarguil
The reason one interrupt handle is currently used for RMV/LSC events and another one for Rx traffic is because these come from distinct file descriptors. This can be simplified however as Rx interrupt file descriptors are stored elsewhere and are registered separately. Modifying the interrupt han

[dpdk-dev] [PATCH v1 31/48] net/mlx4: remove mbuf macro definitions

2017-08-01 Thread Adrien Mazarguil
These were originally used for compatibility between DPDK releases when this PMD was built out of tree. Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 29 ++--- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/drivers/net/mlx4/mlx4.c b/driver

[dpdk-dev] [PATCH v1 30/48] net/mlx4: remove unnecessary wrapper functions

2017-08-01 Thread Adrien Mazarguil
Wrapper functions whose main purpose was to take a lock on the private structure are no longer needed since this lock does not exist anymore. Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 61 -- drivers/net/mlx4/mlx4_flow.c | 106 +---

[dpdk-dev] [PATCH v1 32/48] net/mlx4: use standard macro to get array size

2017-08-01 Thread Adrien Mazarguil
Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 11 ++- drivers/net/mlx4/mlx4.h | 3 --- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index 0f1169c..f4dc67f 100644 --- a/drivers/net/mlx4/mlx4.c +++ b/driver

[dpdk-dev] [PATCH v1 29/48] net/mlx4: remove control path locks

2017-08-01 Thread Adrien Mazarguil
Concurrent use of various control path functions (e.g. configuring a queue and destroying it simultaneously) may lead to undefined behavior. PMD are not supposed to protect themselves from misbehaving applications, and mlx4 is one of the few with internal locks on most control path operations. Thi

[dpdk-dev] [PATCH v1 28/48] net/mlx4: clean up coding style inconsistencies

2017-08-01 Thread Adrien Mazarguil
This addresses badly formatted comments and needless empty lines before refactoring functions into different files. Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 89 --- drivers/net/mlx4/mlx4_flow.c | 1 - 2 files changed, 36 insertions(+

[dpdk-dev] [PATCH v1 26/48] net/mlx4: simplify link update function

2017-08-01 Thread Adrien Mazarguil
Returning a different value when the current link status differs from the previous one was probably useful at some point in the past but is now meaningless; this value is ignored both internally (mlx4 PMD) and externally (ethdev wrapper). Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4

[dpdk-dev] [PATCH v1 27/48] net/mlx4: standardize on negative errno values

2017-08-01 Thread Adrien Mazarguil
Due to its reliance on system calls, the mlx4 PMD uses positive errno values internally and negative ones at the ethdev API border. Although most internal functions are documented, this mixed design is unusual and prone to mistakes (e.g. flow API implementation uses negative values exclusively). S

[dpdk-dev] [PATCH v1 25/48] net/mlx4: revert fast Verbs interface for Rx

2017-08-01 Thread Adrien Mazarguil
This reverts commit acac55f164128fc76da8d93cae1e8c1e560e99f6. "Fast Verbs" is a nonstandard experimental interface that must be reverted for compatibility reasons. Its replacement is slower but temporary, performance will be restored by a subsequent commit through an enhanced data path implementat

[dpdk-dev] [PATCH v1 24/48] net/mlx4: revert fast Verbs interface for Tx

2017-08-01 Thread Adrien Mazarguil
This reverts commit 9980f81dc2623291b89cf1c281a6a9f116fd2394. "Fast Verbs" is a nonstandard experimental interface that must be reverted for compatibility reasons. Its replacement is slower but temporary, performance will be restored by a subsequent commit through an enhanced data path implementat

[dpdk-dev] [PATCH v1 22/48] net/mlx4: revert resource domain support

2017-08-01 Thread Adrien Mazarguil
This reverts commit 3e49c148b715c3c0a12c1200295bb9b312f7028e. Resource domains are not part of the standard Verbs interface. The performance improvement they bring will be restored later through a different data path implementation. This commit makes the PMD not rely on the non-standard QP alloca

[dpdk-dev] [PATCH v1 23/48] net/mlx4: revert multicast echo prevention

2017-08-01 Thread Adrien Mazarguil
This reverts commit 8b3ffe95e75d6d305992505005cbb95969874a15. Multicast loopback prevention is not part of the standard Verbs interface. Remove it temporarily. Signed-off-by: Moti Haimovsky Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/Makefile | 6 +- drivers/net/mlx4/mlx4.c | 7

[dpdk-dev] [PATCH v1 21/48] net/mlx4: use standard QP attributes

2017-08-01 Thread Adrien Mazarguil
The Verbs API used to set QP attributes is deprecated. Revert to the standard API since it actually supports the remaining ones. Signed-off-by: Moti Haimovsky Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletio

[dpdk-dev] [PATCH v1 19/48] net/mlx4: drop scatter/gather support

2017-08-01 Thread Adrien Mazarguil
The Verbs API used to implement Tx and Rx burst functions is deprecated. Drop scatter/gather support to ease refactoring while maintaining basic single-segment Rx/Tx functionality in the meantime. Signed-off-by: Adrien Mazarguil --- doc/guides/nics/features/mlx4.ini | 1 - doc/guides/nics/mlx4

[dpdk-dev] [PATCH v1 20/48] net/mlx4: drop inline receive support

2017-08-01 Thread Adrien Mazarguil
The Verbs API used to implement inline receive is deprecated. Support will be added back after refactoring the PMD. Signed-off-by: Moti Haimovsky Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 52 drivers/net/mlx4/mlx4.h | 1 - 2 file

[dpdk-dev] [PATCH v1 18/48] net/mlx4: drop packet type recognition support

2017-08-01 Thread Adrien Mazarguil
The Verbs API used to implement packet type recognition is deprecated. Support will be added back after refactoring the PMD. Signed-off-by: Adrien Mazarguil --- doc/guides/nics/features/mlx4.ini | 1 - drivers/net/mlx4/mlx4.c | 70 +- 2 files changed, 2

[dpdk-dev] [PATCH v1 17/48] net/mlx4: drop checksum offloads support

2017-08-01 Thread Adrien Mazarguil
The Verbs API used to implement Tx and Rx checksum offloads is deprecated. Support for these will be added back after refactoring the PMD. Signed-off-by: Adrien Mazarguil --- doc/guides/nics/features/mlx4.ini | 4 -- doc/guides/nics/mlx4.rst | 2 - drivers/net/mlx4/mlx4.c |

[dpdk-dev] [PATCH v1 16/48] net/mlx4: drop RSS support

2017-08-01 Thread Adrien Mazarguil
The Verbs RSS API used in this PMD is now obsolete. It is superseded by an enhanced API with fewer constraints already used in the mlx5 PMD. Drop RSS support in preparation for a major refactoring. The ability to configure several Rx queues is retained, these can be targeted directly by creating s

[dpdk-dev] [PATCH v1 13/48] net/mlx4: drop MAC flows affecting all Rx queues

2017-08-01 Thread Adrien Mazarguil
Configuring several Rx queues enables RSS, which causes an additional special parent queue to be created to manage them. MAC flows are associated with the queue supposed to receive packets; either the parent one in case of RSS or the single orphan otherwise. For historical reasons the current imp

[dpdk-dev] [PATCH v1 15/48] net/mlx4: revert RSS parent queue refactoring

2017-08-01 Thread Adrien Mazarguil
This reverts commit ff00a0dc5600dbb0a29e4aa7fa4b078f98c7a360. Support for several RSS parent queues was necessary to implement the RSS flow rule action, dropped in a prior commit. Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 332 +++--- driv

[dpdk-dev] [PATCH v1 14/48] net/mlx4: revert flow API RSS support

2017-08-01 Thread Adrien Mazarguil
This reverts commit d7769c7c08cc08a9d1bc4e40b95524d9697707d9. Existing RSS features rely on experimental Verbs provided by Mellanox OFED. In order to replace this dependency with standard distribution packages, RSS support must be temporarily removed to be re-implemented using a different API. R

[dpdk-dev] [PATCH v1 12/48] net/mlx4: remove MAC address configuration support

2017-08-01 Thread Adrien Mazarguil
Only the default port MAC address remains and is not configurable. This is done in preparation for a major refactoring. Signed-off-by: Adrien Mazarguil --- doc/guides/nics/features/mlx4.ini | 2 - doc/guides/nics/mlx4.rst | 1 - drivers/net/mlx4/mlx4.c | 322 --

[dpdk-dev] [PATCH v1 11/48] net/mlx4: remove VLAN filter support

2017-08-01 Thread Adrien Mazarguil
This is done in preparation for a major refactoring. Signed-off-by: Adrien Mazarguil --- doc/guides/nics/features/mlx4.ini | 1 - doc/guides/nics/mlx4.rst | 1 - drivers/net/mlx4/mlx4.c | 206 +++-- drivers/net/mlx4/mlx4.h | 13 +-- 4

[dpdk-dev] [PATCH v1 10/48] net/mlx4: remove allmulti and promisc support

2017-08-01 Thread Adrien Mazarguil
This is done in preparation for a major refactoring. Signed-off-by: Adrien Mazarguil --- doc/guides/nics/features/mlx4.ini | 2 - doc/guides/nics/mlx4.rst | 2 - drivers/net/mlx4/mlx4.c | 311 - drivers/net/mlx4/mlx4.h | 4 - 4 f

[dpdk-dev] [PATCH v1 09/48] net/mlx4: remove Tx inline compilation option

2017-08-01 Thread Adrien Mazarguil
This should be a run-time parameter. Signed-off-by: Adrien Mazarguil --- config/common_base| 1 - drivers/net/mlx4/Makefile | 4 drivers/net/mlx4/mlx4.c | 6 -- drivers/net/mlx4/mlx4.h | 4 4 files changed, 15 deletions(-) diff --git a/config/common_base b/config/commo

[dpdk-dev] [PATCH v1 08/48] net/mlx4: remove scatter mode compilation option

2017-08-01 Thread Adrien Mazarguil
This option both sets the maximum number of segments for Rx/Tx packets and whether scattered mode is supported at all. This commit removes the latter as well as configuration file exposure since the most appropriate value should be decided at run-time. Signed-off-by: Adrien Mazarguil --- config/

[dpdk-dev] [PATCH v1 07/48] net/mlx4: remove soft counters compilation option

2017-08-01 Thread Adrien Mazarguil
Software counters are mandatory since hardware counters are not implemented. Signed-off-by: Adrien Mazarguil --- config/common_base| 1 - doc/guides/nics/mlx4.rst | 6 -- drivers/net/mlx4/Makefile | 4 drivers/net/mlx4/mlx4.c | 37 - dri

[dpdk-dev] [PATCH v1 06/48] net/mlx4: remove useless code

2017-08-01 Thread Adrien Mazarguil
Less code makes refactoring easier. No impact on functionality. Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 17 + drivers/net/mlx4/mlx4.h | 12 2 files changed, 1 insertion(+), 28 deletions(-) diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4

[dpdk-dev] [PATCH v1 05/48] net/mlx4: remove secondary process support

2017-08-01 Thread Adrien Mazarguil
Current implementation is partial (Tx only), not convenient to use and not of primary concern. Remove this feature before refactoring the PMD. Signed-off-by: Adrien Mazarguil --- doc/guides/nics/features/mlx4.ini | 1 - doc/guides/nics/mlx4.rst | 2 - drivers/net/mlx4/mlx4.c

[dpdk-dev] [PATCH v1 04/48] net/mlx4: remove useless compilation checks

2017-08-01 Thread Adrien Mazarguil
Verbs support for RSS, inline receive and extended device query calls has not been optional for a while. Their absence is untested and is therefore unsupported. Remove the related compilation checks and assume Mellanox OFED is up to date, as described in the documentation. Use this opportunity to

[dpdk-dev] [PATCH v1 02/48] net/mlx4: remove limitation on number of instances

2017-08-01 Thread Adrien Mazarguil
The seemingly artificial limitation on the maximum number of instances for this PMD is an historical leftover that predates its first public release. It was used as a workaround to support multiple physical ports on a PCI device exposing a single bus address when mlx4 was implemented directly as a

[dpdk-dev] [PATCH v1 03/48] net/mlx4: check max number of ports dynamically

2017-08-01 Thread Adrien Mazarguil
Use maximum number reported by hardware capabilities as replacement for the static check on MLX4_PMD_MAX_PHYS_PORTS. Cc: Gaëtan Rivet Cc: Allain Legacy Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 43 +-- drivers/net/mlx4/mlx4.h | 3 ---

[dpdk-dev] [PATCH v1 01/48] net/mlx4: add consistency to copyright notices

2017-08-01 Thread Adrien Mazarguil
Copyright lasts long enough not to require notices to be updated yearly. The current approach of updating them occasionally while working on unrelated tasks should be deprecated in favor of dedicated commits updating all files at once when necessary. Standardize on a single year per copyright own

[dpdk-dev] [PATCH v1 00/48] net/mlx4: trim and refactor entire PMD

2017-08-01 Thread Adrien Mazarguil
The main purpose of this large series is to relieve the mlx4 PMD from its dependency on Mellanox OFED to instead rely on the standard rdma-core package provided by Linux distributions. While compatibility with Mellanox OFED is preserved, all nonstandard functionality has to be stripped from the PM

Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

2017-08-01 Thread Jerin Jacob
> > > > > > Instead of > > > == > > > rte_event_eth_rx_adapter_create() > > > rte_event_eth_rx_adapter_get_info(); > > > rte_event_eth_rx_adapter_configure(); > > > rte_event_eth_rx_adapter_queue_add(); > > > == > > > > > > How about ? > > > == > > > > > > rte_event_eth_rx_adapter_get_info(uint8

[dpdk-dev] [PATCH] net/mlx5: fix buffer address posting in vectorized Rx

2017-08-01 Thread Yongseok Koh
The data_off field of newly allocated mbufs is stale data. This shouldn't be used in calculating Rx address for device when posting free buffers. RTE_PKTMBUF_HEADROOM should be used instead and data_off of a mbuf will be reset on packet reception anyway. Fixes: 6cb559d67b83 ("net/mlx5: add vectori

[dpdk-dev] [PATCH v6] doc: document NIC features

2017-08-01 Thread Ferruh Yigit
Document NIC features, add more information about them and add more implementation related support. Signed-off-by: Ferruh Yigit Signed-off-by: John McNamara Reviewed-by: Andrew Rybchenko --- Cc: Olivier Matz v6: * Apply code review comments and minor updates. * Add new feature "Lock-free Tx q

Re: [dpdk-dev] [PATCH] net/vmxnet3: restore correct filtering

2017-08-01 Thread Shrikrishna Khare
On Sun, 30 Jul 2017, Thomas Monjalon wrote: > 24/07/2017 16:22, Charles (Chas) Williams: > > We should only restore shadow_vfta when hw_vlan_filter is active. > > Otherwise, we should restore the previous filtering behavior. > > > > Fixes: f003fc383487("vmxnet3: enable vlan filtering") > > Cc:

Re: [dpdk-dev] [PATCH v1] app/testpmd: fix Tx first with LSC interrupt

2017-08-01 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt > Sent: Tuesday, July 25, 2017 11:28 AM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Hunt, David > > Subject: [dpdk-dev] [PATCH v1] app/testpmd: fix Tx first with LSC interrupt > > The lsc_interrupt flag i

Re: [dpdk-dev] [PATCH] librte_cfgfile: add section num entries by index

2017-08-01 Thread Thomas Monjalon
01/08/2017 14:36, Dumitrescu, Cristian: > > 27/04/2017 08:51, Guduri Prathyusha: > > > rte_cfgfile_section_num_entries_by_index() is added to get the number > > of > > > entries of a section when multiple sections of the same name are > > > present. > > > > > > Signed-off-by: Guduri Prathyusha > >

Re: [dpdk-dev] [PATCH] librte_cfgfile: add section num entries by index

2017-08-01 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, July 31, 2017 10:10 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Guduri Prathyusha > > Subject: Re: [dpdk-dev] [PATCH] librte_cfgfile: add section num entries by > index > > 27/04/2017 08:51,

Re: [dpdk-dev] [PATCH v2] cryptodev: fix NULL pointer dereference

2017-08-01 Thread Thomas Monjalon
01/08/2017 12:48, De Lara Guarch, Pablo: > From: Gonzalez Monroy, Sergio > > On 01/08/2017 10:35, Thomas Monjalon wrote: > > > 01/08/2017 10:13, Sergio Gonzalez Monroy: > > >> On 31/07/2017 20:33, Thomas Monjalon wrote: > > >>> 31/07/2017 11:18, Pablo de Lara: > > When register a crypto driver

Re: [dpdk-dev] [PATCH] net/mlx4: workaround to verbs wrong error return

2017-08-01 Thread Matan Azrad
> -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Tuesday, August 1, 2017 1:51 PM > To: Matan Azrad > Cc: dev@dpdk.org; Thomas Monjalon ; Olga Shern > ; sta...@dpdk.org > Subject: Re: [PATCH] net/mlx4: workaround to verbs wrong error return > > Hi

[dpdk-dev] [PATCH 5/5] net/mlx5: remove old MLNX_OFED 3.3 verification

2017-08-01 Thread Nelio Laranjeiro
This version of MLNX_OFED is no more supported. Signed-off-by: Nelio Laranjeiro Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index 2392be5..e89aba8 100644 --- a/drivers/net/mlx5/mlx5

[dpdk-dev] [PATCH 4/5] net/mlx5: remove multiple drop RSS queues

2017-08-01 Thread Nelio Laranjeiro
Since MLNX_OFED 4.1 this code is no more useful. Signed-off-by: Nelio Laranjeiro Acked-by: Shahaf Shuler --- drivers/net/mlx5/Makefile| 5 drivers/net/mlx5/mlx5_flow.c | 55 ++-- 2 files changed, 17 insertions(+), 43 deletions(-) diff --git a/d

[dpdk-dev] [PATCH 2/5] net/mlx5: remove pdentic pragma

2017-08-01 Thread Nelio Laranjeiro
Those are useless since DPDK headers have been cleaned up. Signed-off-by: Nelio Laranjeiro Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5.c | 7 --- drivers/net/mlx5/mlx5.h | 7 --- drivers/net/mlx5/mlx5_ethdev.c | 7 --- drivers/net/mlx5/mlx5_fdir

[dpdk-dev] [PATCH 0/5] net/mlx5: cleanups

2017-08-01 Thread Nelio Laranjeiro
This Series make some cleanup in mlx5 PMD by removing useless code or non working code. This series apply on top of: [PATCH 0/5] net/mlx5: enable/disable vPMD and some cleanups Specifically on patch: net/mlx5: cleanup Rx ring in free functions http://dpdk.org/dev/patchwork/patch/27303/ Nelio La

[dpdk-dev] [PATCH 3/5] net/mlx5: fix non working secondary process by removing it

2017-08-01 Thread Nelio Laranjeiro
Secondary process is a copy/paste of the mlx4 drivers, it was never tested and it even segfault at the secondary process start in the mlx5_pci_probe(). This makes more sense to wipe this non working feature to re-write a working and functional version. Fixes: a48deada651b ("mlx5: allow operation

[dpdk-dev] [PATCH 1/5] net/mlx5: remove flow drop useless if branches

2017-08-01 Thread Nelio Laranjeiro
Those two if statements are useless as there is a verification on the drop field of the flow to jump to the end of the function just above. Signed-off-by: Nelio Laranjeiro Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_flow.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net

Re: [dpdk-dev] [PATCH] vhost: make the page logging atomic

2017-08-01 Thread Maxime Coquelin
On 08/01/2017 11:01 AM, Tiwei Bie wrote: Each dirty page logging operation should be atomic. But it's not atomic in current implementation. So it's possible that some dirty pages can't be logged successfully when different threads try to log different pages into the same byte of the log buffer

Re: [dpdk-dev] [PATCH] net/mlx5: fix MTU update

2017-08-01 Thread Nélio Laranjeiro
On Tue, Aug 01, 2017 at 12:11:16PM +0200, Adrien Mazarguil wrote: > On Tue, Aug 01, 2017 at 09:55:57AM +0200, Nelio Laranjeiro wrote: > > Changing the MTU is not related to changing the number of segments, > > activating or not the multi-segment support should be handled by the > > application. > >

Re: [dpdk-dev] [PATCH] net/mlx4: workaround to verbs wrong error return

2017-08-01 Thread Adrien Mazarguil
Hi Matan, (snipping a bit of unnecessary context) On Tue, Aug 01, 2017 at 10:12:29AM +, Matan Azrad wrote: [...] > > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] [...] > > On Mon, Jul 31, 2017 at 04:56:33PM +, Matan Azrad wrote: [...] > > > > From: Adrien Mazarguil [mailto:a

Re: [dpdk-dev] [PATCH v2] cryptodev: fix NULL pointer dereference

2017-08-01 Thread De Lara Guarch, Pablo
> -Original Message- > From: Gonzalez Monroy, Sergio > Sent: Tuesday, August 1, 2017 11:18 AM > To: Thomas Monjalon > Cc: De Lara Guarch, Pablo ; > dev@dpdk.org > Subject: Re: [PATCH v2] cryptodev: fix NULL pointer dereference > > On 01/08/2017 10:35, Thomas Monjalon wrote: > > 01/08/20

Re: [dpdk-dev] [PATCH v2 0/4] cryptodev vdev changes for -rc2

2017-08-01 Thread De Lara Guarch, Pablo
> -Original Message- > From: jblu...@gmail.com [mailto:jblu...@gmail.com] On Behalf Of Jan > Blunck > Sent: Thursday, July 27, 2017 8:32 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Doherty, Declan > Subject: Re: [PATCH v2 0/4] cryptodev vdev changes for -rc2 > > On Wed, Jul 19,

Re: [dpdk-dev] [PATCH v2] cryptodev: fix NULL pointer dereference

2017-08-01 Thread Sergio Gonzalez Monroy
On 01/08/2017 10:35, Thomas Monjalon wrote: 01/08/2017 10:13, Sergio Gonzalez Monroy: On 31/07/2017 20:33, Thomas Monjalon wrote: 31/07/2017 11:18, Pablo de Lara: When register a crypto driver, a cryptodev driver structure was being allocated, using malloc. Since this call may fail, it is safe

Re: [dpdk-dev] [PATCH v5] doc: document NIC features

2017-08-01 Thread Ferruh Yigit
On 7/26/2017 6:08 AM, Shreyansh Jain wrote: > Hello Ferruh, > > Some trivial comments inline. Hi Shreyansh, Thank you for the review, I will send a new version. Thanks, ferruh > > On Thursday 20 July 2017 02:53 PM, Ferruh Yigit wrote: >> Document NIC features, add more information about them

Re: [dpdk-dev] [PATCH] net/mlx4: workaround to verbs wrong error return

2017-08-01 Thread Matan Azrad
Hi Adrien > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Tuesday, August 1, 2017 12:42 PM > To: Matan Azrad > Cc: dev@dpdk.org; Thomas Monjalon ; Olga Shern > ; sta...@dpdk.org > Subject: Re: [PATCH] net/mlx4: workaround to verbs wrong error retu

Re: [dpdk-dev] [PATCH] net/mlx5: fix MTU update

2017-08-01 Thread Adrien Mazarguil
On Tue, Aug 01, 2017 at 09:55:57AM +0200, Nelio Laranjeiro wrote: > Changing the MTU is not related to changing the number of segments, > activating or not the multi-segment support should be handled by the > application. > > Fixes: 9964b965ad69 ("net/mlx5: re-add Rx scatter support") > Cc: sta...

Re: [dpdk-dev] [dpdk-users] DPDK16.11.2 LTS: i40e PMD fails to start X710 port

2017-08-01 Thread Dumitru Ceara
Hi all, I'm reposting the following bug report on the dev mailing list. I was wondering if this is a known issue or not. In our application code, the only way to overcome the problem is to introduce a delay after each rte_eth_dev_stop/start call when using X710 cards. However, this seems like a h

Re: [dpdk-dev] [PATCH] net/mlx4: workaround to verbs wrong error return

2017-08-01 Thread Adrien Mazarguil
Hi Matan, On Mon, Jul 31, 2017 at 04:56:33PM +, Matan Azrad wrote: > Hi Adrien > > > -Original Message- > > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > > Sent: Monday, July 31, 2017 5:17 PM > > To: Matan Azrad > > Cc: dev@dpdk.org; Thomas Monjalon ; Olga Shern > > ;

Re: [dpdk-dev] [PATCH v2] cryptodev: fix NULL pointer dereference

2017-08-01 Thread Thomas Monjalon
01/08/2017 10:13, Sergio Gonzalez Monroy: > On 31/07/2017 20:33, Thomas Monjalon wrote: > > 31/07/2017 11:18, Pablo de Lara: > >> When register a crypto driver, a cryptodev driver > >> structure was being allocated, using malloc. > >> Since this call may fail, it is safer to allocate > >> this memo

Re: [dpdk-dev] [dpdk-users] If shared libraries are used vdev doesn't work anymore

2017-08-01 Thread Thomas Monjalon
01/08/2017 10:17, Gaëtan Rivet: > Hi, > > On Mon, Jul 31, 2017 at 10:23:50PM +0200, Thomas Monjalon wrote: > > 31/07/2017 16:58, Dirk-Holger Lenz: > > > If dpdk is built with 'CONFIG_RTE_BUILD_SHARED_LIB=y' then > > > using the vdev feature (args: e.g. -c 3 -n 4 --vdev="crypto_openssl") > > > the

[dpdk-dev] [PATCH] vhost: make the page logging atomic

2017-08-01 Thread Tiwei Bie
Each dirty page logging operation should be atomic. But it's not atomic in current implementation. So it's possible that some dirty pages can't be logged successfully when different threads try to log different pages into the same byte of the log buffer concurrently. This patch fixes this issue. F

Re: [dpdk-dev] [PATCH] doc: add tested Intel platforms with Intel NICs

2017-08-01 Thread Mcnamara, John
> -Original Message- > From: Pei, Yulong > Sent: Monday, July 31, 2017 5:30 AM > To: dev@dpdk.org > Cc: Mcnamara, John ; tho...@monjalon.net > Subject: [PATCH] doc: add tested Intel platforms with Intel NICs > > Add tested Intel platforms with Intel NICs to the release note. > > Signed-

Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

2017-08-01 Thread Rao, Nikhil
On 7/29/2017 8:42 PM, Jerin Jacob wrote: -Original Message- Date: Thu, 27 Jul 2017 16:28:29 +0530 From: "Rao, Nikhil" To: Jerin Jacob CC: gage.e...@intel.com, dev@dpdk.org, tho...@monjalon.net, bruce.richard...@intel.com, harry.van.haa...@intel.com, hemant.agra...@nxp.com, nipun.gu

[dpdk-dev] [PATCH] app/crypto-perf: fix incorrect IV allocation

2017-08-01 Thread Pablo de Lara
Memory is reserved after each crypto operation for the necessary IV(s), which could be for cipher, authentication or AEAD algorithms. However, for AEAD algorithms (such as AES-GCM), this memory was not being reserved, leading to potential memory overflow. Fixes: 8a5b494a7f99 ("app/test-crypto-perf

Re: [dpdk-dev] [dpdk-users] If shared libraries are used vdev doesn't work anymore

2017-08-01 Thread Gaëtan Rivet
Hi, On Mon, Jul 31, 2017 at 10:23:50PM +0200, Thomas Monjalon wrote: > 31/07/2017 16:58, Dirk-Holger Lenz: > > If dpdk is built with 'CONFIG_RTE_BUILD_SHARED_LIB=y' then > > using the vdev feature (args: e.g. -c 3 -n 4 --vdev="crypto_openssl") > > the rte_eal_init() returns 'ERROR: failed to parse

Re: [dpdk-dev] [PATCH v2] cryptodev: fix NULL pointer dereference

2017-08-01 Thread Sergio Gonzalez Monroy
On 31/07/2017 20:33, Thomas Monjalon wrote: 31/07/2017 11:18, Pablo de Lara: When register a crypto driver, a cryptodev driver structure was being allocated, using malloc. Since this call may fail, it is safer to allocate this memory statically in each PMD, so driver registration will never fail

[dpdk-dev] [PATCH 5/5] net/mlx5: cleanup Rx ring in free functions

2017-08-01 Thread Nelio Laranjeiro
Vector PMD returns buffers to the application without setting the pointers in the Rx queue to null nor allocating them. When the PMD cleanup the ring it needs to take a special care to those pointers to not free the mbufs before the application have used them nor if the application have already fr

[dpdk-dev] [PATCH 4/5] net/mlx5: prepare vector Rx ring at setup time

2017-08-01 Thread Nelio Laranjeiro
To use the vector, it needs to add to the PMD Rx mbuf ring four extra mbuf to avoid memory corruption. This additional mbuf are added on dev_start() whereas all other mbuf are allocated on queue setup. This patch brings this allocation back to the same place as other mbuf allocation. Signed-off-

[dpdk-dev] [PATCH 0/5] net/mlx5: enable/disable vPMD and some cleanups

2017-08-01 Thread Nelio Laranjeiro
This series add more information and flexibility to the user to use or not the vPMD. An information will be printed to inform the user which Tx/Rx function have been automatically selected in addition, new device parameters are added to disable Tx/Rx vector (see device documentation for more detai

[dpdk-dev] [PATCH 2/5] net/mlx5: add parameters to enable/disable vector code

2017-08-01 Thread Nelio Laranjeiro
Helps to deactivate the vector function without re-compiling the code. Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- doc/guides/nics/mlx5.rst | 14 ++ drivers/net/mlx5/mlx5.c | 23 +++ drivers/net/mlx5/mlx5.h |

[dpdk-dev] [PATCH 3/5] net/mlx5: avoid reusing old queue's mbuf on reconfigure

2017-08-01 Thread Nelio Laranjeiro
This patch prepare the merge of fake mbuf allocation needed by the vector code with rxq_alloc_elts() where all mbuf of the queues should be allocated. Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxq.c | 21 - 1 file changed, 4 insertions(

[dpdk-dev] [PATCH 1/5] net/mlx5: warn which Tx/Rx burst function is selected

2017-08-01 Thread Nelio Laranjeiro
Warning the user helps to understand way the performances does not match the expected values. Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_ethdev.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b

[dpdk-dev] [PATCH] net/mlx5: fix MTU update

2017-08-01 Thread Nelio Laranjeiro
Changing the MTU is not related to changing the number of segments, activating or not the multi-segment support should be handled by the application. Fixes: 9964b965ad69 ("net/mlx5: re-add Rx scatter support") Cc: sta...@dpdk.org Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drive

  1   2   >